* [PATCH 00/29] treewide: Convert comma separated statements
@ 2020-08-25 4:55 Joe Perches
2020-08-25 4:56 ` [PATCH 08/29] dma-buf: Avoid " Joe Perches
` (3 more replies)
0 siblings, 4 replies; 18+ messages in thread
From: Joe Perches @ 2020-08-25 4:55 UTC (permalink / raw)
To: Jiri Kosina, oprofile-list, linux-ide, drbd-dev, linux-media,
dri-devel, linaro-mm-sig, intel-gfx, linux-hwmon, linux-input,
linux-bcache, netdev, linuxppc-dev, linux-arm-kernel,
linux-fsdevel, reiserfs-devel, linux-nfs
Cc: linux-doc, linux-kernel, linux-alpha, linux-ia64, sparclinux,
linux-block, linux-mtd, linux-s390, linux-scsi, devel,
linux-fbdev, linux-pm, linux-kselftest
There are many comma separated statements in the kernel.
See:https://lore.kernel.org/lkml/alpine.DEB.2.22.394.2008201856110.2524@hadrien/
Convert the comma separated statements that are in if/do/while blocks
to use braces and semicolons.
Many comma separated statements still exist but those are changes for
another day.
Joe Perches (29):
coding-style.rst: Avoid comma statements
alpha: Avoid comma separated statements
ia64: Avoid comma separated statements
sparc: Avoid comma separated statements
ata: Avoid comma separated statements
drbd: Avoid comma separated statements
lp: Avoid comma separated statements
dma-buf: Avoid comma separated statements
drm/gma500: Avoid comma separated statements
drm/i915: Avoid comma separated statements
hwmon: (scmi-hwmon): Avoid comma separated statements
Input: MT - Avoid comma separated statements
bcache: Avoid comma separated statements
media: Avoid comma separated statements
mtd: Avoid comma separated statements
8390: Avoid comma separated statements
fs_enet: Avoid comma separated statements
wan: sbni: Avoid comma separated statements
s390/tty3270: Avoid comma separated statements
scai/arm: Avoid comma separated statements
media: atomisp: Avoid comma separated statements
video: fbdev: Avoid comma separated statements
fuse: Avoid comma separated statements
reiserfs: Avoid comma separated statements
lib/zlib: Avoid comma separated statements
lib: zstd: Avoid comma separated statements
ipv6: fib6: Avoid comma separated statements
sunrpc: Avoid comma separated statements
tools: Avoid comma separated statements
Documentation/process/coding-style.rst | 17 +
arch/alpha/kernel/pci_iommu.c | 8 +-
arch/alpha/oprofile/op_model_ev4.c | 22 +-
arch/alpha/oprofile/op_model_ev5.c | 8 +-
arch/ia64/kernel/smpboot.c | 7 +-
arch/sparc/kernel/smp_64.c | 7 +-
drivers/ata/pata_icside.c | 21 +-
drivers/block/drbd/drbd_receiver.c | 6 +-
drivers/char/lp.c | 6 +-
drivers/dma-buf/st-dma-fence.c | 7 +-
drivers/gpu/drm/gma500/mdfld_intel_display.c | 44 ++-
drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 8 +-
drivers/gpu/drm/i915/gt/intel_gt_requests.c | 6 +-
.../gpu/drm/i915/gt/selftest_workarounds.c | 6 +-
drivers/gpu/drm/i915/intel_runtime_pm.c | 6 +-
drivers/hwmon/scmi-hwmon.c | 6 +-
drivers/input/input-mt.c | 11 +-
drivers/md/bcache/bset.c | 12 +-
drivers/md/bcache/sysfs.c | 6 +-
drivers/media/i2c/msp3400-kthreads.c | 12 +-
drivers/media/pci/bt8xx/bttv-cards.c | 6 +-
drivers/media/pci/saa7134/saa7134-video.c | 7 +-
drivers/mtd/devices/lart.c | 10 +-
drivers/net/ethernet/8390/axnet_cs.c | 19 +-
drivers/net/ethernet/8390/lib8390.c | 14 +-
drivers/net/ethernet/8390/pcnet_cs.c | 6 +-
.../ethernet/freescale/fs_enet/fs_enet-main.c | 11 +-
drivers/net/wan/sbni.c | 101 +++---
drivers/s390/char/tty3270.c | 6 +-
drivers/scsi/arm/cumana_2.c | 19 +-
drivers/scsi/arm/eesox.c | 9 +-
drivers/scsi/arm/powertec.c | 9 +-
.../media/atomisp/pci/atomisp_subdev.c | 6 +-
drivers/video/fbdev/tgafb.c | 12 +-
fs/fuse/dir.c | 24 +-
fs/reiserfs/fix_node.c | 36 ++-
lib/zlib_deflate/deftree.c | 49 ++-
lib/zstd/compress.c | 120 ++++---
lib/zstd/fse_compress.c | 24 +-
lib/zstd/huf_compress.c | 6 +-
net/ipv6/ip6_fib.c | 12 +-
net/sunrpc/sysctl.c | 6 +-
tools/lib/subcmd/help.c | 10 +-
tools/power/cpupower/utils/cpufreq-set.c | 14 +-
tools/testing/selftests/vm/gup_benchmark.c | 18 +-
tools/testing/selftests/vm/userfaultfd.c | 296 +++++++++++-------
46 files changed, 694 insertions(+), 382 deletions(-)
--
2.26.0
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 08/29] dma-buf: Avoid comma separated statements
2020-08-25 4:55 [PATCH 00/29] treewide: Convert comma separated statements Joe Perches
@ 2020-08-25 4:56 ` Joe Perches
2020-08-26 15:08 ` Christian König
` (2 more replies)
2020-08-25 4:56 ` [PATCH 14/29] media: " Joe Perches
` (2 subsequent siblings)
3 siblings, 3 replies; 18+ messages in thread
From: Joe Perches @ 2020-08-25 4:56 UTC (permalink / raw)
To: Jiri Kosina, Sumit Semwal, Christian König
Cc: linux-media, dri-devel, linaro-mm-sig, linux-kernel
Use semicolons and braces.
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/dma-buf/st-dma-fence.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c
index e593064341c8..c8a12d7ad71a 100644
--- a/drivers/dma-buf/st-dma-fence.c
+++ b/drivers/dma-buf/st-dma-fence.c
@@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg)
dma_fence_signal(f1);
smp_store_mb(cb.seen, false);
- if (!f2 || dma_fence_add_callback(f2, &cb.cb, simple_callback))
- miss++, cb.seen = true;
+ if (!f2 ||
+ dma_fence_add_callback(f2, &cb.cb, simple_callback)) {
+ miss++;
+ cb.seen = true;
+ }
if (!t->before)
dma_fence_signal(f1);
--
2.26.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 14/29] media: Avoid comma separated statements
2020-08-25 4:55 [PATCH 00/29] treewide: Convert comma separated statements Joe Perches
2020-08-25 4:56 ` [PATCH 08/29] dma-buf: Avoid " Joe Perches
@ 2020-08-25 4:56 ` Joe Perches
2020-09-04 11:45 ` Kieran Bingham
2020-08-25 4:56 ` [PATCH 21/29] media: atomisp: " Joe Perches
2020-09-09 2:09 ` [PATCH 00/29] treewide: Convert " Martin K. Petersen
3 siblings, 1 reply; 18+ messages in thread
From: Joe Perches @ 2020-08-25 4:56 UTC (permalink / raw)
To: Jiri Kosina, Mauro Carvalho Chehab; +Cc: linux-media, linux-kernel
Use semicolons and braces.
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/media/i2c/msp3400-kthreads.c | 12 ++++++++----
drivers/media/pci/bt8xx/bttv-cards.c | 6 ++++--
drivers/media/pci/saa7134/saa7134-video.c | 7 +++++--
3 files changed, 17 insertions(+), 8 deletions(-)
diff --git a/drivers/media/i2c/msp3400-kthreads.c b/drivers/media/i2c/msp3400-kthreads.c
index d3b0d1c18efd..ac8752c63266 100644
--- a/drivers/media/i2c/msp3400-kthreads.c
+++ b/drivers/media/i2c/msp3400-kthreads.c
@@ -549,8 +549,10 @@ int msp3400c_thread(void *data)
val = msp_read_dsp(client, 0x1b);
if (val > 32767)
val -= 65536;
- if (val1 < val)
- val1 = val, max1 = i;
+ if (val1 < val) {
+ val1 = val;
+ max1 = i;
+ }
dev_dbg_lvl(&client->dev, 1, msp_debug,
"carrier1 val: %5d / %s\n", val, cd[i].name);
}
@@ -586,8 +588,10 @@ int msp3400c_thread(void *data)
val = msp_read_dsp(client, 0x1b);
if (val > 32767)
val -= 65536;
- if (val2 < val)
- val2 = val, max2 = i;
+ if (val2 < val) {
+ val2 = val;
+ max2 = i;
+ }
dev_dbg_lvl(&client->dev, 1, msp_debug,
"carrier2 val: %5d / %s\n", val, cd[i].name);
}
diff --git a/drivers/media/pci/bt8xx/bttv-cards.c b/drivers/media/pci/bt8xx/bttv-cards.c
index 16148802dabb..ca20b806e82d 100644
--- a/drivers/media/pci/bt8xx/bttv-cards.c
+++ b/drivers/media/pci/bt8xx/bttv-cards.c
@@ -3934,8 +3934,10 @@ static void osprey_eeprom(struct bttv *btv, const u8 ee[256])
if (checksum != ee[21])
return;
cardid = BTTV_BOARD_OSPREY1x0_848;
- for (i = 12; i < 21; i++)
- serial *= 10, serial += ee[i] - '0';
+ for (i = 12; i < 21; i++) {
+ serial *= 10;
+ serial += ee[i] - '0';
+ }
}
} else {
unsigned short type;
diff --git a/drivers/media/pci/saa7134/saa7134-video.c b/drivers/media/pci/saa7134/saa7134-video.c
index a8ac94fadc14..f673cda57f30 100644
--- a/drivers/media/pci/saa7134/saa7134-video.c
+++ b/drivers/media/pci/saa7134/saa7134-video.c
@@ -868,8 +868,11 @@ static int buffer_activate(struct saa7134_dev *dev,
lines_uv = dev->height >> dev->fmt->vshift;
base2 = base + bpl * dev->height;
base3 = base2 + bpl_uv * lines_uv;
- if (dev->fmt->uvswap)
- tmp = base2, base2 = base3, base3 = tmp;
+ if (dev->fmt->uvswap) {
+ tmp = base2;
+ base2 = base3;
+ base3 = tmp;
+ }
video_dbg("uv: bpl=%ld lines=%ld base2/3=%ld/%ld\n",
bpl_uv,lines_uv,base2,base3);
if (V4L2_FIELD_HAS_BOTH(dev->field)) {
--
2.26.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 21/29] media: atomisp: Avoid comma separated statements
2020-08-25 4:55 [PATCH 00/29] treewide: Convert comma separated statements Joe Perches
2020-08-25 4:56 ` [PATCH 08/29] dma-buf: Avoid " Joe Perches
2020-08-25 4:56 ` [PATCH 14/29] media: " Joe Perches
@ 2020-08-25 4:56 ` Joe Perches
2020-09-04 11:46 ` Kieran Bingham
2020-09-09 2:09 ` [PATCH 00/29] treewide: Convert " Martin K. Petersen
3 siblings, 1 reply; 18+ messages in thread
From: Joe Perches @ 2020-08-25 4:56 UTC (permalink / raw)
To: Jiri Kosina, linux-kernel
Cc: Mauro Carvalho Chehab, Sakari Ailus, Greg Kroah-Hartman,
linux-media, devel
Use semicolons and braces.
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/staging/media/atomisp/pci/atomisp_subdev.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_subdev.c b/drivers/staging/media/atomisp/pci/atomisp_subdev.c
index 6ba817f15655..52b9fb18c87f 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_subdev.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_subdev.c
@@ -410,8 +410,10 @@ int atomisp_subdev_set_selection(struct v4l2_subdev *sd,
if (atomisp_subdev_format_conversion(isp_sd,
isp_sd->capture_pad)
- && crop[pad]->width && crop[pad]->height)
- crop[pad]->width -= padding_w, crop[pad]->height -= padding_h;
+ && crop[pad]->width && crop[pad]->height) {
+ crop[pad]->width -= padding_w;
+ crop[pad]->height -= padding_h;
+ }
/* if subdev type is SOC camera,we do not need to set DVS */
if (isp->inputs[isp_sd->input_curr].type == SOC_CAMERA)
--
2.26.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH 08/29] dma-buf: Avoid comma separated statements
2020-08-25 4:56 ` [PATCH 08/29] dma-buf: Avoid " Joe Perches
@ 2020-08-26 15:08 ` Christian König
2020-09-03 12:21 ` Sumit Semwal
2020-09-04 11:42 ` Kieran Bingham
2021-01-30 18:47 ` Joe Perches
2 siblings, 1 reply; 18+ messages in thread
From: Christian König @ 2020-08-26 15:08 UTC (permalink / raw)
To: Joe Perches, Jiri Kosina, Sumit Semwal
Cc: linux-media, dri-devel, linaro-mm-sig, linux-kernel
Am 25.08.20 um 06:56 schrieb Joe Perches:
> Use semicolons and braces.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/dma-buf/st-dma-fence.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c
> index e593064341c8..c8a12d7ad71a 100644
> --- a/drivers/dma-buf/st-dma-fence.c
> +++ b/drivers/dma-buf/st-dma-fence.c
> @@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg)
> dma_fence_signal(f1);
>
> smp_store_mb(cb.seen, false);
> - if (!f2 || dma_fence_add_callback(f2, &cb.cb, simple_callback))
> - miss++, cb.seen = true;
> + if (!f2 ||
> + dma_fence_add_callback(f2, &cb.cb, simple_callback)) {
> + miss++;
> + cb.seen = true;
> + }
>
> if (!t->before)
> dma_fence_signal(f1);
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 08/29] dma-buf: Avoid comma separated statements
2020-08-26 15:08 ` Christian König
@ 2020-09-03 12:21 ` Sumit Semwal
0 siblings, 0 replies; 18+ messages in thread
From: Sumit Semwal @ 2020-09-03 12:21 UTC (permalink / raw)
To: Christian König
Cc: Joe Perches, Jiri Kosina, open list:DMA BUFFER SHARING FRAMEWORK,
DRI mailing list, Linaro MM SIG, LKML
Hello Joe,
On Wed, 26 Aug 2020 at 20:38, Christian König <christian.koenig@amd.com> wrote:
>
> Am 25.08.20 um 06:56 schrieb Joe Perches:
> > Use semicolons and braces.
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
>
> Acked-by: Christian König <christian.koenig@amd.com>
FWIW,
Acked-by: Sumit Semwal <sumit.semwal@linaro.org>
>
> > ---
> > drivers/dma-buf/st-dma-fence.c | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c
> > index e593064341c8..c8a12d7ad71a 100644
> > --- a/drivers/dma-buf/st-dma-fence.c
> > +++ b/drivers/dma-buf/st-dma-fence.c
> > @@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg)
> > dma_fence_signal(f1);
> >
> > smp_store_mb(cb.seen, false);
> > - if (!f2 || dma_fence_add_callback(f2, &cb.cb, simple_callback))
> > - miss++, cb.seen = true;
> > + if (!f2 ||
> > + dma_fence_add_callback(f2, &cb.cb, simple_callback)) {
> > + miss++;
> > + cb.seen = true;
> > + }
> >
> > if (!t->before)
> > dma_fence_signal(f1);
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 08/29] dma-buf: Avoid comma separated statements
2020-08-25 4:56 ` [PATCH 08/29] dma-buf: Avoid " Joe Perches
2020-08-26 15:08 ` Christian König
@ 2020-09-04 11:42 ` Kieran Bingham
2020-09-04 21:33 ` Joe Perches
2021-01-30 18:47 ` Joe Perches
2 siblings, 1 reply; 18+ messages in thread
From: Kieran Bingham @ 2020-09-04 11:42 UTC (permalink / raw)
To: Joe Perches, Jiri Kosina, Sumit Semwal, Christian König
Cc: linux-media, dri-devel, linaro-mm-sig, linux-kernel
Hi Joe,
Nice, I only see three of these on the linux-media list, so I'll only
look at those, but I'm pleased to see this is treewide ;-)
Definitely prefer this.
On 25/08/2020 05:56, Joe Perches wrote:
> Use semicolons and braces.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> drivers/dma-buf/st-dma-fence.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c
> index e593064341c8..c8a12d7ad71a 100644
> --- a/drivers/dma-buf/st-dma-fence.c
> +++ b/drivers/dma-buf/st-dma-fence.c
> @@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg)
> dma_fence_signal(f1);
>
> smp_store_mb(cb.seen, false);
> - if (!f2 || dma_fence_add_callback(f2, &cb.cb, simple_callback))
> - miss++, cb.seen = true;
> + if (!f2 ||
> + dma_fence_add_callback(f2, &cb.cb, simple_callback)) {
> + miss++;
> + cb.seen = true;
> + }
>
> if (!t->before)
> dma_fence_signal(f1);
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 14/29] media: Avoid comma separated statements
2020-08-25 4:56 ` [PATCH 14/29] media: " Joe Perches
@ 2020-09-04 11:45 ` Kieran Bingham
0 siblings, 0 replies; 18+ messages in thread
From: Kieran Bingham @ 2020-09-04 11:45 UTC (permalink / raw)
To: Joe Perches, Jiri Kosina, Mauro Carvalho Chehab; +Cc: linux-media, linux-kernel
On 25/08/2020 05:56, Joe Perches wrote:
> Use semicolons and braces.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/media/i2c/msp3400-kthreads.c | 12 ++++++++----
> drivers/media/pci/bt8xx/bttv-cards.c | 6 ++++--
> drivers/media/pci/saa7134/saa7134-video.c | 7 +++++--
> 3 files changed, 17 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/media/i2c/msp3400-kthreads.c b/drivers/media/i2c/msp3400-kthreads.c
> index d3b0d1c18efd..ac8752c63266 100644
> --- a/drivers/media/i2c/msp3400-kthreads.c
> +++ b/drivers/media/i2c/msp3400-kthreads.c
> @@ -549,8 +549,10 @@ int msp3400c_thread(void *data)
> val = msp_read_dsp(client, 0x1b);
> if (val > 32767)
> val -= 65536;
> - if (val1 < val)
> - val1 = val, max1 = i;
> + if (val1 < val) {
> + val1 = val;
> + max1 = i;
> + }
> dev_dbg_lvl(&client->dev, 1, msp_debug,
> "carrier1 val: %5d / %s\n", val, cd[i].name);
> }
> @@ -586,8 +588,10 @@ int msp3400c_thread(void *data)
> val = msp_read_dsp(client, 0x1b);
> if (val > 32767)
> val -= 65536;
> - if (val2 < val)
> - val2 = val, max2 = i;
> + if (val2 < val) {
> + val2 = val;
> + max2 = i;
> + }
> dev_dbg_lvl(&client->dev, 1, msp_debug,
> "carrier2 val: %5d / %s\n", val, cd[i].name);
> }
> diff --git a/drivers/media/pci/bt8xx/bttv-cards.c b/drivers/media/pci/bt8xx/bttv-cards.c
> index 16148802dabb..ca20b806e82d 100644
> --- a/drivers/media/pci/bt8xx/bttv-cards.c
> +++ b/drivers/media/pci/bt8xx/bttv-cards.c
> @@ -3934,8 +3934,10 @@ static void osprey_eeprom(struct bttv *btv, const u8 ee[256])
> if (checksum != ee[21])
> return;
> cardid = BTTV_BOARD_OSPREY1x0_848;
> - for (i = 12; i < 21; i++)
> - serial *= 10, serial += ee[i] - '0';
> + for (i = 12; i < 21; i++) {
> + serial *= 10;
> + serial += ee[i] - '0';
> + }
> }
> } else {
> unsigned short type;
> diff --git a/drivers/media/pci/saa7134/saa7134-video.c b/drivers/media/pci/saa7134/saa7134-video.c
> index a8ac94fadc14..f673cda57f30 100644
> --- a/drivers/media/pci/saa7134/saa7134-video.c
> +++ b/drivers/media/pci/saa7134/saa7134-video.c
> @@ -868,8 +868,11 @@ static int buffer_activate(struct saa7134_dev *dev,
> lines_uv = dev->height >> dev->fmt->vshift;
> base2 = base + bpl * dev->height;
> base3 = base2 + bpl_uv * lines_uv;
> - if (dev->fmt->uvswap)
> - tmp = base2, base2 = base3, base3 = tmp;
> + if (dev->fmt->uvswap) {
> + tmp = base2;
> + base2 = base3;
> + base3 = tmp;
Don't we have any swap macro helpers for this?
Anyway, that would be out of scope of this patch series.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> + }
> video_dbg("uv: bpl=%ld lines=%ld base2/3=%ld/%ld\n",
> bpl_uv,lines_uv,base2,base3);
> if (V4L2_FIELD_HAS_BOTH(dev->field)) {
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 21/29] media: atomisp: Avoid comma separated statements
2020-08-25 4:56 ` [PATCH 21/29] media: atomisp: " Joe Perches
@ 2020-09-04 11:46 ` Kieran Bingham
0 siblings, 0 replies; 18+ messages in thread
From: Kieran Bingham @ 2020-09-04 11:46 UTC (permalink / raw)
To: Joe Perches, Jiri Kosina, linux-kernel
Cc: Mauro Carvalho Chehab, Sakari Ailus, Greg Kroah-Hartman,
linux-media, devel
On 25/08/2020 05:56, Joe Perches wrote:
> Use semicolons and braces.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> drivers/staging/media/atomisp/pci/atomisp_subdev.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_subdev.c b/drivers/staging/media/atomisp/pci/atomisp_subdev.c
> index 6ba817f15655..52b9fb18c87f 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_subdev.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_subdev.c
> @@ -410,8 +410,10 @@ int atomisp_subdev_set_selection(struct v4l2_subdev *sd,
>
> if (atomisp_subdev_format_conversion(isp_sd,
> isp_sd->capture_pad)
> - && crop[pad]->width && crop[pad]->height)
> - crop[pad]->width -= padding_w, crop[pad]->height -= padding_h;
> + && crop[pad]->width && crop[pad]->height) {
> + crop[pad]->width -= padding_w;
> + crop[pad]->height -= padding_h;
> + }
>
> /* if subdev type is SOC camera,we do not need to set DVS */
> if (isp->inputs[isp_sd->input_curr].type == SOC_CAMERA)
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 08/29] dma-buf: Avoid comma separated statements
2020-09-04 11:42 ` Kieran Bingham
@ 2020-09-04 21:33 ` Joe Perches
0 siblings, 0 replies; 18+ messages in thread
From: Joe Perches @ 2020-09-04 21:33 UTC (permalink / raw)
To: kieran.bingham+renesas, Jiri Kosina, Sumit Semwal, Christian König
Cc: linux-media, dri-devel, linaro-mm-sig, linux-kernel
On Fri, 2020-09-04 at 12:42 +0100, Kieran Bingham wrote:
> I'm pleased to see this is treewide ;-)
> Definitely prefer this.
These are only the comma uses in if/do/while blocks that
would also need braces as separate statements.
There a multiple dozens more just with single statements
terminated by commas and not semicolons.
See: https://lore.kernel.org/patchwork/patch/1291033/
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 00/29] treewide: Convert comma separated statements
2020-08-25 4:55 [PATCH 00/29] treewide: Convert comma separated statements Joe Perches
` (2 preceding siblings ...)
2020-08-25 4:56 ` [PATCH 21/29] media: atomisp: " Joe Perches
@ 2020-09-09 2:09 ` Martin K. Petersen
3 siblings, 0 replies; 18+ messages in thread
From: Martin K. Petersen @ 2020-09-09 2:09 UTC (permalink / raw)
To: linuxppc-dev, linux-ide, dri-devel, linux-hwmon, Joe Perches,
oprofile-list, linux-fsdevel, linux-media, linaro-mm-sig,
drbd-dev, intel-gfx, linux-arm-kernel, linux-input, linux-nfs,
netdev, reiserfs-devel, linux-bcache, Jiri Kosina
Cc: Martin K . Petersen, sparclinux, linux-mtd, linux-s390,
linux-doc, linux-block, linux-ia64, linux-pm, linux-kselftest,
linux-fbdev, devel, linux-scsi, linux-alpha, linux-kernel
On Mon, 24 Aug 2020 21:55:57 -0700, Joe Perches wrote:
> There are many comma separated statements in the kernel.
> See:https://lore.kernel.org/lkml/alpine.DEB.2.22.394.2008201856110.2524@hadrien/
>
> Convert the comma separated statements that are in if/do/while blocks
> to use braces and semicolons.
>
> Many comma separated statements still exist but those are changes for
> another day.
>
> [...]
Applied to 5.10/scsi-queue, thanks!
[01/29] coding-style.rst: Avoid comma statements
(no commit info)
[02/29] alpha: Avoid comma separated statements
(no commit info)
[03/29] ia64: Avoid comma separated statements
(no commit info)
[04/29] sparc: Avoid comma separated statements
(no commit info)
[05/29] ata: Avoid comma separated statements
(no commit info)
[06/29] drbd: Avoid comma separated statements
(no commit info)
[07/29] lp: Avoid comma separated statements
(no commit info)
[08/29] dma-buf: Avoid comma separated statements
(no commit info)
[09/29] drm/gma500: Avoid comma separated statements
(no commit info)
[10/29] drm/i915: Avoid comma separated statements
(no commit info)
[11/29] hwmon: (scmi-hwmon): Avoid comma separated statements
(no commit info)
[12/29] Input: MT - Avoid comma separated statements
(no commit info)
[13/29] bcache: Avoid comma separated statements
(no commit info)
[14/29] media: Avoid comma separated statements
(no commit info)
[15/29] mtd: Avoid comma separated statements
(no commit info)
[16/29] 8390: Avoid comma separated statements
(no commit info)
[17/29] fs_enet: Avoid comma separated statements
(no commit info)
[18/29] wan: sbni: Avoid comma separated statements
(no commit info)
[19/29] s390/tty3270: Avoid comma separated statements
(no commit info)
[20/29] scsi: arm: Avoid comma separated statements
https://git.kernel.org/mkp/scsi/c/a08a07326510
[21/29] media: atomisp: Avoid comma separated statements
(no commit info)
[22/29] video: fbdev: Avoid comma separated statements
(no commit info)
[23/29] fuse: Avoid comma separated statements
(no commit info)
[24/29] reiserfs: Avoid comma separated statements
(no commit info)
[25/29] lib/zlib: Avoid comma separated statements
(no commit info)
[26/29] lib: zstd: Avoid comma separated statements
(no commit info)
[27/29] ipv6: fib6: Avoid comma separated statements
(no commit info)
[28/29] sunrpc: Avoid comma separated statements
(no commit info)
[29/29] tools: Avoid comma separated statements
(no commit info)
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 08/29] dma-buf: Avoid comma separated statements
2020-08-25 4:56 ` [PATCH 08/29] dma-buf: Avoid " Joe Perches
2020-08-26 15:08 ` Christian König
2020-09-04 11:42 ` Kieran Bingham
@ 2021-01-30 18:47 ` Joe Perches
2021-02-03 13:26 ` Christian König
2 siblings, 1 reply; 18+ messages in thread
From: Joe Perches @ 2021-01-30 18:47 UTC (permalink / raw)
To: Jiri Kosina, Sumit Semwal, Christian König
Cc: linux-media, dri-devel, linaro-mm-sig, linux-kernel
On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
> Use semicolons and braces.
Ping?
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/dma-buf/st-dma-fence.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c
> index e593064341c8..c8a12d7ad71a 100644
> --- a/drivers/dma-buf/st-dma-fence.c
> +++ b/drivers/dma-buf/st-dma-fence.c
> @@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg)
> dma_fence_signal(f1);
>
>
> smp_store_mb(cb.seen, false);
> - if (!f2 || dma_fence_add_callback(f2, &cb.cb, simple_callback))
> - miss++, cb.seen = true;
> + if (!f2 ||
> + dma_fence_add_callback(f2, &cb.cb, simple_callback)) {
> + miss++;
> + cb.seen = true;
> + }
>
>
> if (!t->before)
> dma_fence_signal(f1);
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 08/29] dma-buf: Avoid comma separated statements
2021-02-03 13:26 ` Christian König
@ 2021-01-31 17:39 ` Joe Perches
2021-01-31 17:53 ` Christian König
2021-02-01 21:54 ` Lyude Paul
1 sibling, 1 reply; 18+ messages in thread
From: Joe Perches @ 2021-01-31 17:39 UTC (permalink / raw)
To: Christian König, Jiri Kosina, Sumit Semwal
Cc: linux-media, dri-devel, linaro-mm-sig, linux-kernel
On Wed, 2021-02-03 at 14:26 +0100, Christian König wrote:
> Am 30.01.21 um 19:47 schrieb Joe Perches:
> > On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
> > > Use semicolons and braces.
> > Ping?
> > > Signed-off-by: Joe Perches <joe@perches.com>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> Do you have commit rights to drm-misc-next?
No.
> > > ---
> > > drivers/dma-buf/st-dma-fence.c | 7 +++++--
> > > 1 file changed, 5 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c
> > > index e593064341c8..c8a12d7ad71a 100644
> > > --- a/drivers/dma-buf/st-dma-fence.c
> > > +++ b/drivers/dma-buf/st-dma-fence.c
> > > @@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg)
> > > dma_fence_signal(f1);
> > >
> > > smp_store_mb(cb.seen, false);
> > > - if (!f2 || dma_fence_add_callback(f2, &cb.cb, simple_callback))
> > > - miss++, cb.seen = true;
> > > + if (!f2 ||
> > > + dma_fence_add_callback(f2, &cb.cb, simple_callback)) {
> > > + miss++;
> > > + cb.seen = true;
> > > + }
> > >
> > > if (!t->before)
> > > dma_fence_signal(f1);
> >
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 08/29] dma-buf: Avoid comma separated statements
2021-01-31 17:39 ` Joe Perches
@ 2021-01-31 17:53 ` Christian König
0 siblings, 0 replies; 18+ messages in thread
From: Christian König @ 2021-01-31 17:53 UTC (permalink / raw)
To: Joe Perches, Jiri Kosina, Sumit Semwal
Cc: linux-media, dri-devel, linaro-mm-sig, linux-kernel
Am 31.01.21 um 18:39 schrieb Joe Perches:
> On Wed, 2021-02-03 at 14:26 +0100, Christian König wrote:
>> Am 30.01.21 um 19:47 schrieb Joe Perches:
>>> On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
>>>> Use semicolons and braces.
>>> Ping?
>>>> Signed-off-by: Joe Perches <joe@perches.com>
>> Reviewed-by: Christian König <christian.koenig@amd.com>
>>
>> Do you have commit rights to drm-misc-next?
> No.
Pushed.
Thanks for the help,
Christian.
>
>>>> ---
>>>> drivers/dma-buf/st-dma-fence.c | 7 +++++--
>>>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c
>>>> index e593064341c8..c8a12d7ad71a 100644
>>>> --- a/drivers/dma-buf/st-dma-fence.c
>>>> +++ b/drivers/dma-buf/st-dma-fence.c
>>>> @@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg)
>>>> dma_fence_signal(f1);
>>>>
>>>> smp_store_mb(cb.seen, false);
>>>> - if (!f2 || dma_fence_add_callback(f2, &cb.cb, simple_callback))
>>>> - miss++, cb.seen = true;
>>>> + if (!f2 ||
>>>> + dma_fence_add_callback(f2, &cb.cb, simple_callback)) {
>>>> + miss++;
>>>> + cb.seen = true;
>>>> + }
>>>>
>>>> if (!t->before)
>>>> dma_fence_signal(f1);
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 08/29] dma-buf: Avoid comma separated statements
2021-02-03 13:26 ` Christian König
2021-01-31 17:39 ` Joe Perches
@ 2021-02-01 21:54 ` Lyude Paul
2021-02-02 8:33 ` [Linaro-mm-sig] " Christian König
1 sibling, 1 reply; 18+ messages in thread
From: Lyude Paul @ 2021-02-01 21:54 UTC (permalink / raw)
To: Christian König, Joe Perches, Jiri Kosina, Sumit Semwal
Cc: linaro-mm-sig, linux-kernel, dri-devel, linux-media
This is entirely unrelated to this thread, but I noticed when going through dri-
devel that this email is somehow dated two days in the future from now.
On Wed, 2021-02-03 at 14:26 +0100, Christian König wrote:
> Am 30.01.21 um 19:47 schrieb Joe Perches:
> > On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
> > > Use semicolons and braces.
> > Ping?
> >
> > > Signed-off-by: Joe Perches <joe@perches.com>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> Do you have commit rights to drm-misc-next?
>
> > > ---
> > > drivers/dma-buf/st-dma-fence.c | 7 +++++--
> > > 1 file changed, 5 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-
> > > fence.c
> > > index e593064341c8..c8a12d7ad71a 100644
> > > --- a/drivers/dma-buf/st-dma-fence.c
> > > +++ b/drivers/dma-buf/st-dma-fence.c
> > > @@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg)
> > > dma_fence_signal(f1);
> > >
> > >
> > > smp_store_mb(cb.seen, false);
> > > - if (!f2 || dma_fence_add_callback(f2, &cb.cb,
> > > simple_callback))
> > > - miss++, cb.seen = true;
> > > + if (!f2 ||
> > > + dma_fence_add_callback(f2, &cb.cb, simple_callback)) {
> > > + miss++;
> > > + cb.seen = true;
> > > + }
> > >
> > >
> > > if (!t->before)
> > > dma_fence_signal(f1);
> >
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Sincerely,
Lyude Paul (she/her)
Software Engineer at Red Hat
Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've
asked me a question, are waiting for a review/merge on a patch, etc. and I
haven't responded in a while, please feel free to send me another email to check
on my status. I don't bite!
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Linaro-mm-sig] [PATCH 08/29] dma-buf: Avoid comma separated statements
2021-02-01 21:54 ` Lyude Paul
@ 2021-02-02 8:33 ` Christian König
2021-02-02 18:24 ` Lyude Paul
0 siblings, 1 reply; 18+ messages in thread
From: Christian König @ 2021-02-02 8:33 UTC (permalink / raw)
To: lyude, Christian König, Joe Perches, Jiri Kosina, Sumit Semwal
Cc: linaro-mm-sig, linux-kernel, dri-devel, linux-media
Yeah, known issue.
An NTP server which I don't have access to has gone bananas and
sometimes spits out invalid time stamps.
Only thing I can do is wait for an admin to take care of this.
Christian.
Am 01.02.21 um 22:54 schrieb Lyude Paul:
> This is entirely unrelated to this thread, but I noticed when going through dri-
> devel that this email is somehow dated two days in the future from now.
>
> On Wed, 2021-02-03 at 14:26 +0100, Christian König wrote:
>> Am 30.01.21 um 19:47 schrieb Joe Perches:
>>> On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
>>>> Use semicolons and braces.
>>> Ping?
>>>
>>>> Signed-off-by: Joe Perches <joe@perches.com>
>> Reviewed-by: Christian König <christian.koenig@amd.com>
>>
>> Do you have commit rights to drm-misc-next?
>>
>>>> ---
>>>> drivers/dma-buf/st-dma-fence.c | 7 +++++--
>>>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-
>>>> fence.c
>>>> index e593064341c8..c8a12d7ad71a 100644
>>>> --- a/drivers/dma-buf/st-dma-fence.c
>>>> +++ b/drivers/dma-buf/st-dma-fence.c
>>>> @@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg)
>>>> dma_fence_signal(f1);
>>>>
>>>>
>>>> smp_store_mb(cb.seen, false);
>>>> - if (!f2 || dma_fence_add_callback(f2, &cb.cb,
>>>> simple_callback))
>>>> - miss++, cb.seen = true;
>>>> + if (!f2 ||
>>>> + dma_fence_add_callback(f2, &cb.cb, simple_callback)) {
>>>> + miss++;
>>>> + cb.seen = true;
>>>> + }
>>>>
>>>>
>>>> if (!t->before)
>>>> dma_fence_signal(f1);
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Linaro-mm-sig] [PATCH 08/29] dma-buf: Avoid comma separated statements
2021-02-02 8:33 ` [Linaro-mm-sig] " Christian König
@ 2021-02-02 18:24 ` Lyude Paul
0 siblings, 0 replies; 18+ messages in thread
From: Lyude Paul @ 2021-02-02 18:24 UTC (permalink / raw)
To: christian.koenig, Joe Perches, Jiri Kosina, Sumit Semwal
Cc: linaro-mm-sig, linux-kernel, dri-devel, linux-media
On Tue, 2021-02-02 at 09:33 +0100, Christian König wrote:
> Yeah, known issue.
>
> An NTP server which I don't have access to has gone bananas and
> sometimes spits out invalid time stamps.
>
> Only thing I can do is wait for an admin to take care of this.
haha it's ok! I just thought it was mildly entertaining to see, as my email
client formatted the message timestamp "Next Wednesday" :)
>
> Christian.
>
> Am 01.02.21 um 22:54 schrieb Lyude Paul:
> > This is entirely unrelated to this thread, but I noticed when going through
> > dri-
> > devel that this email is somehow dated two days in the future from now.
> >
> > On Wed, 2021-02-03 at 14:26 +0100, Christian König wrote:
> > > Am 30.01.21 um 19:47 schrieb Joe Perches:
> > > > On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
> > > > > Use semicolons and braces.
> > > > Ping?
> > > >
> > > > > Signed-off-by: Joe Perches <joe@perches.com>
> > > Reviewed-by: Christian König <christian.koenig@amd.com>
> > >
> > > Do you have commit rights to drm-misc-next?
> > >
> > > > > ---
> > > > > drivers/dma-buf/st-dma-fence.c | 7 +++++--
> > > > > 1 file changed, 5 insertions(+), 2 deletions(-)
> > > > >
> > > > > diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-
> > > > > fence.c
> > > > > index e593064341c8..c8a12d7ad71a 100644
> > > > > --- a/drivers/dma-buf/st-dma-fence.c
> > > > > +++ b/drivers/dma-buf/st-dma-fence.c
> > > > > @@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg)
> > > > > dma_fence_signal(f1);
> > > > >
> > > > >
> > > > > smp_store_mb(cb.seen, false);
> > > > > - if (!f2 || dma_fence_add_callback(f2, &cb.cb,
> > > > > simple_callback))
> > > > > - miss++, cb.seen = true;
> > > > > + if (!f2 ||
> > > > > + dma_fence_add_callback(f2, &cb.cb,
> > > > > simple_callback)) {
> > > > > + miss++;
> > > > > + cb.seen = true;
> > > > > + }
> > > > >
> > > > >
> > > > > if (!t->before)
> > > > > dma_fence_signal(f1);
> > > _______________________________________________
> > > dri-devel mailing list
> > > dri-devel@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Sincerely,
Lyude Paul (she/her)
Software Engineer at Red Hat
Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've
asked me a question, are waiting for a review/merge on a patch, etc. and I
haven't responded in a while, please feel free to send me another email to check
on my status. I don't bite!
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 08/29] dma-buf: Avoid comma separated statements
2021-01-30 18:47 ` Joe Perches
@ 2021-02-03 13:26 ` Christian König
2021-01-31 17:39 ` Joe Perches
2021-02-01 21:54 ` Lyude Paul
0 siblings, 2 replies; 18+ messages in thread
From: Christian König @ 2021-02-03 13:26 UTC (permalink / raw)
To: Joe Perches, Jiri Kosina, Sumit Semwal
Cc: linux-media, dri-devel, linaro-mm-sig, linux-kernel
Am 30.01.21 um 19:47 schrieb Joe Perches:
> On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
>> Use semicolons and braces.
> Ping?
>
>> Signed-off-by: Joe Perches <joe@perches.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Do you have commit rights to drm-misc-next?
>> ---
>> drivers/dma-buf/st-dma-fence.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c
>> index e593064341c8..c8a12d7ad71a 100644
>> --- a/drivers/dma-buf/st-dma-fence.c
>> +++ b/drivers/dma-buf/st-dma-fence.c
>> @@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg)
>> dma_fence_signal(f1);
>>
>>
>> smp_store_mb(cb.seen, false);
>> - if (!f2 || dma_fence_add_callback(f2, &cb.cb, simple_callback))
>> - miss++, cb.seen = true;
>> + if (!f2 ||
>> + dma_fence_add_callback(f2, &cb.cb, simple_callback)) {
>> + miss++;
>> + cb.seen = true;
>> + }
>>
>>
>> if (!t->before)
>> dma_fence_signal(f1);
>
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2021-02-02 18:28 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-25 4:55 [PATCH 00/29] treewide: Convert comma separated statements Joe Perches
2020-08-25 4:56 ` [PATCH 08/29] dma-buf: Avoid " Joe Perches
2020-08-26 15:08 ` Christian König
2020-09-03 12:21 ` Sumit Semwal
2020-09-04 11:42 ` Kieran Bingham
2020-09-04 21:33 ` Joe Perches
2021-01-30 18:47 ` Joe Perches
2021-02-03 13:26 ` Christian König
2021-01-31 17:39 ` Joe Perches
2021-01-31 17:53 ` Christian König
2021-02-01 21:54 ` Lyude Paul
2021-02-02 8:33 ` [Linaro-mm-sig] " Christian König
2021-02-02 18:24 ` Lyude Paul
2020-08-25 4:56 ` [PATCH 14/29] media: " Joe Perches
2020-09-04 11:45 ` Kieran Bingham
2020-08-25 4:56 ` [PATCH 21/29] media: atomisp: " Joe Perches
2020-09-04 11:46 ` Kieran Bingham
2020-09-09 2:09 ` [PATCH 00/29] treewide: Convert " Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).