linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/5] media/media-device.h: drop duplicated word in comment
@ 2020-07-14 22:05 Randy Dunlap
  2020-07-14 22:05 ` [PATCH 2/5] media/media-devnode.h: " Randy Dunlap
                   ` (4 more replies)
  0 siblings, 5 replies; 10+ messages in thread
From: Randy Dunlap @ 2020-07-14 22:05 UTC (permalink / raw)
  To: linux-kernel; +Cc: Randy Dunlap, Mauro Carvalho Chehab, linux-media

Delete the doubled word "the" in a comment.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org
---
 include/media/media-device.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20200714.orig/include/media/media-device.h
+++ linux-next-20200714/include/media/media-device.h
@@ -128,7 +128,7 @@ struct media_device_ops {
  *
  * Use-case: find tuner entity connected to the decoder
  * entity and check if it is available, and activate the
- * the link between them from @enable_source and deactivate
+ * link between them from @enable_source and deactivate
  * from @disable_source.
  *
  * .. note::

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 2/5] media/media-devnode.h: drop duplicated word in comment
  2020-07-14 22:05 [PATCH 1/5] media/media-device.h: drop duplicated word in comment Randy Dunlap
@ 2020-07-14 22:05 ` Randy Dunlap
  2020-07-17 11:59   ` Kieran Bingham
  2020-07-14 22:05 ` [PATCH 3/5] media/dvbdev.h: fix " Randy Dunlap
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 10+ messages in thread
From: Randy Dunlap @ 2020-07-14 22:05 UTC (permalink / raw)
  To: linux-kernel; +Cc: Randy Dunlap, Mauro Carvalho Chehab, linux-media

Delete the doubled word "the" in a comment.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org
---
 include/media/media-devnode.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20200714.orig/include/media/media-devnode.h
+++ linux-next-20200714/include/media/media-devnode.h
@@ -39,7 +39,7 @@ struct media_device;
  * @poll: pointer to the function that implements poll() syscall
  * @ioctl: pointer to the function that implements ioctl() syscall
  * @compat_ioctl: pointer to the function that will handle 32 bits userspace
- *	calls to the the ioctl() syscall on a Kernel compiled with 64 bits.
+ *	calls to the ioctl() syscall on a Kernel compiled with 64 bits.
  * @open: pointer to the function that implements open() syscall
  * @release: pointer to the function that will release the resources allocated
  *	by the @open function.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 3/5] media/dvbdev.h: fix duplicated word in comment
  2020-07-14 22:05 [PATCH 1/5] media/media-device.h: drop duplicated word in comment Randy Dunlap
  2020-07-14 22:05 ` [PATCH 2/5] media/media-devnode.h: " Randy Dunlap
@ 2020-07-14 22:05 ` Randy Dunlap
  2020-07-15  0:51   ` Joe Perches
  2020-07-14 22:05 ` [PATCH 4/5] media/media-entity.h: drop " Randy Dunlap
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 10+ messages in thread
From: Randy Dunlap @ 2020-07-14 22:05 UTC (permalink / raw)
  To: linux-kernel; +Cc: Randy Dunlap, Mauro Carvalho Chehab, linux-media

Change the doubled word "the" in a comment to "to the".

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org
---
 include/media/dvbdev.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20200714.orig/include/media/dvbdev.h
+++ linux-next-20200714/include/media/dvbdev.h
@@ -385,7 +385,7 @@ struct i2c_client;
  * with dvb_module_probe() should use dvb_module_release() to unbind.
  *
  * Return:
- *	On success, return an &struct i2c_client, pointing the the bound
+ *	On success, return an &struct i2c_client, pointing to the bound
  *	I2C device. %NULL otherwise.
  *
  * .. note::

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 4/5] media/media-entity.h: drop duplicated word in comment
  2020-07-14 22:05 [PATCH 1/5] media/media-device.h: drop duplicated word in comment Randy Dunlap
  2020-07-14 22:05 ` [PATCH 2/5] media/media-devnode.h: " Randy Dunlap
  2020-07-14 22:05 ` [PATCH 3/5] media/dvbdev.h: fix " Randy Dunlap
@ 2020-07-14 22:05 ` Randy Dunlap
  2020-07-17 12:00   ` Kieran Bingham
  2020-07-14 22:05 ` [PATCH 5/5] media/v4l2-subdev.h: " Randy Dunlap
  2020-07-17 11:59 ` [PATCH 1/5] media/media-device.h: " Kieran Bingham
  4 siblings, 1 reply; 10+ messages in thread
From: Randy Dunlap @ 2020-07-14 22:05 UTC (permalink / raw)
  To: linux-kernel; +Cc: Randy Dunlap, Mauro Carvalho Chehab, linux-media

Delete the doubled word "flag" in a comment.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org
---
 include/media/media-entity.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20200714.orig/include/media/media-entity.h
+++ linux-next-20200714/include/media/media-entity.h
@@ -803,7 +803,7 @@ int __media_entity_setup_link(struct med
  * @flags:	the requested new link flags
  *
  * The only configurable property is the %MEDIA_LNK_FL_ENABLED link flag
- * flag to enable/disable a link. Links marked with the
+ * to enable/disable a link. Links marked with the
  * %MEDIA_LNK_FL_IMMUTABLE link flag can not be enabled or disabled.
  *
  * When a link is enabled or disabled, the media framework calls the

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 5/5] media/v4l2-subdev.h: drop duplicated word in comment
  2020-07-14 22:05 [PATCH 1/5] media/media-device.h: drop duplicated word in comment Randy Dunlap
                   ` (2 preceding siblings ...)
  2020-07-14 22:05 ` [PATCH 4/5] media/media-entity.h: drop " Randy Dunlap
@ 2020-07-14 22:05 ` Randy Dunlap
  2020-07-17 12:00   ` Kieran Bingham
  2020-07-17 11:59 ` [PATCH 1/5] media/media-device.h: " Kieran Bingham
  4 siblings, 1 reply; 10+ messages in thread
From: Randy Dunlap @ 2020-07-14 22:05 UTC (permalink / raw)
  To: linux-kernel; +Cc: Randy Dunlap, Mauro Carvalho Chehab, linux-media

Delete the doubled words "the" in comments.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org
---
 include/media/v4l2-subdev.h |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

--- linux-next-20200714.orig/include/media/v4l2-subdev.h
+++ linux-next-20200714/include/media/v4l2-subdev.h
@@ -566,9 +566,9 @@ struct v4l2_subdev_ir_parameters {
  *
  * @rx_read: Reads received codes or pulse width data.
  *	The semantics are similar to a non-blocking read() call.
- * @rx_g_parameters: Get the current operating parameters and state of the
+ * @rx_g_parameters: Get the current operating parameters and state of
  *	the IR receiver.
- * @rx_s_parameters: Set the current operating parameters and state of the
+ * @rx_s_parameters: Set the current operating parameters and state of
  *	the IR receiver.  It is recommended to call
  *	[rt]x_g_parameters first to fill out the current state, and only change
  *	the fields that need to be changed.  Upon return, the actual device
@@ -582,9 +582,9 @@ struct v4l2_subdev_ir_parameters {
  *
  * @tx_write: Writes codes or pulse width data for transmission.
  *	The semantics are similar to a non-blocking write() call.
- * @tx_g_parameters: Get the current operating parameters and state of the
+ * @tx_g_parameters: Get the current operating parameters and state of
  *	the IR transmitter.
- * @tx_s_parameters: Set the current operating parameters and state of the
+ * @tx_s_parameters: Set the current operating parameters and state of
  *	the IR transmitter.  It is recommended to call
  *	[rt]x_g_parameters first to fill out the current state, and only change
  *	the fields that need to be changed.  Upon return, the actual device

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 3/5] media/dvbdev.h: fix duplicated word in comment
  2020-07-14 22:05 ` [PATCH 3/5] media/dvbdev.h: fix " Randy Dunlap
@ 2020-07-15  0:51   ` Joe Perches
  0 siblings, 0 replies; 10+ messages in thread
From: Joe Perches @ 2020-07-15  0:51 UTC (permalink / raw)
  To: Randy Dunlap, linux-kernel; +Cc: Mauro Carvalho Chehab, linux-media

On Tue, 2020-07-14 at 15:05 -0700, Randy Dunlap wrote:
> Change the doubled word "the" in a comment to "to the".

Hey 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: linux-media@vger.kernel.org
> ---
>  include/media/dvbdev.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20200714.orig/include/media/dvbdev.h
> +++ linux-next-20200714/include/media/dvbdev.h
> @@ -385,7 +385,7 @@ struct i2c_client;
>   * with dvb_module_probe() should use dvb_module_release() to unbind.
>   *
>   * Return:
> - *	On success, return an &struct i2c_client, pointing the the bound
> + *	On success, return an &struct i2c_client, pointing to the bound

an &struct reads OK as text, but does not as rst/html

Perhaps this should be:

   return the address of the bound &struct i2c_client device
or
   return a pointer to the bound &struct i2c_client device

otherwise the html output is

   Return

   On success, return an struct i2c_client, pointing to the bound
   I2C device. NULL otherwise.

and there seem to be too many commas used as well.




^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/5] media/media-device.h: drop duplicated word in comment
  2020-07-14 22:05 [PATCH 1/5] media/media-device.h: drop duplicated word in comment Randy Dunlap
                   ` (3 preceding siblings ...)
  2020-07-14 22:05 ` [PATCH 5/5] media/v4l2-subdev.h: " Randy Dunlap
@ 2020-07-17 11:59 ` Kieran Bingham
  4 siblings, 0 replies; 10+ messages in thread
From: Kieran Bingham @ 2020-07-17 11:59 UTC (permalink / raw)
  To: Randy Dunlap, linux-kernel; +Cc: Mauro Carvalho Chehab, linux-media

On 14/07/2020 23:05, Randy Dunlap wrote:
> Delete the doubled word "the" in a comment.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: linux-media@vger.kernel.org

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> ---
>  include/media/media-device.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20200714.orig/include/media/media-device.h
> +++ linux-next-20200714/include/media/media-device.h
> @@ -128,7 +128,7 @@ struct media_device_ops {
>   *
>   * Use-case: find tuner entity connected to the decoder
>   * entity and check if it is available, and activate the
> - * the link between them from @enable_source and deactivate
> + * link between them from @enable_source and deactivate
>   * from @disable_source.
>   *
>   * .. note::
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/5] media/media-devnode.h: drop duplicated word in comment
  2020-07-14 22:05 ` [PATCH 2/5] media/media-devnode.h: " Randy Dunlap
@ 2020-07-17 11:59   ` Kieran Bingham
  0 siblings, 0 replies; 10+ messages in thread
From: Kieran Bingham @ 2020-07-17 11:59 UTC (permalink / raw)
  To: Randy Dunlap, linux-kernel; +Cc: Mauro Carvalho Chehab, linux-media

On 14/07/2020 23:05, Randy Dunlap wrote:
> Delete the doubled word "the" in a comment.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: linux-media@vger.kernel.org
> ---
>  include/media/media-devnode.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20200714.orig/include/media/media-devnode.h
> +++ linux-next-20200714/include/media/media-devnode.h
> @@ -39,7 +39,7 @@ struct media_device;
>   * @poll: pointer to the function that implements poll() syscall
>   * @ioctl: pointer to the function that implements ioctl() syscall
>   * @compat_ioctl: pointer to the function that will handle 32 bits userspace
> - *	calls to the the ioctl() syscall on a Kernel compiled with 64 bits.
> + *	calls to the ioctl() syscall on a Kernel compiled with 64 bits.
>   * @open: pointer to the function that implements open() syscall
>   * @release: pointer to the function that will release the resources allocated
>   *	by the @open function.
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 4/5] media/media-entity.h: drop duplicated word in comment
  2020-07-14 22:05 ` [PATCH 4/5] media/media-entity.h: drop " Randy Dunlap
@ 2020-07-17 12:00   ` Kieran Bingham
  0 siblings, 0 replies; 10+ messages in thread
From: Kieran Bingham @ 2020-07-17 12:00 UTC (permalink / raw)
  To: Randy Dunlap, linux-kernel; +Cc: Mauro Carvalho Chehab, linux-media

On 14/07/2020 23:05, Randy Dunlap wrote:
> Delete the doubled word "flag" in a comment.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: linux-media@vger.kernel.org

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> ---
>  include/media/media-entity.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20200714.orig/include/media/media-entity.h
> +++ linux-next-20200714/include/media/media-entity.h
> @@ -803,7 +803,7 @@ int __media_entity_setup_link(struct med
>   * @flags:	the requested new link flags
>   *
>   * The only configurable property is the %MEDIA_LNK_FL_ENABLED link flag
> - * flag to enable/disable a link. Links marked with the
> + * to enable/disable a link. Links marked with the
>   * %MEDIA_LNK_FL_IMMUTABLE link flag can not be enabled or disabled.
>   *
>   * When a link is enabled or disabled, the media framework calls the
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 5/5] media/v4l2-subdev.h: drop duplicated word in comment
  2020-07-14 22:05 ` [PATCH 5/5] media/v4l2-subdev.h: " Randy Dunlap
@ 2020-07-17 12:00   ` Kieran Bingham
  0 siblings, 0 replies; 10+ messages in thread
From: Kieran Bingham @ 2020-07-17 12:00 UTC (permalink / raw)
  To: Randy Dunlap, linux-kernel; +Cc: Mauro Carvalho Chehab, linux-media

On 14/07/2020 23:05, Randy Dunlap wrote:
> Delete the doubled words "the" in comments.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: linux-media@vger.kernel.org

I guess the second instance of the word could have also been removed, to
keep more content on the first line, which fits under 80chars, but I
don't think it really matters.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> ---
>  include/media/v4l2-subdev.h |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> --- linux-next-20200714.orig/include/media/v4l2-subdev.h
> +++ linux-next-20200714/include/media/v4l2-subdev.h
> @@ -566,9 +566,9 @@ struct v4l2_subdev_ir_parameters {
>   *
>   * @rx_read: Reads received codes or pulse width data.
>   *	The semantics are similar to a non-blocking read() call.
> - * @rx_g_parameters: Get the current operating parameters and state of the
> + * @rx_g_parameters: Get the current operating parameters and state of
>   *	the IR receiver.
> - * @rx_s_parameters: Set the current operating parameters and state of the
> + * @rx_s_parameters: Set the current operating parameters and state of
>   *	the IR receiver.  It is recommended to call
>   *	[rt]x_g_parameters first to fill out the current state, and only change
>   *	the fields that need to be changed.  Upon return, the actual device
> @@ -582,9 +582,9 @@ struct v4l2_subdev_ir_parameters {
>   *
>   * @tx_write: Writes codes or pulse width data for transmission.
>   *	The semantics are similar to a non-blocking write() call.
> - * @tx_g_parameters: Get the current operating parameters and state of the
> + * @tx_g_parameters: Get the current operating parameters and state of
>   *	the IR transmitter.
> - * @tx_s_parameters: Set the current operating parameters and state of the
> + * @tx_s_parameters: Set the current operating parameters and state of
>   *	the IR transmitter.  It is recommended to call
>   *	[rt]x_g_parameters first to fill out the current state, and only change
>   *	the fields that need to be changed.  Upon return, the actual device
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-07-17 12:00 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-14 22:05 [PATCH 1/5] media/media-device.h: drop duplicated word in comment Randy Dunlap
2020-07-14 22:05 ` [PATCH 2/5] media/media-devnode.h: " Randy Dunlap
2020-07-17 11:59   ` Kieran Bingham
2020-07-14 22:05 ` [PATCH 3/5] media/dvbdev.h: fix " Randy Dunlap
2020-07-15  0:51   ` Joe Perches
2020-07-14 22:05 ` [PATCH 4/5] media/media-entity.h: drop " Randy Dunlap
2020-07-17 12:00   ` Kieran Bingham
2020-07-14 22:05 ` [PATCH 5/5] media/v4l2-subdev.h: " Randy Dunlap
2020-07-17 12:00   ` Kieran Bingham
2020-07-17 11:59 ` [PATCH 1/5] media/media-device.h: " Kieran Bingham

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).