* Re: [PATCH] staging: davinci: drop pointless static qualifier in vpfe_resizer_init()
2019-03-11 14:14 [PATCH] staging: davinci: drop pointless static qualifier in vpfe_resizer_init() Mao Wenan
@ 2019-03-11 14:07 ` Dan Carpenter
2019-03-11 14:10 ` Colin Ian King
2019-03-11 14:17 ` maowenan
0 siblings, 2 replies; 5+ messages in thread
From: Dan Carpenter @ 2019-03-11 14:07 UTC (permalink / raw)
To: Mao Wenan
Cc: gregkh, Julia.Lawall, kimbrownkd, colin.king, hans.verkuil,
linux-media, devel
On Mon, Mar 11, 2019 at 10:14:05PM +0800, Mao Wenan wrote:
> There is no need to have the 'T *v' variable static
> since new value always be assigned before use it.
>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> drivers/staging/media/davinci_vpfe/dm365_resizer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_resizer.c b/drivers/staging/media/davinci_vpfe/dm365_resizer.c
> index 6098f43ac51b..a2a672d4615d 100644
> --- a/drivers/staging/media/davinci_vpfe/dm365_resizer.c
> +++ b/drivers/staging/media/davinci_vpfe/dm365_resizer.c
> @@ -1881,7 +1881,7 @@ int vpfe_resizer_init(struct vpfe_resizer_device *vpfe_rsz,
> struct v4l2_subdev *sd = &vpfe_rsz->crop_resizer.subdev;
> struct media_pad *pads = &vpfe_rsz->crop_resizer.pads[0];
> struct media_entity *me = &sd->entity;
> - static resource_size_t res_len;
> + resource_size_t res_len;
^
Could you remove the extra space character also, please.
> struct resource *res;
> int ret;
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: davinci: drop pointless static qualifier in vpfe_resizer_init()
2019-03-11 14:07 ` Dan Carpenter
@ 2019-03-11 14:10 ` Colin Ian King
2019-03-11 14:37 ` Dan Carpenter
2019-03-11 14:17 ` maowenan
1 sibling, 1 reply; 5+ messages in thread
From: Colin Ian King @ 2019-03-11 14:10 UTC (permalink / raw)
To: Dan Carpenter, Mao Wenan
Cc: gregkh, Julia.Lawall, kimbrownkd, hans.verkuil, linux-media, devel
On 11/03/2019 14:07, Dan Carpenter wrote:
> On Mon, Mar 11, 2019 at 10:14:05PM +0800, Mao Wenan wrote:
>> There is no need to have the 'T *v' variable static
>> since new value always be assigned before use it.
>>
>> Signed-off-by: Mao Wenan <maowenan@huawei.com>
>> ---
>> drivers/staging/media/davinci_vpfe/dm365_resizer.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/media/davinci_vpfe/dm365_resizer.c b/drivers/staging/media/davinci_vpfe/dm365_resizer.c
>> index 6098f43ac51b..a2a672d4615d 100644
>> --- a/drivers/staging/media/davinci_vpfe/dm365_resizer.c
>> +++ b/drivers/staging/media/davinci_vpfe/dm365_resizer.c
>> @@ -1881,7 +1881,7 @@ int vpfe_resizer_init(struct vpfe_resizer_device *vpfe_rsz,
>> struct v4l2_subdev *sd = &vpfe_rsz->crop_resizer.subdev;
>> struct media_pad *pads = &vpfe_rsz->crop_resizer.pads[0];
>> struct media_entity *me = &sd->entity;
>> - static resource_size_t res_len;
>> + resource_size_t res_len;
> ^
> Could you remove the extra space character also, please.
shouldn't checkpatch find these?
>
>> struct resource *res;
>> int ret;
>
> regards,
> dan carpenter
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] staging: davinci: drop pointless static qualifier in vpfe_resizer_init()
@ 2019-03-11 14:14 Mao Wenan
2019-03-11 14:07 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Mao Wenan @ 2019-03-11 14:14 UTC (permalink / raw)
To: gregkh, Julia.Lawall, kimbrownkd, colin.king, hans.verkuil,
linux-media, devel
There is no need to have the 'T *v' variable static
since new value always be assigned before use it.
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
drivers/staging/media/davinci_vpfe/dm365_resizer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/davinci_vpfe/dm365_resizer.c b/drivers/staging/media/davinci_vpfe/dm365_resizer.c
index 6098f43ac51b..a2a672d4615d 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_resizer.c
+++ b/drivers/staging/media/davinci_vpfe/dm365_resizer.c
@@ -1881,7 +1881,7 @@ int vpfe_resizer_init(struct vpfe_resizer_device *vpfe_rsz,
struct v4l2_subdev *sd = &vpfe_rsz->crop_resizer.subdev;
struct media_pad *pads = &vpfe_rsz->crop_resizer.pads[0];
struct media_entity *me = &sd->entity;
- static resource_size_t res_len;
+ resource_size_t res_len;
struct resource *res;
int ret;
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: davinci: drop pointless static qualifier in vpfe_resizer_init()
2019-03-11 14:07 ` Dan Carpenter
2019-03-11 14:10 ` Colin Ian King
@ 2019-03-11 14:17 ` maowenan
1 sibling, 0 replies; 5+ messages in thread
From: maowenan @ 2019-03-11 14:17 UTC (permalink / raw)
To: Dan Carpenter
Cc: gregkh, Julia.Lawall, kimbrownkd, colin.king, hans.verkuil,
linux-media, devel, kernel-janitors
On 2019/3/11 22:07, Dan Carpenter wrote:
> On Mon, Mar 11, 2019 at 10:14:05PM +0800, Mao Wenan wrote:
>> There is no need to have the 'T *v' variable static
>> since new value always be assigned before use it.
>>
>> Signed-off-by: Mao Wenan <maowenan@huawei.com>
>> ---
>> drivers/staging/media/davinci_vpfe/dm365_resizer.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/media/davinci_vpfe/dm365_resizer.c b/drivers/staging/media/davinci_vpfe/dm365_resizer.c
>> index 6098f43ac51b..a2a672d4615d 100644
>> --- a/drivers/staging/media/davinci_vpfe/dm365_resizer.c
>> +++ b/drivers/staging/media/davinci_vpfe/dm365_resizer.c
>> @@ -1881,7 +1881,7 @@ int vpfe_resizer_init(struct vpfe_resizer_device *vpfe_rsz,
>> struct v4l2_subdev *sd = &vpfe_rsz->crop_resizer.subdev;
>> struct media_pad *pads = &vpfe_rsz->crop_resizer.pads[0];
>> struct media_entity *me = &sd->entity;
>> - static resource_size_t res_len;
>> + resource_size_t res_len;
> ^
> Could you remove the extra space character also, please.
sure, I will do this, sorry, I don't pay attention to the old code style.
>
>> struct resource *res;
>> int ret;
>
> regards,
> dan carpenter
>
>
>
> .
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: davinci: drop pointless static qualifier in vpfe_resizer_init()
2019-03-11 14:10 ` Colin Ian King
@ 2019-03-11 14:37 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2019-03-11 14:37 UTC (permalink / raw)
To: Colin Ian King
Cc: Mao Wenan, gregkh, Julia.Lawall, kimbrownkd, hans.verkuil,
linux-media, devel
On Mon, Mar 11, 2019 at 02:10:12PM +0000, Colin Ian King wrote:
> On 11/03/2019 14:07, Dan Carpenter wrote:
> > On Mon, Mar 11, 2019 at 10:14:05PM +0800, Mao Wenan wrote:
> >> There is no need to have the 'T *v' variable static
> >> since new value always be assigned before use it.
> >>
> >> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> >> ---
> >> drivers/staging/media/davinci_vpfe/dm365_resizer.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/staging/media/davinci_vpfe/dm365_resizer.c b/drivers/staging/media/davinci_vpfe/dm365_resizer.c
> >> index 6098f43ac51b..a2a672d4615d 100644
> >> --- a/drivers/staging/media/davinci_vpfe/dm365_resizer.c
> >> +++ b/drivers/staging/media/davinci_vpfe/dm365_resizer.c
> >> @@ -1881,7 +1881,7 @@ int vpfe_resizer_init(struct vpfe_resizer_device *vpfe_rsz,
> >> struct v4l2_subdev *sd = &vpfe_rsz->crop_resizer.subdev;
> >> struct media_pad *pads = &vpfe_rsz->crop_resizer.pads[0];
> >> struct media_entity *me = &sd->entity;
> >> - static resource_size_t res_len;
> >> + resource_size_t res_len;
> > ^
> > Could you remove the extra space character also, please.
>
> shouldn't checkpatch find these?
>
We would sometimes want to add extra spaces to make struct declarations
line up in a header file.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-11 14:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-11 14:14 [PATCH] staging: davinci: drop pointless static qualifier in vpfe_resizer_init() Mao Wenan
2019-03-11 14:07 ` Dan Carpenter
2019-03-11 14:10 ` Colin Ian King
2019-03-11 14:37 ` Dan Carpenter
2019-03-11 14:17 ` maowenan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).