linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] atomisp:pci/runtime/queue: modify the return error value
@ 2020-09-17  3:44 Xiaoliang Pang
  2020-09-17  5:31 ` Tianjia Zhang
  0 siblings, 1 reply; 2+ messages in thread
From: Xiaoliang Pang @ 2020-09-17  3:44 UTC (permalink / raw)
  To: mchehab, sakari.ailus, gregkh
  Cc: dawning.pang, alexander.deucher, evan.quan, christian.koenig,
	linux-media, devel, linux-kernel, tianjia.zhang

modify the return error value is -EDOM

Fixes: 2cac05dee6e30("drm/amd/powerplay: add the hw manager for vega12 (v4)")
Cc: Evan Quan <evan.quan@amd.com>
Signed-off-by: Xiaoliang Pang <dawning.pang@gmail.com>
---
 .../staging/media/atomisp/pci/runtime/queue/src/queue_access.c  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c
index fdca743c4ab7..424e7a15a389 100644
--- a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c
+++ b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c
@@ -44,7 +44,7 @@ int ia_css_queue_load(
 				   the value as zero. This causes division by 0
 				   exception as the size is used in a modular
 				   division operation. */
-				return EDOM;
+				return -EDOM;
 			}
 		}
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] atomisp:pci/runtime/queue: modify the return error value
  2020-09-17  3:44 [PATCH v1] atomisp:pci/runtime/queue: modify the return error value Xiaoliang Pang
@ 2020-09-17  5:31 ` Tianjia Zhang
  0 siblings, 0 replies; 2+ messages in thread
From: Tianjia Zhang @ 2020-09-17  5:31 UTC (permalink / raw)
  To: Xiaoliang Pang, mchehab, sakari.ailus, gregkh
  Cc: alexander.deucher, evan.quan, christian.koenig, linux-media,
	devel, linux-kernel

LGTM.

Reviewed-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>

On 9/17/20 11:44 AM, Xiaoliang Pang wrote:
> modify the return error value is -EDOM
> 
> Fixes: 2cac05dee6e30("drm/amd/powerplay: add the hw manager for vega12 (v4)")
> Cc: Evan Quan <evan.quan@amd.com>
> Signed-off-by: Xiaoliang Pang <dawning.pang@gmail.com>
> ---
>   .../staging/media/atomisp/pci/runtime/queue/src/queue_access.c  | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c
> index fdca743c4ab7..424e7a15a389 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c
> +++ b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c
> @@ -44,7 +44,7 @@ int ia_css_queue_load(
>   				   the value as zero. This causes division by 0
>   				   exception as the size is used in a modular
>   				   division operation. */
> -				return EDOM;
> +				return -EDOM;
>   			}
>   		}
>   
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-17  5:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-17  3:44 [PATCH v1] atomisp:pci/runtime/queue: modify the return error value Xiaoliang Pang
2020-09-17  5:31 ` Tianjia Zhang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).