* [PATCH v4 0/3] Add rga to rk322x device tree
@ 2020-02-03 22:30 Justin Swartz
2020-02-03 22:40 ` [PATCH v4 1/3] [media] dt-bindings: Add binding for rk3228 rga Justin Swartz
0 siblings, 1 reply; 4+ messages in thread
From: Justin Swartz @ 2020-02-03 22:30 UTC (permalink / raw)
To: Jacob Chen, Ezequiel Garcia, Mauro Carvalho Chehab, Rob Herring,
Mark Rutland, Heiko Stuebner, linux-media, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel
Cc: Justin Swartz
This patchset aims to enable use of Rockchip's RGA, a 2D raster
graphic acceleration unit, on rk322x based devices.
Changes in v4:
- Add a compatible value entry for the rk3228 to the rockchip-rga
device tree binding documentation.
Changes in v3:
- Relocate rga node to the correct position in rk322x.dtsi, as
indicated by Johan Jonker.
Changes in v2:
- Remove unnecessary "rockchip,rk3228-rga" device tree compatibility
string patch, as advised by Ezequiel Garcia.
- Use both "rockchip,rk3228-rga" and "rockchip,rk3288-rga" in the
rga node's compatibility property, as suggested by Heiko Stuebner.
Justin Swartz (3):
[media] dt-bindings: Add binding for rk3228 rga
ARM: dts: rockchip: add rga node for rk322x
ARM: dts: rockchip: enable rga for rk3229-xms6
Documentation/devicetree/bindings/media/rockchip-rga.txt | 5 +++--
arch/arm/boot/dts/rk3229-xms6.dts | 4 ++++
arch/arm/boot/dts/rk322x.dtsi | 11 +++++++++++
3 files changed, 18 insertions(+), 2 deletions(-)
--
2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v4 1/3] [media] dt-bindings: Add binding for rk3228 rga
2020-02-03 22:30 [PATCH v4 0/3] Add rga to rk322x device tree Justin Swartz
@ 2020-02-03 22:40 ` Justin Swartz
2020-02-06 19:06 ` Rob Herring
2020-03-01 0:29 ` Heiko Stuebner
0 siblings, 2 replies; 4+ messages in thread
From: Justin Swartz @ 2020-02-03 22:40 UTC (permalink / raw)
To: Jacob Chen, Ezequiel Garcia, Mauro Carvalho Chehab, Rob Herring,
Mark Rutland, Heiko Stuebner
Cc: Justin Swartz, linux-media, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel
Indicate that the rk3228 rga is compatible with that of the rk3288.
But if any rk3228-specific quirks are identified in future that
require handling logic that differs from what is provided for the
rk3288, then allow for the compatibility string "rockchip,rk3228-rga"
to be matched instead of "rockchip,rk3288-rga".
Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
---
Documentation/devicetree/bindings/media/rockchip-rga.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/rockchip-rga.txt b/Documentation/devicetree/bindings/media/rockchip-rga.txt
index fd5276abf..c53a8e513 100644
--- a/Documentation/devicetree/bindings/media/rockchip-rga.txt
+++ b/Documentation/devicetree/bindings/media/rockchip-rga.txt
@@ -6,8 +6,9 @@ BitBLT, alpha blending and image blur/sharpness.
Required properties:
- compatible: value should be one of the following
- "rockchip,rk3288-rga";
- "rockchip,rk3399-rga";
+ "rockchip,rk3228-rga", "rockchip,rk3288-rga": for Rockchip RK3228
+ "rockchip,rk3288-rga": for Rockchip RK3288
+ "rockchip,rk3399-rga": for Rockchip RK3399
- interrupts: RGA interrupt specifier.
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v4 1/3] [media] dt-bindings: Add binding for rk3228 rga
2020-02-03 22:40 ` [PATCH v4 1/3] [media] dt-bindings: Add binding for rk3228 rga Justin Swartz
@ 2020-02-06 19:06 ` Rob Herring
2020-03-01 0:29 ` Heiko Stuebner
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2020-02-06 19:06 UTC (permalink / raw)
To: Justin Swartz
Cc: Jacob Chen, Ezequiel Garcia, Mauro Carvalho Chehab, Mark Rutland,
Heiko Stuebner, Justin Swartz, linux-media, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel
On Mon, 3 Feb 2020 22:40:15 +0000, Justin Swartz wrote:
> Indicate that the rk3228 rga is compatible with that of the rk3288.
>
> But if any rk3228-specific quirks are identified in future that
> require handling logic that differs from what is provided for the
> rk3288, then allow for the compatibility string "rockchip,rk3228-rga"
> to be matched instead of "rockchip,rk3288-rga".
>
> Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
> ---
> Documentation/devicetree/bindings/media/rockchip-rga.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4 1/3] [media] dt-bindings: Add binding for rk3228 rga
2020-02-03 22:40 ` [PATCH v4 1/3] [media] dt-bindings: Add binding for rk3228 rga Justin Swartz
2020-02-06 19:06 ` Rob Herring
@ 2020-03-01 0:29 ` Heiko Stuebner
1 sibling, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2020-03-01 0:29 UTC (permalink / raw)
To: Justin Swartz, Mauro Carvalho Chehab
Cc: Jacob Chen, Ezequiel Garcia, Rob Herring, Mark Rutland,
linux-media, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel
Hi Mauro,
Am Montag, 3. Februar 2020, 23:40:15 CET schrieb Justin Swartz:
> Indicate that the rk3228 rga is compatible with that of the rk3288.
>
> But if any rk3228-specific quirks are identified in future that
> require handling logic that differs from what is provided for the
> rk3288, then allow for the compatibility string "rockchip,rk3228-rga"
> to be matched instead of "rockchip,rk3288-rga".
>
> Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
what is the process in the media-world for this dt-binding only patch?
Do you want to apply it, or should I just also apply it with the following
2 dt-patches? There shouldn't be any conflicts with the media tree
as this patch really only affects the rga binding document.
Thanks
Heiko
> ---
> Documentation/devicetree/bindings/media/rockchip-rga.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/rockchip-rga.txt b/Documentation/devicetree/bindings/media/rockchip-rga.txt
> index fd5276abf..c53a8e513 100644
> --- a/Documentation/devicetree/bindings/media/rockchip-rga.txt
> +++ b/Documentation/devicetree/bindings/media/rockchip-rga.txt
> @@ -6,8 +6,9 @@ BitBLT, alpha blending and image blur/sharpness.
>
> Required properties:
> - compatible: value should be one of the following
> - "rockchip,rk3288-rga";
> - "rockchip,rk3399-rga";
> + "rockchip,rk3228-rga", "rockchip,rk3288-rga": for Rockchip RK3228
> + "rockchip,rk3288-rga": for Rockchip RK3288
> + "rockchip,rk3399-rga": for Rockchip RK3399
>
> - interrupts: RGA interrupt specifier.
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-01 0:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-03 22:30 [PATCH v4 0/3] Add rga to rk322x device tree Justin Swartz
2020-02-03 22:40 ` [PATCH v4 1/3] [media] dt-bindings: Add binding for rk3228 rga Justin Swartz
2020-02-06 19:06 ` Rob Herring
2020-03-01 0:29 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).