* [PATCH v5 0/3] introduce more MDP3 components in mt8195
@ 2023-09-12 7:56 Moudy Ho
2023-09-12 7:56 ` [PATCH v5 1/3] dt-binding: mediatek: correct MDP3 node with generic names Moudy Ho
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Moudy Ho @ 2023-09-12 7:56 UTC (permalink / raw)
To: Chun-Kuang Hu, Philipp Zabel, David Airlie, Daniel Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Mauro Carvalho Chehab, Matthias Brugger, Hans Verkuil
Cc: AngeloGioacchino Del Regno, dri-devel, linux-mediatek,
devicetree, linux-kernel, linux-media, linux-arm-kernel,
Moudy Ho
Changes since v4:
- Rebase on v6.6-rc1
- Organize identical hardware components into their respective files.
Hi,
The purpose of this patch is to separate the MDP3-related bindings from
the original mailing list mentioned below:
https://lore.kernel.org/all/20230208092209.19472-1-moudy.ho@mediatek.com/
Those binding files describe additional components that
are present in the mt8195.
Moudy Ho (3):
dt-binding: mediatek: correct MDP3 node with generic names
dt-binding: mediatek: integrate MDP RDMA to one binding
dt-binding: mediatek: add MediaTek mt8195 MDP3 components
.../display/mediatek/mediatek,aal.yaml | 2 +-
.../display/mediatek/mediatek,color.yaml | 2 +-
.../display/mediatek/mediatek,mdp-rdma.yaml | 88 -------------------
.../display/mediatek/mediatek,merge.yaml | 1 +
.../display/mediatek/mediatek,ovl.yaml | 2 +-
.../display/mediatek/mediatek,split.yaml | 1 +
.../bindings/media/mediatek,mdp3-fg.yaml | 61 +++++++++++++
.../bindings/media/mediatek,mdp3-hdr.yaml | 60 +++++++++++++
.../bindings/media/mediatek,mdp3-pad.yaml | 61 +++++++++++++
.../bindings/media/mediatek,mdp3-rdma.yaml | 50 ++++++-----
.../bindings/media/mediatek,mdp3-stitch.yaml | 61 +++++++++++++
.../bindings/media/mediatek,mdp3-tcc.yaml | 60 +++++++++++++
.../bindings/media/mediatek,mdp3-tdshp.yaml | 61 +++++++++++++
.../bindings/media/mediatek,mdp3-wrot.yaml | 23 +++--
14 files changed, 412 insertions(+), 121 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml
create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-fg.yaml
create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-hdr.yaml
create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-pad.yaml
create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-stitch.yaml
create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-tcc.yaml
create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-tdshp.yaml
--
2.18.0
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v5 1/3] dt-binding: mediatek: correct MDP3 node with generic names
2023-09-12 7:56 [PATCH v5 0/3] introduce more MDP3 components in mt8195 Moudy Ho
@ 2023-09-12 7:56 ` Moudy Ho
2023-09-12 7:56 ` [PATCH v5 2/3] dt-binding: mediatek: integrate MDP RDMA to one binding Moudy Ho
2023-09-12 7:56 ` [PATCH v5 3/3] dt-binding: mediatek: add MediaTek mt8195 MDP3 components Moudy Ho
2 siblings, 0 replies; 10+ messages in thread
From: Moudy Ho @ 2023-09-12 7:56 UTC (permalink / raw)
To: Chun-Kuang Hu, Philipp Zabel, David Airlie, Daniel Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Mauro Carvalho Chehab, Matthias Brugger, Hans Verkuil
Cc: AngeloGioacchino Del Regno, dri-devel, linux-mediatek,
devicetree, linux-kernel, linux-media, linux-arm-kernel,
Moudy Ho
The DMA-related nodes RDMA/WROT in MDP3 should be changed to generic names.
In addition, fix improper space indent in example.
Fixes: 4ad7b39623ab ("media: dt-binding: mediatek: add bindings for MediaTek MDP3 components")
Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
Acked-by: Rob Herring <robh@kernel.org>
---
.../bindings/media/mediatek,mdp3-rdma.yaml | 29 +++++++++++--------
.../bindings/media/mediatek,mdp3-wrot.yaml | 23 +++++++++------
2 files changed, 31 insertions(+), 21 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
index 7032c7e15039..3e128733ef53 100644
--- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
@@ -61,6 +61,9 @@ properties:
- description: used for 1st data pipe from RDMA
- description: used for 2nd data pipe from RDMA
+ '#dma-cells':
+ const: 1
+
required:
- compatible
- reg
@@ -70,6 +73,7 @@ required:
- clocks
- iommus
- mboxes
+ - '#dma-cells'
additionalProperties: false
@@ -80,16 +84,17 @@ examples:
#include <dt-bindings/power/mt8183-power.h>
#include <dt-bindings/memory/mt8183-larb-port.h>
- mdp3_rdma0: mdp3-rdma0@14001000 {
- compatible = "mediatek,mt8183-mdp3-rdma";
- reg = <0x14001000 0x1000>;
- mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0x1000 0x1000>;
- mediatek,gce-events = <CMDQ_EVENT_MDP_RDMA0_SOF>,
- <CMDQ_EVENT_MDP_RDMA0_EOF>;
- power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
- clocks = <&mmsys CLK_MM_MDP_RDMA0>,
- <&mmsys CLK_MM_MDP_RSZ1>;
- iommus = <&iommu>;
- mboxes = <&gce 20 CMDQ_THR_PRIO_LOWEST>,
- <&gce 21 CMDQ_THR_PRIO_LOWEST>;
+ dma-controller@14001000 {
+ compatible = "mediatek,mt8183-mdp3-rdma";
+ reg = <0x14001000 0x1000>;
+ mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0x1000 0x1000>;
+ mediatek,gce-events = <CMDQ_EVENT_MDP_RDMA0_SOF>,
+ <CMDQ_EVENT_MDP_RDMA0_EOF>;
+ power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
+ clocks = <&mmsys CLK_MM_MDP_RDMA0>,
+ <&mmsys CLK_MM_MDP_RSZ1>;
+ iommus = <&iommu>;
+ mboxes = <&gce 20 CMDQ_THR_PRIO_LOWEST>,
+ <&gce 21 CMDQ_THR_PRIO_LOWEST>;
+ #dma-cells = <1>;
};
diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml
index 0baa77198fa2..64ea98aa0592 100644
--- a/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml
@@ -50,6 +50,9 @@ properties:
iommus:
maxItems: 1
+ '#dma-cells':
+ const: 1
+
required:
- compatible
- reg
@@ -58,6 +61,7 @@ required:
- power-domains
- clocks
- iommus
+ - '#dma-cells'
additionalProperties: false
@@ -68,13 +72,14 @@ examples:
#include <dt-bindings/power/mt8183-power.h>
#include <dt-bindings/memory/mt8183-larb-port.h>
- mdp3_wrot0: mdp3-wrot0@14005000 {
- compatible = "mediatek,mt8183-mdp3-wrot";
- reg = <0x14005000 0x1000>;
- mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0x5000 0x1000>;
- mediatek,gce-events = <CMDQ_EVENT_MDP_WROT0_SOF>,
- <CMDQ_EVENT_MDP_WROT0_EOF>;
- power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
- clocks = <&mmsys CLK_MM_MDP_WROT0>;
- iommus = <&iommu>;
+ dma-controller@14005000 {
+ compatible = "mediatek,mt8183-mdp3-wrot";
+ reg = <0x14005000 0x1000>;
+ mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0x5000 0x1000>;
+ mediatek,gce-events = <CMDQ_EVENT_MDP_WROT0_SOF>,
+ <CMDQ_EVENT_MDP_WROT0_EOF>;
+ power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
+ clocks = <&mmsys CLK_MM_MDP_WROT0>;
+ iommus = <&iommu>;
+ #dma-cells = <1>;
};
--
2.18.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v5 2/3] dt-binding: mediatek: integrate MDP RDMA to one binding
2023-09-12 7:56 [PATCH v5 0/3] introduce more MDP3 components in mt8195 Moudy Ho
2023-09-12 7:56 ` [PATCH v5 1/3] dt-binding: mediatek: correct MDP3 node with generic names Moudy Ho
@ 2023-09-12 7:56 ` Moudy Ho
2023-09-12 8:16 ` Krzysztof Kozlowski
2023-09-12 7:56 ` [PATCH v5 3/3] dt-binding: mediatek: add MediaTek mt8195 MDP3 components Moudy Ho
2 siblings, 1 reply; 10+ messages in thread
From: Moudy Ho @ 2023-09-12 7:56 UTC (permalink / raw)
To: Chun-Kuang Hu, Philipp Zabel, David Airlie, Daniel Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Mauro Carvalho Chehab, Matthias Brugger, Hans Verkuil
Cc: AngeloGioacchino Del Regno, dri-devel, linux-mediatek,
devicetree, linux-kernel, linux-media, linux-arm-kernel,
Moudy Ho
Due to the same hardware design, MDP RDMA needs to
be integrated into the same binding.
Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
---
.../display/mediatek/mediatek,mdp-rdma.yaml | 88 -------------------
.../bindings/media/mediatek,mdp3-rdma.yaml | 5 +-
2 files changed, 3 insertions(+), 90 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml
deleted file mode 100644
index dd12e2ff685c..000000000000
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml
+++ /dev/null
@@ -1,88 +0,0 @@
-# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
-%YAML 1.2
----
-$id: http://devicetree.org/schemas/display/mediatek/mediatek,mdp-rdma.yaml#
-$schema: http://devicetree.org/meta-schemas/core.yaml#
-
-title: MediaTek MDP RDMA
-
-maintainers:
- - Chun-Kuang Hu <chunkuang.hu@kernel.org>
- - Philipp Zabel <p.zabel@pengutronix.de>
-
-description:
- The MediaTek MDP RDMA stands for Read Direct Memory Access.
- It provides real time data to the back-end panel driver, such as DSI,
- DPI and DP_INTF.
- It contains one line buffer to store the sufficient pixel data.
- RDMA device node must be siblings to the central MMSYS_CONFIG node.
- For a description of the MMSYS_CONFIG binding, see
- Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml for details.
-
-properties:
- compatible:
- const: mediatek,mt8195-vdo1-rdma
-
- reg:
- maxItems: 1
-
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- clocks:
- items:
- - description: RDMA Clock
-
- iommus:
- maxItems: 1
-
- mediatek,gce-client-reg:
- description:
- The register of display function block to be set by gce. There are 4 arguments,
- such as gce node, subsys id, offset and register size. The subsys id that is
- mapping to the register of display function blocks is defined in the gce header
- include/dt-bindings/gce/<chip>-gce.h of each chips.
- $ref: /schemas/types.yaml#/definitions/phandle-array
- items:
- items:
- - description: phandle of GCE
- - description: GCE subsys id
- - description: register offset
- - description: register size
- maxItems: 1
-
-required:
- - compatible
- - reg
- - power-domains
- - clocks
- - iommus
- - mediatek,gce-client-reg
-
-additionalProperties: false
-
-examples:
- - |
- #include <dt-bindings/interrupt-controller/arm-gic.h>
- #include <dt-bindings/clock/mt8195-clk.h>
- #include <dt-bindings/power/mt8195-power.h>
- #include <dt-bindings/gce/mt8195-gce.h>
- #include <dt-bindings/memory/mt8195-memory-port.h>
-
- soc {
- #address-cells = <2>;
- #size-cells = <2>;
-
- rdma@1c104000 {
- compatible = "mediatek,mt8195-vdo1-rdma";
- reg = <0 0x1c104000 0 0x1000>;
- interrupts = <GIC_SPI 495 IRQ_TYPE_LEVEL_HIGH 0>;
- clocks = <&vdosys1 CLK_VDO1_MDP_RDMA0>;
- power-domains = <&spm MT8195_POWER_DOMAIN_VDOSYS1>;
- iommus = <&iommu_vdo M4U_PORT_L2_MDP_RDMA0>;
- mediatek,gce-client-reg = <&gce0 SUBSYS_1c10XXXX 0x4000 0x1000>;
- };
- };
diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
index 3e128733ef53..0c22571d8c22 100644
--- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
@@ -20,8 +20,9 @@ description: |
properties:
compatible:
- items:
- - const: mediatek,mt8183-mdp3-rdma
+ enum:
+ - mediatek,mt8183-mdp3-rdma
+ - mediatek,mt8195-vdo1-rdma
reg:
maxItems: 1
--
2.18.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v5 3/3] dt-binding: mediatek: add MediaTek mt8195 MDP3 components
2023-09-12 7:56 [PATCH v5 0/3] introduce more MDP3 components in mt8195 Moudy Ho
2023-09-12 7:56 ` [PATCH v5 1/3] dt-binding: mediatek: correct MDP3 node with generic names Moudy Ho
2023-09-12 7:56 ` [PATCH v5 2/3] dt-binding: mediatek: integrate MDP RDMA to one binding Moudy Ho
@ 2023-09-12 7:56 ` Moudy Ho
2023-09-12 8:19 ` Krzysztof Kozlowski
2 siblings, 1 reply; 10+ messages in thread
From: Moudy Ho @ 2023-09-12 7:56 UTC (permalink / raw)
To: Chun-Kuang Hu, Philipp Zabel, David Airlie, Daniel Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Mauro Carvalho Chehab, Matthias Brugger, Hans Verkuil
Cc: AngeloGioacchino Del Regno, dri-devel, linux-mediatek,
devicetree, linux-kernel, linux-media, linux-arm-kernel,
Moudy Ho
Introduce more MDP3 components present in MT8195.
Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
---
.../display/mediatek/mediatek,aal.yaml | 2 +-
.../display/mediatek/mediatek,color.yaml | 2 +-
.../display/mediatek/mediatek,merge.yaml | 1 +
.../display/mediatek/mediatek,ovl.yaml | 2 +-
.../display/mediatek/mediatek,split.yaml | 1 +
.../bindings/media/mediatek,mdp3-fg.yaml | 61 +++++++++++++++++++
.../bindings/media/mediatek,mdp3-hdr.yaml | 60 ++++++++++++++++++
.../bindings/media/mediatek,mdp3-pad.yaml | 61 +++++++++++++++++++
.../bindings/media/mediatek,mdp3-rdma.yaml | 16 ++---
.../bindings/media/mediatek,mdp3-stitch.yaml | 61 +++++++++++++++++++
.../bindings/media/mediatek,mdp3-tcc.yaml | 60 ++++++++++++++++++
.../bindings/media/mediatek,mdp3-tdshp.yaml | 61 +++++++++++++++++++
12 files changed, 378 insertions(+), 10 deletions(-)
create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-fg.yaml
create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-hdr.yaml
create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-pad.yaml
create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-stitch.yaml
create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-tcc.yaml
create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-tdshp.yaml
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
index 7fd42c8fdc32..04b1314d00f2 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
@@ -24,6 +24,7 @@ properties:
- enum:
- mediatek,mt8173-disp-aal
- mediatek,mt8183-disp-aal
+ - mediatek,mt8195-mdp3-aal
- items:
- enum:
- mediatek,mt2712-disp-aal
@@ -63,7 +64,6 @@ properties:
required:
- compatible
- reg
- - interrupts
- power-domains
- clocks
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml
index f21e44092043..8e97b0a6a7b3 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml
@@ -26,6 +26,7 @@ properties:
- mediatek,mt2701-disp-color
- mediatek,mt8167-disp-color
- mediatek,mt8173-disp-color
+ - mediatek,mt8195-mdp3-color
- items:
- enum:
- mediatek,mt7623-disp-color
@@ -66,7 +67,6 @@ properties:
required:
- compatible
- reg
- - interrupts
- power-domains
- clocks
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml
index eead5cb8636e..401498523404 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml
@@ -24,6 +24,7 @@ properties:
- enum:
- mediatek,mt8173-disp-merge
- mediatek,mt8195-disp-merge
+ - mediatek,mt8195-mdp3-merge
- items:
- const: mediatek,mt6795-disp-merge
- const: mediatek,mt8173-disp-merge
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
index 3e1069b00b56..10d4d4f64e09 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
@@ -26,6 +26,7 @@ properties:
- mediatek,mt8173-disp-ovl
- mediatek,mt8183-disp-ovl
- mediatek,mt8192-disp-ovl
+ - mediatek,mt8195-mdp3-ovl
- items:
- enum:
- mediatek,mt7623-disp-ovl
@@ -76,7 +77,6 @@ properties:
required:
- compatible
- reg
- - interrupts
- power-domains
- clocks
- iommus
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml
index a8a5c9608598..a96b271e3240 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml
@@ -23,6 +23,7 @@ properties:
oneOf:
- enum:
- mediatek,mt8173-disp-split
+ - mediatek,mt8195-mdp3-split
- items:
- const: mediatek,mt6795-disp-split
- const: mediatek,mt8173-disp-split
diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-fg.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-fg.yaml
new file mode 100644
index 000000000000..71fd449de8b4
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-fg.yaml
@@ -0,0 +1,61 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/mediatek,mdp3-fg.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek Media Data Path 3 FG
+
+maintainers:
+ - Matthias Brugger <matthias.bgg@gmail.com>
+ - Moudy Ho <moudy.ho@mediatek.com>
+
+description:
+ One of Media Data Path 3 (MDP3) components used to add film grain
+ according to AV1 spec.
+
+properties:
+ compatible:
+ enum:
+ - mediatek,mt8195-mdp3-fg
+
+ reg:
+ maxItems: 1
+
+ mediatek,gce-client-reg:
+ description:
+ The register of display function block to be set by gce. There are 4 arguments,
+ such as gce node, subsys id, offset and register size. The subsys id that is
+ mapping to the register of display function blocks is defined in the gce header
+ include/dt-bindings/gce/<chip>-gce.h of each chips.
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ items:
+ items:
+ - description: phandle of GCE
+ - description: GCE subsys id
+ - description: register offset
+ - description: register size
+ maxItems: 1
+
+ clocks:
+ minItems: 1
+
+required:
+ - compatible
+ - reg
+ - mediatek,gce-client-reg
+ - clocks
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/mt8195-clk.h>
+ #include <dt-bindings/gce/mt8195-gce.h>
+
+ display@14002000 {
+ compatible = "mediatek,mt8195-mdp3-fg";
+ reg = <0x14002000 0x1000>;
+ mediatek,gce-client-reg = <&gce1 SUBSYS_1400XXXX 0x2000 0x1000>;
+ clocks = <&vppsys0 CLK_VPP0_MDP_FG>;
+ };
diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-hdr.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-hdr.yaml
new file mode 100644
index 000000000000..fb1bb5a9e57f
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-hdr.yaml
@@ -0,0 +1,60 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/mediatek,mdp3-hdr.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek Media Data Path 3 HDR
+
+maintainers:
+ - Matthias Brugger <matthias.bgg@gmail.com>
+ - Moudy Ho <moudy.ho@mediatek.com>
+
+description:
+ One of Media Data Path 3 (MDP3) components used to perform HDR to SDR
+
+properties:
+ compatible:
+ enum:
+ - mediatek,mt8195-mdp3-hdr
+
+ reg:
+ maxItems: 1
+
+ mediatek,gce-client-reg:
+ description:
+ The register of display function block to be set by gce. There are 4 arguments,
+ such as gce node, subsys id, offset and register size. The subsys id that is
+ mapping to the register of display function blocks is defined in the gce header
+ include/dt-bindings/gce/<chip>-gce.h of each chips.
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ items:
+ items:
+ - description: phandle of GCE
+ - description: GCE subsys id
+ - description: register offset
+ - description: register size
+ maxItems: 1
+
+ clocks:
+ minItems: 1
+
+required:
+ - compatible
+ - reg
+ - mediatek,gce-client-reg
+ - clocks
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/mt8195-clk.h>
+ #include <dt-bindings/gce/mt8195-gce.h>
+
+ display@14004000 {
+ compatible = "mediatek,mt8195-mdp3-hdr";
+ reg = <0x14004000 0x1000>;
+ mediatek,gce-client-reg = <&gce1 SUBSYS_1400XXXX 0x4000 0x1000>;
+ clocks = <&vppsys0 CLK_VPP0_MDP_HDR>;
+ };
diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-pad.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-pad.yaml
new file mode 100644
index 000000000000..13b66c5985fe
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-pad.yaml
@@ -0,0 +1,61 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/mediatek,mdp3-pad.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek Media Data Path 3 PADDING
+
+maintainers:
+ - Matthias Brugger <matthias.bgg@gmail.com>
+ - Moudy Ho <moudy.ho@mediatek.com>
+
+description:
+ One of Media Data Path 3 (MDP3) components used to insert
+ pre-defined color or alpha value to arbitrary side of image.
+
+properties:
+ compatible:
+ enum:
+ - mediatek,mt8195-mdp3-pad
+
+ reg:
+ maxItems: 1
+
+ mediatek,gce-client-reg:
+ description:
+ The register of display function block to be set by gce. There are 4 arguments,
+ such as gce node, subsys id, offset and register size. The subsys id that is
+ mapping to the register of display function blocks is defined in the gce header
+ include/dt-bindings/gce/<chip>-gce.h of each chips.
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ items:
+ items:
+ - description: phandle of GCE
+ - description: GCE subsys id
+ - description: register offset
+ - description: register size
+ maxItems: 1
+
+ clocks:
+ minItems: 1
+
+required:
+ - compatible
+ - reg
+ - mediatek,gce-client-reg
+ - clocks
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/mt8195-clk.h>
+ #include <dt-bindings/gce/mt8195-gce.h>
+
+ display@1400a000 {
+ compatible = "mediatek,mt8195-mdp3-pad";
+ reg = <0x1400a000 0x1000>;
+ mediatek,gce-client-reg = <&gce1 SUBSYS_1400XXXX 0xa000 0x1000>;
+ clocks = <&vppsys0 CLK_VPP0_PADDING>;
+ };
diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
index 0c22571d8c22..17cd5b587e23 100644
--- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
@@ -23,6 +23,7 @@ properties:
enum:
- mediatek,mt8183-mdp3-rdma
- mediatek,mt8195-vdo1-rdma
+ - mediatek,mt8195-mdp3-rdma
reg:
maxItems: 1
@@ -50,17 +51,19 @@ properties:
maxItems: 1
clocks:
- items:
- - description: RDMA clock
- - description: RSZ clock
+ oneOf:
+ - items:
+ - description: RDMA clock
+ - description: SRAM shared component clock
+ - items:
+ - description: RDMA clock
iommus:
maxItems: 1
mboxes:
- items:
- - description: used for 1st data pipe from RDMA
- - description: used for 2nd data pipe from RDMA
+ minItems: 1
+ maxItems: 5
'#dma-cells':
const: 1
@@ -73,7 +76,6 @@ required:
- power-domains
- clocks
- iommus
- - mboxes
- '#dma-cells'
additionalProperties: false
diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-stitch.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-stitch.yaml
new file mode 100644
index 000000000000..45a9d6ac171a
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-stitch.yaml
@@ -0,0 +1,61 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/mediatek,mdp3-stitch.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek Media Data Path 3 STITCH
+
+maintainers:
+ - Matthias Brugger <matthias.bgg@gmail.com>
+ - Moudy Ho <moudy.ho@mediatek.com>
+
+description:
+ One of Media Data Path 3 (MDP3) components used to combine multiple video frame
+ with overlapping fields of view to produce a segmented panorame.
+
+properties:
+ compatible:
+ enum:
+ - mediatek,mt8195-mdp3-stitch
+
+ reg:
+ maxItems: 1
+
+ mediatek,gce-client-reg:
+ description:
+ The register of display function block to be set by gce. There are 4 arguments,
+ such as gce node, subsys id, offset and register size. The subsys id that is
+ mapping to the register of display function blocks is defined in the gce header
+ include/dt-bindings/gce/<chip>-gce.h of each chips.
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ items:
+ items:
+ - description: phandle of GCE
+ - description: GCE subsys id
+ - description: register offset
+ - description: register size
+ maxItems: 1
+
+ clocks:
+ minItems: 1
+
+required:
+ - compatible
+ - reg
+ - mediatek,gce-client-reg
+ - clocks
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/mt8195-clk.h>
+ #include <dt-bindings/gce/mt8195-gce.h>
+
+ display@14003000 {
+ compatible = "mediatek,mt8195-mdp3-stitch";
+ reg = <0x14003000 0x1000>;
+ mediatek,gce-client-reg = <&gce1 SUBSYS_1400XXXX 0x3000 0x1000>;
+ clocks = <&vppsys0 CLK_VPP0_STITCH>;
+ };
diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-tcc.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-tcc.yaml
new file mode 100644
index 000000000000..245e2134c74a
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-tcc.yaml
@@ -0,0 +1,60 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/mediatek,mdp3-tcc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek Media Data Path 3 TCC
+
+maintainers:
+ - Matthias Brugger <matthias.bgg@gmail.com>
+
+description:
+ One of Media Data Path 3 (MDP3) components used to support
+ HDR gamma curve conversion HDR displays.
+
+properties:
+ compatible:
+ enum:
+ - mediatek,mt8195-mdp3-tcc
+
+ reg:
+ maxItems: 1
+
+ mediatek,gce-client-reg:
+ description:
+ The register of display function block to be set by gce. There are 4 arguments,
+ such as gce node, subsys id, offset and register size. The subsys id that is
+ mapping to the register of display function blocks is defined in the gce header
+ include/dt-bindings/gce/<chip>-gce.h of each chips.
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ items:
+ items:
+ - description: phandle of GCE
+ - description: GCE subsys id
+ - description: register offset
+ - description: register size
+ maxItems: 1
+
+ clocks:
+ minItems: 1
+
+required:
+ - compatible
+ - reg
+ - mediatek,gce-client-reg
+ - clocks
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/mt8195-clk.h>
+ #include <dt-bindings/gce/mt8195-gce.h>
+
+ display@1400b000 {
+ compatible = "mediatek,mt8195-mdp3-tcc";
+ reg = <0x1400b000 0x1000>;
+ mediatek,gce-client-reg = <&gce1 SUBSYS_1400XXXX 0xb000 0x1000>;
+ clocks = <&vppsys0 CLK_VPP0_MDP_TCC>;
+ };
diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-tdshp.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-tdshp.yaml
new file mode 100644
index 000000000000..0ac904cbc2c0
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-tdshp.yaml
@@ -0,0 +1,61 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/mediatek,mdp3-tdshp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek Media Data Path 3 TDSHP
+
+maintainers:
+ - Matthias Brugger <matthias.bgg@gmail.com>
+ - Moudy Ho <moudy.ho@mediatek.com>
+
+description:
+ One of Media Data Path 3 (MDP3) components used to improve image
+ sharpness and contrast.
+
+properties:
+ compatible:
+ enum:
+ - mediatek,mt8195-mdp3-tdshp
+
+ reg:
+ maxItems: 1
+
+ mediatek,gce-client-reg:
+ description:
+ The register of display function block to be set by gce. There are 4 arguments,
+ such as gce node, subsys id, offset and register size. The subsys id that is
+ mapping to the register of display function blocks is defined in the gce header
+ include/dt-bindings/gce/<chip>-gce.h of each chips.
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ items:
+ items:
+ - description: phandle of GCE
+ - description: GCE subsys id
+ - description: register offset
+ - description: register size
+ maxItems: 1
+
+ clocks:
+ minItems: 1
+
+required:
+ - compatible
+ - reg
+ - mediatek,gce-client-reg
+ - clocks
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/mt8195-clk.h>
+ #include <dt-bindings/gce/mt8195-gce.h>
+
+ display@14007000 {
+ compatible = "mediatek,mt8195-mdp3-tdshp";
+ reg = <0x14007000 0x1000>;
+ mediatek,gce-client-reg = <&gce1 SUBSYS_1400XXXX 0x7000 0x1000>;
+ clocks = <&vppsys0 CLK_VPP0_MDP_TDSHP>;
+ };
--
2.18.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v5 2/3] dt-binding: mediatek: integrate MDP RDMA to one binding
2023-09-12 7:56 ` [PATCH v5 2/3] dt-binding: mediatek: integrate MDP RDMA to one binding Moudy Ho
@ 2023-09-12 8:16 ` Krzysztof Kozlowski
2023-09-13 3:04 ` Moudy Ho (何宗原)
0 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2023-09-12 8:16 UTC (permalink / raw)
To: Moudy Ho, Chun-Kuang Hu, Philipp Zabel, David Airlie,
Daniel Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Mauro Carvalho Chehab, Matthias Brugger, Hans Verkuil
Cc: AngeloGioacchino Del Regno, dri-devel, linux-mediatek,
devicetree, linux-kernel, linux-media, linux-arm-kernel
On 12/09/2023 09:56, Moudy Ho wrote:
> Due to the same hardware design, MDP RDMA needs to
> be integrated into the same binding.
>
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
This applies to entire patchset. It is not dt-binding, but dt-bindings.
> Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
> ---
> .../display/mediatek/mediatek,mdp-rdma.yaml | 88 -------------------
> .../bindings/media/mediatek,mdp3-rdma.yaml | 5 +-
> 2 files changed, 3 insertions(+), 90 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml
> deleted file mode 100644
> index dd12e2ff685c..000000000000
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml
> +++ /dev/null
> @@ -1,88 +0,0 @@
> -# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> -%YAML 1.2
> ----
> -$id: http://devicetree.org/schemas/display/mediatek/mediatek,mdp-rdma.yaml#
> -$schema: http://devicetree.org/meta-schemas/core.yaml#
> -
> -title: MediaTek MDP RDMA
> -
> -maintainers:
> - - Chun-Kuang Hu <chunkuang.hu@kernel.org>
> - - Philipp Zabel <p.zabel@pengutronix.de>
> -
> -description:
> - The MediaTek MDP RDMA stands for Read Direct Memory Access.
> - It provides real time data to the back-end panel driver, such as DSI,
> - DPI and DP_INTF.
> - It contains one line buffer to store the sufficient pixel data.
> - RDMA device node must be siblings to the central MMSYS_CONFIG node.
> - For a description of the MMSYS_CONFIG binding, see
> - Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml for details.
> -
> -properties:
> - compatible:
> - const: mediatek,mt8195-vdo1-rdma
> -
> - reg:
> - maxItems: 1
> -
> - interrupts:
> - maxItems: 1
> -
> - power-domains:
> - maxItems: 1
> -
> - clocks:
> - items:
> - - description: RDMA Clock
This is different and you did not explain it in commit msg.
Another difference - mboxes. Looks like you did not test your DTS...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v5 3/3] dt-binding: mediatek: add MediaTek mt8195 MDP3 components
2023-09-12 7:56 ` [PATCH v5 3/3] dt-binding: mediatek: add MediaTek mt8195 MDP3 components Moudy Ho
@ 2023-09-12 8:19 ` Krzysztof Kozlowski
2023-09-13 8:39 ` Moudy Ho (何宗原)
0 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2023-09-12 8:19 UTC (permalink / raw)
To: Moudy Ho, Chun-Kuang Hu, Philipp Zabel, David Airlie,
Daniel Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Mauro Carvalho Chehab, Matthias Brugger, Hans Verkuil
Cc: AngeloGioacchino Del Regno, dri-devel, linux-mediatek,
devicetree, linux-kernel, linux-media, linux-arm-kernel
On 12/09/2023 09:56, Moudy Ho wrote:
> Introduce more MDP3 components present in MT8195.
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
>
> Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
> ---
> .../display/mediatek/mediatek,aal.yaml | 2 +-
> .../display/mediatek/mediatek,color.yaml | 2 +-
> .../display/mediatek/mediatek,merge.yaml | 1 +
> .../display/mediatek/mediatek,ovl.yaml | 2 +-
> .../display/mediatek/mediatek,split.yaml | 1 +
> .../bindings/media/mediatek,mdp3-fg.yaml | 61 +++++++++++++++++++
> .../bindings/media/mediatek,mdp3-hdr.yaml | 60 ++++++++++++++++++
> .../bindings/media/mediatek,mdp3-pad.yaml | 61 +++++++++++++++++++
> .../bindings/media/mediatek,mdp3-rdma.yaml | 16 ++---
> .../bindings/media/mediatek,mdp3-stitch.yaml | 61 +++++++++++++++++++
> .../bindings/media/mediatek,mdp3-tcc.yaml | 60 ++++++++++++++++++
> .../bindings/media/mediatek,mdp3-tdshp.yaml | 61 +++++++++++++++++++
> 12 files changed, 378 insertions(+), 10 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-fg.yaml
> create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-hdr.yaml
> create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-pad.yaml
> create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-stitch.yaml
> create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-tcc.yaml
> create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-tdshp.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
> index 7fd42c8fdc32..04b1314d00f2 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
> @@ -24,6 +24,7 @@ properties:
> - enum:
> - mediatek,mt8173-disp-aal
> - mediatek,mt8183-disp-aal
> + - mediatek,mt8195-mdp3-aal
> - items:
> - enum:
> - mediatek,mt2712-disp-aal
> @@ -63,7 +64,6 @@ properties:
> required:
> - compatible
> - reg
> - - interrupts
Why? commit msg tells nothing about it. Why interrupt is not erquired in
mt8173? How dropping such requirement is anyhow related to mt8195?
> - power-domains
> - clocks
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml
> index f21e44092043..8e97b0a6a7b3 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml
> @@ -26,6 +26,7 @@ properties:
> - mediatek,mt2701-disp-color
> - mediatek,mt8167-disp-color
> - mediatek,mt8173-disp-color
> + - mediatek,mt8195-mdp3-color
> - items:
> - enum:
> - mediatek,mt7623-disp-color
> @@ -66,7 +67,6 @@ properties:
> required:
> - compatible
> - reg
> - - interrupts
Why?
> - power-domains
> - clocks
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml
> index eead5cb8636e..401498523404 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml
> @@ -24,6 +24,7 @@ properties:
> - enum:
> - mediatek,mt8173-disp-merge
> - mediatek,mt8195-disp-merge
> + - mediatek,mt8195-mdp3-merge
> - items:
> - const: mediatek,mt6795-disp-merge
> - const: mediatek,mt8173-disp-merge
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> index 3e1069b00b56..10d4d4f64e09 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> @@ -26,6 +26,7 @@ properties:
> - mediatek,mt8173-disp-ovl
> - mediatek,mt8183-disp-ovl
> - mediatek,mt8192-disp-ovl
> + - mediatek,mt8195-mdp3-ovl
> - items:
> - enum:
> - mediatek,mt7623-disp-ovl
> @@ -76,7 +77,6 @@ properties:
> required:
> - compatible
> - reg
> - - interrupts
Why?
> - power-domains
> - clocks
> - iommus
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml
> index a8a5c9608598..a96b271e3240 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml
> @@ -23,6 +23,7 @@ properties:
> oneOf:
> - enum:
> - mediatek,mt8173-disp-split
> + - mediatek,mt8195-mdp3-split
> - items:
> - const: mediatek,mt6795-disp-split
> - const: mediatek,mt8173-disp-split
> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-fg.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-fg.yaml
> new file mode 100644
> index 000000000000..71fd449de8b4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-fg.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/mediatek,mdp3-fg.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek Media Data Path 3 FG
> +
> +maintainers:
> + - Matthias Brugger <matthias.bgg@gmail.com>
> + - Moudy Ho <moudy.ho@mediatek.com>
> +
> +description:
> + One of Media Data Path 3 (MDP3) components used to add film grain
> + according to AV1 spec.
> +
> +properties:
> + compatible:
> + enum:
> + - mediatek,mt8195-mdp3-fg
> +
> + reg:
> + maxItems: 1
> +
> + mediatek,gce-client-reg:
> + description:
> + The register of display function block to be set by gce. There are 4 arguments,
> + such as gce node, subsys id, offset and register size. The subsys id that is
> + mapping to the register of display function blocks is defined in the gce header
> + include/dt-bindings/gce/<chip>-gce.h of each chips.
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + items:
> + items:
> + - description: phandle of GCE
> + - description: GCE subsys id
> + - description: register offset
> + - description: register size
> + maxItems: 1
> +
> + clocks:
> + minItems: 1
This must be maxItems. Use existing code as an example, do not re-invent it.
> +
> +required:
> + - compatible
> + - reg
> + - mediatek,gce-client-reg
> + - clocks
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/mt8195-clk.h>
> + #include <dt-bindings/gce/mt8195-gce.h>
> +
> + display@14002000 {
> + compatible = "mediatek,mt8195-mdp3-fg";
> + reg = <0x14002000 0x1000>;
> + mediatek,gce-client-reg = <&gce1 SUBSYS_1400XXXX 0x2000 0x1000>;
> + clocks = <&vppsys0 CLK_VPP0_MDP_FG>;
> + };
> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-hdr.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-hdr.yaml
> new file mode 100644
> index 000000000000..fb1bb5a9e57f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-hdr.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/mediatek,mdp3-hdr.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek Media Data Path 3 HDR
> +
> +maintainers:
> + - Matthias Brugger <matthias.bgg@gmail.com>
> + - Moudy Ho <moudy.ho@mediatek.com>
> +
> +description:
> + One of Media Data Path 3 (MDP3) components used to perform HDR to SDR
> +
> +properties:
> + compatible:
> + enum:
> + - mediatek,mt8195-mdp3-hdr
> +
> + reg:
> + maxItems: 1
> +
> + mediatek,gce-client-reg:
> + description:
> + The register of display function block to be set by gce. There are 4 arguments,
> + such as gce node, subsys id, offset and register size. The subsys id that is
> + mapping to the register of display function blocks is defined in the gce header
> + include/dt-bindings/gce/<chip>-gce.h of each chips.
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + items:
> + items:
> + - description: phandle of GCE
> + - description: GCE subsys id
> + - description: register offset
> + - description: register size
> + maxItems: 1
> +
> + clocks:
> + minItems: 1
Here as well. Why is this minitems?
> +
> +required:
> + - compatible
> + - reg
> + - mediatek,gce-client-reg
> + - clocks
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/mt8195-clk.h>
> + #include <dt-bindings/gce/mt8195-gce.h>
> +
> + display@14004000 {
> + compatible = "mediatek,mt8195-mdp3-hdr";
> + reg = <0x14004000 0x1000>;
> + mediatek,gce-client-reg = <&gce1 SUBSYS_1400XXXX 0x4000 0x1000>;
> + clocks = <&vppsys0 CLK_VPP0_MDP_HDR>;
> + };
> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-pad.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-pad.yaml
> new file mode 100644
> index 000000000000..13b66c5985fe
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-pad.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/mediatek,mdp3-pad.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek Media Data Path 3 PADDING
> +
> +maintainers:
> + - Matthias Brugger <matthias.bgg@gmail.com>
> + - Moudy Ho <moudy.ho@mediatek.com>
> +
> +description:
> + One of Media Data Path 3 (MDP3) components used to insert
> + pre-defined color or alpha value to arbitrary side of image.
> +
> +properties:
> + compatible:
> + enum:
> + - mediatek,mt8195-mdp3-pad
And you cannot add it to existing padding because?
> +
> + reg:
> + maxItems: 1
> +
> + mediatek,gce-client-reg:
> + description:
> + The register of display function block to be set by gce. There are 4 arguments,
> + such as gce node, subsys id, offset and register size. The subsys id that is
> + mapping to the register of display function blocks is defined in the gce header
> + include/dt-bindings/gce/<chip>-gce.h of each chips.
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + items:
> + items:
> + - description: phandle of GCE
> + - description: GCE subsys id
> + - description: register offset
> + - description: register size
> + maxItems: 1
> +
> + clocks:
> + minItems: 1
Nope
> +
> +required:
> + - compatible
> + - reg
> + - mediatek,gce-client-reg
> + - clocks
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/mt8195-clk.h>
> + #include <dt-bindings/gce/mt8195-gce.h>
> +
> + display@1400a000 {
> + compatible = "mediatek,mt8195-mdp3-pad";
> + reg = <0x1400a000 0x1000>;
> + mediatek,gce-client-reg = <&gce1 SUBSYS_1400XXXX 0xa000 0x1000>;
> + clocks = <&vppsys0 CLK_VPP0_PADDING>;
> + };
> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> index 0c22571d8c22..17cd5b587e23 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> @@ -23,6 +23,7 @@ properties:
> enum:
> - mediatek,mt8183-mdp3-rdma
> - mediatek,mt8195-vdo1-rdma
> + - mediatek,mt8195-mdp3-rdma
m is before v
>
> reg:
> maxItems: 1
> @@ -50,17 +51,19 @@ properties:
> maxItems: 1
>
> clocks:
> - items:
> - - description: RDMA clock
> - - description: RSZ clock
> + oneOf:
> + - items:
> + - description: RDMA clock
> + - description: SRAM shared component clock
> + - items:
> + - description: RDMA clock
Why now mt8183 can have SRAM clock optional? How changing mt8183 is
related to this patch?
I'll finish the review, sorry fix basics here.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v5 2/3] dt-binding: mediatek: integrate MDP RDMA to one binding
2023-09-12 8:16 ` Krzysztof Kozlowski
@ 2023-09-13 3:04 ` Moudy Ho (何宗原)
2023-09-13 6:37 ` Krzysztof Kozlowski
0 siblings, 1 reply; 10+ messages in thread
From: Moudy Ho (何宗原) @ 2023-09-13 3:04 UTC (permalink / raw)
To: robh+dt, chunkuang.hu, mchehab, krzysztof.kozlowski, daniel,
p.zabel, conor+dt, hverkuil-cisco, airlied,
krzysztof.kozlowski+dt, matthias.bgg
Cc: dri-devel, linux-kernel, linux-mediatek, linux-media,
angelogioacchino.delregno, devicetree, linux-arm-kernel
On Tue, 2023-09-12 at 10:16 +0200, Krzysztof Kozlowski wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On 12/09/2023 09:56, Moudy Ho wrote:
> > Due to the same hardware design, MDP RDMA needs to
> > be integrated into the same binding.
> >
>
> Please use subject prefixes matching the subsystem. You can get them
> for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the
> directory
> your patch is touching.
>
> This applies to entire patchset. It is not dt-binding, but dt-
> bindings.
>
> > Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
> > ---
> > .../display/mediatek/mediatek,mdp-rdma.yaml | 88 -------------
> ------
> > .../bindings/media/mediatek,mdp3-rdma.yaml | 5 +-
> > 2 files changed, 3 insertions(+), 90 deletions(-)
> > delete mode 100644
> Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-
> rdma.yaml
> >
> > diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-
> rdma.yaml
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-
> rdma.yaml
> > deleted file mode 100644
> > index dd12e2ff685c..000000000000
> > ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-
> rdma.yaml
> > +++ /dev/null
> > @@ -1,88 +0,0 @@
> > -# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > -%YAML 1.2
> > ----
> > -$id:
> http://devicetree.org/schemas/display/mediatek/mediatek,mdp-rdma.yaml#
> > -$schema: http://devicetree.org/meta-schemas/core.yaml#
> > -
> > -title: MediaTek MDP RDMA
> > -
> > -maintainers:
> > - - Chun-Kuang Hu <chunkuang.hu@kernel.org>
> > - - Philipp Zabel <p.zabel@pengutronix.de>
> > -
> > -description:
> > - The MediaTek MDP RDMA stands for Read Direct Memory Access.
> > - It provides real time data to the back-end panel driver, such as
> DSI,
> > - DPI and DP_INTF.
> > - It contains one line buffer to store the sufficient pixel data.
> > - RDMA device node must be siblings to the central MMSYS_CONFIG
> node.
> > - For a description of the MMSYS_CONFIG binding, see
> >
> - Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
> for details.
> > -
> > -properties:
> > - compatible:
> > - const: mediatek,mt8195-vdo1-rdma
> > -
> > - reg:
> > - maxItems: 1
> > -
> > - interrupts:
> > - maxItems: 1
> > -
> > - power-domains:
> > - maxItems: 1
> > -
> > - clocks:
> > - items:
> > - - description: RDMA Clock
>
> This is different and you did not explain it in commit msg.
>
> Another difference - mboxes. Looks like you did not test your DTS...
>
> Best regards,
> Krzysztof
>
Hi Krzysztof,
Sorry for the inconvenience.
The property you mentioned was removed on [3/3]. This incorrect
configuration went unnoticed because I passed the test with the entire
series.
It will be recified in the next version.
Sincerely,
Moudy
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v5 2/3] dt-binding: mediatek: integrate MDP RDMA to one binding
2023-09-13 3:04 ` Moudy Ho (何宗原)
@ 2023-09-13 6:37 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2023-09-13 6:37 UTC (permalink / raw)
To: Moudy Ho (何宗原),
robh+dt, chunkuang.hu, mchehab, daniel, p.zabel, conor+dt,
hverkuil-cisco, airlied, krzysztof.kozlowski+dt, matthias.bgg
Cc: dri-devel, linux-kernel, linux-mediatek, linux-media,
angelogioacchino.delregno, devicetree, linux-arm-kernel
On 13/09/2023 05:04, Moudy Ho (何宗原) wrote:
> On Tue, 2023-09-12 at 10:16 +0200, Krzysztof Kozlowski wrote:
>>
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>> On 12/09/2023 09:56, Moudy Ho wrote:
>>> Due to the same hardware design, MDP RDMA needs to
>>> be integrated into the same binding.
>>>
>>
>> Please use subject prefixes matching the subsystem. You can get them
>> for
>> example with `git log --oneline -- DIRECTORY_OR_FILE` on the
>> directory
>> your patch is touching.
>>
>> This applies to entire patchset. It is not dt-binding, but dt-
>> bindings.
>>
>>> Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
>>> ---
>>> .../display/mediatek/mediatek,mdp-rdma.yaml | 88 -------------
>> ------
>>> .../bindings/media/mediatek,mdp3-rdma.yaml | 5 +-
>>> 2 files changed, 3 insertions(+), 90 deletions(-)
>>> delete mode 100644
>> Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-
>> rdma.yaml
>>>
>>> diff --git
>> a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-
>> rdma.yaml
>> b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-
>> rdma.yaml
>>> deleted file mode 100644
>>> index dd12e2ff685c..000000000000
>>> ---
>> a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-
>> rdma.yaml
>>> +++ /dev/null
>>> @@ -1,88 +0,0 @@
>>> -# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> -%YAML 1.2
>>> ----
>>> -$id:
>> http://devicetree.org/schemas/display/mediatek/mediatek,mdp-rdma.yaml#
>>> -$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> -
>>> -title: MediaTek MDP RDMA
>>> -
>>> -maintainers:
>>> - - Chun-Kuang Hu <chunkuang.hu@kernel.org>
>>> - - Philipp Zabel <p.zabel@pengutronix.de>
>>> -
>>> -description:
>>> - The MediaTek MDP RDMA stands for Read Direct Memory Access.
>>> - It provides real time data to the back-end panel driver, such as
>> DSI,
>>> - DPI and DP_INTF.
>>> - It contains one line buffer to store the sufficient pixel data.
>>> - RDMA device node must be siblings to the central MMSYS_CONFIG
>> node.
>>> - For a description of the MMSYS_CONFIG binding, see
>>>
>> - Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
>> for details.
>>> -
>>> -properties:
>>> - compatible:
>>> - const: mediatek,mt8195-vdo1-rdma
>>> -
>>> - reg:
>>> - maxItems: 1
>>> -
>>> - interrupts:
>>> - maxItems: 1
>>> -
>>> - power-domains:
>>> - maxItems: 1
>>> -
>>> - clocks:
>>> - items:
>>> - - description: RDMA Clock
>>
>> This is different and you did not explain it in commit msg.
>>
>> Another difference - mboxes. Looks like you did not test your DTS...
>>
>> Best regards,
>> Krzysztof
>>
> Hi Krzysztof,
>
> Sorry for the inconvenience.
> The property you mentioned was removed on [3/3]. This incorrect
> configuration went unnoticed because I passed the test with the entire
> series.
> It will be recified in the next version.
Please describe any differences (lost properties etc) in commit msg with
some explanation.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v5 3/3] dt-binding: mediatek: add MediaTek mt8195 MDP3 components
2023-09-12 8:19 ` Krzysztof Kozlowski
@ 2023-09-13 8:39 ` Moudy Ho (何宗原)
2023-09-13 8:58 ` Krzysztof Kozlowski
0 siblings, 1 reply; 10+ messages in thread
From: Moudy Ho (何宗原) @ 2023-09-13 8:39 UTC (permalink / raw)
To: robh+dt, chunkuang.hu, mchehab, krzysztof.kozlowski, daniel,
p.zabel, conor+dt, hverkuil-cisco, airlied,
krzysztof.kozlowski+dt, matthias.bgg
Cc: dri-devel, linux-kernel, linux-mediatek, linux-media,
angelogioacchino.delregno, devicetree, linux-arm-kernel
Hi Krzysztof,
On Tue, 2023-09-12 at 10:19 +0200, Krzysztof Kozlowski wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On 12/09/2023 09:56, Moudy Ho wrote:
> > Introduce more MDP3 components present in MT8195.
>
> Please use subject prefixes matching the subsystem. You can get them
> for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the
> directory
> your patch is touching.
>
> >
> > Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
> > ---
> > .../display/mediatek/mediatek,aal.yaml | 2 +-
> > .../display/mediatek/mediatek,color.yaml | 2 +-
> > .../display/mediatek/mediatek,merge.yaml | 1 +
> > .../display/mediatek/mediatek,ovl.yaml | 2 +-
> > .../display/mediatek/mediatek,split.yaml | 1 +
> > .../bindings/media/mediatek,mdp3-fg.yaml | 61
> +++++++++++++++++++
> > .../bindings/media/mediatek,mdp3-hdr.yaml | 60
> ++++++++++++++++++
> > .../bindings/media/mediatek,mdp3-pad.yaml | 61
> +++++++++++++++++++
> > .../bindings/media/mediatek,mdp3-rdma.yaml | 16 ++---
> > .../bindings/media/mediatek,mdp3-stitch.yaml | 61
> +++++++++++++++++++
> > .../bindings/media/mediatek,mdp3-tcc.yaml | 60
> ++++++++++++++++++
> > .../bindings/media/mediatek,mdp3-tdshp.yaml | 61
> +++++++++++++++++++
> > 12 files changed, 378 insertions(+), 10 deletions(-)
> > create mode 100644
> Documentation/devicetree/bindings/media/mediatek,mdp3-fg.yaml
> > create mode 100644
> Documentation/devicetree/bindings/media/mediatek,mdp3-hdr.yaml
> > create mode 100644
> Documentation/devicetree/bindings/media/mediatek,mdp3-pad.yaml
> > create mode 100644
> Documentation/devicetree/bindings/media/mediatek,mdp3-stitch.yaml
> > create mode 100644
> Documentation/devicetree/bindings/media/mediatek,mdp3-tcc.yaml
> > create mode 100644
> Documentation/devicetree/bindings/media/mediatek,mdp3-tdshp.yaml
> >
> > diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yam
> l
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yam
> l
> > index 7fd42c8fdc32..04b1314d00f2 100644
> > ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yam
> l
> > +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yam
> l
> > @@ -24,6 +24,7 @@ properties:
> > - enum:
> > - mediatek,mt8173-disp-aal
> > - mediatek,mt8183-disp-aal
> > + - mediatek,mt8195-mdp3-aal
> > - items:
> > - enum:
> > - mediatek,mt2712-disp-aal
> > @@ -63,7 +64,6 @@ properties:
> > required:
> > - compatible
> > - reg
> > - - interrupts
>
> Why? commit msg tells nothing about it. Why interrupt is not erquired
> in
> mt8173? How dropping such requirement is anyhow related to mt8195?
>
>
The signals of the MDP engines are completely controlled by MTK's MUTEX
for starting and stopping frame processing, eliminating the need for
additional interrupts.
Considering the discussion in the previous version, it is advisable to
merge it into the existing display binding files.
Therefore, I tried removing the required conditions to facilitate file
merging.
However, for file integrity purposes, I should revert these changes and
set the corresponding settings in DTS(even if they are not used).
The other YAML files - color, merge and ovl - mentioned below will also
be rectified in the next version.
> > - power-domains
> > - clocks
> >
> > diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,color.y
> aml
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,color.y
> aml
> > index f21e44092043..8e97b0a6a7b3 100644
> > ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,color.y
> aml
> > +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,color.y
> aml
> > @@ -26,6 +26,7 @@ properties:
> > - mediatek,mt2701-disp-color
> > - mediatek,mt8167-disp-color
> > - mediatek,mt8173-disp-color
> > + - mediatek,mt8195-mdp3-color
> > - items:
> > - enum:
> > - mediatek,mt7623-disp-color
> > @@ -66,7 +67,6 @@ properties:
> > required:
> > - compatible
> > - reg
> > - - interrupts
>
> Why?
>
> > - power-domains
> > - clocks
> >
> > diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.y
> aml
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.y
> aml
> > index eead5cb8636e..401498523404 100644
> > ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.y
> aml
> > +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.y
> aml
> > @@ -24,6 +24,7 @@ properties:
> > - enum:
> > - mediatek,mt8173-disp-merge
> > - mediatek,mt8195-disp-merge
> > + - mediatek,mt8195-mdp3-merge
> > - items:
> > - const: mediatek,mt6795-disp-merge
> > - const: mediatek,mt8173-disp-merge
> > diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yam
> l
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yam
> l
> > index 3e1069b00b56..10d4d4f64e09 100644
> > ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yam
> l
> > +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yam
> l
> > @@ -26,6 +26,7 @@ properties:
> > - mediatek,mt8173-disp-ovl
> > - mediatek,mt8183-disp-ovl
> > - mediatek,mt8192-disp-ovl
> > + - mediatek,mt8195-mdp3-ovl
> > - items:
> > - enum:
> > - mediatek,mt7623-disp-ovl
> > @@ -76,7 +77,6 @@ properties:
> > required:
> > - compatible
> > - reg
> > - - interrupts
>
> Why?
>
> > - power-domains
> > - clocks
> > - iommus
> > diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,split.y
> aml
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,split.y
> aml
> > index a8a5c9608598..a96b271e3240 100644
> > ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,split.y
> aml
> > +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,split.y
> aml
> > @@ -23,6 +23,7 @@ properties:
> > oneOf:
> > - enum:
> > - mediatek,mt8173-disp-split
> > + - mediatek,mt8195-mdp3-split
> > - items:
> > - const: mediatek,mt6795-disp-split
> > - const: mediatek,mt8173-disp-split
> > diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
> fg.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
> fg.yaml
> > new file mode 100644
> > index 000000000000..71fd449de8b4
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-fg.yaml
> > @@ -0,0 +1,61 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/mediatek,mdp3-fg.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MediaTek Media Data Path 3 FG
> > +
> > +maintainers:
> > + - Matthias Brugger <matthias.bgg@gmail.com>
> > + - Moudy Ho <moudy.ho@mediatek.com>
> > +
> > +description:
> > + One of Media Data Path 3 (MDP3) components used to add film
> grain
> > + according to AV1 spec.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - mediatek,mt8195-mdp3-fg
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + mediatek,gce-client-reg:
> > + description:
> > + The register of display function block to be set by gce.
> There are 4 arguments,
> > + such as gce node, subsys id, offset and register size. The
> subsys id that is
> > + mapping to the register of display function blocks is
> defined in the gce header
> > + include/dt-bindings/gce/<chip>-gce.h of each chips.
> > + $ref: /schemas/types.yaml#/definitions/phandle-array
> > + items:
> > + items:
> > + - description: phandle of GCE
> > + - description: GCE subsys id
> > + - description: register offset
> > + - description: register size
> > + maxItems: 1
> > +
> > + clocks:
> > + minItems: 1
>
> This must be maxItems. Use existing code as an example, do not re-
> invent it.
>
Thanks for the advice, it will be fixed in the next version.
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - mediatek,gce-client-reg
> > + - clocks
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/clock/mt8195-clk.h>
> > + #include <dt-bindings/gce/mt8195-gce.h>
> > +
> > + display@14002000 {
> > + compatible = "mediatek,mt8195-mdp3-fg";
> > + reg = <0x14002000 0x1000>;
> > + mediatek,gce-client-reg = <&gce1 SUBSYS_1400XXXX 0x2000
> 0x1000>;
> > + clocks = <&vppsys0 CLK_VPP0_MDP_FG>;
> > + };
> > diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
> hdr.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
> hdr.yaml
> > new file mode 100644
> > index 000000000000..fb1bb5a9e57f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-
> hdr.yaml
> > @@ -0,0 +1,60 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/mediatek,mdp3-hdr.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MediaTek Media Data Path 3 HDR
> > +
> > +maintainers:
> > + - Matthias Brugger <matthias.bgg@gmail.com>
> > + - Moudy Ho <moudy.ho@mediatek.com>
> > +
> > +description:
> > + One of Media Data Path 3 (MDP3) components used to perform HDR
> to SDR
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - mediatek,mt8195-mdp3-hdr
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + mediatek,gce-client-reg:
> > + description:
> > + The register of display function block to be set by gce.
> There are 4 arguments,
> > + such as gce node, subsys id, offset and register size. The
> subsys id that is
> > + mapping to the register of display function blocks is
> defined in the gce header
> > + include/dt-bindings/gce/<chip>-gce.h of each chips.
> > + $ref: /schemas/types.yaml#/definitions/phandle-array
> > + items:
> > + items:
> > + - description: phandle of GCE
> > + - description: GCE subsys id
> > + - description: register offset
> > + - description: register size
> > + maxItems: 1
> > +
> > + clocks:
> > + minItems: 1
>
> Here as well. Why is this minitems?
>
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - mediatek,gce-client-reg
> > + - clocks
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/clock/mt8195-clk.h>
> > + #include <dt-bindings/gce/mt8195-gce.h>
> > +
> > + display@14004000 {
> > + compatible = "mediatek,mt8195-mdp3-hdr";
> > + reg = <0x14004000 0x1000>;
> > + mediatek,gce-client-reg = <&gce1 SUBSYS_1400XXXX 0x4000
> 0x1000>;
> > + clocks = <&vppsys0 CLK_VPP0_MDP_HDR>;
> > + };
> > diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
> pad.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
> pad.yaml
> > new file mode 100644
> > index 000000000000..13b66c5985fe
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-
> pad.yaml
> > @@ -0,0 +1,61 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/mediatek,mdp3-pad.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MediaTek Media Data Path 3 PADDING
> > +
> > +maintainers:
> > + - Matthias Brugger <matthias.bgg@gmail.com>
> > + - Moudy Ho <moudy.ho@mediatek.com>
> > +
> > +description:
> > + One of Media Data Path 3 (MDP3) components used to insert
> > + pre-defined color or alpha value to arbitrary side of image.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - mediatek,mt8195-mdp3-pad
>
> And you cannot add it to existing padding because?
>
Apologies for the oversight. I will integrate padding into the same
files, and include a link to the series below:
Message ID =
20230911074233.31556-5-shawn.sung@mediatek.com
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + mediatek,gce-client-reg:
> > + description:
> > + The register of display function block to be set by gce.
> There are 4 arguments,
> > + such as gce node, subsys id, offset and register size. The
> subsys id that is
> > + mapping to the register of display function blocks is
> defined in the gce header
> > + include/dt-bindings/gce/<chip>-gce.h of each chips.
> > + $ref: /schemas/types.yaml#/definitions/phandle-array
> > + items:
> > + items:
> > + - description: phandle of GCE
> > + - description: GCE subsys id
> > + - description: register offset
> > + - description: register size
> > + maxItems: 1
> > +
> > + clocks:
> > + minItems: 1
>
> Nope
>
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - mediatek,gce-client-reg
> > + - clocks
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/clock/mt8195-clk.h>
> > + #include <dt-bindings/gce/mt8195-gce.h>
> > +
> > + display@1400a000 {
> > + compatible = "mediatek,mt8195-mdp3-pad";
> > + reg = <0x1400a000 0x1000>;
> > + mediatek,gce-client-reg = <&gce1 SUBSYS_1400XXXX 0xa000
> 0x1000>;
> > + clocks = <&vppsys0 CLK_VPP0_PADDING>;
> > + };
> > diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
> rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
> rdma.yaml
> > index 0c22571d8c22..17cd5b587e23 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-
> rdma.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-
> rdma.yaml
> > @@ -23,6 +23,7 @@ properties:
> > enum:
> > - mediatek,mt8183-mdp3-rdma
> > - mediatek,mt8195-vdo1-rdma
> > + - mediatek,mt8195-mdp3-rdma
>
> m is before v
>
Thanks for pointing that out. It will be addressed and fixed.
> >
> > reg:
> > maxItems: 1
> > @@ -50,17 +51,19 @@ properties:
> > maxItems: 1
> >
> > clocks:
> > - items:
> > - - description: RDMA clock
> > - - description: RSZ clock
> > + oneOf:
> > + - items:
> > + - description: RDMA clock
> > + - description: SRAM shared component clock
> > + - items:
> > + - description: RDMA clock
>
> Why now mt8183 can have SRAM clock optional? How changing mt8183 is
> related to this patch?
>
> I'll finish the review, sorry fix basics here.
>
> Best regards,
> Krzysztof
>
The RDMA of only the 8183 needed to share SRMA with other component due
to the old desgin.
I attempted to describe both the situation of the 8183 and new designs
like the 8195, but it appears that this writing style may lead to
misunderstandings.
I am unsure if there are any ways to enhance it.
Sincerely,
Moudy
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v5 3/3] dt-binding: mediatek: add MediaTek mt8195 MDP3 components
2023-09-13 8:39 ` Moudy Ho (何宗原)
@ 2023-09-13 8:58 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2023-09-13 8:58 UTC (permalink / raw)
To: Moudy Ho (何宗原),
robh+dt, chunkuang.hu, mchehab, daniel, p.zabel, conor+dt,
hverkuil-cisco, airlied, krzysztof.kozlowski+dt, matthias.bgg
Cc: dri-devel, linux-kernel, linux-mediatek, linux-media,
angelogioacchino.delregno, devicetree, linux-arm-kernel
On 13/09/2023 10:39, Moudy Ho (何宗原) wrote:
>>> @@ -63,7 +64,6 @@ properties:
>>> required:
>>> - compatible
>>> - reg
>>> - - interrupts
>>
>> Why? commit msg tells nothing about it. Why interrupt is not erquired
>> in
>> mt8173? How dropping such requirement is anyhow related to mt8195?
>>
>>
> The signals of the MDP engines are completely controlled by MTK's MUTEX
> for starting and stopping frame processing, eliminating the need for
> additional interrupts.
Then it does not look like related to this patch at all.
...
>>>
>>> reg:
>>> maxItems: 1
>>> @@ -50,17 +51,19 @@ properties:
>>> maxItems: 1
>>>
>>> clocks:
>>> - items:
>>> - - description: RDMA clock
>>> - - description: RSZ clock
>>> + oneOf:
>>> + - items:
>>> + - description: RDMA clock
>>> + - description: SRAM shared component clock
>>> + - items:
>>> + - description: RDMA clock
>>
>> Why now mt8183 can have SRAM clock optional? How changing mt8183 is
>> related to this patch?
>>
>> I'll finish the review, sorry fix basics here.
>>
>> Best regards,
>> Krzysztof
>>
> The RDMA of only the 8183 needed to share SRMA with other component due
> to the old desgin.
> I attempted to describe both the situation of the 8183 and new designs
> like the 8195, but it appears that this writing style may lead to
> misunderstandings.
> I am unsure if there are any ways to enhance it.
Just like many other bindings, just look at Qualcomm, use allOf to
restrict entries per variants.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-09-13 8:58 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-12 7:56 [PATCH v5 0/3] introduce more MDP3 components in mt8195 Moudy Ho
2023-09-12 7:56 ` [PATCH v5 1/3] dt-binding: mediatek: correct MDP3 node with generic names Moudy Ho
2023-09-12 7:56 ` [PATCH v5 2/3] dt-binding: mediatek: integrate MDP RDMA to one binding Moudy Ho
2023-09-12 8:16 ` Krzysztof Kozlowski
2023-09-13 3:04 ` Moudy Ho (何宗原)
2023-09-13 6:37 ` Krzysztof Kozlowski
2023-09-12 7:56 ` [PATCH v5 3/3] dt-binding: mediatek: add MediaTek mt8195 MDP3 components Moudy Ho
2023-09-12 8:19 ` Krzysztof Kozlowski
2023-09-13 8:39 ` Moudy Ho (何宗原)
2023-09-13 8:58 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).