* [PATCH -next] media: i2c: No need to set device_driver owner
@ 2023-07-18 1:01 Yang Li
2023-07-18 7:06 ` Tomi Valkeinen
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2023-07-18 1:01 UTC (permalink / raw)
To: tomi.valkeinen; +Cc: mchehab, linux-media, linux-kernel, Yang Li, Abaci Robot
Remove .owner field if calls are used which set it automatically.
to silence the warning:
./drivers/media/i2c/ds90ub953.c:1390:3-8: No need to set .owner here. The core will do it.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5902
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/media/i2c/ds90ub953.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c
index 1e3827a60029..ce1c6f8b656e 100644
--- a/drivers/media/i2c/ds90ub953.c
+++ b/drivers/media/i2c/ds90ub953.c
@@ -1387,7 +1387,6 @@ static struct i2c_driver ds90ub953_driver = {
.id_table = ub953_id,
.driver = {
.name = "ds90ub953",
- .owner = THIS_MODULE,
.of_match_table = ub953_dt_ids,
},
};
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] media: i2c: No need to set device_driver owner
2023-07-18 1:01 [PATCH -next] media: i2c: No need to set device_driver owner Yang Li
@ 2023-07-18 7:06 ` Tomi Valkeinen
0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2023-07-18 7:06 UTC (permalink / raw)
To: Yang Li; +Cc: mchehab, linux-media, linux-kernel, Abaci Robot
On 18/07/2023 04:01, Yang Li wrote:
> Remove .owner field if calls are used which set it automatically.
>
> to silence the warning:
> ./drivers/media/i2c/ds90ub953.c:1390:3-8: No need to set .owner here. The core will do it.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5902
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/media/i2c/ds90ub953.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c
> index 1e3827a60029..ce1c6f8b656e 100644
> --- a/drivers/media/i2c/ds90ub953.c
> +++ b/drivers/media/i2c/ds90ub953.c
> @@ -1387,7 +1387,6 @@ static struct i2c_driver ds90ub953_driver = {
> .id_table = ub953_id,
> .driver = {
> .name = "ds90ub953",
> - .owner = THIS_MODULE,
> .of_match_table = ub953_dt_ids,
> },
> };
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Tomi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-18 7:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-18 1:01 [PATCH -next] media: i2c: No need to set device_driver owner Yang Li
2023-07-18 7:06 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).