Re: [PATCHv2 00/19] saa7146: convert to vb2

[Hans Verkuil <hverkuil-cisco@xs4all.nl>]

On 23/03/2023 18:23, Hans Verkuil wrote:
> On 23/03/2023 16:53, Hans Verkuil wrote:
>> This series converts the saa7146 driver to vb2.
>>
>> Tested with my mxb board, Hexium Orion and Gemini boards and av7110 boards
>> (DVB-C and DVB-T).
>>
>> I don't have a av7110 card with analog video capture, so that remains
>> untested.
>>
>> Note that the first patch fixes a regression that the removal of overlay
>> support introduced.
>>
>> Regards,
>>
>> 	Hans
> 
> Just ignore this series, something is still wrong.

No, it's fine after all.

I noticed that the Hexium Gemini card swaps the U and V components, but I discovered
that it was like that for a long time, even in kernel 5.10.

I can make it work by changing a h_offset value, but I will have to do a bit more
testing later.

It's independent of this work, so I leave this series as-is.

Regards,

	Hans

> 
> Regards,
> 
> 	Hans
> 
>>
>> Hans Verkuil (19):
>>   media: common: saa7146: disable clipping
>>   common/saa7146: fix VFL direction for vbi output
>>   media: pci: saa7146: hexium_orion: initialize input 0
>>   media: saa7146: drop 'dev' and 'resources' from struct saa7146_fh
>>   media: common: saa7146: drop 'fmt' from struct saa7146_buf
>>   media: common: saa7146: replace BUG_ON by WARN_ON
>>   staging: media: av7110: replace BUG_ON by WARN_ON
>>   media: common: saa7146: fix broken V4L2_PIX_FMT_YUV422P support
>>   media: common: saa7146: use for_each_sg_dma_page
>>   media: saa7146: convert to vb2
>>   media: common: saa7146: fix compliance problems with field handling
>>   media: common: saa7146: check minimum video format size
>>   media: common: saa7146: fall back to V4L2_PIX_FMT_BGR24
>>   media: common: saa7146: allow S_STD(G_STD)
>>   media: mxb: update the tvnorms when changing input
>>   media: common: saa7146: add support for missing
>>     .vidioc_try_fmt_vbi_cap
>>   media: mxb: allow tuner/input/audio ioctls for vbi
>>   media: pci: saa7146: advertise only those TV standard that are
>>     supported
>>   staging: media: av7110: fix VBI output support
>>
>>  drivers/media/common/saa7146/Kconfig         |   2 +-
>>  drivers/media/common/saa7146/saa7146_core.c  |  40 +-
>>  drivers/media/common/saa7146/saa7146_fops.c  | 349 +++-------
>>  drivers/media/common/saa7146/saa7146_hlp.c   |  61 +-
>>  drivers/media/common/saa7146/saa7146_vbi.c   | 287 ++++-----
>>  drivers/media/common/saa7146/saa7146_video.c | 642 ++++++-------------
>>  drivers/media/pci/saa7146/hexium_gemini.c    |  23 +-
>>  drivers/media/pci/saa7146/hexium_orion.c     |  24 +-
>>  drivers/media/pci/saa7146/mxb.c              |  53 +-
>>  drivers/media/pci/ttpci/budget-av.c          |   4 +-
>>  drivers/staging/media/av7110/av7110.c        |   6 +-
>>  drivers/staging/media/av7110/av7110_hw.c     |   3 +-
>>  drivers/staging/media/av7110/av7110_v4l.c    | 116 ++--
>>  include/media/drv-intf/saa7146_vv.h          |  44 +-
>>  14 files changed, 598 insertions(+), 1056 deletions(-)
>>
>