* [PATCH V2] media: imx: imx8mq-mipi_csi2: Remove unneeded code
@ 2022-01-28 17:07 Muhammad Usama Anjum
2022-01-29 18:54 ` Fabio Estevam
2022-02-18 11:08 ` Muhammad Usama Anjum
0 siblings, 2 replies; 4+ messages in thread
From: Muhammad Usama Anjum @ 2022-01-28 17:07 UTC (permalink / raw)
To: Steve Longerbeam, Philipp Zabel, Mauro Carvalho Chehab,
Greg Kroah-Hartman, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
open list:MEDIA DRIVERS FOR FREESCALE IMX,
open list:STAGING SUBSYSTEM,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list, mkl
Cc: Muhammad Usama Anjum, kernel, kernel-janitors
ret is constant in imx8mq_mipi_csi_pm_suspend(). This function cannot
return error. Remove the return variable. Simplify other functions which
are using this function.
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
Changes in V2:
Removed fixes tag
---
drivers/staging/media/imx/imx8mq-mipi-csi2.c | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/media/imx/imx8mq-mipi-csi2.c b/drivers/staging/media/imx/imx8mq-mipi-csi2.c
index 3b9fa75efac6b..c992b845e63d1 100644
--- a/drivers/staging/media/imx/imx8mq-mipi-csi2.c
+++ b/drivers/staging/media/imx/imx8mq-mipi-csi2.c
@@ -693,11 +693,10 @@ static int imx8mq_mipi_csi_async_register(struct csi_state *state)
* Suspend/resume
*/
-static int imx8mq_mipi_csi_pm_suspend(struct device *dev)
+static void imx8mq_mipi_csi_pm_suspend(struct device *dev)
{
struct v4l2_subdev *sd = dev_get_drvdata(dev);
struct csi_state *state = mipi_sd_to_csi2_state(sd);
- int ret = 0;
mutex_lock(&state->lock);
@@ -708,8 +707,6 @@ static int imx8mq_mipi_csi_pm_suspend(struct device *dev)
}
mutex_unlock(&state->lock);
-
- return ret ? -EAGAIN : 0;
}
static int imx8mq_mipi_csi_pm_resume(struct device *dev)
@@ -742,15 +739,12 @@ static int __maybe_unused imx8mq_mipi_csi_suspend(struct device *dev)
{
struct v4l2_subdev *sd = dev_get_drvdata(dev);
struct csi_state *state = mipi_sd_to_csi2_state(sd);
- int ret;
- ret = imx8mq_mipi_csi_pm_suspend(dev);
- if (ret)
- return ret;
+ imx8mq_mipi_csi_pm_suspend(dev);
state->state |= ST_SUSPENDED;
- return ret;
+ return 0;
}
static int __maybe_unused imx8mq_mipi_csi_resume(struct device *dev)
@@ -770,9 +764,7 @@ static int __maybe_unused imx8mq_mipi_csi_runtime_suspend(struct device *dev)
struct csi_state *state = mipi_sd_to_csi2_state(sd);
int ret;
- ret = imx8mq_mipi_csi_pm_suspend(dev);
- if (ret)
- return ret;
+ imx8mq_mipi_csi_pm_suspend(dev);
ret = icc_set_bw(state->icc_path, 0, 0);
if (ret)
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH V2] media: imx: imx8mq-mipi_csi2: Remove unneeded code
2022-01-28 17:07 [PATCH V2] media: imx: imx8mq-mipi_csi2: Remove unneeded code Muhammad Usama Anjum
@ 2022-01-29 18:54 ` Fabio Estevam
2022-02-18 11:08 ` Muhammad Usama Anjum
1 sibling, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2022-01-29 18:54 UTC (permalink / raw)
To: Muhammad Usama Anjum
Cc: Steve Longerbeam, Philipp Zabel, Mauro Carvalho Chehab,
Greg Kroah-Hartman, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, NXP Linux Team,
open list:MEDIA DRIVERS FOR FREESCALE IMX,
open list:STAGING SUBSYSTEM,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list, Marc Kleine-Budde, kernel, kernel-janitors
On Fri, Jan 28, 2022 at 2:07 PM Muhammad Usama Anjum
<usama.anjum@collabora.com> wrote:
>
> ret is constant in imx8mq_mipi_csi_pm_suspend(). This function cannot
> return error. Remove the return variable. Simplify other functions which
> are using this function.
>
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> Changes in V2:
> Removed fixes tag
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V2] media: imx: imx8mq-mipi_csi2: Remove unneeded code
2022-01-28 17:07 [PATCH V2] media: imx: imx8mq-mipi_csi2: Remove unneeded code Muhammad Usama Anjum
2022-01-29 18:54 ` Fabio Estevam
@ 2022-02-18 11:08 ` Muhammad Usama Anjum
2022-02-25 17:41 ` Muhammad Usama Anjum
1 sibling, 1 reply; 4+ messages in thread
From: Muhammad Usama Anjum @ 2022-02-18 11:08 UTC (permalink / raw)
To: Steve Longerbeam, Philipp Zabel, Mauro Carvalho Chehab,
Greg Kroah-Hartman, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
open list:MEDIA DRIVERS FOR FREESCALE IMX,
open list:STAGING SUBSYSTEM,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list, mkl
Cc: usama.anjum, kernel, kernel-janitors
Reminder.
On 1/28/22 10:07 PM, Muhammad Usama Anjum wrote:
> ret is constant in imx8mq_mipi_csi_pm_suspend(). This function cannot
> return error. Remove the return variable. Simplify other functions which
> are using this function.
>
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> Changes in V2:
> Removed fixes tag
> ---
> drivers/staging/media/imx/imx8mq-mipi-csi2.c | 16 ++++------------
> 1 file changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx8mq-mipi-csi2.c b/drivers/staging/media/imx/imx8mq-mipi-csi2.c
> index 3b9fa75efac6b..c992b845e63d1 100644
> --- a/drivers/staging/media/imx/imx8mq-mipi-csi2.c
> +++ b/drivers/staging/media/imx/imx8mq-mipi-csi2.c
> @@ -693,11 +693,10 @@ static int imx8mq_mipi_csi_async_register(struct csi_state *state)
> * Suspend/resume
> */
>
> -static int imx8mq_mipi_csi_pm_suspend(struct device *dev)
> +static void imx8mq_mipi_csi_pm_suspend(struct device *dev)
> {
> struct v4l2_subdev *sd = dev_get_drvdata(dev);
> struct csi_state *state = mipi_sd_to_csi2_state(sd);
> - int ret = 0;
>
> mutex_lock(&state->lock);
>
> @@ -708,8 +707,6 @@ static int imx8mq_mipi_csi_pm_suspend(struct device *dev)
> }
>
> mutex_unlock(&state->lock);
> -
> - return ret ? -EAGAIN : 0;
> }
>
> static int imx8mq_mipi_csi_pm_resume(struct device *dev)
> @@ -742,15 +739,12 @@ static int __maybe_unused imx8mq_mipi_csi_suspend(struct device *dev)
> {
> struct v4l2_subdev *sd = dev_get_drvdata(dev);
> struct csi_state *state = mipi_sd_to_csi2_state(sd);
> - int ret;
>
> - ret = imx8mq_mipi_csi_pm_suspend(dev);
> - if (ret)
> - return ret;
> + imx8mq_mipi_csi_pm_suspend(dev);
>
> state->state |= ST_SUSPENDED;
>
> - return ret;
> + return 0;
> }
>
> static int __maybe_unused imx8mq_mipi_csi_resume(struct device *dev)
> @@ -770,9 +764,7 @@ static int __maybe_unused imx8mq_mipi_csi_runtime_suspend(struct device *dev)
> struct csi_state *state = mipi_sd_to_csi2_state(sd);
> int ret;
>
> - ret = imx8mq_mipi_csi_pm_suspend(dev);
> - if (ret)
> - return ret;
> + imx8mq_mipi_csi_pm_suspend(dev);
>
> ret = icc_set_bw(state->icc_path, 0, 0);
> if (ret)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH V2] media: imx: imx8mq-mipi_csi2: Remove unneeded code
2022-02-18 11:08 ` Muhammad Usama Anjum
@ 2022-02-25 17:41 ` Muhammad Usama Anjum
0 siblings, 0 replies; 4+ messages in thread
From: Muhammad Usama Anjum @ 2022-02-25 17:41 UTC (permalink / raw)
To: Steve Longerbeam, Philipp Zabel, Mauro Carvalho Chehab,
Greg Kroah-Hartman, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
open list:MEDIA DRIVERS FOR FREESCALE IMX,
open list:STAGING SUBSYSTEM,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list, mkl, Hans Verkuil
Cc: usama.anjum, kernel, kernel-janitors
From:
https://patchwork.linuxtv.org/project/linux-media/patch/20220128170722.1624767-1-usama.anjum@collabora.com/
State Under Review
Delegated to: Hans Verkuil
On 2/18/22 4:08 PM, Muhammad Usama Anjum wrote:
> Reminder.
>
> On 1/28/22 10:07 PM, Muhammad Usama Anjum wrote:
>> ret is constant in imx8mq_mipi_csi_pm_suspend(). This function cannot
>> return error. Remove the return variable. Simplify other functions which
>> are using this function.
>>
>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>> ---
>> Changes in V2:
>> Removed fixes tag
>> ---
>> drivers/staging/media/imx/imx8mq-mipi-csi2.c | 16 ++++------------
>> 1 file changed, 4 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/staging/media/imx/imx8mq-mipi-csi2.c b/drivers/staging/media/imx/imx8mq-mipi-csi2.c
>> index 3b9fa75efac6b..c992b845e63d1 100644
>> --- a/drivers/staging/media/imx/imx8mq-mipi-csi2.c
>> +++ b/drivers/staging/media/imx/imx8mq-mipi-csi2.c
>> @@ -693,11 +693,10 @@ static int imx8mq_mipi_csi_async_register(struct csi_state *state)
>> * Suspend/resume
>> */
>>
>> -static int imx8mq_mipi_csi_pm_suspend(struct device *dev)
>> +static void imx8mq_mipi_csi_pm_suspend(struct device *dev)
>> {
>> struct v4l2_subdev *sd = dev_get_drvdata(dev);
>> struct csi_state *state = mipi_sd_to_csi2_state(sd);
>> - int ret = 0;
>>
>> mutex_lock(&state->lock);
>>
>> @@ -708,8 +707,6 @@ static int imx8mq_mipi_csi_pm_suspend(struct device *dev)
>> }
>>
>> mutex_unlock(&state->lock);
>> -
>> - return ret ? -EAGAIN : 0;
>> }
>>
>> static int imx8mq_mipi_csi_pm_resume(struct device *dev)
>> @@ -742,15 +739,12 @@ static int __maybe_unused imx8mq_mipi_csi_suspend(struct device *dev)
>> {
>> struct v4l2_subdev *sd = dev_get_drvdata(dev);
>> struct csi_state *state = mipi_sd_to_csi2_state(sd);
>> - int ret;
>>
>> - ret = imx8mq_mipi_csi_pm_suspend(dev);
>> - if (ret)
>> - return ret;
>> + imx8mq_mipi_csi_pm_suspend(dev);
>>
>> state->state |= ST_SUSPENDED;
>>
>> - return ret;
>> + return 0;
>> }
>>
>> static int __maybe_unused imx8mq_mipi_csi_resume(struct device *dev)
>> @@ -770,9 +764,7 @@ static int __maybe_unused imx8mq_mipi_csi_runtime_suspend(struct device *dev)
>> struct csi_state *state = mipi_sd_to_csi2_state(sd);
>> int ret;
>>
>> - ret = imx8mq_mipi_csi_pm_suspend(dev);
>> - if (ret)
>> - return ret;
>> + imx8mq_mipi_csi_pm_suspend(dev);
>>
>> ret = icc_set_bw(state->icc_path, 0, 0);
>> if (ret)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-25 17:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-28 17:07 [PATCH V2] media: imx: imx8mq-mipi_csi2: Remove unneeded code Muhammad Usama Anjum
2022-01-29 18:54 ` Fabio Estevam
2022-02-18 11:08 ` Muhammad Usama Anjum
2022-02-25 17:41 ` Muhammad Usama Anjum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).