From: Jan Kotas <jank@cadence.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Jan Kotas <jank@cadence.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-media <linux-media@vger.kernel.org>,
linux-devicetree <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] media: Add support for Cadence CSI2TX 2.1
Date: Mon, 22 Jul 2019 07:07:33 +0000 [thread overview]
Message-ID: <AF5297BE-EE52-4652-8DE6-6A3F4E855480@global.cadence.com> (raw)
In-Reply-To: <20190720082559.pk3odkf5hztgvpif@flea>
> On 20 Jul 2019, at 10:25, Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> Hi,
>
> On Thu, Jul 18, 2019 at 12:15:09PM +0100, Jan Kotas wrote:
>> /* Put our lanes (clock and data) out of reset */
>> reg = CSI2TX_DPHY_CFG_CLK_RESET | CSI2TX_DPHY_CFG_MODE_LPDT;
>> for (i = 0; i < csi2tx->num_lanes; i++)
>> - reg |= CSI2TX_DPHY_CFG_LANE_RESET(csi2tx->lanes[i]);
>> + reg |= CSI2TX_DPHY_CFG_LANE_RESET(csi2tx->lanes[i] - 1);
>
> This looks like a separate change?
>
>> writel(reg, csi2tx->base + CSI2TX_DPHY_CFG_REG);
>>
>> - udelay(10);
>> + csi2tx_dphy_init_finish(csi2tx, reg);
>> +}
>>
>> - /* Enable our (clock and data) lanes */
>> - reg |= CSI2TX_DPHY_CFG_CLK_ENABLE;
>> - for (i = 0; i < csi2tx->num_lanes; i++)
>> - reg |= CSI2TX_DPHY_CFG_LANE_ENABLE(csi2tx->lanes[i]);
>
> And you have a similar change here that should be in a separate patch,
> with a proper explanation.
>
> Otherwise, the rest looks good.
OK, I’ll create a separate patch with this modification.
Jan
> Maxime
>
> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
prev parent reply other threads:[~2019-07-22 7:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 11:15 [PATCH 0/3] media: Add support for Cadence CSI2TX version 2.1 Jan Kotas
2019-07-18 11:15 ` [PATCH 1/3] media: dt-bindings: Update bindings " Jan Kotas
2019-07-20 8:26 ` Maxime Ripard
2019-07-18 11:15 ` [PATCH 2/3] media: Add lane checks for Cadence CSI2TX Jan Kotas
2019-07-18 11:52 ` Marc Gonzalez
2019-07-18 12:07 ` Jan Kotas
2019-07-20 8:26 ` Maxime Ripard
2019-07-18 11:15 ` [PATCH 3/3] media: Add support for Cadence CSI2TX 2.1 Jan Kotas
2019-07-20 8:25 ` Maxime Ripard
2019-07-22 7:07 ` Jan Kotas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AF5297BE-EE52-4652-8DE6-6A3F4E855480@global.cadence.com \
--to=jank@cadence.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).