linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] STV22 Dual USB DVB-T Tuner HDTV linux kernel support
@ 2011-06-23 15:39 Emilio David Diaus López
  2011-06-23 21:37 ` Fwd: " David
  0 siblings, 1 reply; 5+ messages in thread
From: Emilio David Diaus López @ 2011-06-23 15:39 UTC (permalink / raw)
  To: Antti Palosaari; +Cc: linux-media

Hello:

I expect the patches finally are ok.

This patches add

Signed-off-by: Emilio David Diaus Lopez <reality_es@yahoo.es>
-----------------------------------------

-- ./drivers/media/dvb/dvb-usb/af9015.c.orig	2011-06-21 12:39:44.000000000 +0200
+++ ./drivers/media/dvb/dvb-usb/af9015.c	2011-06-22 12:05:28.000000000 +0200
@@ -749,6 +749,8 @@ static const struct af9015_rc_setup af90
 		RC_MAP_AZUREWAVE_AD_TU700 },
 	{ (USB_VID_MSI_2 << 16) + USB_PID_MSI_DIGI_VOX_MINI_III,
 		RC_MAP_MSI_DIGIVOX_III },
+	{ (USB_VID_KWORLD_2 << 16) + USB_PID_SVEON_STV22,
+		RC_MAP_MSI_DIGIVOX_III },
 	{ (USB_VID_LEADTEK << 16) + USB_PID_WINFAST_DTV_DONGLE_GOLD,
 		RC_MAP_LEADTEK_Y04G0051 },
 	{ (USB_VID_AVERMEDIA << 16) + USB_PID_AVERMEDIA_VOLAR_X,
@@ -1309,6 +1311,7 @@ static struct usb_device_id af9015_usb_t
 		USB_PID_TERRATEC_CINERGY_T_STICK_DUAL_RC)},
 /* 35 */{USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A850T)},
 	{USB_DEVICE(USB_VID_GTEK,      USB_PID_TINYTWIN_3)},
+	{USB_DEVICE(USB_VID_KWORLD_2,  USB_PID_SVEON_STV22)},
 	{0},
 };
 MODULE_DEVICE_TABLE(usb, af9015_usb_table);
@@ -1649,6 +1652,11 @@ static struct dvb_usb_device_properties
 				.warm_ids = {NULL},
 			},
 			{
+				.name = "Sveon STV22 Dual USB DVB-T Tuner HDTV ",
+				.cold_ids = {&af9015_usb_table[37], NULL},
+				.warm_ids = {NULL},
+			},
+			{
 				.name = "Leadtek WinFast DTV2000DS",
 				.cold_ids = {&af9015_usb_table[29], NULL},
 				.warm_ids = {NULL},

------------------------------
--- ./drivers/media/dvb/dvb-usb/dvb-usb-ids.h.orig	2011-06-21
12:39:45.000000000 +0200
+++ ./drivers/media/dvb/dvb-usb/dvb-usb-ids.h	2011-06-18
11:48:22.000000000 +0200
@@ -128,6 +128,7 @@
 #define USB_PID_INTEL_CE9500				0x9500
 #define USB_PID_KWORLD_399U				0xe399
 #define USB_PID_KWORLD_399U_2				0xe400
+#define USB_PID_SVEON_STV22				0xe401
 #define USB_PID_KWORLD_395U				0xe396
 #define USB_PID_KWORLD_395U_2				0xe39b
 #define USB_PID_KWORLD_395U_3				0xe395
------------------------
1.1
-----------------------
Thanks for your time

goodbye
Emilio David Diaus López

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Fwd: [PATCH] STV22 Dual USB DVB-T Tuner HDTV linux kernel support
  2011-06-23 15:39 [PATCH] STV22 Dual USB DVB-T Tuner HDTV linux kernel support Emilio David Diaus López
@ 2011-06-23 21:37 ` David
  2011-07-09  3:48   ` Antti Palosaari
  0 siblings, 1 reply; 5+ messages in thread
From: David @ 2011-06-23 21:37 UTC (permalink / raw)
  To: Antti Palosaari; +Cc: linux-media

Hello:

I expect the patches finally are ok.

This patches add

Signed-off-by: Emilio David Diaus Lopez <reality_es@yahoo.es>
-----------------------------------------

-- ./drivers/media/dvb/dvb-usb/af9015.c.orig    2011-06-21
12:39:44.000000000 +0200
+++ ./drivers/media/dvb/dvb-usb/af9015.c        2011-06-22
12:05:28.000000000 +0200
@@ -749,6 +749,8 @@ static const struct af9015_rc_setup af90
               RC_MAP_AZUREWAVE_AD_TU700 },
       { (USB_VID_MSI_2 << 16) + USB_PID_MSI_DIGI_VOX_MINI_III,
               RC_MAP_MSI_DIGIVOX_III },
+       { (USB_VID_KWORLD_2 << 16) + USB_PID_SVEON_STV22,
+               RC_MAP_MSI_DIGIVOX_III },
       { (USB_VID_LEADTEK << 16) + USB_PID_WINFAST_DTV_DONGLE_GOLD,
               RC_MAP_LEADTEK_Y04G0051 },
       { (USB_VID_AVERMEDIA << 16) + USB_PID_AVERMEDIA_VOLAR_X,
@@ -1309,6 +1311,7 @@ static struct usb_device_id af9015_usb_t
               USB_PID_TERRATEC_CINERGY_T_STICK_DUAL_RC)},
 /* 35 */{USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A850T)},
       {USB_DEVICE(USB_VID_GTEK,      USB_PID_TINYTWIN_3)},
+       {USB_DEVICE(USB_VID_KWORLD_2,  USB_PID_SVEON_STV22)},
       {0},
 };
 MODULE_DEVICE_TABLE(usb, af9015_usb_table);
@@ -1649,6 +1652,11 @@ static struct dvb_usb_device_properties
                               .warm_ids = {NULL},
                       },
                       {
+                               .name = "Sveon STV22 Dual USB DVB-T
Tuner HDTV ",
+                               .cold_ids = {&af9015_usb_table[37], NULL},
+                               .warm_ids = {NULL},
+                       },
+                       {
                               .name = "Leadtek WinFast DTV2000DS",
                               .cold_ids = {&af9015_usb_table[29], NULL},
                               .warm_ids = {NULL},

------------------------------
--- ./drivers/media/dvb/dvb-usb/dvb-usb-ids.h.orig      2011-06-21
12:39:45.000000000 +0200
+++ ./drivers/media/dvb/dvb-usb/dvb-usb-ids.h   2011-06-18
11:48:22.000000000 +0200
@@ -128,6 +128,7 @@
 #define USB_PID_INTEL_CE9500                           0x9500
 #define USB_PID_KWORLD_399U                            0xe399
 #define USB_PID_KWORLD_399U_2                          0xe400
+#define USB_PID_SVEON_STV22                            0xe401
 #define USB_PID_KWORLD_395U                            0xe396
 #define USB_PID_KWORLD_395U_2                          0xe39b
 #define USB_PID_KWORLD_395U_3                          0xe395
------------------------
1.1
-----------------------
Thanks for your time

goodbye
Emilio David Diaus López

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Fwd: [PATCH] STV22 Dual USB DVB-T Tuner HDTV linux kernel support
  2011-06-23 21:37 ` Fwd: " David
@ 2011-07-09  3:48   ` Antti Palosaari
  2011-07-12 20:33     ` David
  0 siblings, 1 reply; 5+ messages in thread
From: Antti Palosaari @ 2011-07-09  3:48 UTC (permalink / raw)
  To: David; +Cc: linux-media

On 06/24/2011 12:37 AM, David wrote:
> Hello:
>
> I expect the patches finally are ok.

Hello and sorry for delay.
Your patch is not OK.

Biggest fault is that it does not increase .num_device_descs count. It 
will break some other device. Don't try to add new devices between 
existing devices. If you were added it correctly behind existing devices 
you must already find out something is broken since device was not detected.

See that example how to add device:
http://kerneltrap.org/mailarchive/git-commits-head/2010/5/20/34349/thread

Good place, for example, to add your device is behind: "AverMedia AVerTV 
Volar Black HD (A850)" device.

And here is example how to map remote:
http://www.mail-archive.com/linuxtv-commits@linuxtv.org/msg09016.html


Antti




>
> This patches add
>
> Signed-off-by: Emilio David Diaus Lopez<reality_es@yahoo.es>
> -----------------------------------------
>
> -- ./drivers/media/dvb/dvb-usb/af9015.c.orig    2011-06-21
> 12:39:44.000000000 +0200
> +++ ./drivers/media/dvb/dvb-usb/af9015.c        2011-06-22
> 12:05:28.000000000 +0200
> @@ -749,6 +749,8 @@ static const struct af9015_rc_setup af90
>                 RC_MAP_AZUREWAVE_AD_TU700 },
>         { (USB_VID_MSI_2<<  16) + USB_PID_MSI_DIGI_VOX_MINI_III,
>                 RC_MAP_MSI_DIGIVOX_III },
> +       { (USB_VID_KWORLD_2<<  16) + USB_PID_SVEON_STV22,
> +               RC_MAP_MSI_DIGIVOX_III },
>         { (USB_VID_LEADTEK<<  16) + USB_PID_WINFAST_DTV_DONGLE_GOLD,
>                 RC_MAP_LEADTEK_Y04G0051 },
>         { (USB_VID_AVERMEDIA<<  16) + USB_PID_AVERMEDIA_VOLAR_X,
> @@ -1309,6 +1311,7 @@ static struct usb_device_id af9015_usb_t
>                 USB_PID_TERRATEC_CINERGY_T_STICK_DUAL_RC)},
>   /* 35 */{USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A850T)},
>         {USB_DEVICE(USB_VID_GTEK,      USB_PID_TINYTWIN_3)},
> +       {USB_DEVICE(USB_VID_KWORLD_2,  USB_PID_SVEON_STV22)},
>         {0},
>   };
>   MODULE_DEVICE_TABLE(usb, af9015_usb_table);
> @@ -1649,6 +1652,11 @@ static struct dvb_usb_device_properties
>                                 .warm_ids = {NULL},
>                         },
>                         {
> +                               .name = "Sveon STV22 Dual USB DVB-T
> Tuner HDTV ",
> +                               .cold_ids = {&af9015_usb_table[37], NULL},
> +                               .warm_ids = {NULL},
> +                       },
> +                       {
>                                 .name = "Leadtek WinFast DTV2000DS",
>                                 .cold_ids = {&af9015_usb_table[29], NULL},
>                                 .warm_ids = {NULL},
>
> ------------------------------
> --- ./drivers/media/dvb/dvb-usb/dvb-usb-ids.h.orig      2011-06-21
> 12:39:45.000000000 +0200
> +++ ./drivers/media/dvb/dvb-usb/dvb-usb-ids.h   2011-06-18
> 11:48:22.000000000 +0200
> @@ -128,6 +128,7 @@
>   #define USB_PID_INTEL_CE9500                           0x9500
>   #define USB_PID_KWORLD_399U                            0xe399
>   #define USB_PID_KWORLD_399U_2                          0xe400
> +#define USB_PID_SVEON_STV22                            0xe401
>   #define USB_PID_KWORLD_395U                            0xe396
>   #define USB_PID_KWORLD_395U_2                          0xe39b
>   #define USB_PID_KWORLD_395U_3                          0xe395
> ------------------------
> 1.1
> -----------------------
> Thanks for your time
>
> goodbye
> Emilio David Diaus López
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 
http://palosaari.fi/

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Fwd: [PATCH] STV22 Dual USB DVB-T Tuner HDTV linux kernel support
  2011-07-09  3:48   ` Antti Palosaari
@ 2011-07-12 20:33     ` David
  2011-07-12 23:02       ` Antti Palosaari
  0 siblings, 1 reply; 5+ messages in thread
From: David @ 2011-07-12 20:33 UTC (permalink / raw)
  To: Antti Palosaari, linux-media

Hello Again:

The new patches are done, please tell me if i have to make any
changes. Thanks for your time.

Signed-off-by: Emilio David Diaus Lopez <reality_es@yahoo.es>
----------------------------------------------
--- ./drivers/media/dvb/dvb-usb/af9015.c.orig    2011-03-22
05:45:24.000000000 +0100
+++ ./drivers/media/dvb/dvb-usb/af9015.c    2011-07-12 22:04:15.612645277 +0200
@@ -759,6 +759,8 @@ static const struct af9015_rc_setup af90
         RC_MAP_DIGITALNOW_TINYTWIN },
     { (USB_VID_GTEK << 16) + USB_PID_TINYTWIN_3,
         RC_MAP_DIGITALNOW_TINYTWIN },
+    { (USB_VID_KWORLD_2 << 16) + USB_PID_SVEON_STV22,
+        RC_MAP_MSI_DIGIVOX_III },
     { }
 };

@@ -1309,6 +1311,7 @@ static struct usb_device_id af9015_usb_t
         USB_PID_TERRATEC_CINERGY_T_STICK_DUAL_RC)},
 /* 35 */{USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A850T)},
     {USB_DEVICE(USB_VID_GTEK,      USB_PID_TINYTWIN_3)},
+    {USB_DEVICE(USB_VID_KWORLD_2,  USB_PID_SVEON_STV22)},
     {0},
 };
 MODULE_DEVICE_TABLE(usb, af9015_usb_table);
@@ -1502,7 +1505,7 @@ static struct dvb_usb_device_properties

         .i2c_algo = &af9015_i2c_algo,

-        .num_device_descs = 9, /* check max from dvb-usb.h */
+        .num_device_descs = 10, /* check max from dvb-usb.h */
         .devices = {
             {
                 .name = "Xtensions XD-380",
@@ -1554,6 +1557,11 @@ static struct dvb_usb_device_properties
                 .cold_ids = {&af9015_usb_table[20], NULL},
                 .warm_ids = {NULL},
             },
+                        {
+                .name = "Sveon STV22 Dual USB DVB-T Tuner HDTV ",
+                .cold_ids = {&af9015_usb_table[37], NULL},
+                .warm_ids = {NULL},
+            },
         }
     }, {
         .caps = DVB_USB_IS_AN_I2C_ADAPTER,
------------------------
--- ./drivers/media/dvb/dvb-usb/dvb-usb-ids.h.orig    2011-06-08
03:51:23.000000000 +0200
+++ ./drivers/media/dvb/dvb-usb/dvb-usb-ids.h    2011-07-12
22:06:22.432044202 +0200
@@ -315,6 +315,7 @@
 #define USB_PID_FRIIO_WHITE                0x0001
 #define USB_PID_TVWAY_PLUS                0x0002
 #define USB_PID_SVEON_STV20                0xe39d
+#define USB_PID_SVEON_STV22                0xe401
 #define USB_PID_AZUREWAVE_AZ6027            0x3275
 #define USB_PID_TERRATEC_DVBS2CI_V1            0x10a4
 #define USB_PID_TERRATEC_DVBS2CI_V2            0x10ac
----------------------
1.3
-------------------------

regards

Emilio David Diaus López

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Fwd: [PATCH] STV22 Dual USB DVB-T Tuner HDTV linux kernel support
  2011-07-12 20:33     ` David
@ 2011-07-12 23:02       ` Antti Palosaari
  0 siblings, 0 replies; 5+ messages in thread
From: Antti Palosaari @ 2011-07-12 23:02 UTC (permalink / raw)
  To: David; +Cc: linux-media

On 07/12/2011 11:33 PM, David wrote:
> The new patches are done, please tell me if i have to make any
> changes. Thanks for your time.

Patch was still broken formally, seems like even Patchwork [1] cannot 
catch it. Anyhow, I copied it manually my tree [2] in order to go 
forward. No need your action any-more, thank you!

[1] https://patchwork.kernel.org/project/linux-media/list/
[2] 
http://git.linuxtv.org/anttip/media_tree.git?a=shortlog;h=refs/heads/af9015


regards
Antti

-- 
http://palosaari.fi/

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-07-12 23:02 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-23 15:39 [PATCH] STV22 Dual USB DVB-T Tuner HDTV linux kernel support Emilio David Diaus López
2011-06-23 21:37 ` Fwd: " David
2011-07-09  3:48   ` Antti Palosaari
2011-07-12 20:33     ` David
2011-07-12 23:02       ` Antti Palosaari

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).