From: Steve Cho <stevecho@chromium.org>
To: Yunfei Dong <yunfei.dong@mediatek.com>
Cc: Alexandre Courbot <acourbot@chromium.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Tzung-Bi Shih <tzungbi@chromium.org>,
Tiffany Lin <tiffany.lin@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tomasz Figa <tfiga@google.com>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Fritz Koenig <frkoenig@chromium.org>,
Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel <dri-devel@lists.freedesktop.org>,
Irui Wang <irui.wang@mediatek.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v11, 03/19] media: mtk-vcodec: Refactor vcodec pm interface
Date: Wed, 1 Dec 2021 16:10:00 -0800 [thread overview]
Message-ID: <CAC-pXoNtM0CFp9iFtZLtgQ7ZG9VewXyk9wF66w6YcEE4skRghA@mail.gmail.com> (raw)
In-Reply-To: <20211129034201.5767-4-yunfei.dong@mediatek.com>
Reviewed-by: Steve Cho <stevecho@chromium.org>
On Sun, Nov 28, 2021 at 7:44 PM Yunfei Dong <yunfei.dong@mediatek.com> wrote:
>
> Using the needed param for pm init/release function and remove unused
> param mtkdev in 'struct mtk_vcodec_pm'.
nit: How about s/needed param/needed params |pdev| and |pm|/ ?
> Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
> ---
> .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 6 ++---
> .../platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 22 ++++++++-----------
> .../platform/mtk-vcodec/mtk_vcodec_dec_pm.h | 5 +++--
> .../platform/mtk-vcodec/mtk_vcodec_drv.h | 1 -
> .../platform/mtk-vcodec/mtk_vcodec_enc_pm.c | 1 -
> 5 files changed, 15 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c
> index 055d50e52720..3ac4c3935e4e 100644
> --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c
> +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c
> @@ -249,7 +249,7 @@ static int mtk_vcodec_probe(struct platform_device *pdev)
> if (IS_ERR(dev->fw_handler))
> return PTR_ERR(dev->fw_handler);
>
> - ret = mtk_vcodec_init_dec_pm(dev);
> + ret = mtk_vcodec_init_dec_pm(dev->plat_dev, &dev->pm);
> if (ret < 0) {
> dev_err(&pdev->dev, "Failed to get mt vcodec clock source");
> goto err_dec_pm;
> @@ -378,7 +378,7 @@ static int mtk_vcodec_probe(struct platform_device *pdev)
> err_dec_alloc:
> v4l2_device_unregister(&dev->v4l2_dev);
> err_res:
> - mtk_vcodec_release_dec_pm(dev);
> + mtk_vcodec_release_dec_pm(&dev->pm);
> err_dec_pm:
> mtk_vcodec_fw_release(dev->fw_handler);
> return ret;
> @@ -418,7 +418,7 @@ static int mtk_vcodec_dec_remove(struct platform_device *pdev)
> video_unregister_device(dev->vfd_dec);
>
> v4l2_device_unregister(&dev->v4l2_dev);
> - mtk_vcodec_release_dec_pm(dev);
> + mtk_vcodec_release_dec_pm(&dev->pm);
> mtk_vcodec_fw_release(dev->fw_handler);
> return 0;
> }
> diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c
> index 6038db96f71c..20bd157a855c 100644
> --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c
> +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c
> @@ -13,18 +13,15 @@
> #include "mtk_vcodec_dec_pm.h"
> #include "mtk_vcodec_util.h"
>
> -int mtk_vcodec_init_dec_pm(struct mtk_vcodec_dev *mtkdev)
> +int mtk_vcodec_init_dec_pm(struct platform_device *pdev,
> + struct mtk_vcodec_pm *pm)
> {
> struct device_node *node;
> - struct platform_device *pdev;
> - struct mtk_vcodec_pm *pm;
> + struct platform_device *larb_pdev;
> struct mtk_vcodec_clk *dec_clk;
> struct mtk_vcodec_clk_info *clk_info;
> int i = 0, ret = 0;
>
> - pdev = mtkdev->plat_dev;
> - pm = &mtkdev->pm;
> - pm->mtkdev = mtkdev;
> dec_clk = &pm->vdec_clk;
> node = of_parse_phandle(pdev->dev.of_node, "mediatek,larb", 0);
> if (!node) {
> @@ -32,13 +29,12 @@ int mtk_vcodec_init_dec_pm(struct mtk_vcodec_dev *mtkdev)
> return -1;
> }
>
> - pdev = of_find_device_by_node(node);
> + larb_pdev = of_find_device_by_node(node);
> of_node_put(node);
> - if (WARN_ON(!pdev)) {
> + if (WARN_ON(!larb_pdev)) {
> return -1;
> }
> - pm->larbvdec = &pdev->dev;
> - pdev = mtkdev->plat_dev;
> + pm->larbvdec = &larb_pdev->dev;
> pm->dev = &pdev->dev;
>
> dec_clk->clk_num =
> @@ -82,10 +78,10 @@ int mtk_vcodec_init_dec_pm(struct mtk_vcodec_dev *mtkdev)
> return ret;
> }
>
> -void mtk_vcodec_release_dec_pm(struct mtk_vcodec_dev *dev)
> +void mtk_vcodec_release_dec_pm(struct mtk_vcodec_pm *pm)
> {
> - pm_runtime_disable(dev->pm.dev);
> - put_device(dev->pm.larbvdec);
> + pm_runtime_disable(pm->dev);
> + put_device(pm->larbvdec);
> }
>
> int mtk_vcodec_dec_pw_on(struct mtk_vcodec_pm *pm)
> diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.h
> index 280aeaefdb65..a3df6aef6cb9 100644
> --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.h
> +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.h
> @@ -9,8 +9,9 @@
>
> #include "mtk_vcodec_drv.h"
>
> -int mtk_vcodec_init_dec_pm(struct mtk_vcodec_dev *dev);
> -void mtk_vcodec_release_dec_pm(struct mtk_vcodec_dev *dev);
> +int mtk_vcodec_init_dec_pm(struct platform_device *pdev,
> + struct mtk_vcodec_pm *pm);
> +void mtk_vcodec_release_dec_pm(struct mtk_vcodec_pm *pm);
>
> int mtk_vcodec_dec_pw_on(struct mtk_vcodec_pm *pm);
> void mtk_vcodec_dec_pw_off(struct mtk_vcodec_pm *pm);
> diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h
> index 1d2370608d0d..0fa9d85114b9 100644
> --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h
> +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h
> @@ -195,7 +195,6 @@ struct mtk_vcodec_pm {
> struct mtk_vcodec_clk venc_clk;
> struct device *larbvenc;
> struct device *dev;
> - struct mtk_vcodec_dev *mtkdev;
> };
>
> /**
> diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.c
> index 1b2e4930ed27..0c8c8f86788c 100644
> --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.c
> +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.c
> @@ -26,7 +26,6 @@ int mtk_vcodec_init_enc_pm(struct mtk_vcodec_dev *mtkdev)
> pdev = mtkdev->plat_dev;
> pm = &mtkdev->pm;
> memset(pm, 0, sizeof(struct mtk_vcodec_pm));
> - pm->mtkdev = mtkdev;
> pm->dev = &pdev->dev;
> dev = &pdev->dev;
> enc_clk = &pm->venc_clk;
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-12-02 0:10 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 3:41 [PATCH v11, 00/19] Support multi hardware decode using of_platform_populate Yunfei Dong
2021-11-29 3:41 ` [PATCH v11, 01/19] media: mtk-vcodec: Get numbers of register bases from DT Yunfei Dong
2021-11-30 13:20 ` Benjamin Gaignard
2021-12-02 2:24 ` yunfei.dong
2021-11-29 3:41 ` [PATCH v11, 02/19] media: mtk-vcodec: Align vcodec wake up interrupt interface Yunfei Dong
2021-12-01 23:55 ` Steve Cho
2021-12-01 23:58 ` Steve Cho
2021-11-29 3:41 ` [PATCH v11, 03/19] media: mtk-vcodec: Refactor vcodec pm interface Yunfei Dong
2021-12-02 0:10 ` Steve Cho [this message]
2021-11-29 3:41 ` [PATCH v11, 04/19] media: mtk-vcodec: export decoder pm functions Yunfei Dong
2021-11-30 13:34 ` Benjamin Gaignard
2021-12-03 1:50 ` yunfei.dong
2021-12-01 12:09 ` AngeloGioacchino Del Regno
2021-12-01 23:59 ` Steve Cho
2021-11-29 3:41 ` [PATCH v11, 05/19] media: mtk-vcodec: Support MT8192 Yunfei Dong
2021-12-01 12:09 ` AngeloGioacchino Del Regno
2021-12-01 23:58 ` Steve Cho
2021-11-29 3:41 ` [PATCH v11, 06/19] media: mtk-vcodec: Add to support multi hardware decode Yunfei Dong
2021-11-29 3:41 ` [PATCH v11, 07/19] dt-bindings: media: mtk-vcodec: Separate video encoder and decoder dt-bindings Yunfei Dong
2021-11-29 3:41 ` [PATCH v11, 08/19] media: mtk-vcodec: Use pure single core for MT8183 Yunfei Dong
2021-11-29 3:41 ` [PATCH v11, 09/19] media: mtk-vcodec: Add irq interface for multi hardware Yunfei Dong
2021-12-01 12:09 ` AngeloGioacchino Del Regno
2021-11-29 3:41 ` [PATCH v11, 10/19] media: mtk-vcodec: Add msg queue feature for lat and core architecture Yunfei Dong
2021-12-01 12:09 ` AngeloGioacchino Del Regno
2021-12-03 1:55 ` yunfei.dong
2021-11-29 3:41 ` [PATCH v11, 11/19] media: mtk-vcodec: Generalize power and clock on/off interfaces Yunfei Dong
2021-12-01 12:09 ` AngeloGioacchino Del Regno
2021-11-29 3:41 ` [PATCH v11, 12/19] media: mtk-vcodec: Add new interface to lock different hardware Yunfei Dong
2021-11-29 3:41 ` [PATCH v11, 13/19] media: mtk-vcodec: Add work queue for core hardware decode Yunfei Dong
2021-11-29 3:41 ` [PATCH v11,14/19] media: mtk-vcodec: Support 34bits dma address for vdec Yunfei Dong
2021-12-01 12:09 ` AngeloGioacchino Del Regno
2021-11-29 3:41 ` [PATCH v11, 15/19] dt-bindings: media: mtk-vcodec: Adds decoder dt-bindings for mt8192 Yunfei Dong
2021-11-29 3:41 ` [PATCH v11, 16/19] media: mtk-vcodec: Add core dec and dec end ipi msg Yunfei Dong
2021-11-29 3:41 ` [PATCH v11, 17/19] media: mtk-vcodec: Use codec type to separate different hardware Yunfei Dong
2021-11-29 3:42 ` [PATCH v11, 18/19] media: mtk-vcodec: Remove mtk_vcodec_release_dec_pm Yunfei Dong
2021-12-01 12:08 ` AngeloGioacchino Del Regno
2021-11-29 3:42 ` [PATCH v11, 19/19] media: mtk-vcodec: Remove mtk_vcodec_release_enc_pm Yunfei Dong
2021-12-01 12:08 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAC-pXoNtM0CFp9iFtZLtgQ7ZG9VewXyk9wF66w6YcEE4skRghA@mail.gmail.com \
--to=stevecho@chromium.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=acourbot@chromium.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=benjamin.gaignard@collabora.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frkoenig@chromium.org \
--cc=hsinyi@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=irui.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@google.com \
--cc=tiffany.lin@mediatek.com \
--cc=tzungbi@chromium.org \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).