From: "yunfei.dong@mediatek.com" <yunfei.dong@mediatek.com>
To: Benjamin Gaignard <benjamin.gaignard@collabora.com>,
Alexandre Courbot <acourbot@chromium.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
"Tzung-Bi Shih" <tzungbi@chromium.org>,
Tiffany Lin <tiffany.lin@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tomasz Figa <tfiga@google.com>
Cc: Hsin-Yi Wang <hsinyi@chromium.org>,
Fritz Koenig <frkoenig@chromium.org>,
Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel <dri-devel@lists.freedesktop.org>,
Irui Wang <irui.wang@mediatek.com>, <linux-media@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<srv_heupstream@mediatek.com>,
<linux-mediatek@lists.infradead.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH v11, 04/19] media: mtk-vcodec: export decoder pm functions
Date: Fri, 3 Dec 2021 09:50:04 +0800 [thread overview]
Message-ID: <e4be43859ea07a8382f927905c32f047dda77584.camel@mediatek.com> (raw)
In-Reply-To: <2fa4e19f-d57c-6264-4284-8387c4182d1f@collabora.com>
Hi Benjamin,
Thanks for your suggestion.
On Tue, 2021-11-30 at 14:34 +0100, Benjamin Gaignard wrote:
> Le 29/11/2021 à 04:41, Yunfei Dong a écrit :
> > Register each hardware as platform device, need to call pm
> > functions
> > to open/close power and clock from module mtk-vcodec-dec, export
> > these
> > functions.
>
> The commit message confuse me, maybe something like:
> "When mtk vcodec decoder is build as a module we need to export
> mtk-vcodec-dec pm functions to make them visible by the other
> components"
>
Fix in patch v12
> With that:
> Reviewed-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
>
Best Regards,
Yunfei Dong
> >
> > Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
> > ---
> > drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c
> > b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c
> > index 20bd157a855c..221cf60e9fbf 100644
> > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c
> > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c
> > @@ -77,12 +77,14 @@ int mtk_vcodec_init_dec_pm(struct
> > platform_device *pdev,
> > put_device(pm->larbvdec);
> > return ret;
> > }
> > +EXPORT_SYMBOL_GPL(mtk_vcodec_init_dec_pm);
> >
> > void mtk_vcodec_release_dec_pm(struct mtk_vcodec_pm *pm)
> > {
> > pm_runtime_disable(pm->dev);
> > put_device(pm->larbvdec);
> > }
> > +EXPORT_SYMBOL_GPL(mtk_vcodec_release_dec_pm);
> >
> > int mtk_vcodec_dec_pw_on(struct mtk_vcodec_pm *pm)
> > {
> > @@ -94,6 +96,7 @@ int mtk_vcodec_dec_pw_on(struct mtk_vcodec_pm
> > *pm)
> >
> > return ret;
> > }
> > +EXPORT_SYMBOL_GPL(mtk_vcodec_dec_pw_on);
> >
> > void mtk_vcodec_dec_pw_off(struct mtk_vcodec_pm *pm)
> > {
> > @@ -103,6 +106,7 @@ void mtk_vcodec_dec_pw_off(struct mtk_vcodec_pm
> > *pm)
> > if (ret)
> > mtk_v4l2_err("pm_runtime_put_sync fail %d", ret);
> > }
> > +EXPORT_SYMBOL_GPL(mtk_vcodec_dec_pw_off);
> >
> > void mtk_vcodec_dec_clock_on(struct mtk_vcodec_pm *pm)
> > {
> > @@ -129,6 +133,7 @@ void mtk_vcodec_dec_clock_on(struct
> > mtk_vcodec_pm *pm)
> > for (i -= 1; i >= 0; i--)
> > clk_disable_unprepare(dec_clk->clk_info[i].vcodec_clk);
> > }
> > +EXPORT_SYMBOL_GPL(mtk_vcodec_dec_clock_on);
> >
> > void mtk_vcodec_dec_clock_off(struct mtk_vcodec_pm *pm)
> > {
> > @@ -139,3 +144,4 @@ void mtk_vcodec_dec_clock_off(struct
> > mtk_vcodec_pm *pm)
> > for (i = dec_clk->clk_num - 1; i >= 0; i--)
> > clk_disable_unprepare(dec_clk->clk_info[i].vcodec_clk);
> > }
> > +EXPORT_SYMBOL_GPL(mtk_vcodec_dec_clock_off);
next prev parent reply other threads:[~2021-12-03 1:50 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 3:41 [PATCH v11, 00/19] Support multi hardware decode using of_platform_populate Yunfei Dong
2021-11-29 3:41 ` [PATCH v11, 01/19] media: mtk-vcodec: Get numbers of register bases from DT Yunfei Dong
2021-11-30 13:20 ` Benjamin Gaignard
2021-12-02 2:24 ` yunfei.dong
2021-11-29 3:41 ` [PATCH v11, 02/19] media: mtk-vcodec: Align vcodec wake up interrupt interface Yunfei Dong
2021-12-01 23:55 ` Steve Cho
2021-12-01 23:58 ` Steve Cho
2021-11-29 3:41 ` [PATCH v11, 03/19] media: mtk-vcodec: Refactor vcodec pm interface Yunfei Dong
2021-12-02 0:10 ` Steve Cho
2021-11-29 3:41 ` [PATCH v11, 04/19] media: mtk-vcodec: export decoder pm functions Yunfei Dong
2021-11-30 13:34 ` Benjamin Gaignard
2021-12-03 1:50 ` yunfei.dong [this message]
2021-12-01 12:09 ` AngeloGioacchino Del Regno
2021-12-01 23:59 ` Steve Cho
2021-11-29 3:41 ` [PATCH v11, 05/19] media: mtk-vcodec: Support MT8192 Yunfei Dong
2021-12-01 12:09 ` AngeloGioacchino Del Regno
2021-12-01 23:58 ` Steve Cho
2021-11-29 3:41 ` [PATCH v11, 06/19] media: mtk-vcodec: Add to support multi hardware decode Yunfei Dong
2021-11-29 3:41 ` [PATCH v11, 07/19] dt-bindings: media: mtk-vcodec: Separate video encoder and decoder dt-bindings Yunfei Dong
2021-11-29 3:41 ` [PATCH v11, 08/19] media: mtk-vcodec: Use pure single core for MT8183 Yunfei Dong
2021-11-29 3:41 ` [PATCH v11, 09/19] media: mtk-vcodec: Add irq interface for multi hardware Yunfei Dong
2021-12-01 12:09 ` AngeloGioacchino Del Regno
2021-11-29 3:41 ` [PATCH v11, 10/19] media: mtk-vcodec: Add msg queue feature for lat and core architecture Yunfei Dong
2021-12-01 12:09 ` AngeloGioacchino Del Regno
2021-12-03 1:55 ` yunfei.dong
2021-11-29 3:41 ` [PATCH v11, 11/19] media: mtk-vcodec: Generalize power and clock on/off interfaces Yunfei Dong
2021-12-01 12:09 ` AngeloGioacchino Del Regno
2021-11-29 3:41 ` [PATCH v11, 12/19] media: mtk-vcodec: Add new interface to lock different hardware Yunfei Dong
2021-11-29 3:41 ` [PATCH v11, 13/19] media: mtk-vcodec: Add work queue for core hardware decode Yunfei Dong
2021-11-29 3:41 ` [PATCH v11,14/19] media: mtk-vcodec: Support 34bits dma address for vdec Yunfei Dong
2021-12-01 12:09 ` AngeloGioacchino Del Regno
2021-11-29 3:41 ` [PATCH v11, 15/19] dt-bindings: media: mtk-vcodec: Adds decoder dt-bindings for mt8192 Yunfei Dong
2021-11-29 3:41 ` [PATCH v11, 16/19] media: mtk-vcodec: Add core dec and dec end ipi msg Yunfei Dong
2021-11-29 3:41 ` [PATCH v11, 17/19] media: mtk-vcodec: Use codec type to separate different hardware Yunfei Dong
2021-11-29 3:42 ` [PATCH v11, 18/19] media: mtk-vcodec: Remove mtk_vcodec_release_dec_pm Yunfei Dong
2021-12-01 12:08 ` AngeloGioacchino Del Regno
2021-11-29 3:42 ` [PATCH v11, 19/19] media: mtk-vcodec: Remove mtk_vcodec_release_enc_pm Yunfei Dong
2021-12-01 12:08 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4be43859ea07a8382f927905c32f047dda77584.camel@mediatek.com \
--to=yunfei.dong@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=acourbot@chromium.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=benjamin.gaignard@collabora.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frkoenig@chromium.org \
--cc=hsinyi@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=irui.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@google.com \
--cc=tiffany.lin@mediatek.com \
--cc=tzungbi@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).