* Re: [git:media_tree/master] media: dt-bindings: media: Use OF graph schema
[not found] <E1kkTsj-0029fe-8O@www.linuxtv.org>
@ 2020-12-02 15:45 ` Rob Herring
2020-12-02 15:52 ` Laurent Pinchart
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2020-12-02 15:45 UTC (permalink / raw)
To: Linux Media Mailing List, Mauro Carvalho Chehab
Cc: linuxtv-commits, Jacopo Mondi, Maxime Ripard, Laurent Pinchart,
Laurent Pinchart, Sakari Ailus
On Wed, Dec 2, 2020 at 8:17 AM Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> wrote:
>
> This is an automatic generated email to let you know that the following patch were queued:
>
> Subject: media: dt-bindings: media: Use OF graph schema
> Author: Rob Herring <robh@kernel.org>
> Date: Tue Nov 17 02:39:47 2020 +0100
>
> Now that we have a graph schema, rework the media related schemas to
> use it. Mostly this is adding a reference to graph.yaml and dropping
> duplicate parts from schemas.
>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Jacopo Mondi <jacopo@jmondi.org>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Laurent did not ack this. There was discussion on this and it needs a
v2. Please drop.
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
>
> .../bindings/media/allwinner,sun4i-a10-csi.yaml | 1 +
> .../bindings/media/allwinner,sun6i-a31-csi.yaml | 1 +
> .../devicetree/bindings/media/i2c/adv7180.yaml | 31 ++-------
> .../devicetree/bindings/media/i2c/adv7604.yaml | 32 ++-------
> .../bindings/media/i2c/aptina,mt9v111.yaml | 2 +-
> .../bindings/media/i2c/imi,rdacm2x-gmsl.yaml | 25 +------
> .../devicetree/bindings/media/i2c/imx219.yaml | 4 ++
> .../bindings/media/i2c/maxim,max9286.yaml | 76 +++++-----------------
> .../devicetree/bindings/media/i2c/ov5647.yaml | 5 +-
> .../devicetree/bindings/media/i2c/ov8856.yaml | 5 +-
> .../devicetree/bindings/media/i2c/ovti,ov772x.yaml | 1 +
> .../devicetree/bindings/media/i2c/sony,imx214.yaml | 1 +
> .../devicetree/bindings/media/i2c/sony,imx274.yaml | 3 +-
> .../bindings/media/marvell,mmp2-ccic.yaml | 1 +
> .../devicetree/bindings/media/renesas,ceu.yaml | 1 +
> .../devicetree/bindings/media/renesas,csi2.yaml | 36 ++--------
> .../devicetree/bindings/media/renesas,vin.yaml | 7 +-
> .../devicetree/bindings/media/st,stm32-dcmi.yaml | 7 +-
> .../devicetree/bindings/media/ti,cal.yaml | 15 ++---
> .../bindings/media/xilinx/xlnx,csi2rxss.yaml | 21 +-----
> 20 files changed, 61 insertions(+), 214 deletions(-)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [git:media_tree/master] media: dt-bindings: media: Use OF graph schema
2020-12-02 15:45 ` [git:media_tree/master] media: dt-bindings: media: Use OF graph schema Rob Herring
@ 2020-12-02 15:52 ` Laurent Pinchart
2020-12-02 16:30 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Laurent Pinchart @ 2020-12-02 15:52 UTC (permalink / raw)
To: Rob Herring
Cc: Linux Media Mailing List, Mauro Carvalho Chehab, linuxtv-commits,
Jacopo Mondi, Maxime Ripard, Laurent Pinchart, Sakari Ailus
On Wed, Dec 02, 2020 at 08:45:59AM -0700, Rob Herring wrote:
> On Wed, Dec 2, 2020 at 8:17 AM Mauro Carvalho Chehab
> <mchehab+huawei@kernel.org> wrote:
> >
> > This is an automatic generated email to let you know that the following patch were queued:
> >
> > Subject: media: dt-bindings: media: Use OF graph schema
> > Author: Rob Herring <robh@kernel.org>
> > Date: Tue Nov 17 02:39:47 2020 +0100
> >
> > Now that we have a graph schema, rework the media related schemas to
> > use it. Mostly this is adding a reference to graph.yaml and dropping
> > duplicate parts from schemas.
> >
> > Cc: Maxime Ripard <mripard@kernel.org>
> > Cc: Jacopo Mondi <jacopo@jmondi.org>
> > Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Laurent did not ack this. There was discussion on this and it needs a
> v2. Please drop.
I told Sakari in an IRC conversation I was fine with the patches, and he
asked if that meant an ack. I said yes, but didn't realize he wanted to
apply your v1. Sorry about the confusion :-S
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> >
> > .../bindings/media/allwinner,sun4i-a10-csi.yaml | 1 +
> > .../bindings/media/allwinner,sun6i-a31-csi.yaml | 1 +
> > .../devicetree/bindings/media/i2c/adv7180.yaml | 31 ++-------
> > .../devicetree/bindings/media/i2c/adv7604.yaml | 32 ++-------
> > .../bindings/media/i2c/aptina,mt9v111.yaml | 2 +-
> > .../bindings/media/i2c/imi,rdacm2x-gmsl.yaml | 25 +------
> > .../devicetree/bindings/media/i2c/imx219.yaml | 4 ++
> > .../bindings/media/i2c/maxim,max9286.yaml | 76 +++++-----------------
> > .../devicetree/bindings/media/i2c/ov5647.yaml | 5 +-
> > .../devicetree/bindings/media/i2c/ov8856.yaml | 5 +-
> > .../devicetree/bindings/media/i2c/ovti,ov772x.yaml | 1 +
> > .../devicetree/bindings/media/i2c/sony,imx214.yaml | 1 +
> > .../devicetree/bindings/media/i2c/sony,imx274.yaml | 3 +-
> > .../bindings/media/marvell,mmp2-ccic.yaml | 1 +
> > .../devicetree/bindings/media/renesas,ceu.yaml | 1 +
> > .../devicetree/bindings/media/renesas,csi2.yaml | 36 ++--------
> > .../devicetree/bindings/media/renesas,vin.yaml | 7 +-
> > .../devicetree/bindings/media/st,stm32-dcmi.yaml | 7 +-
> > .../devicetree/bindings/media/ti,cal.yaml | 15 ++---
> > .../bindings/media/xilinx/xlnx,csi2rxss.yaml | 21 +-----
> > 20 files changed, 61 insertions(+), 214 deletions(-)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [git:media_tree/master] media: dt-bindings: media: Use OF graph schema
2020-12-02 15:52 ` Laurent Pinchart
@ 2020-12-02 16:30 ` Rob Herring
2020-12-02 17:43 ` Sakari Ailus
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2020-12-02 16:30 UTC (permalink / raw)
To: Laurent Pinchart, Mauro Carvalho Chehab
Cc: Linux Media Mailing List, linuxtv-commits, Jacopo Mondi,
Maxime Ripard, Laurent Pinchart, Sakari Ailus
On Wed, Dec 2, 2020 at 8:52 AM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> On Wed, Dec 02, 2020 at 08:45:59AM -0700, Rob Herring wrote:
> > On Wed, Dec 2, 2020 at 8:17 AM Mauro Carvalho Chehab
> > <mchehab+huawei@kernel.org> wrote:
> > >
> > > This is an automatic generated email to let you know that the following patch were queued:
> > >
> > > Subject: media: dt-bindings: media: Use OF graph schema
> > > Author: Rob Herring <robh@kernel.org>
> > > Date: Tue Nov 17 02:39:47 2020 +0100
> > >
> > > Now that we have a graph schema, rework the media related schemas to
> > > use it. Mostly this is adding a reference to graph.yaml and dropping
> > > duplicate parts from schemas.
> > >
> > > Cc: Maxime Ripard <mripard@kernel.org>
> > > Cc: Jacopo Mondi <jacopo@jmondi.org>
> > > Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > Laurent did not ack this. There was discussion on this and it needs a
> > v2. Please drop.
>
> I told Sakari in an IRC conversation I was fine with the patches, and he
> asked if that meant an ack. I said yes, but didn't realize he wanted to
> apply your v1. Sorry about the confusion :-S
Thinking about this some more, I think video-interfaces.txt is going
to need to be converted first as well. Otherwise, it's going to be 2
rounds of whack-a-mole. Also consider that everything applied after
this needs to be converted with whatever we end up with. Folks will
need to respin their patches, the maintainer has to do it, or we'll
need another round. So consider when is the best time in the cycle to
apply?
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [git:media_tree/master] media: dt-bindings: media: Use OF graph schema
2020-12-02 16:30 ` Rob Herring
@ 2020-12-02 17:43 ` Sakari Ailus
2020-12-02 17:52 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Sakari Ailus @ 2020-12-02 17:43 UTC (permalink / raw)
To: Rob Herring
Cc: Laurent Pinchart, Mauro Carvalho Chehab,
Linux Media Mailing List, linuxtv-commits, Jacopo Mondi,
Maxime Ripard, Laurent Pinchart
Hi Rob, Laurent,
On Wed, Dec 02, 2020 at 09:30:27AM -0700, Rob Herring wrote:
> On Wed, Dec 2, 2020 at 8:52 AM Laurent Pinchart
> <laurent.pinchart@ideasonboard.com> wrote:
> >
> > On Wed, Dec 02, 2020 at 08:45:59AM -0700, Rob Herring wrote:
> > > On Wed, Dec 2, 2020 at 8:17 AM Mauro Carvalho Chehab
> > > <mchehab+huawei@kernel.org> wrote:
> > > >
> > > > This is an automatic generated email to let you know that the following patch were queued:
> > > >
> > > > Subject: media: dt-bindings: media: Use OF graph schema
> > > > Author: Rob Herring <robh@kernel.org>
> > > > Date: Tue Nov 17 02:39:47 2020 +0100
> > > >
> > > > Now that we have a graph schema, rework the media related schemas to
> > > > use it. Mostly this is adding a reference to graph.yaml and dropping
> > > > duplicate parts from schemas.
> > > >
> > > > Cc: Maxime Ripard <mripard@kernel.org>
> > > > Cc: Jacopo Mondi <jacopo@jmondi.org>
> > > > Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > > > Signed-off-by: Rob Herring <robh@kernel.org>
> > > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > >
> > > Laurent did not ack this. There was discussion on this and it needs a
> > > v2. Please drop.
I noticed it had been there for a while with some comments from Laurent
that didn't obviously result in any changes to the patch.
The patch is in Mauro's tree now. I can send a revert if you'd prefer that
instead of making changes on top of this.
> >
> > I told Sakari in an IRC conversation I was fine with the patches, and he
> > asked if that meant an ack. I said yes, but didn't realize he wanted to
> > apply your v1. Sorry about the confusion :-S
>
> Thinking about this some more, I think video-interfaces.txt is going
> to need to be converted first as well. Otherwise, it's going to be 2
> rounds of whack-a-mole. Also consider that everything applied after
> this needs to be converted with whatever we end up with. Folks will
> need to respin their patches, the maintainer has to do it, or we'll
> need another round. So consider when is the best time in the cycle to
> apply?
I don't think this would be a bad time (there will always be some binding
patches around), but again hopefully we'd have video-interfaces.txt
converted soon.
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [git:media_tree/master] media: dt-bindings: media: Use OF graph schema
2020-12-02 17:43 ` Sakari Ailus
@ 2020-12-02 17:52 ` Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2020-12-02 17:52 UTC (permalink / raw)
To: Sakari Ailus
Cc: Laurent Pinchart, Mauro Carvalho Chehab,
Linux Media Mailing List, linuxtv-commits, Jacopo Mondi,
Maxime Ripard, Laurent Pinchart
On Wed, Dec 2, 2020 at 10:43 AM Sakari Ailus
<sakari.ailus@linux.intel.com> wrote:
>
> Hi Rob, Laurent,
>
> On Wed, Dec 02, 2020 at 09:30:27AM -0700, Rob Herring wrote:
> > On Wed, Dec 2, 2020 at 8:52 AM Laurent Pinchart
> > <laurent.pinchart@ideasonboard.com> wrote:
> > >
> > > On Wed, Dec 02, 2020 at 08:45:59AM -0700, Rob Herring wrote:
> > > > On Wed, Dec 2, 2020 at 8:17 AM Mauro Carvalho Chehab
> > > > <mchehab+huawei@kernel.org> wrote:
> > > > >
> > > > > This is an automatic generated email to let you know that the following patch were queued:
> > > > >
> > > > > Subject: media: dt-bindings: media: Use OF graph schema
> > > > > Author: Rob Herring <robh@kernel.org>
> > > > > Date: Tue Nov 17 02:39:47 2020 +0100
> > > > >
> > > > > Now that we have a graph schema, rework the media related schemas to
> > > > > use it. Mostly this is adding a reference to graph.yaml and dropping
> > > > > duplicate parts from schemas.
> > > > >
> > > > > Cc: Maxime Ripard <mripard@kernel.org>
> > > > > Cc: Jacopo Mondi <jacopo@jmondi.org>
> > > > > Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > > > > Signed-off-by: Rob Herring <robh@kernel.org>
> > > > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > >
> > > > Laurent did not ack this. There was discussion on this and it needs a
> > > > v2. Please drop.
>
> I noticed it had been there for a while with some comments from Laurent
> that didn't obviously result in any changes to the patch.
It was probably clearer in the DRM version of the patch I referred to.
> The patch is in Mauro's tree now. I can send a revert if you'd prefer that
> instead of making changes on top of this.
It needs to be removed however you all want. While graph.yaml is in
dtschema, I'm reworking it and things will break when that's
committed.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-12-02 17:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <E1kkTsj-0029fe-8O@www.linuxtv.org>
2020-12-02 15:45 ` [git:media_tree/master] media: dt-bindings: media: Use OF graph schema Rob Herring
2020-12-02 15:52 ` Laurent Pinchart
2020-12-02 16:30 ` Rob Herring
2020-12-02 17:43 ` Sakari Ailus
2020-12-02 17:52 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).