* [PATCH -next] media: meson: vdec: Add missing kthread.h
@ 2019-06-12 10:05 YueHaibing
2019-06-12 10:21 ` Maxime Jourdan
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-06-12 10:05 UTC (permalink / raw)
To: mjourdan, mchehab, gregkh, khilman
Cc: linux-kernel, linux-arm-kernel, devel, linux-media, linux-media,
linux-amlogic, YueHaibing
Fix building error:
drivers/staging/media/meson/vdec/vdec.c: In function vdec_recycle_thread:
drivers/staging/media/meson/vdec/vdec.c:59:10: error: implicit declaration
of function kthread_should_stop;
did you mean thread_saved_sp? [-Werror=implicit-function-declaration]
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 3e7f51bd9607 ("media: meson: add v4l2 m2m video decoder driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/staging/media/meson/vdec/vdec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c
index 4e4f9d6..0a1a04f 100644
--- a/drivers/staging/media/meson/vdec/vdec.c
+++ b/drivers/staging/media/meson/vdec/vdec.c
@@ -12,6 +12,7 @@
#include <linux/mfd/syscon.h>
#include <linux/slab.h>
#include <linux/interrupt.h>
+#include <linux/kthread.h>
#include <media/v4l2-ioctl.h>
#include <media/v4l2-event.h>
#include <media/v4l2-ctrls.h>
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] media: meson: vdec: Add missing kthread.h
2019-06-12 10:05 [PATCH -next] media: meson: vdec: Add missing kthread.h YueHaibing
@ 2019-06-12 10:21 ` Maxime Jourdan
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Jourdan @ 2019-06-12 10:21 UTC (permalink / raw)
To: YueHaibing
Cc: Mauro Carvalho Chehab, gregkh, Kevin Hilman, linux-kernel,
linux-arm-kernel, devel, Linux Media Mailing List, linux-media,
linux-amlogic
On Wed, Jun 12, 2019 at 12:05 PM YueHaibing <yuehaibing@huawei.com> wrote:
>
> Fix building error:
>
> drivers/staging/media/meson/vdec/vdec.c: In function vdec_recycle_thread:
> drivers/staging/media/meson/vdec/vdec.c:59:10: error: implicit declaration
> of function kthread_should_stop;
> did you mean thread_saved_sp? [-Werror=implicit-function-declaration]
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 3e7f51bd9607 ("media: meson: add v4l2 m2m video decoder driver")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/staging/media/meson/vdec/vdec.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c
> index 4e4f9d6..0a1a04f 100644
> --- a/drivers/staging/media/meson/vdec/vdec.c
> +++ b/drivers/staging/media/meson/vdec/vdec.c
> @@ -12,6 +12,7 @@
> #include <linux/mfd/syscon.h>
> #include <linux/slab.h>
> #include <linux/interrupt.h>
> +#include <linux/kthread.h>
> #include <media/v4l2-ioctl.h>
> #include <media/v4l2-event.h>
> #include <media/v4l2-ctrls.h>
> --
> 2.7.4
>
>
Thanks for the patch, sorry that this one slipped through.
Acked-by: Maxime Jourdan <mjourdan@baylibre.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-12 10:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-12 10:05 [PATCH -next] media: meson: vdec: Add missing kthread.h YueHaibing
2019-06-12 10:21 ` Maxime Jourdan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).