* [PATCH] media: i2c: Kconfig: Make MAX9271 a module
@ 2021-02-08 18:20 Jacopo Mondi
2021-02-08 20:21 ` Sakari Ailus
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jacopo Mondi @ 2021-02-08 18:20 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Laurent Pinchart
Cc: Jacopo Mondi, Sakari Ailus, linux-media, linux-next,
linux-renesas-soc, Stephen Rothwell
With the introduction of the RDACM21 camera module support in
commit a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module")
the symbols defined by the max9271 library were exported twice
if multiple users of the library were compiled in at the same time.
In example:
WARNING: modpost: drivers/media/i2c/rdacm21-camera_module:
'max9271_set_serial_link' exported twice. Previous export was in
drivers/media/i2c/rdacm20-camera_module.ko
Fix this by making the rdacm21 file a module and have the driver
using its functions select it.
Fixes: a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Suggested-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
drivers/media/i2c/Kconfig | 5 +++++
drivers/media/i2c/Makefile | 7 +++----
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index 2d3dc0d82f9e..84645f751da3 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -1240,12 +1240,16 @@ config VIDEO_NOON010PC30
source "drivers/media/i2c/m5mols/Kconfig"
+config VIDEO_MAX9271
+ tristate
+
config VIDEO_RDACM20
tristate "IMI RDACM20 camera support"
depends on I2C
select V4L2_FWNODE
select VIDEO_V4L2_SUBDEV_API
select MEDIA_CONTROLLER
+ select VIDEO_MAX9271
help
This driver supports the IMI RDACM20 GMSL camera, used in
ADAS systems.
@@ -1259,6 +1263,7 @@ config VIDEO_RDACM21
select V4L2_FWNODE
select VIDEO_V4L2_SUBDEV_API
select MEDIA_CONTROLLER
+ select VIDEO_MAX9271
help
This driver supports the IMI RDACM21 GMSL camera, used in
ADAS systems.
diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
index 6bd22d63e1a7..c34a7de3158b 100644
--- a/drivers/media/i2c/Makefile
+++ b/drivers/media/i2c/Makefile
@@ -125,10 +125,9 @@ obj-$(CONFIG_VIDEO_IMX319) += imx319.o
obj-$(CONFIG_VIDEO_IMX334) += imx334.o
obj-$(CONFIG_VIDEO_IMX355) += imx355.o
obj-$(CONFIG_VIDEO_MAX9286) += max9286.o
-rdacm20-camera_module-objs := rdacm20.o max9271.o
-obj-$(CONFIG_VIDEO_RDACM20) += rdacm20-camera_module.o
-rdacm21-camera_module-objs := rdacm21.o max9271.o
-obj-$(CONFIG_VIDEO_RDACM21) += rdacm21-camera_module.o
+obj-$(CONFIG_VIDEO_MAX9271) += max9271.o
+obj-$(CONFIG_VIDEO_RDACM20) += rdacm20.o
+obj-$(CONFIG_VIDEO_RDACM21) += rdacm21.o
obj-$(CONFIG_VIDEO_ST_MIPID02) += st-mipid02.o
obj-$(CONFIG_SDR_MAX2175) += max2175.o
--
2.30.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] media: i2c: Kconfig: Make MAX9271 a module
2021-02-08 18:20 [PATCH] media: i2c: Kconfig: Make MAX9271 a module Jacopo Mondi
@ 2021-02-08 20:21 ` Sakari Ailus
2021-02-08 22:26 ` Laurent Pinchart
2021-02-08 20:42 ` Geert Uytterhoeven
2021-02-09 23:24 ` Nathan Chancellor
2 siblings, 1 reply; 6+ messages in thread
From: Sakari Ailus @ 2021-02-08 20:21 UTC (permalink / raw)
To: Jacopo Mondi
Cc: Mauro Carvalho Chehab, Laurent Pinchart, linux-media, linux-next,
linux-renesas-soc, Stephen Rothwell
Hi Jacopo,
On Mon, Feb 08, 2021 at 07:20:06PM +0100, Jacopo Mondi wrote:
> With the introduction of the RDACM21 camera module support in
> commit a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module")
> the symbols defined by the max9271 library were exported twice
> if multiple users of the library were compiled in at the same time.
>
> In example:
> WARNING: modpost: drivers/media/i2c/rdacm21-camera_module:
> 'max9271_set_serial_link' exported twice. Previous export was in
> drivers/media/i2c/rdacm20-camera_module.ko
>
> Fix this by making the rdacm21 file a module and have the driver
> using its functions select it.
>
> Fixes: a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Suggested-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
> drivers/media/i2c/Kconfig | 5 +++++
> drivers/media/i2c/Makefile | 7 +++----
> 2 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index 2d3dc0d82f9e..84645f751da3 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -1240,12 +1240,16 @@ config VIDEO_NOON010PC30
>
> source "drivers/media/i2c/m5mols/Kconfig"
>
> +config VIDEO_MAX9271
How about calling this VIDEO_MAX9271_HELPER instead? It's not a driver in
the proper sense of the word.
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> + tristate
> +
> config VIDEO_RDACM20
> tristate "IMI RDACM20 camera support"
> depends on I2C
> select V4L2_FWNODE
> select VIDEO_V4L2_SUBDEV_API
> select MEDIA_CONTROLLER
> + select VIDEO_MAX9271
> help
> This driver supports the IMI RDACM20 GMSL camera, used in
> ADAS systems.
> @@ -1259,6 +1263,7 @@ config VIDEO_RDACM21
> select V4L2_FWNODE
> select VIDEO_V4L2_SUBDEV_API
> select MEDIA_CONTROLLER
> + select VIDEO_MAX9271
> help
> This driver supports the IMI RDACM21 GMSL camera, used in
> ADAS systems.
> diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
> index 6bd22d63e1a7..c34a7de3158b 100644
> --- a/drivers/media/i2c/Makefile
> +++ b/drivers/media/i2c/Makefile
> @@ -125,10 +125,9 @@ obj-$(CONFIG_VIDEO_IMX319) += imx319.o
> obj-$(CONFIG_VIDEO_IMX334) += imx334.o
> obj-$(CONFIG_VIDEO_IMX355) += imx355.o
> obj-$(CONFIG_VIDEO_MAX9286) += max9286.o
> -rdacm20-camera_module-objs := rdacm20.o max9271.o
> -obj-$(CONFIG_VIDEO_RDACM20) += rdacm20-camera_module.o
> -rdacm21-camera_module-objs := rdacm21.o max9271.o
> -obj-$(CONFIG_VIDEO_RDACM21) += rdacm21-camera_module.o
> +obj-$(CONFIG_VIDEO_MAX9271) += max9271.o
> +obj-$(CONFIG_VIDEO_RDACM20) += rdacm20.o
> +obj-$(CONFIG_VIDEO_RDACM21) += rdacm21.o
> obj-$(CONFIG_VIDEO_ST_MIPID02) += st-mipid02.o
>
> obj-$(CONFIG_SDR_MAX2175) += max2175.o
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] media: i2c: Kconfig: Make MAX9271 a module
2021-02-08 18:20 [PATCH] media: i2c: Kconfig: Make MAX9271 a module Jacopo Mondi
2021-02-08 20:21 ` Sakari Ailus
@ 2021-02-08 20:42 ` Geert Uytterhoeven
2021-02-09 23:24 ` Nathan Chancellor
2 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2021-02-08 20:42 UTC (permalink / raw)
To: Jacopo Mondi
Cc: Mauro Carvalho Chehab, Laurent Pinchart, Sakari Ailus,
Linux Media Mailing List, Linux-Next, Linux-Renesas,
Stephen Rothwell
Hi Jacopo,
Thanks for your patch!
On Mon, Feb 8, 2021 at 7:22 PM Jacopo Mondi <jacopo+renesas@jmondi.org> wrote:
> With the introduction of the RDACM21 camera module support in
> commit a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module")
> the symbols defined by the max9271 library were exported twice
> if multiple users of the library were compiled in at the same time.
>
> In example:
> WARNING: modpost: drivers/media/i2c/rdacm21-camera_module:
> 'max9271_set_serial_link' exported twice. Previous export was in
> drivers/media/i2c/rdacm20-camera_module.ko
>
> Fix this by making the rdacm21 file a module and have the driver
max9271
> using its functions select it.
>
> Fixes: a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Suggested-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
With the above fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] media: i2c: Kconfig: Make MAX9271 a module
2021-02-08 20:21 ` Sakari Ailus
@ 2021-02-08 22:26 ` Laurent Pinchart
2021-02-09 8:48 ` Sakari Ailus
0 siblings, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2021-02-08 22:26 UTC (permalink / raw)
To: Sakari Ailus
Cc: Jacopo Mondi, Mauro Carvalho Chehab, linux-media, linux-next,
linux-renesas-soc, Stephen Rothwell
Hi Sakari and Jacopo,
On Mon, Feb 08, 2021 at 10:21:47PM +0200, Sakari Ailus wrote:
> On Mon, Feb 08, 2021 at 07:20:06PM +0100, Jacopo Mondi wrote:
> > With the introduction of the RDACM21 camera module support in
> > commit a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module")
> > the symbols defined by the max9271 library were exported twice
> > if multiple users of the library were compiled in at the same time.
> >
> > In example:
> > WARNING: modpost: drivers/media/i2c/rdacm21-camera_module:
> > 'max9271_set_serial_link' exported twice. Previous export was in
> > drivers/media/i2c/rdacm20-camera_module.ko
> >
> > Fix this by making the rdacm21 file a module and have the driver
> > using its functions select it.
> >
> > Fixes: a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module")
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Suggested-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> > ---
> > drivers/media/i2c/Kconfig | 5 +++++
> > drivers/media/i2c/Makefile | 7 +++----
> > 2 files changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> > index 2d3dc0d82f9e..84645f751da3 100644
> > --- a/drivers/media/i2c/Kconfig
> > +++ b/drivers/media/i2c/Kconfig
> > @@ -1240,12 +1240,16 @@ config VIDEO_NOON010PC30
> >
> > source "drivers/media/i2c/m5mols/Kconfig"
> >
> > +config VIDEO_MAX9271
>
> How about calling this VIDEO_MAX9271_HELPER instead? It's not a driver in
> the proper sense of the word.
Not all Kconfig symbols refer to drivers. Should we rename V4L2_FWNODE
to V4L2_FWNODE_HELPER ? :-)
Of course the MAX9271 name may lead someone to believe that the symbol
refers to a driver. If you think we should really make this explicit,
I'd have a preference for LIB instead of HELPER.
Either way,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
>
> > + tristate
> > +
> > config VIDEO_RDACM20
> > tristate "IMI RDACM20 camera support"
> > depends on I2C
> > select V4L2_FWNODE
> > select VIDEO_V4L2_SUBDEV_API
> > select MEDIA_CONTROLLER
> > + select VIDEO_MAX9271
> > help
> > This driver supports the IMI RDACM20 GMSL camera, used in
> > ADAS systems.
> > @@ -1259,6 +1263,7 @@ config VIDEO_RDACM21
> > select V4L2_FWNODE
> > select VIDEO_V4L2_SUBDEV_API
> > select MEDIA_CONTROLLER
> > + select VIDEO_MAX9271
> > help
> > This driver supports the IMI RDACM21 GMSL camera, used in
> > ADAS systems.
> > diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
> > index 6bd22d63e1a7..c34a7de3158b 100644
> > --- a/drivers/media/i2c/Makefile
> > +++ b/drivers/media/i2c/Makefile
> > @@ -125,10 +125,9 @@ obj-$(CONFIG_VIDEO_IMX319) += imx319.o
> > obj-$(CONFIG_VIDEO_IMX334) += imx334.o
> > obj-$(CONFIG_VIDEO_IMX355) += imx355.o
> > obj-$(CONFIG_VIDEO_MAX9286) += max9286.o
> > -rdacm20-camera_module-objs := rdacm20.o max9271.o
> > -obj-$(CONFIG_VIDEO_RDACM20) += rdacm20-camera_module.o
> > -rdacm21-camera_module-objs := rdacm21.o max9271.o
> > -obj-$(CONFIG_VIDEO_RDACM21) += rdacm21-camera_module.o
> > +obj-$(CONFIG_VIDEO_MAX9271) += max9271.o
> > +obj-$(CONFIG_VIDEO_RDACM20) += rdacm20.o
> > +obj-$(CONFIG_VIDEO_RDACM21) += rdacm21.o
> > obj-$(CONFIG_VIDEO_ST_MIPID02) += st-mipid02.o
> >
> > obj-$(CONFIG_SDR_MAX2175) += max2175.o
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] media: i2c: Kconfig: Make MAX9271 a module
2021-02-08 22:26 ` Laurent Pinchart
@ 2021-02-09 8:48 ` Sakari Ailus
0 siblings, 0 replies; 6+ messages in thread
From: Sakari Ailus @ 2021-02-09 8:48 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Jacopo Mondi, Mauro Carvalho Chehab, linux-media, linux-next,
linux-renesas-soc, Stephen Rothwell
On Tue, Feb 09, 2021 at 12:26:33AM +0200, Laurent Pinchart wrote:
> Hi Sakari and Jacopo,
>
> On Mon, Feb 08, 2021 at 10:21:47PM +0200, Sakari Ailus wrote:
> > On Mon, Feb 08, 2021 at 07:20:06PM +0100, Jacopo Mondi wrote:
> > > With the introduction of the RDACM21 camera module support in
> > > commit a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module")
> > > the symbols defined by the max9271 library were exported twice
> > > if multiple users of the library were compiled in at the same time.
> > >
> > > In example:
> > > WARNING: modpost: drivers/media/i2c/rdacm21-camera_module:
> > > 'max9271_set_serial_link' exported twice. Previous export was in
> > > drivers/media/i2c/rdacm20-camera_module.ko
> > >
> > > Fix this by making the rdacm21 file a module and have the driver
> > > using its functions select it.
> > >
> > > Fixes: a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module")
> > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > Suggested-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> > > ---
> > > drivers/media/i2c/Kconfig | 5 +++++
> > > drivers/media/i2c/Makefile | 7 +++----
> > > 2 files changed, 8 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> > > index 2d3dc0d82f9e..84645f751da3 100644
> > > --- a/drivers/media/i2c/Kconfig
> > > +++ b/drivers/media/i2c/Kconfig
> > > @@ -1240,12 +1240,16 @@ config VIDEO_NOON010PC30
> > >
> > > source "drivers/media/i2c/m5mols/Kconfig"
> > >
> > > +config VIDEO_MAX9271
> >
> > How about calling this VIDEO_MAX9271_HELPER instead? It's not a driver in
> > the proper sense of the word.
>
> Not all Kconfig symbols refer to drivers. Should we rename V4L2_FWNODE
> to V4L2_FWNODE_HELPER ? :-)
>
> Of course the MAX9271 name may lead someone to believe that the symbol
> refers to a driver. If you think we should really make this explicit,
> I'd have a preference for LIB instead of HELPER.
LIB sounds good to me, too.
>
> Either way,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> > Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> >
> > > + tristate
> > > +
> > > config VIDEO_RDACM20
> > > tristate "IMI RDACM20 camera support"
> > > depends on I2C
> > > select V4L2_FWNODE
> > > select VIDEO_V4L2_SUBDEV_API
> > > select MEDIA_CONTROLLER
> > > + select VIDEO_MAX9271
> > > help
> > > This driver supports the IMI RDACM20 GMSL camera, used in
> > > ADAS systems.
> > > @@ -1259,6 +1263,7 @@ config VIDEO_RDACM21
> > > select V4L2_FWNODE
> > > select VIDEO_V4L2_SUBDEV_API
> > > select MEDIA_CONTROLLER
> > > + select VIDEO_MAX9271
> > > help
> > > This driver supports the IMI RDACM21 GMSL camera, used in
> > > ADAS systems.
> > > diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
> > > index 6bd22d63e1a7..c34a7de3158b 100644
> > > --- a/drivers/media/i2c/Makefile
> > > +++ b/drivers/media/i2c/Makefile
> > > @@ -125,10 +125,9 @@ obj-$(CONFIG_VIDEO_IMX319) += imx319.o
> > > obj-$(CONFIG_VIDEO_IMX334) += imx334.o
> > > obj-$(CONFIG_VIDEO_IMX355) += imx355.o
> > > obj-$(CONFIG_VIDEO_MAX9286) += max9286.o
> > > -rdacm20-camera_module-objs := rdacm20.o max9271.o
> > > -obj-$(CONFIG_VIDEO_RDACM20) += rdacm20-camera_module.o
> > > -rdacm21-camera_module-objs := rdacm21.o max9271.o
> > > -obj-$(CONFIG_VIDEO_RDACM21) += rdacm21-camera_module.o
> > > +obj-$(CONFIG_VIDEO_MAX9271) += max9271.o
> > > +obj-$(CONFIG_VIDEO_RDACM20) += rdacm20.o
> > > +obj-$(CONFIG_VIDEO_RDACM21) += rdacm21.o
> > > obj-$(CONFIG_VIDEO_ST_MIPID02) += st-mipid02.o
> > >
> > > obj-$(CONFIG_SDR_MAX2175) += max2175.o
>
> --
> Regards,
>
> Laurent Pinchart
--
Sakari Ailus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] media: i2c: Kconfig: Make MAX9271 a module
2021-02-08 18:20 [PATCH] media: i2c: Kconfig: Make MAX9271 a module Jacopo Mondi
2021-02-08 20:21 ` Sakari Ailus
2021-02-08 20:42 ` Geert Uytterhoeven
@ 2021-02-09 23:24 ` Nathan Chancellor
2 siblings, 0 replies; 6+ messages in thread
From: Nathan Chancellor @ 2021-02-09 23:24 UTC (permalink / raw)
To: Jacopo Mondi
Cc: Mauro Carvalho Chehab, Laurent Pinchart, Sakari Ailus,
linux-media, linux-next, linux-renesas-soc, Stephen Rothwell
On Mon, Feb 08, 2021 at 07:20:06PM +0100, Jacopo Mondi wrote:
> With the introduction of the RDACM21 camera module support in
> commit a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module")
> the symbols defined by the max9271 library were exported twice
> if multiple users of the library were compiled in at the same time.
>
> In example:
> WARNING: modpost: drivers/media/i2c/rdacm21-camera_module:
> 'max9271_set_serial_link' exported twice. Previous export was in
> drivers/media/i2c/rdacm20-camera_module.ko
>
> Fix this by making the rdacm21 file a module and have the driver
> using its functions select it.
>
> Fixes: a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Suggested-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
That file needs a MODULE_LICENSE now otherwise there will be a fatal
build error:
ERROR: modpost: missing MODULE_LICENSE() in drivers/media/i2c/max9271.o
Cheers,
Nathan
> ---
> drivers/media/i2c/Kconfig | 5 +++++
> drivers/media/i2c/Makefile | 7 +++----
> 2 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index 2d3dc0d82f9e..84645f751da3 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -1240,12 +1240,16 @@ config VIDEO_NOON010PC30
>
> source "drivers/media/i2c/m5mols/Kconfig"
>
> +config VIDEO_MAX9271
> + tristate
> +
> config VIDEO_RDACM20
> tristate "IMI RDACM20 camera support"
> depends on I2C
> select V4L2_FWNODE
> select VIDEO_V4L2_SUBDEV_API
> select MEDIA_CONTROLLER
> + select VIDEO_MAX9271
> help
> This driver supports the IMI RDACM20 GMSL camera, used in
> ADAS systems.
> @@ -1259,6 +1263,7 @@ config VIDEO_RDACM21
> select V4L2_FWNODE
> select VIDEO_V4L2_SUBDEV_API
> select MEDIA_CONTROLLER
> + select VIDEO_MAX9271
> help
> This driver supports the IMI RDACM21 GMSL camera, used in
> ADAS systems.
> diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
> index 6bd22d63e1a7..c34a7de3158b 100644
> --- a/drivers/media/i2c/Makefile
> +++ b/drivers/media/i2c/Makefile
> @@ -125,10 +125,9 @@ obj-$(CONFIG_VIDEO_IMX319) += imx319.o
> obj-$(CONFIG_VIDEO_IMX334) += imx334.o
> obj-$(CONFIG_VIDEO_IMX355) += imx355.o
> obj-$(CONFIG_VIDEO_MAX9286) += max9286.o
> -rdacm20-camera_module-objs := rdacm20.o max9271.o
> -obj-$(CONFIG_VIDEO_RDACM20) += rdacm20-camera_module.o
> -rdacm21-camera_module-objs := rdacm21.o max9271.o
> -obj-$(CONFIG_VIDEO_RDACM21) += rdacm21-camera_module.o
> +obj-$(CONFIG_VIDEO_MAX9271) += max9271.o
> +obj-$(CONFIG_VIDEO_RDACM20) += rdacm20.o
> +obj-$(CONFIG_VIDEO_RDACM21) += rdacm21.o
> obj-$(CONFIG_VIDEO_ST_MIPID02) += st-mipid02.o
>
> obj-$(CONFIG_SDR_MAX2175) += max2175.o
> --
> 2.30.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-10 0:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-08 18:20 [PATCH] media: i2c: Kconfig: Make MAX9271 a module Jacopo Mondi
2021-02-08 20:21 ` Sakari Ailus
2021-02-08 22:26 ` Laurent Pinchart
2021-02-09 8:48 ` Sakari Ailus
2021-02-08 20:42 ` Geert Uytterhoeven
2021-02-09 23:24 ` Nathan Chancellor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).