linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: media: Renesas R-Car IMR bindings
@ 2019-03-25 18:14 Sergei Shtylyov
  2019-03-25 18:34 ` Geert Uytterhoeven
  0 siblings, 1 reply; 2+ messages in thread
From: Sergei Shtylyov @ 2019-03-25 18:14 UTC (permalink / raw)
  To: Mauro Carvalho Chehab, Rob Herring, linux-media, devicetree
  Cc: Mark Rutland, linux-renesas-soc, Rob Herring

The image renderer (IMR), or the distortion correction engine, is a
drawing processor with a simple instruction system capable of referencing
video capture data or data in an external memory as the 2D texture data
and performing texture mapping and drawing with respect to any shape that
is split into triangular objects.

Document  the device tree bindings for the image renderer light extended 4
(IMR-LX4) found in the R-Car gen3 SoCs...

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Rob Herring <robh@kernel.org>

---
This patch is against the 'master' branch of the 'media_tree.git' repo.

This patch has been split from the large IMR driver patch (which would need
much more work), it fixes checkpatch.pl's warnings on the SoC .dtsi files
which have been already merged (the bindings didn't change since v1 of the
driver patch).

Documentation/devicetree/bindings/media/rcar_imr.txt |   27 +++++++++++++++++++
 1 file changed, 27 insertions(+)

Index: media_tree/Documentation/devicetree/bindings/media/rcar_imr.txt
===================================================================
--- /dev/null
+++ media_tree/Documentation/devicetree/bindings/media/rcar_imr.txt
@@ -0,0 +1,27 @@
+Renesas R-Car Image Renderer (Distortion Correction Engine)
+-----------------------------------------------------------
+
+The image renderer, or the distortion correction engine, is a drawing processor
+with a simple instruction system capable of referencing video capture data or
+data in an external memory as 2D texture data and performing texture mapping
+and drawing with respect to any shape that is split into triangular objects.
+
+Required properties:
+
+- compatible: "renesas,<soctype>-imr-lx4", "renesas,imr-lx4" as a fallback for
+  the image renderer light extended 4 (IMR-LX4) found in the R-Car gen3 SoCs,
+  where the examples with <soctype> are:
+  - "renesas,r8a7795-imr-lx4" for R-Car H3,
+  - "renesas,r8a7796-imr-lx4" for R-Car M3-W.
+- reg: offset and length of the register block;
+- interrupts: single interrupt specifier;
+- clocks: single clock phandle/specifier pair.
+
+Example:
+
+	imr-lx4@fe860000 {
+		compatible = "renesas,r8a7795-imr-lx4", "renesas,imr-lx4";
+		reg = <0 0xfe860000 0 0x2000>;
+		interrupts = <GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&cpg CPG_MOD 823>;
+	};

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: media: Renesas R-Car IMR bindings
  2019-03-25 18:14 [PATCH] dt-bindings: media: Renesas R-Car IMR bindings Sergei Shtylyov
@ 2019-03-25 18:34 ` Geert Uytterhoeven
  0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2019-03-25 18:34 UTC (permalink / raw)
  To: Sergei Shtylyov
  Cc: Mauro Carvalho Chehab, Rob Herring, Linux Media Mailing List,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Mark Rutland, Linux-Renesas, Rob Herring, Laurent Pinchart,
	Kieran Bingham

CC Laurent, Kieran

On Mon, Mar 25, 2019 at 7:14 PM Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> The image renderer (IMR), or the distortion correction engine, is a
> drawing processor with a simple instruction system capable of referencing
> video capture data or data in an external memory as the 2D texture data
> and performing texture mapping and drawing with respect to any shape that
> is split into triangular objects.
>
> Document  the device tree bindings for the image renderer light extended 4
> (IMR-LX4) found in the R-Car gen3 SoCs...
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Acked-by: Rob Herring <robh@kernel.org>
>
> ---
> This patch is against the 'master' branch of the 'media_tree.git' repo.
>
> This patch has been split from the large IMR driver patch (which would need
> much more work), it fixes checkpatch.pl's warnings on the SoC .dtsi files
> which have been already merged (the bindings didn't change since v1 of the
> driver patch).
>
> Documentation/devicetree/bindings/media/rcar_imr.txt |   27 +++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> Index: media_tree/Documentation/devicetree/bindings/media/rcar_imr.txt
> ===================================================================
> --- /dev/null
> +++ media_tree/Documentation/devicetree/bindings/media/rcar_imr.txt
> @@ -0,0 +1,27 @@
> +Renesas R-Car Image Renderer (Distortion Correction Engine)
> +-----------------------------------------------------------
> +
> +The image renderer, or the distortion correction engine, is a drawing processor
> +with a simple instruction system capable of referencing video capture data or
> +data in an external memory as 2D texture data and performing texture mapping
> +and drawing with respect to any shape that is split into triangular objects.
> +
> +Required properties:
> +
> +- compatible: "renesas,<soctype>-imr-lx4", "renesas,imr-lx4" as a fallback for
> +  the image renderer light extended 4 (IMR-LX4) found in the R-Car gen3 SoCs,
> +  where the examples with <soctype> are:
> +  - "renesas,r8a7795-imr-lx4" for R-Car H3,
> +  - "renesas,r8a7796-imr-lx4" for R-Car M3-W.
> +- reg: offset and length of the register block;
> +- interrupts: single interrupt specifier;
> +- clocks: single clock phandle/specifier pair.

power-domains? (they're usually not in the always-on area on R-Car Gen3)
resets?

> +
> +Example:
> +
> +       imr-lx4@fe860000 {
> +               compatible = "renesas,r8a7795-imr-lx4", "renesas,imr-lx4";
> +               reg = <0 0xfe860000 0 0x2000>;
> +               interrupts = <GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>;
> +               clocks = <&cpg CPG_MOD 823>;
> +       };

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-03-25 18:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-25 18:14 [PATCH] dt-bindings: media: Renesas R-Car IMR bindings Sergei Shtylyov
2019-03-25 18:34 ` Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).