From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Antti Palosaari <crope@iki.fi>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] media: tm6000: Spelling s/diconencted/diconnected/
Date: Wed, 7 Aug 2019 14:12:14 +0200 [thread overview]
Message-ID: <CAMuHMdW8SAgT+KR9yEwhjaxijL07FuvqyGXmAOMv3xrvPB=HJw@mail.gmail.com> (raw)
In-Reply-To: <040b2c92-516b-58c6-940e-54fb58f7ddee@xs4all.nl>
Hi Hans,
On Wed, Aug 7, 2019 at 1:05 PM Hans Verkuil <hverkuil@xs4all.nl> wrote:
> On 8/7/19 12:53 PM, Geert Uytterhoeven wrote:
> > On Wed, Aug 7, 2019 at 11:33 AM Hans Verkuil <hverkuil@xs4all.nl> wrote:
> >> On 7/31/19 8:43 PM, Geert Uytterhoeven wrote:
> >>> On Wed, Jul 31, 2019 at 8:36 PM Antti Palosaari <crope@iki.fi> wrote:
> >>>> On 7/31/19 4:41 PM, Geert Uytterhoeven wrote:
> >>>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >>>>> ---
> >>>>> drivers/media/usb/tm6000/tm6000-cards.c | 2 +-
> >>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>>
> >>>>> diff --git a/drivers/media/usb/tm6000/tm6000-cards.c b/drivers/media/usb/tm6000/tm6000-cards.c
> >>>>> index 23df50aa0a4af6da..9a0ffe678524987c 100644
> >>>>> --- a/drivers/media/usb/tm6000/tm6000-cards.c
> >>>>> +++ b/drivers/media/usb/tm6000/tm6000-cards.c
> >>>>> @@ -1328,7 +1328,7 @@ static int tm6000_usb_probe(struct usb_interface *interface,
> >>>>>
> >>>>> /*
> >>>>> * tm6000_usb_disconnect()
> >>>>> - * called when the device gets diconencted
> >>>>> + * called when the device gets diconnected
> >>>>
> >>>> disconnected ?
> >>>
> >>> Thanks, will fix!
> >>
> >> Can you also add a commit message when you post v2? Currently that's
> >> empty and Linus doesn't like empty commit messages :-)
> >
> > Even if everything to be said is in the one-line summary?
>
> Yes. In fact, checkpatch warns if the commit description is empty.
Quoting the checkpatch.pl maintainer:
"checkpatch is a stupid script and doesn't forbid anything.
It's just a suggestion guide."
https://lore.kernel.org/lkml/20190801124037.11dcac71@gandalf.local.home/
> In this case, just say 'Fix typo.', that's sufficient.
If that makes you happy...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2019-08-07 12:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 13:41 [PATCH] media: tm6000: Spelling s/diconencted/diconnected/ Geert Uytterhoeven
2019-07-31 18:36 ` Antti Palosaari
2019-07-31 18:43 ` Geert Uytterhoeven
2019-08-07 9:33 ` Hans Verkuil
2019-08-07 10:53 ` Geert Uytterhoeven
2019-08-07 11:05 ` Hans Verkuil
2019-08-07 12:12 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdW8SAgT+KR9yEwhjaxijL07FuvqyGXmAOMv3xrvPB=HJw@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=crope@iki.fi \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).