* [PATCH] media: tm6000: Spelling s/diconencted/diconnected/
@ 2019-07-31 13:41 Geert Uytterhoeven
2019-07-31 18:36 ` Antti Palosaari
0 siblings, 1 reply; 7+ messages in thread
From: Geert Uytterhoeven @ 2019-07-31 13:41 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: linux-media, Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/media/usb/tm6000/tm6000-cards.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/tm6000/tm6000-cards.c b/drivers/media/usb/tm6000/tm6000-cards.c
index 23df50aa0a4af6da..9a0ffe678524987c 100644
--- a/drivers/media/usb/tm6000/tm6000-cards.c
+++ b/drivers/media/usb/tm6000/tm6000-cards.c
@@ -1328,7 +1328,7 @@ static int tm6000_usb_probe(struct usb_interface *interface,
/*
* tm6000_usb_disconnect()
- * called when the device gets diconencted
+ * called when the device gets diconnected
* video device will be unregistered on v4l2_close in case it is still open
*/
static void tm6000_usb_disconnect(struct usb_interface *interface)
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] media: tm6000: Spelling s/diconencted/diconnected/
2019-07-31 13:41 [PATCH] media: tm6000: Spelling s/diconencted/diconnected/ Geert Uytterhoeven
@ 2019-07-31 18:36 ` Antti Palosaari
2019-07-31 18:43 ` Geert Uytterhoeven
0 siblings, 1 reply; 7+ messages in thread
From: Antti Palosaari @ 2019-07-31 18:36 UTC (permalink / raw)
To: Geert Uytterhoeven, Mauro Carvalho Chehab; +Cc: linux-media
On 7/31/19 4:41 PM, Geert Uytterhoeven wrote:
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/media/usb/tm6000/tm6000-cards.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/tm6000/tm6000-cards.c b/drivers/media/usb/tm6000/tm6000-cards.c
> index 23df50aa0a4af6da..9a0ffe678524987c 100644
> --- a/drivers/media/usb/tm6000/tm6000-cards.c
> +++ b/drivers/media/usb/tm6000/tm6000-cards.c
> @@ -1328,7 +1328,7 @@ static int tm6000_usb_probe(struct usb_interface *interface,
>
> /*
> * tm6000_usb_disconnect()
> - * called when the device gets diconencted
> + * called when the device gets diconnected
disconnected ?
For the both patches.
> * video device will be unregistered on v4l2_close in case it is still open
> */
> static void tm6000_usb_disconnect(struct usb_interface *interface)
>
regards
Antti
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] media: tm6000: Spelling s/diconencted/diconnected/
2019-07-31 18:36 ` Antti Palosaari
@ 2019-07-31 18:43 ` Geert Uytterhoeven
2019-08-07 9:33 ` Hans Verkuil
0 siblings, 1 reply; 7+ messages in thread
From: Geert Uytterhoeven @ 2019-07-31 18:43 UTC (permalink / raw)
To: Antti Palosaari; +Cc: Mauro Carvalho Chehab, Linux Media Mailing List
Hi Antti,
On Wed, Jul 31, 2019 at 8:36 PM Antti Palosaari <crope@iki.fi> wrote:
> On 7/31/19 4:41 PM, Geert Uytterhoeven wrote:
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > drivers/media/usb/tm6000/tm6000-cards.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/usb/tm6000/tm6000-cards.c b/drivers/media/usb/tm6000/tm6000-cards.c
> > index 23df50aa0a4af6da..9a0ffe678524987c 100644
> > --- a/drivers/media/usb/tm6000/tm6000-cards.c
> > +++ b/drivers/media/usb/tm6000/tm6000-cards.c
> > @@ -1328,7 +1328,7 @@ static int tm6000_usb_probe(struct usb_interface *interface,
> >
> > /*
> > * tm6000_usb_disconnect()
> > - * called when the device gets diconencted
> > + * called when the device gets diconnected
>
> disconnected ?
Thanks, will fix!
> For the both patches.
How embarassing...
/me hides in a brown paper bag...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] media: tm6000: Spelling s/diconencted/diconnected/
2019-07-31 18:43 ` Geert Uytterhoeven
@ 2019-08-07 9:33 ` Hans Verkuil
2019-08-07 10:53 ` Geert Uytterhoeven
0 siblings, 1 reply; 7+ messages in thread
From: Hans Verkuil @ 2019-08-07 9:33 UTC (permalink / raw)
To: Geert Uytterhoeven, Antti Palosaari
Cc: Mauro Carvalho Chehab, Linux Media Mailing List
On 7/31/19 8:43 PM, Geert Uytterhoeven wrote:
> Hi Antti,
>
> On Wed, Jul 31, 2019 at 8:36 PM Antti Palosaari <crope@iki.fi> wrote:
>> On 7/31/19 4:41 PM, Geert Uytterhoeven wrote:
>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>> ---
>>> drivers/media/usb/tm6000/tm6000-cards.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/media/usb/tm6000/tm6000-cards.c b/drivers/media/usb/tm6000/tm6000-cards.c
>>> index 23df50aa0a4af6da..9a0ffe678524987c 100644
>>> --- a/drivers/media/usb/tm6000/tm6000-cards.c
>>> +++ b/drivers/media/usb/tm6000/tm6000-cards.c
>>> @@ -1328,7 +1328,7 @@ static int tm6000_usb_probe(struct usb_interface *interface,
>>>
>>> /*
>>> * tm6000_usb_disconnect()
>>> - * called when the device gets diconencted
>>> + * called when the device gets diconnected
>>
>> disconnected ?
>
> Thanks, will fix!
Can you also add a commit message when you post v2? Currently that's
empty and Linus doesn't like empty commit messages :-)
Regards,
Hans
>
>> For the both patches.
>
> How embarassing...
> /me hides in a brown paper bag...
>
> Gr{oetje,eeting}s,
>
> Geert
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] media: tm6000: Spelling s/diconencted/diconnected/
2019-08-07 9:33 ` Hans Verkuil
@ 2019-08-07 10:53 ` Geert Uytterhoeven
2019-08-07 11:05 ` Hans Verkuil
0 siblings, 1 reply; 7+ messages in thread
From: Geert Uytterhoeven @ 2019-08-07 10:53 UTC (permalink / raw)
To: Hans Verkuil
Cc: Antti Palosaari, Mauro Carvalho Chehab, Linux Media Mailing List
Hi Hans,
On Wed, Aug 7, 2019 at 11:33 AM Hans Verkuil <hverkuil@xs4all.nl> wrote:
> On 7/31/19 8:43 PM, Geert Uytterhoeven wrote:
> > On Wed, Jul 31, 2019 at 8:36 PM Antti Palosaari <crope@iki.fi> wrote:
> >> On 7/31/19 4:41 PM, Geert Uytterhoeven wrote:
> >>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >>> ---
> >>> drivers/media/usb/tm6000/tm6000-cards.c | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/media/usb/tm6000/tm6000-cards.c b/drivers/media/usb/tm6000/tm6000-cards.c
> >>> index 23df50aa0a4af6da..9a0ffe678524987c 100644
> >>> --- a/drivers/media/usb/tm6000/tm6000-cards.c
> >>> +++ b/drivers/media/usb/tm6000/tm6000-cards.c
> >>> @@ -1328,7 +1328,7 @@ static int tm6000_usb_probe(struct usb_interface *interface,
> >>>
> >>> /*
> >>> * tm6000_usb_disconnect()
> >>> - * called when the device gets diconencted
> >>> + * called when the device gets diconnected
> >>
> >> disconnected ?
> >
> > Thanks, will fix!
>
> Can you also add a commit message when you post v2? Currently that's
> empty and Linus doesn't like empty commit messages :-)
Even if everything to be said is in the one-line summary?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] media: tm6000: Spelling s/diconencted/diconnected/
2019-08-07 10:53 ` Geert Uytterhoeven
@ 2019-08-07 11:05 ` Hans Verkuil
2019-08-07 12:12 ` Geert Uytterhoeven
0 siblings, 1 reply; 7+ messages in thread
From: Hans Verkuil @ 2019-08-07 11:05 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Antti Palosaari, Mauro Carvalho Chehab, Linux Media Mailing List
On 8/7/19 12:53 PM, Geert Uytterhoeven wrote:
> Hi Hans,
>
> On Wed, Aug 7, 2019 at 11:33 AM Hans Verkuil <hverkuil@xs4all.nl> wrote:
>> On 7/31/19 8:43 PM, Geert Uytterhoeven wrote:
>>> On Wed, Jul 31, 2019 at 8:36 PM Antti Palosaari <crope@iki.fi> wrote:
>>>> On 7/31/19 4:41 PM, Geert Uytterhoeven wrote:
>>>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>>>> ---
>>>>> drivers/media/usb/tm6000/tm6000-cards.c | 2 +-
>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/drivers/media/usb/tm6000/tm6000-cards.c b/drivers/media/usb/tm6000/tm6000-cards.c
>>>>> index 23df50aa0a4af6da..9a0ffe678524987c 100644
>>>>> --- a/drivers/media/usb/tm6000/tm6000-cards.c
>>>>> +++ b/drivers/media/usb/tm6000/tm6000-cards.c
>>>>> @@ -1328,7 +1328,7 @@ static int tm6000_usb_probe(struct usb_interface *interface,
>>>>>
>>>>> /*
>>>>> * tm6000_usb_disconnect()
>>>>> - * called when the device gets diconencted
>>>>> + * called when the device gets diconnected
>>>>
>>>> disconnected ?
>>>
>>> Thanks, will fix!
>>
>> Can you also add a commit message when you post v2? Currently that's
>> empty and Linus doesn't like empty commit messages :-)
>
> Even if everything to be said is in the one-line summary?
Yes. In fact, checkpatch warns if the commit description is empty.
In this case, just say 'Fix typo.', that's sufficient.
Regards,
Hans
>
> Gr{oetje,eeting}s,
>
> Geert
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] media: tm6000: Spelling s/diconencted/diconnected/
2019-08-07 11:05 ` Hans Verkuil
@ 2019-08-07 12:12 ` Geert Uytterhoeven
0 siblings, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2019-08-07 12:12 UTC (permalink / raw)
To: Hans Verkuil
Cc: Antti Palosaari, Mauro Carvalho Chehab, Linux Media Mailing List
Hi Hans,
On Wed, Aug 7, 2019 at 1:05 PM Hans Verkuil <hverkuil@xs4all.nl> wrote:
> On 8/7/19 12:53 PM, Geert Uytterhoeven wrote:
> > On Wed, Aug 7, 2019 at 11:33 AM Hans Verkuil <hverkuil@xs4all.nl> wrote:
> >> On 7/31/19 8:43 PM, Geert Uytterhoeven wrote:
> >>> On Wed, Jul 31, 2019 at 8:36 PM Antti Palosaari <crope@iki.fi> wrote:
> >>>> On 7/31/19 4:41 PM, Geert Uytterhoeven wrote:
> >>>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >>>>> ---
> >>>>> drivers/media/usb/tm6000/tm6000-cards.c | 2 +-
> >>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>>
> >>>>> diff --git a/drivers/media/usb/tm6000/tm6000-cards.c b/drivers/media/usb/tm6000/tm6000-cards.c
> >>>>> index 23df50aa0a4af6da..9a0ffe678524987c 100644
> >>>>> --- a/drivers/media/usb/tm6000/tm6000-cards.c
> >>>>> +++ b/drivers/media/usb/tm6000/tm6000-cards.c
> >>>>> @@ -1328,7 +1328,7 @@ static int tm6000_usb_probe(struct usb_interface *interface,
> >>>>>
> >>>>> /*
> >>>>> * tm6000_usb_disconnect()
> >>>>> - * called when the device gets diconencted
> >>>>> + * called when the device gets diconnected
> >>>>
> >>>> disconnected ?
> >>>
> >>> Thanks, will fix!
> >>
> >> Can you also add a commit message when you post v2? Currently that's
> >> empty and Linus doesn't like empty commit messages :-)
> >
> > Even if everything to be said is in the one-line summary?
>
> Yes. In fact, checkpatch warns if the commit description is empty.
Quoting the checkpatch.pl maintainer:
"checkpatch is a stupid script and doesn't forbid anything.
It's just a suggestion guide."
https://lore.kernel.org/lkml/20190801124037.11dcac71@gandalf.local.home/
> In this case, just say 'Fix typo.', that's sufficient.
If that makes you happy...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-08-07 12:12 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-31 13:41 [PATCH] media: tm6000: Spelling s/diconencted/diconnected/ Geert Uytterhoeven
2019-07-31 18:36 ` Antti Palosaari
2019-07-31 18:43 ` Geert Uytterhoeven
2019-08-07 9:33 ` Hans Verkuil
2019-08-07 10:53 ` Geert Uytterhoeven
2019-08-07 11:05 ` Hans Verkuil
2019-08-07 12:12 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).