* drivers/media/platform/fsl-viu.c:36: warning: "out_be32" redefined
@ 2020-08-17 15:28 kernel test robot
2020-08-17 20:18 ` Geert Uytterhoeven
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2020-08-17 15:28 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: kbuild-all, linux-kernel, linux-media
[-- Attachment #1: Type: text/plain, Size: 8525 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5
commit: a19f228b8dd9a67e8de4ebd4eac8a4c94ec39d1a media: Kconfig: not all V4L2 platform drivers are for camera
date: 4 months ago
config: m68k-randconfig-r021-20200817 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout a19f228b8dd9a67e8de4ebd4eac8a4c94ec39d1a
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from arch/m68k/include/asm/io_mm.h:25,
from arch/m68k/include/asm/io.h:8,
from include/linux/io.h:13,
from include/linux/irq.h:20,
from include/asm-generic/hardirq.h:13,
from ./arch/m68k/include/generated/asm/hardirq.h:1,
from include/linux/hardirq.h:9,
from include/linux/interrupt.h:11,
from drivers/media/platform/fsl-viu.c:17:
arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsb':
arch/m68k/include/asm/raw_io.h:83:7: warning: variable '__w' set but not used [-Wunused-but-set-variable]
83 | ({u8 __w, __v = (b); u32 _addr = ((u32) (addr)); \
| ^~~
arch/m68k/include/asm/raw_io.h:430:3: note: in expansion of macro 'rom_out_8'
430 | rom_out_8(port, *buf++);
| ^~~~~~~~~
arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw':
arch/m68k/include/asm/raw_io.h:86:8: warning: variable '__w' set but not used [-Wunused-but-set-variable]
86 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); \
| ^~~
arch/m68k/include/asm/raw_io.h:448:3: note: in expansion of macro 'rom_out_be16'
448 | rom_out_be16(port, *buf++);
| ^~~~~~~~~~~~
arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw_swapw':
arch/m68k/include/asm/raw_io.h:90:8: warning: variable '__w' set but not used [-Wunused-but-set-variable]
90 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); \
| ^~~
arch/m68k/include/asm/raw_io.h:466:3: note: in expansion of macro 'rom_out_le16'
466 | rom_out_le16(port, *buf++);
| ^~~~~~~~~~~~
In file included from include/linux/kernel.h:11,
from include/linux/list.h:9,
from include/linux/module.h:12,
from drivers/media/platform/fsl-viu.c:12:
include/linux/scatterlist.h: In function 'sg_set_buf':
arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra]
169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~
include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~~~~~~~~~~
In file included from arch/m68k/include/asm/bug.h:32,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/preempt.h:5,
from ./arch/m68k/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:51,
from include/linux/seqlock.h:36,
from include/linux/time.h:6,
from include/linux/stat.h:19,
from include/linux/module.h:13,
from drivers/media/platform/fsl-viu.c:12:
include/linux/dma-mapping.h: In function 'dma_map_resource':
arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra]
169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/asm-generic/bug.h:139:27: note: in definition of macro 'WARN_ON_ONCE'
139 | int __ret_warn_once = !!(condition); \
| ^~~~~~~~~
arch/m68k/include/asm/page_mm.h:170:25: note: in expansion of macro 'virt_addr_valid'
170 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn))
| ^~~~~~~~~~~~~~~
include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid'
352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
| ^~~~~~~~~
drivers/media/platform/fsl-viu.c: At top level:
>> drivers/media/platform/fsl-viu.c:36: warning: "out_be32" redefined
36 | #define out_be32(v, a) iowrite32be(a, (void __iomem *)v)
|
In file included from arch/m68k/include/asm/io_mm.h:25,
from arch/m68k/include/asm/io.h:8,
from include/linux/io.h:13,
from include/linux/irq.h:20,
from include/asm-generic/hardirq.h:13,
from ./arch/m68k/include/generated/asm/hardirq.h:1,
from include/linux/hardirq.h:9,
from include/linux/interrupt.h:11,
from drivers/media/platform/fsl-viu.c:17:
arch/m68k/include/asm/raw_io.h:32: note: this is the location of the previous definition
32 | #define out_be32(addr,l) (void)((*(__force volatile u32 *) (addr)) = (l))
|
>> drivers/media/platform/fsl-viu.c:37: warning: "in_be32" redefined
37 | #define in_be32(a) ioread32be((void __iomem *)a)
|
In file included from arch/m68k/include/asm/io_mm.h:25,
from arch/m68k/include/asm/io.h:8,
from include/linux/io.h:13,
from include/linux/irq.h:20,
from include/asm-generic/hardirq.h:13,
from ./arch/m68k/include/generated/asm/hardirq.h:1,
from include/linux/hardirq.h:9,
from include/linux/interrupt.h:11,
from drivers/media/platform/fsl-viu.c:17:
arch/m68k/include/asm/raw_io.h:23: note: this is the location of the previous definition
23 | #define in_be32(addr) \
|
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a19f228b8dd9a67e8de4ebd4eac8a4c94ec39d1a
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout a19f228b8dd9a67e8de4ebd4eac8a4c94ec39d1a
vim +/out_be32 +36 drivers/media/platform/fsl-viu.c
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 33
29d750686331a1a drivers/media/platform/fsl-viu.c Mauro Carvalho Chehab 2018-04-05 34 /* Allow building this driver with COMPILE_TEST */
6898dd580a04534 drivers/media/platform/fsl-viu.c Randy Dunlap 2019-08-06 35 #if !defined(CONFIG_PPC) && !defined(CONFIG_MICROBLAZE)
29d750686331a1a drivers/media/platform/fsl-viu.c Mauro Carvalho Chehab 2018-04-05 @36 #define out_be32(v, a) iowrite32be(a, (void __iomem *)v)
29d750686331a1a drivers/media/platform/fsl-viu.c Mauro Carvalho Chehab 2018-04-05 @37 #define in_be32(a) ioread32be((void __iomem *)a)
29d750686331a1a drivers/media/platform/fsl-viu.c Mauro Carvalho Chehab 2018-04-05 38 #endif
29d750686331a1a drivers/media/platform/fsl-viu.c Mauro Carvalho Chehab 2018-04-05 39
:::::: The code at line 36 was first introduced by commit
:::::: 29d750686331a1a9ceeb97e81d3770f57bed5f72 media: fsl-viu: allow building it with COMPILE_TEST
:::::: TO: Mauro Carvalho Chehab <mchehab@s-opensource.com>
:::::: CC: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33768 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: drivers/media/platform/fsl-viu.c:36: warning: "out_be32" redefined
2020-08-17 15:28 drivers/media/platform/fsl-viu.c:36: warning: "out_be32" redefined kernel test robot
@ 2020-08-17 20:18 ` Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2020-08-17 20:18 UTC (permalink / raw)
To: kernel test robot
Cc: Mauro Carvalho Chehab, kbuild-all, Linux Kernel Mailing List,
Linux Media Mailing List
On Mon, Aug 17, 2020 at 9:32 PM kernel test robot <lkp@intel.com> wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5
> commit: a19f228b8dd9a67e8de4ebd4eac8a4c94ec39d1a media: Kconfig: not all V4L2 platform drivers are for camera
> date: 4 months ago
> config: m68k-randconfig-r021-20200817 (attached as .config)
> compiler: m68k-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout a19f228b8dd9a67e8de4ebd4eac8a4c94ec39d1a
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> drivers/media/platform/fsl-viu.c: At top level:
> >> drivers/media/platform/fsl-viu.c:36: warning: "out_be32" redefined
> 36 | #define out_be32(v, a) iowrite32be(a, (void __iomem *)v)
> |
> In file included from arch/m68k/include/asm/io_mm.h:25,
> from arch/m68k/include/asm/io.h:8,
> from include/linux/io.h:13,
> from include/linux/irq.h:20,
> from include/asm-generic/hardirq.h:13,
> from ./arch/m68k/include/generated/asm/hardirq.h:1,
> from include/linux/hardirq.h:9,
> from include/linux/interrupt.h:11,
> from drivers/media/platform/fsl-viu.c:17:
> arch/m68k/include/asm/raw_io.h:32: note: this is the location of the previous definition
> 32 | #define out_be32(addr,l) (void)((*(__force volatile u32 *) (addr)) = (l))
> |
> >> drivers/media/platform/fsl-viu.c:37: warning: "in_be32" redefined
> 37 | #define in_be32(a) ioread32be((void __iomem *)a)
> |
> In file included from arch/m68k/include/asm/io_mm.h:25,
> from arch/m68k/include/asm/io.h:8,
> from include/linux/io.h:13,
> from include/linux/irq.h:20,
> from include/asm-generic/hardirq.h:13,
> from ./arch/m68k/include/generated/asm/hardirq.h:1,
> from include/linux/hardirq.h:9,
> from include/linux/interrupt.h:11,
> from drivers/media/platform/fsl-viu.c:17:
> arch/m68k/include/asm/raw_io.h:23: note: this is the location of the previous definition
> 23 | #define in_be32(addr) \
> |
Fix available for +2 years
[PATCH] media: fsl-viu: Use proper check for presence of {out,in}_be32()
https://lore.kernel.org/linux-media/1528451328-21316-1-git-send-email-geert@linux-m68k.org/
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-17 20:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-17 15:28 drivers/media/platform/fsl-viu.c:36: warning: "out_be32" redefined kernel test robot
2020-08-17 20:18 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).