linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* include/linux/cec-funcs.h:1280: suspicious expression ?
@ 2016-08-01 10:24 David Binderman
  0 siblings, 0 replies; only message in thread
From: David Binderman @ 2016-08-01 10:24 UTC (permalink / raw)
  To: hans.verkuil, linux-media, Linux Kernel Mailing List, dcb314

Hello there,

include/linux/cec-funcs.h:1280:50: warning: logical ‘and’ applied to
non-boolean constant [-Wlogical-op]

Source code is

        msg->msg[4] = ui_cmd->channel_identifier.major && 0xff;

Maybe better code

        msg->msg[4] = ui_cmd->channel_identifier.major & 0xff;

Regards

David Binderman

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-08-01 10:24 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-01 10:24 include/linux/cec-funcs.h:1280: suspicious expression ? David Binderman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).