* [PATCH] mxl111sf: missing return values validation
@ 2015-10-15 20:22 Insu Yun
2015-10-15 21:27 ` Michael Ira Krufky
0 siblings, 1 reply; 2+ messages in thread
From: Insu Yun @ 2015-10-15 20:22 UTC (permalink / raw)
To: mkrufky, mchehab, linux-media, linux-kernel
Cc: taesoo, yeongjin.jang, insu, Insu Yun
Return values of mxl111sf_enable_usb_output and mxl1x1sf_top_master_ctrl
are not validated.
Signed-off-by: Insu Yun <wuninsu@gmail.com>
---
drivers/media/usb/dvb-usb-v2/mxl111sf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/usb/dvb-usb-v2/mxl111sf.c b/drivers/media/usb/dvb-usb-v2/mxl111sf.c
index bec12b0..b71b2e6 100644
--- a/drivers/media/usb/dvb-usb-v2/mxl111sf.c
+++ b/drivers/media/usb/dvb-usb-v2/mxl111sf.c
@@ -288,9 +288,9 @@ static int mxl111sf_adap_fe_init(struct dvb_frontend *fe)
err = mxl1x1sf_set_device_mode(state, adap_state->device_mode);
mxl_fail(err);
- mxl111sf_enable_usb_output(state);
+ err = mxl111sf_enable_usb_output(state);
mxl_fail(err);
- mxl1x1sf_top_master_ctrl(state, 1);
+ err = mxl1x1sf_top_master_ctrl(state, 1);
mxl_fail(err);
if ((MXL111SF_GPIO_MOD_DVBT != adap_state->gpio_mode) &&
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mxl111sf: missing return values validation
2015-10-15 20:22 [PATCH] mxl111sf: missing return values validation Insu Yun
@ 2015-10-15 21:27 ` Michael Ira Krufky
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ira Krufky @ 2015-10-15 21:27 UTC (permalink / raw)
To: Insu Yun
Cc: Mauro Carvalho Chehab, linux-media, LKML, taesoo, yeongjin.jang, insu
On Thu, Oct 15, 2015 at 4:22 PM, Insu Yun <wuninsu@gmail.com> wrote:
> Return values of mxl111sf_enable_usb_output and mxl1x1sf_top_master_ctrl
> are not validated.
>
> Signed-off-by: Insu Yun <wuninsu@gmail.com>
Eeek! You're right! ...and I'm the one who wrote the offending code.
My bad O:-)
Thank you for this patch. Mauro, please apply it.
Reviewed-by: Michael Ira Krufky <mkrufky@linuxtv.org>
> ---
> drivers/media/usb/dvb-usb-v2/mxl111sf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/dvb-usb-v2/mxl111sf.c b/drivers/media/usb/dvb-usb-v2/mxl111sf.c
> index bec12b0..b71b2e6 100644
> --- a/drivers/media/usb/dvb-usb-v2/mxl111sf.c
> +++ b/drivers/media/usb/dvb-usb-v2/mxl111sf.c
> @@ -288,9 +288,9 @@ static int mxl111sf_adap_fe_init(struct dvb_frontend *fe)
> err = mxl1x1sf_set_device_mode(state, adap_state->device_mode);
>
> mxl_fail(err);
> - mxl111sf_enable_usb_output(state);
> + err = mxl111sf_enable_usb_output(state);
> mxl_fail(err);
> - mxl1x1sf_top_master_ctrl(state, 1);
> + err = mxl1x1sf_top_master_ctrl(state, 1);
> mxl_fail(err);
>
> if ((MXL111SF_GPIO_MOD_DVBT != adap_state->gpio_mode) &&
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-15 21:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-15 20:22 [PATCH] mxl111sf: missing return values validation Insu Yun
2015-10-15 21:27 ` Michael Ira Krufky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).