* [PATCH] media: ov13b10: Fix some error checking in probe
@ 2023-07-19 10:16 Dan Carpenter
2023-07-20 4:33 ` Cao, Bingbu
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2023-07-19 10:16 UTC (permalink / raw)
To: Bingbu Cao
Cc: Arec Kao, Sakari Ailus, Mauro Carvalho Chehab, Hans de Goede,
Hao Yao, linux-media, kernel-janitors
The "ret = " assignment was missing, so ov13b10_power_on() is not
checked for errors. Add the assignment.
Fixes: 6e28afd15228 ("media: ov13b10: add PM control support based on power resources")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
Adding error handling always risky breaking the driver and I have not
tested this patch.
drivers/media/i2c/ov13b10.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov13b10.c b/drivers/media/i2c/ov13b10.c
index dbc642c5995b..8ebdb32dd3db 100644
--- a/drivers/media/i2c/ov13b10.c
+++ b/drivers/media/i2c/ov13b10.c
@@ -1501,7 +1501,7 @@ static int ov13b10_probe(struct i2c_client *client)
full_power = acpi_dev_state_d0(&client->dev);
if (full_power) {
- ov13b10_power_on(&client->dev);
+ ret = ov13b10_power_on(&client->dev);
if (ret) {
dev_err(&client->dev, "failed to power on\n");
return ret;
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] media: ov13b10: Fix some error checking in probe
2023-07-19 10:16 [PATCH] media: ov13b10: Fix some error checking in probe Dan Carpenter
@ 2023-07-20 4:33 ` Cao, Bingbu
0 siblings, 0 replies; 2+ messages in thread
From: Cao, Bingbu @ 2023-07-20 4:33 UTC (permalink / raw)
To: Dan Carpenter
Cc: Kao, Arec, Sakari Ailus, Mauro Carvalho Chehab, Hans de Goede,
Yao, Hao, linux-media, kernel-janitors
Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>
Thanks!
------------------------------------------------------------------------
BRs,
Bingbu Cao
>-----Original Message-----
>From: Dan Carpenter <dan.carpenter@linaro.org>
>Sent: Wednesday, July 19, 2023 6:16 PM
>To: Cao, Bingbu <bingbu.cao@intel.com>
>Cc: Kao, Arec <arec.kao@intel.com>; Sakari Ailus
><sakari.ailus@linux.intel.com>; Mauro Carvalho Chehab <mchehab@kernel.org>;
>Hans de Goede <hdegoede@redhat.com>; Yao, Hao <hao.yao@intel.com>; linux-
>media@vger.kernel.org; kernel-janitors@vger.kernel.org
>Subject: [PATCH] media: ov13b10: Fix some error checking in probe
>
>The "ret = " assignment was missing, so ov13b10_power_on() is not checked
>for errors. Add the assignment.
>
>Fixes: 6e28afd15228 ("media: ov13b10: add PM control support based on power
>resources")
>Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
>---
>Adding error handling always risky breaking the driver and I have not
>tested this patch.
>
> drivers/media/i2c/ov13b10.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/media/i2c/ov13b10.c b/drivers/media/i2c/ov13b10.c
>index dbc642c5995b..8ebdb32dd3db 100644
>--- a/drivers/media/i2c/ov13b10.c
>+++ b/drivers/media/i2c/ov13b10.c
>@@ -1501,7 +1501,7 @@ static int ov13b10_probe(struct i2c_client *client)
>
> full_power = acpi_dev_state_d0(&client->dev);
> if (full_power) {
>- ov13b10_power_on(&client->dev);
>+ ret = ov13b10_power_on(&client->dev);
> if (ret) {
> dev_err(&client->dev, "failed to power on\n");
> return ret;
>--
>2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-20 4:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-19 10:16 [PATCH] media: ov13b10: Fix some error checking in probe Dan Carpenter
2023-07-20 4:33 ` Cao, Bingbu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).