* [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver
@ 2013-05-23 22:11 Sergei Shtylyov
2013-06-02 18:56 ` Sergei Shtylyov
` (2 more replies)
0 siblings, 3 replies; 26+ messages in thread
From: Sergei Shtylyov @ 2013-05-23 22:11 UTC (permalink / raw)
To: g.liakhovetski, mchehab, linux-media
Cc: magnus.damm, linux-sh, phil.edworthy, matsu, vladimir.barinov
From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Add Renesas R-Car VIN (Video In) V4L2 driver.
Based on the patch by Phil Edworthy <phil.edworthy@renesas.com>.
Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
[Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed 'enum chip_id'
values, reordered rcar_vin_id_table[] entries, removed senseless parens from
to_buf_list() macro, used ALIGN() macro in rcar_vin_setup(), added {} to the
*if* statement and used 'bool' values instead of 0/1 where necessary, removed
unused macros, done some reformatting and clarified some comments.]
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
This patch is against the 'media_tree.git' repo.
It requires two following patches from Guennadi Liakhovetski:
https://patchwork.linuxtv.org/patch/18209/
https://patchwork.linuxtv.org/patch/18210/
Changes since version 5:
- handled subdevice's inability to support cropping;
- set the field format depending on a video standard.
Changes since version 4:
- added "select SOC_CAMERA_SCALE_CROP" to Kconfig entry;
- added #include "soc_scale_crop.h", made use of the functions declared there
instead of the analogous functions originally copied from the SH-Mobile CEU
driver now that they have been placed in a module of their own, removing now
unused private functions.
Changes since version 3:
- removed the driver's dependency on R-Car M1A/H1 SoCs from Kconfig;
- made the driver aware of the differences between R-Car E1/M1/H1 SoCs by having
different platform device IDs for different SoCs, introcduced 'enum chips_id'
to be used as the 'driver_data' field of 'struct platform_device_id' and then
copied to the 'chip' field of 'struct rcar_vin_priv';
- sorted #include's alphabetically, added a number of #includes <media/v4l2-*>;
- removed the 'data_through' field of the 'struct rcar_vin_priv' and the pass-
through logic from set_fmt() method;
- simplified is_continuous_transfer(), used it where applicable;
- removed senseless parens from to_buf_list() macro;
- removed the 'code' field from the 'struct rcar_vin_cam';
- largely rewrote the queue_setup() method;
- removed 'input_is_yuv' variable from rcar_vin_setup(), made 'progressive' and
'output_is_yuv' variables 'bool', and made setting VnDMR.EXRGB bit only happen
on R-Car E1/H1 there;
- made use of ALIGN() macro in rcar_vin_setup() and rcar_vin_set_rect();
- fixed missing {} on one branch of the *if* statement in several places, added
{} to the *if* statement where necessary;
- stopped saving/restoring flags when grabbing/dropping a spinlock in the
buf_queue() and buf_cleanup() methods;
- made 'dsize' variable calculation depend on R-Car E1 in rcar_vin_set_rect()
- fix the continuous capturing to stop when there is no buffer to be set into
the VnMBm registers in rcar_vin_irq();
- replaced BUG_ON() with WARN_ON() and *return* in the remove() method, also
replaced pm_runtime_put_sync() with pm_runtime_put() there;
- removed size_dst() and calc_scale() as the calls to calc_scale() were also
removed from the set_fmt() method;
- removed the VnMC register value check from capture_restore();
- removed 'cfg' variable initializers from set_bus_param() method and
rcar_vin_try_bus_param();
- added bus width check to rcar_vin_try_bus_param();
- removed V4L2_PIX_FMT_YUYV format from rcar_vin_formats[], initialize 'layout'
field of every element in this table;
- changed dev_err() call and *return* -EINVAL to dev_warn() and *return* 0 in
the get_formats() method,
- added rcar_vin_packing_supported() and started handling pass-through mode in
the get_formats() method;
- constified the parameters of is_smaller() and is_inside();
- redid the scaling logic so that it can't scale RGB32 data on R-Car E1 in the
set_fmt() method, also stopped assigning to 'cam->code' there;
- started selecting the current format if soc_camera_xlate_by_fourcc() call
failed in the try_fmt() method, also started letting 'soc-camera' calculate
bytes-per-line and image size there;
- removed pm_runtime_resume() call from the driver's probe() method
- added setting of the 'timestamp_type' field to the init_videobuf2() method.
Changes since version 2:
- replaced Cyrillic characters in comments with the proper Latinic ones.
Changes since the original posting:
- added IRQF_SHARED flag in devm_request_irq() call (since on R8A7778 VIN0/1
share the same IRQ) and removed deprecated IRQF_DISABLED flag.
drivers/media/platform/soc_camera/Kconfig | 8
drivers/media/platform/soc_camera/Makefile | 1
drivers/media/platform/soc_camera/rcar_vin.c | 1476 +++++++++++++++++++++++++++
include/linux/platform_data/camera-rcar.h | 25
4 files changed, 1510 insertions(+)
Index: media_tree/drivers/media/platform/soc_camera/Kconfig
===================================================================
--- media_tree.orig/drivers/media/platform/soc_camera/Kconfig
+++ media_tree/drivers/media/platform/soc_camera/Kconfig
@@ -48,6 +48,14 @@ config VIDEO_PXA27x
---help---
This is a v4l2 driver for the PXA27x Quick Capture Interface
+config VIDEO_RCAR_VIN
+ tristate "R-Car Video Input (VIN) support"
+ depends on VIDEO_DEV && SOC_CAMERA
+ select VIDEOBUF2_DMA_CONTIG
+ select SOC_CAMERA_SCALE_CROP
+ ---help---
+ This is a v4l2 driver for the R-Car VIN Interface
+
config VIDEO_SH_MOBILE_CSI2
tristate "SuperH Mobile MIPI CSI-2 Interface driver"
depends on VIDEO_DEV && SOC_CAMERA && HAVE_CLK
Index: media_tree/drivers/media/platform/soc_camera/Makefile
===================================================================
--- media_tree.orig/drivers/media/platform/soc_camera/Makefile
+++ media_tree/drivers/media/platform/soc_camera/Makefile
@@ -14,5 +14,6 @@ obj-$(CONFIG_VIDEO_OMAP1) += omap1_came
obj-$(CONFIG_VIDEO_PXA27x) += pxa_camera.o
obj-$(CONFIG_VIDEO_SH_MOBILE_CEU) += sh_mobile_ceu_camera.o
obj-$(CONFIG_VIDEO_SH_MOBILE_CSI2) += sh_mobile_csi2.o
+obj-$(CONFIG_VIDEO_RCAR_VIN) += rcar_vin.o
ccflags-y += -I$(srctree)/drivers/media/i2c/soc_camera
Index: media_tree/drivers/media/platform/soc_camera/rcar_vin.c
===================================================================
--- /dev/null
+++ media_tree/drivers/media/platform/soc_camera/rcar_vin.c
@@ -0,0 +1,1476 @@
+/*
+ * SoC-camera host driver for Renesas R-Car VIN unit
+ *
+ * Copyright (C) 2011-2013 Renesas Solutions Corp.
+ * Copyright (C) 2013 Cogent Embedded, Inc., <source@cogentembedded.com>
+ *
+ * Based on V4L2 Driver for SuperH Mobile CEU interface "sh_mobile_ceu_camera.c"
+ *
+ * Copyright (C) 2008 Magnus Damm
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation; either version 2 of the License, or (at your
+ * option) any later version.
+ */
+
+#include <linux/delay.h>
+#include <linux/interrupt.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/pm_runtime.h>
+#include <linux/platform_data/camera-rcar.h>
+#include <linux/slab.h>
+#include <linux/videodev2.h>
+
+#include <media/soc_camera.h>
+#include <media/soc_mediabus.h>
+#include <media/v4l2-common.h>
+#include <media/v4l2-dev.h>
+#include <media/v4l2-device.h>
+#include <media/v4l2-mediabus.h>
+#include <media/v4l2-subdev.h>
+#include <media/videobuf2-dma-contig.h>
+
+#include "soc_scale_crop.h"
+
+#define DRV_NAME "rcar_vin"
+
+/* Register offsets for R-Car VIN */
+#define VNMC_REG 0x00 /* Video n Main Control Register */
+#define VNMS_REG 0x04 /* Video n Module Status Register */
+#define VNFC_REG 0x08 /* Video n Frame Capture Register */
+#define VNSLPRC_REG 0x0C /* Video n Start Line Pre-Clip Register */
+#define VNELPRC_REG 0x10 /* Video n End Line Pre-Clip Register */
+#define VNSPPRC_REG 0x14 /* Video n Start Pixel Pre-Clip Register */
+#define VNEPPRC_REG 0x18 /* Video n End Pixel Pre-Clip Register */
+#define VNSLPOC_REG 0x1C /* Video n Start Line Post-Clip Register */
+#define VNELPOC_REG 0x20 /* Video n End Line Post-Clip Register */
+#define VNSPPOC_REG 0x24 /* Video n Start Pixel Post-Clip Register */
+#define VNEPPOC_REG 0x28 /* Video n End Pixel Post-Clip Register */
+#define VNIS_REG 0x2C /* Video n Image Stride Register */
+#define VNMB_REG(m) (0x30 + ((m) << 2)) /* Video n Memory Base m Register */
+#define VNIE_REG 0x40 /* Video n Interrupt Enable Register */
+#define VNINTS_REG 0x44 /* Video n Interrupt Status Register */
+#define VNSI_REG 0x48 /* Video n Scanline Interrupt Register */
+#define VNMTC_REG 0x4C /* Video n Memory Transfer Control Register */
+#define VNYS_REG 0x50 /* Video n Y Scale Register */
+#define VNXS_REG 0x54 /* Video n X Scale Register */
+#define VNDMR_REG 0x58 /* Video n Data Mode Register */
+#define VNDMR2_REG 0x5C /* Video n Data Mode Register 2 */
+#define VNUVAOF_REG 0x60 /* Video n UV Address Offset Register */
+
+/* Register bit fields for R-Car VIN */
+/* Video n Main Control Register bits */
+#define VNMC_FOC (1 << 21)
+#define VNMC_YCAL (1 << 19)
+#define VNMC_INF_YUV8_BT656 (0 << 16)
+#define VNMC_INF_YUV8_BT601 (1 << 16)
+#define VNMC_INF_YUV16 (5 << 16)
+#define VNMC_VUP (1 << 10)
+#define VNMC_IM_ODD (0 << 3)
+#define VNMC_IM_ODD_EVEN (1 << 3)
+#define VNMC_IM_EVEN (2 << 3)
+#define VNMC_IM_FULL (3 << 3)
+#define VNMC_BPS (1 << 1)
+#define VNMC_ME (1 << 0)
+
+/* Video n Module Status Register bits */
+#define VNMS_FBS_MASK (3 << 3)
+#define VNMS_FBS_SHIFT 3
+#define VNMS_AV (1 << 1)
+#define VNMS_CA (1 << 0)
+
+/* Video n Frame Capture Register bits */
+#define VNFC_C_FRAME (1 << 1)
+#define VNFC_S_FRAME (1 << 0)
+
+/* Video n Interrupt Enable Register bits */
+#define VNIE_FIE (1 << 4)
+#define VNIE_EFE (1 << 1)
+
+/* Video n Data Mode Register bits */
+#define VNDMR_EXRGB (1 << 8)
+#define VNDMR_BPSM (1 << 4)
+#define VNDMR_DTMD_YCSEP (1 << 1)
+#define VNDMR_DTMD_ARGB1555 (1 << 0)
+
+/* Video n Data Mode Register 2 bits */
+#define VNDMR2_VPS (1 << 30)
+#define VNDMR2_HPS (1 << 29)
+#define VNDMR2_FTEV (1 << 17)
+
+#define VIN_MAX_WIDTH 2048
+#define VIN_MAX_HEIGHT 2048
+
+enum chip_id {
+ RCAR_H1,
+ RCAR_M1,
+ RCAR_E1,
+};
+
+enum rcar_vin_state {
+ STOPPED = 0,
+ RUNNING,
+ STOPPING,
+};
+
+struct rcar_vin_priv {
+ void __iomem *base;
+ spinlock_t lock;
+ int sequence;
+ /* State of the VIN module in capturing mode */
+ enum rcar_vin_state state;
+ struct rcar_vin_platform_data *pdata;
+ struct soc_camera_host ici;
+ struct soc_camera_device *icd;
+ struct list_head capture;
+#define MAX_BUFFER_NUM 3
+ struct vb2_buffer *queue_buf[MAX_BUFFER_NUM];
+ struct vb2_alloc_ctx *alloc_ctx;
+ enum v4l2_field field;
+ unsigned int vb_count;
+ unsigned int nr_hw_slots;
+ bool request_to_stop;
+ struct completion capture_stop;
+ enum chip_id chip;
+};
+
+#define is_continuous_transfer(priv) (priv->vb_count > MAX_BUFFER_NUM)
+
+struct rcar_vin_buffer {
+ struct vb2_buffer vb;
+ struct list_head list;
+};
+
+#define to_buf_list(vb2_buffer) (&container_of(vb2_buffer, \
+ struct rcar_vin_buffer, \
+ vb)->list)
+
+struct rcar_vin_cam {
+ /* VIN offsets within the camera output, before the VIN scaler */
+ unsigned int vin_left;
+ unsigned int vin_top;
+ /* Client output, as seen by the VIN */
+ unsigned int width;
+ unsigned int height;
+ /*
+ * User window from S_CROP / G_CROP, produced by client cropping and
+ * scaling, VIN scaling and VIN cropping, mapped back onto the client
+ * input window
+ */
+ struct v4l2_rect subrect;
+ /* Camera cropping rectangle */
+ struct v4l2_rect rect;
+ const struct soc_mbus_pixelfmt *extra_fmt;
+};
+
+/*
+ * .queue_setup() is called to check whether the driver can accept the requested
+ * number of buffers and to fill in plane sizes for the current frame format if
+ * required
+ */
+static int rcar_vin_videobuf_setup(struct vb2_queue *vq,
+ const struct v4l2_format *fmt,
+ unsigned int *count,
+ unsigned int *num_planes,
+ unsigned int sizes[], void *alloc_ctxs[])
+{
+ struct soc_camera_device *icd = soc_camera_from_vb2q(vq);
+ struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
+ struct rcar_vin_priv *priv = ici->priv;
+
+ if (fmt) {
+ const struct soc_camera_format_xlate *xlate;
+ unsigned int bytes_per_line;
+ int ret;
+
+ xlate = soc_camera_xlate_by_fourcc(icd,
+ fmt->fmt.pix.pixelformat);
+ if (!xlate)
+ return -EINVAL;
+ ret = soc_mbus_bytes_per_line(fmt->fmt.pix.width,
+ xlate->host_fmt);
+ if (ret < 0)
+ return ret;
+
+ bytes_per_line = max_t(u32, fmt->fmt.pix.bytesperline, ret);
+
+ ret = soc_mbus_image_size(xlate->host_fmt, bytes_per_line,
+ fmt->fmt.pix.height);
+ if (ret < 0)
+ return ret;
+
+ sizes[0] = max_t(u32, fmt->fmt.pix.sizeimage, ret);
+ } else {
+ /* Called from VIDIOC_REQBUFS or in compatibility mode */
+ sizes[0] = icd->sizeimage;
+ }
+
+ alloc_ctxs[0] = priv->alloc_ctx;
+
+ if (!vq->num_buffers)
+ priv->sequence = 0;
+
+ if (!*count)
+ *count = 2;
+ priv->vb_count = *count;
+
+ *num_planes = 1;
+
+ /* Number of hardware slots */
+ if (is_continuous_transfer(priv))
+ priv->nr_hw_slots = MAX_BUFFER_NUM;
+ else
+ priv->nr_hw_slots = 1;
+
+ dev_dbg(icd->parent, "count=%d, size=%u\n", *count, sizes[0]);
+
+ return 0;
+}
+
+static void rcar_vin_setup(struct rcar_vin_priv *priv)
+{
+ struct soc_camera_device *icd = priv->icd;
+ struct rcar_vin_cam *cam = icd->host_priv;
+ u32 vnmc, dmr, interrupts;
+ bool progressive = false, output_is_yuv = false;
+
+ switch (priv->field) {
+ case V4L2_FIELD_TOP:
+ vnmc = VNMC_IM_ODD;
+ break;
+ case V4L2_FIELD_BOTTOM:
+ vnmc = VNMC_IM_EVEN;
+ break;
+ case V4L2_FIELD_INTERLACED:
+ case V4L2_FIELD_INTERLACED_TB:
+ vnmc = VNMC_IM_FULL;
+ break;
+ case V4L2_FIELD_INTERLACED_BT:
+ vnmc = VNMC_IM_FULL | VNMC_FOC;
+ break;
+ case V4L2_FIELD_NONE:
+ if (is_continuous_transfer(priv)) {
+ vnmc = VNMC_IM_ODD_EVEN;
+ progressive = true;
+ } else {
+ vnmc = VNMC_IM_ODD;
+ }
+ break;
+ default:
+ vnmc = VNMC_IM_ODD;
+ break;
+ }
+
+ /* input interface */
+ switch (icd->current_fmt->code) {
+ case V4L2_MBUS_FMT_YUYV8_1X16:
+ /* BT.601/BT.1358 16bit YCbCr422 */
+ vnmc |= VNMC_INF_YUV16;
+ break;
+ case V4L2_MBUS_FMT_YUYV8_2X8:
+ /* BT.656 8bit YCbCr422 or BT.601 8bit YCbCr422 */
+ vnmc |= priv->pdata->flags & RCAR_VIN_BT656 ?
+ VNMC_INF_YUV8_BT656 : VNMC_INF_YUV8_BT601;
+ default:
+ break;
+ }
+
+ /* output format */
+ switch (icd->current_fmt->host_fmt->fourcc) {
+ case V4L2_PIX_FMT_NV16:
+ iowrite32(ALIGN(cam->width * cam->height, 0x80),
+ priv->base + VNUVAOF_REG);
+ dmr = VNDMR_DTMD_YCSEP;
+ output_is_yuv = true;
+ break;
+ case V4L2_PIX_FMT_YUYV:
+ dmr = VNDMR_BPSM;
+ output_is_yuv = true;
+ break;
+ case V4L2_PIX_FMT_UYVY:
+ dmr = 0;
+ output_is_yuv = true;
+ break;
+ case V4L2_PIX_FMT_RGB555X:
+ dmr = VNDMR_DTMD_ARGB1555;
+ break;
+ case V4L2_PIX_FMT_RGB565:
+ dmr = 0;
+ break;
+ case V4L2_PIX_FMT_RGB32:
+ if (priv->chip == RCAR_H1 || priv->chip == RCAR_E1) {
+ dmr = VNDMR_EXRGB;
+ break;
+ }
+ default:
+ dev_warn(icd->parent, "Invalid fourcc format (0x%x)\n",
+ icd->current_fmt->host_fmt->fourcc);
+ dmr = ioread32(priv->base + VNDMR_REG);
+ vnmc = ioread32(priv->base + VNMC_REG);
+ break;
+ }
+
+ /* Always update on field change */
+ vnmc |= VNMC_VUP;
+
+ /* If input and output use the same colorspace, use bypass mode */
+ if (output_is_yuv)
+ vnmc |= VNMC_BPS;
+
+ /* progressive or interlaced mode */
+ interrupts = progressive ? VNIE_FIE | VNIE_EFE : VNIE_EFE;
+
+ /* ack interrupts */
+ iowrite32(interrupts, priv->base + VNINTS_REG);
+ /* enable interrupts */
+ iowrite32(interrupts, priv->base + VNIE_REG);
+ /* start capturing */
+ iowrite32(dmr, priv->base + VNDMR_REG);
+ iowrite32(vnmc | VNMC_ME, priv->base + VNMC_REG);
+}
+
+static void rcar_vin_capture(struct rcar_vin_priv *priv)
+{
+ if (is_continuous_transfer(priv))
+ /* Continuous Frame Capture Mode */
+ iowrite32(VNFC_C_FRAME, priv->base + VNFC_REG);
+ else
+ /* Single Frame Capture Mode */
+ iowrite32(VNFC_S_FRAME, priv->base + VNFC_REG);
+}
+
+static void rcar_vin_request_capture_stop(struct rcar_vin_priv *priv)
+{
+ priv->state = STOPPING;
+
+ /* set continuous & single transfer off */
+ iowrite32(0, priv->base + VNFC_REG);
+ /* disable capture (release DMA buffer), reset */
+ iowrite32(ioread32(priv->base + VNMC_REG) & ~VNMC_ME,
+ priv->base + VNMC_REG);
+
+ /* update the status if stopped already */
+ if (!(ioread32(priv->base + VNMS_REG) & VNMS_CA))
+ priv->state = STOPPED;
+}
+
+static int rcar_vin_get_free_hw_slot(struct rcar_vin_priv *priv)
+{
+ int slot;
+
+ for (slot = 0; slot < priv->nr_hw_slots; slot++)
+ if (priv->queue_buf[slot] == NULL)
+ return slot;
+
+ return -1;
+}
+
+static int rcar_vin_hw_ready(struct rcar_vin_priv *priv)
+{
+ /* Ensure all HW slots are filled */
+ return rcar_vin_get_free_hw_slot(priv) < 0 ? 1 : 0;
+}
+
+/* Moves a buffer from the queue to the HW slots */
+static int rcar_vin_fill_hw_slot(struct rcar_vin_priv *priv)
+{
+ struct vb2_buffer *vb;
+ dma_addr_t phys_addr_top;
+ int slot;
+
+ if (list_empty(&priv->capture))
+ return 0;
+
+ /* Find a free HW slot */
+ slot = rcar_vin_get_free_hw_slot(priv);
+ if (slot < 0)
+ return 0;
+
+ vb = &list_entry(priv->capture.next, struct rcar_vin_buffer, list)->vb;
+ list_del_init(to_buf_list(vb));
+ priv->queue_buf[slot] = vb;
+ phys_addr_top = vb2_dma_contig_plane_dma_addr(vb, 0);
+ iowrite32(phys_addr_top, priv->base + VNMB_REG(slot));
+
+ return 1;
+}
+
+static void rcar_vin_videobuf_queue(struct vb2_buffer *vb)
+{
+ struct soc_camera_device *icd = soc_camera_from_vb2q(vb->vb2_queue);
+ struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
+ struct rcar_vin_priv *priv = ici->priv;
+ unsigned long size;
+ int bytes_per_line;
+
+ bytes_per_line = soc_mbus_bytes_per_line(icd->user_width,
+ icd->current_fmt->host_fmt);
+ if (bytes_per_line < 0)
+ goto error;
+
+ size = icd->user_height * bytes_per_line;
+
+ if (vb2_plane_size(vb, 0) < size) {
+ dev_err(icd->parent, "Buffer #%d too small (%lu < %lu)\n",
+ vb->v4l2_buf.index, vb2_plane_size(vb, 0), size);
+ goto error;
+ }
+
+ vb2_set_plane_payload(vb, 0, size);
+
+ dev_dbg(icd->parent, "%s (vb=0x%p) 0x%p %lu\n", __func__,
+ vb, vb2_plane_vaddr(vb, 0), vb2_get_plane_payload(vb, 0));
+
+ spin_lock_irq(&priv->lock);
+
+ list_add_tail(to_buf_list(vb), &priv->capture);
+ rcar_vin_fill_hw_slot(priv);
+
+ /* If we weren't running, and have enough buffers, start capturing! */
+ if (priv->state != RUNNING && rcar_vin_hw_ready(priv)) {
+ priv->request_to_stop = false;
+ init_completion(&priv->capture_stop);
+ priv->state = RUNNING;
+ rcar_vin_setup(priv);
+ rcar_vin_capture(priv);
+ }
+
+ spin_unlock_irq(&priv->lock);
+
+ return;
+
+error:
+ vb2_buffer_done(vb, VB2_BUF_STATE_ERROR);
+}
+
+static void rcar_vin_videobuf_release(struct vb2_buffer *vb)
+{
+ struct soc_camera_device *icd = soc_camera_from_vb2q(vb->vb2_queue);
+ struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
+ struct rcar_vin_priv *priv = ici->priv;
+ unsigned int i;
+ int buf_in_use = 0;
+
+ spin_lock_irq(&priv->lock);
+
+ /* Is the buffer in use by the VIN hardware? */
+ for (i = 0; i < MAX_BUFFER_NUM; i++) {
+ if (priv->queue_buf[i] == vb) {
+ buf_in_use = 1;
+ break;
+ }
+ }
+
+ if (buf_in_use) {
+ while (priv->state != STOPPED) {
+
+ /* issue stop if running */
+ if (priv->state == RUNNING)
+ rcar_vin_request_capture_stop(priv);
+
+ /* wait until capturing has been stopped */
+ if (priv->state == STOPPING) {
+ priv->request_to_stop = true;
+ spin_unlock_irq(&priv->lock);
+ wait_for_completion(&priv->capture_stop);
+ spin_lock_irq(&priv->lock);
+ }
+ }
+ /*
+ * Capturing has now stopped. The buffer we have been asked
+ * to release could be any of the current buffers in use, so
+ * release all buffers that are in use by HW
+ */
+ for (i = 0; i < MAX_BUFFER_NUM; i++) {
+ if (priv->queue_buf[i]) {
+ vb2_buffer_done(priv->queue_buf[i],
+ VB2_BUF_STATE_ERROR);
+ priv->queue_buf[i] = NULL;
+ }
+ }
+ } else {
+ list_del_init(to_buf_list(vb));
+ }
+
+ spin_unlock_irq(&priv->lock);
+}
+
+static int rcar_vin_videobuf_init(struct vb2_buffer *vb)
+{
+ INIT_LIST_HEAD(to_buf_list(vb));
+ return 0;
+}
+
+static int rcar_vin_stop_streaming(struct vb2_queue *vq)
+{
+ struct soc_camera_device *icd = soc_camera_from_vb2q(vq);
+ struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
+ struct rcar_vin_priv *priv = ici->priv;
+ struct list_head *buf_head, *tmp;
+
+ spin_lock_irq(&priv->lock);
+ list_for_each_safe(buf_head, tmp, &priv->capture)
+ list_del_init(buf_head);
+ spin_unlock_irq(&priv->lock);
+
+ return 0;
+}
+
+static struct vb2_ops rcar_vin_vb2_ops = {
+ .queue_setup = rcar_vin_videobuf_setup,
+ .buf_init = rcar_vin_videobuf_init,
+ .buf_cleanup = rcar_vin_videobuf_release,
+ .buf_queue = rcar_vin_videobuf_queue,
+ .stop_streaming = rcar_vin_stop_streaming,
+ .wait_prepare = soc_camera_unlock,
+ .wait_finish = soc_camera_lock,
+};
+
+static irqreturn_t rcar_vin_irq(int irq, void *data)
+{
+ struct rcar_vin_priv *priv = data;
+ u32 int_status;
+ bool can_run = false, hw_stopped;
+ int slot;
+ unsigned int handled = 0;
+
+ spin_lock(&priv->lock);
+
+ int_status = ioread32(priv->base + VNINTS_REG);
+ if (!int_status)
+ goto done;
+ /* ack interrupts */
+ iowrite32(int_status, priv->base + VNINTS_REG);
+ handled = 1;
+
+ /* nothing to do if capture status is 'STOPPED' */
+ if (priv->state == STOPPED)
+ goto done;
+
+ hw_stopped = !(ioread32(priv->base + VNMS_REG) & VNMS_CA);
+
+ if (!priv->request_to_stop) {
+ if (is_continuous_transfer(priv))
+ slot = (ioread32(priv->base + VNMS_REG) &
+ VNMS_FBS_MASK) >> VNMS_FBS_SHIFT;
+ else
+ slot = 0;
+
+ priv->queue_buf[slot]->v4l2_buf.field = priv->field;
+ priv->queue_buf[slot]->v4l2_buf.sequence = priv->sequence++;
+ do_gettimeofday(&priv->queue_buf[slot]->v4l2_buf.timestamp);
+ vb2_buffer_done(priv->queue_buf[slot], VB2_BUF_STATE_DONE);
+ priv->queue_buf[slot] = NULL;
+
+ if (priv->state != STOPPING)
+ can_run = rcar_vin_fill_hw_slot(priv);
+
+ if (hw_stopped || !can_run) {
+ priv->state = STOPPED;
+ } else if (is_continuous_transfer(priv) &&
+ list_empty(&priv->capture) &&
+ priv->state == RUNNING) {
+ /*
+ * The continuous capturing requires an explicit stop
+ * operation when there is no buffer to be set into
+ * the VnMBm registers.
+ */
+ rcar_vin_request_capture_stop(priv);
+ } else {
+ rcar_vin_capture(priv);
+ }
+
+ } else if (hw_stopped) {
+ priv->state = STOPPED;
+ priv->request_to_stop = false;
+ complete(&priv->capture_stop);
+ }
+
+done:
+ spin_unlock(&priv->lock);
+
+ return IRQ_RETVAL(handled);
+}
+
+static int rcar_vin_add_device(struct soc_camera_device *icd)
+{
+ struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
+ struct rcar_vin_priv *priv = ici->priv;
+ int i;
+
+ if (priv->icd)
+ return -EBUSY;
+
+ for (i = 0; i < MAX_BUFFER_NUM; i++)
+ priv->queue_buf[i] = NULL;
+
+ pm_runtime_get_sync(ici->v4l2_dev.dev);
+ priv->icd = icd;
+
+ dev_dbg(icd->parent, "R-Car VIN driver attached to camera %d\n",
+ icd->devnum);
+
+ return 0;
+}
+
+static void rcar_vin_remove_device(struct soc_camera_device *icd)
+{
+ struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
+ struct rcar_vin_priv *priv = ici->priv;
+ struct vb2_buffer *vb;
+ int i;
+
+ if (icd != priv->icd) {
+ WARN_ON(1);
+ return;
+ }
+
+ /* disable capture, disable interrupts */
+ iowrite32(ioread32(priv->base + VNMC_REG) & ~VNMC_ME,
+ priv->base + VNMC_REG);
+ iowrite32(0, priv->base + VNIE_REG);
+
+ priv->state = STOPPED;
+ priv->request_to_stop = false;
+
+ /* make sure active buffer is cancelled */
+ spin_lock_irq(&priv->lock);
+ for (i = 0; i < MAX_BUFFER_NUM; i++) {
+ vb = priv->queue_buf[i];
+ if (vb) {
+ list_del_init(to_buf_list(vb));
+ vb2_buffer_done(vb, VB2_BUF_STATE_ERROR);
+ vb = NULL;
+ }
+ }
+ spin_unlock_irq(&priv->lock);
+
+ pm_runtime_put(ici->v4l2_dev.dev);
+ priv->icd = NULL;
+
+ dev_dbg(icd->parent, "R-Car VIN driver detached from camera %d\n",
+ icd->devnum);
+}
+
+/* rect is guaranteed to not exceed the scaled camera rectangle */
+static int rcar_vin_set_rect(struct soc_camera_device *icd)
+{
+ struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
+ struct rcar_vin_cam *cam = icd->host_priv;
+ struct rcar_vin_priv *priv = ici->priv;
+ unsigned int left_offset, top_offset;
+ unsigned char dsize = 0;
+ struct v4l2_rect *cam_subrect = &cam->subrect;
+
+ dev_dbg(icd->parent, "Crop %ux%u@%u:%u\n",
+ icd->user_width, icd->user_height, cam->vin_left, cam->vin_top);
+
+ left_offset = cam->vin_left;
+ top_offset = cam->vin_top;
+
+ if (icd->current_fmt->host_fmt->fourcc == V4L2_PIX_FMT_RGB32 &&
+ priv->chip == RCAR_E1)
+ dsize = 1;
+
+ dev_dbg(icd->parent, "Cam %ux%u@%u:%u\n",
+ cam->width, cam->height, cam->vin_left, cam->vin_top);
+ dev_dbg(icd->parent, "Cam subrect %ux%u@%u:%u\n",
+ cam_subrect->width, cam_subrect->height,
+ cam_subrect->left, cam_subrect->top);
+
+ /* Set Start/End Pixel/Line Pre-Clip */
+ iowrite32(left_offset << dsize, priv->base + VNSPPRC_REG);
+ iowrite32((left_offset + cam->width - 1) << dsize,
+ priv->base + VNEPPRC_REG);
+ switch (priv->field) {
+ case V4L2_FIELD_INTERLACED:
+ case V4L2_FIELD_INTERLACED_TB:
+ case V4L2_FIELD_INTERLACED_BT:
+ iowrite32(top_offset / 2, priv->base + VNSLPRC_REG);
+ iowrite32((top_offset + cam->height) / 2 - 1,
+ priv->base + VNELPRC_REG);
+ break;
+ default:
+ iowrite32(top_offset, priv->base + VNSLPRC_REG);
+ iowrite32(top_offset + cam->height - 1,
+ priv->base + VNELPRC_REG);
+ break;
+ }
+
+ /* Set Start/End Pixel/Line Post-Clip */
+ iowrite32(0, priv->base + VNSPPOC_REG);
+ iowrite32(0, priv->base + VNSLPOC_REG);
+ iowrite32((cam_subrect->width - 1) << dsize, priv->base + VNEPPOC_REG);
+ switch (priv->field) {
+ case V4L2_FIELD_INTERLACED:
+ case V4L2_FIELD_INTERLACED_TB:
+ case V4L2_FIELD_INTERLACED_BT:
+ iowrite32(cam_subrect->height / 2 - 1,
+ priv->base + VNELPOC_REG);
+ break;
+ default:
+ iowrite32(cam_subrect->height - 1, priv->base + VNELPOC_REG);
+ break;
+ }
+
+ iowrite32(ALIGN(cam->width, 0x10), priv->base + VNIS_REG);
+
+ return 0;
+}
+
+static void capture_stop_preserve(struct rcar_vin_priv *priv, u32 *vnmc)
+{
+ *vnmc = ioread32(priv->base + VNMC_REG);
+ /* module disable */
+ iowrite32(*vnmc & ~VNMC_ME, priv->base + VNMC_REG);
+}
+
+static void capture_restore(struct rcar_vin_priv *priv, u32 vnmc)
+{
+ unsigned long timeout = jiffies + 10 * HZ;
+
+ /*
+ * Wait until the end of the current frame. It can take a long time,
+ * but if it has been aborted by a MRST1 reset, it should exit sooner.
+ */
+ while ((ioread32(priv->base + VNMS_REG) & VNMS_AV) &&
+ time_before(jiffies, timeout))
+ msleep(1);
+
+ if (time_after(jiffies, timeout)) {
+ dev_err(priv->ici.v4l2_dev.dev,
+ "Timeout waiting for frame end! Interface problem?\n");
+ return;
+ }
+
+ iowrite32(vnmc, priv->base + VNMC_REG);
+}
+
+#define VIN_MBUS_FLAGS (V4L2_MBUS_MASTER | \
+ V4L2_MBUS_PCLK_SAMPLE_RISING | \
+ V4L2_MBUS_HSYNC_ACTIVE_HIGH | \
+ V4L2_MBUS_HSYNC_ACTIVE_LOW | \
+ V4L2_MBUS_VSYNC_ACTIVE_HIGH | \
+ V4L2_MBUS_VSYNC_ACTIVE_LOW | \
+ V4L2_MBUS_DATA_ACTIVE_HIGH)
+
+static int rcar_vin_set_bus_param(struct soc_camera_device *icd)
+{
+ struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
+ struct rcar_vin_priv *priv = ici->priv;
+ struct v4l2_subdev *sd = soc_camera_to_subdev(icd);
+ struct v4l2_mbus_config cfg;
+ unsigned long common_flags;
+ u32 vnmc;
+ u32 val;
+ int ret;
+
+ capture_stop_preserve(priv, &vnmc);
+
+ ret = v4l2_subdev_call(sd, video, g_mbus_config, &cfg);
+ if (!ret) {
+ common_flags = soc_mbus_config_compatible(&cfg, VIN_MBUS_FLAGS);
+ if (!common_flags) {
+ dev_warn(icd->parent,
+ "MBUS flags incompatible: camera 0x%x, host 0x%x\n",
+ cfg.flags, VIN_MBUS_FLAGS);
+ return -EINVAL;
+ }
+ } else if (ret != -ENOIOCTLCMD) {
+ return ret;
+ } else {
+ common_flags = VIN_MBUS_FLAGS;
+ }
+
+ /* Make choises, based on platform preferences */
+ if ((common_flags & V4L2_MBUS_HSYNC_ACTIVE_HIGH) &&
+ (common_flags & V4L2_MBUS_HSYNC_ACTIVE_LOW)) {
+ if (priv->pdata->flags & RCAR_VIN_HSYNC_ACTIVE_LOW)
+ common_flags &= ~V4L2_MBUS_HSYNC_ACTIVE_HIGH;
+ else
+ common_flags &= ~V4L2_MBUS_HSYNC_ACTIVE_LOW;
+ }
+
+ if ((common_flags & V4L2_MBUS_VSYNC_ACTIVE_HIGH) &&
+ (common_flags & V4L2_MBUS_VSYNC_ACTIVE_LOW)) {
+ if (priv->pdata->flags & RCAR_VIN_VSYNC_ACTIVE_LOW)
+ common_flags &= ~V4L2_MBUS_VSYNC_ACTIVE_HIGH;
+ else
+ common_flags &= ~V4L2_MBUS_VSYNC_ACTIVE_LOW;
+ }
+
+ cfg.flags = common_flags;
+ ret = v4l2_subdev_call(sd, video, s_mbus_config, &cfg);
+ if (ret < 0 && ret != -ENOIOCTLCMD)
+ return ret;
+
+ val = priv->field == V4L2_FIELD_NONE ? VNDMR2_FTEV : 0;
+ if (!(common_flags & V4L2_MBUS_VSYNC_ACTIVE_LOW))
+ val |= VNDMR2_VPS;
+ if (!(common_flags & V4L2_MBUS_HSYNC_ACTIVE_LOW))
+ val |= VNDMR2_HPS;
+ iowrite32(val, priv->base + VNDMR2_REG);
+
+ ret = rcar_vin_set_rect(icd);
+ if (ret < 0)
+ return ret;
+
+ capture_restore(priv, vnmc);
+
+ return 0;
+}
+
+static int rcar_vin_try_bus_param(struct soc_camera_device *icd,
+ unsigned char buswidth)
+{
+ struct v4l2_subdev *sd = soc_camera_to_subdev(icd);
+ struct v4l2_mbus_config cfg;
+ int ret;
+
+ ret = v4l2_subdev_call(sd, video, g_mbus_config, &cfg);
+ if (ret == -ENOIOCTLCMD)
+ return 0;
+ else if (ret)
+ return ret;
+
+ if (buswidth > 24)
+ return -EINVAL;
+
+ /* check is there common mbus flags */
+ ret = soc_mbus_config_compatible(&cfg, VIN_MBUS_FLAGS);
+ if (ret)
+ return 0;
+
+ dev_warn(icd->parent,
+ "MBUS flags incompatible: camera 0x%x, host 0x%x\n",
+ cfg.flags, VIN_MBUS_FLAGS);
+
+ return -EINVAL;
+}
+
+static bool rcar_vin_packing_supported(const struct soc_mbus_pixelfmt *fmt)
+{
+ return fmt->packing == SOC_MBUS_PACKING_NONE ||
+ (fmt->bits_per_sample > 8 &&
+ fmt->packing == SOC_MBUS_PACKING_EXTEND16);
+}
+
+static const struct soc_mbus_pixelfmt rcar_vin_formats[] = {
+ {
+ .fourcc = V4L2_PIX_FMT_NV16,
+ .name = "NV16",
+ .bits_per_sample = 16,
+ .packing = SOC_MBUS_PACKING_NONE,
+ .order = SOC_MBUS_ORDER_LE,
+ .layout = SOC_MBUS_LAYOUT_PACKED,
+ },
+ {
+ .fourcc = V4L2_PIX_FMT_UYVY,
+ .name = "UYVY",
+ .bits_per_sample = 16,
+ .packing = SOC_MBUS_PACKING_NONE,
+ .order = SOC_MBUS_ORDER_LE,
+ .layout = SOC_MBUS_LAYOUT_PACKED,
+ },
+ {
+ .fourcc = V4L2_PIX_FMT_RGB565,
+ .name = "RGB565",
+ .bits_per_sample = 16,
+ .packing = SOC_MBUS_PACKING_NONE,
+ .order = SOC_MBUS_ORDER_LE,
+ .layout = SOC_MBUS_LAYOUT_PACKED,
+ },
+ {
+ .fourcc = V4L2_PIX_FMT_RGB555X,
+ .name = "ARGB1555",
+ .bits_per_sample = 16,
+ .packing = SOC_MBUS_PACKING_NONE,
+ .order = SOC_MBUS_ORDER_LE,
+ .layout = SOC_MBUS_LAYOUT_PACKED,
+ },
+ {
+ .fourcc = V4L2_PIX_FMT_RGB32,
+ .name = "RGB888",
+ .bits_per_sample = 32,
+ .packing = SOC_MBUS_PACKING_NONE,
+ .order = SOC_MBUS_ORDER_LE,
+ .layout = SOC_MBUS_LAYOUT_PACKED,
+ },
+};
+
+static int rcar_vin_get_formats(struct soc_camera_device *icd, unsigned int idx,
+ struct soc_camera_format_xlate *xlate)
+{
+ struct v4l2_subdev *sd = soc_camera_to_subdev(icd);
+ struct device *dev = icd->parent;
+ int ret, k, n;
+ int formats = 0;
+ struct rcar_vin_cam *cam;
+ enum v4l2_mbus_pixelcode code;
+ const struct soc_mbus_pixelfmt *fmt;
+
+ ret = v4l2_subdev_call(sd, video, enum_mbus_fmt, idx, &code);
+ if (ret < 0)
+ return 0;
+
+ fmt = soc_mbus_get_fmtdesc(code);
+ if (!fmt) {
+ dev_warn(dev, "unsupported format code #%u: %d\n", idx, code);
+ return 0;
+ }
+
+ ret = rcar_vin_try_bus_param(icd, fmt->bits_per_sample);
+ if (ret < 0)
+ return 0;
+
+ if (!icd->host_priv) {
+ struct v4l2_mbus_framefmt mf;
+ struct v4l2_rect rect;
+ struct device *dev = icd->parent;
+ int shift;
+
+ ret = v4l2_subdev_call(sd, video, g_mbus_fmt, &mf);
+ if (ret < 0)
+ return ret;
+
+ /* Cache current client geometry */
+ ret = soc_camera_client_g_rect(sd, &rect);
+ if (ret < 0) {
+ /* Sensor driver doesn't support cropping */
+ rect.left = 0;
+ rect.top = 0;
+ rect.width = mf.width;
+ rect.height = mf.height;
+ }
+
+ /*
+ * If sensor proposes too large format then try smaller ones:
+ * 1280x960, 640x480, 320x240
+ */
+ for (shift = 0; shift < 3; shift++) {
+ if (mf.width <= VIN_MAX_WIDTH &&
+ mf.height <= VIN_MAX_HEIGHT)
+ break;
+
+ mf.width = 1280 >> shift;
+ mf.height = 960 >> shift;
+ ret = v4l2_device_call_until_err(sd->v4l2_dev,
+ soc_camera_grp_id(icd),
+ video, s_mbus_fmt,
+ &mf);
+ if (ret < 0)
+ return ret;
+ }
+
+ if (shift == 3) {
+ dev_err(dev,
+ "Failed to configure the client below %ux%x\n",
+ mf.width, mf.height);
+ return -EIO;
+ }
+
+ dev_dbg(dev, "camera fmt %ux%u\n", mf.width, mf.height);
+
+ cam = kzalloc(sizeof(*cam), GFP_KERNEL);
+ if (!cam)
+ return -ENOMEM;
+ /*
+ * We are called with current camera crop,
+ * initialise subrect with it
+ */
+ cam->rect = rect;
+ cam->subrect = rect;
+ cam->width = mf.width;
+ cam->height = mf.height;
+
+ icd->host_priv = cam;
+ } else {
+ cam = icd->host_priv;
+ }
+
+ /* Beginning of a pass */
+ if (!idx)
+ cam->extra_fmt = NULL;
+
+ switch (code) {
+ case V4L2_MBUS_FMT_YUYV8_1X16:
+ case V4L2_MBUS_FMT_YUYV8_2X8:
+ if (cam->extra_fmt)
+ break;
+
+ /* Add all our formats that can be generated by VIN */
+ cam->extra_fmt = rcar_vin_formats;
+
+ n = ARRAY_SIZE(rcar_vin_formats);
+ formats += n;
+ for (k = 0; xlate && k < n; k++, xlate++) {
+ xlate->host_fmt = &rcar_vin_formats[k];
+ xlate->code = code;
+ dev_dbg(dev, "Providing format %s using code %d\n",
+ rcar_vin_formats[k].name, code);
+ }
+ break;
+ default:
+ if (!rcar_vin_packing_supported(fmt))
+ return 0;
+
+ dev_dbg(dev, "Providing format %s in pass-through mode\n",
+ fmt->name);
+ break;
+ }
+
+ /* Generic pass-through */
+ formats++;
+ if (xlate) {
+ xlate->host_fmt = fmt;
+ xlate->code = code;
+ xlate++;
+ }
+
+ return formats;
+}
+
+static void rcar_vin_put_formats(struct soc_camera_device *icd)
+{
+ kfree(icd->host_priv);
+ icd->host_priv = NULL;
+}
+
+static int rcar_vin_set_crop(struct soc_camera_device *icd,
+ const struct v4l2_crop *a)
+{
+ struct v4l2_crop a_writable = *a;
+ const struct v4l2_rect *rect = &a_writable.c;
+ struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
+ struct rcar_vin_priv *priv = ici->priv;
+ struct v4l2_crop cam_crop;
+ struct rcar_vin_cam *cam = icd->host_priv;
+ struct v4l2_rect *cam_rect = &cam_crop.c;
+ struct v4l2_subdev *sd = soc_camera_to_subdev(icd);
+ struct device *dev = icd->parent;
+ struct v4l2_mbus_framefmt mf;
+ u32 vnmc;
+ int ret, i;
+
+ dev_dbg(dev, "S_CROP(%ux%u@%u:%u)\n", rect->width, rect->height,
+ rect->left, rect->top);
+
+ /* During camera cropping its output window can change too, stop VIN */
+ capture_stop_preserve(priv, &vnmc);
+ dev_dbg(dev, "VNMC_REG 0x%x\n", vnmc);
+
+ /* Apply iterative camera S_CROP for new input window. */
+ ret = soc_camera_client_s_crop(sd, &a_writable, &cam_crop,
+ &cam->rect, &cam->subrect);
+ if (ret < 0)
+ return ret;
+
+ dev_dbg(dev, "camera cropped to %ux%u@%u:%u\n",
+ cam_rect->width, cam_rect->height,
+ cam_rect->left, cam_rect->top);
+
+ /* On success cam_crop contains current camera crop */
+
+ /* Retrieve camera output window */
+ ret = v4l2_subdev_call(sd, video, g_mbus_fmt, &mf);
+ if (ret < 0)
+ return ret;
+
+ if (mf.width > VIN_MAX_WIDTH || mf.height > VIN_MAX_HEIGHT)
+ return -EINVAL;
+
+ /* Cache camera output window */
+ cam->width = mf.width;
+ cam->height = mf.height;
+
+ icd->user_width = cam->width;
+ icd->user_height = cam->height;
+
+ cam->vin_left = rect->left & ~1;
+ cam->vin_top = rect->top & ~1;
+
+ /* Use VIN cropping to crop to the new window. */
+ ret = rcar_vin_set_rect(icd);
+ if (ret < 0)
+ return ret;
+
+ cam->subrect = *rect;
+
+ dev_dbg(dev, "VIN cropped to %ux%u@%u:%u\n",
+ icd->user_width, icd->user_height,
+ cam->vin_left, cam->vin_top);
+
+ /* Restore capture */
+ for (i = 0; i < MAX_BUFFER_NUM; i++) {
+ if (priv->queue_buf[i] && priv->state == STOPPED) {
+ vnmc |= VNMC_ME;
+ break;
+ }
+ }
+ capture_restore(priv, vnmc);
+
+ /* Even if only camera cropping succeeded */
+ return ret;
+}
+
+static int rcar_vin_get_crop(struct soc_camera_device *icd,
+ struct v4l2_crop *a)
+{
+ struct rcar_vin_cam *cam = icd->host_priv;
+
+ a->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
+ a->c = cam->subrect;
+
+ return 0;
+}
+
+/* Similar to set_crop multistage iterative algorithm */
+static int rcar_vin_set_fmt(struct soc_camera_device *icd,
+ struct v4l2_format *f)
+{
+ struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
+ struct rcar_vin_priv *priv = ici->priv;
+ struct v4l2_subdev *sd = soc_camera_to_subdev(icd);
+ struct rcar_vin_cam *cam = icd->host_priv;
+ struct v4l2_pix_format *pix = &f->fmt.pix;
+ struct v4l2_mbus_framefmt mf;
+ struct device *dev = icd->parent;
+ __u32 pixfmt = pix->pixelformat;
+ const struct soc_camera_format_xlate *xlate;
+ unsigned int vin_sub_width = 0, vin_sub_height = 0;
+ int ret;
+ bool can_scale;
+ enum v4l2_field field;
+ v4l2_std_id std;
+
+ dev_dbg(dev, "S_FMT(pix=0x%x, %ux%u)\n",
+ pixfmt, pix->width, pix->height);
+
+ switch (pix->field) {
+ default:
+ pix->field = V4L2_FIELD_NONE;
+ /* fall-through */
+ case V4L2_FIELD_NONE:
+ case V4L2_FIELD_TOP:
+ case V4L2_FIELD_BOTTOM:
+ case V4L2_FIELD_INTERLACED_TB:
+ case V4L2_FIELD_INTERLACED_BT:
+ field = pix->field;
+ break;
+ case V4L2_FIELD_INTERLACED:
+ /* Query for standard if not explicitly mentioned _TB/_BT */
+ ret = v4l2_subdev_call(sd, video, querystd, &std);
+ if (ret < 0)
+ std = V4L2_STD_625_50;
+
+ field = std & V4L2_STD_625_50 ? V4L2_FIELD_INTERLACED_TB :
+ V4L2_FIELD_INTERLACED_BT;
+ break;
+ }
+
+ xlate = soc_camera_xlate_by_fourcc(icd, pixfmt);
+ if (!xlate) {
+ dev_warn(dev, "Format %x not found\n", pixfmt);
+ return -EINVAL;
+ }
+ /* Calculate client output geometry */
+ soc_camera_calc_client_output(icd, &cam->rect, &cam->subrect, pix, &mf, 12);
+ mf.field = pix->field;
+ mf.colorspace = pix->colorspace;
+ mf.code = xlate->code;
+
+ switch (pixfmt) {
+ case V4L2_PIX_FMT_NV16:
+ can_scale = false;
+ break;
+ case V4L2_PIX_FMT_RGB32:
+ can_scale = priv->chip != RCAR_E1;
+ break;
+ default:
+ can_scale = true;
+ break;
+ }
+
+ dev_dbg(dev, "request camera output %ux%u\n", mf.width, mf.height);
+
+ ret = soc_camera_client_scale(icd, &cam->rect, &cam->subrect,
+ &mf, &vin_sub_width, &vin_sub_height,
+ can_scale, 12);
+
+ /* Done with the camera. Now see if we can improve the result */
+ dev_dbg(dev, "Camera %d fmt %ux%u, requested %ux%u\n",
+ ret, mf.width, mf.height, pix->width, pix->height);
+
+ if (ret < 0)
+ dev_dbg(dev, "Sensor doesn't support cropping\n");
+
+ if (mf.code != xlate->code)
+ return -EINVAL;
+
+ /* Prepare VIN crop */
+ cam->width = mf.width;
+ cam->height = mf.height;
+
+ /* Use VIN scaling to scale to the requested user window. */
+
+ /* We cannot scale up */
+ if (pix->width > vin_sub_width)
+ vin_sub_width = pix->width;
+
+ if (pix->height > vin_sub_height)
+ vin_sub_height = pix->height;
+
+ pix->colorspace = mf.colorspace;
+
+ if (!can_scale) {
+ pix->width = vin_sub_width;
+ pix->height = vin_sub_height;
+ }
+
+ /*
+ * We have calculated CFLCR, the actual configuration will be performed
+ * in rcar_vin_set_bus_param()
+ */
+
+ dev_dbg(dev, "W: %u : %u, H: %u : %u\n",
+ vin_sub_width, pix->width, vin_sub_height, pix->height);
+
+ icd->current_fmt = xlate;
+
+ priv->field = field;
+
+ return 0;
+}
+
+static int rcar_vin_try_fmt(struct soc_camera_device *icd,
+ struct v4l2_format *f)
+{
+ const struct soc_camera_format_xlate *xlate;
+ struct v4l2_pix_format *pix = &f->fmt.pix;
+ struct v4l2_subdev *sd = soc_camera_to_subdev(icd);
+ struct v4l2_mbus_framefmt mf;
+ __u32 pixfmt = pix->pixelformat;
+ int width, height;
+ int ret;
+
+ xlate = soc_camera_xlate_by_fourcc(icd, pixfmt);
+ if (!xlate) {
+ xlate = icd->current_fmt;
+ dev_dbg(icd->parent, "Format %x not found, keeping %x\n",
+ pixfmt, xlate->host_fmt->fourcc);
+ pixfmt = xlate->host_fmt->fourcc;
+ pix->pixelformat = pixfmt;
+ pix->colorspace = icd->colorspace;
+ }
+
+ /* FIXME: calculate using depth and bus width */
+ v4l_bound_align_image(&pix->width, 2, VIN_MAX_WIDTH, 1,
+ &pix->height, 4, VIN_MAX_HEIGHT, 2, 0);
+
+ width = pix->width;
+ height = pix->height;
+
+ /* let soc-camera calculate these values */
+ pix->bytesperline = 0;
+ pix->sizeimage = 0;
+
+ /* limit to sensor capabilities */
+ mf.width = pix->width;
+ mf.height = pix->height;
+ mf.field = pix->field;
+ mf.code = xlate->code;
+ mf.colorspace = pix->colorspace;
+
+ ret = v4l2_device_call_until_err(sd->v4l2_dev, soc_camera_grp_id(icd),
+ video, try_mbus_fmt, &mf);
+ if (ret < 0)
+ return ret;
+
+ pix->width = mf.width;
+ pix->height = mf.height;
+ pix->field = mf.field;
+ pix->colorspace = mf.colorspace;
+
+ if (pixfmt == V4L2_PIX_FMT_NV16) {
+ /* FIXME: check against rect_max after converting soc-camera */
+ /* We can scale precisely, need a bigger image from camera */
+ if (pix->width < width || pix->height < height) {
+ /*
+ * We presume, the sensor behaves sanely, i.e. if
+ * requested a bigger rectangle, it will not return a
+ * smaller one.
+ */
+ mf.width = VIN_MAX_WIDTH;
+ mf.height = VIN_MAX_HEIGHT;
+ ret = v4l2_device_call_until_err(sd->v4l2_dev,
+ soc_camera_grp_id(icd),
+ video, try_mbus_fmt,
+ &mf);
+ if (ret < 0) {
+ dev_err(icd->parent,
+ "client try_fmt() = %d\n", ret);
+ return ret;
+ }
+ }
+ /* We will scale exactly */
+ if (mf.width > width)
+ pix->width = width;
+ if (mf.height > height)
+ pix->height = height;
+ }
+
+ return ret;
+}
+
+static unsigned int rcar_vin_poll(struct file *file, poll_table *pt)
+{
+ struct soc_camera_device *icd = file->private_data;
+
+ return vb2_poll(&icd->vb2_vidq, file, pt);
+}
+
+static int rcar_vin_querycap(struct soc_camera_host *ici,
+ struct v4l2_capability *cap)
+{
+ strlcpy(cap->card, "R_Car_VIN", sizeof(cap->card));
+ cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_STREAMING;
+ return 0;
+}
+
+static int rcar_vin_init_videobuf2(struct vb2_queue *vq,
+ struct soc_camera_device *icd)
+{
+ vq->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
+ vq->io_modes = VB2_MMAP | VB2_USERPTR;
+ vq->drv_priv = icd;
+ vq->ops = &rcar_vin_vb2_ops;
+ vq->mem_ops = &vb2_dma_contig_memops;
+ vq->buf_struct_size = sizeof(struct rcar_vin_buffer);
+ vq->timestamp_type = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
+
+ return vb2_queue_init(vq);
+}
+
+static struct soc_camera_host_ops rcar_vin_host_ops = {
+ .owner = THIS_MODULE,
+ .add = rcar_vin_add_device,
+ .remove = rcar_vin_remove_device,
+ .get_formats = rcar_vin_get_formats,
+ .put_formats = rcar_vin_put_formats,
+ .get_crop = rcar_vin_get_crop,
+ .set_crop = rcar_vin_set_crop,
+ .try_fmt = rcar_vin_try_fmt,
+ .set_fmt = rcar_vin_set_fmt,
+ .poll = rcar_vin_poll,
+ .querycap = rcar_vin_querycap,
+ .set_bus_param = rcar_vin_set_bus_param,
+ .init_videobuf2 = rcar_vin_init_videobuf2,
+};
+
+static struct platform_device_id rcar_vin_id_table[] = {
+ { "r8a7779-vin", RCAR_H1 },
+ { "r8a7778-vin", RCAR_M1 },
+ { "uPD35004-vin", RCAR_E1 },
+ {},
+};
+MODULE_DEVICE_TABLE(platform, rcar_vin_id_table);
+
+static int rcar_vin_probe(struct platform_device *pdev)
+{
+ struct rcar_vin_priv *priv;
+ struct resource *mem;
+ struct rcar_vin_platform_data *pdata;
+ int irq, ret;
+
+ pdata = pdev->dev.platform_data;
+ if (!pdata || !pdata->flags) {
+ dev_err(&pdev->dev, "platform data not set\n");
+ return -EINVAL;
+ }
+
+ mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ if (mem == NULL)
+ return -EINVAL;
+
+ irq = platform_get_irq(pdev, 0);
+ if (irq <= 0)
+ return -EINVAL;
+
+ priv = devm_kzalloc(&pdev->dev, sizeof(struct rcar_vin_priv),
+ GFP_KERNEL);
+ if (!priv)
+ return -ENOMEM;
+
+ priv->base = devm_ioremap_resource(&pdev->dev, mem);
+ if (IS_ERR(priv->base))
+ return PTR_ERR(priv->base);
+
+ ret = devm_request_irq(&pdev->dev, irq, rcar_vin_irq, IRQF_SHARED,
+ dev_name(&pdev->dev), priv);
+ if (ret)
+ return ret;
+
+ priv->alloc_ctx = vb2_dma_contig_init_ctx(&pdev->dev);
+ if (IS_ERR(priv->alloc_ctx))
+ return PTR_ERR(priv->alloc_ctx);
+
+ priv->ici.priv = priv;
+ priv->ici.v4l2_dev.dev = &pdev->dev;
+ priv->ici.nr = pdev->id;
+ priv->ici.drv_name = dev_name(&pdev->dev);
+ priv->ici.ops = &rcar_vin_host_ops;
+
+ priv->pdata = pdata;
+ priv->chip = pdev->id_entry->driver_data;
+ spin_lock_init(&priv->lock);
+ INIT_LIST_HEAD(&priv->capture);
+
+ priv->state = STOPPED;
+
+ pm_suspend_ignore_children(&pdev->dev, true);
+ pm_runtime_enable(&pdev->dev);
+
+ ret = soc_camera_host_register(&priv->ici);
+ if (ret)
+ goto cleanup;
+
+ return 0;
+
+cleanup:
+ pm_runtime_disable(&pdev->dev);
+ vb2_dma_contig_cleanup_ctx(priv->alloc_ctx);
+
+ return ret;
+}
+
+static int rcar_vin_remove(struct platform_device *pdev)
+{
+ struct soc_camera_host *soc_host = to_soc_camera_host(&pdev->dev);
+ struct rcar_vin_priv *priv = container_of(soc_host,
+ struct rcar_vin_priv, ici);
+
+ soc_camera_host_unregister(soc_host);
+ pm_runtime_disable(&pdev->dev);
+ vb2_dma_contig_cleanup_ctx(priv->alloc_ctx);
+
+ return 0;
+}
+
+static struct platform_driver rcar_vin_driver = {
+ .probe = rcar_vin_probe,
+ .remove = rcar_vin_remove,
+ .driver = {
+ .name = DRV_NAME,
+ .owner = THIS_MODULE,
+ },
+ .id_table = rcar_vin_id_table,
+};
+
+module_platform_driver(rcar_vin_driver);
+
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:rcar_vin");
+MODULE_DESCRIPTION("Renesas R-Car VIN camera host driver");
Index: media_tree/include/linux/platform_data/camera-rcar.h
===================================================================
--- /dev/null
+++ media_tree/include/linux/platform_data/camera-rcar.h
@@ -0,0 +1,25 @@
+/*
+ * Platform data for Renesas R-Car VIN soc-camera driver
+ *
+ * Copyright (C) 2011-2013 Renesas Solutions Corp.
+ * Copyright (C) 2013 Cogent Embedded, Inc., <source@cogentembedded.com>
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation; either version 2 of the License, or (at your
+ * option) any later version.
+ */
+
+#ifndef __CAMERA_RCAR_H_
+#define __CAMERA_RCAR_H_
+
+#define RCAR_VIN_HSYNC_ACTIVE_LOW (1 << 0)
+#define RCAR_VIN_VSYNC_ACTIVE_LOW (1 << 1)
+#define RCAR_VIN_BT601 (1 << 2)
+#define RCAR_VIN_BT656 (1 << 3)
+
+struct rcar_vin_platform_data {
+ unsigned int flags;
+};
+
+#endif /* __CAMERA_RCAR_H_ */
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver
2013-05-23 22:11 [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver Sergei Shtylyov
@ 2013-06-02 18:56 ` Sergei Shtylyov
2013-06-04 1:08 ` Simon Horman
2013-06-13 13:12 ` Guennadi Liakhovetski
2013-06-21 4:46 ` Katsuya MATSUBARA
2 siblings, 1 reply; 26+ messages in thread
From: Sergei Shtylyov @ 2013-06-02 18:56 UTC (permalink / raw)
To: g.liakhovetski, mchehab, linux-media
Cc: magnus.damm, linux-sh, phil.edworthy, matsu, vladimir.barinov
Hello.
On 05/24/2013 02:11 AM, Sergei Shtylyov wrote:
> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>
> Add Renesas R-Car VIN (Video In) V4L2 driver.
>
> Based on the patch by Phil Edworthy <phil.edworthy@renesas.com>.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> [Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed 'enum chip_id'
> values, reordered rcar_vin_id_table[] entries, removed senseless parens from
> to_buf_list() macro, used ALIGN() macro in rcar_vin_setup(), added {} to the
> *if* statement and used 'bool' values instead of 0/1 where necessary, removed
> unused macros, done some reformatting and clarified some comments.]
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> This patch is against the 'media_tree.git' repo.
> It requires two following patches from Guennadi Liakhovetski:
>
> https://patchwork.linuxtv.org/patch/18209/
> https://patchwork.linuxtv.org/patch/18210/
>
[...]
> Index: media_tree/include/linux/platform_data/camera-rcar.h
> ===================================================================
> --- /dev/null
> +++ media_tree/include/linux/platform_data/camera-rcar.h
> @@ -0,0 +1,25 @@
> +/*
> + * Platform data for Renesas R-Car VIN soc-camera driver
> + *
> + * Copyright (C) 2011-2013 Renesas Solutions Corp.
> + * Copyright (C) 2013 Cogent Embedded, Inc., <source@cogentembedded.com>
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published by the
> + * Free Software Foundation; either version 2 of the License, or (at your
> + * option) any later version.
> + */
> +
> +#ifndef __CAMERA_RCAR_H_
> +#define __CAMERA_RCAR_H_
> +
> +#define RCAR_VIN_HSYNC_ACTIVE_LOW (1 << 0)
> +#define RCAR_VIN_VSYNC_ACTIVE_LOW (1 << 1)
> +#define RCAR_VIN_BT601 (1 << 2)
> +#define RCAR_VIN_BT656 (1 << 3)
> +
> +struct rcar_vin_platform_data {
> + unsigned int flags;
> +};
> +
> +#endif /* __CAMERA_RCAR_H_ */
I wonder how to deal with a cross tree dependency caused by this file.
Perhaps the VIN platform code could be merged thru the media tree (or
maybe vice versa, all patches merged thru the Renesas tree)?
WBR, Sergei
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver
2013-06-02 18:56 ` Sergei Shtylyov
@ 2013-06-04 1:08 ` Simon Horman
0 siblings, 0 replies; 26+ messages in thread
From: Simon Horman @ 2013-06-04 1:08 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: g.liakhovetski, mchehab, linux-media, magnus.damm, linux-sh,
phil.edworthy, matsu, vladimir.barinov
On Sun, Jun 02, 2013 at 10:56:22PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 05/24/2013 02:11 AM, Sergei Shtylyov wrote:
>
> >From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> >
> >Add Renesas R-Car VIN (Video In) V4L2 driver.
> >
> >Based on the patch by Phil Edworthy <phil.edworthy@renesas.com>.
> >
> >Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> >[Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed 'enum chip_id'
> >values, reordered rcar_vin_id_table[] entries, removed senseless parens from
> >to_buf_list() macro, used ALIGN() macro in rcar_vin_setup(), added {} to the
> >*if* statement and used 'bool' values instead of 0/1 where necessary, removed
> >unused macros, done some reformatting and clarified some comments.]
> >Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >
> >---
> >This patch is against the 'media_tree.git' repo.
> >It requires two following patches from Guennadi Liakhovetski:
> >
> >https://patchwork.linuxtv.org/patch/18209/
> >https://patchwork.linuxtv.org/patch/18210/
> >
>
> [...]
> >Index: media_tree/include/linux/platform_data/camera-rcar.h
> >===================================================================
> >--- /dev/null
> >+++ media_tree/include/linux/platform_data/camera-rcar.h
> >@@ -0,0 +1,25 @@
> >+/*
> >+ * Platform data for Renesas R-Car VIN soc-camera driver
> >+ *
> >+ * Copyright (C) 2011-2013 Renesas Solutions Corp.
> >+ * Copyright (C) 2013 Cogent Embedded, Inc., <source@cogentembedded.com>
> >+ *
> >+ * This program is free software; you can redistribute it and/or modify it
> >+ * under the terms of the GNU General Public License as published by the
> >+ * Free Software Foundation; either version 2 of the License, or (at your
> >+ * option) any later version.
> >+ */
> >+
> >+#ifndef __CAMERA_RCAR_H_
> >+#define __CAMERA_RCAR_H_
> >+
> >+#define RCAR_VIN_HSYNC_ACTIVE_LOW (1 << 0)
> >+#define RCAR_VIN_VSYNC_ACTIVE_LOW (1 << 1)
> >+#define RCAR_VIN_BT601 (1 << 2)
> >+#define RCAR_VIN_BT656 (1 << 3)
> >+
> >+struct rcar_vin_platform_data {
> >+ unsigned int flags;
> >+};
> >+
> >+#endif /* __CAMERA_RCAR_H_ */
>
> I wonder how to deal with a cross tree dependency caused by this file.
> Perhaps the VIN platform code could be merged thru the media tree (or
> maybe vice versa, all patches merged thru the Renesas tree)?
I am comfortable with either option with a slight preference for
taking the changes through the media tree.
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver
2013-05-23 22:11 [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver Sergei Shtylyov
2013-06-02 18:56 ` Sergei Shtylyov
@ 2013-06-13 13:12 ` Guennadi Liakhovetski
2013-06-21 0:50 ` Vladimir Barinov
2013-06-21 20:08 ` Sergei Shtylyov
2013-06-21 4:46 ` Katsuya MATSUBARA
2 siblings, 2 replies; 26+ messages in thread
From: Guennadi Liakhovetski @ 2013-06-13 13:12 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: mchehab, linux-media, magnus.damm, linux-sh, phil.edworthy,
matsu, vladimir.barinov
Hi Sergei
Patches, that this commit is based upon are hopefully moving towards the
mainline, but it's still possible, that some more changes will be
required. In any case, I wanted to comment to this version to let you
prepare for a new version in advance.
In general - looks better!
On Fri, 24 May 2013, Sergei Shtylyov wrote:
> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>
> Add Renesas R-Car VIN (Video In) V4L2 driver.
>
> Based on the patch by Phil Edworthy <phil.edworthy@renesas.com>.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> [Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed 'enum chip_id'
> values, reordered rcar_vin_id_table[] entries, removed senseless parens from
> to_buf_list() macro, used ALIGN() macro in rcar_vin_setup(), added {} to the
> *if* statement and used 'bool' values instead of 0/1 where necessary, removed
> unused macros, done some reformatting and clarified some comments.]
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
[snip]
> Index: media_tree/drivers/media/platform/soc_camera/rcar_vin.c
> ===================================================================
> --- /dev/null
> +++ media_tree/drivers/media/platform/soc_camera/rcar_vin.c
> @@ -0,0 +1,1476 @@
> +/*
> + * SoC-camera host driver for Renesas R-Car VIN unit
> + *
> + * Copyright (C) 2011-2013 Renesas Solutions Corp.
> + * Copyright (C) 2013 Cogent Embedded, Inc., <source@cogentembedded.com>
> + *
> + * Based on V4L2 Driver for SuperH Mobile CEU interface "sh_mobile_ceu_camera.c"
> + *
> + * Copyright (C) 2008 Magnus Damm
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published by the
> + * Free Software Foundation; either version 2 of the License, or (at your
> + * option) any later version.
> + */
> +
> +#include <linux/delay.h>
> +#include <linux/interrupt.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/platform_device.h>
> +#include <linux/pm_runtime.h>
> +#include <linux/platform_data/camera-rcar.h>
"l" before "m" please :)
[snip]
> +static void rcar_vin_setup(struct rcar_vin_priv *priv)
> +{
> + struct soc_camera_device *icd = priv->icd;
> + struct rcar_vin_cam *cam = icd->host_priv;
> + u32 vnmc, dmr, interrupts;
> + bool progressive = false, output_is_yuv = false;
> +
> + switch (priv->field) {
> + case V4L2_FIELD_TOP:
> + vnmc = VNMC_IM_ODD;
> + break;
> + case V4L2_FIELD_BOTTOM:
> + vnmc = VNMC_IM_EVEN;
> + break;
> + case V4L2_FIELD_INTERLACED:
> + case V4L2_FIELD_INTERLACED_TB:
> + vnmc = VNMC_IM_FULL;
> + break;
> + case V4L2_FIELD_INTERLACED_BT:
> + vnmc = VNMC_IM_FULL | VNMC_FOC;
> + break;
> + case V4L2_FIELD_NONE:
> + if (is_continuous_transfer(priv)) {
> + vnmc = VNMC_IM_ODD_EVEN;
> + progressive = true;
> + } else {
> + vnmc = VNMC_IM_ODD;
> + }
> + break;
> + default:
> + vnmc = VNMC_IM_ODD;
> + break;
> + }
> +
> + /* input interface */
> + switch (icd->current_fmt->code) {
> + case V4L2_MBUS_FMT_YUYV8_1X16:
> + /* BT.601/BT.1358 16bit YCbCr422 */
> + vnmc |= VNMC_INF_YUV16;
> + break;
> + case V4L2_MBUS_FMT_YUYV8_2X8:
> + /* BT.656 8bit YCbCr422 or BT.601 8bit YCbCr422 */
> + vnmc |= priv->pdata->flags & RCAR_VIN_BT656 ?
> + VNMC_INF_YUV8_BT656 : VNMC_INF_YUV8_BT601;
> + default:
> + break;
> + }
> +
> + /* output format */
> + switch (icd->current_fmt->host_fmt->fourcc) {
> + case V4L2_PIX_FMT_NV16:
> + iowrite32(ALIGN(cam->width * cam->height, 0x80),
> + priv->base + VNUVAOF_REG);
> + dmr = VNDMR_DTMD_YCSEP;
> + output_is_yuv = true;
> + break;
> + case V4L2_PIX_FMT_YUYV:
> + dmr = VNDMR_BPSM;
> + output_is_yuv = true;
> + break;
> + case V4L2_PIX_FMT_UYVY:
> + dmr = 0;
> + output_is_yuv = true;
> + break;
> + case V4L2_PIX_FMT_RGB555X:
> + dmr = VNDMR_DTMD_ARGB1555;
> + break;
> + case V4L2_PIX_FMT_RGB565:
> + dmr = 0;
> + break;
> + case V4L2_PIX_FMT_RGB32:
> + if (priv->chip == RCAR_H1 || priv->chip == RCAR_E1) {
> + dmr = VNDMR_EXRGB;
> + break;
> + }
> + default:
> + dev_warn(icd->parent, "Invalid fourcc format (0x%x)\n",
> + icd->current_fmt->host_fmt->fourcc);
I'll put a marker here for now: I don't understand the logic - either you
don't support this case, then you should either fail somehow or switch to
a supported case, or you do support it, then you don't need a warning
[snip]
> +static void rcar_vin_videobuf_queue(struct vb2_buffer *vb)
> +{
> + struct soc_camera_device *icd = soc_camera_from_vb2q(vb->vb2_queue);
> + struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
> + struct rcar_vin_priv *priv = ici->priv;
> + unsigned long size;
> + int bytes_per_line;
> +
> + bytes_per_line = soc_mbus_bytes_per_line(icd->user_width,
> + icd->current_fmt->host_fmt);
> + if (bytes_per_line < 0)
> + goto error;
> +
> + size = icd->user_height * bytes_per_line;
You haven't fixed this
[snip]
> +static irqreturn_t rcar_vin_irq(int irq, void *data)
> +{
> + struct rcar_vin_priv *priv = data;
> + u32 int_status;
> + bool can_run = false, hw_stopped;
> + int slot;
> + unsigned int handled = 0;
> +
> + spin_lock(&priv->lock);
> +
> + int_status = ioread32(priv->base + VNINTS_REG);
> + if (!int_status)
> + goto done;
> + /* ack interrupts */
> + iowrite32(int_status, priv->base + VNINTS_REG);
> + handled = 1;
> +
> + /* nothing to do if capture status is 'STOPPED' */
> + if (priv->state == STOPPED)
> + goto done;
> +
> + hw_stopped = !(ioread32(priv->base + VNMS_REG) & VNMS_CA);
> +
> + if (!priv->request_to_stop) {
> + if (is_continuous_transfer(priv))
> + slot = (ioread32(priv->base + VNMS_REG) &
> + VNMS_FBS_MASK) >> VNMS_FBS_SHIFT;
> + else
> + slot = 0;
> +
> + priv->queue_buf[slot]->v4l2_buf.field = priv->field;
> + priv->queue_buf[slot]->v4l2_buf.sequence = priv->sequence++;
> + do_gettimeofday(&priv->queue_buf[slot]->v4l2_buf.timestamp);
> + vb2_buffer_done(priv->queue_buf[slot], VB2_BUF_STATE_DONE);
> + priv->queue_buf[slot] = NULL;
> +
> + if (priv->state != STOPPING)
> + can_run = rcar_vin_fill_hw_slot(priv);
> +
> + if (hw_stopped || !can_run) {
> + priv->state = STOPPED;
> + } else if (is_continuous_transfer(priv) &&
> + list_empty(&priv->capture) &&
> + priv->state == RUNNING) {
> + /*
> + * The continuous capturing requires an explicit stop
> + * operation when there is no buffer to be set into
> + * the VnMBm registers.
> + */
> + rcar_vin_request_capture_stop(priv);
> + } else {
> + rcar_vin_capture(priv);
> + }
You don't need braces here
> +
> + } else if (hw_stopped) {
> + priv->state = STOPPED;
> + priv->request_to_stop = false;
> + complete(&priv->capture_stop);
> + }
> +
> +done:
> + spin_unlock(&priv->lock);
> +
> + return IRQ_RETVAL(handled);
> +}
> +
> +static int rcar_vin_add_device(struct soc_camera_device *icd)
> +{
> + struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
> + struct rcar_vin_priv *priv = ici->priv;
> + int i;
> +
> + if (priv->icd)
> + return -EBUSY;
> +
> + for (i = 0; i < MAX_BUFFER_NUM; i++)
> + priv->queue_buf[i] = NULL;
> +
> + pm_runtime_get_sync(ici->v4l2_dev.dev);
> + priv->icd = icd;
> +
> + dev_dbg(icd->parent, "R-Car VIN driver attached to camera %d\n",
> + icd->devnum);
> +
> + return 0;
> +}
> +
> +static void rcar_vin_remove_device(struct soc_camera_device *icd)
> +{
> + struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
> + struct rcar_vin_priv *priv = ici->priv;
> + struct vb2_buffer *vb;
> + int i;
> +
> + if (icd != priv->icd) {
> + WARN_ON(1);
> + return;
> + }
Make it
if (WARN_ON(icd != priv->icd))
return;
> +
> + /* disable capture, disable interrupts */
> + iowrite32(ioread32(priv->base + VNMC_REG) & ~VNMC_ME,
> + priv->base + VNMC_REG);
> + iowrite32(0, priv->base + VNIE_REG);
> +
> + priv->state = STOPPED;
> + priv->request_to_stop = false;
> +
> + /* make sure active buffer is cancelled */
> + spin_lock_irq(&priv->lock);
> + for (i = 0; i < MAX_BUFFER_NUM; i++) {
> + vb = priv->queue_buf[i];
> + if (vb) {
> + list_del_init(to_buf_list(vb));
> + vb2_buffer_done(vb, VB2_BUF_STATE_ERROR);
> + vb = NULL;
I asked to remove this assignment in my previous review
[snip]
> +static const struct soc_mbus_pixelfmt rcar_vin_formats[] = {
> + {
> + .fourcc = V4L2_PIX_FMT_NV16,
> + .name = "NV16",
> + .bits_per_sample = 16,
> + .packing = SOC_MBUS_PACKING_NONE,
> + .order = SOC_MBUS_ORDER_LE,
> + .layout = SOC_MBUS_LAYOUT_PACKED,
This should be SOC_MBUS_LAYOUT_PLANAR_Y_C
> + },
> + {
> + .fourcc = V4L2_PIX_FMT_UYVY,
> + .name = "UYVY",
> + .bits_per_sample = 16,
> + .packing = SOC_MBUS_PACKING_NONE,
> + .order = SOC_MBUS_ORDER_LE,
> + .layout = SOC_MBUS_LAYOUT_PACKED,
> + },
> + {
> + .fourcc = V4L2_PIX_FMT_RGB565,
> + .name = "RGB565",
> + .bits_per_sample = 16,
> + .packing = SOC_MBUS_PACKING_NONE,
> + .order = SOC_MBUS_ORDER_LE,
> + .layout = SOC_MBUS_LAYOUT_PACKED,
> + },
> + {
> + .fourcc = V4L2_PIX_FMT_RGB555X,
> + .name = "ARGB1555",
> + .bits_per_sample = 16,
> + .packing = SOC_MBUS_PACKING_NONE,
> + .order = SOC_MBUS_ORDER_LE,
> + .layout = SOC_MBUS_LAYOUT_PACKED,
> + },
> + {
> + .fourcc = V4L2_PIX_FMT_RGB32,
> + .name = "RGB888",
> + .bits_per_sample = 32,
> + .packing = SOC_MBUS_PACKING_NONE,
> + .order = SOC_MBUS_ORDER_LE,
> + .layout = SOC_MBUS_LAYOUT_PACKED,
> + },
> +};
> +
> +static int rcar_vin_get_formats(struct soc_camera_device *icd, unsigned int idx,
> + struct soc_camera_format_xlate *xlate)
> +{
> + struct v4l2_subdev *sd = soc_camera_to_subdev(icd);
> + struct device *dev = icd->parent;
> + int ret, k, n;
> + int formats = 0;
> + struct rcar_vin_cam *cam;
> + enum v4l2_mbus_pixelcode code;
> + const struct soc_mbus_pixelfmt *fmt;
> +
> + ret = v4l2_subdev_call(sd, video, enum_mbus_fmt, idx, &code);
> + if (ret < 0)
> + return 0;
> +
> + fmt = soc_mbus_get_fmtdesc(code);
> + if (!fmt) {
> + dev_warn(dev, "unsupported format code #%u: %d\n", idx, code);
> + return 0;
> + }
> +
> + ret = rcar_vin_try_bus_param(icd, fmt->bits_per_sample);
> + if (ret < 0)
> + return 0;
> +
> + if (!icd->host_priv) {
> + struct v4l2_mbus_framefmt mf;
> + struct v4l2_rect rect;
> + struct device *dev = icd->parent;
> + int shift;
> +
> + ret = v4l2_subdev_call(sd, video, g_mbus_fmt, &mf);
> + if (ret < 0)
> + return ret;
> +
> + /* Cache current client geometry */
> + ret = soc_camera_client_g_rect(sd, &rect);
> + if (ret < 0) {
> + /* Sensor driver doesn't support cropping */
I don't think it's right. soc_camera_client_g_rect() should only return an
error, if the subdevice driver implements g_crop or cropcap and returns an
error from them. If those methods are just unimplemented, you get a 0
back. Do you see anything different?
> + rect.left = 0;
> + rect.top = 0;
> + rect.width = mf.width;
> + rect.height = mf.height;
> + }
> +
> + /*
> + * If sensor proposes too large format then try smaller ones:
> + * 1280x960, 640x480, 320x240
> + */
> + for (shift = 0; shift < 3; shift++) {
> + if (mf.width <= VIN_MAX_WIDTH &&
> + mf.height <= VIN_MAX_HEIGHT)
> + break;
> +
> + mf.width = 1280 >> shift;
> + mf.height = 960 >> shift;
> + ret = v4l2_device_call_until_err(sd->v4l2_dev,
> + soc_camera_grp_id(icd),
> + video, s_mbus_fmt,
> + &mf);
> + if (ret < 0)
> + return ret;
> + }
> +
> + if (shift == 3) {
> + dev_err(dev,
> + "Failed to configure the client below %ux%x\n",
> + mf.width, mf.height);
> + return -EIO;
> + }
> +
> + dev_dbg(dev, "camera fmt %ux%u\n", mf.width, mf.height);
> +
> + cam = kzalloc(sizeof(*cam), GFP_KERNEL);
> + if (!cam)
> + return -ENOMEM;
> + /*
> + * We are called with current camera crop,
> + * initialise subrect with it
> + */
> + cam->rect = rect;
> + cam->subrect = rect;
> + cam->width = mf.width;
> + cam->height = mf.height;
> +
> + icd->host_priv = cam;
> + } else {
> + cam = icd->host_priv;
> + }
> +
> + /* Beginning of a pass */
> + if (!idx)
> + cam->extra_fmt = NULL;
> +
> + switch (code) {
> + case V4L2_MBUS_FMT_YUYV8_1X16:
> + case V4L2_MBUS_FMT_YUYV8_2X8:
> + if (cam->extra_fmt)
> + break;
> +
> + /* Add all our formats that can be generated by VIN */
> + cam->extra_fmt = rcar_vin_formats;
> +
> + n = ARRAY_SIZE(rcar_vin_formats);
> + formats += n;
> + for (k = 0; xlate && k < n; k++, xlate++) {
> + xlate->host_fmt = &rcar_vin_formats[k];
> + xlate->code = code;
> + dev_dbg(dev, "Providing format %s using code %d\n",
> + rcar_vin_formats[k].name, code);
> + }
> + break;
> + default:
> + if (!rcar_vin_packing_supported(fmt))
> + return 0;
> +
> + dev_dbg(dev, "Providing format %s in pass-through mode\n",
> + fmt->name);
> + break;
Ok, you added pass-through...
> + }
> +
> + /* Generic pass-through */
> + formats++;
> + if (xlate) {
> + xlate->host_fmt = fmt;
> + xlate->code = code;
> + xlate++;
> + }
> +
> + return formats;
> +}
[snip]
> +/* Similar to set_crop multistage iterative algorithm */
> +static int rcar_vin_set_fmt(struct soc_camera_device *icd,
> + struct v4l2_format *f)
> +{
> + struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
> + struct rcar_vin_priv *priv = ici->priv;
> + struct v4l2_subdev *sd = soc_camera_to_subdev(icd);
> + struct rcar_vin_cam *cam = icd->host_priv;
> + struct v4l2_pix_format *pix = &f->fmt.pix;
> + struct v4l2_mbus_framefmt mf;
> + struct device *dev = icd->parent;
> + __u32 pixfmt = pix->pixelformat;
> + const struct soc_camera_format_xlate *xlate;
> + unsigned int vin_sub_width = 0, vin_sub_height = 0;
> + int ret;
> + bool can_scale;
> + enum v4l2_field field;
> + v4l2_std_id std;
> +
> + dev_dbg(dev, "S_FMT(pix=0x%x, %ux%u)\n",
> + pixfmt, pix->width, pix->height);
> +
> + switch (pix->field) {
> + default:
> + pix->field = V4L2_FIELD_NONE;
> + /* fall-through */
> + case V4L2_FIELD_NONE:
> + case V4L2_FIELD_TOP:
> + case V4L2_FIELD_BOTTOM:
> + case V4L2_FIELD_INTERLACED_TB:
> + case V4L2_FIELD_INTERLACED_BT:
> + field = pix->field;
> + break;
> + case V4L2_FIELD_INTERLACED:
> + /* Query for standard if not explicitly mentioned _TB/_BT */
> + ret = v4l2_subdev_call(sd, video, querystd, &std);
> + if (ret < 0)
> + std = V4L2_STD_625_50;
> +
> + field = std & V4L2_STD_625_50 ? V4L2_FIELD_INTERLACED_TB :
> + V4L2_FIELD_INTERLACED_BT;
> + break;
> + }
> +
> + xlate = soc_camera_xlate_by_fourcc(icd, pixfmt);
> + if (!xlate) {
> + dev_warn(dev, "Format %x not found\n", pixfmt);
> + return -EINVAL;
> + }
> + /* Calculate client output geometry */
> + soc_camera_calc_client_output(icd, &cam->rect, &cam->subrect, pix, &mf, 12);
> + mf.field = pix->field;
> + mf.colorspace = pix->colorspace;
> + mf.code = xlate->code;
> +
> + switch (pixfmt) {
> + case V4L2_PIX_FMT_NV16:
> + can_scale = false;
> + break;
> + case V4L2_PIX_FMT_RGB32:
> + can_scale = priv->chip != RCAR_E1;
> + break;
> + default:
> + can_scale = true;
You also get here in the pass-through mode, right? I don't think you can
scale then.
> + break;
> + }
> +
> + dev_dbg(dev, "request camera output %ux%u\n", mf.width, mf.height);
> +
> + ret = soc_camera_client_scale(icd, &cam->rect, &cam->subrect,
> + &mf, &vin_sub_width, &vin_sub_height,
> + can_scale, 12);
> +
> + /* Done with the camera. Now see if we can improve the result */
> + dev_dbg(dev, "Camera %d fmt %ux%u, requested %ux%u\n",
> + ret, mf.width, mf.height, pix->width, pix->height);
> +
> + if (ret < 0)
> + dev_dbg(dev, "Sensor doesn't support cropping\n");
Are you sure this print is correct?
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver
2013-06-13 13:12 ` Guennadi Liakhovetski
@ 2013-06-21 0:50 ` Vladimir Barinov
2013-06-21 20:08 ` Sergei Shtylyov
1 sibling, 0 replies; 26+ messages in thread
From: Vladimir Barinov @ 2013-06-21 0:50 UTC (permalink / raw)
To: Guennadi Liakhovetski
Cc: Sergei Shtylyov, mchehab, linux-media, magnus.damm, linux-sh,
phil.edworthy, matsu
Hi Guennadi,
Sorry for the response delay and thank you for new review.
Guennadi Liakhovetski wrote:
>> + /* output format */
>> + switch (icd->current_fmt->host_fmt->fourcc) {
>> + case V4L2_PIX_FMT_NV16:
>> + iowrite32(ALIGN(cam->width * cam->height, 0x80),
>> + priv->base + VNUVAOF_REG);
>> + dmr = VNDMR_DTMD_YCSEP;
>> + output_is_yuv = true;
>> + break;
>> + case V4L2_PIX_FMT_YUYV:
>> + dmr = VNDMR_BPSM;
>> + output_is_yuv = true;
>> + break;
>> + case V4L2_PIX_FMT_UYVY:
>> + dmr = 0;
>> + output_is_yuv = true;
>> + break;
>> + case V4L2_PIX_FMT_RGB555X:
>> + dmr = VNDMR_DTMD_ARGB1555;
>> + break;
>> + case V4L2_PIX_FMT_RGB565:
>> + dmr = 0;
>> + break;
>> + case V4L2_PIX_FMT_RGB32:
>> + if (priv->chip == RCAR_H1 || priv->chip == RCAR_E1) {
>> + dmr = VNDMR_EXRGB;
>> + break;
>> + }
>> + default:
>> + dev_warn(icd->parent, "Invalid fourcc format (0x%x)\n",
>> + icd->current_fmt->host_fmt->fourcc);
>>
>
> I'll put a marker here for now: I don't understand the logic - either you
> don't support this case, then you should either fail somehow or switch to
> a supported case, or you do support it, then you don't need a warning
>
Yes, the default case is not supported.
Don't you think the current logic should be replaced with BUG() callback?
> [snip]
>
>
>> +static void rcar_vin_videobuf_queue(struct vb2_buffer *vb)
>> +{
>> + struct soc_camera_device *icd = soc_camera_from_vb2q(vb->vb2_queue);
>> + struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
>> + struct rcar_vin_priv *priv = ici->priv;
>> + unsigned long size;
>> + int bytes_per_line;
>> +
>> + bytes_per_line = soc_mbus_bytes_per_line(icd->user_width,
>> + icd->current_fmt->host_fmt);
>> + if (bytes_per_line < 0)
>> + goto error;
>> +
>> + size = icd->user_height * bytes_per_line;
>>
>
> You haven't fixed this
>
Sorry for the miss. Will replace with icd->sizeimage.
>> +static const struct soc_mbus_pixelfmt rcar_vin_formats[] = {
>> + {
>> + .fourcc = V4L2_PIX_FMT_NV16,
>> + .name = "NV16",
>> + .bits_per_sample = 16,
>> + .packing = SOC_MBUS_PACKING_NONE,
>> + .order = SOC_MBUS_ORDER_LE,
>> + .layout = SOC_MBUS_LAYOUT_PACKED,
>>
>
> This should be SOC_MBUS_LAYOUT_PLANAR_Y_C
>
Shouldn't the ".packing" be changed here to SOC_MBUS_PACKING_2X8_PADHI ?
>> + if (!icd->host_priv) {
>> + struct v4l2_mbus_framefmt mf;
>> + struct v4l2_rect rect;
>> + struct device *dev = icd->parent;
>> + int shift;
>> +
>> + ret = v4l2_subdev_call(sd, video, g_mbus_fmt, &mf);
>> + if (ret < 0)
>> + return ret;
>> +
>> + /* Cache current client geometry */
>> + ret = soc_camera_client_g_rect(sd, &rect);
>> + if (ret < 0) {
>> + /* Sensor driver doesn't support cropping */
>>
>
> I don't think it's right. soc_camera_client_g_rect() should only return an
> error, if the subdevice driver implements g_crop or cropcap and returns an
> error from them. If those methods are just unimplemented, you get a 0
> back. Do you see anything different?
>
No.
In case the subdevice drivers does not implement cropping (i.e there is
no both methods g_crop and cropcap) then the return value is -ENOIOCTLCMD.
Don't you suggest to continue for (ret == -ENOIOCTLCMD) and return for
other (ret < 0) ?
>> + switch (pixfmt) {
>> + case V4L2_PIX_FMT_NV16:
>> + can_scale = false;
>> + break;
>> + case V4L2_PIX_FMT_RGB32:
>> + can_scale = priv->chip != RCAR_E1;
>> + break;
>> + default:
>> + can_scale = true;
>>
>
> You also get here in the pass-through mode, right? I don't think you can
> scale then.
>
Yes, thank you for pointing to this. I will add only supported formats
for scaling capability.
>
>> + break;
>> + }
>> +
>> + dev_dbg(dev, "request camera output %ux%u\n", mf.width, mf.height);
>> +
>> + ret = soc_camera_client_scale(icd, &cam->rect, &cam->subrect,
>> + &mf, &vin_sub_width, &vin_sub_height,
>> + can_scale, 12);
>> +
>> + /* Done with the camera. Now see if we can improve the result */
>> + dev_dbg(dev, "Camera %d fmt %ux%u, requested %ux%u\n",
>> + ret, mf.width, mf.height, pix->width, pix->height);
>> +
>> + if (ret < 0)
>> + dev_dbg(dev, "Sensor doesn't support cropping\n");
>>
>
> Are you sure this print is correct?
>
Probably it should be the same like above for the case if subdevice
driver does not support cropping (see soc_scale_crop.c -> client_s_fmt() ).
Regards,
Vladimir
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver
2013-05-23 22:11 [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver Sergei Shtylyov
2013-06-02 18:56 ` Sergei Shtylyov
2013-06-13 13:12 ` Guennadi Liakhovetski
@ 2013-06-21 4:46 ` Katsuya MATSUBARA
2013-06-21 8:06 ` Vladimir Barinov
2 siblings, 1 reply; 26+ messages in thread
From: Katsuya MATSUBARA @ 2013-06-21 4:46 UTC (permalink / raw)
To: sergei.shtylyov
Cc: g.liakhovetski, mchehab, linux-media, magnus.damm, linux-sh,
phil.edworthy, vladimir.barinov
Hi Sergei and Valadmir,
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Fri, 24 May 2013 02:11:28 +0400
(snip)
> +/* Similar to set_crop multistage iterative algorithm */
> +static int rcar_vin_set_fmt(struct soc_camera_device *icd,
> + struct v4l2_format *f)
> +{
> + struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
> + struct rcar_vin_priv *priv = ici->priv;
> + struct v4l2_subdev *sd = soc_camera_to_subdev(icd);
> + struct rcar_vin_cam *cam = icd->host_priv;
> + struct v4l2_pix_format *pix = &f->fmt.pix;
> + struct v4l2_mbus_framefmt mf;
> + struct device *dev = icd->parent;
> + __u32 pixfmt = pix->pixelformat;
> + const struct soc_camera_format_xlate *xlate;
> + unsigned int vin_sub_width = 0, vin_sub_height = 0;
> + int ret;
> + bool can_scale;
> + enum v4l2_field field;
> + v4l2_std_id std;
> +
> + dev_dbg(dev, "S_FMT(pix=0x%x, %ux%u)\n",
> + pixfmt, pix->width, pix->height);
> +
> + switch (pix->field) {
> + default:
> + pix->field = V4L2_FIELD_NONE;
> + /* fall-through */
> + case V4L2_FIELD_NONE:
> + case V4L2_FIELD_TOP:
> + case V4L2_FIELD_BOTTOM:
> + case V4L2_FIELD_INTERLACED_TB:
> + case V4L2_FIELD_INTERLACED_BT:
> + field = pix->field;
> + break;
> + case V4L2_FIELD_INTERLACED:
> + /* Query for standard if not explicitly mentioned _TB/_BT */
> + ret = v4l2_subdev_call(sd, video, querystd, &std);
> + if (ret < 0)
> + std = V4L2_STD_625_50;
> +
> + field = std & V4L2_STD_625_50 ? V4L2_FIELD_INTERLACED_TB :
> + V4L2_FIELD_INTERLACED_BT;
> + break;
> + }
I have tested your VIN driver with NTSC video input
with the following two boards;
1. Marzen (R-CarH1 SoC and ADV7180 video decoder)
2. BOCK-W (R-CarM1A SoC and ML86V7667 video decoder)
As a result, I have got strange captured images in the BOCK-W
environment. The image looks that the top and bottom fields
have been combined in wrong order.
However, in case of Marzen, it works fine with correct images
captured. I made sure that the driver chose the
V4L2_FIELD_INTERLACED_BT flag for the NTSC standard video
in the both environments.
Have you seen such an iusse with the ML86V7667 driver?
I think there may be some mismatch between the VIN
and the ML86V7667 settings.
Thanks,
---
Katsuya Matsubara / IGEL Co., Ltd
matsu@igel.co.jp
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver
2013-06-21 4:46 ` Katsuya MATSUBARA
@ 2013-06-21 8:06 ` Vladimir Barinov
2013-06-21 9:09 ` Katsuya MATSUBARA
0 siblings, 1 reply; 26+ messages in thread
From: Vladimir Barinov @ 2013-06-21 8:06 UTC (permalink / raw)
To: Katsuya MATSUBARA
Cc: sergei.shtylyov, g.liakhovetski, mchehab, linux-media,
magnus.damm, linux-sh, phil.edworthy
Hi Matsubara-san,
Katsuya MATSUBARA wrote:
> Hi Sergei and Valadmir,
>
> From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Date: Fri, 24 May 2013 02:11:28 +0400
>
> (snip)
>
>> +/* Similar to set_crop multistage iterative algorithm */
>> +static int rcar_vin_set_fmt(struct soc_camera_device *icd,
>> + struct v4l2_format *f)
>> +{
>> + struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
>> + struct rcar_vin_priv *priv = ici->priv;
>> + struct v4l2_subdev *sd = soc_camera_to_subdev(icd);
>> + struct rcar_vin_cam *cam = icd->host_priv;
>> + struct v4l2_pix_format *pix = &f->fmt.pix;
>> + struct v4l2_mbus_framefmt mf;
>> + struct device *dev = icd->parent;
>> + __u32 pixfmt = pix->pixelformat;
>> + const struct soc_camera_format_xlate *xlate;
>> + unsigned int vin_sub_width = 0, vin_sub_height = 0;
>> + int ret;
>> + bool can_scale;
>> + enum v4l2_field field;
>> + v4l2_std_id std;
>> +
>> + dev_dbg(dev, "S_FMT(pix=0x%x, %ux%u)\n",
>> + pixfmt, pix->width, pix->height);
>> +
>> + switch (pix->field) {
>> + default:
>> + pix->field = V4L2_FIELD_NONE;
>> + /* fall-through */
>> + case V4L2_FIELD_NONE:
>> + case V4L2_FIELD_TOP:
>> + case V4L2_FIELD_BOTTOM:
>> + case V4L2_FIELD_INTERLACED_TB:
>> + case V4L2_FIELD_INTERLACED_BT:
>> + field = pix->field;
>> + break;
>> + case V4L2_FIELD_INTERLACED:
>> + /* Query for standard if not explicitly mentioned _TB/_BT */
>> + ret = v4l2_subdev_call(sd, video, querystd, &std);
>> + if (ret < 0)
>> + std = V4L2_STD_625_50;
>> +
>> + field = std & V4L2_STD_625_50 ? V4L2_FIELD_INTERLACED_TB :
>> + V4L2_FIELD_INTERLACED_BT;
>> + break;
>> + }
>>
>
> I have tested your VIN driver with NTSC video input
> with the following two boards;
>
> 1. Marzen (R-CarH1 SoC and ADV7180 video decoder)
> 2. BOCK-W (R-CarM1A SoC and ML86V7667 video decoder)
>
> As a result, I have got strange captured images in the BOCK-W
> environment. The image looks that the top and bottom fields
> have been combined in wrong order.
> However, in case of Marzen, it works fine with correct images
> captured. I made sure that the driver chose the
> V4L2_FIELD_INTERLACED_BT flag for the NTSC standard video
> in the both environments.
>
> Have you seen such an iusse with the ML86V7667 driver?
> I think there may be some mismatch between the VIN
> and the ML86V7667 settings.
>
Unfortunately, I had ability to test decoder only with PAL camera. And
I've made the fake tests for NTSC standard reported by video decoders to
validate the difference on captured image.
The interlace on bock-w was correct for PAL standard in accordance to
above tests.
I have been able to see incorrect mix up of _TB/_BT only in case of i2c
transaction fails during subdevice V4L2_STD runtime query.
Thank you for the valuable report.
I will try to get the NTSC camera to continue with your finding.
Regards,
Vladimir
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver
2013-06-21 8:06 ` Vladimir Barinov
@ 2013-06-21 9:09 ` Katsuya MATSUBARA
2013-06-21 9:39 ` Vladimir Barinov
0 siblings, 1 reply; 26+ messages in thread
From: Katsuya MATSUBARA @ 2013-06-21 9:09 UTC (permalink / raw)
To: vladimir.barinov
Cc: sergei.shtylyov, g.liakhovetski, mchehab, linux-media,
magnus.damm, linux-sh, phil.edworthy
Hi Vladimir,
From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Date: Fri, 21 Jun 2013 12:06:12 +0400
> Hi Matsubara-san,
>
> Katsuya MATSUBARA wrote:
>> Hi Sergei and Valadmir,
>>
>> From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> Date: Fri, 24 May 2013 02:11:28 +0400
>>
>> (snip)
>>
>>> +/* Similar to set_crop multistage iterative algorithm */
>>> +static int rcar_vin_set_fmt(struct soc_camera_device *icd,
>>> + struct v4l2_format *f)
>>> +{
>>> + struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
>>> + struct rcar_vin_priv *priv = ici->priv;
>>> + struct v4l2_subdev *sd = soc_camera_to_subdev(icd);
>>> + struct rcar_vin_cam *cam = icd->host_priv;
>>> + struct v4l2_pix_format *pix = &f->fmt.pix;
>>> + struct v4l2_mbus_framefmt mf;
>>> + struct device *dev = icd->parent;
>>> + __u32 pixfmt = pix->pixelformat;
>>> + const struct soc_camera_format_xlate *xlate;
>>> + unsigned int vin_sub_width = 0, vin_sub_height = 0;
>>> + int ret;
>>> + bool can_scale;
>>> + enum v4l2_field field;
>>> + v4l2_std_id std;
>>> +
>>> + dev_dbg(dev, "S_FMT(pix=0x%x, %ux%u)\n",
>>> + pixfmt, pix->width, pix->height);
>>> +
>>> + switch (pix->field) {
>>> + default:
>>> + pix->field = V4L2_FIELD_NONE;
>>> + /* fall-through */
>>> + case V4L2_FIELD_NONE:
>>> + case V4L2_FIELD_TOP:
>>> + case V4L2_FIELD_BOTTOM:
>>> + case V4L2_FIELD_INTERLACED_TB:
>>> + case V4L2_FIELD_INTERLACED_BT:
>>> + field = pix->field;
>>> + break;
>>> + case V4L2_FIELD_INTERLACED:
>>> + /* Query for standard if not explicitly mentioned _TB/_BT */
>>> + ret = v4l2_subdev_call(sd, video, querystd, &std);
>>> + if (ret < 0)
>>> + std = V4L2_STD_625_50;
>>> +
>>> + field = std & V4L2_STD_625_50 ? V4L2_FIELD_INTERLACED_TB :
>>> + V4L2_FIELD_INTERLACED_BT;
>>> + break;
>>> + }
>>>
>>
>> I have tested your VIN driver with NTSC video input
>> with the following two boards;
>>
>> 1. Marzen (R-CarH1 SoC and ADV7180 video decoder)
>> 2. BOCK-W (R-CarM1A SoC and ML86V7667 video decoder)
>>
>> As a result, I have got strange captured images in the BOCK-W
>> environment. The image looks that the top and bottom fields
>> have been combined in wrong order.
>> However, in case of Marzen, it works fine with correct images
>> captured. I made sure that the driver chose the
>> V4L2_FIELD_INTERLACED_BT flag for the NTSC standard video
>> in the both environments.
>>
>> Have you seen such an iusse with the ML86V7667 driver?
>> I think there may be some mismatch between the VIN
>> and the ML86V7667 settings.
>>
> Unfortunately, I had ability to test decoder only with PAL camera. And
> I've made the fake tests for NTSC standard reported by video decoders
> to validate the difference on captured image.
> The interlace on bock-w was correct for PAL standard in accordance to
> above tests.
>
> I have been able to see incorrect mix up of _TB/_BT only in case of
> i2c transaction fails during subdevice V4L2_STD runtime query.
I have slightly investigated the issue on bock-w.
I have not seen such i2c errors during capturing and booting.
But I have seen that querystd() in the ml86v7667 driver often
returns V4L2_STD_UNKNOWN, although the corresponding function
in the adv7180 driver always returns V4L2_STD_525_60 for NTSC video.
The driver also chose '_BT' for V4L2_STD_UNKNOWN, so even in this
case the display should be fine for NTSC video.
I have confirmed that the driver always selects '_BT' for NTSC
video even if I repeat it several times in my environment.
Thanks,
---
Katsuya Matsubara / IGEL Co., Ltd
matsu@igel.co.jp
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver
2013-06-21 9:09 ` Katsuya MATSUBARA
@ 2013-06-21 9:39 ` Vladimir Barinov
2013-06-21 10:01 ` Katsuya MATSUBARA
0 siblings, 1 reply; 26+ messages in thread
From: Vladimir Barinov @ 2013-06-21 9:39 UTC (permalink / raw)
To: Katsuya MATSUBARA
Cc: sergei.shtylyov, g.liakhovetski, mchehab, linux-media,
magnus.damm, linux-sh, phil.edworthy
Hi Matsubara-san,
Katsuya MATSUBARA wrote:
> Hi Vladimir,
>
> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Date: Fri, 21 Jun 2013 12:06:12 +0400
>
>
>> Hi Matsubara-san,
>>
>> Katsuya MATSUBARA wrote:
>>
>>> Hi Sergei and Valadmir,
>>>
>>> From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>> Date: Fri, 24 May 2013 02:11:28 +0400
>>>
>>> (snip)
>>>
>>>
>>>> +/* Similar to set_crop multistage iterative algorithm */
>>>> +static int rcar_vin_set_fmt(struct soc_camera_device *icd,
>>>> + struct v4l2_format *f)
>>>> +{
>>>> + struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
>>>> + struct rcar_vin_priv *priv = ici->priv;
>>>> + struct v4l2_subdev *sd = soc_camera_to_subdev(icd);
>>>> + struct rcar_vin_cam *cam = icd->host_priv;
>>>> + struct v4l2_pix_format *pix = &f->fmt.pix;
>>>> + struct v4l2_mbus_framefmt mf;
>>>> + struct device *dev = icd->parent;
>>>> + __u32 pixfmt = pix->pixelformat;
>>>> + const struct soc_camera_format_xlate *xlate;
>>>> + unsigned int vin_sub_width = 0, vin_sub_height = 0;
>>>> + int ret;
>>>> + bool can_scale;
>>>> + enum v4l2_field field;
>>>> + v4l2_std_id std;
>>>> +
>>>> + dev_dbg(dev, "S_FMT(pix=0x%x, %ux%u)\n",
>>>> + pixfmt, pix->width, pix->height);
>>>> +
>>>> + switch (pix->field) {
>>>> + default:
>>>> + pix->field = V4L2_FIELD_NONE;
>>>> + /* fall-through */
>>>> + case V4L2_FIELD_NONE:
>>>> + case V4L2_FIELD_TOP:
>>>> + case V4L2_FIELD_BOTTOM:
>>>> + case V4L2_FIELD_INTERLACED_TB:
>>>> + case V4L2_FIELD_INTERLACED_BT:
>>>> + field = pix->field;
>>>> + break;
>>>> + case V4L2_FIELD_INTERLACED:
>>>> + /* Query for standard if not explicitly mentioned _TB/_BT */
>>>> + ret = v4l2_subdev_call(sd, video, querystd, &std);
>>>> + if (ret < 0)
>>>> + std = V4L2_STD_625_50;
>>>> +
>>>> + field = std & V4L2_STD_625_50 ? V4L2_FIELD_INTERLACED_TB :
>>>> + V4L2_FIELD_INTERLACED_BT;
>>>> + break;
>>>> + }
>>>>
>>>>
>>> I have tested your VIN driver with NTSC video input
>>> with the following two boards;
>>>
>>> 1. Marzen (R-CarH1 SoC and ADV7180 video decoder)
>>> 2. BOCK-W (R-CarM1A SoC and ML86V7667 video decoder)
>>>
>>> As a result, I have got strange captured images in the BOCK-W
>>> environment. The image looks that the top and bottom fields
>>> have been combined in wrong order.
>>> However, in case of Marzen, it works fine with correct images
>>> captured. I made sure that the driver chose the
>>> V4L2_FIELD_INTERLACED_BT flag for the NTSC standard video
>>> in the both environments.
>>>
>>> Have you seen such an iusse with the ML86V7667 driver?
>>> I think there may be some mismatch between the VIN
>>> and the ML86V7667 settings.
>>>
>>>
>> Unfortunately, I had ability to test decoder only with PAL camera. And
>> I've made the fake tests for NTSC standard reported by video decoders
>> to validate the difference on captured image.
>> The interlace on bock-w was correct for PAL standard in accordance to
>> above tests.
>>
>> I have been able to see incorrect mix up of _TB/_BT only in case of
>> i2c transaction fails during subdevice V4L2_STD runtime query.
>>
>
> I have slightly investigated the issue on bock-w.
>
> I have not seen such i2c errors during capturing and booting.
> But I have seen that querystd() in the ml86v7667 driver often
> returns V4L2_STD_UNKNOWN, although the corresponding function
>
could you try Hans's fix:
https://patchwork.kernel.org/patch/2640701/
> in the adv7180 driver always returns V4L2_STD_525_60 for NTSC video.
> The driver also chose '_BT' for V4L2_STD_UNKNOWN, so even in this
> case the display should be fine for NTSC video.
> I have confirmed that the driver always selects '_BT' for NTSC
> video even if I repeat it several times in my environment.
>
> Thanks,
> ---
> Katsuya Matsubara / IGEL Co., Ltd
> matsu@igel.co.jp
>
>
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver
2013-06-21 9:39 ` Vladimir Barinov
@ 2013-06-21 10:01 ` Katsuya MATSUBARA
2013-06-21 10:32 ` Vladimir Barinov
0 siblings, 1 reply; 26+ messages in thread
From: Katsuya MATSUBARA @ 2013-06-21 10:01 UTC (permalink / raw)
To: vladimir.barinov
Cc: sergei.shtylyov, g.liakhovetski, mchehab, linux-media,
magnus.damm, linux-sh, phil.edworthy
Hi Vladimir,
From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Date: Fri, 21 Jun 2013 13:39:50 +0400
(snip)
>> I have not seen such i2c errors during capturing and booting.
>> But I have seen that querystd() in the ml86v7667 driver often
>> returns V4L2_STD_UNKNOWN, although the corresponding function
>>
> could you try Hans's fix:
> https://patchwork.kernel.org/patch/2640701/
The fix has been already applied in my environment.
Thanks,
---
Katsuya Matsubara / IGEL Co., Ltd
matsu@igel.co.jp
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver
2013-06-21 10:01 ` Katsuya MATSUBARA
@ 2013-06-21 10:32 ` Vladimir Barinov
2013-06-21 13:04 ` Katsuya MATSUBARA
0 siblings, 1 reply; 26+ messages in thread
From: Vladimir Barinov @ 2013-06-21 10:32 UTC (permalink / raw)
To: Katsuya MATSUBARA
Cc: sergei.shtylyov, g.liakhovetski, mchehab, linux-media,
magnus.damm, linux-sh, phil.edworthy
[-- Attachment #1: Type: text/plain, Size: 951 bytes --]
Katsuya MATSUBARA wrote:
> Hi Vladimir,
>
> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Date: Fri, 21 Jun 2013 13:39:50 +0400
>
> (snip)
>
>>> I have not seen such i2c errors during capturing and booting.
>>> But I have seen that querystd() in the ml86v7667 driver often
>>> returns V4L2_STD_UNKNOWN, although the corresponding function
>>>
>>>
>> could you try Hans's fix:
>> https://patchwork.kernel.org/patch/2640701/
>>
>
> The fix has been already applied in my environment.
>
I've found that after some iteration of submission we disabled the input
signal in autodetection in ml86v7667_init(). per recommendations.
That could be the case why the input signal is not locked.
On adv7180 it still has optional autodetection but Hans recommended to
get rid from runtime autodetection.
So I've added input signal detection only during boot time.
Could you please try the attached patch?
Regards,
Vladimir
[-- Attachment #2: 0054-ml86v7667_query_std_fix.patch --]
[-- Type: text/x-patch, Size: 1131 bytes --]
From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Subject: V4L2: decoder: ml86v7667: fix querystd
Input signal autodetection is disabled, hence the cached V4L2_STD must be used
Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
drivers/media/i2c/ml86v7667.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
Index: build/drivers/media/i2c/ml86v7667.c
===================================================================
--- build.orig/drivers/media/i2c/ml86v7667.c 2013-06-21 13:24:13.000000000 +0300
+++ build/drivers/media/i2c/ml86v7667.c 2013-06-21 13:26:07.308872980 +0300
@@ -162,17 +162,9 @@
static int ml86v7667_querystd(struct v4l2_subdev *sd, v4l2_std_id *std)
{
- struct i2c_client *client = v4l2_get_subdevdata(sd);
- int status;
+ struct ml86v7667_priv *priv = to_ml86v7667(sd);
- status = i2c_smbus_read_byte_data(client, STATUS_REG);
- if (status < 0)
- return status;
-
- if (status & STATUS_HLOCK_DETECT)
- *std &= status & STATUS_NTSCPAL ? V4L2_STD_625_50 : V4L2_STD_525_60;
- else
- *std = V4L2_STD_UNKNOWN;
+ *std = priv->std;
return 0;
}
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver
2013-06-21 10:32 ` Vladimir Barinov
@ 2013-06-21 13:04 ` Katsuya MATSUBARA
2013-06-22 11:45 ` Vladimir Barinov
0 siblings, 1 reply; 26+ messages in thread
From: Katsuya MATSUBARA @ 2013-06-21 13:04 UTC (permalink / raw)
To: vladimir.barinov
Cc: sergei.shtylyov, g.liakhovetski, mchehab, linux-media,
magnus.damm, linux-sh, phil.edworthy
Hi Vladimir,
From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Date: Fri, 21 Jun 2013 14:32:05 +0400
> Katsuya MATSUBARA wrote:
>> Hi Vladimir,
>>
>> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> Date: Fri, 21 Jun 2013 13:39:50 +0400
>>
>> (snip)
>>
>>>> I have not seen such i2c errors during capturing and booting.
>>>> But I have seen that querystd() in the ml86v7667 driver often
>>>> returns V4L2_STD_UNKNOWN, although the corresponding function
>>>>
>>> could you try Hans's fix:
>>> https://patchwork.kernel.org/patch/2640701/
>>>
>>
>> The fix has been already applied in my environment.
>>
> I've found that after some iteration of submission we disabled the
> input signal in autodetection in ml86v7667_init(). per
> recommendations.
> That could be the case why the input signal is not locked.
>
> On adv7180 it still has optional autodetection but Hans recommended to
> get rid from runtime autodetection.
> So I've added input signal detection only during boot time.
>
> Could you please try the attached patch?
With the patch, V4L2_STD_UNKNOWN often returned by querystd()
in the ml86v7667 driver has been gone.
But, captured images are still incorrect that means wrong
order of fields desite '_BT' chosen for V4L2_STD_525_60.
Thanks,
---
Katsuya Matsubara / IGEL Co., Ltd
matsu@igel.co.jp
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver
2013-06-13 13:12 ` Guennadi Liakhovetski
2013-06-21 0:50 ` Vladimir Barinov
@ 2013-06-21 20:08 ` Sergei Shtylyov
1 sibling, 0 replies; 26+ messages in thread
From: Sergei Shtylyov @ 2013-06-21 20:08 UTC (permalink / raw)
To: Guennadi Liakhovetski
Cc: mchehab, linux-media, magnus.damm, linux-sh, phil.edworthy,
matsu, vladimir.barinov
Hello.
On 06/13/2013 05:12 PM, Guennadi Liakhovetski wrote:
> Hi Sergei
> Patches, that this commit is based upon are hopefully moving towards the
> mainline, but it's still possible, that some more changes will be
> required. In any case, I wanted to comment to this version to let you
> prepare for a new version in advance.
> In general - looks better!
>> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> Add Renesas R-Car VIN (Video In) V4L2 driver.
>> Based on the patch by Phil Edworthy <phil.edworthy@renesas.com>.
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> [Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed 'enum chip_id'
>> values, reordered rcar_vin_id_table[] entries, removed senseless parens from
>> to_buf_list() macro, used ALIGN() macro in rcar_vin_setup(), added {} to the
>> *if* statement and used 'bool' values instead of 0/1 where necessary, removed
>> unused macros, done some reformatting and clarified some comments.]
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> ---
> [snip]
>> Index: media_tree/drivers/media/platform/soc_camera/rcar_vin.c
>> ===================================================================
>> --- /dev/null
>> +++ media_tree/drivers/media/platform/soc_camera/rcar_vin.c
[...]
>> +static irqreturn_t rcar_vin_irq(int irq, void *data)
>> +{
[...]
>> + if (hw_stopped || !can_run) {
>> + priv->state = STOPPED;
>> + } else if (is_continuous_transfer(priv) &&
>> + list_empty(&priv->capture) &&
>> + priv->state == RUNNING) {
>> + /*
>> + * The continuous capturing requires an explicit stop
>> + * operation when there is no buffer to be set into
>> + * the VnMBm registers.
>> + */
>> + rcar_vin_request_capture_stop(priv);
>> + } else {
>> + rcar_vin_capture(priv);
>> + }
> You don't need braces here
Did you mean only *else* branch or the whole *if statement? In both
cases, I disagree. Removing {} only from *else* contradicts do
Documenation/CodingStyle, removing them from the *if* branch too also
don't appeal to me as due to the comment inside the *if* branch. Sorry,
I'm leaving this as is.
WBR, Sergei
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver
2013-06-21 13:04 ` Katsuya MATSUBARA
@ 2013-06-22 11:45 ` Vladimir Barinov
2013-07-25 3:01 ` [PATCH v8] " Katsuya MATSUBARA
0 siblings, 1 reply; 26+ messages in thread
From: Vladimir Barinov @ 2013-06-22 11:45 UTC (permalink / raw)
To: Katsuya MATSUBARA
Cc: sergei.shtylyov, g.liakhovetski, mchehab, linux-media,
magnus.damm, linux-sh, phil.edworthy
Hi Matsubara-san,
Katsuya MATSUBARA wrote:
> Hi Vladimir,
>
> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Date: Fri, 21 Jun 2013 14:32:05 +0400
>
>
>> Katsuya MATSUBARA wrote:
>>
>>> Hi Vladimir,
>>>
>>> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>>> Date: Fri, 21 Jun 2013 13:39:50 +0400
>>>
>>> (snip)
>>>
>>>
>>>>> I have not seen such i2c errors during capturing and booting.
>>>>> But I have seen that querystd() in the ml86v7667 driver often
>>>>> returns V4L2_STD_UNKNOWN, although the corresponding function
>>>>>
>>>>>
>>>> could you try Hans's fix:
>>>> https://patchwork.kernel.org/patch/2640701/
>>>>
>>>>
>>> The fix has been already applied in my environment.
>>>
>>>
>> I've found that after some iteration of submission we disabled the
>> input signal in autodetection in ml86v7667_init(). per
>> recommendations.
>> That could be the case why the input signal is not locked.
>>
>> On adv7180 it still has optional autodetection but Hans recommended to
>> get rid from runtime autodetection.
>> So I've added input signal detection only during boot time.
>>
>> Could you please try the attached patch?
>>
>
> With the patch, V4L2_STD_UNKNOWN often returned by querystd()
> in the ml86v7667 driver has been gone.
> But, captured images are still incorrect that means wrong
> order of fields desite '_BT' chosen for V4L2_STD_525_60.
>
I've ordered the NTSC camera.
I will return once I get it.
Regards,
Vladimir
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver
@ 2013-07-19 23:14 Sergei Shtylyov
2013-07-24 16:14 ` Guennadi Liakhovetski
0 siblings, 1 reply; 26+ messages in thread
From: Sergei Shtylyov @ 2013-07-19 23:14 UTC (permalink / raw)
To: g.liakhovetski, mchehab, linux-media
Cc: magnus.damm, linux-sh, phil.edworthy, matsu, vladimir.barinov
From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Add Renesas R-Car VIN (Video In) V4L2 driver.
Based on the patch by Phil Edworthy <phil.edworthy@renesas.com>.
Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
[Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed 'enum chip_id'
values, reordered rcar_vin_id_table[] entries, removed senseless parens from
to_buf_list() macro, used ALIGN() macro in rcar_vin_setup(), added {} to the
*if* statement and used 'bool' values instead of 0/1 where necessary, removed
unused macros, done some reformatting and clarified some comments.]
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
This patch is against the 'media_tree.git' repo.
Changes since version 7:
- remove 'icd' field from 'struct rcar_vin_priv' in accordance with the commit
f7f6ce2d09c86bd80ee11bd654a1ac1e8f5dfe13 ([media] soc-camera: move common code
to soc_camera.c);
- added mandatory clock_{start|stop}() methods in accordance with the commit
a78fcc11264b824d9651b55abfeedd16d5cd8415 ([media] soc-camera: make .clock_
{start,stop} compulsory, .add / .remove optional).
Changes since version 6:
- sorted #include's alphabetically once again;
- BUG() on invalid format in rcar_vin_setup();
- used 'icd->sizeimage' instead of frame size calculation;
- moved WARN_ON() into the *if* condition and removed setting 'vb' to NULL in
rcar_vin_remove_device();
- fixed 'packing' and 'layout' field values for 'fourcc' V4L2_PIX_FMT_NV16 in
rcar_vin_formats[];
- made result handling logic more accurate in case subdevice does not support
cropping;
- fixed scaling capability for pass-through pixel formats;
- resolved reject in the Makefile, refreshed the patch.
Changes since version 5:
- handled subdevice's inability to support cropping;
- set the field format depending on a video standard.
Changes since version 4:
- added "select SOC_CAMERA_SCALE_CROP" to Kconfig entry;
- added #include "soc_scale_crop.h", made use of the functions declared there
instead of the analogous functions originally copied from the SH-Mobile CEU
driver now that they have been placed in a module of their own, removing now
unused private functions.
Changes since version 3:
- removed the driver's dependency on R-Car M1A/H1 SoCs from Kconfig;
- made the driver aware of the differences between R-Car E1/M1/H1 SoCs by having
different platform device IDs for different SoCs, introcduced 'enum chips_id'
to be used as the 'driver_data' field of 'struct platform_device_id' and then
copied to the 'chip' field of 'struct rcar_vin_priv';
- sorted #include's alphabetically, added a number of #includes <media/v4l2-*>;
- removed the 'data_through' field of the 'struct rcar_vin_priv' and the pass-
through logic from set_fmt() method;
- simplified is_continuous_transfer(), used it where applicable;
- removed senseless parens from to_buf_list() macro;
- removed the 'code' field from the 'struct rcar_vin_cam';
- largely rewrote the queue_setup() method;
- removed 'input_is_yuv' variable from rcar_vin_setup(), made 'progressive' and
'output_is_yuv' variables 'bool', and made setting VnDMR.EXRGB bit only happen
on R-Car E1/H1 there;
- made use of ALIGN() macro in rcar_vin_setup() and rcar_vin_set_rect();
- fixed missing {} on one branch of the *if* statement in several places, added
{} to the *if* statement where necessary;
- stopped saving/restoring flags when grabbing/dropping a spinlock in the
buf_queue() and buf_cleanup() methods;
- made 'dsize' variable calculation depend on R-Car E1 in rcar_vin_set_rect()
- fix the continuous capturing to stop when there is no buffer to be set into
the VnMBm registers in rcar_vin_irq();
- replaced BUG_ON() with WARN_ON() and *return* in the remove() method, also
replaced pm_runtime_put_sync() with pm_runtime_put() there;
- removed size_dst() and calc_scale() as the calls to calc_scale() were also
removed from the set_fmt() method;
- removed the VnMC register value check from capture_restore();
- removed 'cfg' variable initializers from set_bus_param() method and
rcar_vin_try_bus_param();
- added bus width check to rcar_vin_try_bus_param();
- removed V4L2_PIX_FMT_YUYV format from rcar_vin_formats[], initialize 'layout'
field of every element in this table;
- changed dev_err() call and *return* -EINVAL to dev_warn() and *return* 0 in
the get_formats() method,
- added rcar_vin_packing_supported() and started handling pass-through mode in
the get_formats() method;
- constified the parameters of is_smaller() and is_inside();
- redid the scaling logic so that it can't scale RGB32 data on R-Car E1 in the
set_fmt() method, also stopped assigning to 'cam->code' there;
- started selecting the current format if soc_camera_xlate_by_fourcc() call
failed in the try_fmt() method, also started letting 'soc-camera' calculate
bytes-per-line and image size there;
- removed pm_runtime_resume() call from the driver's probe() method
- added setting of the 'timestamp_type' field to the init_videobuf2() method.
Changes since version 2:
- replaced Cyrillic characters in comments with the proper Latinic ones.
Changes since the original posting:
- added IRQF_SHARED flag in devm_request_irq() call (since on R8A7778 VIN0/1
share the same IRQ) and removed deprecated IRQF_DISABLED flag.
drivers/media/platform/soc_camera/Kconfig | 8
drivers/media/platform/soc_camera/Makefile | 1
drivers/media/platform/soc_camera/rcar_vin.c | 1474 +++++++++++++++++++++++++++
include/linux/platform_data/camera-rcar.h | 25
4 files changed, 1508 insertions(+)
Index: media_tree/drivers/media/platform/soc_camera/Kconfig
===================================================================
--- media_tree.orig/drivers/media/platform/soc_camera/Kconfig
+++ media_tree/drivers/media/platform/soc_camera/Kconfig
@@ -44,6 +44,14 @@ config VIDEO_PXA27x
---help---
This is a v4l2 driver for the PXA27x Quick Capture Interface
+config VIDEO_RCAR_VIN
+ tristate "R-Car Video Input (VIN) support"
+ depends on VIDEO_DEV && SOC_CAMERA
+ select VIDEOBUF2_DMA_CONTIG
+ select SOC_CAMERA_SCALE_CROP
+ ---help---
+ This is a v4l2 driver for the R-Car VIN Interface
+
config VIDEO_SH_MOBILE_CSI2
tristate "SuperH Mobile MIPI CSI-2 Interface driver"
depends on VIDEO_DEV && SOC_CAMERA && HAVE_CLK
Index: media_tree/drivers/media/platform/soc_camera/Makefile
===================================================================
--- media_tree.orig/drivers/media/platform/soc_camera/Makefile
+++ media_tree/drivers/media/platform/soc_camera/Makefile
@@ -14,3 +14,4 @@ obj-$(CONFIG_VIDEO_OMAP1) += omap1_came
obj-$(CONFIG_VIDEO_PXA27x) += pxa_camera.o
obj-$(CONFIG_VIDEO_SH_MOBILE_CEU) += sh_mobile_ceu_camera.o
obj-$(CONFIG_VIDEO_SH_MOBILE_CSI2) += sh_mobile_csi2.o
+obj-$(CONFIG_VIDEO_RCAR_VIN) += rcar_vin.o
Index: media_tree/drivers/media/platform/soc_camera/rcar_vin.c
===================================================================
--- /dev/null
+++ media_tree/drivers/media/platform/soc_camera/rcar_vin.c
@@ -0,0 +1,1474 @@
+/*
+ * SoC-camera host driver for Renesas R-Car VIN unit
+ *
+ * Copyright (C) 2011-2013 Renesas Solutions Corp.
+ * Copyright (C) 2013 Cogent Embedded, Inc., <source@cogentembedded.com>
+ *
+ * Based on V4L2 Driver for SuperH Mobile CEU interface "sh_mobile_ceu_camera.c"
+ *
+ * Copyright (C) 2008 Magnus Damm
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation; either version 2 of the License, or (at your
+ * option) any later version.
+ */
+
+#include <linux/delay.h>
+#include <linux/interrupt.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/platform_data/camera-rcar.h>
+#include <linux/platform_device.h>
+#include <linux/pm_runtime.h>
+#include <linux/slab.h>
+#include <linux/videodev2.h>
+
+#include <media/soc_camera.h>
+#include <media/soc_mediabus.h>
+#include <media/v4l2-common.h>
+#include <media/v4l2-dev.h>
+#include <media/v4l2-device.h>
+#include <media/v4l2-mediabus.h>
+#include <media/v4l2-subdev.h>
+#include <media/videobuf2-dma-contig.h>
+
+#include "soc_scale_crop.h"
+
+#define DRV_NAME "rcar_vin"
+
+/* Register offsets for R-Car VIN */
+#define VNMC_REG 0x00 /* Video n Main Control Register */
+#define VNMS_REG 0x04 /* Video n Module Status Register */
+#define VNFC_REG 0x08 /* Video n Frame Capture Register */
+#define VNSLPRC_REG 0x0C /* Video n Start Line Pre-Clip Register */
+#define VNELPRC_REG 0x10 /* Video n End Line Pre-Clip Register */
+#define VNSPPRC_REG 0x14 /* Video n Start Pixel Pre-Clip Register */
+#define VNEPPRC_REG 0x18 /* Video n End Pixel Pre-Clip Register */
+#define VNSLPOC_REG 0x1C /* Video n Start Line Post-Clip Register */
+#define VNELPOC_REG 0x20 /* Video n End Line Post-Clip Register */
+#define VNSPPOC_REG 0x24 /* Video n Start Pixel Post-Clip Register */
+#define VNEPPOC_REG 0x28 /* Video n End Pixel Post-Clip Register */
+#define VNIS_REG 0x2C /* Video n Image Stride Register */
+#define VNMB_REG(m) (0x30 + ((m) << 2)) /* Video n Memory Base m Register */
+#define VNIE_REG 0x40 /* Video n Interrupt Enable Register */
+#define VNINTS_REG 0x44 /* Video n Interrupt Status Register */
+#define VNSI_REG 0x48 /* Video n Scanline Interrupt Register */
+#define VNMTC_REG 0x4C /* Video n Memory Transfer Control Register */
+#define VNYS_REG 0x50 /* Video n Y Scale Register */
+#define VNXS_REG 0x54 /* Video n X Scale Register */
+#define VNDMR_REG 0x58 /* Video n Data Mode Register */
+#define VNDMR2_REG 0x5C /* Video n Data Mode Register 2 */
+#define VNUVAOF_REG 0x60 /* Video n UV Address Offset Register */
+
+/* Register bit fields for R-Car VIN */
+/* Video n Main Control Register bits */
+#define VNMC_FOC (1 << 21)
+#define VNMC_YCAL (1 << 19)
+#define VNMC_INF_YUV8_BT656 (0 << 16)
+#define VNMC_INF_YUV8_BT601 (1 << 16)
+#define VNMC_INF_YUV16 (5 << 16)
+#define VNMC_VUP (1 << 10)
+#define VNMC_IM_ODD (0 << 3)
+#define VNMC_IM_ODD_EVEN (1 << 3)
+#define VNMC_IM_EVEN (2 << 3)
+#define VNMC_IM_FULL (3 << 3)
+#define VNMC_BPS (1 << 1)
+#define VNMC_ME (1 << 0)
+
+/* Video n Module Status Register bits */
+#define VNMS_FBS_MASK (3 << 3)
+#define VNMS_FBS_SHIFT 3
+#define VNMS_AV (1 << 1)
+#define VNMS_CA (1 << 0)
+
+/* Video n Frame Capture Register bits */
+#define VNFC_C_FRAME (1 << 1)
+#define VNFC_S_FRAME (1 << 0)
+
+/* Video n Interrupt Enable Register bits */
+#define VNIE_FIE (1 << 4)
+#define VNIE_EFE (1 << 1)
+
+/* Video n Data Mode Register bits */
+#define VNDMR_EXRGB (1 << 8)
+#define VNDMR_BPSM (1 << 4)
+#define VNDMR_DTMD_YCSEP (1 << 1)
+#define VNDMR_DTMD_ARGB1555 (1 << 0)
+
+/* Video n Data Mode Register 2 bits */
+#define VNDMR2_VPS (1 << 30)
+#define VNDMR2_HPS (1 << 29)
+#define VNDMR2_FTEV (1 << 17)
+
+#define VIN_MAX_WIDTH 2048
+#define VIN_MAX_HEIGHT 2048
+
+enum chip_id {
+ RCAR_H1,
+ RCAR_M1,
+ RCAR_E1,
+};
+
+enum rcar_vin_state {
+ STOPPED = 0,
+ RUNNING,
+ STOPPING,
+};
+
+struct rcar_vin_priv {
+ void __iomem *base;
+ spinlock_t lock;
+ int sequence;
+ /* State of the VIN module in capturing mode */
+ enum rcar_vin_state state;
+ struct rcar_vin_platform_data *pdata;
+ struct soc_camera_host ici;
+ struct list_head capture;
+#define MAX_BUFFER_NUM 3
+ struct vb2_buffer *queue_buf[MAX_BUFFER_NUM];
+ struct vb2_alloc_ctx *alloc_ctx;
+ enum v4l2_field field;
+ unsigned int vb_count;
+ unsigned int nr_hw_slots;
+ bool request_to_stop;
+ struct completion capture_stop;
+ enum chip_id chip;
+};
+
+#define is_continuous_transfer(priv) (priv->vb_count > MAX_BUFFER_NUM)
+
+struct rcar_vin_buffer {
+ struct vb2_buffer vb;
+ struct list_head list;
+};
+
+#define to_buf_list(vb2_buffer) (&container_of(vb2_buffer, \
+ struct rcar_vin_buffer, \
+ vb)->list)
+
+struct rcar_vin_cam {
+ /* VIN offsets within the camera output, before the VIN scaler */
+ unsigned int vin_left;
+ unsigned int vin_top;
+ /* Client output, as seen by the VIN */
+ unsigned int width;
+ unsigned int height;
+ /*
+ * User window from S_CROP / G_CROP, produced by client cropping and
+ * scaling, VIN scaling and VIN cropping, mapped back onto the client
+ * input window
+ */
+ struct v4l2_rect subrect;
+ /* Camera cropping rectangle */
+ struct v4l2_rect rect;
+ const struct soc_mbus_pixelfmt *extra_fmt;
+};
+
+/*
+ * .queue_setup() is called to check whether the driver can accept the requested
+ * number of buffers and to fill in plane sizes for the current frame format if
+ * required
+ */
+static int rcar_vin_videobuf_setup(struct vb2_queue *vq,
+ const struct v4l2_format *fmt,
+ unsigned int *count,
+ unsigned int *num_planes,
+ unsigned int sizes[], void *alloc_ctxs[])
+{
+ struct soc_camera_device *icd = soc_camera_from_vb2q(vq);
+ struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
+ struct rcar_vin_priv *priv = ici->priv;
+
+ if (fmt) {
+ const struct soc_camera_format_xlate *xlate;
+ unsigned int bytes_per_line;
+ int ret;
+
+ xlate = soc_camera_xlate_by_fourcc(icd,
+ fmt->fmt.pix.pixelformat);
+ if (!xlate)
+ return -EINVAL;
+ ret = soc_mbus_bytes_per_line(fmt->fmt.pix.width,
+ xlate->host_fmt);
+ if (ret < 0)
+ return ret;
+
+ bytes_per_line = max_t(u32, fmt->fmt.pix.bytesperline, ret);
+
+ ret = soc_mbus_image_size(xlate->host_fmt, bytes_per_line,
+ fmt->fmt.pix.height);
+ if (ret < 0)
+ return ret;
+
+ sizes[0] = max_t(u32, fmt->fmt.pix.sizeimage, ret);
+ } else {
+ /* Called from VIDIOC_REQBUFS or in compatibility mode */
+ sizes[0] = icd->sizeimage;
+ }
+
+ alloc_ctxs[0] = priv->alloc_ctx;
+
+ if (!vq->num_buffers)
+ priv->sequence = 0;
+
+ if (!*count)
+ *count = 2;
+ priv->vb_count = *count;
+
+ *num_planes = 1;
+
+ /* Number of hardware slots */
+ if (is_continuous_transfer(priv))
+ priv->nr_hw_slots = MAX_BUFFER_NUM;
+ else
+ priv->nr_hw_slots = 1;
+
+ dev_dbg(icd->parent, "count=%d, size=%u\n", *count, sizes[0]);
+
+ return 0;
+}
+
+static void rcar_vin_setup(struct rcar_vin_priv *priv)
+{
+ struct soc_camera_device *icd = priv->ici.icd;
+ struct rcar_vin_cam *cam = icd->host_priv;
+ u32 vnmc, dmr, interrupts;
+ bool progressive = false, output_is_yuv = false;
+
+ switch (priv->field) {
+ case V4L2_FIELD_TOP:
+ vnmc = VNMC_IM_ODD;
+ break;
+ case V4L2_FIELD_BOTTOM:
+ vnmc = VNMC_IM_EVEN;
+ break;
+ case V4L2_FIELD_INTERLACED:
+ case V4L2_FIELD_INTERLACED_TB:
+ vnmc = VNMC_IM_FULL;
+ break;
+ case V4L2_FIELD_INTERLACED_BT:
+ vnmc = VNMC_IM_FULL | VNMC_FOC;
+ break;
+ case V4L2_FIELD_NONE:
+ if (is_continuous_transfer(priv)) {
+ vnmc = VNMC_IM_ODD_EVEN;
+ progressive = true;
+ } else {
+ vnmc = VNMC_IM_ODD;
+ }
+ break;
+ default:
+ vnmc = VNMC_IM_ODD;
+ break;
+ }
+
+ /* input interface */
+ switch (icd->current_fmt->code) {
+ case V4L2_MBUS_FMT_YUYV8_1X16:
+ /* BT.601/BT.1358 16bit YCbCr422 */
+ vnmc |= VNMC_INF_YUV16;
+ break;
+ case V4L2_MBUS_FMT_YUYV8_2X8:
+ /* BT.656 8bit YCbCr422 or BT.601 8bit YCbCr422 */
+ vnmc |= priv->pdata->flags & RCAR_VIN_BT656 ?
+ VNMC_INF_YUV8_BT656 : VNMC_INF_YUV8_BT601;
+ default:
+ break;
+ }
+
+ /* output format */
+ switch (icd->current_fmt->host_fmt->fourcc) {
+ case V4L2_PIX_FMT_NV16:
+ iowrite32(ALIGN(cam->width * cam->height, 0x80),
+ priv->base + VNUVAOF_REG);
+ dmr = VNDMR_DTMD_YCSEP;
+ output_is_yuv = true;
+ break;
+ case V4L2_PIX_FMT_YUYV:
+ dmr = VNDMR_BPSM;
+ output_is_yuv = true;
+ break;
+ case V4L2_PIX_FMT_UYVY:
+ dmr = 0;
+ output_is_yuv = true;
+ break;
+ case V4L2_PIX_FMT_RGB555X:
+ dmr = VNDMR_DTMD_ARGB1555;
+ break;
+ case V4L2_PIX_FMT_RGB565:
+ dmr = 0;
+ break;
+ case V4L2_PIX_FMT_RGB32:
+ if (priv->chip == RCAR_H1 || priv->chip == RCAR_E1) {
+ dmr = VNDMR_EXRGB;
+ break;
+ }
+ default:
+ BUG();
+ }
+
+ /* Always update on field change */
+ vnmc |= VNMC_VUP;
+
+ /* If input and output use the same colorspace, use bypass mode */
+ if (output_is_yuv)
+ vnmc |= VNMC_BPS;
+
+ /* progressive or interlaced mode */
+ interrupts = progressive ? VNIE_FIE | VNIE_EFE : VNIE_EFE;
+
+ /* ack interrupts */
+ iowrite32(interrupts, priv->base + VNINTS_REG);
+ /* enable interrupts */
+ iowrite32(interrupts, priv->base + VNIE_REG);
+ /* start capturing */
+ iowrite32(dmr, priv->base + VNDMR_REG);
+ iowrite32(vnmc | VNMC_ME, priv->base + VNMC_REG);
+}
+
+static void rcar_vin_capture(struct rcar_vin_priv *priv)
+{
+ if (is_continuous_transfer(priv))
+ /* Continuous Frame Capture Mode */
+ iowrite32(VNFC_C_FRAME, priv->base + VNFC_REG);
+ else
+ /* Single Frame Capture Mode */
+ iowrite32(VNFC_S_FRAME, priv->base + VNFC_REG);
+}
+
+static void rcar_vin_request_capture_stop(struct rcar_vin_priv *priv)
+{
+ priv->state = STOPPING;
+
+ /* set continuous & single transfer off */
+ iowrite32(0, priv->base + VNFC_REG);
+ /* disable capture (release DMA buffer), reset */
+ iowrite32(ioread32(priv->base + VNMC_REG) & ~VNMC_ME,
+ priv->base + VNMC_REG);
+
+ /* update the status if stopped already */
+ if (!(ioread32(priv->base + VNMS_REG) & VNMS_CA))
+ priv->state = STOPPED;
+}
+
+static int rcar_vin_get_free_hw_slot(struct rcar_vin_priv *priv)
+{
+ int slot;
+
+ for (slot = 0; slot < priv->nr_hw_slots; slot++)
+ if (priv->queue_buf[slot] == NULL)
+ return slot;
+
+ return -1;
+}
+
+static int rcar_vin_hw_ready(struct rcar_vin_priv *priv)
+{
+ /* Ensure all HW slots are filled */
+ return rcar_vin_get_free_hw_slot(priv) < 0 ? 1 : 0;
+}
+
+/* Moves a buffer from the queue to the HW slots */
+static int rcar_vin_fill_hw_slot(struct rcar_vin_priv *priv)
+{
+ struct vb2_buffer *vb;
+ dma_addr_t phys_addr_top;
+ int slot;
+
+ if (list_empty(&priv->capture))
+ return 0;
+
+ /* Find a free HW slot */
+ slot = rcar_vin_get_free_hw_slot(priv);
+ if (slot < 0)
+ return 0;
+
+ vb = &list_entry(priv->capture.next, struct rcar_vin_buffer, list)->vb;
+ list_del_init(to_buf_list(vb));
+ priv->queue_buf[slot] = vb;
+ phys_addr_top = vb2_dma_contig_plane_dma_addr(vb, 0);
+ iowrite32(phys_addr_top, priv->base + VNMB_REG(slot));
+
+ return 1;
+}
+
+static void rcar_vin_videobuf_queue(struct vb2_buffer *vb)
+{
+ struct soc_camera_device *icd = soc_camera_from_vb2q(vb->vb2_queue);
+ struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
+ struct rcar_vin_priv *priv = ici->priv;
+ unsigned long size;
+
+ size = icd->sizeimage;
+
+ if (vb2_plane_size(vb, 0) < size) {
+ dev_err(icd->parent, "Buffer #%d too small (%lu < %lu)\n",
+ vb->v4l2_buf.index, vb2_plane_size(vb, 0), size);
+ goto error;
+ }
+
+ vb2_set_plane_payload(vb, 0, size);
+
+ dev_dbg(icd->parent, "%s (vb=0x%p) 0x%p %lu\n", __func__,
+ vb, vb2_plane_vaddr(vb, 0), vb2_get_plane_payload(vb, 0));
+
+ spin_lock_irq(&priv->lock);
+
+ list_add_tail(to_buf_list(vb), &priv->capture);
+ rcar_vin_fill_hw_slot(priv);
+
+ /* If we weren't running, and have enough buffers, start capturing! */
+ if (priv->state != RUNNING && rcar_vin_hw_ready(priv)) {
+ priv->request_to_stop = false;
+ init_completion(&priv->capture_stop);
+ priv->state = RUNNING;
+ rcar_vin_setup(priv);
+ rcar_vin_capture(priv);
+ }
+
+ spin_unlock_irq(&priv->lock);
+
+ return;
+
+error:
+ vb2_buffer_done(vb, VB2_BUF_STATE_ERROR);
+}
+
+static void rcar_vin_videobuf_release(struct vb2_buffer *vb)
+{
+ struct soc_camera_device *icd = soc_camera_from_vb2q(vb->vb2_queue);
+ struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
+ struct rcar_vin_priv *priv = ici->priv;
+ unsigned int i;
+ int buf_in_use = 0;
+
+ spin_lock_irq(&priv->lock);
+
+ /* Is the buffer in use by the VIN hardware? */
+ for (i = 0; i < MAX_BUFFER_NUM; i++) {
+ if (priv->queue_buf[i] == vb) {
+ buf_in_use = 1;
+ break;
+ }
+ }
+
+ if (buf_in_use) {
+ while (priv->state != STOPPED) {
+
+ /* issue stop if running */
+ if (priv->state == RUNNING)
+ rcar_vin_request_capture_stop(priv);
+
+ /* wait until capturing has been stopped */
+ if (priv->state == STOPPING) {
+ priv->request_to_stop = true;
+ spin_unlock_irq(&priv->lock);
+ wait_for_completion(&priv->capture_stop);
+ spin_lock_irq(&priv->lock);
+ }
+ }
+ /*
+ * Capturing has now stopped. The buffer we have been asked
+ * to release could be any of the current buffers in use, so
+ * release all buffers that are in use by HW
+ */
+ for (i = 0; i < MAX_BUFFER_NUM; i++) {
+ if (priv->queue_buf[i]) {
+ vb2_buffer_done(priv->queue_buf[i],
+ VB2_BUF_STATE_ERROR);
+ priv->queue_buf[i] = NULL;
+ }
+ }
+ } else {
+ list_del_init(to_buf_list(vb));
+ }
+
+ spin_unlock_irq(&priv->lock);
+}
+
+static int rcar_vin_videobuf_init(struct vb2_buffer *vb)
+{
+ INIT_LIST_HEAD(to_buf_list(vb));
+ return 0;
+}
+
+static int rcar_vin_stop_streaming(struct vb2_queue *vq)
+{
+ struct soc_camera_device *icd = soc_camera_from_vb2q(vq);
+ struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
+ struct rcar_vin_priv *priv = ici->priv;
+ struct list_head *buf_head, *tmp;
+
+ spin_lock_irq(&priv->lock);
+ list_for_each_safe(buf_head, tmp, &priv->capture)
+ list_del_init(buf_head);
+ spin_unlock_irq(&priv->lock);
+
+ return 0;
+}
+
+static struct vb2_ops rcar_vin_vb2_ops = {
+ .queue_setup = rcar_vin_videobuf_setup,
+ .buf_init = rcar_vin_videobuf_init,
+ .buf_cleanup = rcar_vin_videobuf_release,
+ .buf_queue = rcar_vin_videobuf_queue,
+ .stop_streaming = rcar_vin_stop_streaming,
+ .wait_prepare = soc_camera_unlock,
+ .wait_finish = soc_camera_lock,
+};
+
+static irqreturn_t rcar_vin_irq(int irq, void *data)
+{
+ struct rcar_vin_priv *priv = data;
+ u32 int_status;
+ bool can_run = false, hw_stopped;
+ int slot;
+ unsigned int handled = 0;
+
+ spin_lock(&priv->lock);
+
+ int_status = ioread32(priv->base + VNINTS_REG);
+ if (!int_status)
+ goto done;
+ /* ack interrupts */
+ iowrite32(int_status, priv->base + VNINTS_REG);
+ handled = 1;
+
+ /* nothing to do if capture status is 'STOPPED' */
+ if (priv->state == STOPPED)
+ goto done;
+
+ hw_stopped = !(ioread32(priv->base + VNMS_REG) & VNMS_CA);
+
+ if (!priv->request_to_stop) {
+ if (is_continuous_transfer(priv))
+ slot = (ioread32(priv->base + VNMS_REG) &
+ VNMS_FBS_MASK) >> VNMS_FBS_SHIFT;
+ else
+ slot = 0;
+
+ priv->queue_buf[slot]->v4l2_buf.field = priv->field;
+ priv->queue_buf[slot]->v4l2_buf.sequence = priv->sequence++;
+ do_gettimeofday(&priv->queue_buf[slot]->v4l2_buf.timestamp);
+ vb2_buffer_done(priv->queue_buf[slot], VB2_BUF_STATE_DONE);
+ priv->queue_buf[slot] = NULL;
+
+ if (priv->state != STOPPING)
+ can_run = rcar_vin_fill_hw_slot(priv);
+
+ if (hw_stopped || !can_run) {
+ priv->state = STOPPED;
+ } else if (is_continuous_transfer(priv) &&
+ list_empty(&priv->capture) &&
+ priv->state == RUNNING) {
+ /*
+ * The continuous capturing requires an explicit stop
+ * operation when there is no buffer to be set into
+ * the VnMBm registers.
+ */
+ rcar_vin_request_capture_stop(priv);
+ } else {
+ rcar_vin_capture(priv);
+ }
+
+ } else if (hw_stopped) {
+ priv->state = STOPPED;
+ priv->request_to_stop = false;
+ complete(&priv->capture_stop);
+ }
+
+done:
+ spin_unlock(&priv->lock);
+
+ return IRQ_RETVAL(handled);
+}
+
+static int rcar_vin_add_device(struct soc_camera_device *icd)
+{
+ struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
+ struct rcar_vin_priv *priv = ici->priv;
+ int i;
+
+ for (i = 0; i < MAX_BUFFER_NUM; i++)
+ priv->queue_buf[i] = NULL;
+
+ pm_runtime_get_sync(ici->v4l2_dev.dev);
+
+ dev_dbg(icd->parent, "R-Car VIN driver attached to camera %d\n",
+ icd->devnum);
+
+ return 0;
+}
+
+static void rcar_vin_remove_device(struct soc_camera_device *icd)
+{
+ struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
+ struct rcar_vin_priv *priv = ici->priv;
+ struct vb2_buffer *vb;
+ int i;
+
+ /* disable capture, disable interrupts */
+ iowrite32(ioread32(priv->base + VNMC_REG) & ~VNMC_ME,
+ priv->base + VNMC_REG);
+ iowrite32(0, priv->base + VNIE_REG);
+
+ priv->state = STOPPED;
+ priv->request_to_stop = false;
+
+ /* make sure active buffer is cancelled */
+ spin_lock_irq(&priv->lock);
+ for (i = 0; i < MAX_BUFFER_NUM; i++) {
+ vb = priv->queue_buf[i];
+ if (vb) {
+ list_del_init(to_buf_list(vb));
+ vb2_buffer_done(vb, VB2_BUF_STATE_ERROR);
+ }
+ }
+ spin_unlock_irq(&priv->lock);
+
+ pm_runtime_put(ici->v4l2_dev.dev);
+
+ dev_dbg(icd->parent, "R-Car VIN driver detached from camera %d\n",
+ icd->devnum);
+}
+
+/* Called with .host_lock held */
+static int rcar_vin_clock_start(struct soc_camera_host *ici)
+{
+ return 0;
+}
+
+/* Called with .host_lock held */
+static void rcar_vin_clock_stop(struct soc_camera_host *ici)
+{
+}
+
+/* rect is guaranteed to not exceed the scaled camera rectangle */
+static int rcar_vin_set_rect(struct soc_camera_device *icd)
+{
+ struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
+ struct rcar_vin_cam *cam = icd->host_priv;
+ struct rcar_vin_priv *priv = ici->priv;
+ unsigned int left_offset, top_offset;
+ unsigned char dsize = 0;
+ struct v4l2_rect *cam_subrect = &cam->subrect;
+
+ dev_dbg(icd->parent, "Crop %ux%u@%u:%u\n",
+ icd->user_width, icd->user_height, cam->vin_left, cam->vin_top);
+
+ left_offset = cam->vin_left;
+ top_offset = cam->vin_top;
+
+ if (icd->current_fmt->host_fmt->fourcc == V4L2_PIX_FMT_RGB32 &&
+ priv->chip == RCAR_E1)
+ dsize = 1;
+
+ dev_dbg(icd->parent, "Cam %ux%u@%u:%u\n",
+ cam->width, cam->height, cam->vin_left, cam->vin_top);
+ dev_dbg(icd->parent, "Cam subrect %ux%u@%u:%u\n",
+ cam_subrect->width, cam_subrect->height,
+ cam_subrect->left, cam_subrect->top);
+
+ /* Set Start/End Pixel/Line Pre-Clip */
+ iowrite32(left_offset << dsize, priv->base + VNSPPRC_REG);
+ iowrite32((left_offset + cam->width - 1) << dsize,
+ priv->base + VNEPPRC_REG);
+ switch (priv->field) {
+ case V4L2_FIELD_INTERLACED:
+ case V4L2_FIELD_INTERLACED_TB:
+ case V4L2_FIELD_INTERLACED_BT:
+ iowrite32(top_offset / 2, priv->base + VNSLPRC_REG);
+ iowrite32((top_offset + cam->height) / 2 - 1,
+ priv->base + VNELPRC_REG);
+ break;
+ default:
+ iowrite32(top_offset, priv->base + VNSLPRC_REG);
+ iowrite32(top_offset + cam->height - 1,
+ priv->base + VNELPRC_REG);
+ break;
+ }
+
+ /* Set Start/End Pixel/Line Post-Clip */
+ iowrite32(0, priv->base + VNSPPOC_REG);
+ iowrite32(0, priv->base + VNSLPOC_REG);
+ iowrite32((cam_subrect->width - 1) << dsize, priv->base + VNEPPOC_REG);
+ switch (priv->field) {
+ case V4L2_FIELD_INTERLACED:
+ case V4L2_FIELD_INTERLACED_TB:
+ case V4L2_FIELD_INTERLACED_BT:
+ iowrite32(cam_subrect->height / 2 - 1,
+ priv->base + VNELPOC_REG);
+ break;
+ default:
+ iowrite32(cam_subrect->height - 1, priv->base + VNELPOC_REG);
+ break;
+ }
+
+ iowrite32(ALIGN(cam->width, 0x10), priv->base + VNIS_REG);
+
+ return 0;
+}
+
+static void capture_stop_preserve(struct rcar_vin_priv *priv, u32 *vnmc)
+{
+ *vnmc = ioread32(priv->base + VNMC_REG);
+ /* module disable */
+ iowrite32(*vnmc & ~VNMC_ME, priv->base + VNMC_REG);
+}
+
+static void capture_restore(struct rcar_vin_priv *priv, u32 vnmc)
+{
+ unsigned long timeout = jiffies + 10 * HZ;
+
+ /*
+ * Wait until the end of the current frame. It can take a long time,
+ * but if it has been aborted by a MRST1 reset, it should exit sooner.
+ */
+ while ((ioread32(priv->base + VNMS_REG) & VNMS_AV) &&
+ time_before(jiffies, timeout))
+ msleep(1);
+
+ if (time_after(jiffies, timeout)) {
+ dev_err(priv->ici.v4l2_dev.dev,
+ "Timeout waiting for frame end! Interface problem?\n");
+ return;
+ }
+
+ iowrite32(vnmc, priv->base + VNMC_REG);
+}
+
+#define VIN_MBUS_FLAGS (V4L2_MBUS_MASTER | \
+ V4L2_MBUS_PCLK_SAMPLE_RISING | \
+ V4L2_MBUS_HSYNC_ACTIVE_HIGH | \
+ V4L2_MBUS_HSYNC_ACTIVE_LOW | \
+ V4L2_MBUS_VSYNC_ACTIVE_HIGH | \
+ V4L2_MBUS_VSYNC_ACTIVE_LOW | \
+ V4L2_MBUS_DATA_ACTIVE_HIGH)
+
+static int rcar_vin_set_bus_param(struct soc_camera_device *icd)
+{
+ struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
+ struct rcar_vin_priv *priv = ici->priv;
+ struct v4l2_subdev *sd = soc_camera_to_subdev(icd);
+ struct v4l2_mbus_config cfg;
+ unsigned long common_flags;
+ u32 vnmc;
+ u32 val;
+ int ret;
+
+ capture_stop_preserve(priv, &vnmc);
+
+ ret = v4l2_subdev_call(sd, video, g_mbus_config, &cfg);
+ if (!ret) {
+ common_flags = soc_mbus_config_compatible(&cfg, VIN_MBUS_FLAGS);
+ if (!common_flags) {
+ dev_warn(icd->parent,
+ "MBUS flags incompatible: camera 0x%x, host 0x%x\n",
+ cfg.flags, VIN_MBUS_FLAGS);
+ return -EINVAL;
+ }
+ } else if (ret != -ENOIOCTLCMD) {
+ return ret;
+ } else {
+ common_flags = VIN_MBUS_FLAGS;
+ }
+
+ /* Make choises, based on platform preferences */
+ if ((common_flags & V4L2_MBUS_HSYNC_ACTIVE_HIGH) &&
+ (common_flags & V4L2_MBUS_HSYNC_ACTIVE_LOW)) {
+ if (priv->pdata->flags & RCAR_VIN_HSYNC_ACTIVE_LOW)
+ common_flags &= ~V4L2_MBUS_HSYNC_ACTIVE_HIGH;
+ else
+ common_flags &= ~V4L2_MBUS_HSYNC_ACTIVE_LOW;
+ }
+
+ if ((common_flags & V4L2_MBUS_VSYNC_ACTIVE_HIGH) &&
+ (common_flags & V4L2_MBUS_VSYNC_ACTIVE_LOW)) {
+ if (priv->pdata->flags & RCAR_VIN_VSYNC_ACTIVE_LOW)
+ common_flags &= ~V4L2_MBUS_VSYNC_ACTIVE_HIGH;
+ else
+ common_flags &= ~V4L2_MBUS_VSYNC_ACTIVE_LOW;
+ }
+
+ cfg.flags = common_flags;
+ ret = v4l2_subdev_call(sd, video, s_mbus_config, &cfg);
+ if (ret < 0 && ret != -ENOIOCTLCMD)
+ return ret;
+
+ val = priv->field == V4L2_FIELD_NONE ? VNDMR2_FTEV : 0;
+ if (!(common_flags & V4L2_MBUS_VSYNC_ACTIVE_LOW))
+ val |= VNDMR2_VPS;
+ if (!(common_flags & V4L2_MBUS_HSYNC_ACTIVE_LOW))
+ val |= VNDMR2_HPS;
+ iowrite32(val, priv->base + VNDMR2_REG);
+
+ ret = rcar_vin_set_rect(icd);
+ if (ret < 0)
+ return ret;
+
+ capture_restore(priv, vnmc);
+
+ return 0;
+}
+
+static int rcar_vin_try_bus_param(struct soc_camera_device *icd,
+ unsigned char buswidth)
+{
+ struct v4l2_subdev *sd = soc_camera_to_subdev(icd);
+ struct v4l2_mbus_config cfg;
+ int ret;
+
+ ret = v4l2_subdev_call(sd, video, g_mbus_config, &cfg);
+ if (ret == -ENOIOCTLCMD)
+ return 0;
+ else if (ret)
+ return ret;
+
+ if (buswidth > 24)
+ return -EINVAL;
+
+ /* check is there common mbus flags */
+ ret = soc_mbus_config_compatible(&cfg, VIN_MBUS_FLAGS);
+ if (ret)
+ return 0;
+
+ dev_warn(icd->parent,
+ "MBUS flags incompatible: camera 0x%x, host 0x%x\n",
+ cfg.flags, VIN_MBUS_FLAGS);
+
+ return -EINVAL;
+}
+
+static bool rcar_vin_packing_supported(const struct soc_mbus_pixelfmt *fmt)
+{
+ return fmt->packing == SOC_MBUS_PACKING_NONE ||
+ (fmt->bits_per_sample > 8 &&
+ fmt->packing == SOC_MBUS_PACKING_EXTEND16);
+}
+
+static const struct soc_mbus_pixelfmt rcar_vin_formats[] = {
+ {
+ .fourcc = V4L2_PIX_FMT_NV16,
+ .name = "NV16",
+ .bits_per_sample = 16,
+ .packing = SOC_MBUS_PACKING_2X8_PADHI,
+ .order = SOC_MBUS_ORDER_LE,
+ .layout = SOC_MBUS_LAYOUT_PLANAR_Y_C,
+ },
+ {
+ .fourcc = V4L2_PIX_FMT_UYVY,
+ .name = "UYVY",
+ .bits_per_sample = 16,
+ .packing = SOC_MBUS_PACKING_NONE,
+ .order = SOC_MBUS_ORDER_LE,
+ .layout = SOC_MBUS_LAYOUT_PACKED,
+ },
+ {
+ .fourcc = V4L2_PIX_FMT_RGB565,
+ .name = "RGB565",
+ .bits_per_sample = 16,
+ .packing = SOC_MBUS_PACKING_NONE,
+ .order = SOC_MBUS_ORDER_LE,
+ .layout = SOC_MBUS_LAYOUT_PACKED,
+ },
+ {
+ .fourcc = V4L2_PIX_FMT_RGB555X,
+ .name = "ARGB1555",
+ .bits_per_sample = 16,
+ .packing = SOC_MBUS_PACKING_NONE,
+ .order = SOC_MBUS_ORDER_LE,
+ .layout = SOC_MBUS_LAYOUT_PACKED,
+ },
+ {
+ .fourcc = V4L2_PIX_FMT_RGB32,
+ .name = "RGB888",
+ .bits_per_sample = 32,
+ .packing = SOC_MBUS_PACKING_NONE,
+ .order = SOC_MBUS_ORDER_LE,
+ .layout = SOC_MBUS_LAYOUT_PACKED,
+ },
+};
+
+static int rcar_vin_get_formats(struct soc_camera_device *icd, unsigned int idx,
+ struct soc_camera_format_xlate *xlate)
+{
+ struct v4l2_subdev *sd = soc_camera_to_subdev(icd);
+ struct device *dev = icd->parent;
+ int ret, k, n;
+ int formats = 0;
+ struct rcar_vin_cam *cam;
+ enum v4l2_mbus_pixelcode code;
+ const struct soc_mbus_pixelfmt *fmt;
+
+ ret = v4l2_subdev_call(sd, video, enum_mbus_fmt, idx, &code);
+ if (ret < 0)
+ return 0;
+
+ fmt = soc_mbus_get_fmtdesc(code);
+ if (!fmt) {
+ dev_warn(dev, "unsupported format code #%u: %d\n", idx, code);
+ return 0;
+ }
+
+ ret = rcar_vin_try_bus_param(icd, fmt->bits_per_sample);
+ if (ret < 0)
+ return 0;
+
+ if (!icd->host_priv) {
+ struct v4l2_mbus_framefmt mf;
+ struct v4l2_rect rect;
+ struct device *dev = icd->parent;
+ int shift;
+
+ ret = v4l2_subdev_call(sd, video, g_mbus_fmt, &mf);
+ if (ret < 0)
+ return ret;
+
+ /* Cache current client geometry */
+ ret = soc_camera_client_g_rect(sd, &rect);
+ if (ret == -ENOIOCTLCMD) {
+ /* Sensor driver doesn't support cropping */
+ rect.left = 0;
+ rect.top = 0;
+ rect.width = mf.width;
+ rect.height = mf.height;
+ } else if (ret < 0) {
+ return ret;
+ }
+
+ /*
+ * If sensor proposes too large format then try smaller ones:
+ * 1280x960, 640x480, 320x240
+ */
+ for (shift = 0; shift < 3; shift++) {
+ if (mf.width <= VIN_MAX_WIDTH &&
+ mf.height <= VIN_MAX_HEIGHT)
+ break;
+
+ mf.width = 1280 >> shift;
+ mf.height = 960 >> shift;
+ ret = v4l2_device_call_until_err(sd->v4l2_dev,
+ soc_camera_grp_id(icd),
+ video, s_mbus_fmt,
+ &mf);
+ if (ret < 0)
+ return ret;
+ }
+
+ if (shift == 3) {
+ dev_err(dev,
+ "Failed to configure the client below %ux%x\n",
+ mf.width, mf.height);
+ return -EIO;
+ }
+
+ dev_dbg(dev, "camera fmt %ux%u\n", mf.width, mf.height);
+
+ cam = kzalloc(sizeof(*cam), GFP_KERNEL);
+ if (!cam)
+ return -ENOMEM;
+ /*
+ * We are called with current camera crop,
+ * initialise subrect with it
+ */
+ cam->rect = rect;
+ cam->subrect = rect;
+ cam->width = mf.width;
+ cam->height = mf.height;
+
+ icd->host_priv = cam;
+ } else {
+ cam = icd->host_priv;
+ }
+
+ /* Beginning of a pass */
+ if (!idx)
+ cam->extra_fmt = NULL;
+
+ switch (code) {
+ case V4L2_MBUS_FMT_YUYV8_1X16:
+ case V4L2_MBUS_FMT_YUYV8_2X8:
+ if (cam->extra_fmt)
+ break;
+
+ /* Add all our formats that can be generated by VIN */
+ cam->extra_fmt = rcar_vin_formats;
+
+ n = ARRAY_SIZE(rcar_vin_formats);
+ formats += n;
+ for (k = 0; xlate && k < n; k++, xlate++) {
+ xlate->host_fmt = &rcar_vin_formats[k];
+ xlate->code = code;
+ dev_dbg(dev, "Providing format %s using code %d\n",
+ rcar_vin_formats[k].name, code);
+ }
+ break;
+ default:
+ if (!rcar_vin_packing_supported(fmt))
+ return 0;
+
+ dev_dbg(dev, "Providing format %s in pass-through mode\n",
+ fmt->name);
+ break;
+ }
+
+ /* Generic pass-through */
+ formats++;
+ if (xlate) {
+ xlate->host_fmt = fmt;
+ xlate->code = code;
+ xlate++;
+ }
+
+ return formats;
+}
+
+static void rcar_vin_put_formats(struct soc_camera_device *icd)
+{
+ kfree(icd->host_priv);
+ icd->host_priv = NULL;
+}
+
+static int rcar_vin_set_crop(struct soc_camera_device *icd,
+ const struct v4l2_crop *a)
+{
+ struct v4l2_crop a_writable = *a;
+ const struct v4l2_rect *rect = &a_writable.c;
+ struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
+ struct rcar_vin_priv *priv = ici->priv;
+ struct v4l2_crop cam_crop;
+ struct rcar_vin_cam *cam = icd->host_priv;
+ struct v4l2_rect *cam_rect = &cam_crop.c;
+ struct v4l2_subdev *sd = soc_camera_to_subdev(icd);
+ struct device *dev = icd->parent;
+ struct v4l2_mbus_framefmt mf;
+ u32 vnmc;
+ int ret, i;
+
+ dev_dbg(dev, "S_CROP(%ux%u@%u:%u)\n", rect->width, rect->height,
+ rect->left, rect->top);
+
+ /* During camera cropping its output window can change too, stop VIN */
+ capture_stop_preserve(priv, &vnmc);
+ dev_dbg(dev, "VNMC_REG 0x%x\n", vnmc);
+
+ /* Apply iterative camera S_CROP for new input window. */
+ ret = soc_camera_client_s_crop(sd, &a_writable, &cam_crop,
+ &cam->rect, &cam->subrect);
+ if (ret < 0)
+ return ret;
+
+ dev_dbg(dev, "camera cropped to %ux%u@%u:%u\n",
+ cam_rect->width, cam_rect->height,
+ cam_rect->left, cam_rect->top);
+
+ /* On success cam_crop contains current camera crop */
+
+ /* Retrieve camera output window */
+ ret = v4l2_subdev_call(sd, video, g_mbus_fmt, &mf);
+ if (ret < 0)
+ return ret;
+
+ if (mf.width > VIN_MAX_WIDTH || mf.height > VIN_MAX_HEIGHT)
+ return -EINVAL;
+
+ /* Cache camera output window */
+ cam->width = mf.width;
+ cam->height = mf.height;
+
+ icd->user_width = cam->width;
+ icd->user_height = cam->height;
+
+ cam->vin_left = rect->left & ~1;
+ cam->vin_top = rect->top & ~1;
+
+ /* Use VIN cropping to crop to the new window. */
+ ret = rcar_vin_set_rect(icd);
+ if (ret < 0)
+ return ret;
+
+ cam->subrect = *rect;
+
+ dev_dbg(dev, "VIN cropped to %ux%u@%u:%u\n",
+ icd->user_width, icd->user_height,
+ cam->vin_left, cam->vin_top);
+
+ /* Restore capture */
+ for (i = 0; i < MAX_BUFFER_NUM; i++) {
+ if (priv->queue_buf[i] && priv->state == STOPPED) {
+ vnmc |= VNMC_ME;
+ break;
+ }
+ }
+ capture_restore(priv, vnmc);
+
+ /* Even if only camera cropping succeeded */
+ return ret;
+}
+
+static int rcar_vin_get_crop(struct soc_camera_device *icd,
+ struct v4l2_crop *a)
+{
+ struct rcar_vin_cam *cam = icd->host_priv;
+
+ a->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
+ a->c = cam->subrect;
+
+ return 0;
+}
+
+/* Similar to set_crop multistage iterative algorithm */
+static int rcar_vin_set_fmt(struct soc_camera_device *icd,
+ struct v4l2_format *f)
+{
+ struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
+ struct rcar_vin_priv *priv = ici->priv;
+ struct v4l2_subdev *sd = soc_camera_to_subdev(icd);
+ struct rcar_vin_cam *cam = icd->host_priv;
+ struct v4l2_pix_format *pix = &f->fmt.pix;
+ struct v4l2_mbus_framefmt mf;
+ struct device *dev = icd->parent;
+ __u32 pixfmt = pix->pixelformat;
+ const struct soc_camera_format_xlate *xlate;
+ unsigned int vin_sub_width = 0, vin_sub_height = 0;
+ int ret;
+ bool can_scale;
+ enum v4l2_field field;
+ v4l2_std_id std;
+
+ dev_dbg(dev, "S_FMT(pix=0x%x, %ux%u)\n",
+ pixfmt, pix->width, pix->height);
+
+ switch (pix->field) {
+ default:
+ pix->field = V4L2_FIELD_NONE;
+ /* fall-through */
+ case V4L2_FIELD_NONE:
+ case V4L2_FIELD_TOP:
+ case V4L2_FIELD_BOTTOM:
+ case V4L2_FIELD_INTERLACED_TB:
+ case V4L2_FIELD_INTERLACED_BT:
+ field = pix->field;
+ break;
+ case V4L2_FIELD_INTERLACED:
+ /* Query for standard if not explicitly mentioned _TB/_BT */
+ ret = v4l2_subdev_call(sd, video, querystd, &std);
+ if (ret < 0)
+ std = V4L2_STD_625_50;
+
+ field = std & V4L2_STD_625_50 ? V4L2_FIELD_INTERLACED_TB :
+ V4L2_FIELD_INTERLACED_BT;
+ break;
+ }
+
+ xlate = soc_camera_xlate_by_fourcc(icd, pixfmt);
+ if (!xlate) {
+ dev_warn(dev, "Format %x not found\n", pixfmt);
+ return -EINVAL;
+ }
+ /* Calculate client output geometry */
+ soc_camera_calc_client_output(icd, &cam->rect, &cam->subrect, pix, &mf, 12);
+ mf.field = pix->field;
+ mf.colorspace = pix->colorspace;
+ mf.code = xlate->code;
+
+ switch (pixfmt) {
+ case V4L2_PIX_FMT_RGB32:
+ can_scale = priv->chip != RCAR_E1;
+ break;
+ case V4L2_PIX_FMT_UYVY:
+ case V4L2_PIX_FMT_YUYV:
+ case V4L2_PIX_FMT_RGB565:
+ case V4L2_PIX_FMT_RGB555X:
+ can_scale = true;
+ break;
+ default:
+ can_scale = false;
+ break;
+ }
+
+ dev_dbg(dev, "request camera output %ux%u\n", mf.width, mf.height);
+
+ ret = soc_camera_client_scale(icd, &cam->rect, &cam->subrect,
+ &mf, &vin_sub_width, &vin_sub_height,
+ can_scale, 12);
+
+ /* Done with the camera. Now see if we can improve the result */
+ dev_dbg(dev, "Camera %d fmt %ux%u, requested %ux%u\n",
+ ret, mf.width, mf.height, pix->width, pix->height);
+
+ if (ret == -ENOIOCTLCMD)
+ dev_dbg(dev, "Sensor doesn't support cropping\n");
+ else if (ret < 0)
+ return ret;
+
+ if (mf.code != xlate->code)
+ return -EINVAL;
+
+ /* Prepare VIN crop */
+ cam->width = mf.width;
+ cam->height = mf.height;
+
+ /* Use VIN scaling to scale to the requested user window. */
+
+ /* We cannot scale up */
+ if (pix->width > vin_sub_width)
+ vin_sub_width = pix->width;
+
+ if (pix->height > vin_sub_height)
+ vin_sub_height = pix->height;
+
+ pix->colorspace = mf.colorspace;
+
+ if (!can_scale) {
+ pix->width = vin_sub_width;
+ pix->height = vin_sub_height;
+ }
+
+ /*
+ * We have calculated CFLCR, the actual configuration will be performed
+ * in rcar_vin_set_bus_param()
+ */
+
+ dev_dbg(dev, "W: %u : %u, H: %u : %u\n",
+ vin_sub_width, pix->width, vin_sub_height, pix->height);
+
+ icd->current_fmt = xlate;
+
+ priv->field = field;
+
+ return 0;
+}
+
+static int rcar_vin_try_fmt(struct soc_camera_device *icd,
+ struct v4l2_format *f)
+{
+ const struct soc_camera_format_xlate *xlate;
+ struct v4l2_pix_format *pix = &f->fmt.pix;
+ struct v4l2_subdev *sd = soc_camera_to_subdev(icd);
+ struct v4l2_mbus_framefmt mf;
+ __u32 pixfmt = pix->pixelformat;
+ int width, height;
+ int ret;
+
+ xlate = soc_camera_xlate_by_fourcc(icd, pixfmt);
+ if (!xlate) {
+ xlate = icd->current_fmt;
+ dev_dbg(icd->parent, "Format %x not found, keeping %x\n",
+ pixfmt, xlate->host_fmt->fourcc);
+ pixfmt = xlate->host_fmt->fourcc;
+ pix->pixelformat = pixfmt;
+ pix->colorspace = icd->colorspace;
+ }
+
+ /* FIXME: calculate using depth and bus width */
+ v4l_bound_align_image(&pix->width, 2, VIN_MAX_WIDTH, 1,
+ &pix->height, 4, VIN_MAX_HEIGHT, 2, 0);
+
+ width = pix->width;
+ height = pix->height;
+
+ /* let soc-camera calculate these values */
+ pix->bytesperline = 0;
+ pix->sizeimage = 0;
+
+ /* limit to sensor capabilities */
+ mf.width = pix->width;
+ mf.height = pix->height;
+ mf.field = pix->field;
+ mf.code = xlate->code;
+ mf.colorspace = pix->colorspace;
+
+ ret = v4l2_device_call_until_err(sd->v4l2_dev, soc_camera_grp_id(icd),
+ video, try_mbus_fmt, &mf);
+ if (ret < 0)
+ return ret;
+
+ pix->width = mf.width;
+ pix->height = mf.height;
+ pix->field = mf.field;
+ pix->colorspace = mf.colorspace;
+
+ if (pixfmt == V4L2_PIX_FMT_NV16) {
+ /* FIXME: check against rect_max after converting soc-camera */
+ /* We can scale precisely, need a bigger image from camera */
+ if (pix->width < width || pix->height < height) {
+ /*
+ * We presume, the sensor behaves sanely, i.e. if
+ * requested a bigger rectangle, it will not return a
+ * smaller one.
+ */
+ mf.width = VIN_MAX_WIDTH;
+ mf.height = VIN_MAX_HEIGHT;
+ ret = v4l2_device_call_until_err(sd->v4l2_dev,
+ soc_camera_grp_id(icd),
+ video, try_mbus_fmt,
+ &mf);
+ if (ret < 0) {
+ dev_err(icd->parent,
+ "client try_fmt() = %d\n", ret);
+ return ret;
+ }
+ }
+ /* We will scale exactly */
+ if (mf.width > width)
+ pix->width = width;
+ if (mf.height > height)
+ pix->height = height;
+ }
+
+ return ret;
+}
+
+static unsigned int rcar_vin_poll(struct file *file, poll_table *pt)
+{
+ struct soc_camera_device *icd = file->private_data;
+
+ return vb2_poll(&icd->vb2_vidq, file, pt);
+}
+
+static int rcar_vin_querycap(struct soc_camera_host *ici,
+ struct v4l2_capability *cap)
+{
+ strlcpy(cap->card, "R_Car_VIN", sizeof(cap->card));
+ cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_STREAMING;
+ return 0;
+}
+
+static int rcar_vin_init_videobuf2(struct vb2_queue *vq,
+ struct soc_camera_device *icd)
+{
+ vq->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
+ vq->io_modes = VB2_MMAP | VB2_USERPTR;
+ vq->drv_priv = icd;
+ vq->ops = &rcar_vin_vb2_ops;
+ vq->mem_ops = &vb2_dma_contig_memops;
+ vq->buf_struct_size = sizeof(struct rcar_vin_buffer);
+ vq->timestamp_type = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
+
+ return vb2_queue_init(vq);
+}
+
+static struct soc_camera_host_ops rcar_vin_host_ops = {
+ .owner = THIS_MODULE,
+ .add = rcar_vin_add_device,
+ .remove = rcar_vin_remove_device,
+ .clock_start = rcar_vin_clock_start,
+ .clock_stop = rcar_vin_clock_stop,
+ .get_formats = rcar_vin_get_formats,
+ .put_formats = rcar_vin_put_formats,
+ .get_crop = rcar_vin_get_crop,
+ .set_crop = rcar_vin_set_crop,
+ .try_fmt = rcar_vin_try_fmt,
+ .set_fmt = rcar_vin_set_fmt,
+ .poll = rcar_vin_poll,
+ .querycap = rcar_vin_querycap,
+ .set_bus_param = rcar_vin_set_bus_param,
+ .init_videobuf2 = rcar_vin_init_videobuf2,
+};
+
+static struct platform_device_id rcar_vin_id_table[] = {
+ { "r8a7779-vin", RCAR_H1 },
+ { "r8a7778-vin", RCAR_M1 },
+ { "uPD35004-vin", RCAR_E1 },
+ {},
+};
+MODULE_DEVICE_TABLE(platform, rcar_vin_id_table);
+
+static int rcar_vin_probe(struct platform_device *pdev)
+{
+ struct rcar_vin_priv *priv;
+ struct resource *mem;
+ struct rcar_vin_platform_data *pdata;
+ int irq, ret;
+
+ pdata = pdev->dev.platform_data;
+ if (!pdata || !pdata->flags) {
+ dev_err(&pdev->dev, "platform data not set\n");
+ return -EINVAL;
+ }
+
+ mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ if (mem == NULL)
+ return -EINVAL;
+
+ irq = platform_get_irq(pdev, 0);
+ if (irq <= 0)
+ return -EINVAL;
+
+ priv = devm_kzalloc(&pdev->dev, sizeof(struct rcar_vin_priv),
+ GFP_KERNEL);
+ if (!priv)
+ return -ENOMEM;
+
+ priv->base = devm_ioremap_resource(&pdev->dev, mem);
+ if (IS_ERR(priv->base))
+ return PTR_ERR(priv->base);
+
+ ret = devm_request_irq(&pdev->dev, irq, rcar_vin_irq, IRQF_SHARED,
+ dev_name(&pdev->dev), priv);
+ if (ret)
+ return ret;
+
+ priv->alloc_ctx = vb2_dma_contig_init_ctx(&pdev->dev);
+ if (IS_ERR(priv->alloc_ctx))
+ return PTR_ERR(priv->alloc_ctx);
+
+ priv->ici.priv = priv;
+ priv->ici.v4l2_dev.dev = &pdev->dev;
+ priv->ici.nr = pdev->id;
+ priv->ici.drv_name = dev_name(&pdev->dev);
+ priv->ici.ops = &rcar_vin_host_ops;
+
+ priv->pdata = pdata;
+ priv->chip = pdev->id_entry->driver_data;
+ spin_lock_init(&priv->lock);
+ INIT_LIST_HEAD(&priv->capture);
+
+ priv->state = STOPPED;
+
+ pm_suspend_ignore_children(&pdev->dev, true);
+ pm_runtime_enable(&pdev->dev);
+
+ ret = soc_camera_host_register(&priv->ici);
+ if (ret)
+ goto cleanup;
+
+ return 0;
+
+cleanup:
+ pm_runtime_disable(&pdev->dev);
+ vb2_dma_contig_cleanup_ctx(priv->alloc_ctx);
+
+ return ret;
+}
+
+static int rcar_vin_remove(struct platform_device *pdev)
+{
+ struct soc_camera_host *soc_host = to_soc_camera_host(&pdev->dev);
+ struct rcar_vin_priv *priv = container_of(soc_host,
+ struct rcar_vin_priv, ici);
+
+ soc_camera_host_unregister(soc_host);
+ pm_runtime_disable(&pdev->dev);
+ vb2_dma_contig_cleanup_ctx(priv->alloc_ctx);
+
+ return 0;
+}
+
+static struct platform_driver rcar_vin_driver = {
+ .probe = rcar_vin_probe,
+ .remove = rcar_vin_remove,
+ .driver = {
+ .name = DRV_NAME,
+ .owner = THIS_MODULE,
+ },
+ .id_table = rcar_vin_id_table,
+};
+
+module_platform_driver(rcar_vin_driver);
+
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:rcar_vin");
+MODULE_DESCRIPTION("Renesas R-Car VIN camera host driver");
Index: media_tree/include/linux/platform_data/camera-rcar.h
===================================================================
--- /dev/null
+++ media_tree/include/linux/platform_data/camera-rcar.h
@@ -0,0 +1,25 @@
+/*
+ * Platform data for Renesas R-Car VIN soc-camera driver
+ *
+ * Copyright (C) 2011-2013 Renesas Solutions Corp.
+ * Copyright (C) 2013 Cogent Embedded, Inc., <source@cogentembedded.com>
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation; either version 2 of the License, or (at your
+ * option) any later version.
+ */
+
+#ifndef __CAMERA_RCAR_H_
+#define __CAMERA_RCAR_H_
+
+#define RCAR_VIN_HSYNC_ACTIVE_LOW (1 << 0)
+#define RCAR_VIN_VSYNC_ACTIVE_LOW (1 << 1)
+#define RCAR_VIN_BT601 (1 << 2)
+#define RCAR_VIN_BT656 (1 << 3)
+
+struct rcar_vin_platform_data {
+ unsigned int flags;
+};
+
+#endif /* __CAMERA_RCAR_H_ */
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver
2013-07-19 23:14 Sergei Shtylyov
@ 2013-07-24 16:14 ` Guennadi Liakhovetski
2013-07-24 19:36 ` Vladimir Barinov
2013-07-24 19:40 ` Sergei Shtylyov
0 siblings, 2 replies; 26+ messages in thread
From: Guennadi Liakhovetski @ 2013-07-24 16:14 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: mchehab, linux-media, magnus.damm, linux-sh, phil.edworthy,
matsu, vladimir.barinov
Hi Sergei, Vladimir
So, looks like we're almost there. checkpatch.pl looks pretty good too, I
don't care about > 80 chars, Kconfig seems to be a dull one, have a look
at msleep(1) warning whether it bothers you.
On Sat, 20 Jul 2013, Sergei Shtylyov wrote:
> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>
> Add Renesas R-Car VIN (Video In) V4L2 driver.
>
> Based on the patch by Phil Edworthy <phil.edworthy@renesas.com>.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> [Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed 'enum chip_id'
> values, reordered rcar_vin_id_table[] entries, removed senseless parens from
> to_buf_list() macro, used ALIGN() macro in rcar_vin_setup(), added {} to the
> *if* statement and used 'bool' values instead of 0/1 where necessary, removed
> unused macros, done some reformatting and clarified some comments.]
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> This patch is against the 'media_tree.git' repo.
>
> Changes since version 7:
> - remove 'icd' field from 'struct rcar_vin_priv' in accordance with the commit
> f7f6ce2d09c86bd80ee11bd654a1ac1e8f5dfe13 ([media] soc-camera: move common code
> to soc_camera.c);
> - added mandatory clock_{start|stop}() methods in accordance with the commit
> a78fcc11264b824d9651b55abfeedd16d5cd8415 ([media] soc-camera: make .clock_
> {start,stop} compulsory, .add / .remove optional).
>
> Changes since version 6:
> - sorted #include's alphabetically once again;
> - BUG() on invalid format in rcar_vin_setup();
No, please don't. I think I commented on the use of BUG() in this driver
already. It shall only be used if the machine cannot continue to run. I
don't think this is the sace here.
[snip]
> Index: media_tree/drivers/media/platform/soc_camera/rcar_vin.c
> ===================================================================
> --- /dev/null
> +++ media_tree/drivers/media/platform/soc_camera/rcar_vin.c
> @@ -0,0 +1,1474 @@
[snip]
> + /* output format */
> + switch (icd->current_fmt->host_fmt->fourcc) {
> + case V4L2_PIX_FMT_NV16:
> + iowrite32(ALIGN(cam->width * cam->height, 0x80),
> + priv->base + VNUVAOF_REG);
> + dmr = VNDMR_DTMD_YCSEP;
> + output_is_yuv = true;
> + break;
> + case V4L2_PIX_FMT_YUYV:
> + dmr = VNDMR_BPSM;
> + output_is_yuv = true;
> + break;
> + case V4L2_PIX_FMT_UYVY:
> + dmr = 0;
> + output_is_yuv = true;
> + break;
> + case V4L2_PIX_FMT_RGB555X:
> + dmr = VNDMR_DTMD_ARGB1555;
> + break;
> + case V4L2_PIX_FMT_RGB565:
> + dmr = 0;
> + break;
> + case V4L2_PIX_FMT_RGB32:
> + if (priv->chip == RCAR_H1 || priv->chip == RCAR_E1) {
> + dmr = VNDMR_EXRGB;
> + break;
> + }
> + default:
> + BUG();
as commented above, please, remove
[snip]
> +/* Called with .host_lock held */
> +static int rcar_vin_clock_start(struct soc_camera_host *ici)
> +{
Ok, this looks suspicious to me, because all other drivers activate their
master clock output here. Looking at the datasheet though it does look
like VIN doesn't have a master clock output. In such a case maybe you
could add a clarifying comment here. It might even be worth making these
two callbacks optional too, but this is the only driver so far, that
doesn't use them, so, let's keep it this way for now, just, please, add a
comment.
> + return 0;
> +}
> +
> +/* Called with .host_lock held */
> +static void rcar_vin_clock_stop(struct soc_camera_host *ici)
> +{
> +}
[snip]
> +static const struct soc_mbus_pixelfmt rcar_vin_formats[] = {
> + {
> + .fourcc = V4L2_PIX_FMT_NV16,
> + .name = "NV16",
> + .bits_per_sample = 16,
> + .packing = SOC_MBUS_PACKING_2X8_PADHI,
ehem... you sample 16 bits and you say you have to sample 2 x 8 bits,
something seems wrong to me.
> + .order = SOC_MBUS_ORDER_LE,
> + .layout = SOC_MBUS_LAYOUT_PLANAR_Y_C,
> + },
[snip]
> + ret = soc_camera_client_scale(icd, &cam->rect, &cam->subrect,
> + &mf, &vin_sub_width, &vin_sub_height,
> + can_scale, 12);
> +
> + /* Done with the camera. Now see if we can improve the result */
> + dev_dbg(dev, "Camera %d fmt %ux%u, requested %ux%u\n",
> + ret, mf.width, mf.height, pix->width, pix->height);
> +
> + if (ret == -ENOIOCTLCMD)
> + dev_dbg(dev, "Sensor doesn't support cropping\n");
You mean "scaling"
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver
2013-07-24 16:14 ` Guennadi Liakhovetski
@ 2013-07-24 19:36 ` Vladimir Barinov
2013-07-24 20:38 ` Guennadi Liakhovetski
2013-07-24 19:40 ` Sergei Shtylyov
1 sibling, 1 reply; 26+ messages in thread
From: Vladimir Barinov @ 2013-07-24 19:36 UTC (permalink / raw)
To: Guennadi Liakhovetski
Cc: Sergei Shtylyov, mchehab, linux-media, magnus.damm, linux-sh,
phil.edworthy, matsu
Hi Guennadi,
Thank you for the v8 review.
On 07/24/2013 08:14 PM, Guennadi Liakhovetski wrote:
> [snip]
>> + /* output format */
>> + switch (icd->current_fmt->host_fmt->fourcc) {
>> + case V4L2_PIX_FMT_NV16:
>> + iowrite32(ALIGN(cam->width * cam->height, 0x80),
>> + priv->base + VNUVAOF_REG);
>> + dmr = VNDMR_DTMD_YCSEP;
>> + output_is_yuv = true;
>> + break;
>> + case V4L2_PIX_FMT_YUYV:
>> + dmr = VNDMR_BPSM;
>> + output_is_yuv = true;
>> + break;
>> + case V4L2_PIX_FMT_UYVY:
>> + dmr = 0;
>> + output_is_yuv = true;
>> + break;
>> + case V4L2_PIX_FMT_RGB555X:
>> + dmr = VNDMR_DTMD_ARGB1555;
>> + break;
>> + case V4L2_PIX_FMT_RGB565:
>> + dmr = 0;
>> + break;
>> + case V4L2_PIX_FMT_RGB32:
>> + if (priv->chip == RCAR_H1 || priv->chip == RCAR_E1) {
>> + dmr = VNDMR_EXRGB;
>> + break;
>> + }
>> + default:
>> + BUG();
> as commented above, please, remove
Does WARN_ON(1) work instead of removal?
Regards,
Vladimir
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver
2013-07-24 16:14 ` Guennadi Liakhovetski
2013-07-24 19:36 ` Vladimir Barinov
@ 2013-07-24 19:40 ` Sergei Shtylyov
2013-07-24 20:26 ` Guennadi Liakhovetski
1 sibling, 1 reply; 26+ messages in thread
From: Sergei Shtylyov @ 2013-07-24 19:40 UTC (permalink / raw)
To: Guennadi Liakhovetski
Cc: mchehab, linux-media, magnus.damm, linux-sh, phil.edworthy,
matsu, vladimir.barinov
Hello.
On 07/24/2013 08:14 PM, Guennadi Liakhovetski wrote:
>> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> Add Renesas R-Car VIN (Video In) V4L2 driver.
>> Based on the patch by Phil Edworthy <phil.edworthy@renesas.com>.
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> [Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed 'enum chip_id'
>> values, reordered rcar_vin_id_table[] entries, removed senseless parens from
>> to_buf_list() macro, used ALIGN() macro in rcar_vin_setup(), added {} to the
>> *if* statement and used 'bool' values instead of 0/1 where necessary, removed
>> unused macros, done some reformatting and clarified some comments.]
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> ---
>> This patch is against the 'media_tree.git' repo.
>> Changes since version 7:
>> - remove 'icd' field from 'struct rcar_vin_priv' in accordance with the commit
>> f7f6ce2d09c86bd80ee11bd654a1ac1e8f5dfe13 ([media] soc-camera: move common code
>> to soc_camera.c);
>> - added mandatory clock_{start|stop}() methods in accordance with the commit
>> a78fcc11264b824d9651b55abfeedd16d5cd8415 ([media] soc-camera: make .clock_
>> {start,stop} compulsory, .add / .remove optional).
>> Changes since version 6:
>> - sorted #include's alphabetically once again;
>> - BUG() on invalid format in rcar_vin_setup();
> No, please don't. I think I commented on the use of BUG() in this driver
> already. It shall only be used if the machine cannot continue to run. I
> don't think this is the sace here.
Note that sh_mobile_ceu_camera.c has BUG() in almost the same case.
WBR, Sergei
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver
2013-07-24 19:40 ` Sergei Shtylyov
@ 2013-07-24 20:26 ` Guennadi Liakhovetski
0 siblings, 0 replies; 26+ messages in thread
From: Guennadi Liakhovetski @ 2013-07-24 20:26 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: mchehab, linux-media, magnus.damm, linux-sh, phil.edworthy,
matsu, vladimir.barinov
On Wed, 24 Jul 2013, Sergei Shtylyov wrote:
> Hello.
>
> On 07/24/2013 08:14 PM, Guennadi Liakhovetski wrote:
>
> > > From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>
> > > Add Renesas R-Car VIN (Video In) V4L2 driver.
>
> > > Based on the patch by Phil Edworthy <phil.edworthy@renesas.com>.
>
> > > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> > > [Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed 'enum
> > > chip_id'
> > > values, reordered rcar_vin_id_table[] entries, removed senseless parens
> > > from
> > > to_buf_list() macro, used ALIGN() macro in rcar_vin_setup(), added {} to
> > > the
> > > *if* statement and used 'bool' values instead of 0/1 where necessary,
> > > removed
> > > unused macros, done some reformatting and clarified some comments.]
> > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> > > ---
> > > This patch is against the 'media_tree.git' repo.
>
> > > Changes since version 7:
> > > - remove 'icd' field from 'struct rcar_vin_priv' in accordance with the
> > > commit
> > > f7f6ce2d09c86bd80ee11bd654a1ac1e8f5dfe13 ([media] soc-camera: move
> > > common code
> > > to soc_camera.c);
> > > - added mandatory clock_{start|stop}() methods in accordance with the
> > > commit
> > > a78fcc11264b824d9651b55abfeedd16d5cd8415 ([media] soc-camera: make
> > > .clock_
> > > {start,stop} compulsory, .add / .remove optional).
>
> > > Changes since version 6:
> > > - sorted #include's alphabetically once again;
> > > - BUG() on invalid format in rcar_vin_setup();
>
> > No, please don't. I think I commented on the use of BUG() in this driver
> > already. It shall only be used if the machine cannot continue to run. I
> > don't think this is the sace here.
>
> Note that sh_mobile_ceu_camera.c has BUG() in almost the same case.
Yes, I know. Unfortunately, back then neither the author nor any of the
reviewers realised, that that wasn't a good idea. That doesn't mean though
we have to repeat old mistakes. Would be good to fix that (and probably
multiple other) such occurrences.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver
2013-07-24 19:36 ` Vladimir Barinov
@ 2013-07-24 20:38 ` Guennadi Liakhovetski
0 siblings, 0 replies; 26+ messages in thread
From: Guennadi Liakhovetski @ 2013-07-24 20:38 UTC (permalink / raw)
To: Vladimir Barinov
Cc: Sergei Shtylyov, mchehab, linux-media, magnus.damm, linux-sh,
phil.edworthy, matsu
Hi Vladimir
On Wed, 24 Jul 2013, Vladimir Barinov wrote:
> Hi Guennadi,
>
> Thank you for the v8 review.
>
> On 07/24/2013 08:14 PM, Guennadi Liakhovetski wrote:
> > [snip]
> > > + /* output format */
> > > + switch (icd->current_fmt->host_fmt->fourcc) {
> > > + case V4L2_PIX_FMT_NV16:
> > > + iowrite32(ALIGN(cam->width * cam->height, 0x80),
> > > + priv->base + VNUVAOF_REG);
> > > + dmr = VNDMR_DTMD_YCSEP;
> > > + output_is_yuv = true;
> > > + break;
> > > + case V4L2_PIX_FMT_YUYV:
> > > + dmr = VNDMR_BPSM;
> > > + output_is_yuv = true;
> > > + break;
> > > + case V4L2_PIX_FMT_UYVY:
> > > + dmr = 0;
> > > + output_is_yuv = true;
> > > + break;
> > > + case V4L2_PIX_FMT_RGB555X:
> > > + dmr = VNDMR_DTMD_ARGB1555;
> > > + break;
> > > + case V4L2_PIX_FMT_RGB565:
> > > + dmr = 0;
> > > + break;
> > > + case V4L2_PIX_FMT_RGB32:
> > > + if (priv->chip == RCAR_H1 || priv->chip == RCAR_E1) {
> > > + dmr = VNDMR_EXRGB;
> > > + break;
> > > + }
> > > + default:
> > > + BUG();
> > as commented above, please, remove
> Does WARN_ON(1) work instead of removal?
Sorry, by "remove" I certainly meant replace with a proper handling, not
just delete. In principle the above condition should never be entered,
right? Also for fmt == V4L2_PIX_FMT_RGB32 but chip not one of RCAR_H1 or
RCAR_E1? Well, this function is called from your driver's .buf_queue(),
which doesn't return an error. But yes, I would make rcar_vin_setup()
issue a warning and return an error and then, back in
rcar_vin_videobuf_queue() return the buffer with an error code (goto
error).
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver
2013-06-22 11:45 ` Vladimir Barinov
@ 2013-07-25 3:01 ` Katsuya MATSUBARA
2013-07-25 6:55 ` Vladimir Barinov
0 siblings, 1 reply; 26+ messages in thread
From: Katsuya MATSUBARA @ 2013-07-25 3:01 UTC (permalink / raw)
To: vladimir.barinov
Cc: g.liakhovetski, mchehab, linux-media, magnus.damm, linux-sh,
phil.edworthy, sergei.shtylyov
Hi Vladimir,
Thank you for the revised patch.
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Sat, 20 Jul 2013 03:14:34 +0400
> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>
> Add Renesas R-Car VIN (Video In) V4L2 driver.
>
> Based on the patch by Phil Edworthy <phil.edworthy@renesas.com>.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> [Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed 'enum chip_id'
> values, reordered rcar_vin_id_table[] entries, removed senseless parens from
> to_buf_list() macro, used ALIGN() macro in rcar_vin_setup(), added {} to the
> *if* statement and used 'bool' values instead of 0/1 where necessary, removed
> unused macros, done some reformatting and clarified some comments.]
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> This patch is against the 'media_tree.git' repo.
>
> Changes since version 7:
> - remove 'icd' field from 'struct rcar_vin_priv' in accordance with the commit
> f7f6ce2d09c86bd80ee11bd654a1ac1e8f5dfe13 ([media] soc-camera: move common code
> to soc_camera.c);
> - added mandatory clock_{start|stop}() methods in accordance with the commit
> a78fcc11264b824d9651b55abfeedd16d5cd8415 ([media] soc-camera: make .clock_
> {start,stop} compulsory, .add / .remove optional).
From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Subject: Re: [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver
Date: Sat, 22 Jun 2013 15:45:10 +0400
>> But, captured images are still incorrect that means wrong
>> order of fields desite '_BT' chosen for V4L2_STD_525_60.
>>
> I've ordered the NTSC camera.
> I will return once I get it.
Did you get an NTSC camera and see the field order issue
occurs on your BOCK-W board?
You may want to consider adding a workaround into
the VIN driver if the issue remains in the latest patch.
Thanks,
---
Katsuya Matsubara / IGEL Co., Ltd
matsu@igel.co.jp
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver
2013-07-25 3:01 ` [PATCH v8] " Katsuya MATSUBARA
@ 2013-07-25 6:55 ` Vladimir Barinov
2013-07-25 7:29 ` Katsuya MATSUBARA
0 siblings, 1 reply; 26+ messages in thread
From: Vladimir Barinov @ 2013-07-25 6:55 UTC (permalink / raw)
To: Katsuya MATSUBARA
Cc: g.liakhovetski, mchehab, linux-media, magnus.damm, linux-sh,
phil.edworthy, sergei.shtylyov
Hi Matsubara-san,
On 07/25/2013 07:01 AM, Katsuya MATSUBARA wrote:
> Hi Vladimir,
>
> Thank you for the revised patch.
>
> From: Sergei Shtylyov<sergei.shtylyov@cogentembedded.com>
> Date: Sat, 20 Jul 2013 03:14:34 +0400
>
>> From: Vladimir Barinov<vladimir.barinov@cogentembedded.com>
>>
>> Add Renesas R-Car VIN (Video In) V4L2 driver.
>>
>> Based on the patch by Phil Edworthy<phil.edworthy@renesas.com>.
>>
>> Signed-off-by: Vladimir Barinov<vladimir.barinov@cogentembedded.com>
>> [Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed 'enum chip_id'
>> values, reordered rcar_vin_id_table[] entries, removed senseless parens from
>> to_buf_list() macro, used ALIGN() macro in rcar_vin_setup(), added {} to the
>> *if* statement and used 'bool' values instead of 0/1 where necessary, removed
>> unused macros, done some reformatting and clarified some comments.]
>> Signed-off-by: Sergei Shtylyov<sergei.shtylyov@cogentembedded.com>
>>
>> ---
>> This patch is against the 'media_tree.git' repo.
>>
>> Changes since version 7:
>> - remove 'icd' field from 'struct rcar_vin_priv' in accordance with the commit
>> f7f6ce2d09c86bd80ee11bd654a1ac1e8f5dfe13 ([media] soc-camera: move common code
>> to soc_camera.c);
>> - added mandatory clock_{start|stop}() methods in accordance with the commit
>> a78fcc11264b824d9651b55abfeedd16d5cd8415 ([media] soc-camera: make .clock_
>> {start,stop} compulsory, .add / .remove optional).
> From: Vladimir Barinov<vladimir.barinov@cogentembedded.com>
> Subject: Re: [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver
> Date: Sat, 22 Jun 2013 15:45:10 +0400
>
>>> But, captured images are still incorrect that means wrong
>>> order of fields desite '_BT' chosen for V4L2_STD_525_60.
>>>
>> I've ordered the NTSC camera.
>> I will return once I get it.
> Did you get an NTSC camera and see the field order issue
> occurs on your BOCK-W board?
Yes I did.
> You may want to consider adding a workaround into
> the VIN driver if the issue remains in the latest patch.
Have you seen this patch https://linuxtv.org/patch/19278/ ?
Regards,
Vladimir
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver
2013-07-25 6:55 ` Vladimir Barinov
@ 2013-07-25 7:29 ` Katsuya MATSUBARA
2013-07-26 11:11 ` Guennadi Liakhovetski
0 siblings, 1 reply; 26+ messages in thread
From: Katsuya MATSUBARA @ 2013-07-25 7:29 UTC (permalink / raw)
To: vladimir.barinov
Cc: g.liakhovetski, mchehab, linux-media, magnus.damm, linux-sh,
phil.edworthy, sergei.shtylyov
Hi Vladimir,
From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Date: Thu, 25 Jul 2013 10:55:51 +0400
> Hi Matsubara-san,
>
> On 07/25/2013 07:01 AM, Katsuya MATSUBARA wrote:
>> Hi Vladimir,
>>
>> Thank you for the revised patch.
>>
>> From: Sergei Shtylyov<sergei.shtylyov@cogentembedded.com>
>> Date: Sat, 20 Jul 2013 03:14:34 +0400
>>
>>> From: Vladimir Barinov<vladimir.barinov@cogentembedded.com>
>>>
>>> Add Renesas R-Car VIN (Video In) V4L2 driver.
>>>
>>> Based on the patch by Phil Edworthy<phil.edworthy@renesas.com>.
>>>
>>> Signed-off-by: Vladimir Barinov<vladimir.barinov@cogentembedded.com>
>>> [Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed
>>> 'enum chip_id'
>>> values, reordered rcar_vin_id_table[] entries, removed senseless
>>> parens from
>>> to_buf_list() macro, used ALIGN() macro in rcar_vin_setup(), added {}
>>> to the
>>> *if* statement and used 'bool' values instead of 0/1 where necessary,
>>> *removed
>>> unused macros, done some reformatting and clarified some comments.]
>>> Signed-off-by: Sergei Shtylyov<sergei.shtylyov@cogentembedded.com>
>>>
>>> ---
>>> This patch is against the 'media_tree.git' repo.
>>>
>>> Changes since version 7:
>>> - remove 'icd' field from 'struct rcar_vin_priv' in accordance with the
>>> - commit
>>> f7f6ce2d09c86bd80ee11bd654a1ac1e8f5dfe13 ([media] soc-camera: move
>>> common code
>>> to soc_camera.c);
>>> - added mandatory clock_{start|stop}() methods in accordance with the
>>> - commit
>>> a78fcc11264b824d9651b55abfeedd16d5cd8415 ([media] soc-camera: make
>>> .clock_
>>> {start,stop} compulsory, .add / .remove optional).
>> From: Vladimir Barinov<vladimir.barinov@cogentembedded.com>
>> Subject: Re: [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver
>> Date: Sat, 22 Jun 2013 15:45:10 +0400
>>
>>>> But, captured images are still incorrect that means wrong
>>>> order of fields desite '_BT' chosen for V4L2_STD_525_60.
>>>>
>>> I've ordered the NTSC camera.
>>> I will return once I get it.
>> Did you get an NTSC camera and see the field order issue
>> occurs on your BOCK-W board?
> Yes I did.
>> You may want to consider adding a workaround into
>> the VIN driver if the issue remains in the latest patch.
> Have you seen this patch https://linuxtv.org/patch/19278/ ?
Oh, I missed the mail.
I tested it now and confirmed the issue has gone!
Thank you for fixing it.
---
Katsuya Matsubara / IGEL Co., Ltd
matsu@igel.co.jp
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver
2013-07-25 7:29 ` Katsuya MATSUBARA
@ 2013-07-26 11:11 ` Guennadi Liakhovetski
2013-07-30 7:36 ` Katsuya MATSUBARA
0 siblings, 1 reply; 26+ messages in thread
From: Guennadi Liakhovetski @ 2013-07-26 11:11 UTC (permalink / raw)
To: Katsuya MATSUBARA
Cc: vladimir.barinov, mchehab, linux-media, magnus.damm, linux-sh,
phil.edworthy, sergei.shtylyov
Hello Matsubara-san
On Thu, 25 Jul 2013, Katsuya MATSUBARA wrote:
>
> Hi Vladimir,
>
> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Date: Thu, 25 Jul 2013 10:55:51 +0400
>
> > Hi Matsubara-san,
> >
> > On 07/25/2013 07:01 AM, Katsuya MATSUBARA wrote:
> >> Hi Vladimir,
> >>
> >> Thank you for the revised patch.
> >>
> >> From: Sergei Shtylyov<sergei.shtylyov@cogentembedded.com>
> >> Date: Sat, 20 Jul 2013 03:14:34 +0400
> >>
> >>> From: Vladimir Barinov<vladimir.barinov@cogentembedded.com>
> >>>
> >>> Add Renesas R-Car VIN (Video In) V4L2 driver.
> >>>
> >>> Based on the patch by Phil Edworthy<phil.edworthy@renesas.com>.
> >>>
> >>> Signed-off-by: Vladimir Barinov<vladimir.barinov@cogentembedded.com>
> >>> [Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed
> >>> 'enum chip_id'
> >>> values, reordered rcar_vin_id_table[] entries, removed senseless
> >>> parens from
> >>> to_buf_list() macro, used ALIGN() macro in rcar_vin_setup(), added {}
> >>> to the
> >>> *if* statement and used 'bool' values instead of 0/1 where necessary,
> >>> *removed
> >>> unused macros, done some reformatting and clarified some comments.]
> >>> Signed-off-by: Sergei Shtylyov<sergei.shtylyov@cogentembedded.com>
> >>>
> >>> ---
> >>> This patch is against the 'media_tree.git' repo.
> >>>
> >>> Changes since version 7:
> >>> - remove 'icd' field from 'struct rcar_vin_priv' in accordance with the
> >>> - commit
> >>> f7f6ce2d09c86bd80ee11bd654a1ac1e8f5dfe13 ([media] soc-camera: move
> >>> common code
> >>> to soc_camera.c);
> >>> - added mandatory clock_{start|stop}() methods in accordance with the
> >>> - commit
> >>> a78fcc11264b824d9651b55abfeedd16d5cd8415 ([media] soc-camera: make
> >>> .clock_
> >>> {start,stop} compulsory, .add / .remove optional).
> >> From: Vladimir Barinov<vladimir.barinov@cogentembedded.com>
> >> Subject: Re: [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver
> >> Date: Sat, 22 Jun 2013 15:45:10 +0400
> >>
> >>>> But, captured images are still incorrect that means wrong
> >>>> order of fields desite '_BT' chosen for V4L2_STD_525_60.
> >>>>
> >>> I've ordered the NTSC camera.
> >>> I will return once I get it.
> >> Did you get an NTSC camera and see the field order issue
> >> occurs on your BOCK-W board?
> > Yes I did.
> >> You may want to consider adding a workaround into
> >> the VIN driver if the issue remains in the latest patch.
> > Have you seen this patch https://linuxtv.org/patch/19278/ ?
>
> Oh, I missed the mail.
> I tested it now and confirmed the issue has gone!
Does this mean I can add your Tested-by to v9 of this driver?
> Thank you for fixing it.
> ---
> Katsuya Matsubara / IGEL Co., Ltd
> matsu@igel.co.jp
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver
2013-07-26 11:11 ` Guennadi Liakhovetski
@ 2013-07-30 7:36 ` Katsuya MATSUBARA
2013-07-30 7:45 ` Guennadi Liakhovetski
0 siblings, 1 reply; 26+ messages in thread
From: Katsuya MATSUBARA @ 2013-07-30 7:36 UTC (permalink / raw)
To: g.liakhovetski
Cc: vladimir.barinov, mchehab, linux-media, magnus.damm, linux-sh,
phil.edworthy, sergei.shtylyov
Hi Guennadi,
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Date: Fri, 26 Jul 2013 13:11:52 +0200 (CEST)
> Hello Matsubara-san
>
> On Thu, 25 Jul 2013, Katsuya MATSUBARA wrote:
>
>>
>> Hi Vladimir,
>>
>> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> Date: Thu, 25 Jul 2013 10:55:51 +0400
>>
>> > Hi Matsubara-san,
>> >
>> > On 07/25/2013 07:01 AM, Katsuya MATSUBARA wrote:
>> >> Hi Vladimir,
>> >>
>> >> Thank you for the revised patch.
>> >>
>> >> From: Sergei Shtylyov<sergei.shtylyov@cogentembedded.com>
>> >> Date: Sat, 20 Jul 2013 03:14:34 +0400
>> >>
>> >>> From: Vladimir Barinov<vladimir.barinov@cogentembedded.com>
>> >>>
>> >>> Add Renesas R-Car VIN (Video In) V4L2 driver.
>> >>>
>> >>> Based on the patch by Phil Edworthy<phil.edworthy@renesas.com>.
>> >>>
>> >>> Signed-off-by: Vladimir Barinov<vladimir.barinov@cogentembedded.com>
>> >>> [Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed
>> >>> 'enum chip_id'
>> >>> values, reordered rcar_vin_id_table[] entries, removed senseless
>> >>> parens from
>> >>> to_buf_list() macro, used ALIGN() macro in rcar_vin_setup(), added {}
>> >>> to the
>> >>> *if* statement and used 'bool' values instead of 0/1 where necessary,
>> >>> *removed
>> >>> unused macros, done some reformatting and clarified some comments.]
>> >>> Signed-off-by: Sergei Shtylyov<sergei.shtylyov@cogentembedded.com>
>> >>>
>> >>> ---
>> >>> This patch is against the 'media_tree.git' repo.
>> >>>
>> >>> Changes since version 7:
>> >>> - remove 'icd' field from 'struct rcar_vin_priv' in accordance with the
>> >>> - commit
>> >>> f7f6ce2d09c86bd80ee11bd654a1ac1e8f5dfe13 ([media] soc-camera: move
>> >>> common code
>> >>> to soc_camera.c);
>> >>> - added mandatory clock_{start|stop}() methods in accordance with the
>> >>> - commit
>> >>> a78fcc11264b824d9651b55abfeedd16d5cd8415 ([media] soc-camera: make
>> >>> .clock_
>> >>> {start,stop} compulsory, .add / .remove optional).
>> >> From: Vladimir Barinov<vladimir.barinov@cogentembedded.com>
>> >> Subject: Re: [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver
>> >> Date: Sat, 22 Jun 2013 15:45:10 +0400
>> >>
>> >>>> But, captured images are still incorrect that means wrong
>> >>>> order of fields desite '_BT' chosen for V4L2_STD_525_60.
>> >>>>
>> >>> I've ordered the NTSC camera.
>> >>> I will return once I get it.
>> >> Did you get an NTSC camera and see the field order issue
>> >> occurs on your BOCK-W board?
>> > Yes I did.
>> >> You may want to consider adding a workaround into
>> >> the VIN driver if the issue remains in the latest patch.
>> > Have you seen this patch https://linuxtv.org/patch/19278/ ?
>>
>> Oh, I missed the mail.
>> I tested it now and confirmed the issue has gone!
>
> Does this mean I can add your Tested-by to v9 of this driver?
Sure.
Unfortunately my marzen board has gone from my office.
But I made sure that the v9 VIN driver and the fixed ml86v7667
sensor driver work fine on a BOCK-W board with a NTSC camera.
Tested-by: Katsuya MATSUBARA <matsu@igel.co.jp>
Thanks,
---
Katsuya Matsubara / IGEL Co. Ltd
matsu@igel.co.jp
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver
2013-07-30 7:36 ` Katsuya MATSUBARA
@ 2013-07-30 7:45 ` Guennadi Liakhovetski
0 siblings, 0 replies; 26+ messages in thread
From: Guennadi Liakhovetski @ 2013-07-30 7:45 UTC (permalink / raw)
To: Katsuya MATSUBARA
Cc: vladimir.barinov, mchehab, linux-media, magnus.damm, linux-sh,
phil.edworthy, sergei.shtylyov
Hi Matsubara-san,
On Tue, 30 Jul 2013, Katsuya MATSUBARA wrote:
>
> Hi Guennadi,
>
> From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Date: Fri, 26 Jul 2013 13:11:52 +0200 (CEST)
>
> > Hello Matsubara-san
> >
> > On Thu, 25 Jul 2013, Katsuya MATSUBARA wrote:
> >
> >>
> >> Hi Vladimir,
[snip]
> >> I tested it now and confirmed the issue has gone!
> >
> > Does this mean I can add your Tested-by to v9 of this driver?
>
> Sure.
>
> Unfortunately my marzen board has gone from my office.
> But I made sure that the v9 VIN driver and the fixed ml86v7667
> sensor driver work fine on a BOCK-W board with a NTSC camera.
>
> Tested-by: Katsuya MATSUBARA <matsu@igel.co.jp>
Thanks!
Regards
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 26+ messages in thread
end of thread, other threads:[~2013-07-30 7:45 UTC | newest]
Thread overview: 26+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-23 22:11 [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver Sergei Shtylyov
2013-06-02 18:56 ` Sergei Shtylyov
2013-06-04 1:08 ` Simon Horman
2013-06-13 13:12 ` Guennadi Liakhovetski
2013-06-21 0:50 ` Vladimir Barinov
2013-06-21 20:08 ` Sergei Shtylyov
2013-06-21 4:46 ` Katsuya MATSUBARA
2013-06-21 8:06 ` Vladimir Barinov
2013-06-21 9:09 ` Katsuya MATSUBARA
2013-06-21 9:39 ` Vladimir Barinov
2013-06-21 10:01 ` Katsuya MATSUBARA
2013-06-21 10:32 ` Vladimir Barinov
2013-06-21 13:04 ` Katsuya MATSUBARA
2013-06-22 11:45 ` Vladimir Barinov
2013-07-25 3:01 ` [PATCH v8] " Katsuya MATSUBARA
2013-07-25 6:55 ` Vladimir Barinov
2013-07-25 7:29 ` Katsuya MATSUBARA
2013-07-26 11:11 ` Guennadi Liakhovetski
2013-07-30 7:36 ` Katsuya MATSUBARA
2013-07-30 7:45 ` Guennadi Liakhovetski
2013-07-19 23:14 Sergei Shtylyov
2013-07-24 16:14 ` Guennadi Liakhovetski
2013-07-24 19:36 ` Vladimir Barinov
2013-07-24 20:38 ` Guennadi Liakhovetski
2013-07-24 19:40 ` Sergei Shtylyov
2013-07-24 20:26 ` Guennadi Liakhovetski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).