* [PATCH] V4L: fix ov9650 control clusters
@ 2016-01-19 11:12 Guennadi Liakhovetski
2016-01-24 21:14 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Guennadi Liakhovetski @ 2016-01-19 11:12 UTC (permalink / raw)
To: Linux Media Mailing List; +Cc: Sylwester Nawrocki, Laurent Pinchart
Auto-gain and auto-exposure clusters in the ov9650 driver have both a
size of 2, not 3 controls. Fix this.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
---
drivers/media/i2c/ov9650.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/ov9650.c b/drivers/media/i2c/ov9650.c
index 9fe9006..2baa528 100644
--- a/drivers/media/i2c/ov9650.c
+++ b/drivers/media/i2c/ov9650.c
@@ -1046,8 +1046,8 @@ static int ov965x_initialize_controls(struct ov965x *ov965x)
ctrls->exposure->flags |= V4L2_CTRL_FLAG_VOLATILE;
v4l2_ctrl_auto_cluster(3, &ctrls->auto_wb, 0, false);
- v4l2_ctrl_auto_cluster(3, &ctrls->auto_gain, 0, true);
- v4l2_ctrl_auto_cluster(3, &ctrls->auto_exp, 1, true);
+ v4l2_ctrl_auto_cluster(2, &ctrls->auto_gain, 0, true);
+ v4l2_ctrl_auto_cluster(2, &ctrls->auto_exp, 1, true);
v4l2_ctrl_cluster(2, &ctrls->hflip);
ov965x->sd.ctrl_handler = hdl;
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] V4L: fix ov9650 control clusters
2016-01-19 11:12 [PATCH] V4L: fix ov9650 control clusters Guennadi Liakhovetski
@ 2016-01-24 21:14 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2016-01-24 21:14 UTC (permalink / raw)
To: Guennadi Liakhovetski; +Cc: Linux Media Mailing List, Sylwester Nawrocki
Hi Guennadi,
Thank you for the patch.
On Tuesday 19 January 2016 12:12:48 Guennadi Liakhovetski wrote:
> Auto-gain and auto-exposure clusters in the ov9650 driver have both a
> size of 2, not 3 controls. Fix this.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
I'd change the subject to "v4l: ov9650: Fix control clusters" though.
> ---
> drivers/media/i2c/ov9650.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/ov9650.c b/drivers/media/i2c/ov9650.c
> index 9fe9006..2baa528 100644
> --- a/drivers/media/i2c/ov9650.c
> +++ b/drivers/media/i2c/ov9650.c
> @@ -1046,8 +1046,8 @@ static int ov965x_initialize_controls(struct ov965x
> *ov965x) ctrls->exposure->flags |= V4L2_CTRL_FLAG_VOLATILE;
>
> v4l2_ctrl_auto_cluster(3, &ctrls->auto_wb, 0, false);
> - v4l2_ctrl_auto_cluster(3, &ctrls->auto_gain, 0, true);
> - v4l2_ctrl_auto_cluster(3, &ctrls->auto_exp, 1, true);
> + v4l2_ctrl_auto_cluster(2, &ctrls->auto_gain, 0, true);
> + v4l2_ctrl_auto_cluster(2, &ctrls->auto_exp, 1, true);
> v4l2_ctrl_cluster(2, &ctrls->hflip);
>
> ov965x->sd.ctrl_handler = hdl;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-25 6:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-19 11:12 [PATCH] V4L: fix ov9650 control clusters Guennadi Liakhovetski
2016-01-24 21:14 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).