* [PATCH] media: uvcvideo: fix return value check in uvc_gpio_parse()
@ 2022-10-24 13:49 Yang Yingliang
2022-10-24 18:03 ` Ricardo Ribalda
2022-10-24 18:10 ` Laurent Pinchart
0 siblings, 2 replies; 3+ messages in thread
From: Yang Yingliang @ 2022-10-24 13:49 UTC (permalink / raw)
To: linux-media; +Cc: laurent.pinchart, ribalda, mchehab, yangyingliang
gpiod_to_irq() may return -EPROBE_DEFER, add a minus sign to fix it.
Fixes: 2886477ff987 ("media: uvcvideo: Implement UVC_EXT_GPIO_UNIT")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/media/usb/uvc/uvc_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
index 215fb483efb0..1e6bdd6104ef 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -1267,7 +1267,7 @@ static int uvc_gpio_parse(struct uvc_device *dev)
irq = gpiod_to_irq(gpio_privacy);
if (irq < 0) {
- if (irq != EPROBE_DEFER)
+ if (irq != -EPROBE_DEFER)
dev_err(&dev->udev->dev,
"No IRQ for privacy GPIO (%d)\n", irq);
return irq;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: uvcvideo: fix return value check in uvc_gpio_parse()
2022-10-24 13:49 [PATCH] media: uvcvideo: fix return value check in uvc_gpio_parse() Yang Yingliang
@ 2022-10-24 18:03 ` Ricardo Ribalda
2022-10-24 18:10 ` Laurent Pinchart
1 sibling, 0 replies; 3+ messages in thread
From: Ricardo Ribalda @ 2022-10-24 18:03 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-media, laurent.pinchart, mchehab
Hi Yang
Good catch, luckily the only effect is whether the error message is
printed or not. But it has to be fixed.
On Mon, 24 Oct 2022 at 15:50, Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> gpiod_to_irq() may return -EPROBE_DEFER, add a minus sign to fix it.
>
> Fixes: 2886477ff987 ("media: uvcvideo: Implement UVC_EXT_GPIO_UNIT")
Reviewed-by: Ricardo Ribalda <ribalda@chromium.org>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/media/usb/uvc/uvc_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index 215fb483efb0..1e6bdd6104ef 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -1267,7 +1267,7 @@ static int uvc_gpio_parse(struct uvc_device *dev)
>
> irq = gpiod_to_irq(gpio_privacy);
> if (irq < 0) {
> - if (irq != EPROBE_DEFER)
> + if (irq != -EPROBE_DEFER)
> dev_err(&dev->udev->dev,
> "No IRQ for privacy GPIO (%d)\n", irq);
> return irq;
> --
> 2.25.1
>
--
Ricardo Ribalda
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: uvcvideo: fix return value check in uvc_gpio_parse()
2022-10-24 13:49 [PATCH] media: uvcvideo: fix return value check in uvc_gpio_parse() Yang Yingliang
2022-10-24 18:03 ` Ricardo Ribalda
@ 2022-10-24 18:10 ` Laurent Pinchart
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2022-10-24 18:10 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-media, ribalda, mchehab
Hi Yang,
Thank you for the patch.
On Mon, Oct 24, 2022 at 09:49:32PM +0800, Yang Yingliang wrote:
> gpiod_to_irq() may return -EPROBE_DEFER, add a minus sign to fix it.
>
> Fixes: 2886477ff987 ("media: uvcvideo: Implement UVC_EXT_GPIO_UNIT")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/media/usb/uvc/uvc_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index 215fb483efb0..1e6bdd6104ef 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -1267,7 +1267,7 @@ static int uvc_gpio_parse(struct uvc_device *dev)
>
> irq = gpiod_to_irq(gpio_privacy);
> if (irq < 0) {
> - if (irq != EPROBE_DEFER)
> + if (irq != -EPROBE_DEFER)
Oops.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> dev_err(&dev->udev->dev,
> "No IRQ for privacy GPIO (%d)\n", irq);
> return irq;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-24 20:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-24 13:49 [PATCH] media: uvcvideo: fix return value check in uvc_gpio_parse() Yang Yingliang
2022-10-24 18:03 ` Ricardo Ribalda
2022-10-24 18:10 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).