From: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] media: rcar-csi2: Enable support for r8a77961
Date: Wed, 24 Mar 2021 14:54:55 +0100 [thread overview]
Message-ID: <YFtEr9imzsbImk2y@oden.dyn.berto.se> (raw)
In-Reply-To: <CAMuHMdXbhzzYUwiXg8h2KPdTb-c5peogDK_saGvDir36zNAq4w@mail.gmail.com>
Hi Geert,
Thanks for your feedback.
On 2021-03-23 15:53:27 +0100, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> On Fri, Mar 12, 2021 at 2:26 PM Niklas Söderlund
> <niklas.soderlund+renesas@ragnatech.se> wrote:
> > Enable support for M3-W+ (r8a77961).
> >
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>
> Thanks for your patch!
>
> > --- a/drivers/media/platform/rcar-vin/rcar-csi2.c
> > +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c
> > @@ -1164,6 +1164,10 @@ static const struct of_device_id rcar_csi2_of_table[] = {
> > .compatible = "renesas,r8a7796-csi2",
> > .data = &rcar_csi2_info_r8a7796,
> > },
> > + {
> > + .compatible = "renesas,r8a77961-csi2",
> > + .data = &rcar_csi2_info_r8a7796,
>
> Hence CSI2 on R-Car M3-W+ is handled the same way as R-Car M3-W.
> I don't know what this means for the driver, but according to Technical
> Update TN-RCT-S0359A/E, R-Car M3-W+ supports lane settings 4/2/1 on
> CSI40/41 (like most other R-Car Gen3 SoCs), while R-Car M3-W supports
> only lane setting 4 on CSI40/41.
This is a great find.
The table TN-RCT-S0359A/E correct was not present in datasheets before
v0.80 so it have completely been missed. The trouble is that the current
driver does the wrong thing for M3-W (and allows 4/2/1 lanes) and this
this patch would be correct for M3-W+ while still leaving M3-W
incorrect.
I will resping this series to first correct the M3-W behavior and then
add M3-W on-top.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
Regards,
Niklas Söderlund
prev parent reply other threads:[~2021-03-24 13:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 13:24 [PATCH] media: rcar-csi2: Enable support for r8a77961 Niklas Söderlund
2021-03-17 9:16 ` Niklas Söderlund
2021-03-23 14:53 ` Geert Uytterhoeven
2021-03-24 13:54 ` Niklas Söderlund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFtEr9imzsbImk2y@oden.dyn.berto.se \
--to=niklas.soderlund+renesas@ragnatech.se \
--cc=geert@linux-m68k.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).