* [PATCH v2] staging: media: zoran: moved statement to next line with '*'
@ 2021-04-09 11:40 Mitali Borkar
2021-04-13 14:27 ` Hans Verkuil
0 siblings, 1 reply; 2+ messages in thread
From: Mitali Borkar @ 2021-04-09 11:40 UTC (permalink / raw)
To: clabbe, mchehab, gregkh
Cc: linux-media, linux-staging, linux-kernel, outreachy-kernel, mitali_s
Moved the statement to next line and added '*' before it to meet
linux kernel coding style for long(multi-line) comments.
Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
---
Changes from v1:- made style changes according to linux kernel coding style
for long comments.
drivers/staging/media/zoran/zr36060.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/zoran/zr36060.c b/drivers/staging/media/zoran/zr36060.c
index 035634fc1c6d..8c6f4d792a9d 100644
--- a/drivers/staging/media/zoran/zr36060.c
+++ b/drivers/staging/media/zoran/zr36060.c
@@ -249,7 +249,8 @@ static const char zr36060_ta[8] = { 0, 1, 1, 0, 0, 0, 0, 0 }; //table idx's AC
static const char zr36060_decimation_h[8] = { 2, 1, 1, 0, 0, 0, 0, 0 };
static const char zr36060_decimation_v[8] = { 1, 1, 1, 0, 0, 0, 0, 0 };
-/* SOF (start of frame) segment depends on width,
+/*
+ * SOF (start of frame) segment depends on width,
* height and sampling ratio of each color component
*/
static int zr36060_set_sof(struct zr36060 *ptr)
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] staging: media: zoran: moved statement to next line with '*'
2021-04-09 11:40 [PATCH v2] staging: media: zoran: moved statement to next line with '*' Mitali Borkar
@ 2021-04-13 14:27 ` Hans Verkuil
0 siblings, 0 replies; 2+ messages in thread
From: Hans Verkuil @ 2021-04-13 14:27 UTC (permalink / raw)
To: Mitali Borkar, clabbe, mchehab, gregkh
Cc: linux-media, linux-staging, linux-kernel, outreachy-kernel, mitali_s
On 09/04/2021 13:40, Mitali Borkar wrote:
> Moved the statement to next line and added '*' before it to meet
> linux kernel coding style for long(multi-line) comments.
>
> Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
> ---
>
> Changes from v1:- made style changes according to linux kernel coding style
> for long comments.
>
> drivers/staging/media/zoran/zr36060.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/zoran/zr36060.c b/drivers/staging/media/zoran/zr36060.c
> index 035634fc1c6d..8c6f4d792a9d 100644
> --- a/drivers/staging/media/zoran/zr36060.c
> +++ b/drivers/staging/media/zoran/zr36060.c
> @@ -249,7 +249,8 @@ static const char zr36060_ta[8] = { 0, 1, 1, 0, 0, 0, 0, 0 }; //table idx's AC
> static const char zr36060_decimation_h[8] = { 2, 1, 1, 0, 0, 0, 0, 0 };
> static const char zr36060_decimation_v[8] = { 1, 1, 1, 0, 0, 0, 0, 0 };
>
> -/* SOF (start of frame) segment depends on width,
> +/*
> + * SOF (start of frame) segment depends on width,
> * height and sampling ratio of each color component
> */
> static int zr36060_set_sof(struct zr36060 *ptr)
>
Same problem as with other patches: this sits on top of your v1, so won't apply
to mainline code.
Regards,
Hans
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-13 14:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 11:40 [PATCH v2] staging: media: zoran: moved statement to next line with '*' Mitali Borkar
2021-04-13 14:27 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).