[PATCH] media: staging: ipu3-imgu: clarify the limitation of grid config

[PATCH] media: staging: ipu3-imgu: clarify the limitation of grid config

[Bingbu Cao]

There are some grid configuration limitations for ImgU, which was
not described clearly in current uAPI header file, add the description
to help user to set the grid configuration correctly.

Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
Reported-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
---
 drivers/staging/media/ipu3/include/uapi/intel-ipu3.h | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h b/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h
index fa3d6ee5adf2..65290c1b1892 100644
--- a/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h
+++ b/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h
@@ -34,11 +34,21 @@
  * struct ipu3_uapi_grid_config - Grid plane config
  *
  * @width:	Grid horizontal dimensions, in number of grid blocks(cells).
+ *		For AWB, the range is (16, 80),
+ *		for AF/AE, the range is (16, 32).
  * @height:	Grid vertical dimensions, in number of grid cells.
+ *		For AWB, the range is (16, 60),
+ *		For AF/AE, the range is (16, 24).
  * @block_width_log2:	Log2 of the width of each cell in pixels.
- *			for (2^3, 2^4, 2^5, 2^6, 2^7), values [3, 7].
+ *			For AWB, the range is (2^3, 2^4, 2^5, 2^6),
+ *			values [3, 6].
+ *			For AF/AE, the range is (2^3, 2^4, 2^5, 2^6, 2^7),
+ *			values [3, 7].
  * @block_height_log2:	Log2 of the height of each cell in pixels.
- *			for (2^3, 2^4, 2^5, 2^6, 2^7), values [3, 7].
+ *			For AWB, the range is (2^3, 2^4, 2^5, 2^6),
+ *			values [3, 6].
+ *			For AF/AE, the range is (2^3, 2^4, 2^5, 2^6, 2^7),
+ *			values [3, 7].
  * @height_per_slice:	The number of blocks in vertical axis per slice.
  *			Default 2.
  * @x_start: X value of top left corner of Region of Interest(ROI).
-- 
2.7.4

Re: [PATCH] media: staging: ipu3-imgu: clarify the limitation of grid config

[Laurent Pinchart]

Hi Bingbu,

Thank you for the patch.

On Thu, Oct 14, 2021 at 06:56:17PM +0800, Bingbu Cao wrote:
> There are some grid configuration limitations for ImgU, which was
> not described clearly in current uAPI header file, add the description
> to help user to set the grid configuration correctly.
> 
> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
> Reported-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
> ---
>  drivers/staging/media/ipu3/include/uapi/intel-ipu3.h | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h b/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h
> index fa3d6ee5adf2..65290c1b1892 100644
> --- a/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h
> +++ b/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h
> @@ -34,11 +34,21 @@
>   * struct ipu3_uapi_grid_config - Grid plane config
>   *
>   * @width:	Grid horizontal dimensions, in number of grid blocks(cells).
> + *		For AWB, the range is (16, 80),
> + *		for AF/AE, the range is (16, 32).
>   * @height:	Grid vertical dimensions, in number of grid cells.
> + *		For AWB, the range is (16, 60),
> + *		For AF/AE, the range is (16, 24).
>   * @block_width_log2:	Log2 of the width of each cell in pixels.
> - *			for (2^3, 2^4, 2^5, 2^6, 2^7), values [3, 7].
> + *			For AWB, the range is (2^3, 2^4, 2^5, 2^6),
> + *			values [3, 6].

I would have written

 *			For AWB, the range is [3, 6].

(and similarly below) as I don't think enumerating all the power of two
values brings any additional clarity. This predates this patch though,
so with or without that change,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> + *			For AF/AE, the range is (2^3, 2^4, 2^5, 2^6, 2^7),
> + *			values [3, 7].
>   * @block_height_log2:	Log2 of the height of each cell in pixels.
> - *			for (2^3, 2^4, 2^5, 2^6, 2^7), values [3, 7].
> + *			For AWB, the range is (2^3, 2^4, 2^5, 2^6),
> + *			values [3, 6].
> + *			For AF/AE, the range is (2^3, 2^4, 2^5, 2^6, 2^7),
> + *			values [3, 7].
>   * @height_per_slice:	The number of blocks in vertical axis per slice.
>   *			Default 2.
>   * @x_start: X value of top left corner of Region of Interest(ROI).

-- 
Regards,

Laurent Pinchart