* [PATCH 1/2] dt-bindings: media: i2c: Add IMX519 CMOS sensor binding
@ 2021-11-02 8:19 Arducam info
2022-02-03 22:01 ` Sakari Ailus
0 siblings, 1 reply; 2+ messages in thread
From: Arducam info @ 2021-11-02 8:19 UTC (permalink / raw)
To: linux-media; +Cc: Arducam info
Add YAML device tree binding for IMX519 CMOS image sensor, and
the relevant MAINTAINERS entries.
Signed-off-by: Lee Jackson <info@arducam.com>
---
.../devicetree/bindings/media/i2c/imx519.yaml | 113 ++++++++++++++++++
MAINTAINERS | 8 ++
2 files changed, 121 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/i2c/imx519.yaml
diff --git a/Documentation/devicetree/bindings/media/i2c/imx519.yaml b/Documentation/devicetree/bindings/media/i2c/imx519.yaml
new file mode 100644
index 000000000000..717230a21764
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/imx519.yaml
@@ -0,0 +1,113 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/imx519.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sony 1/2.5-Inch 16Mpixel CMOS Digital Image Sensor
+
+maintainers:
+ - Lee Jackson <info@arducam.com>
+
+description: |-
+ The Sony IMX519 is a 1/2.5-inch CMOS active pixel digital image sensor
+ with an active array size of 4656H x 3496V. It is programmable through
+ I2C interface. The I2C address is fixed to 0x1A as per sensor data sheet.
+ Image data is sent through MIPI CSI-2, which is configured as either 2 or
+ 4 data lanes.
+
+properties:
+ compatible:
+ const: sony,imx519
+
+ reg:
+ description: I2C device address
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ VDIG-supply:
+ description:
+ Digital I/O voltage supply, 1.05 volts
+
+ VANA-supply:
+ description:
+ Analog voltage supply, 2.8 volts
+
+ VDDL-supply:
+ description:
+ Digital core voltage supply, 1.8 volts
+
+ reset-gpios:
+ description: |-
+ Reference to the GPIO connected to the xclr pin, if any.
+ Must be released (set high) after all supplies and INCK are applied.
+
+ # See ../video-interfaces.txt for more details
+ port:
+ type: object
+ properties:
+ endpoint:
+ type: object
+ properties:
+ data-lanes:
+ description: |-
+ The sensor supports either two-lane, or four-lane operation.
+ For two-lane operation the property must be set to <1 2>.
+ items:
+ - const: 1
+ - const: 2
+
+ clock-noncontinuous:
+ type: boolean
+ description: |-
+ MIPI CSI-2 clock is non-continuous if this property is present,
+ otherwise it's continuous.
+
+ link-frequencies:
+ allOf:
+ - $ref: /schemas/types.yaml#/definitions/uint64-array
+ description:
+ Allowed data bus frequencies.
+
+ required:
+ - link-frequencies
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - VANA-supply
+ - VDIG-supply
+ - VDDL-supply
+ - port
+
+additionalProperties: false
+
+examples:
+ - |
+ i2c0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ imx519: sensor@1a {
+ compatible = "sony,imx519";
+ reg = <0x1a>;
+ clocks = <&imx519_clk>;
+ VANA-supply = <&imx519_vana>; /* 2.8v */
+ VDIG-supply = <&imx519_vdig>; /* 1.05v */
+ VDDL-supply = <&imx519_vddl>; /* 1.8v */
+
+ port {
+ imx519_0: endpoint {
+ remote-endpoint = <&csi1_ep>;
+ data-lanes = <1 2>;
+ clock-noncontinuous;
+ link-frequencies = /bits/ 64 <493500000>;
+ };
+ };
+ };
+ };
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index ee91c5472bc1..5db23bde7e73 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -17492,6 +17492,14 @@ T: git git://linuxtv.org/media_tree.git
F: Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
F: drivers/media/i2c/imx412.c
+SONY IMX519 SENSOR DRIVER
+M: Arducam Kernel Maintenance <info@arducam.com>
+L: linux-media@vger.kernel.org
+S: Maintained
+T: git git://linuxtv.org/media_tree.git
+F: Documentation/devicetree/bindings/media/i2c/imx519.yaml
+F: drivers/media/i2c/imx519.c
+
SONY MEMORYSTICK SUBSYSTEM
M: Maxim Levitsky <maximlevitsky@gmail.com>
M: Alex Dubov <oakad@yahoo.com>
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] dt-bindings: media: i2c: Add IMX519 CMOS sensor binding
2021-11-02 8:19 [PATCH 1/2] dt-bindings: media: i2c: Add IMX519 CMOS sensor binding Arducam info
@ 2022-02-03 22:01 ` Sakari Ailus
0 siblings, 0 replies; 2+ messages in thread
From: Sakari Ailus @ 2022-02-03 22:01 UTC (permalink / raw)
To: Arducam info; +Cc: linux-media
Hi Lee,
Thanks for the patches. Please see my comments below.
On Tue, Nov 02, 2021 at 04:19:12PM +0800, Arducam info wrote:
> Add YAML device tree binding for IMX519 CMOS image sensor, and
> the relevant MAINTAINERS entries.
>
> Signed-off-by: Lee Jackson <info@arducam.com>
Is this your real e-mail address?
The From: header and the Signed-off-by: tags should match.
Please also cc v2 to Rob Herring and the devicetree list.
> ---
> .../devicetree/bindings/media/i2c/imx519.yaml | 113 ++++++++++++++++++
> MAINTAINERS | 8 ++
> 2 files changed, 121 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/imx519.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/imx519.yaml b/Documentation/devicetree/bindings/media/i2c/imx519.yaml
> new file mode 100644
> index 000000000000..717230a21764
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/imx519.yaml
> @@ -0,0 +1,113 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/imx519.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sony 1/2.5-Inch 16Mpixel CMOS Digital Image Sensor
> +
> +maintainers:
> + - Lee Jackson <info@arducam.com>
> +
> +description: |-
> + The Sony IMX519 is a 1/2.5-inch CMOS active pixel digital image sensor
> + with an active array size of 4656H x 3496V. It is programmable through
> + I2C interface. The I2C address is fixed to 0x1A as per sensor data sheet.
> + Image data is sent through MIPI CSI-2, which is configured as either 2 or
> + 4 data lanes.
> +
> +properties:
> + compatible:
> + const: sony,imx519
> +
> + reg:
> + description: I2C device address
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + VDIG-supply:
> + description:
> + Digital I/O voltage supply, 1.05 volts
> +
> + VANA-supply:
> + description:
> + Analog voltage supply, 2.8 volts
> +
> + VDDL-supply:
> + description:
> + Digital core voltage supply, 1.8 volts
> +
> + reset-gpios:
> + description: |-
> + Reference to the GPIO connected to the xclr pin, if any.
> + Must be released (set high) after all supplies and INCK are applied.
> +
> + # See ../video-interfaces.txt for more details
Please refer to video-interfaces.yaml schema instead. See e.g.
Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml .
> + port:
> + type: object
> + properties:
> + endpoint:
> + type: object
> + properties:
> + data-lanes:
> + description: |-
> + The sensor supports either two-lane, or four-lane operation.
> + For two-lane operation the property must be set to <1 2>.
> + items:
> + - const: 1
> + - const: 2
Four lanes are also supported. You could simply use minItems and maxItems
here, as other bindings do.
> +
> + clock-noncontinuous:
> + type: boolean
> + description: |-
> + MIPI CSI-2 clock is non-continuous if this property is present,
> + otherwise it's continuous.
No need for a description, this is in schema. The same for other
properties, too, if there isn't something device specific to say.
> +
> + link-frequencies:
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint64-array
> + description:
> + Allowed data bus frequencies.
> +
> + required:
> + - link-frequencies
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - VANA-supply
> + - VDIG-supply
> + - VDDL-supply
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + imx519: sensor@1a {
> + compatible = "sony,imx519";
> + reg = <0x1a>;
> + clocks = <&imx519_clk>;
> + VANA-supply = <&imx519_vana>; /* 2.8v */
> + VDIG-supply = <&imx519_vdig>; /* 1.05v */
> + VDDL-supply = <&imx519_vddl>; /* 1.8v */
> +
> + port {
> + imx519_0: endpoint {
> + remote-endpoint = <&csi1_ep>;
> + data-lanes = <1 2>;
> + clock-noncontinuous;
> + link-frequencies = /bits/ 64 <493500000>;
> + };
> + };
> + };
> + };
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ee91c5472bc1..5db23bde7e73 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -17492,6 +17492,14 @@ T: git git://linuxtv.org/media_tree.git
> F: Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
> F: drivers/media/i2c/imx412.c
>
> +SONY IMX519 SENSOR DRIVER
> +M: Arducam Kernel Maintenance <info@arducam.com>
> +L: linux-media@vger.kernel.org
> +S: Maintained
> +T: git git://linuxtv.org/media_tree.git
> +F: Documentation/devicetree/bindings/media/i2c/imx519.yaml
> +F: drivers/media/i2c/imx519.c
> +
> SONY MEMORYSTICK SUBSYSTEM
> M: Maxim Levitsky <maximlevitsky@gmail.com>
> M: Alex Dubov <oakad@yahoo.com>
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-03 22:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-02 8:19 [PATCH 1/2] dt-bindings: media: i2c: Add IMX519 CMOS sensor binding Arducam info
2022-02-03 22:01 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).