* [PATCH 1/1] media: sunxi: Depend on GENERIC_PHY_MIPI_DPHY
@ 2022-07-13 19:25 Sakari Ailus
2022-07-13 19:32 ` Laurent Pinchart
2022-07-19 8:55 ` Paul Kocialkowski
0 siblings, 2 replies; 5+ messages in thread
From: Sakari Ailus @ 2022-07-13 19:25 UTC (permalink / raw)
To: linux-media; +Cc: Paul Kocialkowski, Chen-Yu Tsai, Hans Verkuil, Samuel Holland
The sun6i-mipi-csi2 and sun6i-a83t-mipi-csi2 drivers depend on the generic
MIPI D-PHY support. Select it. This fixes a linking problem when either of
these drivers is enabled and GENERIC_PHY_MIPI_DPHY is disabled.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig | 1 +
drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig
index b1712f5873fd9..eb982466abd30 100644
--- a/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig
+++ b/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig
@@ -8,6 +8,7 @@ config VIDEO_SUN6I_MIPI_CSI2
select VIDEO_V4L2_SUBDEV_API
select V4L2_FWNODE
select PHY_SUN6I_MIPI_DPHY
+ select GENERIC_PHY_MIPI_DPHY
select REGMAP_MMIO
help
Support for the Allwinner A31 MIPI CSI-2 controller, also found on
diff --git a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
index 5854f8388c92a..789d58ee12ea9 100644
--- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
+++ b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
@@ -8,5 +8,6 @@ config VIDEO_SUN8I_A83T_MIPI_CSI2
select VIDEO_V4L2_SUBDEV_API
select V4L2_FWNODE
select REGMAP_MMIO
+ select GENERIC_PHY_MIPI_DPHY
help
Support for the Allwinner A83T MIPI CSI-2 controller and D-PHY.
--
2.30.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] media: sunxi: Depend on GENERIC_PHY_MIPI_DPHY
2022-07-13 19:25 [PATCH 1/1] media: sunxi: Depend on GENERIC_PHY_MIPI_DPHY Sakari Ailus
@ 2022-07-13 19:32 ` Laurent Pinchart
2022-07-19 8:55 ` Paul Kocialkowski
1 sibling, 0 replies; 5+ messages in thread
From: Laurent Pinchart @ 2022-07-13 19:32 UTC (permalink / raw)
To: Sakari Ailus
Cc: linux-media, Paul Kocialkowski, Chen-Yu Tsai, Hans Verkuil,
Samuel Holland
Hi Sakari,
Thank you for the patch.
On Wed, Jul 13, 2022 at 10:25:40PM +0300, Sakari Ailus wrote:
> The sun6i-mipi-csi2 and sun6i-a83t-mipi-csi2 drivers depend on the generic
> MIPI D-PHY support. Select it. This fixes a linking problem when either of
> these drivers is enabled and GENERIC_PHY_MIPI_DPHY is disabled.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig | 1 +
> drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig
> index b1712f5873fd9..eb982466abd30 100644
> --- a/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig
> +++ b/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig
> @@ -8,6 +8,7 @@ config VIDEO_SUN6I_MIPI_CSI2
> select VIDEO_V4L2_SUBDEV_API
> select V4L2_FWNODE
> select PHY_SUN6I_MIPI_DPHY
> + select GENERIC_PHY_MIPI_DPHY
> select REGMAP_MMIO
> help
> Support for the Allwinner A31 MIPI CSI-2 controller, also found on
> diff --git a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
> index 5854f8388c92a..789d58ee12ea9 100644
> --- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
> +++ b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
> @@ -8,5 +8,6 @@ config VIDEO_SUN8I_A83T_MIPI_CSI2
> select VIDEO_V4L2_SUBDEV_API
> select V4L2_FWNODE
> select REGMAP_MMIO
> + select GENERIC_PHY_MIPI_DPHY
> help
> Support for the Allwinner A83T MIPI CSI-2 controller and D-PHY.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] media: sunxi: Depend on GENERIC_PHY_MIPI_DPHY
2022-07-13 19:25 [PATCH 1/1] media: sunxi: Depend on GENERIC_PHY_MIPI_DPHY Sakari Ailus
2022-07-13 19:32 ` Laurent Pinchart
@ 2022-07-19 8:55 ` Paul Kocialkowski
2022-07-19 11:27 ` Sakari Ailus
1 sibling, 1 reply; 5+ messages in thread
From: Paul Kocialkowski @ 2022-07-19 8:55 UTC (permalink / raw)
To: Sakari Ailus; +Cc: linux-media, Chen-Yu Tsai, Hans Verkuil, Samuel Holland
[-- Attachment #1: Type: text/plain, Size: 2170 bytes --]
Hi Sakari,
On Wed 13 Jul 22, 22:25, Sakari Ailus wrote:
> The sun6i-mipi-csi2 and sun6i-a83t-mipi-csi2 drivers depend on the generic
> MIPI D-PHY support. Select it. This fixes a linking problem when either of
> these drivers is enabled and GENERIC_PHY_MIPI_DPHY is disabled.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Looks good to me but I have one question below.
Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cheers,
Paul
> ---
> drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig | 1 +
> drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig
> index b1712f5873fd9..eb982466abd30 100644
> --- a/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig
> +++ b/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig
> @@ -8,6 +8,7 @@ config VIDEO_SUN6I_MIPI_CSI2
> select VIDEO_V4L2_SUBDEV_API
> select V4L2_FWNODE
> select PHY_SUN6I_MIPI_DPHY
> + select GENERIC_PHY_MIPI_DPHY
Since we select PHY_SUN6I_MIPI_DPHY here which also selects
GENERIC_PHY_MIPI_DPHY, I suppose this is not strictly needed?
Still feels like a good idea to have it since the driver does use the generic
MIPI D-PHY API.
Thanks,
Paul
> select REGMAP_MMIO
> help
> Support for the Allwinner A31 MIPI CSI-2 controller, also found on
> diff --git a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
> index 5854f8388c92a..789d58ee12ea9 100644
> --- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
> +++ b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
> @@ -8,5 +8,6 @@ config VIDEO_SUN8I_A83T_MIPI_CSI2
> select VIDEO_V4L2_SUBDEV_API
> select V4L2_FWNODE
> select REGMAP_MMIO
> + select GENERIC_PHY_MIPI_DPHY
> help
> Support for the Allwinner A83T MIPI CSI-2 controller and D-PHY.
> --
> 2.30.2
>
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] media: sunxi: Depend on GENERIC_PHY_MIPI_DPHY
2022-07-19 8:55 ` Paul Kocialkowski
@ 2022-07-19 11:27 ` Sakari Ailus
2022-07-19 12:08 ` Paul Kocialkowski
0 siblings, 1 reply; 5+ messages in thread
From: Sakari Ailus @ 2022-07-19 11:27 UTC (permalink / raw)
To: Paul Kocialkowski; +Cc: linux-media, Chen-Yu Tsai, Hans Verkuil, Samuel Holland
Hi Paul,
On Tue, Jul 19, 2022 at 10:55:06AM +0200, Paul Kocialkowski wrote:
> Hi Sakari,
>
> On Wed 13 Jul 22, 22:25, Sakari Ailus wrote:
> > The sun6i-mipi-csi2 and sun6i-a83t-mipi-csi2 drivers depend on the generic
> > MIPI D-PHY support. Select it. This fixes a linking problem when either of
> > these drivers is enabled and GENERIC_PHY_MIPI_DPHY is disabled.
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
>
> Looks good to me but I have one question below.
>
> Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
>
> Cheers,
>
> Paul
>
> > ---
> > drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig | 1 +
> > drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig
> > index b1712f5873fd9..eb982466abd30 100644
> > --- a/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig
> > +++ b/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig
> > @@ -8,6 +8,7 @@ config VIDEO_SUN6I_MIPI_CSI2
> > select VIDEO_V4L2_SUBDEV_API
> > select V4L2_FWNODE
> > select PHY_SUN6I_MIPI_DPHY
> > + select GENERIC_PHY_MIPI_DPHY
>
> Since we select PHY_SUN6I_MIPI_DPHY here which also selects
> GENERIC_PHY_MIPI_DPHY, I suppose this is not strictly needed?
In that case the symbols won't be present in modpost and that causes a build
failure.
Thanks for the review. The patch is already merged though.
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] media: sunxi: Depend on GENERIC_PHY_MIPI_DPHY
2022-07-19 11:27 ` Sakari Ailus
@ 2022-07-19 12:08 ` Paul Kocialkowski
0 siblings, 0 replies; 5+ messages in thread
From: Paul Kocialkowski @ 2022-07-19 12:08 UTC (permalink / raw)
To: Sakari Ailus; +Cc: linux-media, Chen-Yu Tsai, Hans Verkuil, Samuel Holland
[-- Attachment #1: Type: text/plain, Size: 1950 bytes --]
Hi Sakari,
On Tue 19 Jul 22, 11:27, Sakari Ailus wrote:
> Hi Paul,
>
> On Tue, Jul 19, 2022 at 10:55:06AM +0200, Paul Kocialkowski wrote:
> > Hi Sakari,
> >
> > On Wed 13 Jul 22, 22:25, Sakari Ailus wrote:
> > > The sun6i-mipi-csi2 and sun6i-a83t-mipi-csi2 drivers depend on the generic
> > > MIPI D-PHY support. Select it. This fixes a linking problem when either of
> > > these drivers is enabled and GENERIC_PHY_MIPI_DPHY is disabled.
> > >
> > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> >
> > Looks good to me but I have one question below.
> >
> > Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> >
> > Cheers,
> >
> > Paul
> >
> > > ---
> > > drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig | 1 +
> > > drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig | 1 +
> > > 2 files changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig
> > > index b1712f5873fd9..eb982466abd30 100644
> > > --- a/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig
> > > +++ b/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig
> > > @@ -8,6 +8,7 @@ config VIDEO_SUN6I_MIPI_CSI2
> > > select VIDEO_V4L2_SUBDEV_API
> > > select V4L2_FWNODE
> > > select PHY_SUN6I_MIPI_DPHY
> > > + select GENERIC_PHY_MIPI_DPHY
> >
> > Since we select PHY_SUN6I_MIPI_DPHY here which also selects
> > GENERIC_PHY_MIPI_DPHY, I suppose this is not strictly needed?
>
> In that case the symbols won't be present in modpost and that causes a build
> failure.
Oh interesting, thanks!
> Thanks for the review. The patch is already merged though.
Ah, I had a quick look at https://git.linuxtv.org/media_tree.git/
but forgot to check your own tree.
Cheers,
Paul
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-07-19 12:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-13 19:25 [PATCH 1/1] media: sunxi: Depend on GENERIC_PHY_MIPI_DPHY Sakari Ailus
2022-07-13 19:32 ` Laurent Pinchart
2022-07-19 8:55 ` Paul Kocialkowski
2022-07-19 11:27 ` Sakari Ailus
2022-07-19 12:08 ` Paul Kocialkowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).