* Re: [PATCH v2] media: Explicitly include correct DT includes
[not found] <20230718143118.1065743-1-robh@kernel.org>
@ 2023-07-19 18:45 ` Niklas Söderlund
2023-07-22 10:00 ` Sean Young
1 sibling, 0 replies; 2+ messages in thread
From: Niklas Söderlund @ 2023-07-19 18:45 UTC (permalink / raw)
To: Rob Herring
Cc: Hans Verkuil, Mauro Carvalho Chehab, Maxime Coquelin,
Alexandre Torgue, Manivannan Sadhasivam, Laurent Pinchart,
Michael Riesch, Rui Miguel Silva, Steve Longerbeam,
Matt Ranostay, Michael Tretter, Pengutronix Kernel Team,
Ming Qian, Shijie Qin, Zhou Peng, Eddie James, Joel Stanley,
Andrew Jeffery, Philipp Zabel, Bin Liu, Matthias Brugger,
AngeloGioacchino Del Regno, Minghsiu Tsai, Houlong Wei,
Andrew-CT Chen, Tiffany Lin, Yunfei Dong, Dmitry Osipenko,
Thierry Reding, Jonathan Hunter, Shawn Guo, Sascha Hauer,
Fabio Estevam, NXP Linux Team, Stanimir Varbanov, Vikash Garodia,
Bryan O'Donoghue, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Fabrizio Castro, Kieran Bingham, Mikhail Ulyanov, Jacopo Mondi,
Dafna Hirschfeld, Heiko Stuebner, Krz ysztof Kozlowski,
Alim Akhtar, Sylwester Nawrocki, Maxime Ripard, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Yong Deng, Paul Kocialkowski,
Benoit Parrot, Sean Young, Neil Armstrong, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, Sean Wang, devicetree,
linux-media, linux-kernel, linux-stm32, linux-arm-kernel,
openbmc, linux-aspeed, linux-mediatek, linux-tegra,
linux-arm-msm, linux-renesas-soc, linux-rockchip,
linux-samsung-soc, linux-sunxi, linux-amlogic
Hi Rob,
On 2023-07-18 08:31:14 -0600, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> v2:
> - Fix double include of of.h
> ---
For,
> drivers/media/platform/renesas/rcar-isp.c | 2 +-
> drivers/media/platform/renesas/rcar-vin/rcar-core.c | 1 -
> drivers/media/platform/renesas/rcar-vin/rcar-csi2.c | 1 -
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] media: Explicitly include correct DT includes
[not found] <20230718143118.1065743-1-robh@kernel.org>
2023-07-19 18:45 ` [PATCH v2] media: Explicitly include correct DT includes Niklas Söderlund
@ 2023-07-22 10:00 ` Sean Young
1 sibling, 0 replies; 2+ messages in thread
From: Sean Young @ 2023-07-22 10:00 UTC (permalink / raw)
To: Rob Herring
Cc: Hans Verkuil, Mauro Carvalho Chehab, Maxime Coquelin,
Alexandre Torgue, Manivannan Sadhasivam, Laurent Pinchart,
Michael Riesch, Rui Miguel Silva, Steve Longerbeam,
Matt Ranostay, Michael Tretter, Pengutronix Kernel Team,
Ming Qian, Shijie Qin, Zhou Peng, Eddie James, Joel Stanley,
Andrew Jeffery, Philipp Zabel, Bin Liu, Matthias Brugger,
AngeloGioacchino Del Regno, Minghsiu Tsai, Houlong Wei,
Andrew-CT Chen, Tiffany Lin, Yunfei Dong, Dmitry Osipenko,
Thierry Reding, Jonathan Hunter, Shawn Guo, Sascha Hauer,
Fabio Estevam, NXP Linux Team, Stanimir Varbanov, Vikash Garodia,
Bryan O'Donoghue, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Niklas Söderlund, Fabrizio Castro, Kieran Bingham,
Mikhail Ulyanov, Jacopo Mondi, Dafna Hirschfeld, Heiko Stuebner,
Krz ysztof Kozlowski, Alim Akhtar, Sylwester Nawrocki,
Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland,
Yong Deng, Paul Kocialkowski, Benoit Parrot, Neil Armstrong,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl, Sean Wang,
devicetree, linux-media, linux-kernel, linux-stm32,
linux-arm-kernel, openbmc, linux-aspeed, linux-mediatek,
linux-tegra, linux-arm-msm, linux-renesas-soc, linux-rockchip,
linux-samsung-soc, linux-sunxi, linux-amlogic
Hi,
On Tue, Jul 18, 2023 at 08:31:14AM -0600, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
For:
> drivers/media/rc/meson-ir.c | 2 +-
> drivers/media/rc/mtk-cir.c | 3 ++-
> drivers/media/rc/sunxi-cir.c | 3 ++-
Reviewed-by: Sean Young <sean@mess.org>
Thanks,
Sean
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-22 10:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230718143118.1065743-1-robh@kernel.org>
2023-07-19 18:45 ` [PATCH v2] media: Explicitly include correct DT includes Niklas Söderlund
2023-07-22 10:00 ` Sean Young
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).