* [PATCH] s5p-jpeg/jpeg-core.h: fix kernel-doc warnings
@ 2021-03-23 8:39 Hans Verkuil
2021-03-24 11:50 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Hans Verkuil @ 2021-03-23 8:39 UTC (permalink / raw)
To: Linux Media Mailing List
Cc: Krzysztof Kozlowski, Sylwester Nawrocki, Tomasz Figa
Fixes these warnings:
drivers/media/platform/s5p-jpeg/jpeg-core.h:136: warning: Function parameter or member 'irq_ret' not described in 's5p_jpeg'
drivers/media/platform/s5p-jpeg/jpeg-core.h:136: warning: Function parameter or member 'irq_status' not described in 's5p_jpeg'
drivers/media/platform/s5p-jpeg/jpeg-core.h:168: warning: Function parameter or member 'memplanes' not described in 's5p_jpeg_fmt'
drivers/media/platform/s5p-jpeg/jpeg-core.h:168: warning: Function parameter or member 'subsampling' not described in 's5p_jpeg_fmt'
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---
diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.h b/drivers/media/platform/s5p-jpeg/jpeg-core.h
index fcd21ae8bcbe..a77d93c098ce 100644
--- a/drivers/media/platform/s5p-jpeg/jpeg-core.h
+++ b/drivers/media/platform/s5p-jpeg/jpeg-core.h
@@ -111,10 +111,11 @@ enum s5p_jpeg_ctx_state {
* @m2m_dev: v4l2 mem2mem device data
* @regs: JPEG IP registers mapping
* @irq: JPEG IP irq
+ * @irq_ret: JPEG IP irq result value
* @clocks: JPEG IP clock(s)
* @dev: JPEG IP struct device
* @variant: driver variant to be used
- * @irq_status interrupt flags set during single encode/decode
+ * @irq_status: interrupt flags set during single encode/decode
* operation
*/
struct s5p_jpeg {
@@ -152,8 +153,10 @@ struct s5p_jpeg_variant {
* @fourcc: the fourcc code, 0 if not applicable
* @depth: number of bits per pixel
* @colplanes: number of color planes (1 for packed formats)
+ * @memplanes: number of memory planes (1 for packed formats)
* @h_align: horizontal alignment order (align to 2^h_align)
* @v_align: vertical alignment order (align to 2^v_align)
+ * @subsampling:subsampling of a raw format or a JPEG
* @flags: flags describing format applicability
*/
struct s5p_jpeg_fmt {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] s5p-jpeg/jpeg-core.h: fix kernel-doc warnings
2021-03-23 8:39 [PATCH] s5p-jpeg/jpeg-core.h: fix kernel-doc warnings Hans Verkuil
@ 2021-03-24 11:50 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2021-03-24 11:50 UTC (permalink / raw)
To: Hans Verkuil, Linux Media Mailing List; +Cc: Sylwester Nawrocki, Tomasz Figa
On 23/03/2021 09:39, Hans Verkuil wrote:
> Fixes these warnings:
>
> drivers/media/platform/s5p-jpeg/jpeg-core.h:136: warning: Function parameter or member 'irq_ret' not described in 's5p_jpeg'
> drivers/media/platform/s5p-jpeg/jpeg-core.h:136: warning: Function parameter or member 'irq_status' not described in 's5p_jpeg'
> drivers/media/platform/s5p-jpeg/jpeg-core.h:168: warning: Function parameter or member 'memplanes' not described in 's5p_jpeg_fmt'
> drivers/media/platform/s5p-jpeg/jpeg-core.h:168: warning: Function parameter or member 'subsampling' not described in 's5p_jpeg_fmt'
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-24 11:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 8:39 [PATCH] s5p-jpeg/jpeg-core.h: fix kernel-doc warnings Hans Verkuil
2021-03-24 11:50 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).