linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
	Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH 15/22] media: soc_camera: fix a kernel-doc markup
Date: Thu, 30 Nov 2017 08:33:08 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1711300830250.23363@axis700.grange> (raw)
In-Reply-To: <b7ed68fff22e3ce5a6c635099ed5662c6dd7c1a5.1511982439.git.mchehab@s-opensource.com>

On Wed, 29 Nov 2017, Mauro Carvalho Chehab wrote:

> Remove this warning:
> 	drivers/media/platform/soc_camera/soc_scale_crop.c:309: warning: Cannot understand  * @icd		- soc-camera device
> 	 on line 309 - I thought it was a doc line
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

Thanks
Guennadi

> ---
>  drivers/media/platform/soc_camera/soc_scale_crop.c | 21 +++++++++++----------
>  1 file changed, 11 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/media/platform/soc_camera/soc_scale_crop.c b/drivers/media/platform/soc_camera/soc_scale_crop.c
> index 0116097c0c0f..270ec613c27c 100644
> --- a/drivers/media/platform/soc_camera/soc_scale_crop.c
> +++ b/drivers/media/platform/soc_camera/soc_scale_crop.c
> @@ -306,16 +306,17 @@ static int client_set_fmt(struct soc_camera_device *icd,
>  }
>  
>  /**
> - * @icd		- soc-camera device
> - * @rect	- camera cropping window
> - * @subrect	- part of rect, sent to the user
> - * @mf		- in- / output camera output window
> - * @width	- on input: max host input width
> - *		  on output: user width, mapped back to input
> - * @height	- on input: max host input height
> - *		  on output: user height, mapped back to input
> - * @host_can_scale - host can scale this pixel format
> - * @shift	- shift, used for scaling
> + * soc_camera_client_scale
> + * @icd:		soc-camera device
> + * @rect:		camera cropping window
> + * @subrect:		part of rect, sent to the user
> + * @mf:			in- / output camera output window
> + * @width:		on input: max host input width;
> + *			on output: user width, mapped back to input
> + * @height:		on input: max host input height;
> + *			on output: user height, mapped back to input
> + * @host_can_scale:	host can scale this pixel format
> + * @shift:		shift, used for scaling
>   */
>  int soc_camera_client_scale(struct soc_camera_device *icd,
>  			struct v4l2_rect *rect, struct v4l2_rect *subrect,
> -- 
> 2.14.3
> 

  reply	other threads:[~2017-11-30  7:33 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29 19:08 [PATCH 01/22] media: sta2x11: document missing function parameters Mauro Carvalho Chehab
2017-11-29 19:08 ` [PATCH 02/22] media: pxa_camera: get rid of kernel_doc warnings Mauro Carvalho Chehab
2017-11-29 19:08 ` [PATCH 03/22] media: tw68: fix kernel-doc markups Mauro Carvalho Chehab
2017-11-29 19:08 ` [PATCH 04/22] media: ix2505v: get rid of /** comments Mauro Carvalho Chehab
2017-11-29 19:08 ` [PATCH 05/22] media: radio-si476x: fix kernel-doc markups Mauro Carvalho Chehab
2017-11-29 19:08 ` [PATCH 06/22] media: s5k6a3: document some fields at struct s5k6a3 Mauro Carvalho Chehab
2017-11-29 19:08 ` [PATCH 07/22] media: s5k6aa: describe some function parameters Mauro Carvalho Chehab
2017-11-30 19:17   ` Nicholas Mc Guire
2017-11-29 19:08 ` [PATCH 08/22] media: netup_unidvb: fix a bad kernel-doc markup Mauro Carvalho Chehab
2017-11-29 19:08 ` [PATCH 09/22] media: tvp514x: fix kernel-doc parameters Mauro Carvalho Chehab
2017-11-29 19:08 ` [PATCH 10/22] media: vdec: fix some kernel-doc warnings Mauro Carvalho Chehab
2017-11-29 19:08 ` [PATCH 11/22] media: mtk-vpu: add description for wdt fields at struct mtk_vpu Mauro Carvalho Chehab
2017-11-29 19:08 ` [PATCH 12/22] media: s3c-camif: add missing description at s3c_camif_find_format() Mauro Carvalho Chehab
     [not found]   ` <CGME20171130095946epcas2p47a595044e5f5328db0b5a8a17e8888e2@epcas2p4.samsung.com>
2017-11-30  9:59     ` Sylwester Nawrocki
2017-11-29 19:08 ` [PATCH 13/22] media: radio-wl1273: fix a parameter name at kernel-doc macro Mauro Carvalho Chehab
2017-11-29 19:08 ` [PATCH 14/22] media: mt2063: fix some kernel-doc warnings Mauro Carvalho Chehab
2017-11-29 19:08 ` [PATCH 15/22] media: soc_camera: fix a kernel-doc markup Mauro Carvalho Chehab
2017-11-30  7:33   ` Guennadi Liakhovetski [this message]
2017-11-29 19:08 ` [PATCH 16/22] media: vsp1: add a missing kernel-doc parameter Mauro Carvalho Chehab
2017-11-30  9:32   ` Kieran Bingham
2017-11-29 19:08 ` [PATCH 17/22] media: rcar_jpu: fix two kernel-doc markups Mauro Carvalho Chehab
2017-11-29 19:08 ` [PATCH 18/22] media: lm3560: add a missing kernel-doc parameter Mauro Carvalho Chehab
2017-11-29 19:08 ` [PATCH 19/22] media: drivers: remove "/**" from non-kernel-doc comments Mauro Carvalho Chehab
2017-11-30  9:30   ` Kieran Bingham
2017-11-29 19:08 ` [PATCH 20/22] media: dvb_frontends: fix kernel-doc macros Mauro Carvalho Chehab
2017-11-29 19:08 ` [PATCH 21/22] media: docs: add documentation for frontend attach info Mauro Carvalho Chehab
2017-11-29 19:08 ` [PATCH 22/22] media: dvb-frontends: complete kernel-doc markups Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1711300830250.23363@axis700.grange \
    --to=g.liakhovetski@gmx.de \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=mchehab@s-opensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).