From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: "Linux Media Mailing List" <linux-media@vger.kernel.org>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Janusz Krzysztofik" <jmkrzyszt@gmail.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCHv2 for v5.3] v4l2-subdev: fix regression in check_pad()
Date: Tue, 2 Jul 2019 14:15:24 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1907021413060.3147@ramsan.of.borg> (raw)
In-Reply-To: <9885852d-d77e-7bfe-80d4-c4ff20443529@xs4all.nl>
[-- Attachment #1: Type: text/plain, Size: 1272 bytes --]
Hi Hans,
On Sat, 29 Jun 2019, Hans Verkuil wrote:
> sd->entity.graph_obj.mdev can be NULL when this function is called, and
> that breaks existing drivers (rcar-vin, but probably others as well).
>
> Check if sd->entity.num_pads is non-zero instead since that doesn't depend
> on mdev.
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> Reported-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> Fixes: a8fa55078a77 ("media: v4l2-subdev: Verify arguments in v4l2_subdev_call()")
> Tested-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Thanks, this fixes the following boot regression on r8a7791/koelsch:
-rcar-vin e6ef0000.video: Device registered as video27
+rcar-vin e6ef0000.video: Unsupported media bus format for adv7612 13-004c
+rcar-vin e6ef0000.video: Notifier registration failed
+rcar-vin: probe of e6ef0000.video failed with error -22
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2019-07-02 12:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-29 13:00 [PATCHv2 for v5.3] v4l2-subdev: fix regression in check_pad() Hans Verkuil
2019-07-02 12:15 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1907021413060.3147@ramsan.of.borg \
--to=geert@linux-m68k.org \
--cc=hverkuil@xs4all.nl \
--cc=jmkrzyszt@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).