archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <>
To: Hans Verkuil <>
Cc: "Linux Media Mailing List" <>,
	"Niklas Söderlund" <>,
	"Janusz Krzysztofik" <>,
	"Sakari Ailus" <>,
Subject: Re: [PATCHv2 for v5.3] v4l2-subdev: fix regression in check_pad()
Date: Tue, 2 Jul 2019 14:15:24 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1907021413060.3147@ramsan.of.borg> (raw)
In-Reply-To: <>

[-- Attachment #1: Type: text/plain, Size: 1272 bytes --]

 	Hi Hans,

On Sat, 29 Jun 2019, Hans Verkuil wrote:
> sd->entity.graph_obj.mdev can be NULL when this function is called, and
> that breaks existing drivers (rcar-vin, but probably others as well).
> Check if sd->entity.num_pads is non-zero instead since that doesn't depend
> on mdev.
> Signed-off-by: Hans Verkuil <>
> Reported-by: Niklas Söderlund <>
> Fixes: a8fa55078a77 ("media: v4l2-subdev: Verify arguments in v4l2_subdev_call()")
> Tested-by: Niklas Söderlund <>

Thanks, this fixes the following boot regression on r8a7791/koelsch:

     -rcar-vin Device registered as video27
     +rcar-vin Unsupported media bus format for adv7612 13-004c
     +rcar-vin Notifier registration failed
     +rcar-vin: probe of failed with error -22

Tested-by: Geert Uytterhoeven <>



Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
 							    -- Linus Torvalds

      reply	other threads:[~2019-07-02 12:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-29 13:00 Hans Verkuil
2019-07-02 12:15 ` Geert Uytterhoeven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1907021413060.3147@ramsan.of.borg \ \ \ \ \ \ \ \
    --subject='Re: [PATCHv2 for v5.3] v4l2-subdev: fix regression in check_pad()' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).