* [GIT PULL FOR v5.11] media: v4l2: simplify compat ioctl handling
@ 2020-11-03 9:10 Hans Verkuil
2020-11-03 9:31 ` [GIT PULL FOR v5.11] media: v4l2: simplify compat ioctl handling (#68550) Jenkins
0 siblings, 1 reply; 2+ messages in thread
From: Hans Verkuil @ 2020-11-03 9:10 UTC (permalink / raw)
To: Linux Media Mailing List; +Cc: Arnd Bergmann
This simplifies compat32 ioctl handling and removes compat_alloc_user_space()
and copy_in_user() from the kernel.
Tested this with the contrib/test/test-media script and both the 64 and 32 bit
versions of v4l2-ctl and v4l2-compliance ('sudo test-media mc' and
'sudo test-media -32 mc').
Arnd, thank you for your work on this!
Regards,
Hans
The following changes since commit dfe3d19bd092cefb184c6e65b881602c793edd33:
Merge tag 'v5.10-rc1' into patchwork (2020-10-29 09:03:21 +0100)
are available in the Git repository at:
git://linuxtv.org/hverkuil/media_tree.git tags/br-compat32
for you to fetch changes up to 2a911f2d907aa6a5d5bd3996ddb6d45479e5d0df:
media: v4l2: remove remaining compat_ioctl (2020-11-03 09:18:32 +0100)
----------------------------------------------------------------
Tag branch
----------------------------------------------------------------
Arnd Bergmann (8):
media: v4l2: prepare compat-ioctl rework
media: v4l2: remove unneeded compat ioctl handlers
media: v4l2: move v4l2_ext_controls conversion
media: v4l2: move compat handling for v4l2_buffer
media: v4l2: allocate v4l2_clip objects early
media: v4l2: convert v4l2_format compat ioctls
media: v4l2: remaining compat handlers
media: v4l2: remove remaining compat_ioctl
drivers/media/common/saa7146/saa7146_video.c | 6 +-
drivers/media/pci/bt8xx/bttv-driver.c | 8 +-
drivers/media/pci/saa7134/saa7134-video.c | 19 +-
drivers/media/test-drivers/vivid/vivid-vid-cap.c | 18 +-
drivers/media/test-drivers/vivid/vivid-vid-out.c | 18 +-
drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 1772 +++++++++++++++++---------------------------------
drivers/media/v4l2-core/v4l2-ioctl.c | 182 ++++--
include/media/v4l2-ioctl.h | 10 +
include/uapi/linux/videodev2.h | 2 +-
9 files changed, 759 insertions(+), 1276 deletions(-)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [GIT PULL FOR v5.11] media: v4l2: simplify compat ioctl handling (#68550)
2020-11-03 9:10 [GIT PULL FOR v5.11] media: v4l2: simplify compat ioctl handling Hans Verkuil
@ 2020-11-03 9:31 ` Jenkins
0 siblings, 0 replies; 2+ messages in thread
From: Jenkins @ 2020-11-03 9:31 UTC (permalink / raw)
To: mchehab+samsung, linux-media; +Cc: builder
From: builder@linuxtv.org
Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/b16da527-86f2-e28b-0116-997094042142@xs4all.nl/
Build log: https://builder.linuxtv.org/job/patchwork/75386/
Build time: 00:08:29
Link: https://lore.kernel.org/linux-media/b16da527-86f2-e28b-0116-997094042142@xs4all.nl
gpg: Signature made Tue 03 Nov 2020 09:05:44 AM UTC
gpg: using RSA key AAA7FFBA4D2D77EF4CAEA1421326E0CD23ABDCE5
gpg: Good signature from "Hans Verkuil <hverkuil-cisco@xs4all.nl>" [unknown]
gpg: aka "Hans Verkuil <hverkuil@xs4all.nl>" [full]
gpg: Note: This key has expired!
Primary key fingerprint: 052C DE7B C215 053B 689F 1BCA BD2D 6148 6614 3B4C
Subkey fingerprint: AAA7 FFBA 4D2D 77EF 4CAE A142 1326 E0CD 23AB DCE5
Summary: got 2/8 patches with issues, being 2 at build time, plus one error when buinding PDF document
Error/warnings:
patches/0006-media-v4l2-convert-v4l2_format-compat-ioctls.patch:
allmodconfig: return code #0:
../drivers/media/v4l2-core/v4l2-compat-ioctl32.c:1321:6: warning: unused variable ‘aux_space’ [-Wunused-variable]
../drivers/media/v4l2-core/v4l2-compat-ioctl32.c:1320:15: warning: unused variable ‘aux_buf’ [-Wunused-variable]
patches/0007-media-v4l2-remaining-compat-handlers.patch:
allmodconfig: return code #0:
../drivers/media/v4l2-core/v4l2-compat-ioctl32.c:1357:6: warning: unused variable ‘aux_space’ [-Wunused-variable]
../drivers/media/v4l2-core/v4l2-compat-ioctl32.c:1356:15: warning: unused variable ‘aux_buf’ [-Wunused-variable]
At top level:
../drivers/media/v4l2-core/v4l2-compat-ioctl32.c:1324:12: warning: ‘alloc_userspace’ defined but not used [-Wunused-function]
Error #512 when building PDF docs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-03 9:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-03 9:10 [GIT PULL FOR v5.11] media: v4l2: simplify compat ioctl handling Hans Verkuil
2020-11-03 9:31 ` [GIT PULL FOR v5.11] media: v4l2: simplify compat ioctl handling (#68550) Jenkins
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).