[RFC RESEND 0/3] vp9 v4l2 stateless uapi

[RFC RESEND 0/3] vp9 v4l2 stateless uapi

[Andrzej Pietrasiewicz]

Dear All,

This is an RFC on stateless uapi for vp9 decoding with v4l2. This work is based on https://lkml.org/lkml/2020/11/2/1043, but has been substantially reworked. The important change is that the v4l2 control used to pass boolean decoder probabilities has been made unidirectional, and is now called V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS.

In the previous proposal, to queue a frame the userspace must fully dequeue the previous one, which effectively results in a forced lockstep behavior and defeats vb2's capability to enqueue multiple buffers. Such a design was a consequence of backward probability updates being performed by the kernel driver (which has direct access to appropriate counter values) but forward probability updates being coupled with compressed header parsing performed by the userspace.

In vp9 the boolean decoder used to decode the bitstream needs certain parameters to work. Those are probabilities, which change with each frame. After each frame is decoded it is known how many times a given symbol occured in the frame, so the probabilities can be adapted. This process is known as backward probabilities update. A next frame header can also contain information which modifies probabilities resulting from backward update. The said modification is called forward probabilities update. The data for backward update is generated by the decoder hardware, while the data for forward update is prepared by reading the compressed frame header. The natural place to parse something is userspace, while the natural place to access hardware-provided counters is the kernel. Such responsibilties assignment was used in the original work.

To overcome the lockstep, we moved forward probability updates to the kernel, while leaving parsing them in userspace. This way the v4l2 control which is used to pass the probs becomes unidirectional (user->kernel) and the userspace can keep parsing and enqueueing succeeding frames.

If a particular driver parses the compressed header and does backward probability updates on its own then V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS does not need to be used.

This series adds vp9 uapi in proper locations, which means it is a proper, "official" uapi, as opposed to staging uapi which was proposed in the above mentioned lkml thread.

The series adds vp9 support to rkvdec driver.

Rebased onto media_tree.

I kindly ask for your comments.

TODO:

- potentially fine-tune the uAPI (add/remove fields, move between structs)
- write another driver (intended g2 @ iMX8)
- verify the added documentation

Regards,

Andrzej

Andrzej Pietrasiewicz (1):
  media: uapi: Add VP9 stateless decoder controls

Boris Brezillon (1):
  media: rkvdec: Add the VP9 backend

Ezequiel Garcia (1):
  media: rkvdec: Fix .buf_prepare

 .../userspace-api/media/v4l/biblio.rst        |   10 +
 .../media/v4l/ext-ctrls-codec-stateless.rst   |  523 +++
 .../media/v4l/pixfmt-compressed.rst           |   15 +
 .../media/v4l/vidioc-g-ext-ctrls.rst          |    8 +
 .../media/v4l/vidioc-queryctrl.rst            |   12 +
 .../media/videodev2.h.rst.exceptions          |    2 +
 drivers/media/v4l2-core/v4l2-ctrls.c          |  244 ++
 drivers/media/v4l2-core/v4l2-ioctl.c          |    1 +
 drivers/staging/media/rkvdec/Makefile         |    2 +-
 drivers/staging/media/rkvdec/rkvdec-vp9.c     | 2846 +++++++++++++++++
 drivers/staging/media/rkvdec/rkvdec.c         |   62 +-
 drivers/staging/media/rkvdec/rkvdec.h         |    6 +
 include/media/v4l2-ctrls.h                    |    4 +
 include/uapi/linux/v4l2-controls.h            |  455 +++
 include/uapi/linux/videodev2.h                |    6 +
 15 files changed, 4190 insertions(+), 6 deletions(-)
 create mode 100644 drivers/staging/media/rkvdec/rkvdec-vp9.c

-- 
2.17.1

[RFC RESEND 1/3] media: rkvdec: Fix .buf_prepare

[Andrzej Pietrasiewicz]

From: Ezequiel Garcia <ezequiel@collabora.com>

The driver should only set the payload on .buf_prepare if the
buffer is CAPTURE type. If an OUTPUT buffer has a zero bytesused
set by userspace then v4l2-core will set it to buffer length.

Fixes: cd33c830448ba ("media: rkvdec: Add the rkvdec driver")
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
---
 drivers/staging/media/rkvdec/rkvdec.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c
index d821661d30f3..ef2166043127 100644
--- a/drivers/staging/media/rkvdec/rkvdec.c
+++ b/drivers/staging/media/rkvdec/rkvdec.c
@@ -481,7 +481,15 @@ static int rkvdec_buf_prepare(struct vb2_buffer *vb)
 		if (vb2_plane_size(vb, i) < sizeimage)
 			return -EINVAL;
 	}
-	vb2_set_plane_payload(vb, 0, f->fmt.pix_mp.plane_fmt[0].sizeimage);
+
+	/*
+	 * Buffer bytesused is written by driver for CAPTURE buffers.
+	 * (if userspace passes 0 bytesused for OUTPUT buffers, v4l2-core sets
+	 * it to buffer length).
+	 */
+	if (!V4L2_TYPE_IS_OUTPUT(vq->type))
+		vb2_set_plane_payload(vb, 0, f->fmt.pix_mp.plane_fmt[0].sizeimage);
+
 	return 0;
 }
 
-- 
2.17.1

[RFC RESEND 2/3] media: uapi: Add VP9 stateless decoder controls

[Andrzej Pietrasiewicz]

Add the VP9 stateless decoder controls plus the documentation that goes
with it.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
---
 .../userspace-api/media/v4l/biblio.rst        |  10 +
 .../media/v4l/ext-ctrls-codec-stateless.rst   | 523 ++++++++++++++++++
 .../media/v4l/pixfmt-compressed.rst           |  15 +
 .../media/v4l/vidioc-g-ext-ctrls.rst          |   8 +
 .../media/v4l/vidioc-queryctrl.rst            |  12 +
 .../media/videodev2.h.rst.exceptions          |   2 +
 drivers/media/v4l2-core/v4l2-ctrls.c          | 244 ++++++++
 drivers/media/v4l2-core/v4l2-ioctl.c          |   1 +
 include/media/v4l2-ctrls.h                    |   4 +
 include/uapi/linux/v4l2-controls.h            | 455 +++++++++++++++
 include/uapi/linux/videodev2.h                |   6 +
 11 files changed, 1280 insertions(+)

diff --git a/Documentation/userspace-api/media/v4l/biblio.rst b/Documentation/userspace-api/media/v4l/biblio.rst
index 64d241daf63c..051982896375 100644
--- a/Documentation/userspace-api/media/v4l/biblio.rst
+++ b/Documentation/userspace-api/media/v4l/biblio.rst
@@ -417,3 +417,13 @@ VP8
 :title:     RFC 6386: "VP8 Data Format and Decoding Guide"
 
 :author:    J. Bankoski et al.
+
+.. _vp9:
+
+VP9
+===
+
+
+:title:     VP9 Bitstream & Decoding Process Specification
+
+:author:    Adrian Grange (Google), Peter de Rivaz (Argon Design), Jonathan Hunt (Argon Design)
diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-codec-stateless.rst b/Documentation/userspace-api/media/v4l/ext-ctrls-codec-stateless.rst
index 3fc04daa9ffb..ab40c878c8ad 100644
--- a/Documentation/userspace-api/media/v4l/ext-ctrls-codec-stateless.rst
+++ b/Documentation/userspace-api/media/v4l/ext-ctrls-codec-stateless.rst
@@ -1244,3 +1244,526 @@ FWHT Flags
     * - __u8
       - ``padding[3]``
       - Applications and drivers must set this to zero.
+
+.. _v4l2-codec-stateless-vp9:
+
+``V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS (struct)``
+    Stores VP9 probabilities updates as parsed from the current compressed frame
+    header. A value of zero in a struct member means no update of the relevant
+    probability. Motion vector-related updates contain a new value or zero. All
+    other updates contain values translated with inv_map_table[] (see 6.3.5 in
+    :ref:`vp9`).
+
+.. c:type:: v4l2_ctrl_vp9_compressed_hdr_probs
+
+.. cssclass:: longtable
+
+.. tabularcolumns:: |p{5.8cm}|p{4.8cm}|p{6.6cm}|
+
+.. flat-table:: struct v4l2_ctrl_vp9_compressed_hdr_probs
+    :header-rows:  0
+    :stub-columns: 0
+    :widths:       1 1 2
+
+    * - __u8
+      - ``tx8[2][1]``
+      - TX 8x8 probabilities delta.
+    * - __u8
+      - ``tx16[2][2]``
+      - TX 16x16 probabilities delta.
+    * - __u8
+      - ``tx32[2][3]``
+      - TX 32x32 probabilities delta.
+    * - __u8
+      - ``coef[4][2][2][6][6][3]``
+      - Coefficient probabilities delta.
+    * - __u8
+      - ``skip[3]``
+      - Skip probabilities delta.
+    * - __u8
+      - ``inter_mode[7][3]``
+      - Inter prediction mode probabilities delta.
+    * - __u8
+      - ``interp_filter[4][2]``
+      - Interpolation filter probabilities delta.
+    * - __u8
+      - ``is_inter[4]``
+      - Is inter-block probabilities delta.
+    * - __u8
+      - ``comp_mode[5]``
+      - Compound prediction mode probabilities delta.
+    * - __u8
+      - ``single_ref[5][2]``
+      - Single reference probabilities delta.
+    * - __u8
+      - ``comp_mode[5]``
+      - Compound reference probabilities delta.
+    * - __u8
+      - ``y_mode[4][9]``
+      - Y prediction mode probabilities delta.
+    * - __u8
+      - ``uv_mode[10][9]``
+      - UV prediction mode probabilities delta.
+    * - __u8
+      - ``partition[16][3]``
+      - Partition probabilities delta.
+    * - __u8
+      - ``partition[16][3]``
+      - Partition probabilities delta.
+    * - __u8
+      - ``mv.joint[3]``
+      - Motion vector joint probabilities delta.
+    * - __u8
+      - ``mv.sign[2]``
+      - Motion vector sign probabilities delta.
+    * - __u8
+      - ``mv.class[2][10]``
+      - Motion vector class probabilities delta.
+    * - __u8
+      - ``mv.class0_bit[2]``
+      - Motion vector class0 bit probabilities delta.
+    * - __u8
+      - ``mv.bits[2][10]``
+      - Motion vector bits probabilities delta.
+    * - __u8
+      - ``mv.class0_fr[2][2][3]``
+      - Motion vector class0 fractional bit probabilities delta.
+    * - __u8
+      - ``mv.fr[2][3]``
+      - Motion vector fractional bit probabilities delta.
+    * - __u8
+      - ``mv.class0_hp[2]``
+      - Motion vector class0 high precision fractional bit probabilities delta.
+    * - __u8
+      - ``mv.hp[2]``
+      - Motion vector high precision fractional bit probabilities delta.
+
+``V4L2_CID_STATELESS_VP9_FRAME_DECODE_PARAMS (struct)``
+    Specifies the frame parameters for the associated VP9 frame decode request.
+    This includes the necessary parameters for configuring a stateless hardware
+    decoding pipeline for VP9. The bitstream parameters are defined according
+    to :ref:`vp9`.
+
+    .. note::
+
+       This compound control is not yet part of the public kernel API and
+       it is expected to change.
+
+.. c:type:: v4l2_ctrl_vp9_frame_decode_params
+
+.. cssclass:: longtable
+
+.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
+
+.. flat-table:: struct v4l2_ctrl_vp9_frame_decode_params
+    :header-rows:  0
+    :stub-columns: 0
+    :widths:       1 1 2
+
+    * - __u32
+      - ``flags``
+      - Combination of V4L2_VP9_FRAME_FLAG_* flags. See
+        :c:type:`v4l2_vp9_frame_flags`.
+    * - __u16
+      - ``compressed_header_size``
+      - Compressed header size in bytes.
+    * - __u16
+      - ``uncompressed_header_size``
+      - Uncompressed header size in bytes.
+    * - __u8
+      - ``profile``
+      - VP9 profile. Can be 0, 1, 2 or 3.
+    * - __u8
+      - ``reset_frame_context``
+      - Frame context that should be used/updated when decoding the frame.
+    * - __u8
+      - ``bit_depth``
+      - Component depth in bits. Must be 8 for profile 0 and 1. Must 10 or 12
+        for profile 2 and 3.
+    * - __u8
+      - ``interpolation_filter``
+      - Specifies the filter selection used for performing inter prediction. See
+        :c:type:`v4l2_vp9_interpolation_filter`.
+    * - __u8
+      - ``tile_cols_log2``
+      - Specifies the base 2 logarithm of the width of each tile (where the
+        width is measured in units of 8x8 blocks). Shall be less than or equal
+        to 6.
+    * - __u8
+      - ``tile_rows_log2``
+      - Specifies the base 2 logarithm of the height of each tile (where the
+        height is measured in units of 8x8 blocks)
+    * - __u8
+      - ``tx_mode``
+      - Specifies the TX mode. See :c:type:`v4l2_vp9_tx_mode`.
+    * - __u8
+      - ``reference_mode``
+      - Specifies the type of inter prediction to be used. See
+        :c:type:`v4l2_vp9_reference_mode`.
+    * - __u8
+      - ``padding[7]``
+      - Needed to make this struct 64 bit aligned. Shall be filled with zeroes.
+    * - __u16
+      - ``frame_width_minus_1``
+      - Add 1 to get the frame width expressed in pixels.
+    * - __u16
+      - ``frame_height_minus_1``
+      - Add 1 to get the frame height expressed in pixels.
+    * - __u16
+      - ``render_width_minus_1``
+      - Add 1 to get the expected render width expressed in pixels. This is
+        not used during the decoding process but might be used by HW scalers to
+        prepare a frame that's ready for scanout.
+    * - __u16
+      - render_height_minus_1
+      - Add 1 to get the expected render height expressed in pixels. This is
+        not used during the decoding process but might be used by HW scalers to
+        prepare a frame that's ready for scanout.
+    * - __u64
+      - ``refs[3]``
+      - Array of reference frame timestamps.
+    * - __u8
+      - ``ref_frame_sign_bias[4]``
+      - Array of reference frames motion vector sign bias (prediction direction)
+    * - struct :c:type:`v4l2_vp9_loop_filter`
+      - ``lf``
+      - Loop filter parameters. See struct :c:type:`v4l2_vp9_loop_filter`.
+    * - struct :c:type:`v4l2_vp9_quantization`
+      - ``quant``
+      - Quantization parameters. See :c:type:`v4l2_vp9_quantization`.
+    * - struct :c:type:`v4l2_vp9_segmentation`
+      - ``seg``
+      - Segmentation parameters. See :c:type:`v4l2_vp9_segmentation`.
+    * - struct :c:type:`v4l2_vp9_probabilities`
+      - ``probs``
+      - Probabilities. See :c:type:`v4l2_vp9_probabilities`.
+
+.. c:type:: v4l2_vp9_frame_flags
+
+.. cssclass:: longtable
+
+.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
+
+.. flat-table:: enum v4l2_vp9_frame_flags
+    :header-rows:  0
+    :stub-columns: 0
+    :widths:       1 2
+
+    * - ``V4L2_VP9_FRAME_FLAG_KEY_FRAME``
+      - The frame is a key frame.
+    * - ``V4L2_VP9_FRAME_FLAG_SHOW_FRAME``
+      - The frame should be displayed.
+    * - ``V4L2_VP9_FRAME_FLAG_ERROR_RESILIENT``
+      - The decoding should be error resilient.
+    * - ``V4L2_VP9_FRAME_FLAG_INTRA_ONLY``
+      - The frame does not reference other frames.
+    * - ``V4L2_VP9_FRAME_FLAG_ALLOW_HIGH_PREC_MV``
+      - the frame might can high precision motion vectors.
+    * - ``V4L2_VP9_FRAME_FLAG_REFRESH_FRAME_CTX``
+      - Frame context should be updated after decoding.
+    * - ``V4L2_VP9_FRAME_FLAG_PARALLEL_DEC_MODE``
+      - Parallel decoding is used.
+    * - ``V4L2_VP9_FRAME_FLAG_X_SUBSAMPLING``
+      - Vertical subsampling is enabled.
+    * - ``V4L2_VP9_FRAME_FLAG_Y_SUBSAMPLING``
+      - Horizontal subsampling is enabled.
+    * - ``V4L2_VP9_FRAME_FLAG_COLOR_RANGE_FULL_SWING``
+      - The full UV range is used.
+
+.. c:type:: v4l2_vp9_ref_id
+
+.. cssclass:: longtable
+
+.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
+
+.. flat-table:: enum v4l2_vp9_ref_id
+    :header-rows:  0
+    :stub-columns: 0
+    :widths:       1 2
+
+    * - ``V4L2_REF_ID_LAST``
+      - Last reference frame.
+    * - ``V4L2_REF_ID_GOLDEN``
+      - Golden reference frame.
+    * - ``V4L2_REF_ID_ALTREF``
+      - Alternative reference frame.
+    * - ``V4L2_REF_ID_CNT``
+      - Number of reference frames.
+
+.. c:type:: v4l2_vp9_tx_mode
+
+.. cssclass:: longtable
+
+.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
+
+.. flat-table:: enum v4l2_vp9_tx_mode
+    :header-rows:  0
+    :stub-columns: 0
+    :widths:       1 2
+
+    * - ``V4L2_VP9_TX_MODE_ONLY_4X4``
+      - Transform size is 4x4.
+    * - ``V4L2_VP9_TX_MODE_ALLOW_8X8``
+      - Transform size can be up to 8x8.
+    * - ``V4L2_VP9_TX_MODE_ALLOW_16X16``
+      - Transform size can be up to 16x16.
+    * - ``V4L2_VP9_TX_MODE_ALLOW_32X32``
+      - transform size can be up to 32x32.
+    * - ``V4L2_VP9_TX_MODE_SELECT``
+      - Bitstream contains transform size for each block.
+
+.. c:type:: v4l2_vp9_reference_mode
+
+.. cssclass:: longtable
+
+.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
+
+.. flat-table:: enum v4l2_vp9_reference_mode
+    :header-rows:  0
+    :stub-columns: 0
+    :widths:       1 2
+
+    * - ``V4L2_VP9_REF_MODE_SINGLE``
+      - Indicates that all the inter blocks use only a single reference frame
+        to generate motion compensated prediction.
+    * - ``V4L2_VP9_REF_MODE_COMPOUND``
+      - Requires all the inter blocks to use compound mode. Single reference
+        frame prediction is not allowed.
+    * - ``V4L2_VP9_REF_MODE_SELECT``
+      - Allows each individual inter block to select between single and
+        compound prediction modes.
+
+.. c:type:: v4l2_vp9_interpolation_filter
+
+.. cssclass:: longtable
+
+.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
+
+.. flat-table:: enum v4l2_vp9_interpolation_filter
+    :header-rows:  0
+    :stub-columns: 0
+    :widths:       1 2
+
+    * - ``V4L2_VP9_INTERP_FILTER_8TAP``
+      - Height tap filter.
+    * - ``V4L2_VP9_INTERP_FILTER_8TAP_SMOOTH``
+      - Height tap smooth filter.
+    * - ``V4L2_VP9_INTERP_FILTER_8TAP_SHARP``
+      - Height tap sharp filter.
+    * - ``V4L2_VP9_INTERP_FILTER_BILINEAR``
+      - Bilinear filter.
+    * - ``V4L2_VP9_INTERP_FILTER_SWITCHABLE``
+      - Filter selection is signaled at the block level.
+
+.. c:type:: v4l2_vp9_reset_frame_context
+
+.. cssclass:: longtable
+
+.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
+
+.. flat-table:: enum v4l2_vp9_reset_frame_context
+    :header-rows:  0
+    :stub-columns: 0
+    :widths:       1 2
+
+    * - ``V4L2_VP9_RESET_FRAME_CTX_NONE``
+      - Do not reset any frame context.
+    * - ``V4L2_VP9_RESET_FRAME_CTX_SPEC``
+      - Reset the frame context pointed by
+        :c:type:`v4l2_ctrl_vp9_frame_decode_params`.frame_context_idx.
+    * - ``V4L2_VP9_RESET_FRAME_CTX_ALL``
+      - Reset all frame contexts.
+
+.. c:type:: v4l2_vp9_intra_prediction_mode
+
+.. cssclass:: longtable
+
+.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
+
+.. flat-table:: enum v4l2_vp9_intra_prediction_mode
+    :header-rows:  0
+    :stub-columns: 0
+    :widths:       1 2
+
+    * - ``V4L2_VP9_INTRA_PRED_DC``
+      - DC intra prediction.
+    * - ``V4L2_VP9_INTRA_PRED_MODE_V``
+      - Vertical intra prediction.
+    * - ``V4L2_VP9_INTRA_PRED_MODE_H``
+      - Horizontal intra prediction.
+    * - ``V4L2_VP9_INTRA_PRED_MODE_D45``
+      - D45 intra prediction.
+    * - ``V4L2_VP9_INTRA_PRED_MODE_D135``
+      - D135 intra prediction.
+    * - ``V4L2_VP9_INTRA_PRED_MODE_D117``
+      - D117 intra prediction.
+    * - ``V4L2_VP9_INTRA_PRED_MODE_D153``
+      - D153 intra prediction.
+    * - ``V4L2_VP9_INTRA_PRED_MODE_D207``
+      - D207 intra prediction.
+    * - ``V4L2_VP9_INTRA_PRED_MODE_D63``
+      - D63 intra prediction.
+    * - ``V4L2_VP9_INTRA_PRED_MODE_TM``
+      - True motion intra prediction.
+
+.. c:type:: v4l2_vp9_segmentation
+
+.. cssclass:: longtable
+
+.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
+
+.. flat-table:: struct v4l2_vp9_segmentation
+    :header-rows:  0
+    :stub-columns: 0
+    :widths:       1 1 2
+
+    * - __u8
+      - ``flags``
+      - Combination of V4L2_VP9_SEGMENTATION_FLAG_* flags. See
+        :c:type:`v4l2_vp9_segmentation_flags`.
+    * - __u8
+      - ``tree_probs[7]``
+      - Specifies the probability values to be used when decoding a Segment-ID.
+        See '5.15. Segmentation map' section of :ref:`vp9` for more details.
+    * - __u8
+      - ``pred_prob[3]``
+      - Specifies the probability values to be used when decoding a
+        Predicted-Segment-ID. See '6.4.14. Get segment id syntax'
+        section of :ref:`vp9` for more details.
+    * - __u8
+      - ``padding[5]``
+      - Used to align this struct on 64 bit. Shall be filled with zeroes.
+    * - __u8
+      - ``feature_enabled[8]``
+      - Bitmask defining which features are enabled in each segment.
+    * - __u8
+      - ``feature_data[8][4]``
+      - Data attached to each feature. Data entry is only valid if the feature
+        is enabled.
+
+.. c:type:: v4l2_vp9_segment_feature
+
+.. cssclass:: longtable
+
+.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
+
+.. flat-table:: enum v4l2_vp9_segment_feature
+    :header-rows:  0
+    :stub-columns: 0
+    :widths:       1 2
+
+    * - ``V4L2_VP9_SEGMENT_FEATURE_QP_DELTA``
+      - QP delta segment feature.
+    * - ``V4L2_VP9_SEGMENT_FEATURE_LF``
+      - Loop filter segment feature.
+    * - ``V4L2_VP9_SEGMENT_FEATURE_REF_FRAME``
+      - Reference frame segment feature.
+    * - ``V4L2_VP9_SEGMENT_FEATURE_SKIP``
+      - Skip segment feature.
+    * - ``V4L2_VP9_SEGMENT_FEATURE_CNT``
+      - Number of segment features.
+
+.. c:type:: v4l2_vp9_segmentation_flags
+
+.. cssclass:: longtable
+
+.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
+
+.. flat-table:: enum v4l2_vp9_segmentation_flags
+    :header-rows:  0
+    :stub-columns: 0
+    :widths:       1 2
+
+    * - ``V4L2_VP9_SEGMENTATION_FLAG_ENABLED``
+      - Indicates that this frame makes use of the segmentation tool.
+    * - ``V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP``
+      - Indicates that the segmentation map should be updated during the
+        decoding of this frame.
+    * - ``V4L2_VP9_SEGMENTATION_FLAG_TEMPORAL_UPDATE``
+      - Indicates that the updates to the segmentation map are coded
+        relative to the existing segmentation map.
+    * - ``V4L2_VP9_SEGMENTATION_FLAG_UPDATE_DATA``
+      - Indicates that new parameters are about to be specified for each
+        segment.
+    * - ``V4L2_VP9_SEGMENTATION_FLAG_ABS_OR_DELTA_UPDATE``
+      - Indicates that the segmentation parameters represent the actual values
+        to be used.
+
+.. c:type:: v4l2_vp9_quantization
+
+.. cssclass:: longtable
+
+.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
+
+.. flat-table:: struct v4l2_vp9_quantization
+    :header-rows:  0
+    :stub-columns: 0
+    :widths:       1 1 2
+
+    * - __u8
+      - ``base_q_idx``
+      - Indicates the base frame qindex.
+    * - __s8
+      - ``delta_q_y_dc``
+      - Indicates the Y DC quantizer relative to base_q_idx.
+    * - __s8
+      - ``delta_q_uv_dc``
+      - Indicates the UV DC quantizer relative to base_q_idx.
+    * - __s8
+      - ``delta_q_uv_ac``
+      - Indicates the UV AC quantizer relative to base_q_idx.
+    * - __u8
+      - ``padding[4]``
+      - Padding bytes used to align this struct on 64 bit. Must be set to 0.
+
+.. c:type:: v4l2_vp9_loop_filter
+
+.. cssclass:: longtable
+
+.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
+
+.. flat-table:: struct v4l2_vp9_loop_filter
+    :header-rows:  0
+    :stub-columns: 0
+    :widths:       1 1 2
+
+    * - __u8
+      - ``flags``
+      - Combination of V4L2_VP9_LOOP_FILTER_FLAG_* flags.
+        See :c:type:`v4l2_vp9_loop_filter_flags`.
+    * - __u8
+      - ``level``
+      - Indicates the loop filter strength.
+    * - __u8
+      - ``sharpness``
+      - Indicates the sharpness level.
+    * - __s8
+      - ``ref_deltas[4]``
+      - Contains the adjustment needed for the filter level based on the chosen
+        reference frame.
+    * - __s8
+      - ``mode_deltas[2]``
+      - Contains the adjustment needed for the filter level based on the chosen
+        mode
+    * - __u8
+      - ``level_lookup[8][4][2]``
+      - Level lookup table.
+
+
+.. c:type:: v4l2_vp9_loop_filter_flags
+
+.. cssclass:: longtable
+
+.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
+
+.. flat-table:: enum v4l2_vp9_loop_filter_flags
+    :header-rows:  0
+    :stub-columns: 0
+    :widths:       1 2
+
+    * - ``V4L2_VP9_LOOP_FILTER_FLAG_DELTA_ENABLED``
+      - When set, the filter level depends on the mode and reference frame used
+        to predict a block.
+    * - ``V4L2_VP9_LOOP_FILTER_FLAG_DELTA_UPDATE``
+      - When set, the bitstream contains additional syntax elements that
+        specify which mode and reference frame deltas are to be updated.
diff --git a/Documentation/userspace-api/media/v4l/pixfmt-compressed.rst b/Documentation/userspace-api/media/v4l/pixfmt-compressed.rst
index 6dba70da822b..7e34aeb1cb92 100644
--- a/Documentation/userspace-api/media/v4l/pixfmt-compressed.rst
+++ b/Documentation/userspace-api/media/v4l/pixfmt-compressed.rst
@@ -171,6 +171,21 @@ Compressed Formats
       - VP9 compressed video frame. The encoder generates one
 	compressed frame per buffer, and the decoder requires one
 	compressed frame per buffer.
+    * .. _V4L2-PIX-FMT-VP9_FRAME:
+
+      - ``V4L2_PIX_FMT_VP9_FRAME``
+      - 'VP9F'
+      - VP9 parsed frame, including the frame header, as extracted from the container.
+	This format is adapted for stateless video decoders that implement an
+	VP9 pipeline with the :ref:`stateless_decoder`.
+	Metadata associated with the frame to decode is required to be passed
+	through the ``V4L2_CID_STATELESS_VP9_FRAME_DECODE_PARAMS`` and
+	the ``V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS`` controls.
+	See the :ref:`associated Codec Control IDs <v4l2-codec-stateless-vp9>`.
+	Exactly one output and one capture buffer must be provided for use with
+	this pixel format. The output buffer must contain the appropriate number
+	of macroblocks to decode a full corresponding frame to the matching
+	capture buffer.
     * .. _V4L2-PIX-FMT-HEVC:
 
       - ``V4L2_PIX_FMT_HEVC``
diff --git a/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst b/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst
index 3ba22983d21f..3ff72ca63772 100644
--- a/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst
+++ b/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst
@@ -221,6 +221,14 @@ still cause this situation.
       - ``p_vp8_frame``
       - A pointer to a struct :c:type:`v4l2_ctrl_vp8_frame`. Valid if this control is
         of type ``V4L2_CTRL_TYPE_VP8_FRAME``.
+    * - struct :c:type:`v4l2_ctrl_vp9_compressed_hdr_probs` *
+      - ``p_vp9_compressed_hdr_probs``
+      - A pointer to a struct :c:type:`v4l2_ctrl_vp9_compressed_hdr_probs'. Valid if this contro is
+        of type ``V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR_PROBS``.
+    * - struct :c:type:`v4l2_ctrl_vp9_frame_decode_params` *
+      - ``p_vp9_frame_decode_params``
+      - A pointer to a struct :c:type:`v4l2_ctrl_vp9_frame_decode_params'. Valid if this contro is
+        of type ``V4L2_CTRL_TYPE_VP9_FRAME_DECODE_PARAMS``.
     * - struct :c:type:`v4l2_ctrl_hdr10_cll_info` *
       - ``p_hdr10_cll``
       - A pointer to a struct :c:type:`v4l2_ctrl_hdr10_cll_info`. Valid if this control is
diff --git a/Documentation/userspace-api/media/v4l/vidioc-queryctrl.rst b/Documentation/userspace-api/media/v4l/vidioc-queryctrl.rst
index 8a285daedc6a..85fb8b7a9428 100644
--- a/Documentation/userspace-api/media/v4l/vidioc-queryctrl.rst
+++ b/Documentation/userspace-api/media/v4l/vidioc-queryctrl.rst
@@ -495,6 +495,18 @@ See also the examples in :ref:`control`.
       - n/a
       - A struct :c:type:`v4l2_ctrl_vp8_frame`, containing VP8
 	frame parameters for stateless video decoders.
+    * - ``V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR_PROBS``
+      - n/a
+      - n/a
+      - n/a
+      - A struct :c:type:`v4l2_ctrl_vp9_compressed_hdr_probs`, containing VP9
+	probabilities updates for stateless video decoders.
+    * - ``V4L2_CTRL_TYPE_VP9_FRAME_DECODE_PARAMS``
+      - n/a
+      - n/a
+      - n/a
+      - A struct :c:type:`v4l2_ctrl_vp9_compressed_hdr_probs`, containing VP9
+	frame decode parameters for stateless video decoders.
 
 .. raw:: latex
 
diff --git a/Documentation/userspace-api/media/videodev2.h.rst.exceptions b/Documentation/userspace-api/media/videodev2.h.rst.exceptions
index f59940352faa..fdc6f2b22df8 100644
--- a/Documentation/userspace-api/media/videodev2.h.rst.exceptions
+++ b/Documentation/userspace-api/media/videodev2.h.rst.exceptions
@@ -148,6 +148,8 @@ replace symbol V4L2_CTRL_TYPE_HEVC_SLICE_PARAMS :c:type:`v4l2_ctrl_type`
 replace symbol V4L2_CTRL_TYPE_AREA :c:type:`v4l2_ctrl_type`
 replace symbol V4L2_CTRL_TYPE_FWHT_PARAMS :c:type:`v4l2_ctrl_type`
 replace symbol V4L2_CTRL_TYPE_VP8_FRAME :c:type:`v4l2_ctrl_type`
+replace symbol V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR_PROBS :c:type:`v4l2_ctrl_type`
+replace symbol V4L2_CTRL_TYPE_VP9_FRAME_DECODE_PARAMS :c:type:`v4l2_ctrl_type`
 replace symbol V4L2_CTRL_TYPE_HDR10_CLL_INFO :c:type:`v4l2_ctrl_type`
 replace symbol V4L2_CTRL_TYPE_HDR10_MASTERING_DISPLAY :c:type:`v4l2_ctrl_type`
 
diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c
index 0d7fe1bd975a..8de7238593ab 100644
--- a/drivers/media/v4l2-core/v4l2-ctrls.c
+++ b/drivers/media/v4l2-core/v4l2-ctrls.c
@@ -1215,6 +1215,8 @@ const char *v4l2_ctrl_get_name(u32 id)
 	case V4L2_CID_STATELESS_H264_DECODE_PARAMS:		return "H264 Decode Parameters";
 	case V4L2_CID_STATELESS_FWHT_PARAMS:			return "FWHT Stateless Parameters";
 	case V4L2_CID_STATELESS_VP8_FRAME:			return "VP8 Frame Parameters";
+	case V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS:	return "VP9 Probabilities Updates";
+	case V4L2_CID_STATELESS_VP9_FRAME_DECODE_PARAMS:	return "VP9 Frame Decode Parameters";
 
 	/* Colorimetry controls */
 	/* Keep the order of the 'case's the same as in v4l2-controls.h! */
@@ -1517,6 +1519,12 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum v4l2_ctrl_type *type,
 	case V4L2_CID_STATELESS_VP8_FRAME:
 		*type = V4L2_CTRL_TYPE_VP8_FRAME;
 		break;
+	case V4L2_CID_STATELESS_VP9_FRAME_DECODE_PARAMS:
+		*type = V4L2_CTRL_TYPE_VP9_FRAME_DECODE_PARAMS;
+		break;
+	case V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS:
+		*type = V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR_PROBS;
+		break;
 	case V4L2_CID_MPEG_VIDEO_HEVC_SPS:
 		*type = V4L2_CTRL_TYPE_HEVC_SPS;
 		break;
@@ -1836,6 +1844,12 @@ static void std_log(const struct v4l2_ctrl *ctrl)
 	case V4L2_CTRL_TYPE_VP8_FRAME:
 		pr_cont("VP8_FRAME");
 		break;
+	case V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR_PROBS:
+		pr_cont("VP9_COMPRESSED_HDR_PROBS");
+		break;
+	case V4L2_CTRL_TYPE_VP9_FRAME_DECODE_PARAMS:
+		pr_cont("VP9_FRAME_DECODE_PARAMS");
+		break;
 	case V4L2_CTRL_TYPE_HDR10_CLL_INFO:
 		pr_cont("HDR10_CLL_INFO");
 		break;
@@ -1869,6 +1883,224 @@ static void std_log(const struct v4l2_ctrl *ctrl)
 	0;							\
 })
 
+static int
+validate_vp9_lf_params(struct v4l2_vp9_loop_filter *lf)
+{
+	unsigned int i, j, k;
+
+	if (lf->flags &
+	    ~(V4L2_VP9_LOOP_FILTER_FLAG_DELTA_ENABLED |
+	      V4L2_VP9_LOOP_FILTER_FLAG_DELTA_UPDATE))
+		return -EINVAL;
+
+	/*
+	 * V4L2_VP9_LOOP_FILTER_FLAG_DELTA_ENABLED implies
+	 * V4L2_VP9_LOOP_FILTER_FLAG_DELTA_UPDATE.
+	 */
+	if (lf->flags & V4L2_VP9_LOOP_FILTER_FLAG_DELTA_UPDATE &&
+	    !(lf->flags & V4L2_VP9_LOOP_FILTER_FLAG_DELTA_ENABLED))
+		return -EINVAL;
+
+	/* That all values are in the accepted range. */
+	if (lf->level > GENMASK(5, 0))
+		return -EINVAL;
+
+	if (lf->sharpness > GENMASK(2, 0))
+		return -EINVAL;
+
+	for (i = 0; i < ARRAY_SIZE(lf->ref_deltas); i++) {
+		if (lf->ref_deltas[i] < -63 || lf->ref_deltas[i] > 63)
+			return -EINVAL;
+	}
+
+	for (i = 0; i < ARRAY_SIZE(lf->mode_deltas); i++) {
+		if (lf->mode_deltas[i] < -63 || lf->mode_deltas[i] > 63)
+			return -EINVAL;
+	}
+
+	for (i = 0; i < ARRAY_SIZE(lf->level_lookup); i++) {
+		for (j = 0; j < ARRAY_SIZE(lf->level_lookup[0]); j++) {
+			for (k = 0; k < ARRAY_SIZE(lf->level_lookup[0][0]); k++) {
+				if (lf->level_lookup[i][j][k] > 63)
+					return -EINVAL;
+			}
+		}
+	}
+
+	return 0;
+}
+
+static int
+validate_vp9_quant_params(struct v4l2_vp9_quantization *quant)
+{
+	if (quant->delta_q_y_dc < -15 || quant->delta_q_y_dc > 15 ||
+	    quant->delta_q_uv_dc < -15 || quant->delta_q_uv_dc > 15 ||
+	    quant->delta_q_uv_ac < -15 || quant->delta_q_uv_ac > 15)
+		return -EINVAL;
+
+	memset(quant->padding, 0, sizeof(quant->padding));
+	return 0;
+}
+
+static int
+validate_vp9_seg_params(struct v4l2_vp9_segmentation *seg)
+{
+	unsigned int i, j;
+
+	if (seg->flags &
+	    ~(V4L2_VP9_SEGMENTATION_FLAG_ENABLED |
+	      V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP |
+	      V4L2_VP9_SEGMENTATION_FLAG_TEMPORAL_UPDATE |
+	      V4L2_VP9_SEGMENTATION_FLAG_UPDATE_DATA |
+	      V4L2_VP9_SEGMENTATION_FLAG_ABS_OR_DELTA_UPDATE))
+		return -EINVAL;
+
+	/*
+	 * V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP and
+	 * V4L2_VP9_SEGMENTATION_FLAG_UPDATE_DATA imply
+	 * V4L2_VP9_SEGMENTATION_FLAG_ENABLED.
+	 */
+	if ((seg->flags &
+	     (V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP |
+	      V4L2_VP9_SEGMENTATION_FLAG_UPDATE_DATA)) &&
+	    !(seg->flags & V4L2_VP9_SEGMENTATION_FLAG_ENABLED))
+		return -EINVAL;
+
+	/*
+	 * V4L2_VP9_SEGMENTATION_FLAG_TEMPORAL_UPDATE implies
+	 * V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP.
+	 */
+	if (seg->flags & V4L2_VP9_SEGMENTATION_FLAG_TEMPORAL_UPDATE &&
+	    !(seg->flags & V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP))
+		return -EINVAL;
+
+	/*
+	 * V4L2_VP9_SEGMENTATION_FLAG_ABS_OR_DELTA_UPDATE implies
+	 * V4L2_VP9_SEGMENTATION_FLAG_UPDATE_DATA.
+	 */
+	if (seg->flags & V4L2_VP9_SEGMENTATION_FLAG_ABS_OR_DELTA_UPDATE &&
+	    !(seg->flags & V4L2_VP9_SEGMENTATION_FLAG_UPDATE_DATA))
+		return -EINVAL;
+
+	for (i = 0; i < ARRAY_SIZE(seg->feature_enabled); i++) {
+		if (seg->feature_enabled[i] &
+		    ~(V4L2_VP9_SEGMENT_FEATURE_QP_DELTA |
+		      V4L2_VP9_SEGMENT_FEATURE_LF |
+		      V4L2_VP9_SEGMENT_FEATURE_REF_FRAME |
+		      V4L2_VP9_SEGMENT_FEATURE_SKIP))
+			return -EINVAL;
+	}
+
+	for (i = 0; i < ARRAY_SIZE(seg->feature_data); i++) {
+		const int range[] = {255, 63, 3, 0};
+
+		for (j = 0; j < ARRAY_SIZE(seg->feature_data[j]); j++) {
+			if (seg->feature_data[i][j] < -range[j] ||
+			    seg->feature_data[i][j] > range[j])
+				return -EINVAL;
+		}
+	}
+
+	memset(seg->padding, 0, sizeof(seg->padding));
+	return 0;
+}
+
+static int
+validate_vp9_frame_decode_params(struct v4l2_ctrl_vp9_frame_decode_params *dec_params)
+{
+	int ret, i;
+
+	/* Make sure we're not passed invalid flags. */
+	if (dec_params->flags &
+	    ~(V4L2_VP9_FRAME_FLAG_KEY_FRAME |
+	      V4L2_VP9_FRAME_FLAG_SHOW_FRAME |
+	      V4L2_VP9_FRAME_FLAG_ERROR_RESILIENT |
+	      V4L2_VP9_FRAME_FLAG_INTRA_ONLY |
+	      V4L2_VP9_FRAME_FLAG_ALLOW_HIGH_PREC_MV |
+	      V4L2_VP9_FRAME_FLAG_REFRESH_FRAME_CTX |
+	      V4L2_VP9_FRAME_FLAG_PARALLEL_DEC_MODE |
+	      V4L2_VP9_FRAME_FLAG_X_SUBSAMPLING |
+	      V4L2_VP9_FRAME_FLAG_Y_SUBSAMPLING |
+	      V4L2_VP9_FRAME_FLAG_COLOR_RANGE_FULL_SWING))
+		return -EINVAL;
+
+	/*
+	 * The refresh context and error resilient flags are mutually exclusive.
+	 * Same goes for parallel decoding and error resilient modes.
+	 */
+	if (dec_params->flags & V4L2_VP9_FRAME_FLAG_ERROR_RESILIENT &&
+	    dec_params->flags &
+	    (V4L2_VP9_FRAME_FLAG_REFRESH_FRAME_CTX |
+	     V4L2_VP9_FRAME_FLAG_PARALLEL_DEC_MODE))
+		return -EINVAL;
+
+	if (dec_params->profile > V4L2_VP9_PROFILE_MAX)
+		return -EINVAL;
+
+	if (dec_params->reset_frame_context > V4L2_VP9_RESET_FRAME_CTX_ALL)
+		return -EINVAL;
+
+	if (dec_params->frame_context_idx >= V4L2_VP9_NUM_FRAME_CTX)
+		return -EINVAL;
+
+	/*
+	 * Profiles 0 and 1 only support 8-bit depth, profiles 2 and 3 only 10
+	 * and 12 bit depths.
+	 */
+	if ((dec_params->profile < 2 && dec_params->bit_depth != 8) ||
+	    (dec_params->profile >= 2 &&
+	     (dec_params->bit_depth != 10 && dec_params->bit_depth != 12)))
+		return -EINVAL;
+
+	/* Profile 0 and 2 only accept YUV 4:2:0. */
+	if ((dec_params->profile == 0 || dec_params->profile == 2) &&
+	    (!(dec_params->flags & V4L2_VP9_FRAME_FLAG_X_SUBSAMPLING) ||
+	     !(dec_params->flags & V4L2_VP9_FRAME_FLAG_Y_SUBSAMPLING)))
+		return -EINVAL;
+
+	/* Profile 1 and 3 only accept YUV 4:2:2, 4:4:0 and 4:4:4. */
+	if ((dec_params->profile == 1 || dec_params->profile == 3) &&
+	    ((dec_params->flags & V4L2_VP9_FRAME_FLAG_X_SUBSAMPLING) &&
+	     (dec_params->flags & V4L2_VP9_FRAME_FLAG_Y_SUBSAMPLING)))
+		return -EINVAL;
+
+	if (dec_params->interpolation_filter > V4L2_VP9_INTERP_FILTER_SWITCHABLE)
+		return -EINVAL;
+
+	/*
+	 * According to the spec, tile_cols_log2 shall be less than or equal
+	 * to 6.
+	 */
+	if (dec_params->tile_cols_log2 > 6)
+		return -EINVAL;
+
+	if (dec_params->tx_mode > V4L2_VP9_TX_MODE_SELECT)
+		return -EINVAL;
+
+	if (dec_params->reference_mode > V4L2_VP9_REF_MODE_SELECT)
+		return -EINVAL;
+
+	for (i = 0; i < V4L2_REF_ID_CNT + 1; ++i)
+		if (dec_params->ref_frame_sign_bias[i] != 0 &&
+		    dec_params->ref_frame_sign_bias[i] != 1)
+			return -EINVAL;
+
+	ret = validate_vp9_lf_params(&dec_params->lf);
+	if (ret)
+		return ret;
+
+	ret = validate_vp9_quant_params(&dec_params->quant);
+	if (ret)
+		return ret;
+
+	ret = validate_vp9_seg_params(&dec_params->seg);
+	if (ret)
+		return ret;
+
+	memset(dec_params->padding, 0, sizeof(dec_params->padding));
+	return 0;
+}
+
 /* Validate a new control */
 
 #define zero_padding(s) \
@@ -2127,6 +2359,12 @@ static int std_validate_compound(const struct v4l2_ctrl *ctrl, u32 idx,
 		zero_padding(p_vp8_frame->coder_state);
 		break;
 
+	case V4L2_CTRL_TYPE_VP9_FRAME_DECODE_PARAMS:
+		return validate_vp9_frame_decode_params(p);
+
+	case V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR_PROBS:
+		break;
+
 	case V4L2_CTRL_TYPE_HEVC_SPS:
 		p_hevc_sps = p;
 
@@ -2938,6 +3176,12 @@ static struct v4l2_ctrl *v4l2_ctrl_new(struct v4l2_ctrl_handler *hdl,
 	case V4L2_CTRL_TYPE_VP8_FRAME:
 		elem_size = sizeof(struct v4l2_ctrl_vp8_frame);
 		break;
+	case V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR_PROBS:
+		elem_size = sizeof(struct v4l2_ctrl_vp9_compressed_hdr_probs);
+		break;
+	case V4L2_CTRL_TYPE_VP9_FRAME_DECODE_PARAMS:
+		elem_size = sizeof(struct v4l2_ctrl_vp9_frame_decode_params);
+		break;
 	case V4L2_CTRL_TYPE_HEVC_SPS:
 		elem_size = sizeof(struct v4l2_ctrl_hevc_sps);
 		break;
diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
index 6a5d1c6d11d6..dbdafa5ea127 100644
--- a/drivers/media/v4l2-core/v4l2-ioctl.c
+++ b/drivers/media/v4l2-core/v4l2-ioctl.c
@@ -1431,6 +1431,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
 		case V4L2_PIX_FMT_VP8:		descr = "VP8"; break;
 		case V4L2_PIX_FMT_VP8_FRAME:    descr = "VP8 Frame"; break;
 		case V4L2_PIX_FMT_VP9:		descr = "VP9"; break;
+		case V4L2_PIX_FMT_VP9_FRAME:    descr = "VP9 Frame"; break;
 		case V4L2_PIX_FMT_HEVC:		descr = "HEVC"; break; /* aka H.265 */
 		case V4L2_PIX_FMT_HEVC_SLICE:	descr = "HEVC Parsed Slice Data"; break;
 		case V4L2_PIX_FMT_FWHT:		descr = "FWHT"; break; /* used in vicodec */
diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h
index a5953b812878..8c5fb22ff545 100644
--- a/include/media/v4l2-ctrls.h
+++ b/include/media/v4l2-ctrls.h
@@ -50,6 +50,8 @@ struct video_device;
  * @p_h264_decode_params:	Pointer to a struct v4l2_ctrl_h264_decode_params.
  * @p_h264_pred_weights:	Pointer to a struct v4l2_ctrl_h264_pred_weights.
  * @p_vp8_frame:		Pointer to a VP8 frame params structure.
+ * @p_vp9_compressed_hdr_probs:	Pointer to a VP9 frame compressed header probs structure.
+ * @p_vp9_frame_decode_params:	Pointer to a VP9 frame params structure.
  * @p_hevc_sps:			Pointer to an HEVC sequence parameter set structure.
  * @p_hevc_pps:			Pointer to an HEVC picture parameter set structure.
  * @p_hevc_slice_params:	Pointer to an HEVC slice parameters structure.
@@ -79,6 +81,8 @@ union v4l2_ctrl_ptr {
 	struct v4l2_ctrl_hevc_sps *p_hevc_sps;
 	struct v4l2_ctrl_hevc_pps *p_hevc_pps;
 	struct v4l2_ctrl_hevc_slice_params *p_hevc_slice_params;
+	struct v4l2_ctrl_vp9_compressed_hdr_probs *p_vp9_compressed_hdr_probs;
+	struct v4l2_ctrl_vp9_frame_decode_params *p_vp9_frame_decode_params;
 	struct v4l2_ctrl_hdr10_cll_info *p_hdr10_cll;
 	struct v4l2_ctrl_hdr10_mastering_display *p_hdr10_mastering;
 	struct v4l2_area *p_area;
diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h
index d43bec5f1afd..ff5c574f2755 100644
--- a/include/uapi/linux/v4l2-controls.h
+++ b/include/uapi/linux/v4l2-controls.h
@@ -1896,6 +1896,461 @@ struct v4l2_ctrl_hdr10_mastering_display {
 	__u32 min_display_mastering_luminance;
 };
 
+/* Stateless VP9 control */
+
+/**
+ * enum v4l2_vp9_loop_filter_flags - VP9 loop filter flags
+ *
+ * @V4L2_VP9_LOOP_FILTER_FLAG_DELTA_ENABLED: the filter level depends on
+ *					     the mode and reference frame used
+ *					     to predict a block
+ * @V4L2_VP9_LOOP_FILTER_FLAG_DELTA_UPDATE: the bitstream contains additional
+ *					    syntax elements that specify which
+ *					    mode and reference frame deltas
+ *					    are to be updated
+ *
+ * Those are the flags you should pass to &v4l2_vp9_loop_filter.flags. See
+ * section '7.2.8 Loop filter semantics' of the VP9 specification for more
+ * details.
+ */
+enum v4l2_vp9_loop_filter_flags {
+	V4L2_VP9_LOOP_FILTER_FLAG_DELTA_ENABLED = 1 << 0,
+	V4L2_VP9_LOOP_FILTER_FLAG_DELTA_UPDATE = 1 << 1,
+};
+
+/**
+ * struct v4l2_vp9_loop_filter - VP9 loop filter parameters
+ *
+ * @flags: combination of V4L2_VP9_LOOP_FILTER_FLAG_* flags
+ * @level: indicates the loop filter strength
+ * @sharpness: indicates the sharpness level
+ * @ref_deltas: contains the adjustment needed for the filter level based on
+ *		the chosen reference frame
+ * @mode_deltas: contains the adjustment needed for the filter level based on
+ *		 the chosen mode
+ * @level_lookup: level lookup table
+ *
+ * This structure contains all loop filter related parameters. See sections
+ * '7.2.8 Loop filter semantics' and '8.8.1 Loop filter frame init process'
+ * of the VP9 specification for more details.
+ */
+struct v4l2_vp9_loop_filter {
+	__u8 flags;
+	__u8 level;
+	__u8 sharpness;
+	__s8 ref_deltas[4];
+	__s8 mode_deltas[2];
+	__u8 level_lookup[8][4][2];
+	__u8 padding;
+};
+
+/**
+ * struct v4l2_vp9_quantization - VP9 quantization parameters
+ *
+ * @base_q_idx: indicates the base frame qindex
+ * @delta_q_y_dc: indicates the Y DC quantizer relative to base_q_idx
+ * @delta_q_uv_dc: indicates the UV DC quantizer relative to base_q_idx
+ * @delta_q_uv_ac indicates the UV AC quantizer relative to base_q_idx
+ * @padding: padding bytes to align things on 64 bits. Must be set to 0
+ *
+ * Encodes the quantization parameters. See section '7.2.9 Quantization params
+ * syntax' of the VP9 specification for more details.
+ */
+struct v4l2_vp9_quantization {
+	__u8 base_q_idx;
+	__s8 delta_q_y_dc;
+	__s8 delta_q_uv_dc;
+	__s8 delta_q_uv_ac;
+	__u8 padding[4];
+};
+
+/**
+ * enum v4l2_vp9_segmentation_flags - VP9 segmentation flags
+ *
+ * @V4L2_VP9_SEGMENTATION_FLAG_ENABLED: indicates that this frame makes use of
+ *					the segmentation tool
+ * @V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP: indicates that the segmentation map
+ *					   should be updated during the
+ *					   decoding of this frame
+ * @V4L2_VP9_SEGMENTATION_FLAG_TEMPORAL_UPDATE: indicates that the updates to
+ *						the segmentation map are coded
+ *						relative to the existing
+ *						segmentation map
+ * @V4L2_VP9_SEGMENTATION_FLAG_UPDATE_DATA: indicates that new parameters are
+ *					    about to be specified for each
+ *					    segment
+ * @V4L2_VP9_SEGMENTATION_FLAG_ABS_OR_DELTA_UPDATE: indicates that the
+ *						    segmentation parameters
+ *						    represent the actual values
+ *						    to be used
+ *
+ * Those are the flags you should pass to &v4l2_vp9_segmentation.flags. See
+ * section '7.2.10 Segmentation params syntax' of the VP9 specification for
+ * more details.
+ */
+enum v4l2_vp9_segmentation_flags {
+	V4L2_VP9_SEGMENTATION_FLAG_ENABLED = 1 << 0,
+	V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP = 1 << 1,
+	V4L2_VP9_SEGMENTATION_FLAG_TEMPORAL_UPDATE = 1 << 2,
+	V4L2_VP9_SEGMENTATION_FLAG_UPDATE_DATA = 1 << 3,
+	V4L2_VP9_SEGMENTATION_FLAG_ABS_OR_DELTA_UPDATE = 1 << 4,
+};
+
+#define V4L2_VP9_SEGMENT_FEATURE_ENABLED(id)	(1 << (id))
+#define V4L2_VP9_SEGMENT_FEATURE_ENABLED_MASK	0xf
+
+/**
+ * enum v4l2_vp9_segment_feature - VP9 segment feature IDs
+ *
+ * @V4L2_VP9_SEGMENT_FEATURE_QP_DELTA: QP delta segment feature
+ * @V4L2_VP9_SEGMENT_FEATURE_LF: loop filter segment feature
+ * @V4L2_VP9_SEGMENT_FEATURE_REF_FRAME: reference frame segment feature
+ * @V4L2_VP9_SEGMENT_FEATURE_SKIP: skip segment feature
+ * @V4L2_VP9_SEGMENT_FEATURE_CNT: number of segment features
+ *
+ * Segment feature IDs. See section '7.2.10 Segmentation params syntax' of the
+ * VP9 specification for more details.
+ */
+enum v4l2_vp9_segment_feature {
+	V4L2_VP9_SEGMENT_FEATURE_QP_DELTA,
+	V4L2_VP9_SEGMENT_FEATURE_LF,
+	V4L2_VP9_SEGMENT_FEATURE_REF_FRAME,
+	V4L2_VP9_SEGMENT_FEATURE_SKIP,
+	V4L2_VP9_SEGMENT_FEATURE_CNT,
+};
+
+/**
+ * struct v4l2_vp9_segmentation - VP9 segmentation parameters
+ *
+ * @flags: combination of V4L2_VP9_SEGMENTATION_FLAG_* flags
+ * @tree_probs: specifies the probability values to be used when
+ *              decoding a Segment-ID. See '5.15. Segmentation map'
+ *              section of the VP9 specification for more details.
+ * @pred_prob: specifies the probability values to be used when decoding a
+ *	       Predicted-Segment-ID. See '6.4.14. Get segment id syntax'
+ *	       section of :ref:`vp9` for more details..
+ * @padding: padding used to make things aligned on 64 bits. Shall be zero
+ *	     filled
+ * @feature_enabled: bitmask defining which features are enabled in each
+ *		     segment
+ * @feature_data: data attached to each feature. Data entry is only valid if
+ *		  the feature is enabled
+ *
+ * Encodes the quantization parameters. See section '7.2.10 Segmentation
+ * params syntax' of the VP9 specification for more details.
+ */
+struct v4l2_vp9_segmentation {
+	__u8 flags;
+	__u8 tree_probs[7];
+	__u8 pred_probs[3];
+	__u8 padding[5];
+	__u8 feature_enabled[8];
+	__s16 feature_data[8][4];
+};
+
+/**
+ * enum v4l2_vp9_intra_prediction_mode - VP9 Intra prediction modes
+ *
+ * @V4L2_VP9_INTRA_PRED_DC: DC intra prediction
+ * @V4L2_VP9_INTRA_PRED_MODE_V: vertical intra prediction
+ * @V4L2_VP9_INTRA_PRED_MODE_H: horizontal intra prediction
+ * @V4L2_VP9_INTRA_PRED_MODE_D45: D45 intra prediction
+ * @V4L2_VP9_INTRA_PRED_MODE_D135: D135 intra prediction
+ * @V4L2_VP9_INTRA_PRED_MODE_D117: D117 intra prediction
+ * @V4L2_VP9_INTRA_PRED_MODE_D153: D153 intra prediction
+ * @V4L2_VP9_INTRA_PRED_MODE_D207: D207 intra prediction
+ * @V4L2_VP9_INTRA_PRED_MODE_D63: D63 intra prediction
+ * @V4L2_VP9_INTRA_PRED_MODE_TM: True Motion intra prediction
+ *
+ * See section '7.4.5 Intra frame mode info semantics' for more details.
+ */
+enum v4l2_vp9_intra_prediction_mode {
+	V4L2_VP9_INTRA_PRED_MODE_DC,
+	V4L2_VP9_INTRA_PRED_MODE_V,
+	V4L2_VP9_INTRA_PRED_MODE_H,
+	V4L2_VP9_INTRA_PRED_MODE_D45,
+	V4L2_VP9_INTRA_PRED_MODE_D135,
+	V4L2_VP9_INTRA_PRED_MODE_D117,
+	V4L2_VP9_INTRA_PRED_MODE_D153,
+	V4L2_VP9_INTRA_PRED_MODE_D207,
+	V4L2_VP9_INTRA_PRED_MODE_D63,
+	V4L2_VP9_INTRA_PRED_MODE_TM,
+};
+
+/**
+ * enum v4l2_vp9_reset_frame_context - Valid values for
+ *			&v4l2_ctrl_vp9_frame_decode_params->reset_frame_context
+ *
+ * @V4L2_VP9_RESET_FRAME_CTX_NONE: don't reset any frame context
+ * @V4L2_VP9_RESET_FRAME_CTX_SPEC: reset the frame context pointed by
+ *			&v4l2_ctrl_vp9_frame_decode_params.frame_context_idx
+ * @V4L2_VP9_RESET_FRAME_CTX_ALL: reset all frame contexts
+ *
+ * See section '7.2 Uncompressed header semantics' of the VP9 specification
+ * for more details.
+ */
+enum v4l2_vp9_reset_frame_context {
+	V4L2_VP9_RESET_FRAME_CTX_NONE,
+	V4L2_VP9_RESET_FRAME_CTX_SPEC,
+	V4L2_VP9_RESET_FRAME_CTX_ALL,
+};
+
+/**
+ * enum v4l2_vp9_interpolation_filter - VP9 interpolation filter types
+ *
+ * @V4L2_VP9_INTERP_FILTER_8TAP: height tap filter
+ * @V4L2_VP9_INTERP_FILTER_8TAP_SMOOTH: height tap smooth filter
+ * @V4L2_VP9_INTERP_FILTER_8TAP_SHARP: height tap sharp filter
+ * @V4L2_VP9_INTERP_FILTER_BILINEAR: bilinear filter
+ * @V4L2_VP9_INTERP_FILTER_SWITCHABLE: filter selection is signaled at the
+ *				       block level
+ *
+ * See section '7.2.7 Interpolation filter semantics' of the VP9 specification
+ * for more details.
+ */
+enum v4l2_vp9_interpolation_filter {
+	V4L2_VP9_INTERP_FILTER_8TAP,
+	V4L2_VP9_INTERP_FILTER_8TAP_SMOOTH,
+	V4L2_VP9_INTERP_FILTER_8TAP_SHARP,
+	V4L2_VP9_INTERP_FILTER_BILINEAR,
+	V4L2_VP9_INTERP_FILTER_SWITCHABLE,
+};
+
+/**
+ * enum v4l2_vp9_reference_mode - VP9 reference modes
+ *
+ * @V4L2_VP9_REF_MODE_SINGLE: indicates that all the inter blocks use only a
+ *			      single reference frame to generate motion
+ *			      compensated prediction
+ * @V4L2_VP9_REF_MODE_COMPOUND: requires all the inter blocks to use compound
+ *				mode. Single reference frame prediction is not
+ *				allowed
+ * @V4L2_VP9_REF_MODE_SELECT: allows each individual inter block to select
+ *			      between single and compound prediction modes
+ *
+ * See section '7.3.6 Frame reference mode semantics' of the VP9 specification
+ * for more details.
+ */
+enum v4l2_vp9_reference_mode {
+	V4L2_VP9_REF_MODE_SINGLE,
+	V4L2_VP9_REF_MODE_COMPOUND,
+	V4L2_VP9_REF_MODE_SELECT,
+};
+
+/**
+ * enum v4l2_vp9_tx_mode - VP9 TX modes
+ *
+ * @V4L2_VP9_TX_MODE_ONLY_4X4: transform size is 4x4
+ * @V4L2_VP9_TX_MODE_ALLOW_8X8: transform size can be up to 8x8
+ * @V4L2_VP9_TX_MODE_ALLOW_16X16: transform size can be up to 16x16
+ * @V4L2_VP9_TX_MODE_ALLOW_32X32: transform size can be up to 32x32
+ * @V4L2_VP9_TX_MODE_SELECT: bitstream contains transform size for each block
+ *
+ * See section '7.3.1 Tx mode semantics' of the VP9 specification for more
+ * details.
+ */
+enum v4l2_vp9_tx_mode {
+	V4L2_VP9_TX_MODE_ONLY_4X4,
+	V4L2_VP9_TX_MODE_ALLOW_8X8,
+	V4L2_VP9_TX_MODE_ALLOW_16X16,
+	V4L2_VP9_TX_MODE_ALLOW_32X32,
+	V4L2_VP9_TX_MODE_SELECT,
+};
+
+/**
+ * enum v4l2_vp9_ref_id - VP9 Reference frame IDs
+ *
+ * @V4L2_REF_ID_LAST: last reference frame
+ * @V4L2_REF_ID_GOLDEN: golden reference frame
+ * @V4L2_REF_ID_ALTREF: alternative reference frame
+ * @V4L2_REF_ID_CNT: number of reference frames
+ *
+ * See section '7.4.12 Ref frames semantics' of the VP9 specification for more
+ * details.
+ */
+enum v4l2_vp9_ref_id {
+	V4L2_REF_ID_LAST,
+	V4L2_REF_ID_GOLDEN,
+	V4L2_REF_ID_ALTREF,
+	V4L2_REF_ID_CNT,
+};
+
+/**
+ * enum v4l2_vp9_frame_flags - VP9 frame flags
+ * @V4L2_VP9_FRAME_FLAG_KEY_FRAME: the frame is a key frame
+ * @V4L2_VP9_FRAME_FLAG_SHOW_FRAME: the frame should be displayed
+ * @V4L2_VP9_FRAME_FLAG_ERROR_RESILIENT: the decoding should be error resilient
+ * @V4L2_VP9_FRAME_FLAG_INTRA_ONLY: the frame does not reference other frames
+ * @V4L2_VP9_FRAME_FLAG_ALLOW_HIGH_PREC_MV: the frame might can high precision
+ *					    motion vectors
+ * @V4L2_VP9_FRAME_FLAG_REFRESH_FRAME_CTX: frame context should be updated
+ *					   after decoding
+ * @V4L2_VP9_FRAME_FLAG_PARALLEL_DEC_MODE: parallel decoding is used
+ * @V4L2_VP9_FRAME_FLAG_X_SUBSAMPLING: vertical subsampling is enabled
+ * @V4L2_VP9_FRAME_FLAG_Y_SUBSAMPLING: horizontal subsampling is enabled
+ * @V4L2_VP9_FRAME_FLAG_COLOR_RANGE_FULL_SWING: full UV range is used
+ *
+ * Check the VP9 specification for more details.
+ */
+enum v4l2_vp9_frame_flags {
+	V4L2_VP9_FRAME_FLAG_KEY_FRAME = 1 << 0,
+	V4L2_VP9_FRAME_FLAG_SHOW_FRAME = 1 << 1,
+	V4L2_VP9_FRAME_FLAG_ERROR_RESILIENT = 1 << 2,
+	V4L2_VP9_FRAME_FLAG_INTRA_ONLY = 1 << 3,
+	V4L2_VP9_FRAME_FLAG_ALLOW_HIGH_PREC_MV = 1 << 4,
+	V4L2_VP9_FRAME_FLAG_REFRESH_FRAME_CTX = 1 << 5,
+	V4L2_VP9_FRAME_FLAG_PARALLEL_DEC_MODE = 1 << 6,
+	V4L2_VP9_FRAME_FLAG_X_SUBSAMPLING = 1 << 7,
+	V4L2_VP9_FRAME_FLAG_Y_SUBSAMPLING = 1 << 8,
+	V4L2_VP9_FRAME_FLAG_COLOR_RANGE_FULL_SWING = 1 << 9,
+};
+
+#define V4L2_VP9_PROFILE_MAX		3
+
+#define V4L2_CID_STATELESS_VP9_FRAME_DECODE_PARAMS	(V4L2_CID_CODEC_STATELESS_BASE + 300)
+/**
+ * struct v4l2_ctrl_vp9_frame_decode_params - VP9 frame decoding control
+ *
+ * @flags: combination of V4L2_VP9_FRAME_FLAG_* flags
+ * @compressed_header_size: compressed header size in bytes
+ * @uncompressed_header_size: uncompressed header size in bytes
+ * @profile: VP9 profile. Can be 0, 1, 2 or 3
+ * @reset_frame_context: specifies whether the frame context should be reset
+ *			 to default values. See &v4l2_vp9_reset_frame_context
+ *			 for more details
+ * @frame_context_idx: frame context that should be used/updated
+ * @bit_depth: bits per components. Can be 8, 10 or 12. Note that not all
+ *	       profiles support 10 and/or 12 bits depths
+ * @interpolation_filter: specifies the filter selection used for performing
+ *			  inter prediction. See &v4l2_vp9_interpolation_filter
+ *			  for more details
+ * @tile_cols_log2: specifies the base 2 logarithm of the width of each tile
+ *		    (where the width is measured in units of 8x8 blocks).
+ *		    Shall be less than or equal to 6
+ * @tile_rows_log2: specifies the base 2 logarithm of the height of each tile
+ *		    (where the height is measured in units of 8x8 blocks)
+ * @tx_mode: specifies the TX mode. See &v4l2_vp9_tx_mode for more details
+ * @reference_mode: specifies the type of inter prediction to be used. See
+ *		    &v4l2_vp9_reference_mode for more details
+ * @padding: needed to make this struct 64 bit aligned. Shall be filled with
+ *	     zeros
+ * @frame_width_minus_1: add 1 to it and you'll get the frame width expressed
+ *			 in pixels
+ * @frame_height_minus_1: add 1 to it and you'll get the frame height expressed
+ *			  in pixels
+ * @render_width_minus_1: add 1 to it and you'll get the expected render width
+ *			 expressed in pixels. This is not used during the
+ *			 decoding process but might be used by HW scalers to
+ *			 prepare a frame that's ready for scanout
+ * @render_height_minus_1: add 1 to it and you'll get the expected render height
+ *			 expressed in pixels. This is not used during the
+ *			 decoding process but might be used by HW scalers to
+ *			 prepare a frame that's ready for scanout
+ * @refs: array of ref frames timestamps. See &v4l2_vp9_ref_id for more details
+ * @ref_frame_sign_bias: array of reference frames motion vector sign bias
+ *			(prediction direction)
+ * @lf: loop filter parameters. See &v4l2_vp9_loop_filter for more details
+ * @quant: quantization parameters. See &v4l2_vp9_quantization for more details
+ * @seg: segmentation parameters. See &v4l2_vp9_segmentation for more details
+ */
+struct v4l2_ctrl_vp9_frame_decode_params {
+	__u32 flags;
+	__u16 compressed_header_size;
+	__u16 uncompressed_header_size;
+	__u8 profile;
+	__u8 reset_frame_context;
+	__u8 frame_context_idx;
+	__u8 bit_depth;
+	__u8 interpolation_filter;
+	__u8 tile_cols_log2;
+	__u8 tile_rows_log2;
+	__u8 tx_mode;
+	__u8 reference_mode;
+	__u8 padding[7];
+	__u16 frame_width_minus_1;
+	__u16 frame_height_minus_1;
+	__u16 render_width_minus_1;
+	__u16 render_height_minus_1;
+	__u64 refs[V4L2_REF_ID_CNT];
+	__u8 ref_frame_sign_bias[V4L2_REF_ID_CNT + 1];
+	struct v4l2_vp9_loop_filter lf;
+	struct v4l2_vp9_quantization quant;
+	struct v4l2_vp9_segmentation seg;
+};
+
+#define V4L2_VP9_NUM_FRAME_CTX	4
+
+/**
+ * struct v4l2_vp9_mv_compressed_hdr_probs - VP9 Motion vector probability updates
+ * @joint: motion vector joint probability updates
+ * @sign: motion vector sign probability updates
+ * @class: motion vector class probability updates
+ * @class0_bit: motion vector class0 bit probability updates
+ * @bits: motion vector bits probability updates
+ * @class0_fr: motion vector class0 fractional bit probability updates
+ * @fr: motion vector fractional bit probability updates
+ * @class0_hp: motion vector class0 high precision fractional bit probability updates
+ * @hp: motion vector high precision fractional bit probability updates
+ *
+ * This structure contains new values of motion vector probabilities.
+ * A value of zero means there is no update.
+ * See `struct v4l2_vp9_prob_updates` for details.
+ */
+struct v4l2_vp9_mv_compressed_hdr_probs {
+	__u8 joint[3];
+	__u8 sign[2];
+	__u8 class[2][10];
+	__u8 class0_bit[2];
+	__u8 bits[2][10];
+	__u8 class0_fr[2][2][3];
+	__u8 fr[2][3];
+	__u8 class0_hp[2];
+	__u8 hp[2];
+};
+
+#define V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS	(V4L2_CID_CODEC_STATELESS_BASE + 301)
+/**
+ * struct v4l2_ctrl_vp9_compressed_hdr_probs - VP9 probability updates control
+ * @tx8: TX 8x8 probability updates
+ * @tx16: TX 16x16 probability updates
+ * @tx32: TX 32x32 probability updates
+ * @coef: coefficient probability updates
+ * @skip: skip probability updates
+ * @inter_mode: inter mode probability updates
+ * @interp_filter: interpolation filter probability updates
+ * @is_inter: is inter-block probability updates
+ * @comp_mode: compound prediction mode probability updates
+ * @single_ref: single ref probability updates
+ * @comp_ref: compound ref probability updates
+ * @y_mode: Y prediction mode probability updates
+ * @uv_mode: UV prediction mode probability updates
+ * @partition: partition probability updates
+ * @mv: motion vector probability updates
+ *
+ * This structure holds the probabilities update as parsed in the compressed
+ * header (Spec 6.3). These values represent the value of probability update after
+ * being translated with inv_map_table[] (see 6.3.5). A value of zero means that
+ * there is no update.
+ */
+struct v4l2_ctrl_vp9_compressed_hdr_probs {
+	__u8 tx8[2][1];
+	__u8 tx16[2][2];
+	__u8 tx32[2][3];
+	__u8 coef[4][2][2][6][6][3];
+	__u8 skip[3];
+	__u8 inter_mode[7][3];
+	__u8 interp_filter[4][2];
+	__u8 is_inter[4];
+	__u8 comp_mode[5];
+	__u8 single_ref[5][2];
+	__u8 comp_ref[5];
+	__u8 y_mode[4][9];
+	__u8 uv_mode[10][9];
+	__u8 partition[16][3];
+
+	struct v4l2_vp9_mv_compressed_hdr_probs mv;
+};
+
 /* MPEG-compression definitions kept for backwards compatibility */
 #ifndef __KERNEL__
 #define V4L2_CTRL_CLASS_MPEG            V4L2_CTRL_CLASS_CODEC
diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
index 311a01cc5775..508e2d6825b1 100644
--- a/include/uapi/linux/videodev2.h
+++ b/include/uapi/linux/videodev2.h
@@ -697,6 +697,7 @@ struct v4l2_pix_format {
 #define V4L2_PIX_FMT_VP8      v4l2_fourcc('V', 'P', '8', '0') /* VP8 */
 #define V4L2_PIX_FMT_VP8_FRAME v4l2_fourcc('V', 'P', '8', 'F') /* VP8 parsed frame */
 #define V4L2_PIX_FMT_VP9      v4l2_fourcc('V', 'P', '9', '0') /* VP9 */
+#define V4L2_PIX_FMT_VP9_FRAME v4l2_fourcc('V', 'P', '9', 'F') /* VP9 parsed frame */
 #define V4L2_PIX_FMT_HEVC     v4l2_fourcc('H', 'E', 'V', 'C') /* HEVC aka H.265 */
 #define V4L2_PIX_FMT_FWHT     v4l2_fourcc('F', 'W', 'H', 'T') /* Fast Walsh Hadamard Transform (vicodec) */
 #define V4L2_PIX_FMT_FWHT_STATELESS     v4l2_fourcc('S', 'F', 'W', 'H') /* Stateless FWHT (vicodec) */
@@ -1747,6 +1748,8 @@ struct v4l2_ext_control {
 		struct v4l2_ctrl_h264_decode_params __user *p_h264_decode_params;
 		struct v4l2_ctrl_fwht_params __user *p_fwht_params;
 		struct v4l2_ctrl_vp8_frame __user *p_vp8_frame;
+		struct v4l2_ctrl_vp9_compressed_hdr_probs __user *p_vp9_compressed_hdr_probs;
+		struct v4l2_ctrl_vp9_frame_decode_params __user *p_vp9_frame_decode_params;
 		void __user *ptr;
 	};
 } __attribute__ ((packed));
@@ -1807,6 +1810,9 @@ enum v4l2_ctrl_type {
 	V4L2_CTRL_TYPE_FWHT_PARAMS	    = 0x0220,
 
 	V4L2_CTRL_TYPE_VP8_FRAME            = 0x0240,
+
+	V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR_PROBS	= 0x0260,
+	V4L2_CTRL_TYPE_VP9_FRAME_DECODE_PARAMS	= 0x0261,
 };
 
 /*  Used in the VIDIOC_QUERYCTRL ioctl for querying controls */
-- 
2.17.1

Re: [RFC RESEND 2/3] media: uapi: Add VP9 stateless decoder controls

[Hans Verkuil]

On 21/04/2021 12:00, Andrzej Pietrasiewicz wrote:
> Add the VP9 stateless decoder controls plus the documentation that goes
> with it.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
> ---
>  .../userspace-api/media/v4l/biblio.rst        |  10 +
>  .../media/v4l/ext-ctrls-codec-stateless.rst   | 523 ++++++++++++++++++
>  .../media/v4l/pixfmt-compressed.rst           |  15 +
>  .../media/v4l/vidioc-g-ext-ctrls.rst          |   8 +
>  .../media/v4l/vidioc-queryctrl.rst            |  12 +
>  .../media/videodev2.h.rst.exceptions          |   2 +
>  drivers/media/v4l2-core/v4l2-ctrls.c          | 244 ++++++++
>  drivers/media/v4l2-core/v4l2-ioctl.c          |   1 +
>  include/media/v4l2-ctrls.h                    |   4 +
>  include/uapi/linux/v4l2-controls.h            | 455 +++++++++++++++
>  include/uapi/linux/videodev2.h                |   6 +
>  11 files changed, 1280 insertions(+)
> 
> diff --git a/Documentation/userspace-api/media/v4l/biblio.rst b/Documentation/userspace-api/media/v4l/biblio.rst
> index 64d241daf63c..051982896375 100644
> --- a/Documentation/userspace-api/media/v4l/biblio.rst
> +++ b/Documentation/userspace-api/media/v4l/biblio.rst
> @@ -417,3 +417,13 @@ VP8
>  :title:     RFC 6386: "VP8 Data Format and Decoding Guide"
>  
>  :author:    J. Bankoski et al.
> +
> +.. _vp9:
> +
> +VP9
> +===
> +
> +
> +:title:     VP9 Bitstream & Decoding Process Specification
> +
> +:author:    Adrian Grange (Google), Peter de Rivaz (Argon Design), Jonathan Hunt (Argon Design)
> diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-codec-stateless.rst b/Documentation/userspace-api/media/v4l/ext-ctrls-codec-stateless.rst
> index 3fc04daa9ffb..ab40c878c8ad 100644
> --- a/Documentation/userspace-api/media/v4l/ext-ctrls-codec-stateless.rst
> +++ b/Documentation/userspace-api/media/v4l/ext-ctrls-codec-stateless.rst
> @@ -1244,3 +1244,526 @@ FWHT Flags
>      * - __u8
>        - ``padding[3]``
>        - Applications and drivers must set this to zero.
> +
> +.. _v4l2-codec-stateless-vp9:
> +
> +``V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS (struct)``
> +    Stores VP9 probabilities updates as parsed from the current compressed frame
> +    header. A value of zero in a struct member means no update of the relevant
> +    probability. Motion vector-related updates contain a new value or zero. All
> +    other updates contain values translated with inv_map_table[] (see 6.3.5 in
> +    :ref:`vp9`).
> +
> +.. c:type:: v4l2_ctrl_vp9_compressed_hdr_probs
> +
> +.. cssclass:: longtable
> +
> +.. tabularcolumns:: |p{5.8cm}|p{4.8cm}|p{6.6cm}|
> +
> +.. flat-table:: struct v4l2_ctrl_vp9_compressed_hdr_probs
> +    :header-rows:  0
> +    :stub-columns: 0
> +    :widths:       1 1 2
> +
> +    * - __u8
> +      - ``tx8[2][1]``
> +      - TX 8x8 probabilities delta.
> +    * - __u8
> +      - ``tx16[2][2]``
> +      - TX 16x16 probabilities delta.
> +    * - __u8
> +      - ``tx32[2][3]``
> +      - TX 32x32 probabilities delta.
> +    * - __u8
> +      - ``coef[4][2][2][6][6][3]``
> +      - Coefficient probabilities delta.
> +    * - __u8
> +      - ``skip[3]``
> +      - Skip probabilities delta.
> +    * - __u8
> +      - ``inter_mode[7][3]``
> +      - Inter prediction mode probabilities delta.
> +    * - __u8
> +      - ``interp_filter[4][2]``
> +      - Interpolation filter probabilities delta.
> +    * - __u8
> +      - ``is_inter[4]``
> +      - Is inter-block probabilities delta.
> +    * - __u8
> +      - ``comp_mode[5]``
> +      - Compound prediction mode probabilities delta.
> +    * - __u8
> +      - ``single_ref[5][2]``
> +      - Single reference probabilities delta.
> +    * - __u8
> +      - ``comp_mode[5]``
> +      - Compound reference probabilities delta.
> +    * - __u8
> +      - ``y_mode[4][9]``
> +      - Y prediction mode probabilities delta.
> +    * - __u8
> +      - ``uv_mode[10][9]``
> +      - UV prediction mode probabilities delta.
> +    * - __u8
> +      - ``partition[16][3]``
> +      - Partition probabilities delta.
> +    * - __u8
> +      - ``partition[16][3]``
> +      - Partition probabilities delta.
> +    * - __u8
> +      - ``mv.joint[3]``
> +      - Motion vector joint probabilities delta.
> +    * - __u8
> +      - ``mv.sign[2]``
> +      - Motion vector sign probabilities delta.
> +    * - __u8
> +      - ``mv.class[2][10]``
> +      - Motion vector class probabilities delta.
> +    * - __u8
> +      - ``mv.class0_bit[2]``
> +      - Motion vector class0 bit probabilities delta.
> +    * - __u8
> +      - ``mv.bits[2][10]``
> +      - Motion vector bits probabilities delta.
> +    * - __u8
> +      - ``mv.class0_fr[2][2][3]``
> +      - Motion vector class0 fractional bit probabilities delta.
> +    * - __u8
> +      - ``mv.fr[2][3]``
> +      - Motion vector fractional bit probabilities delta.
> +    * - __u8
> +      - ``mv.class0_hp[2]``
> +      - Motion vector class0 high precision fractional bit probabilities delta.
> +    * - __u8
> +      - ``mv.hp[2]``
> +      - Motion vector high precision fractional bit probabilities delta.
> +
> +``V4L2_CID_STATELESS_VP9_FRAME_DECODE_PARAMS (struct)``
> +    Specifies the frame parameters for the associated VP9 frame decode request.
> +    This includes the necessary parameters for configuring a stateless hardware
> +    decoding pipeline for VP9. The bitstream parameters are defined according
> +    to :ref:`vp9`.

Are there specific sections in the spec that define these parameters? Or is it
all over the place? If it's the latter, would it be possible to add a reference
to the respective sections in the field documentation below?

Update: I noticed a lot of references to the spec in v4l2-controls.h. If those
references would answer this question, then you can refer to that header from
here. Or just copy those section references into this documentation.

> +
> +    .. note::
> +
> +       This compound control is not yet part of the public kernel API and
> +       it is expected to change.

Since this patch series add this to uAPI right away, this note must be dropped.

> +
> +.. c:type:: v4l2_ctrl_vp9_frame_decode_params
> +
> +.. cssclass:: longtable
> +
> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
> +
> +.. flat-table:: struct v4l2_ctrl_vp9_frame_decode_params
> +    :header-rows:  0
> +    :stub-columns: 0
> +    :widths:       1 1 2
> +
> +    * - __u32
> +      - ``flags``
> +      - Combination of V4L2_VP9_FRAME_FLAG_* flags. See
> +        :c:type:`v4l2_vp9_frame_flags`.
> +    * - __u16
> +      - ``compressed_header_size``
> +      - Compressed header size in bytes.
> +    * - __u16
> +      - ``uncompressed_header_size``
> +      - Uncompressed header size in bytes.
> +    * - __u8
> +      - ``profile``
> +      - VP9 profile. Can be 0, 1, 2 or 3.
> +    * - __u8
> +      - ``reset_frame_context``
> +      - Frame context that should be used/updated when decoding the frame.
> +    * - __u8
> +      - ``bit_depth``
> +      - Component depth in bits. Must be 8 for profile 0 and 1. Must 10 or 12
> +        for profile 2 and 3.
> +    * - __u8
> +      - ``interpolation_filter``
> +      - Specifies the filter selection used for performing inter prediction. See
> +        :c:type:`v4l2_vp9_interpolation_filter`.
> +    * - __u8
> +      - ``tile_cols_log2``
> +      - Specifies the base 2 logarithm of the width of each tile (where the
> +        width is measured in units of 8x8 blocks). Shall be less than or equal
> +        to 6.
> +    * - __u8
> +      - ``tile_rows_log2``
> +      - Specifies the base 2 logarithm of the height of each tile (where the
> +        height is measured in units of 8x8 blocks)

Missing period at the end of the sentence.

> +    * - __u8
> +      - ``tx_mode``
> +      - Specifies the TX mode. See :c:type:`v4l2_vp9_tx_mode`.
> +    * - __u8
> +      - ``reference_mode``
> +      - Specifies the type of inter prediction to be used. See
> +        :c:type:`v4l2_vp9_reference_mode`.
> +    * - __u8
> +      - ``padding[7]``
> +      - Needed to make this struct 64 bit aligned. Shall be filled with zeroes.
> +    * - __u16
> +      - ``frame_width_minus_1``
> +      - Add 1 to get the frame width expressed in pixels.
> +    * - __u16
> +      - ``frame_height_minus_1``
> +      - Add 1 to get the frame height expressed in pixels.

These two fields are weird. Isn't this defined by setting the output format?
And why the 'minus_1'?

> +    * - __u16
> +      - ``render_width_minus_1``
> +      - Add 1 to get the expected render width expressed in pixels. This is
> +        not used during the decoding process but might be used by HW scalers to
> +        prepare a frame that's ready for scanout.
> +    * - __u16
> +      - render_height_minus_1
> +      - Add 1 to get the expected render height expressed in pixels. This is
> +        not used during the decoding process but might be used by HW scalers to
> +        prepare a frame that's ready for scanout.

No idea what these fields are about. I suspect this can be defined by setting
the capture format, but I'm not sure.

> +    * - __u64
> +      - ``refs[3]``
> +      - Array of reference frame timestamps.
> +    * - __u8
> +      - ``ref_frame_sign_bias[4]``
> +      - Array of reference frames motion vector sign bias (prediction direction)

Missing period at the end.

> +    * - struct :c:type:`v4l2_vp9_loop_filter`
> +      - ``lf``
> +      - Loop filter parameters. See struct :c:type:`v4l2_vp9_loop_filter`.
> +    * - struct :c:type:`v4l2_vp9_quantization`
> +      - ``quant``
> +      - Quantization parameters. See :c:type:`v4l2_vp9_quantization`.
> +    * - struct :c:type:`v4l2_vp9_segmentation`
> +      - ``seg``
> +      - Segmentation parameters. See :c:type:`v4l2_vp9_segmentation`.
> +    * - struct :c:type:`v4l2_vp9_probabilities`
> +      - ``probs``
> +      - Probabilities. See :c:type:`v4l2_vp9_probabilities`.
> +
> +.. c:type:: v4l2_vp9_frame_flags
> +
> +.. cssclass:: longtable
> +
> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
> +
> +.. flat-table:: enum v4l2_vp9_frame_flags
> +    :header-rows:  0
> +    :stub-columns: 0
> +    :widths:       1 2
> +
> +    * - ``V4L2_VP9_FRAME_FLAG_KEY_FRAME``
> +      - The frame is a key frame.
> +    * - ``V4L2_VP9_FRAME_FLAG_SHOW_FRAME``
> +      - The frame should be displayed.
> +    * - ``V4L2_VP9_FRAME_FLAG_ERROR_RESILIENT``
> +      - The decoding should be error resilient.
> +    * - ``V4L2_VP9_FRAME_FLAG_INTRA_ONLY``
> +      - The frame does not reference other frames.
> +    * - ``V4L2_VP9_FRAME_FLAG_ALLOW_HIGH_PREC_MV``
> +      - the frame might can high precision motion vectors.

'might can'? Should that be 'can use'?

> +    * - ``V4L2_VP9_FRAME_FLAG_REFRESH_FRAME_CTX``
> +      - Frame context should be updated after decoding.
> +    * - ``V4L2_VP9_FRAME_FLAG_PARALLEL_DEC_MODE``
> +      - Parallel decoding is used.
> +    * - ``V4L2_VP9_FRAME_FLAG_X_SUBSAMPLING``
> +      - Vertical subsampling is enabled.
> +    * - ``V4L2_VP9_FRAME_FLAG_Y_SUBSAMPLING``
> +      - Horizontal subsampling is enabled.
> +    * - ``V4L2_VP9_FRAME_FLAG_COLOR_RANGE_FULL_SWING``
> +      - The full UV range is used.
> +
> +.. c:type:: v4l2_vp9_ref_id
> +
> +.. cssclass:: longtable
> +
> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
> +
> +.. flat-table:: enum v4l2_vp9_ref_id
> +    :header-rows:  0
> +    :stub-columns: 0
> +    :widths:       1 2
> +
> +    * - ``V4L2_REF_ID_LAST``
> +      - Last reference frame.
> +    * - ``V4L2_REF_ID_GOLDEN``
> +      - Golden reference frame.
> +    * - ``V4L2_REF_ID_ALTREF``
> +      - Alternative reference frame.
> +    * - ``V4L2_REF_ID_CNT``
> +      - Number of reference frames.
> +
> +.. c:type:: v4l2_vp9_tx_mode
> +
> +.. cssclass:: longtable
> +
> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
> +
> +.. flat-table:: enum v4l2_vp9_tx_mode
> +    :header-rows:  0
> +    :stub-columns: 0
> +    :widths:       1 2
> +
> +    * - ``V4L2_VP9_TX_MODE_ONLY_4X4``
> +      - Transform size is 4x4.
> +    * - ``V4L2_VP9_TX_MODE_ALLOW_8X8``
> +      - Transform size can be up to 8x8.
> +    * - ``V4L2_VP9_TX_MODE_ALLOW_16X16``
> +      - Transform size can be up to 16x16.
> +    * - ``V4L2_VP9_TX_MODE_ALLOW_32X32``
> +      - transform size can be up to 32x32.
> +    * - ``V4L2_VP9_TX_MODE_SELECT``
> +      - Bitstream contains transform size for each block.

Either 'contains the transform size' or 'contains transform sizes',
whichever is appropriate.

> +
> +.. c:type:: v4l2_vp9_reference_mode
> +
> +.. cssclass:: longtable
> +
> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
> +
> +.. flat-table:: enum v4l2_vp9_reference_mode
> +    :header-rows:  0
> +    :stub-columns: 0
> +    :widths:       1 2
> +
> +    * - ``V4L2_VP9_REF_MODE_SINGLE``
> +      - Indicates that all the inter blocks use only a single reference frame
> +        to generate motion compensated prediction.
> +    * - ``V4L2_VP9_REF_MODE_COMPOUND``
> +      - Requires all the inter blocks to use compound mode. Single reference
> +        frame prediction is not allowed.
> +    * - ``V4L2_VP9_REF_MODE_SELECT``
> +      - Allows each individual inter block to select between single and
> +        compound prediction modes.
> +
> +.. c:type:: v4l2_vp9_interpolation_filter
> +
> +.. cssclass:: longtable
> +
> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
> +
> +.. flat-table:: enum v4l2_vp9_interpolation_filter
> +    :header-rows:  0
> +    :stub-columns: 0
> +    :widths:       1 2
> +
> +    * - ``V4L2_VP9_INTERP_FILTER_8TAP``
> +      - Height tap filter.
> +    * - ``V4L2_VP9_INTERP_FILTER_8TAP_SMOOTH``
> +      - Height tap smooth filter.
> +    * - ``V4L2_VP9_INTERP_FILTER_8TAP_SHARP``
> +      - Height tap sharp filter.
> +    * - ``V4L2_VP9_INTERP_FILTER_BILINEAR``
> +      - Bilinear filter.
> +    * - ``V4L2_VP9_INTERP_FILTER_SWITCHABLE``
> +      - Filter selection is signaled at the block level.
> +
> +.. c:type:: v4l2_vp9_reset_frame_context
> +
> +.. cssclass:: longtable
> +
> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
> +
> +.. flat-table:: enum v4l2_vp9_reset_frame_context
> +    :header-rows:  0
> +    :stub-columns: 0
> +    :widths:       1 2
> +
> +    * - ``V4L2_VP9_RESET_FRAME_CTX_NONE``
> +      - Do not reset any frame context.
> +    * - ``V4L2_VP9_RESET_FRAME_CTX_SPEC``
> +      - Reset the frame context pointed by

pointed -> pointed to

> +        :c:type:`v4l2_ctrl_vp9_frame_decode_params`.frame_context_idx.
> +    * - ``V4L2_VP9_RESET_FRAME_CTX_ALL``
> +      - Reset all frame contexts.
> +
> +.. c:type:: v4l2_vp9_intra_prediction_mode
> +
> +.. cssclass:: longtable
> +
> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
> +
> +.. flat-table:: enum v4l2_vp9_intra_prediction_mode
> +    :header-rows:  0
> +    :stub-columns: 0
> +    :widths:       1 2
> +
> +    * - ``V4L2_VP9_INTRA_PRED_DC``
> +      - DC intra prediction.
> +    * - ``V4L2_VP9_INTRA_PRED_MODE_V``
> +      - Vertical intra prediction.
> +    * - ``V4L2_VP9_INTRA_PRED_MODE_H``
> +      - Horizontal intra prediction.
> +    * - ``V4L2_VP9_INTRA_PRED_MODE_D45``
> +      - D45 intra prediction.
> +    * - ``V4L2_VP9_INTRA_PRED_MODE_D135``
> +      - D135 intra prediction.
> +    * - ``V4L2_VP9_INTRA_PRED_MODE_D117``
> +      - D117 intra prediction.
> +    * - ``V4L2_VP9_INTRA_PRED_MODE_D153``
> +      - D153 intra prediction.
> +    * - ``V4L2_VP9_INTRA_PRED_MODE_D207``
> +      - D207 intra prediction.
> +    * - ``V4L2_VP9_INTRA_PRED_MODE_D63``
> +      - D63 intra prediction.
> +    * - ``V4L2_VP9_INTRA_PRED_MODE_TM``
> +      - True motion intra prediction.
> +
> +.. c:type:: v4l2_vp9_segmentation
> +
> +.. cssclass:: longtable
> +
> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
> +
> +.. flat-table:: struct v4l2_vp9_segmentation
> +    :header-rows:  0
> +    :stub-columns: 0
> +    :widths:       1 1 2
> +
> +    * - __u8
> +      - ``flags``
> +      - Combination of V4L2_VP9_SEGMENTATION_FLAG_* flags. See
> +        :c:type:`v4l2_vp9_segmentation_flags`.
> +    * - __u8
> +      - ``tree_probs[7]``
> +      - Specifies the probability values to be used when decoding a Segment-ID.
> +        See '5.15. Segmentation map' section of :ref:`vp9` for more details.
> +    * - __u8
> +      - ``pred_prob[3]``
> +      - Specifies the probability values to be used when decoding a
> +        Predicted-Segment-ID. See '6.4.14. Get segment id syntax'
> +        section of :ref:`vp9` for more details.
> +    * - __u8
> +      - ``padding[5]``
> +      - Used to align this struct on 64 bit. Shall be filled with zeroes.

I would prefer to have this at the end of the struct. In general I
prefer padding at the end, not in the middle of a struct, if at all
possible.

> +    * - __u8
> +      - ``feature_enabled[8]``
> +      - Bitmask defining which features are enabled in each segment.
> +    * - __u8
> +      - ``feature_data[8][4]``
> +      - Data attached to each feature. Data entry is only valid if the feature
> +        is enabled.
> +
> +.. c:type:: v4l2_vp9_segment_feature
> +
> +.. cssclass:: longtable
> +
> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
> +
> +.. flat-table:: enum v4l2_vp9_segment_feature
> +    :header-rows:  0
> +    :stub-columns: 0
> +    :widths:       1 2
> +
> +    * - ``V4L2_VP9_SEGMENT_FEATURE_QP_DELTA``
> +      - QP delta segment feature.
> +    * - ``V4L2_VP9_SEGMENT_FEATURE_LF``
> +      - Loop filter segment feature.
> +    * - ``V4L2_VP9_SEGMENT_FEATURE_REF_FRAME``
> +      - Reference frame segment feature.
> +    * - ``V4L2_VP9_SEGMENT_FEATURE_SKIP``
> +      - Skip segment feature.
> +    * - ``V4L2_VP9_SEGMENT_FEATURE_CNT``
> +      - Number of segment features.
> +
> +.. c:type:: v4l2_vp9_segmentation_flags
> +
> +.. cssclass:: longtable
> +
> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
> +
> +.. flat-table:: enum v4l2_vp9_segmentation_flags
> +    :header-rows:  0
> +    :stub-columns: 0
> +    :widths:       1 2
> +
> +    * - ``V4L2_VP9_SEGMENTATION_FLAG_ENABLED``
> +      - Indicates that this frame makes use of the segmentation tool.
> +    * - ``V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP``
> +      - Indicates that the segmentation map should be updated during the
> +        decoding of this frame.
> +    * - ``V4L2_VP9_SEGMENTATION_FLAG_TEMPORAL_UPDATE``
> +      - Indicates that the updates to the segmentation map are coded
> +        relative to the existing segmentation map.
> +    * - ``V4L2_VP9_SEGMENTATION_FLAG_UPDATE_DATA``
> +      - Indicates that new parameters are about to be specified for each
> +        segment.
> +    * - ``V4L2_VP9_SEGMENTATION_FLAG_ABS_OR_DELTA_UPDATE``
> +      - Indicates that the segmentation parameters represent the actual values
> +        to be used.
> +
> +.. c:type:: v4l2_vp9_quantization
> +
> +.. cssclass:: longtable
> +
> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
> +
> +.. flat-table:: struct v4l2_vp9_quantization
> +    :header-rows:  0
> +    :stub-columns: 0
> +    :widths:       1 1 2
> +
> +    * - __u8
> +      - ``base_q_idx``
> +      - Indicates the base frame qindex.
> +    * - __s8
> +      - ``delta_q_y_dc``
> +      - Indicates the Y DC quantizer relative to base_q_idx.
> +    * - __s8
> +      - ``delta_q_uv_dc``
> +      - Indicates the UV DC quantizer relative to base_q_idx.
> +    * - __s8
> +      - ``delta_q_uv_ac``
> +      - Indicates the UV AC quantizer relative to base_q_idx.
> +    * - __u8
> +      - ``padding[4]``
> +      - Padding bytes used to align this struct on 64 bit. Must be set to 0.
> +
> +.. c:type:: v4l2_vp9_loop_filter
> +
> +.. cssclass:: longtable
> +
> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
> +
> +.. flat-table:: struct v4l2_vp9_loop_filter
> +    :header-rows:  0
> +    :stub-columns: 0
> +    :widths:       1 1 2
> +
> +    * - __u8
> +      - ``flags``
> +      - Combination of V4L2_VP9_LOOP_FILTER_FLAG_* flags.
> +        See :c:type:`v4l2_vp9_loop_filter_flags`.
> +    * - __u8
> +      - ``level``
> +      - Indicates the loop filter strength.
> +    * - __u8
> +      - ``sharpness``
> +      - Indicates the sharpness level.
> +    * - __s8
> +      - ``ref_deltas[4]``
> +      - Contains the adjustment needed for the filter level based on the chosen
> +        reference frame.
> +    * - __s8
> +      - ``mode_deltas[2]``
> +      - Contains the adjustment needed for the filter level based on the chosen
> +        mode
> +    * - __u8
> +      - ``level_lookup[8][4][2]``
> +      - Level lookup table.
> +
> +
> +.. c:type:: v4l2_vp9_loop_filter_flags
> +
> +.. cssclass:: longtable
> +
> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
> +
> +.. flat-table:: enum v4l2_vp9_loop_filter_flags
> +    :header-rows:  0
> +    :stub-columns: 0
> +    :widths:       1 2
> +
> +    * - ``V4L2_VP9_LOOP_FILTER_FLAG_DELTA_ENABLED``
> +      - When set, the filter level depends on the mode and reference frame used
> +        to predict a block.
> +    * - ``V4L2_VP9_LOOP_FILTER_FLAG_DELTA_UPDATE``
> +      - When set, the bitstream contains additional syntax elements that
> +        specify which mode and reference frame deltas are to be updated.
> diff --git a/Documentation/userspace-api/media/v4l/pixfmt-compressed.rst b/Documentation/userspace-api/media/v4l/pixfmt-compressed.rst
> index 6dba70da822b..7e34aeb1cb92 100644
> --- a/Documentation/userspace-api/media/v4l/pixfmt-compressed.rst
> +++ b/Documentation/userspace-api/media/v4l/pixfmt-compressed.rst
> @@ -171,6 +171,21 @@ Compressed Formats
>        - VP9 compressed video frame. The encoder generates one
>  	compressed frame per buffer, and the decoder requires one
>  	compressed frame per buffer.
> +    * .. _V4L2-PIX-FMT-VP9_FRAME:
> +
> +      - ``V4L2_PIX_FMT_VP9_FRAME``
> +      - 'VP9F'
> +      - VP9 parsed frame, including the frame header, as extracted from the container.
> +	This format is adapted for stateless video decoders that implement an

an -> a

> +	VP9 pipeline with the :ref:`stateless_decoder`.
> +	Metadata associated with the frame to decode is required to be passed
> +	through the ``V4L2_CID_STATELESS_VP9_FRAME_DECODE_PARAMS`` and
> +	the ``V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS`` controls.
> +	See the :ref:`associated Codec Control IDs <v4l2-codec-stateless-vp9>`.
> +	Exactly one output and one capture buffer must be provided for use with
> +	this pixel format. The output buffer must contain the appropriate number
> +	of macroblocks to decode a full corresponding frame to the matching
> +	capture buffer.
>      * .. _V4L2-PIX-FMT-HEVC:
>  
>        - ``V4L2_PIX_FMT_HEVC``
> diff --git a/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst b/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst
> index 3ba22983d21f..3ff72ca63772 100644
> --- a/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst
> +++ b/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst
> @@ -221,6 +221,14 @@ still cause this situation.
>        - ``p_vp8_frame``
>        - A pointer to a struct :c:type:`v4l2_ctrl_vp8_frame`. Valid if this control is
>          of type ``V4L2_CTRL_TYPE_VP8_FRAME``.
> +    * - struct :c:type:`v4l2_ctrl_vp9_compressed_hdr_probs` *
> +      - ``p_vp9_compressed_hdr_probs``
> +      - A pointer to a struct :c:type:`v4l2_ctrl_vp9_compressed_hdr_probs'. Valid if this contro is

contro -> control

> +        of type ``V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR_PROBS``.
> +    * - struct :c:type:`v4l2_ctrl_vp9_frame_decode_params` *
> +      - ``p_vp9_frame_decode_params``
> +      - A pointer to a struct :c:type:`v4l2_ctrl_vp9_frame_decode_params'. Valid if this contro is

ditto

> +        of type ``V4L2_CTRL_TYPE_VP9_FRAME_DECODE_PARAMS``.
>      * - struct :c:type:`v4l2_ctrl_hdr10_cll_info` *
>        - ``p_hdr10_cll``
>        - A pointer to a struct :c:type:`v4l2_ctrl_hdr10_cll_info`. Valid if this control is
> diff --git a/Documentation/userspace-api/media/v4l/vidioc-queryctrl.rst b/Documentation/userspace-api/media/v4l/vidioc-queryctrl.rst
> index 8a285daedc6a..85fb8b7a9428 100644
> --- a/Documentation/userspace-api/media/v4l/vidioc-queryctrl.rst
> +++ b/Documentation/userspace-api/media/v4l/vidioc-queryctrl.rst
> @@ -495,6 +495,18 @@ See also the examples in :ref:`control`.
>        - n/a
>        - A struct :c:type:`v4l2_ctrl_vp8_frame`, containing VP8
>  	frame parameters for stateless video decoders.
> +    * - ``V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR_PROBS``
> +      - n/a
> +      - n/a
> +      - n/a
> +      - A struct :c:type:`v4l2_ctrl_vp9_compressed_hdr_probs`, containing VP9
> +	probabilities updates for stateless video decoders.
> +    * - ``V4L2_CTRL_TYPE_VP9_FRAME_DECODE_PARAMS``
> +      - n/a
> +      - n/a
> +      - n/a
> +      - A struct :c:type:`v4l2_ctrl_vp9_compressed_hdr_probs`, containing VP9

v4l2_ctrl_vp9_compressed_hdr_probs -> v4l2_ctrl_vp9_frame_decode_params

> +	frame decode parameters for stateless video decoders.
>  
>  .. raw:: latex
>  
> diff --git a/Documentation/userspace-api/media/videodev2.h.rst.exceptions b/Documentation/userspace-api/media/videodev2.h.rst.exceptions
> index f59940352faa..fdc6f2b22df8 100644
> --- a/Documentation/userspace-api/media/videodev2.h.rst.exceptions
> +++ b/Documentation/userspace-api/media/videodev2.h.rst.exceptions
> @@ -148,6 +148,8 @@ replace symbol V4L2_CTRL_TYPE_HEVC_SLICE_PARAMS :c:type:`v4l2_ctrl_type`
>  replace symbol V4L2_CTRL_TYPE_AREA :c:type:`v4l2_ctrl_type`
>  replace symbol V4L2_CTRL_TYPE_FWHT_PARAMS :c:type:`v4l2_ctrl_type`
>  replace symbol V4L2_CTRL_TYPE_VP8_FRAME :c:type:`v4l2_ctrl_type`
> +replace symbol V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR_PROBS :c:type:`v4l2_ctrl_type`
> +replace symbol V4L2_CTRL_TYPE_VP9_FRAME_DECODE_PARAMS :c:type:`v4l2_ctrl_type`
>  replace symbol V4L2_CTRL_TYPE_HDR10_CLL_INFO :c:type:`v4l2_ctrl_type`
>  replace symbol V4L2_CTRL_TYPE_HDR10_MASTERING_DISPLAY :c:type:`v4l2_ctrl_type`
>  
> diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c
> index 0d7fe1bd975a..8de7238593ab 100644
> --- a/drivers/media/v4l2-core/v4l2-ctrls.c
> +++ b/drivers/media/v4l2-core/v4l2-ctrls.c
> @@ -1215,6 +1215,8 @@ const char *v4l2_ctrl_get_name(u32 id)
>  	case V4L2_CID_STATELESS_H264_DECODE_PARAMS:		return "H264 Decode Parameters";
>  	case V4L2_CID_STATELESS_FWHT_PARAMS:			return "FWHT Stateless Parameters";
>  	case V4L2_CID_STATELESS_VP8_FRAME:			return "VP8 Frame Parameters";
> +	case V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS:	return "VP9 Probabilities Updates";
> +	case V4L2_CID_STATELESS_VP9_FRAME_DECODE_PARAMS:	return "VP9 Frame Decode Parameters";
>  
>  	/* Colorimetry controls */
>  	/* Keep the order of the 'case's the same as in v4l2-controls.h! */
> @@ -1517,6 +1519,12 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum v4l2_ctrl_type *type,
>  	case V4L2_CID_STATELESS_VP8_FRAME:
>  		*type = V4L2_CTRL_TYPE_VP8_FRAME;
>  		break;
> +	case V4L2_CID_STATELESS_VP9_FRAME_DECODE_PARAMS:
> +		*type = V4L2_CTRL_TYPE_VP9_FRAME_DECODE_PARAMS;
> +		break;
> +	case V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS:
> +		*type = V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR_PROBS;
> +		break;

Let's swap the order of these two cases. Everywhere else it seems that
PROBS comes before DECODE_PARARMS, so stay consistent.

>  	case V4L2_CID_MPEG_VIDEO_HEVC_SPS:
>  		*type = V4L2_CTRL_TYPE_HEVC_SPS;
>  		break;
> @@ -1836,6 +1844,12 @@ static void std_log(const struct v4l2_ctrl *ctrl)
>  	case V4L2_CTRL_TYPE_VP8_FRAME:
>  		pr_cont("VP8_FRAME");
>  		break;
> +	case V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR_PROBS:
> +		pr_cont("VP9_COMPRESSED_HDR_PROBS");
> +		break;
> +	case V4L2_CTRL_TYPE_VP9_FRAME_DECODE_PARAMS:
> +		pr_cont("VP9_FRAME_DECODE_PARAMS");
> +		break;
>  	case V4L2_CTRL_TYPE_HDR10_CLL_INFO:
>  		pr_cont("HDR10_CLL_INFO");
>  		break;
> @@ -1869,6 +1883,224 @@ static void std_log(const struct v4l2_ctrl *ctrl)
>  	0;							\
>  })
>  
> +static int
> +validate_vp9_lf_params(struct v4l2_vp9_loop_filter *lf)
> +{
> +	unsigned int i, j, k;
> +
> +	if (lf->flags &
> +	    ~(V4L2_VP9_LOOP_FILTER_FLAG_DELTA_ENABLED |
> +	      V4L2_VP9_LOOP_FILTER_FLAG_DELTA_UPDATE))

This is more readable because it is clearer that you are
checking flags against invalid bits:

	if (lf->flags & ~(V4L2_VP9_LOOP_FILTER_FLAG_DELTA_ENABLED |
			  V4L2_VP9_LOOP_FILTER_FLAG_DELTA_UPDATE))

There are similar cases like this further down, do the same there
unless you get lines that are too long.

> +		return -EINVAL;
> +
> +	/*
> +	 * V4L2_VP9_LOOP_FILTER_FLAG_DELTA_ENABLED implies
> +	 * V4L2_VP9_LOOP_FILTER_FLAG_DELTA_UPDATE.
> +	 */
> +	if (lf->flags & V4L2_VP9_LOOP_FILTER_FLAG_DELTA_UPDATE &&
> +	    !(lf->flags & V4L2_VP9_LOOP_FILTER_FLAG_DELTA_ENABLED))
> +		return -EINVAL;
> +
> +	/* That all values are in the accepted range. */
> +	if (lf->level > GENMASK(5, 0))
> +		return -EINVAL;
> +
> +	if (lf->sharpness > GENMASK(2, 0))
> +		return -EINVAL;
> +
> +	for (i = 0; i < ARRAY_SIZE(lf->ref_deltas); i++) {

You can drop { here.

> +		if (lf->ref_deltas[i] < -63 || lf->ref_deltas[i] > 63)
> +			return -EINVAL;
> +	}
> +
> +	for (i = 0; i < ARRAY_SIZE(lf->mode_deltas); i++) {

ditto

> +		if (lf->mode_deltas[i] < -63 || lf->mode_deltas[i] > 63)
> +			return -EINVAL;
> +	}
> +
> +	for (i = 0; i < ARRAY_SIZE(lf->level_lookup); i++) {

ditto

> +		for (j = 0; j < ARRAY_SIZE(lf->level_lookup[0]); j++) {

ditto

> +			for (k = 0; k < ARRAY_SIZE(lf->level_lookup[0][0]); k++) {

ditto

> +				if (lf->level_lookup[i][j][k] > 63)
> +					return -EINVAL;
> +			}
> +		}
> +	}
> +
> +	return 0;
> +}
> +
> +static int
> +validate_vp9_quant_params(struct v4l2_vp9_quantization *quant)
> +{
> +	if (quant->delta_q_y_dc < -15 || quant->delta_q_y_dc > 15 ||
> +	    quant->delta_q_uv_dc < -15 || quant->delta_q_uv_dc > 15 ||
> +	    quant->delta_q_uv_ac < -15 || quant->delta_q_uv_ac > 15)
> +		return -EINVAL;
> +
> +	memset(quant->padding, 0, sizeof(quant->padding));

Use the zero_padding macro for this. Check other occurrence of this.

> +	return 0;
> +}
> +
> +static int
> +validate_vp9_seg_params(struct v4l2_vp9_segmentation *seg)
> +{
> +	unsigned int i, j;
> +
> +	if (seg->flags &
> +	    ~(V4L2_VP9_SEGMENTATION_FLAG_ENABLED |
> +	      V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP |
> +	      V4L2_VP9_SEGMENTATION_FLAG_TEMPORAL_UPDATE |
> +	      V4L2_VP9_SEGMENTATION_FLAG_UPDATE_DATA |
> +	      V4L2_VP9_SEGMENTATION_FLAG_ABS_OR_DELTA_UPDATE))
> +		return -EINVAL;
> +
> +	/*
> +	 * V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP and
> +	 * V4L2_VP9_SEGMENTATION_FLAG_UPDATE_DATA imply
> +	 * V4L2_VP9_SEGMENTATION_FLAG_ENABLED.
> +	 */
> +	if ((seg->flags &
> +	     (V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP |
> +	      V4L2_VP9_SEGMENTATION_FLAG_UPDATE_DATA)) &&
> +	    !(seg->flags & V4L2_VP9_SEGMENTATION_FLAG_ENABLED))
> +		return -EINVAL;
> +
> +	/*
> +	 * V4L2_VP9_SEGMENTATION_FLAG_TEMPORAL_UPDATE implies
> +	 * V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP.
> +	 */
> +	if (seg->flags & V4L2_VP9_SEGMENTATION_FLAG_TEMPORAL_UPDATE &&
> +	    !(seg->flags & V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP))
> +		return -EINVAL;
> +
> +	/*
> +	 * V4L2_VP9_SEGMENTATION_FLAG_ABS_OR_DELTA_UPDATE implies
> +	 * V4L2_VP9_SEGMENTATION_FLAG_UPDATE_DATA.
> +	 */
> +	if (seg->flags & V4L2_VP9_SEGMENTATION_FLAG_ABS_OR_DELTA_UPDATE &&
> +	    !(seg->flags & V4L2_VP9_SEGMENTATION_FLAG_UPDATE_DATA))
> +		return -EINVAL;
> +
> +	for (i = 0; i < ARRAY_SIZE(seg->feature_enabled); i++) {
> +		if (seg->feature_enabled[i] &
> +		    ~(V4L2_VP9_SEGMENT_FEATURE_QP_DELTA |
> +		      V4L2_VP9_SEGMENT_FEATURE_LF |
> +		      V4L2_VP9_SEGMENT_FEATURE_REF_FRAME |
> +		      V4L2_VP9_SEGMENT_FEATURE_SKIP))
> +			return -EINVAL;
> +	}
> +
> +	for (i = 0; i < ARRAY_SIZE(seg->feature_data); i++) {
> +		const int range[] = {255, 63, 3, 0};

Space after/before { and }.

> +
> +		for (j = 0; j < ARRAY_SIZE(seg->feature_data[j]); j++) {
> +			if (seg->feature_data[i][j] < -range[j] ||
> +			    seg->feature_data[i][j] > range[j])
> +				return -EINVAL;
> +		}
> +	}
> +
> +	memset(seg->padding, 0, sizeof(seg->padding));
> +	return 0;
> +}
> +
> +static int
> +validate_vp9_frame_decode_params(struct v4l2_ctrl_vp9_frame_decode_params *dec_params)
> +{
> +	int ret, i;
> +
> +	/* Make sure we're not passed invalid flags. */
> +	if (dec_params->flags &
> +	    ~(V4L2_VP9_FRAME_FLAG_KEY_FRAME |
> +	      V4L2_VP9_FRAME_FLAG_SHOW_FRAME |
> +	      V4L2_VP9_FRAME_FLAG_ERROR_RESILIENT |
> +	      V4L2_VP9_FRAME_FLAG_INTRA_ONLY |
> +	      V4L2_VP9_FRAME_FLAG_ALLOW_HIGH_PREC_MV |
> +	      V4L2_VP9_FRAME_FLAG_REFRESH_FRAME_CTX |
> +	      V4L2_VP9_FRAME_FLAG_PARALLEL_DEC_MODE |
> +	      V4L2_VP9_FRAME_FLAG_X_SUBSAMPLING |
> +	      V4L2_VP9_FRAME_FLAG_Y_SUBSAMPLING |
> +	      V4L2_VP9_FRAME_FLAG_COLOR_RANGE_FULL_SWING))
> +		return -EINVAL;
> +
> +	/*
> +	 * The refresh context and error resilient flags are mutually exclusive.
> +	 * Same goes for parallel decoding and error resilient modes.
> +	 */
> +	if (dec_params->flags & V4L2_VP9_FRAME_FLAG_ERROR_RESILIENT &&
> +	    dec_params->flags &
> +	    (V4L2_VP9_FRAME_FLAG_REFRESH_FRAME_CTX |
> +	     V4L2_VP9_FRAME_FLAG_PARALLEL_DEC_MODE))
> +		return -EINVAL;
> +
> +	if (dec_params->profile > V4L2_VP9_PROFILE_MAX)
> +		return -EINVAL;
> +
> +	if (dec_params->reset_frame_context > V4L2_VP9_RESET_FRAME_CTX_ALL)
> +		return -EINVAL;
> +
> +	if (dec_params->frame_context_idx >= V4L2_VP9_NUM_FRAME_CTX)
> +		return -EINVAL;
> +
> +	/*
> +	 * Profiles 0 and 1 only support 8-bit depth, profiles 2 and 3 only 10
> +	 * and 12 bit depths.
> +	 */
> +	if ((dec_params->profile < 2 && dec_params->bit_depth != 8) ||
> +	    (dec_params->profile >= 2 &&
> +	     (dec_params->bit_depth != 10 && dec_params->bit_depth != 12)))
> +		return -EINVAL;
> +
> +	/* Profile 0 and 2 only accept YUV 4:2:0. */
> +	if ((dec_params->profile == 0 || dec_params->profile == 2) &&
> +	    (!(dec_params->flags & V4L2_VP9_FRAME_FLAG_X_SUBSAMPLING) ||
> +	     !(dec_params->flags & V4L2_VP9_FRAME_FLAG_Y_SUBSAMPLING)))
> +		return -EINVAL;
> +
> +	/* Profile 1 and 3 only accept YUV 4:2:2, 4:4:0 and 4:4:4. */
> +	if ((dec_params->profile == 1 || dec_params->profile == 3) &&
> +	    ((dec_params->flags & V4L2_VP9_FRAME_FLAG_X_SUBSAMPLING) &&
> +	     (dec_params->flags & V4L2_VP9_FRAME_FLAG_Y_SUBSAMPLING)))
> +		return -EINVAL;
> +
> +	if (dec_params->interpolation_filter > V4L2_VP9_INTERP_FILTER_SWITCHABLE)
> +		return -EINVAL;
> +
> +	/*
> +	 * According to the spec, tile_cols_log2 shall be less than or equal
> +	 * to 6.
> +	 */
> +	if (dec_params->tile_cols_log2 > 6)
> +		return -EINVAL;
> +
> +	if (dec_params->tx_mode > V4L2_VP9_TX_MODE_SELECT)
> +		return -EINVAL;
> +
> +	if (dec_params->reference_mode > V4L2_VP9_REF_MODE_SELECT)
> +		return -EINVAL;
> +
> +	for (i = 0; i < V4L2_REF_ID_CNT + 1; ++i)
> +		if (dec_params->ref_frame_sign_bias[i] != 0 &&
> +		    dec_params->ref_frame_sign_bias[i] != 1)
> +			return -EINVAL;
> +
> +	ret = validate_vp9_lf_params(&dec_params->lf);
> +	if (ret)
> +		return ret;
> +
> +	ret = validate_vp9_quant_params(&dec_params->quant);
> +	if (ret)
> +		return ret;
> +
> +	ret = validate_vp9_seg_params(&dec_params->seg);
> +	if (ret)
> +		return ret;
> +
> +	memset(dec_params->padding, 0, sizeof(dec_params->padding));
> +	return 0;
> +}
> +
>  /* Validate a new control */
>  
>  #define zero_padding(s) \
> @@ -2127,6 +2359,12 @@ static int std_validate_compound(const struct v4l2_ctrl *ctrl, u32 idx,
>  		zero_padding(p_vp8_frame->coder_state);
>  		break;
>  
> +	case V4L2_CTRL_TYPE_VP9_FRAME_DECODE_PARAMS:
> +		return validate_vp9_frame_decode_params(p);
> +
> +	case V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR_PROBS:
> +		break;
> +
>  	case V4L2_CTRL_TYPE_HEVC_SPS:
>  		p_hevc_sps = p;
>  
> @@ -2938,6 +3176,12 @@ static struct v4l2_ctrl *v4l2_ctrl_new(struct v4l2_ctrl_handler *hdl,
>  	case V4L2_CTRL_TYPE_VP8_FRAME:
>  		elem_size = sizeof(struct v4l2_ctrl_vp8_frame);
>  		break;
> +	case V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR_PROBS:
> +		elem_size = sizeof(struct v4l2_ctrl_vp9_compressed_hdr_probs);
> +		break;
> +	case V4L2_CTRL_TYPE_VP9_FRAME_DECODE_PARAMS:
> +		elem_size = sizeof(struct v4l2_ctrl_vp9_frame_decode_params);
> +		break;
>  	case V4L2_CTRL_TYPE_HEVC_SPS:
>  		elem_size = sizeof(struct v4l2_ctrl_hevc_sps);
>  		break;
> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
> index 6a5d1c6d11d6..dbdafa5ea127 100644
> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> @@ -1431,6 +1431,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
>  		case V4L2_PIX_FMT_VP8:		descr = "VP8"; break;
>  		case V4L2_PIX_FMT_VP8_FRAME:    descr = "VP8 Frame"; break;
>  		case V4L2_PIX_FMT_VP9:		descr = "VP9"; break;
> +		case V4L2_PIX_FMT_VP9_FRAME:    descr = "VP9 Frame"; break;
>  		case V4L2_PIX_FMT_HEVC:		descr = "HEVC"; break; /* aka H.265 */
>  		case V4L2_PIX_FMT_HEVC_SLICE:	descr = "HEVC Parsed Slice Data"; break;
>  		case V4L2_PIX_FMT_FWHT:		descr = "FWHT"; break; /* used in vicodec */
> diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h
> index a5953b812878..8c5fb22ff545 100644
> --- a/include/media/v4l2-ctrls.h
> +++ b/include/media/v4l2-ctrls.h
> @@ -50,6 +50,8 @@ struct video_device;
>   * @p_h264_decode_params:	Pointer to a struct v4l2_ctrl_h264_decode_params.
>   * @p_h264_pred_weights:	Pointer to a struct v4l2_ctrl_h264_pred_weights.
>   * @p_vp8_frame:		Pointer to a VP8 frame params structure.
> + * @p_vp9_compressed_hdr_probs:	Pointer to a VP9 frame compressed header probs structure.
> + * @p_vp9_frame_decode_params:	Pointer to a VP9 frame params structure.

Why is this called p_vp9_frame_decode_params while for VP8 it is called
p_vp8_frame? The mismatch is odd. This comment is of course about the general
naming of this control, not just this field.

>   * @p_hevc_sps:			Pointer to an HEVC sequence parameter set structure.
>   * @p_hevc_pps:			Pointer to an HEVC picture parameter set structure.
>   * @p_hevc_slice_params:	Pointer to an HEVC slice parameters structure.
> @@ -79,6 +81,8 @@ union v4l2_ctrl_ptr {
>  	struct v4l2_ctrl_hevc_sps *p_hevc_sps;
>  	struct v4l2_ctrl_hevc_pps *p_hevc_pps;
>  	struct v4l2_ctrl_hevc_slice_params *p_hevc_slice_params;
> +	struct v4l2_ctrl_vp9_compressed_hdr_probs *p_vp9_compressed_hdr_probs;
> +	struct v4l2_ctrl_vp9_frame_decode_params *p_vp9_frame_decode_params;
>  	struct v4l2_ctrl_hdr10_cll_info *p_hdr10_cll;
>  	struct v4l2_ctrl_hdr10_mastering_display *p_hdr10_mastering;
>  	struct v4l2_area *p_area;
> diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h
> index d43bec5f1afd..ff5c574f2755 100644
> --- a/include/uapi/linux/v4l2-controls.h
> +++ b/include/uapi/linux/v4l2-controls.h
> @@ -1896,6 +1896,461 @@ struct v4l2_ctrl_hdr10_mastering_display {
>  	__u32 min_display_mastering_luminance;
>  };
>  
> +/* Stateless VP9 control */

control -> controls

> +
> +/**
> + * enum v4l2_vp9_loop_filter_flags - VP9 loop filter flags
> + *
> + * @V4L2_VP9_LOOP_FILTER_FLAG_DELTA_ENABLED: the filter level depends on
> + *					     the mode and reference frame used
> + *					     to predict a block
> + * @V4L2_VP9_LOOP_FILTER_FLAG_DELTA_UPDATE: the bitstream contains additional
> + *					    syntax elements that specify which
> + *					    mode and reference frame deltas
> + *					    are to be updated
> + *
> + * Those are the flags you should pass to &v4l2_vp9_loop_filter.flags. See
> + * section '7.2.8 Loop filter semantics' of the VP9 specification for more
> + * details.
> + */
> +enum v4l2_vp9_loop_filter_flags {
> +	V4L2_VP9_LOOP_FILTER_FLAG_DELTA_ENABLED = 1 << 0,
> +	V4L2_VP9_LOOP_FILTER_FLAG_DELTA_UPDATE = 1 << 1,
> +};
> +
> +/**
> + * struct v4l2_vp9_loop_filter - VP9 loop filter parameters
> + *
> + * @flags: combination of V4L2_VP9_LOOP_FILTER_FLAG_* flags
> + * @level: indicates the loop filter strength
> + * @sharpness: indicates the sharpness level
> + * @ref_deltas: contains the adjustment needed for the filter level based on
> + *		the chosen reference frame
> + * @mode_deltas: contains the adjustment needed for the filter level based on
> + *		 the chosen mode
> + * @level_lookup: level lookup table
> + *
> + * This structure contains all loop filter related parameters. See sections
> + * '7.2.8 Loop filter semantics' and '8.8.1 Loop filter frame init process'
> + * of the VP9 specification for more details.
> + */
> +struct v4l2_vp9_loop_filter {
> +	__u8 flags;
> +	__u8 level;
> +	__u8 sharpness;
> +	__s8 ref_deltas[4];
> +	__s8 mode_deltas[2];
> +	__u8 level_lookup[8][4][2];
> +	__u8 padding;
> +};
> +
> +/**
> + * struct v4l2_vp9_quantization - VP9 quantization parameters
> + *
> + * @base_q_idx: indicates the base frame qindex
> + * @delta_q_y_dc: indicates the Y DC quantizer relative to base_q_idx
> + * @delta_q_uv_dc: indicates the UV DC quantizer relative to base_q_idx
> + * @delta_q_uv_ac indicates the UV AC quantizer relative to base_q_idx
> + * @padding: padding bytes to align things on 64 bits. Must be set to 0
> + *
> + * Encodes the quantization parameters. See section '7.2.9 Quantization params
> + * syntax' of the VP9 specification for more details.
> + */
> +struct v4l2_vp9_quantization {
> +	__u8 base_q_idx;
> +	__s8 delta_q_y_dc;
> +	__s8 delta_q_uv_dc;
> +	__s8 delta_q_uv_ac;
> +	__u8 padding[4];
> +};
> +
> +/**
> + * enum v4l2_vp9_segmentation_flags - VP9 segmentation flags
> + *
> + * @V4L2_VP9_SEGMENTATION_FLAG_ENABLED: indicates that this frame makes use of
> + *					the segmentation tool

Don't indent so far to the right. In case like this you just add a single TAB
after the *. Same elsewhere.

> + * @V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP: indicates that the segmentation map
> + *					   should be updated during the
> + *					   decoding of this frame
> + * @V4L2_VP9_SEGMENTATION_FLAG_TEMPORAL_UPDATE: indicates that the updates to
> + *						the segmentation map are coded
> + *						relative to the existing
> + *						segmentation map
> + * @V4L2_VP9_SEGMENTATION_FLAG_UPDATE_DATA: indicates that new parameters are
> + *					    about to be specified for each
> + *					    segment
> + * @V4L2_VP9_SEGMENTATION_FLAG_ABS_OR_DELTA_UPDATE: indicates that the
> + *						    segmentation parameters
> + *						    represent the actual values
> + *						    to be used
> + *
> + * Those are the flags you should pass to &v4l2_vp9_segmentation.flags. See
> + * section '7.2.10 Segmentation params syntax' of the VP9 specification for
> + * more details.
> + */
> +enum v4l2_vp9_segmentation_flags {
> +	V4L2_VP9_SEGMENTATION_FLAG_ENABLED = 1 << 0,
> +	V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP = 1 << 1,
> +	V4L2_VP9_SEGMENTATION_FLAG_TEMPORAL_UPDATE = 1 << 2,
> +	V4L2_VP9_SEGMENTATION_FLAG_UPDATE_DATA = 1 << 3,
> +	V4L2_VP9_SEGMENTATION_FLAG_ABS_OR_DELTA_UPDATE = 1 << 4,
> +};
> +
> +#define V4L2_VP9_SEGMENT_FEATURE_ENABLED(id)	(1 << (id))
> +#define V4L2_VP9_SEGMENT_FEATURE_ENABLED_MASK	0xf
> +
> +/**
> + * enum v4l2_vp9_segment_feature - VP9 segment feature IDs
> + *
> + * @V4L2_VP9_SEGMENT_FEATURE_QP_DELTA: QP delta segment feature
> + * @V4L2_VP9_SEGMENT_FEATURE_LF: loop filter segment feature
> + * @V4L2_VP9_SEGMENT_FEATURE_REF_FRAME: reference frame segment feature
> + * @V4L2_VP9_SEGMENT_FEATURE_SKIP: skip segment feature
> + * @V4L2_VP9_SEGMENT_FEATURE_CNT: number of segment features
> + *
> + * Segment feature IDs. See section '7.2.10 Segmentation params syntax' of the
> + * VP9 specification for more details.
> + */
> +enum v4l2_vp9_segment_feature {
> +	V4L2_VP9_SEGMENT_FEATURE_QP_DELTA,
> +	V4L2_VP9_SEGMENT_FEATURE_LF,
> +	V4L2_VP9_SEGMENT_FEATURE_REF_FRAME,
> +	V4L2_VP9_SEGMENT_FEATURE_SKIP,
> +	V4L2_VP9_SEGMENT_FEATURE_CNT,
> +};
> +
> +/**
> + * struct v4l2_vp9_segmentation - VP9 segmentation parameters
> + *
> + * @flags: combination of V4L2_VP9_SEGMENTATION_FLAG_* flags
> + * @tree_probs: specifies the probability values to be used when
> + *              decoding a Segment-ID. See '5.15. Segmentation map'
> + *              section of the VP9 specification for more details.
> + * @pred_prob: specifies the probability values to be used when decoding a
> + *	       Predicted-Segment-ID. See '6.4.14. Get segment id syntax'
> + *	       section of :ref:`vp9` for more details..
> + * @padding: padding used to make things aligned on 64 bits. Shall be zero
> + *	     filled
> + * @feature_enabled: bitmask defining which features are enabled in each
> + *		     segment
> + * @feature_data: data attached to each feature. Data entry is only valid if
> + *		  the feature is enabled
> + *
> + * Encodes the quantization parameters. See section '7.2.10 Segmentation
> + * params syntax' of the VP9 specification for more details.
> + */
> +struct v4l2_vp9_segmentation {
> +	__u8 flags;
> +	__u8 tree_probs[7];
> +	__u8 pred_probs[3];
> +	__u8 padding[5];
> +	__u8 feature_enabled[8];
> +	__s16 feature_data[8][4];
> +};
> +
> +/**
> + * enum v4l2_vp9_intra_prediction_mode - VP9 Intra prediction modes
> + *
> + * @V4L2_VP9_INTRA_PRED_DC: DC intra prediction
> + * @V4L2_VP9_INTRA_PRED_MODE_V: vertical intra prediction
> + * @V4L2_VP9_INTRA_PRED_MODE_H: horizontal intra prediction
> + * @V4L2_VP9_INTRA_PRED_MODE_D45: D45 intra prediction
> + * @V4L2_VP9_INTRA_PRED_MODE_D135: D135 intra prediction
> + * @V4L2_VP9_INTRA_PRED_MODE_D117: D117 intra prediction
> + * @V4L2_VP9_INTRA_PRED_MODE_D153: D153 intra prediction
> + * @V4L2_VP9_INTRA_PRED_MODE_D207: D207 intra prediction
> + * @V4L2_VP9_INTRA_PRED_MODE_D63: D63 intra prediction
> + * @V4L2_VP9_INTRA_PRED_MODE_TM: True Motion intra prediction
> + *
> + * See section '7.4.5 Intra frame mode info semantics' for more details.
> + */
> +enum v4l2_vp9_intra_prediction_mode {
> +	V4L2_VP9_INTRA_PRED_MODE_DC,
> +	V4L2_VP9_INTRA_PRED_MODE_V,
> +	V4L2_VP9_INTRA_PRED_MODE_H,
> +	V4L2_VP9_INTRA_PRED_MODE_D45,
> +	V4L2_VP9_INTRA_PRED_MODE_D135,
> +	V4L2_VP9_INTRA_PRED_MODE_D117,
> +	V4L2_VP9_INTRA_PRED_MODE_D153,
> +	V4L2_VP9_INTRA_PRED_MODE_D207,
> +	V4L2_VP9_INTRA_PRED_MODE_D63,
> +	V4L2_VP9_INTRA_PRED_MODE_TM,
> +};
> +
> +/**
> + * enum v4l2_vp9_reset_frame_context - Valid values for
> + *			&v4l2_ctrl_vp9_frame_decode_params->reset_frame_context
> + *
> + * @V4L2_VP9_RESET_FRAME_CTX_NONE: don't reset any frame context
> + * @V4L2_VP9_RESET_FRAME_CTX_SPEC: reset the frame context pointed by
> + *			&v4l2_ctrl_vp9_frame_decode_params.frame_context_idx
> + * @V4L2_VP9_RESET_FRAME_CTX_ALL: reset all frame contexts
> + *
> + * See section '7.2 Uncompressed header semantics' of the VP9 specification
> + * for more details.
> + */
> +enum v4l2_vp9_reset_frame_context {
> +	V4L2_VP9_RESET_FRAME_CTX_NONE,
> +	V4L2_VP9_RESET_FRAME_CTX_SPEC,
> +	V4L2_VP9_RESET_FRAME_CTX_ALL,
> +};
> +
> +/**
> + * enum v4l2_vp9_interpolation_filter - VP9 interpolation filter types
> + *
> + * @V4L2_VP9_INTERP_FILTER_8TAP: height tap filter
> + * @V4L2_VP9_INTERP_FILTER_8TAP_SMOOTH: height tap smooth filter
> + * @V4L2_VP9_INTERP_FILTER_8TAP_SHARP: height tap sharp filter
> + * @V4L2_VP9_INTERP_FILTER_BILINEAR: bilinear filter
> + * @V4L2_VP9_INTERP_FILTER_SWITCHABLE: filter selection is signaled at the
> + *				       block level
> + *
> + * See section '7.2.7 Interpolation filter semantics' of the VP9 specification
> + * for more details.
> + */
> +enum v4l2_vp9_interpolation_filter {
> +	V4L2_VP9_INTERP_FILTER_8TAP,
> +	V4L2_VP9_INTERP_FILTER_8TAP_SMOOTH,
> +	V4L2_VP9_INTERP_FILTER_8TAP_SHARP,
> +	V4L2_VP9_INTERP_FILTER_BILINEAR,
> +	V4L2_VP9_INTERP_FILTER_SWITCHABLE,
> +};
> +
> +/**
> + * enum v4l2_vp9_reference_mode - VP9 reference modes
> + *
> + * @V4L2_VP9_REF_MODE_SINGLE: indicates that all the inter blocks use only a
> + *			      single reference frame to generate motion
> + *			      compensated prediction
> + * @V4L2_VP9_REF_MODE_COMPOUND: requires all the inter blocks to use compound
> + *				mode. Single reference frame prediction is not
> + *				allowed
> + * @V4L2_VP9_REF_MODE_SELECT: allows each individual inter block to select
> + *			      between single and compound prediction modes
> + *
> + * See section '7.3.6 Frame reference mode semantics' of the VP9 specification
> + * for more details.
> + */
> +enum v4l2_vp9_reference_mode {
> +	V4L2_VP9_REF_MODE_SINGLE,
> +	V4L2_VP9_REF_MODE_COMPOUND,
> +	V4L2_VP9_REF_MODE_SELECT,
> +};
> +
> +/**
> + * enum v4l2_vp9_tx_mode - VP9 TX modes
> + *
> + * @V4L2_VP9_TX_MODE_ONLY_4X4: transform size is 4x4
> + * @V4L2_VP9_TX_MODE_ALLOW_8X8: transform size can be up to 8x8
> + * @V4L2_VP9_TX_MODE_ALLOW_16X16: transform size can be up to 16x16
> + * @V4L2_VP9_TX_MODE_ALLOW_32X32: transform size can be up to 32x32
> + * @V4L2_VP9_TX_MODE_SELECT: bitstream contains transform size for each block
> + *
> + * See section '7.3.1 Tx mode semantics' of the VP9 specification for more
> + * details.
> + */
> +enum v4l2_vp9_tx_mode {
> +	V4L2_VP9_TX_MODE_ONLY_4X4,
> +	V4L2_VP9_TX_MODE_ALLOW_8X8,
> +	V4L2_VP9_TX_MODE_ALLOW_16X16,
> +	V4L2_VP9_TX_MODE_ALLOW_32X32,
> +	V4L2_VP9_TX_MODE_SELECT,
> +};
> +
> +/**
> + * enum v4l2_vp9_ref_id - VP9 Reference frame IDs
> + *
> + * @V4L2_REF_ID_LAST: last reference frame
> + * @V4L2_REF_ID_GOLDEN: golden reference frame
> + * @V4L2_REF_ID_ALTREF: alternative reference frame
> + * @V4L2_REF_ID_CNT: number of reference frames
> + *
> + * See section '7.4.12 Ref frames semantics' of the VP9 specification for more
> + * details.
> + */
> +enum v4l2_vp9_ref_id {
> +	V4L2_REF_ID_LAST,
> +	V4L2_REF_ID_GOLDEN,
> +	V4L2_REF_ID_ALTREF,
> +	V4L2_REF_ID_CNT,
> +};
> +
> +/**
> + * enum v4l2_vp9_frame_flags - VP9 frame flags
> + * @V4L2_VP9_FRAME_FLAG_KEY_FRAME: the frame is a key frame
> + * @V4L2_VP9_FRAME_FLAG_SHOW_FRAME: the frame should be displayed
> + * @V4L2_VP9_FRAME_FLAG_ERROR_RESILIENT: the decoding should be error resilient
> + * @V4L2_VP9_FRAME_FLAG_INTRA_ONLY: the frame does not reference other frames
> + * @V4L2_VP9_FRAME_FLAG_ALLOW_HIGH_PREC_MV: the frame might can high precision
> + *					    motion vectors
> + * @V4L2_VP9_FRAME_FLAG_REFRESH_FRAME_CTX: frame context should be updated
> + *					   after decoding
> + * @V4L2_VP9_FRAME_FLAG_PARALLEL_DEC_MODE: parallel decoding is used
> + * @V4L2_VP9_FRAME_FLAG_X_SUBSAMPLING: vertical subsampling is enabled
> + * @V4L2_VP9_FRAME_FLAG_Y_SUBSAMPLING: horizontal subsampling is enabled
> + * @V4L2_VP9_FRAME_FLAG_COLOR_RANGE_FULL_SWING: full UV range is used
> + *
> + * Check the VP9 specification for more details.
> + */
> +enum v4l2_vp9_frame_flags {
> +	V4L2_VP9_FRAME_FLAG_KEY_FRAME = 1 << 0,
> +	V4L2_VP9_FRAME_FLAG_SHOW_FRAME = 1 << 1,
> +	V4L2_VP9_FRAME_FLAG_ERROR_RESILIENT = 1 << 2,
> +	V4L2_VP9_FRAME_FLAG_INTRA_ONLY = 1 << 3,
> +	V4L2_VP9_FRAME_FLAG_ALLOW_HIGH_PREC_MV = 1 << 4,
> +	V4L2_VP9_FRAME_FLAG_REFRESH_FRAME_CTX = 1 << 5,
> +	V4L2_VP9_FRAME_FLAG_PARALLEL_DEC_MODE = 1 << 6,
> +	V4L2_VP9_FRAME_FLAG_X_SUBSAMPLING = 1 << 7,
> +	V4L2_VP9_FRAME_FLAG_Y_SUBSAMPLING = 1 << 8,
> +	V4L2_VP9_FRAME_FLAG_COLOR_RANGE_FULL_SWING = 1 << 9,
> +};
> +
> +#define V4L2_VP9_PROFILE_MAX		3
> +
> +#define V4L2_CID_STATELESS_VP9_FRAME_DECODE_PARAMS	(V4L2_CID_CODEC_STATELESS_BASE + 300)
> +/**
> + * struct v4l2_ctrl_vp9_frame_decode_params - VP9 frame decoding control
> + *
> + * @flags: combination of V4L2_VP9_FRAME_FLAG_* flags
> + * @compressed_header_size: compressed header size in bytes
> + * @uncompressed_header_size: uncompressed header size in bytes
> + * @profile: VP9 profile. Can be 0, 1, 2 or 3
> + * @reset_frame_context: specifies whether the frame context should be reset
> + *			 to default values. See &v4l2_vp9_reset_frame_context
> + *			 for more details
> + * @frame_context_idx: frame context that should be used/updated
> + * @bit_depth: bits per components. Can be 8, 10 or 12. Note that not all
> + *	       profiles support 10 and/or 12 bits depths
> + * @interpolation_filter: specifies the filter selection used for performing
> + *			  inter prediction. See &v4l2_vp9_interpolation_filter
> + *			  for more details
> + * @tile_cols_log2: specifies the base 2 logarithm of the width of each tile
> + *		    (where the width is measured in units of 8x8 blocks).
> + *		    Shall be less than or equal to 6
> + * @tile_rows_log2: specifies the base 2 logarithm of the height of each tile
> + *		    (where the height is measured in units of 8x8 blocks)
> + * @tx_mode: specifies the TX mode. See &v4l2_vp9_tx_mode for more details
> + * @reference_mode: specifies the type of inter prediction to be used. See
> + *		    &v4l2_vp9_reference_mode for more details
> + * @padding: needed to make this struct 64 bit aligned. Shall be filled with
> + *	     zeros
> + * @frame_width_minus_1: add 1 to it and you'll get the frame width expressed
> + *			 in pixels
> + * @frame_height_minus_1: add 1 to it and you'll get the frame height expressed
> + *			  in pixels
> + * @render_width_minus_1: add 1 to it and you'll get the expected render width
> + *			 expressed in pixels. This is not used during the
> + *			 decoding process but might be used by HW scalers to
> + *			 prepare a frame that's ready for scanout
> + * @render_height_minus_1: add 1 to it and you'll get the expected render height
> + *			 expressed in pixels. This is not used during the
> + *			 decoding process but might be used by HW scalers to
> + *			 prepare a frame that's ready for scanout
> + * @refs: array of ref frames timestamps. See &v4l2_vp9_ref_id for more details
> + * @ref_frame_sign_bias: array of reference frames motion vector sign bias
> + *			(prediction direction)
> + * @lf: loop filter parameters. See &v4l2_vp9_loop_filter for more details
> + * @quant: quantization parameters. See &v4l2_vp9_quantization for more details
> + * @seg: segmentation parameters. See &v4l2_vp9_segmentation for more details
> + */
> +struct v4l2_ctrl_vp9_frame_decode_params {
> +	__u32 flags;
> +	__u16 compressed_header_size;
> +	__u16 uncompressed_header_size;
> +	__u8 profile;
> +	__u8 reset_frame_context;
> +	__u8 frame_context_idx;
> +	__u8 bit_depth;
> +	__u8 interpolation_filter;
> +	__u8 tile_cols_log2;
> +	__u8 tile_rows_log2;
> +	__u8 tx_mode;
> +	__u8 reference_mode;
> +	__u8 padding[7];
> +	__u16 frame_width_minus_1;
> +	__u16 frame_height_minus_1;
> +	__u16 render_width_minus_1;
> +	__u16 render_height_minus_1;
> +	__u64 refs[V4L2_REF_ID_CNT];
> +	__u8 ref_frame_sign_bias[V4L2_REF_ID_CNT + 1];
> +	struct v4l2_vp9_loop_filter lf;
> +	struct v4l2_vp9_quantization quant;
> +	struct v4l2_vp9_segmentation seg;
> +};
> +
> +#define V4L2_VP9_NUM_FRAME_CTX	4
> +
> +/**
> + * struct v4l2_vp9_mv_compressed_hdr_probs - VP9 Motion vector probability updates
> + * @joint: motion vector joint probability updates
> + * @sign: motion vector sign probability updates
> + * @class: motion vector class probability updates
> + * @class0_bit: motion vector class0 bit probability updates
> + * @bits: motion vector bits probability updates
> + * @class0_fr: motion vector class0 fractional bit probability updates
> + * @fr: motion vector fractional bit probability updates
> + * @class0_hp: motion vector class0 high precision fractional bit probability updates
> + * @hp: motion vector high precision fractional bit probability updates
> + *
> + * This structure contains new values of motion vector probabilities.
> + * A value of zero means there is no update.

'A value of zero': do you mean that the whole struct is zeroed, or just specific
arrays or single bytes? It's not clear to me at what level this is done.

> + * See `struct v4l2_vp9_prob_updates` for details.
> + */
> +struct v4l2_vp9_mv_compressed_hdr_probs {
> +	__u8 joint[3];
> +	__u8 sign[2];
> +	__u8 class[2][10];
> +	__u8 class0_bit[2];
> +	__u8 bits[2][10];
> +	__u8 class0_fr[2][2][3];
> +	__u8 fr[2][3];
> +	__u8 class0_hp[2];
> +	__u8 hp[2];
> +};
> +
> +#define V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS	(V4L2_CID_CODEC_STATELESS_BASE + 301)
> +/**
> + * struct v4l2_ctrl_vp9_compressed_hdr_probs - VP9 probability updates control
> + * @tx8: TX 8x8 probability updates
> + * @tx16: TX 16x16 probability updates
> + * @tx32: TX 32x32 probability updates
> + * @coef: coefficient probability updates
> + * @skip: skip probability updates
> + * @inter_mode: inter mode probability updates
> + * @interp_filter: interpolation filter probability updates
> + * @is_inter: is inter-block probability updates
> + * @comp_mode: compound prediction mode probability updates
> + * @single_ref: single ref probability updates
> + * @comp_ref: compound ref probability updates
> + * @y_mode: Y prediction mode probability updates
> + * @uv_mode: UV prediction mode probability updates
> + * @partition: partition probability updates
> + * @mv: motion vector probability updates
> + *
> + * This structure holds the probabilities update as parsed in the compressed
> + * header (Spec 6.3). These values represent the value of probability update after
> + * being translated with inv_map_table[] (see 6.3.5). A value of zero means that
> + * there is no update.

Same question.

> + */
> +struct v4l2_ctrl_vp9_compressed_hdr_probs {
> +	__u8 tx8[2][1];
> +	__u8 tx16[2][2];
> +	__u8 tx32[2][3];
> +	__u8 coef[4][2][2][6][6][3];
> +	__u8 skip[3];
> +	__u8 inter_mode[7][3];
> +	__u8 interp_filter[4][2];
> +	__u8 is_inter[4];
> +	__u8 comp_mode[5];
> +	__u8 single_ref[5][2];
> +	__u8 comp_ref[5];
> +	__u8 y_mode[4][9];
> +	__u8 uv_mode[10][9];
> +	__u8 partition[16][3];
> +
> +	struct v4l2_vp9_mv_compressed_hdr_probs mv;
> +};
> +
>  /* MPEG-compression definitions kept for backwards compatibility */
>  #ifndef __KERNEL__
>  #define V4L2_CTRL_CLASS_MPEG            V4L2_CTRL_CLASS_CODEC
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index 311a01cc5775..508e2d6825b1 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -697,6 +697,7 @@ struct v4l2_pix_format {
>  #define V4L2_PIX_FMT_VP8      v4l2_fourcc('V', 'P', '8', '0') /* VP8 */
>  #define V4L2_PIX_FMT_VP8_FRAME v4l2_fourcc('V', 'P', '8', 'F') /* VP8 parsed frame */
>  #define V4L2_PIX_FMT_VP9      v4l2_fourcc('V', 'P', '9', '0') /* VP9 */
> +#define V4L2_PIX_FMT_VP9_FRAME v4l2_fourcc('V', 'P', '9', 'F') /* VP9 parsed frame */
>  #define V4L2_PIX_FMT_HEVC     v4l2_fourcc('H', 'E', 'V', 'C') /* HEVC aka H.265 */
>  #define V4L2_PIX_FMT_FWHT     v4l2_fourcc('F', 'W', 'H', 'T') /* Fast Walsh Hadamard Transform (vicodec) */
>  #define V4L2_PIX_FMT_FWHT_STATELESS     v4l2_fourcc('S', 'F', 'W', 'H') /* Stateless FWHT (vicodec) */
> @@ -1747,6 +1748,8 @@ struct v4l2_ext_control {
>  		struct v4l2_ctrl_h264_decode_params __user *p_h264_decode_params;
>  		struct v4l2_ctrl_fwht_params __user *p_fwht_params;
>  		struct v4l2_ctrl_vp8_frame __user *p_vp8_frame;
> +		struct v4l2_ctrl_vp9_compressed_hdr_probs __user *p_vp9_compressed_hdr_probs;
> +		struct v4l2_ctrl_vp9_frame_decode_params __user *p_vp9_frame_decode_params;
>  		void __user *ptr;
>  	};
>  } __attribute__ ((packed));
> @@ -1807,6 +1810,9 @@ enum v4l2_ctrl_type {
>  	V4L2_CTRL_TYPE_FWHT_PARAMS	    = 0x0220,
>  
>  	V4L2_CTRL_TYPE_VP8_FRAME            = 0x0240,
> +
> +	V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR_PROBS	= 0x0260,
> +	V4L2_CTRL_TYPE_VP9_FRAME_DECODE_PARAMS	= 0x0261,
>  };
>  
>  /*  Used in the VIDIOC_QUERYCTRL ioctl for querying controls */
> 

Regards,

	Hans

Re: [RFC RESEND 2/3] media: uapi: Add VP9 stateless decoder controls

[Andrzej Pietrasiewicz]

Hi Hans,

Thank you for the review. I'm working on a v2 to address your comments.
Also please see inline.

Andrzej

W dniu 29.04.2021 o 12:20, Hans Verkuil pisze:
> On 21/04/2021 12:00, Andrzej Pietrasiewicz wrote:
>> Add the VP9 stateless decoder controls plus the documentation that goes
>> with it.
>>
>> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
>> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
>> Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
>> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
>> ---
>>   .../userspace-api/media/v4l/biblio.rst        |  10 +
>>   .../media/v4l/ext-ctrls-codec-stateless.rst   | 523 ++++++++++++++++++
>>   .../media/v4l/pixfmt-compressed.rst           |  15 +
>>   .../media/v4l/vidioc-g-ext-ctrls.rst          |   8 +
>>   .../media/v4l/vidioc-queryctrl.rst            |  12 +
>>   .../media/videodev2.h.rst.exceptions          |   2 +
>>   drivers/media/v4l2-core/v4l2-ctrls.c          | 244 ++++++++
>>   drivers/media/v4l2-core/v4l2-ioctl.c          |   1 +
>>   include/media/v4l2-ctrls.h                    |   4 +
>>   include/uapi/linux/v4l2-controls.h            | 455 +++++++++++++++
>>   include/uapi/linux/videodev2.h                |   6 +
>>   11 files changed, 1280 insertions(+)
>>
>> diff --git a/Documentation/userspace-api/media/v4l/biblio.rst b/Documentation/userspace-api/media/v4l/biblio.rst
>> index 64d241daf63c..051982896375 100644
>> --- a/Documentation/userspace-api/media/v4l/biblio.rst
>> +++ b/Documentation/userspace-api/media/v4l/biblio.rst
>> @@ -417,3 +417,13 @@ VP8
>>   :title:     RFC 6386: "VP8 Data Format and Decoding Guide"
>>   
>>   :author:    J. Bankoski et al.
>> +
>> +.. _vp9:
>> +
>> +VP9
>> +===
>> +
>> +
>> +:title:     VP9 Bitstream & Decoding Process Specification
>> +
>> +:author:    Adrian Grange (Google), Peter de Rivaz (Argon Design), Jonathan Hunt (Argon Design)
>> diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-codec-stateless.rst b/Documentation/userspace-api/media/v4l/ext-ctrls-codec-stateless.rst
>> index 3fc04daa9ffb..ab40c878c8ad 100644
>> --- a/Documentation/userspace-api/media/v4l/ext-ctrls-codec-stateless.rst
>> +++ b/Documentation/userspace-api/media/v4l/ext-ctrls-codec-stateless.rst
>> @@ -1244,3 +1244,526 @@ FWHT Flags
>>       * - __u8
>>         - ``padding[3]``
>>         - Applications and drivers must set this to zero.
>> +
>> +.. _v4l2-codec-stateless-vp9:
>> +
>> +``V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS (struct)``
>> +    Stores VP9 probabilities updates as parsed from the current compressed frame
>> +    header. A value of zero in a struct member means no update of the relevant
>> +    probability. Motion vector-related updates contain a new value or zero. All
>> +    other updates contain values translated with inv_map_table[] (see 6.3.5 in
>> +    :ref:`vp9`).
>> +
>> +.. c:type:: v4l2_ctrl_vp9_compressed_hdr_probs
>> +
>> +.. cssclass:: longtable
>> +
>> +.. tabularcolumns:: |p{5.8cm}|p{4.8cm}|p{6.6cm}|
>> +
>> +.. flat-table:: struct v4l2_ctrl_vp9_compressed_hdr_probs
>> +    :header-rows:  0
>> +    :stub-columns: 0
>> +    :widths:       1 1 2
>> +
>> +    * - __u8
>> +      - ``tx8[2][1]``
>> +      - TX 8x8 probabilities delta.
>> +    * - __u8
>> +      - ``tx16[2][2]``
>> +      - TX 16x16 probabilities delta.
>> +    * - __u8
>> +      - ``tx32[2][3]``
>> +      - TX 32x32 probabilities delta.
>> +    * - __u8
>> +      - ``coef[4][2][2][6][6][3]``
>> +      - Coefficient probabilities delta.
>> +    * - __u8
>> +      - ``skip[3]``
>> +      - Skip probabilities delta.
>> +    * - __u8
>> +      - ``inter_mode[7][3]``
>> +      - Inter prediction mode probabilities delta.
>> +    * - __u8
>> +      - ``interp_filter[4][2]``
>> +      - Interpolation filter probabilities delta.
>> +    * - __u8
>> +      - ``is_inter[4]``
>> +      - Is inter-block probabilities delta.
>> +    * - __u8
>> +      - ``comp_mode[5]``
>> +      - Compound prediction mode probabilities delta.
>> +    * - __u8
>> +      - ``single_ref[5][2]``
>> +      - Single reference probabilities delta.
>> +    * - __u8
>> +      - ``comp_mode[5]``
>> +      - Compound reference probabilities delta.
>> +    * - __u8
>> +      - ``y_mode[4][9]``
>> +      - Y prediction mode probabilities delta.
>> +    * - __u8
>> +      - ``uv_mode[10][9]``
>> +      - UV prediction mode probabilities delta.
>> +    * - __u8
>> +      - ``partition[16][3]``
>> +      - Partition probabilities delta.
>> +    * - __u8
>> +      - ``partition[16][3]``
>> +      - Partition probabilities delta.
>> +    * - __u8
>> +      - ``mv.joint[3]``
>> +      - Motion vector joint probabilities delta.
>> +    * - __u8
>> +      - ``mv.sign[2]``
>> +      - Motion vector sign probabilities delta.
>> +    * - __u8
>> +      - ``mv.class[2][10]``
>> +      - Motion vector class probabilities delta.
>> +    * - __u8
>> +      - ``mv.class0_bit[2]``
>> +      - Motion vector class0 bit probabilities delta.
>> +    * - __u8
>> +      - ``mv.bits[2][10]``
>> +      - Motion vector bits probabilities delta.
>> +    * - __u8
>> +      - ``mv.class0_fr[2][2][3]``
>> +      - Motion vector class0 fractional bit probabilities delta.
>> +    * - __u8
>> +      - ``mv.fr[2][3]``
>> +      - Motion vector fractional bit probabilities delta.
>> +    * - __u8
>> +      - ``mv.class0_hp[2]``
>> +      - Motion vector class0 high precision fractional bit probabilities delta.
>> +    * - __u8
>> +      - ``mv.hp[2]``
>> +      - Motion vector high precision fractional bit probabilities delta.
>> +
>> +``V4L2_CID_STATELESS_VP9_FRAME_DECODE_PARAMS (struct)``
>> +    Specifies the frame parameters for the associated VP9 frame decode request.
>> +    This includes the necessary parameters for configuring a stateless hardware
>> +    decoding pipeline for VP9. The bitstream parameters are defined according
>> +    to :ref:`vp9`.
> 
> Are there specific sections in the spec that define these parameters? Or is it
> all over the place? If it's the latter, would it be possible to add a reference
> to the respective sections in the field documentation below?
> 
> Update: I noticed a lot of references to the spec in v4l2-controls.h. If those
> references would answer this question, then you can refer to that header from
> here. Or just copy those section references into this documentation.
> 
>> +
>> +    .. note::
>> +
>> +       This compound control is not yet part of the public kernel API and
>> +       it is expected to change.
> 
> Since this patch series add this to uAPI right away, this note must be dropped.
> 
>> +
>> +.. c:type:: v4l2_ctrl_vp9_frame_decode_params
>> +
>> +.. cssclass:: longtable
>> +
>> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
>> +
>> +.. flat-table:: struct v4l2_ctrl_vp9_frame_decode_params
>> +    :header-rows:  0
>> +    :stub-columns: 0
>> +    :widths:       1 1 2
>> +
>> +    * - __u32
>> +      - ``flags``
>> +      - Combination of V4L2_VP9_FRAME_FLAG_* flags. See
>> +        :c:type:`v4l2_vp9_frame_flags`.
>> +    * - __u16
>> +      - ``compressed_header_size``
>> +      - Compressed header size in bytes.
>> +    * - __u16
>> +      - ``uncompressed_header_size``
>> +      - Uncompressed header size in bytes.
>> +    * - __u8
>> +      - ``profile``
>> +      - VP9 profile. Can be 0, 1, 2 or 3.
>> +    * - __u8
>> +      - ``reset_frame_context``
>> +      - Frame context that should be used/updated when decoding the frame.
>> +    * - __u8
>> +      - ``bit_depth``
>> +      - Component depth in bits. Must be 8 for profile 0 and 1. Must 10 or 12
>> +        for profile 2 and 3.
>> +    * - __u8
>> +      - ``interpolation_filter``
>> +      - Specifies the filter selection used for performing inter prediction. See
>> +        :c:type:`v4l2_vp9_interpolation_filter`.
>> +    * - __u8
>> +      - ``tile_cols_log2``
>> +      - Specifies the base 2 logarithm of the width of each tile (where the
>> +        width is measured in units of 8x8 blocks). Shall be less than or equal
>> +        to 6.
>> +    * - __u8
>> +      - ``tile_rows_log2``
>> +      - Specifies the base 2 logarithm of the height of each tile (where the
>> +        height is measured in units of 8x8 blocks)
> 
> Missing period at the end of the sentence.
> 
>> +    * - __u8
>> +      - ``tx_mode``
>> +      - Specifies the TX mode. See :c:type:`v4l2_vp9_tx_mode`.
>> +    * - __u8
>> +      - ``reference_mode``
>> +      - Specifies the type of inter prediction to be used. See
>> +        :c:type:`v4l2_vp9_reference_mode`.
>> +    * - __u8
>> +      - ``padding[7]``
>> +      - Needed to make this struct 64 bit aligned. Shall be filled with zeroes.
>> +    * - __u16
>> +      - ``frame_width_minus_1``
>> +      - Add 1 to get the frame width expressed in pixels.
>> +    * - __u16
>> +      - ``frame_height_minus_1``
>> +      - Add 1 to get the frame height expressed in pixels.
> 
> These two fields are weird. Isn't this defined by setting the output format?
> And why the 'minus_1'?
> 

These are values from the frame header, including the naming. The frame header
is parsed in software (by the CPU) and this data must be passed to the hardware.

>> +    * - __u16
>> +      - ``render_width_minus_1``
>> +      - Add 1 to get the expected render width expressed in pixels. This is
>> +        not used during the decoding process but might be used by HW scalers to
>> +        prepare a frame that's ready for scanout.
>> +    * - __u16
>> +      - render_height_minus_1
>> +      - Add 1 to get the expected render height expressed in pixels. This is
>> +        not used during the decoding process but might be used by HW scalers to
>> +        prepare a frame that's ready for scanout.
> 
> No idea what these fields are about. I suspect this can be defined by setting
> the capture format, but I'm not sure.

Ditto.

> 
>> +    * - __u64
>> +      - ``refs[3]``
>> +      - Array of reference frame timestamps.
>> +    * - __u8
>> +      - ``ref_frame_sign_bias[4]``
>> +      - Array of reference frames motion vector sign bias (prediction direction)
> 
> Missing period at the end.
> 
>> +    * - struct :c:type:`v4l2_vp9_loop_filter`
>> +      - ``lf``
>> +      - Loop filter parameters. See struct :c:type:`v4l2_vp9_loop_filter`.
>> +    * - struct :c:type:`v4l2_vp9_quantization`
>> +      - ``quant``
>> +      - Quantization parameters. See :c:type:`v4l2_vp9_quantization`.
>> +    * - struct :c:type:`v4l2_vp9_segmentation`
>> +      - ``seg``
>> +      - Segmentation parameters. See :c:type:`v4l2_vp9_segmentation`.
>> +    * - struct :c:type:`v4l2_vp9_probabilities`
>> +      - ``probs``
>> +      - Probabilities. See :c:type:`v4l2_vp9_probabilities`.
>> +
>> +.. c:type:: v4l2_vp9_frame_flags
>> +
>> +.. cssclass:: longtable
>> +
>> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
>> +
>> +.. flat-table:: enum v4l2_vp9_frame_flags
>> +    :header-rows:  0
>> +    :stub-columns: 0
>> +    :widths:       1 2
>> +
>> +    * - ``V4L2_VP9_FRAME_FLAG_KEY_FRAME``
>> +      - The frame is a key frame.
>> +    * - ``V4L2_VP9_FRAME_FLAG_SHOW_FRAME``
>> +      - The frame should be displayed.
>> +    * - ``V4L2_VP9_FRAME_FLAG_ERROR_RESILIENT``
>> +      - The decoding should be error resilient.
>> +    * - ``V4L2_VP9_FRAME_FLAG_INTRA_ONLY``
>> +      - The frame does not reference other frames.
>> +    * - ``V4L2_VP9_FRAME_FLAG_ALLOW_HIGH_PREC_MV``
>> +      - the frame might can high precision motion vectors.
> 
> 'might can'? Should that be 'can use'?
> 
>> +    * - ``V4L2_VP9_FRAME_FLAG_REFRESH_FRAME_CTX``
>> +      - Frame context should be updated after decoding.
>> +    * - ``V4L2_VP9_FRAME_FLAG_PARALLEL_DEC_MODE``
>> +      - Parallel decoding is used.
>> +    * - ``V4L2_VP9_FRAME_FLAG_X_SUBSAMPLING``
>> +      - Vertical subsampling is enabled.
>> +    * - ``V4L2_VP9_FRAME_FLAG_Y_SUBSAMPLING``
>> +      - Horizontal subsampling is enabled.
>> +    * - ``V4L2_VP9_FRAME_FLAG_COLOR_RANGE_FULL_SWING``
>> +      - The full UV range is used.
>> +
>> +.. c:type:: v4l2_vp9_ref_id
>> +
>> +.. cssclass:: longtable
>> +
>> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
>> +
>> +.. flat-table:: enum v4l2_vp9_ref_id
>> +    :header-rows:  0
>> +    :stub-columns: 0
>> +    :widths:       1 2
>> +
>> +    * - ``V4L2_REF_ID_LAST``
>> +      - Last reference frame.
>> +    * - ``V4L2_REF_ID_GOLDEN``
>> +      - Golden reference frame.
>> +    * - ``V4L2_REF_ID_ALTREF``
>> +      - Alternative reference frame.
>> +    * - ``V4L2_REF_ID_CNT``
>> +      - Number of reference frames.
>> +
>> +.. c:type:: v4l2_vp9_tx_mode
>> +
>> +.. cssclass:: longtable
>> +
>> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
>> +
>> +.. flat-table:: enum v4l2_vp9_tx_mode
>> +    :header-rows:  0
>> +    :stub-columns: 0
>> +    :widths:       1 2
>> +
>> +    * - ``V4L2_VP9_TX_MODE_ONLY_4X4``
>> +      - Transform size is 4x4.
>> +    * - ``V4L2_VP9_TX_MODE_ALLOW_8X8``
>> +      - Transform size can be up to 8x8.
>> +    * - ``V4L2_VP9_TX_MODE_ALLOW_16X16``
>> +      - Transform size can be up to 16x16.
>> +    * - ``V4L2_VP9_TX_MODE_ALLOW_32X32``
>> +      - transform size can be up to 32x32.
>> +    * - ``V4L2_VP9_TX_MODE_SELECT``
>> +      - Bitstream contains transform size for each block.
> 
> Either 'contains the transform size' or 'contains transform sizes',
> whichever is appropriate.
> 
>> +
>> +.. c:type:: v4l2_vp9_reference_mode
>> +
>> +.. cssclass:: longtable
>> +
>> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
>> +
>> +.. flat-table:: enum v4l2_vp9_reference_mode
>> +    :header-rows:  0
>> +    :stub-columns: 0
>> +    :widths:       1 2
>> +
>> +    * - ``V4L2_VP9_REF_MODE_SINGLE``
>> +      - Indicates that all the inter blocks use only a single reference frame
>> +        to generate motion compensated prediction.
>> +    * - ``V4L2_VP9_REF_MODE_COMPOUND``
>> +      - Requires all the inter blocks to use compound mode. Single reference
>> +        frame prediction is not allowed.
>> +    * - ``V4L2_VP9_REF_MODE_SELECT``
>> +      - Allows each individual inter block to select between single and
>> +        compound prediction modes.
>> +
>> +.. c:type:: v4l2_vp9_interpolation_filter
>> +
>> +.. cssclass:: longtable
>> +
>> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
>> +
>> +.. flat-table:: enum v4l2_vp9_interpolation_filter
>> +    :header-rows:  0
>> +    :stub-columns: 0
>> +    :widths:       1 2
>> +
>> +    * - ``V4L2_VP9_INTERP_FILTER_8TAP``
>> +      - Height tap filter.
>> +    * - ``V4L2_VP9_INTERP_FILTER_8TAP_SMOOTH``
>> +      - Height tap smooth filter.
>> +    * - ``V4L2_VP9_INTERP_FILTER_8TAP_SHARP``
>> +      - Height tap sharp filter.
>> +    * - ``V4L2_VP9_INTERP_FILTER_BILINEAR``
>> +      - Bilinear filter.
>> +    * - ``V4L2_VP9_INTERP_FILTER_SWITCHABLE``
>> +      - Filter selection is signaled at the block level.
>> +
>> +.. c:type:: v4l2_vp9_reset_frame_context
>> +
>> +.. cssclass:: longtable
>> +
>> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
>> +
>> +.. flat-table:: enum v4l2_vp9_reset_frame_context
>> +    :header-rows:  0
>> +    :stub-columns: 0
>> +    :widths:       1 2
>> +
>> +    * - ``V4L2_VP9_RESET_FRAME_CTX_NONE``
>> +      - Do not reset any frame context.
>> +    * - ``V4L2_VP9_RESET_FRAME_CTX_SPEC``
>> +      - Reset the frame context pointed by
> 
> pointed -> pointed to
> 
>> +        :c:type:`v4l2_ctrl_vp9_frame_decode_params`.frame_context_idx.
>> +    * - ``V4L2_VP9_RESET_FRAME_CTX_ALL``
>> +      - Reset all frame contexts.
>> +
>> +.. c:type:: v4l2_vp9_intra_prediction_mode
>> +
>> +.. cssclass:: longtable
>> +
>> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
>> +
>> +.. flat-table:: enum v4l2_vp9_intra_prediction_mode
>> +    :header-rows:  0
>> +    :stub-columns: 0
>> +    :widths:       1 2
>> +
>> +    * - ``V4L2_VP9_INTRA_PRED_DC``
>> +      - DC intra prediction.
>> +    * - ``V4L2_VP9_INTRA_PRED_MODE_V``
>> +      - Vertical intra prediction.
>> +    * - ``V4L2_VP9_INTRA_PRED_MODE_H``
>> +      - Horizontal intra prediction.
>> +    * - ``V4L2_VP9_INTRA_PRED_MODE_D45``
>> +      - D45 intra prediction.
>> +    * - ``V4L2_VP9_INTRA_PRED_MODE_D135``
>> +      - D135 intra prediction.
>> +    * - ``V4L2_VP9_INTRA_PRED_MODE_D117``
>> +      - D117 intra prediction.
>> +    * - ``V4L2_VP9_INTRA_PRED_MODE_D153``
>> +      - D153 intra prediction.
>> +    * - ``V4L2_VP9_INTRA_PRED_MODE_D207``
>> +      - D207 intra prediction.
>> +    * - ``V4L2_VP9_INTRA_PRED_MODE_D63``
>> +      - D63 intra prediction.
>> +    * - ``V4L2_VP9_INTRA_PRED_MODE_TM``
>> +      - True motion intra prediction.
>> +
>> +.. c:type:: v4l2_vp9_segmentation
>> +
>> +.. cssclass:: longtable
>> +
>> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
>> +
>> +.. flat-table:: struct v4l2_vp9_segmentation
>> +    :header-rows:  0
>> +    :stub-columns: 0
>> +    :widths:       1 1 2
>> +
>> +    * - __u8
>> +      - ``flags``
>> +      - Combination of V4L2_VP9_SEGMENTATION_FLAG_* flags. See
>> +        :c:type:`v4l2_vp9_segmentation_flags`.
>> +    * - __u8
>> +      - ``tree_probs[7]``
>> +      - Specifies the probability values to be used when decoding a Segment-ID.
>> +        See '5.15. Segmentation map' section of :ref:`vp9` for more details.
>> +    * - __u8
>> +      - ``pred_prob[3]``
>> +      - Specifies the probability values to be used when decoding a
>> +        Predicted-Segment-ID. See '6.4.14. Get segment id syntax'
>> +        section of :ref:`vp9` for more details.
>> +    * - __u8
>> +      - ``padding[5]``
>> +      - Used to align this struct on 64 bit. Shall be filled with zeroes.
> 
> I would prefer to have this at the end of the struct. In general I
> prefer padding at the end, not in the middle of a struct, if at all
> possible.

u8 + u8[7] + u8[3] is 11 bytes, then u8[5] makes it 16 bytes. The next chunk
then starts at a 64-bit boundary.

> 
>> +    * - __u8
>> +      - ``feature_enabled[8]``
>> +      - Bitmask defining which features are enabled in each segment.
>> +    * - __u8
>> +      - ``feature_data[8][4]``
>> +      - Data attached to each feature. Data entry is only valid if the feature
>> +        is enabled.
>> +
>> +.. c:type:: v4l2_vp9_segment_feature
>> +
>> +.. cssclass:: longtable
>> +
>> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
>> +
>> +.. flat-table:: enum v4l2_vp9_segment_feature
>> +    :header-rows:  0
>> +    :stub-columns: 0
>> +    :widths:       1 2
>> +
>> +    * - ``V4L2_VP9_SEGMENT_FEATURE_QP_DELTA``
>> +      - QP delta segment feature.
>> +    * - ``V4L2_VP9_SEGMENT_FEATURE_LF``
>> +      - Loop filter segment feature.
>> +    * - ``V4L2_VP9_SEGMENT_FEATURE_REF_FRAME``
>> +      - Reference frame segment feature.
>> +    * - ``V4L2_VP9_SEGMENT_FEATURE_SKIP``
>> +      - Skip segment feature.
>> +    * - ``V4L2_VP9_SEGMENT_FEATURE_CNT``
>> +      - Number of segment features.
>> +
>> +.. c:type:: v4l2_vp9_segmentation_flags
>> +
>> +.. cssclass:: longtable
>> +
>> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
>> +
>> +.. flat-table:: enum v4l2_vp9_segmentation_flags
>> +    :header-rows:  0
>> +    :stub-columns: 0
>> +    :widths:       1 2
>> +
>> +    * - ``V4L2_VP9_SEGMENTATION_FLAG_ENABLED``
>> +      - Indicates that this frame makes use of the segmentation tool.
>> +    * - ``V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP``
>> +      - Indicates that the segmentation map should be updated during the
>> +        decoding of this frame.
>> +    * - ``V4L2_VP9_SEGMENTATION_FLAG_TEMPORAL_UPDATE``
>> +      - Indicates that the updates to the segmentation map are coded
>> +        relative to the existing segmentation map.
>> +    * - ``V4L2_VP9_SEGMENTATION_FLAG_UPDATE_DATA``
>> +      - Indicates that new parameters are about to be specified for each
>> +        segment.
>> +    * - ``V4L2_VP9_SEGMENTATION_FLAG_ABS_OR_DELTA_UPDATE``
>> +      - Indicates that the segmentation parameters represent the actual values
>> +        to be used.
>> +
>> +.. c:type:: v4l2_vp9_quantization
>> +
>> +.. cssclass:: longtable
>> +
>> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
>> +
>> +.. flat-table:: struct v4l2_vp9_quantization
>> +    :header-rows:  0
>> +    :stub-columns: 0
>> +    :widths:       1 1 2
>> +
>> +    * - __u8
>> +      - ``base_q_idx``
>> +      - Indicates the base frame qindex.
>> +    * - __s8
>> +      - ``delta_q_y_dc``
>> +      - Indicates the Y DC quantizer relative to base_q_idx.
>> +    * - __s8
>> +      - ``delta_q_uv_dc``
>> +      - Indicates the UV DC quantizer relative to base_q_idx.
>> +    * - __s8
>> +      - ``delta_q_uv_ac``
>> +      - Indicates the UV AC quantizer relative to base_q_idx.
>> +    * - __u8
>> +      - ``padding[4]``
>> +      - Padding bytes used to align this struct on 64 bit. Must be set to 0.
>> +
>> +.. c:type:: v4l2_vp9_loop_filter
>> +
>> +.. cssclass:: longtable
>> +
>> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
>> +
>> +.. flat-table:: struct v4l2_vp9_loop_filter
>> +    :header-rows:  0
>> +    :stub-columns: 0
>> +    :widths:       1 1 2
>> +
>> +    * - __u8
>> +      - ``flags``
>> +      - Combination of V4L2_VP9_LOOP_FILTER_FLAG_* flags.
>> +        See :c:type:`v4l2_vp9_loop_filter_flags`.
>> +    * - __u8
>> +      - ``level``
>> +      - Indicates the loop filter strength.
>> +    * - __u8
>> +      - ``sharpness``
>> +      - Indicates the sharpness level.
>> +    * - __s8
>> +      - ``ref_deltas[4]``
>> +      - Contains the adjustment needed for the filter level based on the chosen
>> +        reference frame.
>> +    * - __s8
>> +      - ``mode_deltas[2]``
>> +      - Contains the adjustment needed for the filter level based on the chosen
>> +        mode
>> +    * - __u8
>> +      - ``level_lookup[8][4][2]``
>> +      - Level lookup table.
>> +
>> +
>> +.. c:type:: v4l2_vp9_loop_filter_flags
>> +
>> +.. cssclass:: longtable
>> +
>> +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
>> +
>> +.. flat-table:: enum v4l2_vp9_loop_filter_flags
>> +    :header-rows:  0
>> +    :stub-columns: 0
>> +    :widths:       1 2
>> +
>> +    * - ``V4L2_VP9_LOOP_FILTER_FLAG_DELTA_ENABLED``
>> +      - When set, the filter level depends on the mode and reference frame used
>> +        to predict a block.
>> +    * - ``V4L2_VP9_LOOP_FILTER_FLAG_DELTA_UPDATE``
>> +      - When set, the bitstream contains additional syntax elements that
>> +        specify which mode and reference frame deltas are to be updated.
>> diff --git a/Documentation/userspace-api/media/v4l/pixfmt-compressed.rst b/Documentation/userspace-api/media/v4l/pixfmt-compressed.rst
>> index 6dba70da822b..7e34aeb1cb92 100644
>> --- a/Documentation/userspace-api/media/v4l/pixfmt-compressed.rst
>> +++ b/Documentation/userspace-api/media/v4l/pixfmt-compressed.rst
>> @@ -171,6 +171,21 @@ Compressed Formats
>>         - VP9 compressed video frame. The encoder generates one
>>   	compressed frame per buffer, and the decoder requires one
>>   	compressed frame per buffer.
>> +    * .. _V4L2-PIX-FMT-VP9_FRAME:
>> +
>> +      - ``V4L2_PIX_FMT_VP9_FRAME``
>> +      - 'VP9F'
>> +      - VP9 parsed frame, including the frame header, as extracted from the container.
>> +	This format is adapted for stateless video decoders that implement an
> 
> an -> a
> 
>> +	VP9 pipeline with the :ref:`stateless_decoder`.
>> +	Metadata associated with the frame to decode is required to be passed
>> +	through the ``V4L2_CID_STATELESS_VP9_FRAME_DECODE_PARAMS`` and
>> +	the ``V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS`` controls.
>> +	See the :ref:`associated Codec Control IDs <v4l2-codec-stateless-vp9>`.
>> +	Exactly one output and one capture buffer must be provided for use with
>> +	this pixel format. The output buffer must contain the appropriate number
>> +	of macroblocks to decode a full corresponding frame to the matching
>> +	capture buffer.
>>       * .. _V4L2-PIX-FMT-HEVC:
>>   
>>         - ``V4L2_PIX_FMT_HEVC``
>> diff --git a/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst b/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst
>> index 3ba22983d21f..3ff72ca63772 100644
>> --- a/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst
>> +++ b/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst
>> @@ -221,6 +221,14 @@ still cause this situation.
>>         - ``p_vp8_frame``
>>         - A pointer to a struct :c:type:`v4l2_ctrl_vp8_frame`. Valid if this control is
>>           of type ``V4L2_CTRL_TYPE_VP8_FRAME``.
>> +    * - struct :c:type:`v4l2_ctrl_vp9_compressed_hdr_probs` *
>> +      - ``p_vp9_compressed_hdr_probs``
>> +      - A pointer to a struct :c:type:`v4l2_ctrl_vp9_compressed_hdr_probs'. Valid if this contro is
> 
> contro -> control
> 
>> +        of type ``V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR_PROBS``.
>> +    * - struct :c:type:`v4l2_ctrl_vp9_frame_decode_params` *
>> +      - ``p_vp9_frame_decode_params``
>> +      - A pointer to a struct :c:type:`v4l2_ctrl_vp9_frame_decode_params'. Valid if this contro is
> 
> ditto
> 
>> +        of type ``V4L2_CTRL_TYPE_VP9_FRAME_DECODE_PARAMS``.
>>       * - struct :c:type:`v4l2_ctrl_hdr10_cll_info` *
>>         - ``p_hdr10_cll``
>>         - A pointer to a struct :c:type:`v4l2_ctrl_hdr10_cll_info`. Valid if this control is
>> diff --git a/Documentation/userspace-api/media/v4l/vidioc-queryctrl.rst b/Documentation/userspace-api/media/v4l/vidioc-queryctrl.rst
>> index 8a285daedc6a..85fb8b7a9428 100644
>> --- a/Documentation/userspace-api/media/v4l/vidioc-queryctrl.rst
>> +++ b/Documentation/userspace-api/media/v4l/vidioc-queryctrl.rst
>> @@ -495,6 +495,18 @@ See also the examples in :ref:`control`.
>>         - n/a
>>         - A struct :c:type:`v4l2_ctrl_vp8_frame`, containing VP8
>>   	frame parameters for stateless video decoders.
>> +    * - ``V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR_PROBS``
>> +      - n/a
>> +      - n/a
>> +      - n/a
>> +      - A struct :c:type:`v4l2_ctrl_vp9_compressed_hdr_probs`, containing VP9
>> +	probabilities updates for stateless video decoders.
>> +    * - ``V4L2_CTRL_TYPE_VP9_FRAME_DECODE_PARAMS``
>> +      - n/a
>> +      - n/a
>> +      - n/a
>> +      - A struct :c:type:`v4l2_ctrl_vp9_compressed_hdr_probs`, containing VP9
> 
> v4l2_ctrl_vp9_compressed_hdr_probs -> v4l2_ctrl_vp9_frame_decode_params
> 
>> +	frame decode parameters for stateless video decoders.
>>   
>>   .. raw:: latex
>>   
>> diff --git a/Documentation/userspace-api/media/videodev2.h.rst.exceptions b/Documentation/userspace-api/media/videodev2.h.rst.exceptions
>> index f59940352faa..fdc6f2b22df8 100644
>> --- a/Documentation/userspace-api/media/videodev2.h.rst.exceptions
>> +++ b/Documentation/userspace-api/media/videodev2.h.rst.exceptions
>> @@ -148,6 +148,8 @@ replace symbol V4L2_CTRL_TYPE_HEVC_SLICE_PARAMS :c:type:`v4l2_ctrl_type`
>>   replace symbol V4L2_CTRL_TYPE_AREA :c:type:`v4l2_ctrl_type`
>>   replace symbol V4L2_CTRL_TYPE_FWHT_PARAMS :c:type:`v4l2_ctrl_type`
>>   replace symbol V4L2_CTRL_TYPE_VP8_FRAME :c:type:`v4l2_ctrl_type`
>> +replace symbol V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR_PROBS :c:type:`v4l2_ctrl_type`
>> +replace symbol V4L2_CTRL_TYPE_VP9_FRAME_DECODE_PARAMS :c:type:`v4l2_ctrl_type`
>>   replace symbol V4L2_CTRL_TYPE_HDR10_CLL_INFO :c:type:`v4l2_ctrl_type`
>>   replace symbol V4L2_CTRL_TYPE_HDR10_MASTERING_DISPLAY :c:type:`v4l2_ctrl_type`
>>   
>> diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c
>> index 0d7fe1bd975a..8de7238593ab 100644
>> --- a/drivers/media/v4l2-core/v4l2-ctrls.c
>> +++ b/drivers/media/v4l2-core/v4l2-ctrls.c
>> @@ -1215,6 +1215,8 @@ const char *v4l2_ctrl_get_name(u32 id)
>>   	case V4L2_CID_STATELESS_H264_DECODE_PARAMS:		return "H264 Decode Parameters";
>>   	case V4L2_CID_STATELESS_FWHT_PARAMS:			return "FWHT Stateless Parameters";
>>   	case V4L2_CID_STATELESS_VP8_FRAME:			return "VP8 Frame Parameters";
>> +	case V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS:	return "VP9 Probabilities Updates";
>> +	case V4L2_CID_STATELESS_VP9_FRAME_DECODE_PARAMS:	return "VP9 Frame Decode Parameters";
>>   
>>   	/* Colorimetry controls */
>>   	/* Keep the order of the 'case's the same as in v4l2-controls.h! */
>> @@ -1517,6 +1519,12 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum v4l2_ctrl_type *type,
>>   	case V4L2_CID_STATELESS_VP8_FRAME:
>>   		*type = V4L2_CTRL_TYPE_VP8_FRAME;
>>   		break;
>> +	case V4L2_CID_STATELESS_VP9_FRAME_DECODE_PARAMS:
>> +		*type = V4L2_CTRL_TYPE_VP9_FRAME_DECODE_PARAMS;
>> +		break;
>> +	case V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS:
>> +		*type = V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR_PROBS;
>> +		break;
> 
> Let's swap the order of these two cases. Everywhere else it seems that
> PROBS comes before DECODE_PARARMS, so stay consistent.
> 
>>   	case V4L2_CID_MPEG_VIDEO_HEVC_SPS:
>>   		*type = V4L2_CTRL_TYPE_HEVC_SPS;
>>   		break;
>> @@ -1836,6 +1844,12 @@ static void std_log(const struct v4l2_ctrl *ctrl)
>>   	case V4L2_CTRL_TYPE_VP8_FRAME:
>>   		pr_cont("VP8_FRAME");
>>   		break;
>> +	case V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR_PROBS:
>> +		pr_cont("VP9_COMPRESSED_HDR_PROBS");
>> +		break;
>> +	case V4L2_CTRL_TYPE_VP9_FRAME_DECODE_PARAMS:
>> +		pr_cont("VP9_FRAME_DECODE_PARAMS");
>> +		break;
>>   	case V4L2_CTRL_TYPE_HDR10_CLL_INFO:
>>   		pr_cont("HDR10_CLL_INFO");
>>   		break;
>> @@ -1869,6 +1883,224 @@ static void std_log(const struct v4l2_ctrl *ctrl)
>>   	0;							\
>>   })
>>   
>> +static int
>> +validate_vp9_lf_params(struct v4l2_vp9_loop_filter *lf)
>> +{
>> +	unsigned int i, j, k;
>> +
>> +	if (lf->flags &
>> +	    ~(V4L2_VP9_LOOP_FILTER_FLAG_DELTA_ENABLED |
>> +	      V4L2_VP9_LOOP_FILTER_FLAG_DELTA_UPDATE))
> 
> This is more readable because it is clearer that you are
> checking flags against invalid bits:
> 
> 	if (lf->flags & ~(V4L2_VP9_LOOP_FILTER_FLAG_DELTA_ENABLED |
> 			  V4L2_VP9_LOOP_FILTER_FLAG_DELTA_UPDATE))
> 
> There are similar cases like this further down, do the same there
> unless you get lines that are too long.
> 
>> +		return -EINVAL;
>> +
>> +	/*
>> +	 * V4L2_VP9_LOOP_FILTER_FLAG_DELTA_ENABLED implies
>> +	 * V4L2_VP9_LOOP_FILTER_FLAG_DELTA_UPDATE.
>> +	 */
>> +	if (lf->flags & V4L2_VP9_LOOP_FILTER_FLAG_DELTA_UPDATE &&
>> +	    !(lf->flags & V4L2_VP9_LOOP_FILTER_FLAG_DELTA_ENABLED))
>> +		return -EINVAL;
>> +
>> +	/* That all values are in the accepted range. */
>> +	if (lf->level > GENMASK(5, 0))
>> +		return -EINVAL;
>> +
>> +	if (lf->sharpness > GENMASK(2, 0))
>> +		return -EINVAL;
>> +
>> +	for (i = 0; i < ARRAY_SIZE(lf->ref_deltas); i++) {
> 
> You can drop { here.
> 
>> +		if (lf->ref_deltas[i] < -63 || lf->ref_deltas[i] > 63)
>> +			return -EINVAL;
>> +	}
>> +
>> +	for (i = 0; i < ARRAY_SIZE(lf->mode_deltas); i++) {
> 
> ditto
> 
>> +		if (lf->mode_deltas[i] < -63 || lf->mode_deltas[i] > 63)
>> +			return -EINVAL;
>> +	}
>> +
>> +	for (i = 0; i < ARRAY_SIZE(lf->level_lookup); i++) {
> 
> ditto
> 
>> +		for (j = 0; j < ARRAY_SIZE(lf->level_lookup[0]); j++) {
> 
> ditto
> 
>> +			for (k = 0; k < ARRAY_SIZE(lf->level_lookup[0][0]); k++) {
> 
> ditto
> 
>> +				if (lf->level_lookup[i][j][k] > 63)
>> +					return -EINVAL;
>> +			}
>> +		}
>> +	}
>> +
>> +	return 0;
>> +}
>> +
>> +static int
>> +validate_vp9_quant_params(struct v4l2_vp9_quantization *quant)
>> +{
>> +	if (quant->delta_q_y_dc < -15 || quant->delta_q_y_dc > 15 ||
>> +	    quant->delta_q_uv_dc < -15 || quant->delta_q_uv_dc > 15 ||
>> +	    quant->delta_q_uv_ac < -15 || quant->delta_q_uv_ac > 15)
>> +		return -EINVAL;
>> +
>> +	memset(quant->padding, 0, sizeof(quant->padding));
> 
> Use the zero_padding macro for this. Check other occurrence of this.
> 
>> +	return 0;
>> +}
>> +
>> +static int
>> +validate_vp9_seg_params(struct v4l2_vp9_segmentation *seg)
>> +{
>> +	unsigned int i, j;
>> +
>> +	if (seg->flags &
>> +	    ~(V4L2_VP9_SEGMENTATION_FLAG_ENABLED |
>> +	      V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP |
>> +	      V4L2_VP9_SEGMENTATION_FLAG_TEMPORAL_UPDATE |
>> +	      V4L2_VP9_SEGMENTATION_FLAG_UPDATE_DATA |
>> +	      V4L2_VP9_SEGMENTATION_FLAG_ABS_OR_DELTA_UPDATE))
>> +		return -EINVAL;
>> +
>> +	/*
>> +	 * V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP and
>> +	 * V4L2_VP9_SEGMENTATION_FLAG_UPDATE_DATA imply
>> +	 * V4L2_VP9_SEGMENTATION_FLAG_ENABLED.
>> +	 */
>> +	if ((seg->flags &
>> +	     (V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP |
>> +	      V4L2_VP9_SEGMENTATION_FLAG_UPDATE_DATA)) &&
>> +	    !(seg->flags & V4L2_VP9_SEGMENTATION_FLAG_ENABLED))
>> +		return -EINVAL;
>> +
>> +	/*
>> +	 * V4L2_VP9_SEGMENTATION_FLAG_TEMPORAL_UPDATE implies
>> +	 * V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP.
>> +	 */
>> +	if (seg->flags & V4L2_VP9_SEGMENTATION_FLAG_TEMPORAL_UPDATE &&
>> +	    !(seg->flags & V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP))
>> +		return -EINVAL;
>> +
>> +	/*
>> +	 * V4L2_VP9_SEGMENTATION_FLAG_ABS_OR_DELTA_UPDATE implies
>> +	 * V4L2_VP9_SEGMENTATION_FLAG_UPDATE_DATA.
>> +	 */
>> +	if (seg->flags & V4L2_VP9_SEGMENTATION_FLAG_ABS_OR_DELTA_UPDATE &&
>> +	    !(seg->flags & V4L2_VP9_SEGMENTATION_FLAG_UPDATE_DATA))
>> +		return -EINVAL;
>> +
>> +	for (i = 0; i < ARRAY_SIZE(seg->feature_enabled); i++) {
>> +		if (seg->feature_enabled[i] &
>> +		    ~(V4L2_VP9_SEGMENT_FEATURE_QP_DELTA |
>> +		      V4L2_VP9_SEGMENT_FEATURE_LF |
>> +		      V4L2_VP9_SEGMENT_FEATURE_REF_FRAME |
>> +		      V4L2_VP9_SEGMENT_FEATURE_SKIP))
>> +			return -EINVAL;
>> +	}
>> +
>> +	for (i = 0; i < ARRAY_SIZE(seg->feature_data); i++) {
>> +		const int range[] = {255, 63, 3, 0};
> 
> Space after/before { and }.
> 
>> +
>> +		for (j = 0; j < ARRAY_SIZE(seg->feature_data[j]); j++) {
>> +			if (seg->feature_data[i][j] < -range[j] ||
>> +			    seg->feature_data[i][j] > range[j])
>> +				return -EINVAL;
>> +		}
>> +	}
>> +
>> +	memset(seg->padding, 0, sizeof(seg->padding));
>> +	return 0;
>> +}
>> +
>> +static int
>> +validate_vp9_frame_decode_params(struct v4l2_ctrl_vp9_frame_decode_params *dec_params)
>> +{
>> +	int ret, i;
>> +
>> +	/* Make sure we're not passed invalid flags. */
>> +	if (dec_params->flags &
>> +	    ~(V4L2_VP9_FRAME_FLAG_KEY_FRAME |
>> +	      V4L2_VP9_FRAME_FLAG_SHOW_FRAME |
>> +	      V4L2_VP9_FRAME_FLAG_ERROR_RESILIENT |
>> +	      V4L2_VP9_FRAME_FLAG_INTRA_ONLY |
>> +	      V4L2_VP9_FRAME_FLAG_ALLOW_HIGH_PREC_MV |
>> +	      V4L2_VP9_FRAME_FLAG_REFRESH_FRAME_CTX |
>> +	      V4L2_VP9_FRAME_FLAG_PARALLEL_DEC_MODE |
>> +	      V4L2_VP9_FRAME_FLAG_X_SUBSAMPLING |
>> +	      V4L2_VP9_FRAME_FLAG_Y_SUBSAMPLING |
>> +	      V4L2_VP9_FRAME_FLAG_COLOR_RANGE_FULL_SWING))
>> +		return -EINVAL;
>> +
>> +	/*
>> +	 * The refresh context and error resilient flags are mutually exclusive.
>> +	 * Same goes for parallel decoding and error resilient modes.
>> +	 */
>> +	if (dec_params->flags & V4L2_VP9_FRAME_FLAG_ERROR_RESILIENT &&
>> +	    dec_params->flags &
>> +	    (V4L2_VP9_FRAME_FLAG_REFRESH_FRAME_CTX |
>> +	     V4L2_VP9_FRAME_FLAG_PARALLEL_DEC_MODE))
>> +		return -EINVAL;
>> +
>> +	if (dec_params->profile > V4L2_VP9_PROFILE_MAX)
>> +		return -EINVAL;
>> +
>> +	if (dec_params->reset_frame_context > V4L2_VP9_RESET_FRAME_CTX_ALL)
>> +		return -EINVAL;
>> +
>> +	if (dec_params->frame_context_idx >= V4L2_VP9_NUM_FRAME_CTX)
>> +		return -EINVAL;
>> +
>> +	/*
>> +	 * Profiles 0 and 1 only support 8-bit depth, profiles 2 and 3 only 10
>> +	 * and 12 bit depths.
>> +	 */
>> +	if ((dec_params->profile < 2 && dec_params->bit_depth != 8) ||
>> +	    (dec_params->profile >= 2 &&
>> +	     (dec_params->bit_depth != 10 && dec_params->bit_depth != 12)))
>> +		return -EINVAL;
>> +
>> +	/* Profile 0 and 2 only accept YUV 4:2:0. */
>> +	if ((dec_params->profile == 0 || dec_params->profile == 2) &&
>> +	    (!(dec_params->flags & V4L2_VP9_FRAME_FLAG_X_SUBSAMPLING) ||
>> +	     !(dec_params->flags & V4L2_VP9_FRAME_FLAG_Y_SUBSAMPLING)))
>> +		return -EINVAL;
>> +
>> +	/* Profile 1 and 3 only accept YUV 4:2:2, 4:4:0 and 4:4:4. */
>> +	if ((dec_params->profile == 1 || dec_params->profile == 3) &&
>> +	    ((dec_params->flags & V4L2_VP9_FRAME_FLAG_X_SUBSAMPLING) &&
>> +	     (dec_params->flags & V4L2_VP9_FRAME_FLAG_Y_SUBSAMPLING)))
>> +		return -EINVAL;
>> +
>> +	if (dec_params->interpolation_filter > V4L2_VP9_INTERP_FILTER_SWITCHABLE)
>> +		return -EINVAL;
>> +
>> +	/*
>> +	 * According to the spec, tile_cols_log2 shall be less than or equal
>> +	 * to 6.
>> +	 */
>> +	if (dec_params->tile_cols_log2 > 6)
>> +		return -EINVAL;
>> +
>> +	if (dec_params->tx_mode > V4L2_VP9_TX_MODE_SELECT)
>> +		return -EINVAL;
>> +
>> +	if (dec_params->reference_mode > V4L2_VP9_REF_MODE_SELECT)
>> +		return -EINVAL;
>> +
>> +	for (i = 0; i < V4L2_REF_ID_CNT + 1; ++i)
>> +		if (dec_params->ref_frame_sign_bias[i] != 0 &&
>> +		    dec_params->ref_frame_sign_bias[i] != 1)
>> +			return -EINVAL;
>> +
>> +	ret = validate_vp9_lf_params(&dec_params->lf);
>> +	if (ret)
>> +		return ret;
>> +
>> +	ret = validate_vp9_quant_params(&dec_params->quant);
>> +	if (ret)
>> +		return ret;
>> +
>> +	ret = validate_vp9_seg_params(&dec_params->seg);
>> +	if (ret)
>> +		return ret;
>> +
>> +	memset(dec_params->padding, 0, sizeof(dec_params->padding));
>> +	return 0;
>> +}
>> +
>>   /* Validate a new control */
>>   
>>   #define zero_padding(s) \
>> @@ -2127,6 +2359,12 @@ static int std_validate_compound(const struct v4l2_ctrl *ctrl, u32 idx,
>>   		zero_padding(p_vp8_frame->coder_state);
>>   		break;
>>   
>> +	case V4L2_CTRL_TYPE_VP9_FRAME_DECODE_PARAMS:
>> +		return validate_vp9_frame_decode_params(p);
>> +
>> +	case V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR_PROBS:
>> +		break;
>> +
>>   	case V4L2_CTRL_TYPE_HEVC_SPS:
>>   		p_hevc_sps = p;
>>   
>> @@ -2938,6 +3176,12 @@ static struct v4l2_ctrl *v4l2_ctrl_new(struct v4l2_ctrl_handler *hdl,
>>   	case V4L2_CTRL_TYPE_VP8_FRAME:
>>   		elem_size = sizeof(struct v4l2_ctrl_vp8_frame);
>>   		break;
>> +	case V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR_PROBS:
>> +		elem_size = sizeof(struct v4l2_ctrl_vp9_compressed_hdr_probs);
>> +		break;
>> +	case V4L2_CTRL_TYPE_VP9_FRAME_DECODE_PARAMS:
>> +		elem_size = sizeof(struct v4l2_ctrl_vp9_frame_decode_params);
>> +		break;
>>   	case V4L2_CTRL_TYPE_HEVC_SPS:
>>   		elem_size = sizeof(struct v4l2_ctrl_hevc_sps);
>>   		break;
>> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
>> index 6a5d1c6d11d6..dbdafa5ea127 100644
>> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
>> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
>> @@ -1431,6 +1431,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
>>   		case V4L2_PIX_FMT_VP8:		descr = "VP8"; break;
>>   		case V4L2_PIX_FMT_VP8_FRAME:    descr = "VP8 Frame"; break;
>>   		case V4L2_PIX_FMT_VP9:		descr = "VP9"; break;
>> +		case V4L2_PIX_FMT_VP9_FRAME:    descr = "VP9 Frame"; break;
>>   		case V4L2_PIX_FMT_HEVC:		descr = "HEVC"; break; /* aka H.265 */
>>   		case V4L2_PIX_FMT_HEVC_SLICE:	descr = "HEVC Parsed Slice Data"; break;
>>   		case V4L2_PIX_FMT_FWHT:		descr = "FWHT"; break; /* used in vicodec */
>> diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h
>> index a5953b812878..8c5fb22ff545 100644
>> --- a/include/media/v4l2-ctrls.h
>> +++ b/include/media/v4l2-ctrls.h
>> @@ -50,6 +50,8 @@ struct video_device;
>>    * @p_h264_decode_params:	Pointer to a struct v4l2_ctrl_h264_decode_params.
>>    * @p_h264_pred_weights:	Pointer to a struct v4l2_ctrl_h264_pred_weights.
>>    * @p_vp8_frame:		Pointer to a VP8 frame params structure.
>> + * @p_vp9_compressed_hdr_probs:	Pointer to a VP9 frame compressed header probs structure.
>> + * @p_vp9_frame_decode_params:	Pointer to a VP9 frame params structure.
> 
> Why is this called p_vp9_frame_decode_params while for VP8 it is called
> p_vp8_frame? The mismatch is odd. This comment is of course about the general
> naming of this control, not just this fiel
If that's preferred, it will be changed in v2.

> 
>>    * @p_hevc_sps:			Pointer to an HEVC sequence parameter set structure.
>>    * @p_hevc_pps:			Pointer to an HEVC picture parameter set structure.
>>    * @p_hevc_slice_params:	Pointer to an HEVC slice parameters structure.
>> @@ -79,6 +81,8 @@ union v4l2_ctrl_ptr {
>>   	struct v4l2_ctrl_hevc_sps *p_hevc_sps;
>>   	struct v4l2_ctrl_hevc_pps *p_hevc_pps;
>>   	struct v4l2_ctrl_hevc_slice_params *p_hevc_slice_params;
>> +	struct v4l2_ctrl_vp9_compressed_hdr_probs *p_vp9_compressed_hdr_probs;
>> +	struct v4l2_ctrl_vp9_frame_decode_params *p_vp9_frame_decode_params;
>>   	struct v4l2_ctrl_hdr10_cll_info *p_hdr10_cll;
>>   	struct v4l2_ctrl_hdr10_mastering_display *p_hdr10_mastering;
>>   	struct v4l2_area *p_area;
>> diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h
>> index d43bec5f1afd..ff5c574f2755 100644
>> --- a/include/uapi/linux/v4l2-controls.h
>> +++ b/include/uapi/linux/v4l2-controls.h
>> @@ -1896,6 +1896,461 @@ struct v4l2_ctrl_hdr10_mastering_display {
>>   	__u32 min_display_mastering_luminance;
>>   };
>>   
>> +/* Stateless VP9 control */
> 
> control -> controls
> 
>> +
>> +/**
>> + * enum v4l2_vp9_loop_filter_flags - VP9 loop filter flags
>> + *
>> + * @V4L2_VP9_LOOP_FILTER_FLAG_DELTA_ENABLED: the filter level depends on
>> + *					     the mode and reference frame used
>> + *					     to predict a block
>> + * @V4L2_VP9_LOOP_FILTER_FLAG_DELTA_UPDATE: the bitstream contains additional
>> + *					    syntax elements that specify which
>> + *					    mode and reference frame deltas
>> + *					    are to be updated
>> + *
>> + * Those are the flags you should pass to &v4l2_vp9_loop_filter.flags. See
>> + * section '7.2.8 Loop filter semantics' of the VP9 specification for more
>> + * details.
>> + */
>> +enum v4l2_vp9_loop_filter_flags {
>> +	V4L2_VP9_LOOP_FILTER_FLAG_DELTA_ENABLED = 1 << 0,
>> +	V4L2_VP9_LOOP_FILTER_FLAG_DELTA_UPDATE = 1 << 1,
>> +};
>> +
>> +/**
>> + * struct v4l2_vp9_loop_filter - VP9 loop filter parameters
>> + *
>> + * @flags: combination of V4L2_VP9_LOOP_FILTER_FLAG_* flags
>> + * @level: indicates the loop filter strength
>> + * @sharpness: indicates the sharpness level
>> + * @ref_deltas: contains the adjustment needed for the filter level based on
>> + *		the chosen reference frame
>> + * @mode_deltas: contains the adjustment needed for the filter level based on
>> + *		 the chosen mode
>> + * @level_lookup: level lookup table
>> + *
>> + * This structure contains all loop filter related parameters. See sections
>> + * '7.2.8 Loop filter semantics' and '8.8.1 Loop filter frame init process'
>> + * of the VP9 specification for more details.
>> + */
>> +struct v4l2_vp9_loop_filter {
>> +	__u8 flags;
>> +	__u8 level;
>> +	__u8 sharpness;
>> +	__s8 ref_deltas[4];
>> +	__s8 mode_deltas[2];
>> +	__u8 level_lookup[8][4][2];
>> +	__u8 padding;
>> +};
>> +
>> +/**
>> + * struct v4l2_vp9_quantization - VP9 quantization parameters
>> + *
>> + * @base_q_idx: indicates the base frame qindex
>> + * @delta_q_y_dc: indicates the Y DC quantizer relative to base_q_idx
>> + * @delta_q_uv_dc: indicates the UV DC quantizer relative to base_q_idx
>> + * @delta_q_uv_ac indicates the UV AC quantizer relative to base_q_idx
>> + * @padding: padding bytes to align things on 64 bits. Must be set to 0
>> + *
>> + * Encodes the quantization parameters. See section '7.2.9 Quantization params
>> + * syntax' of the VP9 specification for more details.
>> + */
>> +struct v4l2_vp9_quantization {
>> +	__u8 base_q_idx;
>> +	__s8 delta_q_y_dc;
>> +	__s8 delta_q_uv_dc;
>> +	__s8 delta_q_uv_ac;
>> +	__u8 padding[4];
>> +};
>> +
>> +/**
>> + * enum v4l2_vp9_segmentation_flags - VP9 segmentation flags
>> + *
>> + * @V4L2_VP9_SEGMENTATION_FLAG_ENABLED: indicates that this frame makes use of
>> + *					the segmentation tool
> 
> Don't indent so far to the right. In case like this you just add a single TAB
> after the *. Same elsewhere.
> 
>> + * @V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP: indicates that the segmentation map
>> + *					   should be updated during the
>> + *					   decoding of this frame
>> + * @V4L2_VP9_SEGMENTATION_FLAG_TEMPORAL_UPDATE: indicates that the updates to
>> + *						the segmentation map are coded
>> + *						relative to the existing
>> + *						segmentation map
>> + * @V4L2_VP9_SEGMENTATION_FLAG_UPDATE_DATA: indicates that new parameters are
>> + *					    about to be specified for each
>> + *					    segment
>> + * @V4L2_VP9_SEGMENTATION_FLAG_ABS_OR_DELTA_UPDATE: indicates that the
>> + *						    segmentation parameters
>> + *						    represent the actual values
>> + *						    to be used
>> + *
>> + * Those are the flags you should pass to &v4l2_vp9_segmentation.flags. See
>> + * section '7.2.10 Segmentation params syntax' of the VP9 specification for
>> + * more details.
>> + */
>> +enum v4l2_vp9_segmentation_flags {
>> +	V4L2_VP9_SEGMENTATION_FLAG_ENABLED = 1 << 0,
>> +	V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP = 1 << 1,
>> +	V4L2_VP9_SEGMENTATION_FLAG_TEMPORAL_UPDATE = 1 << 2,
>> +	V4L2_VP9_SEGMENTATION_FLAG_UPDATE_DATA = 1 << 3,
>> +	V4L2_VP9_SEGMENTATION_FLAG_ABS_OR_DELTA_UPDATE = 1 << 4,
>> +};
>> +
>> +#define V4L2_VP9_SEGMENT_FEATURE_ENABLED(id)	(1 << (id))
>> +#define V4L2_VP9_SEGMENT_FEATURE_ENABLED_MASK	0xf
>> +
>> +/**
>> + * enum v4l2_vp9_segment_feature - VP9 segment feature IDs
>> + *
>> + * @V4L2_VP9_SEGMENT_FEATURE_QP_DELTA: QP delta segment feature
>> + * @V4L2_VP9_SEGMENT_FEATURE_LF: loop filter segment feature
>> + * @V4L2_VP9_SEGMENT_FEATURE_REF_FRAME: reference frame segment feature
>> + * @V4L2_VP9_SEGMENT_FEATURE_SKIP: skip segment feature
>> + * @V4L2_VP9_SEGMENT_FEATURE_CNT: number of segment features
>> + *
>> + * Segment feature IDs. See section '7.2.10 Segmentation params syntax' of the
>> + * VP9 specification for more details.
>> + */
>> +enum v4l2_vp9_segment_feature {
>> +	V4L2_VP9_SEGMENT_FEATURE_QP_DELTA,
>> +	V4L2_VP9_SEGMENT_FEATURE_LF,
>> +	V4L2_VP9_SEGMENT_FEATURE_REF_FRAME,
>> +	V4L2_VP9_SEGMENT_FEATURE_SKIP,
>> +	V4L2_VP9_SEGMENT_FEATURE_CNT,
>> +};
>> +
>> +/**
>> + * struct v4l2_vp9_segmentation - VP9 segmentation parameters
>> + *
>> + * @flags: combination of V4L2_VP9_SEGMENTATION_FLAG_* flags
>> + * @tree_probs: specifies the probability values to be used when
>> + *              decoding a Segment-ID. See '5.15. Segmentation map'
>> + *              section of the VP9 specification for more details.
>> + * @pred_prob: specifies the probability values to be used when decoding a
>> + *	       Predicted-Segment-ID. See '6.4.14. Get segment id syntax'
>> + *	       section of :ref:`vp9` for more details..
>> + * @padding: padding used to make things aligned on 64 bits. Shall be zero
>> + *	     filled
>> + * @feature_enabled: bitmask defining which features are enabled in each
>> + *		     segment
>> + * @feature_data: data attached to each feature. Data entry is only valid if
>> + *		  the feature is enabled
>> + *
>> + * Encodes the quantization parameters. See section '7.2.10 Segmentation
>> + * params syntax' of the VP9 specification for more details.
>> + */
>> +struct v4l2_vp9_segmentation {
>> +	__u8 flags;
>> +	__u8 tree_probs[7];
>> +	__u8 pred_probs[3];
>> +	__u8 padding[5];
>> +	__u8 feature_enabled[8];
>> +	__s16 feature_data[8][4];
>> +};
>> +
>> +/**
>> + * enum v4l2_vp9_intra_prediction_mode - VP9 Intra prediction modes
>> + *
>> + * @V4L2_VP9_INTRA_PRED_DC: DC intra prediction
>> + * @V4L2_VP9_INTRA_PRED_MODE_V: vertical intra prediction
>> + * @V4L2_VP9_INTRA_PRED_MODE_H: horizontal intra prediction
>> + * @V4L2_VP9_INTRA_PRED_MODE_D45: D45 intra prediction
>> + * @V4L2_VP9_INTRA_PRED_MODE_D135: D135 intra prediction
>> + * @V4L2_VP9_INTRA_PRED_MODE_D117: D117 intra prediction
>> + * @V4L2_VP9_INTRA_PRED_MODE_D153: D153 intra prediction
>> + * @V4L2_VP9_INTRA_PRED_MODE_D207: D207 intra prediction
>> + * @V4L2_VP9_INTRA_PRED_MODE_D63: D63 intra prediction
>> + * @V4L2_VP9_INTRA_PRED_MODE_TM: True Motion intra prediction
>> + *
>> + * See section '7.4.5 Intra frame mode info semantics' for more details.
>> + */
>> +enum v4l2_vp9_intra_prediction_mode {
>> +	V4L2_VP9_INTRA_PRED_MODE_DC,
>> +	V4L2_VP9_INTRA_PRED_MODE_V,
>> +	V4L2_VP9_INTRA_PRED_MODE_H,
>> +	V4L2_VP9_INTRA_PRED_MODE_D45,
>> +	V4L2_VP9_INTRA_PRED_MODE_D135,
>> +	V4L2_VP9_INTRA_PRED_MODE_D117,
>> +	V4L2_VP9_INTRA_PRED_MODE_D153,
>> +	V4L2_VP9_INTRA_PRED_MODE_D207,
>> +	V4L2_VP9_INTRA_PRED_MODE_D63,
>> +	V4L2_VP9_INTRA_PRED_MODE_TM,
>> +};
>> +
>> +/**
>> + * enum v4l2_vp9_reset_frame_context - Valid values for
>> + *			&v4l2_ctrl_vp9_frame_decode_params->reset_frame_context
>> + *
>> + * @V4L2_VP9_RESET_FRAME_CTX_NONE: don't reset any frame context
>> + * @V4L2_VP9_RESET_FRAME_CTX_SPEC: reset the frame context pointed by
>> + *			&v4l2_ctrl_vp9_frame_decode_params.frame_context_idx
>> + * @V4L2_VP9_RESET_FRAME_CTX_ALL: reset all frame contexts
>> + *
>> + * See section '7.2 Uncompressed header semantics' of the VP9 specification
>> + * for more details.
>> + */
>> +enum v4l2_vp9_reset_frame_context {
>> +	V4L2_VP9_RESET_FRAME_CTX_NONE,
>> +	V4L2_VP9_RESET_FRAME_CTX_SPEC,
>> +	V4L2_VP9_RESET_FRAME_CTX_ALL,
>> +};
>> +
>> +/**
>> + * enum v4l2_vp9_interpolation_filter - VP9 interpolation filter types
>> + *
>> + * @V4L2_VP9_INTERP_FILTER_8TAP: height tap filter
>> + * @V4L2_VP9_INTERP_FILTER_8TAP_SMOOTH: height tap smooth filter
>> + * @V4L2_VP9_INTERP_FILTER_8TAP_SHARP: height tap sharp filter
>> + * @V4L2_VP9_INTERP_FILTER_BILINEAR: bilinear filter
>> + * @V4L2_VP9_INTERP_FILTER_SWITCHABLE: filter selection is signaled at the
>> + *				       block level
>> + *
>> + * See section '7.2.7 Interpolation filter semantics' of the VP9 specification
>> + * for more details.
>> + */
>> +enum v4l2_vp9_interpolation_filter {
>> +	V4L2_VP9_INTERP_FILTER_8TAP,
>> +	V4L2_VP9_INTERP_FILTER_8TAP_SMOOTH,
>> +	V4L2_VP9_INTERP_FILTER_8TAP_SHARP,
>> +	V4L2_VP9_INTERP_FILTER_BILINEAR,
>> +	V4L2_VP9_INTERP_FILTER_SWITCHABLE,
>> +};
>> +
>> +/**
>> + * enum v4l2_vp9_reference_mode - VP9 reference modes
>> + *
>> + * @V4L2_VP9_REF_MODE_SINGLE: indicates that all the inter blocks use only a
>> + *			      single reference frame to generate motion
>> + *			      compensated prediction
>> + * @V4L2_VP9_REF_MODE_COMPOUND: requires all the inter blocks to use compound
>> + *				mode. Single reference frame prediction is not
>> + *				allowed
>> + * @V4L2_VP9_REF_MODE_SELECT: allows each individual inter block to select
>> + *			      between single and compound prediction modes
>> + *
>> + * See section '7.3.6 Frame reference mode semantics' of the VP9 specification
>> + * for more details.
>> + */
>> +enum v4l2_vp9_reference_mode {
>> +	V4L2_VP9_REF_MODE_SINGLE,
>> +	V4L2_VP9_REF_MODE_COMPOUND,
>> +	V4L2_VP9_REF_MODE_SELECT,
>> +};
>> +
>> +/**
>> + * enum v4l2_vp9_tx_mode - VP9 TX modes
>> + *
>> + * @V4L2_VP9_TX_MODE_ONLY_4X4: transform size is 4x4
>> + * @V4L2_VP9_TX_MODE_ALLOW_8X8: transform size can be up to 8x8
>> + * @V4L2_VP9_TX_MODE_ALLOW_16X16: transform size can be up to 16x16
>> + * @V4L2_VP9_TX_MODE_ALLOW_32X32: transform size can be up to 32x32
>> + * @V4L2_VP9_TX_MODE_SELECT: bitstream contains transform size for each block
>> + *
>> + * See section '7.3.1 Tx mode semantics' of the VP9 specification for more
>> + * details.
>> + */
>> +enum v4l2_vp9_tx_mode {
>> +	V4L2_VP9_TX_MODE_ONLY_4X4,
>> +	V4L2_VP9_TX_MODE_ALLOW_8X8,
>> +	V4L2_VP9_TX_MODE_ALLOW_16X16,
>> +	V4L2_VP9_TX_MODE_ALLOW_32X32,
>> +	V4L2_VP9_TX_MODE_SELECT,
>> +};
>> +
>> +/**
>> + * enum v4l2_vp9_ref_id - VP9 Reference frame IDs
>> + *
>> + * @V4L2_REF_ID_LAST: last reference frame
>> + * @V4L2_REF_ID_GOLDEN: golden reference frame
>> + * @V4L2_REF_ID_ALTREF: alternative reference frame
>> + * @V4L2_REF_ID_CNT: number of reference frames
>> + *
>> + * See section '7.4.12 Ref frames semantics' of the VP9 specification for more
>> + * details.
>> + */
>> +enum v4l2_vp9_ref_id {
>> +	V4L2_REF_ID_LAST,
>> +	V4L2_REF_ID_GOLDEN,
>> +	V4L2_REF_ID_ALTREF,
>> +	V4L2_REF_ID_CNT,
>> +};
>> +
>> +/**
>> + * enum v4l2_vp9_frame_flags - VP9 frame flags
>> + * @V4L2_VP9_FRAME_FLAG_KEY_FRAME: the frame is a key frame
>> + * @V4L2_VP9_FRAME_FLAG_SHOW_FRAME: the frame should be displayed
>> + * @V4L2_VP9_FRAME_FLAG_ERROR_RESILIENT: the decoding should be error resilient
>> + * @V4L2_VP9_FRAME_FLAG_INTRA_ONLY: the frame does not reference other frames
>> + * @V4L2_VP9_FRAME_FLAG_ALLOW_HIGH_PREC_MV: the frame might can high precision
>> + *					    motion vectors
>> + * @V4L2_VP9_FRAME_FLAG_REFRESH_FRAME_CTX: frame context should be updated
>> + *					   after decoding
>> + * @V4L2_VP9_FRAME_FLAG_PARALLEL_DEC_MODE: parallel decoding is used
>> + * @V4L2_VP9_FRAME_FLAG_X_SUBSAMPLING: vertical subsampling is enabled
>> + * @V4L2_VP9_FRAME_FLAG_Y_SUBSAMPLING: horizontal subsampling is enabled
>> + * @V4L2_VP9_FRAME_FLAG_COLOR_RANGE_FULL_SWING: full UV range is used
>> + *
>> + * Check the VP9 specification for more details.
>> + */
>> +enum v4l2_vp9_frame_flags {
>> +	V4L2_VP9_FRAME_FLAG_KEY_FRAME = 1 << 0,
>> +	V4L2_VP9_FRAME_FLAG_SHOW_FRAME = 1 << 1,
>> +	V4L2_VP9_FRAME_FLAG_ERROR_RESILIENT = 1 << 2,
>> +	V4L2_VP9_FRAME_FLAG_INTRA_ONLY = 1 << 3,
>> +	V4L2_VP9_FRAME_FLAG_ALLOW_HIGH_PREC_MV = 1 << 4,
>> +	V4L2_VP9_FRAME_FLAG_REFRESH_FRAME_CTX = 1 << 5,
>> +	V4L2_VP9_FRAME_FLAG_PARALLEL_DEC_MODE = 1 << 6,
>> +	V4L2_VP9_FRAME_FLAG_X_SUBSAMPLING = 1 << 7,
>> +	V4L2_VP9_FRAME_FLAG_Y_SUBSAMPLING = 1 << 8,
>> +	V4L2_VP9_FRAME_FLAG_COLOR_RANGE_FULL_SWING = 1 << 9,
>> +};
>> +
>> +#define V4L2_VP9_PROFILE_MAX		3
>> +
>> +#define V4L2_CID_STATELESS_VP9_FRAME_DECODE_PARAMS	(V4L2_CID_CODEC_STATELESS_BASE + 300)
>> +/**
>> + * struct v4l2_ctrl_vp9_frame_decode_params - VP9 frame decoding control
>> + *
>> + * @flags: combination of V4L2_VP9_FRAME_FLAG_* flags
>> + * @compressed_header_size: compressed header size in bytes
>> + * @uncompressed_header_size: uncompressed header size in bytes
>> + * @profile: VP9 profile. Can be 0, 1, 2 or 3
>> + * @reset_frame_context: specifies whether the frame context should be reset
>> + *			 to default values. See &v4l2_vp9_reset_frame_context
>> + *			 for more details
>> + * @frame_context_idx: frame context that should be used/updated
>> + * @bit_depth: bits per components. Can be 8, 10 or 12. Note that not all
>> + *	       profiles support 10 and/or 12 bits depths
>> + * @interpolation_filter: specifies the filter selection used for performing
>> + *			  inter prediction. See &v4l2_vp9_interpolation_filter
>> + *			  for more details
>> + * @tile_cols_log2: specifies the base 2 logarithm of the width of each tile
>> + *		    (where the width is measured in units of 8x8 blocks).
>> + *		    Shall be less than or equal to 6
>> + * @tile_rows_log2: specifies the base 2 logarithm of the height of each tile
>> + *		    (where the height is measured in units of 8x8 blocks)
>> + * @tx_mode: specifies the TX mode. See &v4l2_vp9_tx_mode for more details
>> + * @reference_mode: specifies the type of inter prediction to be used. See
>> + *		    &v4l2_vp9_reference_mode for more details
>> + * @padding: needed to make this struct 64 bit aligned. Shall be filled with
>> + *	     zeros
>> + * @frame_width_minus_1: add 1 to it and you'll get the frame width expressed
>> + *			 in pixels
>> + * @frame_height_minus_1: add 1 to it and you'll get the frame height expressed
>> + *			  in pixels
>> + * @render_width_minus_1: add 1 to it and you'll get the expected render width
>> + *			 expressed in pixels. This is not used during the
>> + *			 decoding process but might be used by HW scalers to
>> + *			 prepare a frame that's ready for scanout
>> + * @render_height_minus_1: add 1 to it and you'll get the expected render height
>> + *			 expressed in pixels. This is not used during the
>> + *			 decoding process but might be used by HW scalers to
>> + *			 prepare a frame that's ready for scanout
>> + * @refs: array of ref frames timestamps. See &v4l2_vp9_ref_id for more details
>> + * @ref_frame_sign_bias: array of reference frames motion vector sign bias
>> + *			(prediction direction)
>> + * @lf: loop filter parameters. See &v4l2_vp9_loop_filter for more details
>> + * @quant: quantization parameters. See &v4l2_vp9_quantization for more details
>> + * @seg: segmentation parameters. See &v4l2_vp9_segmentation for more details
>> + */
>> +struct v4l2_ctrl_vp9_frame_decode_params {
>> +	__u32 flags;
>> +	__u16 compressed_header_size;
>> +	__u16 uncompressed_header_size;
>> +	__u8 profile;
>> +	__u8 reset_frame_context;
>> +	__u8 frame_context_idx;
>> +	__u8 bit_depth;
>> +	__u8 interpolation_filter;
>> +	__u8 tile_cols_log2;
>> +	__u8 tile_rows_log2;
>> +	__u8 tx_mode;
>> +	__u8 reference_mode;
>> +	__u8 padding[7];
>> +	__u16 frame_width_minus_1;
>> +	__u16 frame_height_minus_1;
>> +	__u16 render_width_minus_1;
>> +	__u16 render_height_minus_1;
>> +	__u64 refs[V4L2_REF_ID_CNT];
>> +	__u8 ref_frame_sign_bias[V4L2_REF_ID_CNT + 1];
>> +	struct v4l2_vp9_loop_filter lf;
>> +	struct v4l2_vp9_quantization quant;
>> +	struct v4l2_vp9_segmentation seg;
>> +};
>> +
>> +#define V4L2_VP9_NUM_FRAME_CTX	4
>> +
>> +/**
>> + * struct v4l2_vp9_mv_compressed_hdr_probs - VP9 Motion vector probability updates
>> + * @joint: motion vector joint probability updates
>> + * @sign: motion vector sign probability updates
>> + * @class: motion vector class probability updates
>> + * @class0_bit: motion vector class0 bit probability updates
>> + * @bits: motion vector bits probability updates
>> + * @class0_fr: motion vector class0 fractional bit probability updates
>> + * @fr: motion vector fractional bit probability updates
>> + * @class0_hp: motion vector class0 high precision fractional bit probability updates
>> + * @hp: motion vector high precision fractional bit probability updates
>> + *
>> + * This structure contains new values of motion vector probabilities.
>> + * A value of zero means there is no update.
> 
> 'A value of zero': do you mean that the whole struct is zeroed, or just specific
> arrays or single bytes? It's not clear to me at what level this is done.

It can be zeroed on an element-by-element basis.

> 
>> + * See `struct v4l2_vp9_prob_updates` for details.
>> + */
>> +struct v4l2_vp9_mv_compressed_hdr_probs {
>> +	__u8 joint[3];
>> +	__u8 sign[2];
>> +	__u8 class[2][10];
>> +	__u8 class0_bit[2];
>> +	__u8 bits[2][10];
>> +	__u8 class0_fr[2][2][3];
>> +	__u8 fr[2][3];
>> +	__u8 class0_hp[2];
>> +	__u8 hp[2];
>> +};
>> +
>> +#define V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS	(V4L2_CID_CODEC_STATELESS_BASE + 301)
>> +/**
>> + * struct v4l2_ctrl_vp9_compressed_hdr_probs - VP9 probability updates control
>> + * @tx8: TX 8x8 probability updates
>> + * @tx16: TX 16x16 probability updates
>> + * @tx32: TX 32x32 probability updates
>> + * @coef: coefficient probability updates
>> + * @skip: skip probability updates
>> + * @inter_mode: inter mode probability updates
>> + * @interp_filter: interpolation filter probability updates
>> + * @is_inter: is inter-block probability updates
>> + * @comp_mode: compound prediction mode probability updates
>> + * @single_ref: single ref probability updates
>> + * @comp_ref: compound ref probability updates
>> + * @y_mode: Y prediction mode probability updates
>> + * @uv_mode: UV prediction mode probability updates
>> + * @partition: partition probability updates
>> + * @mv: motion vector probability updates
>> + *
>> + * This structure holds the probabilities update as parsed in the compressed
>> + * header (Spec 6.3). These values represent the value of probability update after
>> + * being translated with inv_map_table[] (see 6.3.5). A value of zero means that
>> + * there is no update.
> 
> Same question.

Same answer :D

> 
>> + */
>> +struct v4l2_ctrl_vp9_compressed_hdr_probs {
>> +	__u8 tx8[2][1];
>> +	__u8 tx16[2][2];
>> +	__u8 tx32[2][3];
>> +	__u8 coef[4][2][2][6][6][3];
>> +	__u8 skip[3];
>> +	__u8 inter_mode[7][3];
>> +	__u8 interp_filter[4][2];
>> +	__u8 is_inter[4];
>> +	__u8 comp_mode[5];
>> +	__u8 single_ref[5][2];
>> +	__u8 comp_ref[5];
>> +	__u8 y_mode[4][9];
>> +	__u8 uv_mode[10][9];
>> +	__u8 partition[16][3];
>> +
>> +	struct v4l2_vp9_mv_compressed_hdr_probs mv;
>> +};
>> +
>>   /* MPEG-compression definitions kept for backwards compatibility */
>>   #ifndef __KERNEL__
>>   #define V4L2_CTRL_CLASS_MPEG            V4L2_CTRL_CLASS_CODEC
>> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
>> index 311a01cc5775..508e2d6825b1 100644
>> --- a/include/uapi/linux/videodev2.h
>> +++ b/include/uapi/linux/videodev2.h
>> @@ -697,6 +697,7 @@ struct v4l2_pix_format {
>>   #define V4L2_PIX_FMT_VP8      v4l2_fourcc('V', 'P', '8', '0') /* VP8 */
>>   #define V4L2_PIX_FMT_VP8_FRAME v4l2_fourcc('V', 'P', '8', 'F') /* VP8 parsed frame */
>>   #define V4L2_PIX_FMT_VP9      v4l2_fourcc('V', 'P', '9', '0') /* VP9 */
>> +#define V4L2_PIX_FMT_VP9_FRAME v4l2_fourcc('V', 'P', '9', 'F') /* VP9 parsed frame */
>>   #define V4L2_PIX_FMT_HEVC     v4l2_fourcc('H', 'E', 'V', 'C') /* HEVC aka H.265 */
>>   #define V4L2_PIX_FMT_FWHT     v4l2_fourcc('F', 'W', 'H', 'T') /* Fast Walsh Hadamard Transform (vicodec) */
>>   #define V4L2_PIX_FMT_FWHT_STATELESS     v4l2_fourcc('S', 'F', 'W', 'H') /* Stateless FWHT (vicodec) */
>> @@ -1747,6 +1748,8 @@ struct v4l2_ext_control {
>>   		struct v4l2_ctrl_h264_decode_params __user *p_h264_decode_params;
>>   		struct v4l2_ctrl_fwht_params __user *p_fwht_params;
>>   		struct v4l2_ctrl_vp8_frame __user *p_vp8_frame;
>> +		struct v4l2_ctrl_vp9_compressed_hdr_probs __user *p_vp9_compressed_hdr_probs;
>> +		struct v4l2_ctrl_vp9_frame_decode_params __user *p_vp9_frame_decode_params;
>>   		void __user *ptr;
>>   	};
>>   } __attribute__ ((packed));
>> @@ -1807,6 +1810,9 @@ enum v4l2_ctrl_type {
>>   	V4L2_CTRL_TYPE_FWHT_PARAMS	    = 0x0220,
>>   
>>   	V4L2_CTRL_TYPE_VP8_FRAME            = 0x0240,
>> +
>> +	V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR_PROBS	= 0x0260,
>> +	V4L2_CTRL_TYPE_VP9_FRAME_DECODE_PARAMS	= 0x0261,
>>   };
>>   
>>   /*  Used in the VIDIOC_QUERYCTRL ioctl for querying controls */
>>
> 
> Regards,
> 
> 	Hans
> 

Re: [RFC RESEND 2/3] media: uapi: Add VP9 stateless decoder controls

[Nicolas Dufresne]

Hi Hans,

just a partial reply, I'll let Andrzej extend.

Le jeudi 29 avril 2021 à 12:20 +0200, Hans Verkuil a écrit :
> > +      - ``frame_width_minus_1``
> > +      - Add 1 to get the frame width expressed in pixels.
> > +    * - __u16
> > +      - ``frame_height_minus_1``
> > +      - Add 1 to get the frame height expressed in pixels.
> 
> These two fields are weird. Isn't this defined by setting the output format?
> And why the 'minus_1'?
> 
> > +    * - __u16
> > +      - ``render_width_minus_1``
> > +      - Add 1 to get the expected render width expressed in pixels. This is
> > +        not used during the decoding process but might be used by HW
> > scalers to
> > +        prepare a frame that's ready for scanout.
> > +    * - __u16
> > +      - render_height_minus_1
> > +      - Add 1 to get the expected render height expressed in pixels. This
> > is
> > +        not used during the decoding process but might be used by HW
> > scalers to
> > +        prepare a frame that's ready for scanout.
> 
> No idea what these fields are about. I suspect this can be defined by setting
> the capture format, but I'm not sure.

We have the same for other codecs. Each codec bitstream include the coded and
the display size in some form. For H264/H265 that was passed as as number of
macroblock and a crop rectangle. For VP9 value - 1 is as defined in the spec. As
0 is not valid, the boolean coder can save some bits when storing the value.
Though, for parameters, we usually start with the way it's encoded first, and
change it only if we think it make sense. We'll take note and consider this
whenever we have a second driver to look at.

Now, why do we include both here. Well in fact, the HW may have some extra
constraints. Which means there will be up to 3 frame sizes that matters. We
can't also determine if the display/render or coded size will be used for minim
CAPTURE format, as this will in fact depends if a post processor will be used or
not. 

So to recap, we limit the CAPTURE format base on this information, and not the
opposite. The width/height on OUTPUT FMT has been define as meaningless in the
spec (to align with stateful I suppose ?). This way, the driver got all the
information aligned with how it works inside the codec, without having to do a
translation dance, and then properly implement CAPTURE TRY_FMT base on that.

To make an analogy with stateful codec, this replaces the queuing of a frame
that contains codec headers. We skip the SRC_CH events, since this is no longer
asynchronous.

Nicolas

[RFC RESEND 3/3] media: rkvdec: Add the VP9 backend

[Andrzej Pietrasiewicz]

From: Boris Brezillon <boris.brezillon@collabora.com>

The Rockchip VDEC supports VP9 profile 0 up to 4096x2304@30fps. Add
a backend for this new format.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
---
 drivers/staging/media/rkvdec/Makefile     |    2 +-
 drivers/staging/media/rkvdec/rkvdec-vp9.c | 2846 +++++++++++++++++++++
 drivers/staging/media/rkvdec/rkvdec.c     |   52 +-
 drivers/staging/media/rkvdec/rkvdec.h     |    6 +
 4 files changed, 2901 insertions(+), 5 deletions(-)
 create mode 100644 drivers/staging/media/rkvdec/rkvdec-vp9.c

diff --git a/drivers/staging/media/rkvdec/Makefile b/drivers/staging/media/rkvdec/Makefile
index c08fed0a39f9..cb86b429cfaa 100644
--- a/drivers/staging/media/rkvdec/Makefile
+++ b/drivers/staging/media/rkvdec/Makefile
@@ -1,3 +1,3 @@
 obj-$(CONFIG_VIDEO_ROCKCHIP_VDEC) += rockchip-vdec.o
 
-rockchip-vdec-y += rkvdec.o rkvdec-h264.o
+rockchip-vdec-y += rkvdec.o rkvdec-h264.o rkvdec-vp9.o
diff --git a/drivers/staging/media/rkvdec/rkvdec-vp9.c b/drivers/staging/media/rkvdec/rkvdec-vp9.c
new file mode 100644
index 000000000000..82e5dcfe5ef0
--- /dev/null
+++ b/drivers/staging/media/rkvdec/rkvdec-vp9.c
@@ -0,0 +1,2846 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Rockchip Video Decoder VP9 backend
+ *
+ * Copyright (C) 2019 Collabora, Ltd.
+ *	Boris Brezillon <boris.brezillon@collabora.com>
+ * Copyright (C) 2021 Collabora, Ltd.
+ *	Andrzej Pietrasiewicz <andrzej.p@collabora.com>
+ *
+ * Copyright (C) 2016 Rockchip Electronics Co., Ltd.
+ *	Alpha Lin <Alpha.Lin@rock-chips.com>
+ */
+
+/*
+ * For following the vp9 spec please start reading this driver
+ * code from rkvdec_vp9_run() followed by rkvdec_vp9_done().
+ */
+
+#include <linux/kernel.h>
+#include <linux/vmalloc.h>
+#include <media/v4l2-mem2mem.h>
+
+#include "rkvdec.h"
+#include "rkvdec-regs.h"
+
+#define RKVDEC_VP9_PROBE_SIZE		4864
+#define RKVDEC_VP9_COUNT_SIZE		13232
+#define RKVDEC_VP9_MAX_SEGMAP_SIZE	73728
+
+struct rkvdec_vp9_intra_mode_probs {
+	u8 y_mode[105];
+	u8 uv_mode[23];
+};
+
+struct rkvdec_vp9_intra_only_frame_probs {
+	u8 coef_intra[4][2][128];
+	struct rkvdec_vp9_intra_mode_probs intra_mode[10];
+};
+
+struct rkvdec_vp9_inter_frame_probs {
+	u8 y_mode[4][9];
+	u8 comp_mode[5];
+	u8 comp_ref[5];
+	u8 single_ref[5][2];
+	u8 inter_mode[7][3];
+	u8 interp_filter[4][2];
+	u8 padding0[11];
+	u8 coef[2][4][2][128];
+	u8 uv_mode_0_2[3][9];
+	u8 padding1[5];
+	u8 uv_mode_3_5[3][9];
+	u8 padding2[5];
+	u8 uv_mode_6_8[3][9];
+	u8 padding3[5];
+	u8 uv_mode_9[9];
+	u8 padding4[7];
+	u8 padding5[16];
+	struct {
+		u8 joint[3];
+		u8 sign[2];
+		u8 class[2][10];
+		u8 class0_bit[2];
+		u8 bits[2][10];
+		u8 class0_fr[2][2][3];
+		u8 fr[2][3];
+		u8 class0_hp[2];
+		u8 hp[2];
+	} mv;
+};
+
+struct rkvdec_vp9_probs {
+	u8 partition[16][3];
+	u8 pred[3];
+	u8 tree[7];
+	u8 skip[3];
+	u8 tx32[2][3];
+	u8 tx16[2][2];
+	u8 tx8[2][1];
+	u8 is_inter[4];
+	/* 128 bit alignment */
+	u8 padding0[3];
+	union {
+		struct rkvdec_vp9_inter_frame_probs inter;
+		struct rkvdec_vp9_intra_only_frame_probs intra_only;
+	};
+};
+
+/* Data structure describing auxiliary buffer format. */
+struct rkvdec_vp9_priv_tbl {
+	struct rkvdec_vp9_probs probs;
+	u8 segmap[2][RKVDEC_VP9_MAX_SEGMAP_SIZE];
+};
+
+struct rkvdec_vp9_refs_counts {
+	u32 eob[2];
+	u32 coeff[3];
+};
+
+struct rkvdec_vp9_inter_frame_symbol_counts {
+	u32 partition[16][4];
+	u32 skip[3][2];
+	u32 inter[4][2];
+	u32 tx32p[2][4];
+	u32 tx16p[2][4];
+	u32 tx8p[2][2];
+	u32 y_mode[4][10];
+	u32 uv_mode[10][10];
+	u32 comp[5][2];
+	u32 comp_ref[5][2];
+	u32 single_ref[5][2][2];
+	u32 mv_mode[7][4];
+	u32 filter[4][3];
+	u32 mv_joint[4];
+	u32 sign[2][2];
+	/* add 1 element for align */
+	u32 classes[2][11 + 1];
+	u32 class0[2][2];
+	u32 bits[2][10][2];
+	u32 class0_fp[2][2][4];
+	u32 fp[2][4];
+	u32 class0_hp[2][2];
+	u32 hp[2][2];
+	struct rkvdec_vp9_refs_counts ref_cnt[2][4][2][6][6];
+};
+
+struct rkvdec_vp9_intra_frame_symbol_counts {
+	u32 partition[4][4][4];
+	u32 skip[3][2];
+	u32 intra[4][2];
+	u32 tx32p[2][4];
+	u32 tx16p[2][4];
+	u32 tx8p[2][2];
+	struct rkvdec_vp9_refs_counts ref_cnt[2][4][2][6][6];
+};
+
+struct rkvdec_vp9_run {
+	struct rkvdec_run base;
+	const struct v4l2_ctrl_vp9_frame_decode_params *decode_params;
+};
+
+struct rkvdec_vp9_frame_info {
+	u32 valid : 1;
+	u32 segmapid : 1;
+	u32 frame_context_idx : 2;
+	u32 reference_mode : 2;
+	u32 tx_mode : 3;
+	u32 interpolation_filter : 3;
+	u32 flags;
+	u64 timestamp;
+	struct v4l2_vp9_segmentation seg;
+	struct v4l2_vp9_loop_filter lf;
+};
+
+struct rkvdec_vp9_frame_mv_context {
+	u8 joint[3];
+	u8 sign[2];
+	u8 class[2][10];
+	u8 class0_bit[2];
+	u8 bits[2][10];
+	u8 class0_fr[2][2][3];
+	u8 fr[2][3];
+	u8 class0_hp[2];
+	u8 hp[2];
+};
+
+struct rkvdec_vp9_frame_context {
+	u8 tx8[2][1];
+	u8 tx16[2][2];
+	u8 tx32[2][3];
+	u8 coef[4][2][2][6][6][3];
+	u8 skip[3];
+	u8 inter_mode[7][3];
+	u8 interp_filter[4][2];
+	u8 is_inter[4];
+	u8 comp_mode[5];
+	u8 single_ref[5][2];
+	u8 comp_ref[5];
+	u8 y_mode[4][9];
+	u8 uv_mode[10][9];
+	u8 partition[16][3];
+
+	struct rkvdec_vp9_frame_mv_context mv;
+};
+
+struct rkvdec_vp9_ctx {
+	struct rkvdec_aux_buf priv_tbl;
+	struct rkvdec_aux_buf count_tbl;
+	struct rkvdec_vp9_frame_context probability_tables;
+	struct rkvdec_vp9_frame_context frame_context[4];
+	struct rkvdec_vp9_frame_info cur;
+	struct rkvdec_vp9_frame_info last;
+};
+
+static u32 rkvdec_fastdiv(u32 dividend, u16 divisor)
+{
+#define DIV_INV(d)	((u32)(((1ULL << 32) + ((d) - 1)) / (d)))
+#define DIVS_INV(d0, d1, d2, d3, d4, d5, d6, d7, d8, d9)	\
+	DIV_INV(d0), DIV_INV(d1), DIV_INV(d2), DIV_INV(d3),	\
+	DIV_INV(d4), DIV_INV(d5), DIV_INV(d6), DIV_INV(d7),	\
+	DIV_INV(d8), DIV_INV(d9)
+
+	static const u32 inv[] = {
+		DIV_INV(2), DIV_INV(3), DIV_INV(4), DIV_INV(5),
+		DIV_INV(6), DIV_INV(7), DIV_INV(8), DIV_INV(9),
+		DIVS_INV(10, 11, 12, 13, 14, 15, 16, 17, 18, 19),
+		DIVS_INV(20, 21, 22, 23, 24, 25, 26, 27, 28, 29),
+		DIVS_INV(30, 31, 32, 33, 34, 35, 36, 37, 38, 39),
+		DIVS_INV(40, 41, 42, 43, 44, 45, 46, 47, 48, 49),
+		DIVS_INV(50, 51, 52, 53, 54, 55, 56, 57, 58, 59),
+		DIVS_INV(60, 61, 62, 63, 64, 65, 66, 67, 68, 69),
+		DIVS_INV(70, 71, 72, 73, 74, 75, 76, 77, 78, 79),
+		DIVS_INV(80, 81, 82, 83, 84, 85, 86, 87, 88, 89),
+		DIVS_INV(90, 91, 92, 93, 94, 95, 96, 97, 98, 99),
+		DIVS_INV(100, 101, 102, 103, 104, 105, 106, 107, 108, 109),
+		DIVS_INV(110, 111, 112, 113, 114, 115, 116, 117, 118, 119),
+		DIVS_INV(120, 121, 122, 123, 124, 125, 126, 127, 128, 129),
+		DIVS_INV(130, 131, 132, 133, 134, 135, 136, 137, 138, 139),
+		DIVS_INV(140, 141, 142, 143, 144, 145, 146, 147, 148, 149),
+		DIVS_INV(150, 151, 152, 153, 154, 155, 156, 157, 158, 159),
+		DIVS_INV(160, 161, 162, 163, 164, 165, 166, 167, 168, 169),
+		DIVS_INV(170, 171, 172, 173, 174, 175, 176, 177, 178, 179),
+		DIVS_INV(180, 181, 182, 183, 184, 185, 186, 187, 188, 189),
+		DIVS_INV(190, 191, 192, 193, 194, 195, 196, 197, 198, 199),
+		DIVS_INV(200, 201, 202, 203, 204, 205, 206, 207, 208, 209),
+		DIVS_INV(210, 211, 212, 213, 214, 215, 216, 217, 218, 219),
+		DIVS_INV(220, 221, 222, 223, 224, 225, 226, 227, 228, 229),
+		DIVS_INV(230, 231, 232, 233, 234, 235, 236, 237, 238, 239),
+		DIVS_INV(240, 241, 242, 243, 244, 245, 246, 247, 248, 249),
+		DIV_INV(250), DIV_INV(251), DIV_INV(252), DIV_INV(253),
+		DIV_INV(254), DIV_INV(255), DIV_INV(256),
+	};
+
+	if (divisor == 0)
+		return 0;
+	else if (divisor == 1)
+		return dividend;
+
+	if (WARN_ON(divisor - 2 >= ARRAY_SIZE(inv)))
+		return dividend;
+
+	return ((u64)dividend * inv[divisor - 2]) >> 32;
+}
+
+static const u8 vp9_kf_y_mode_prob[10][10][9] = {
+	{
+		/* above = dc */
+		{ 137,  30,  42, 148, 151, 207,  70,  52,  91 },/*left = dc  */
+		{  92,  45, 102, 136, 116, 180,  74,  90, 100 },/*left = v   */
+		{  73,  32,  19, 187, 222, 215,  46,  34, 100 },/*left = h   */
+		{  91,  30,  32, 116, 121, 186,  93,  86,  94 },/*left = d45 */
+		{  72,  35,  36, 149,  68, 206,  68,  63, 105 },/*left = d135*/
+		{  73,  31,  28, 138,  57, 124,  55, 122, 151 },/*left = d117*/
+		{  67,  23,  21, 140, 126, 197,  40,  37, 171 },/*left = d153*/
+		{  86,  27,  28, 128, 154, 212,  45,  43,  53 },/*left = d207*/
+		{  74,  32,  27, 107,  86, 160,  63, 134, 102 },/*left = d63 */
+		{  59,  67,  44, 140, 161, 202,  78,  67, 119 } /*left = tm  */
+	}, {  /* above = v */
+		{  63,  36, 126, 146, 123, 158,  60,  90,  96 },/*left = dc  */
+		{  43,  46, 168, 134, 107, 128,  69, 142,  92 },/*left = v   */
+		{  44,  29,  68, 159, 201, 177,  50,  57,  77 },/*left = h   */
+		{  58,  38,  76, 114,  97, 172,  78, 133,  92 },/*left = d45 */
+		{  46,  41,  76, 140,  63, 184,  69, 112,  57 },/*left = d135*/
+		{  38,  32,  85, 140,  46, 112,  54, 151, 133 },/*left = d117*/
+		{  39,  27,  61, 131, 110, 175,  44,  75, 136 },/*left = d153*/
+		{  52,  30,  74, 113, 130, 175,  51,  64,  58 },/*left = d207*/
+		{  47,  35,  80, 100,  74, 143,  64, 163,  74 },/*left = d63 */
+		{  36,  61, 116, 114, 128, 162,  80, 125,  82 } /*left = tm  */
+	}, {  /* above = h */
+		{  82,  26,  26, 171, 208, 204,  44,  32, 105 },/*left = dc  */
+		{  55,  44,  68, 166, 179, 192,  57,  57, 108 },/*left = v   */
+		{  42,  26,  11, 199, 241, 228,  23,  15,  85 },/*left = h   */
+		{  68,  42,  19, 131, 160, 199,  55,  52,  83 },/*left = d45 */
+		{  58,  50,  25, 139, 115, 232,  39,  52, 118 },/*left = d135*/
+		{  50,  35,  33, 153, 104, 162,  64,  59, 131 },/*left = d117*/
+		{  44,  24,  16, 150, 177, 202,  33,  19, 156 },/*left = d153*/
+		{  55,  27,  12, 153, 203, 218,  26,  27,  49 },/*left = d207*/
+		{  53,  49,  21, 110, 116, 168,  59,  80,  76 },/*left = d63 */
+		{  38,  72,  19, 168, 203, 212,  50,  50, 107 } /*left = tm  */
+	}, {  /* above = d45 */
+		{ 103,  26,  36, 129, 132, 201,  83,  80,  93 },/*left = dc  */
+		{  59,  38,  83, 112, 103, 162,  98, 136,  90 },/*left = v   */
+		{  62,  30,  23, 158, 200, 207,  59,  57,  50 },/*left = h   */
+		{  67,  30,  29,  84,  86, 191, 102,  91,  59 },/*left = d45 */
+		{  60,  32,  33, 112,  71, 220,  64,  89, 104 },/*left = d135*/
+		{  53,  26,  34, 130,  56, 149,  84, 120, 103 },/*left = d117*/
+		{  53,  21,  23, 133, 109, 210,  56,  77, 172 },/*left = d153*/
+		{  77,  19,  29, 112, 142, 228,  55,  66,  36 },/*left = d207*/
+		{  61,  29,  29,  93,  97, 165,  83, 175, 162 },/*left = d63 */
+		{  47,  47,  43, 114, 137, 181, 100,  99,  95 } /*left = tm  */
+	}, {  /* above = d135 */
+		{  69,  23,  29, 128,  83, 199,  46,  44, 101 },/*left = dc  */
+		{  53,  40,  55, 139,  69, 183,  61,  80, 110 },/*left = v   */
+		{  40,  29,  19, 161, 180, 207,  43,  24,  91 },/*left = h   */
+		{  60,  34,  19, 105,  61, 198,  53,  64,  89 },/*left = d45 */
+		{  52,  31,  22, 158,  40, 209,  58,  62,  89 },/*left = d135*/
+		{  44,  31,  29, 147,  46, 158,  56, 102, 198 },/*left = d117*/
+		{  35,  19,  12, 135,  87, 209,  41,  45, 167 },/*left = d153*/
+		{  55,  25,  21, 118,  95, 215,  38,  39,  66 },/*left = d207*/
+		{  51,  38,  25, 113,  58, 164,  70,  93,  97 },/*left = d63 */
+		{  47,  54,  34, 146, 108, 203,  72, 103, 151 } /*left = tm  */
+	}, {  /* above = d117 */
+		{  64,  19,  37, 156,  66, 138,  49,  95, 133 },/*left = dc  */
+		{  46,  27,  80, 150,  55, 124,  55, 121, 135 },/*left = v   */
+		{  36,  23,  27, 165, 149, 166,  54,  64, 118 },/*left = h   */
+		{  53,  21,  36, 131,  63, 163,  60, 109,  81 },/*left = d45 */
+		{  40,  26,  35, 154,  40, 185,  51,  97, 123 },/*left = d135*/
+		{  35,  19,  34, 179,  19,  97,  48, 129, 124 },/*left = d117*/
+		{  36,  20,  26, 136,  62, 164,  33,  77, 154 },/*left = d153*/
+		{  45,  18,  32, 130,  90, 157,  40,  79,  91 },/*left = d207*/
+		{  45,  26,  28, 129,  45, 129,  49, 147, 123 },/*left = d63 */
+		{  38,  44,  51, 136,  74, 162,  57,  97, 121 } /*left = tm  */
+	}, {  /* above = d153 */
+		{  75,  17,  22, 136, 138, 185,  32,  34, 166 },/*left = dc  */
+		{  56,  39,  58, 133, 117, 173,  48,  53, 187 },/*left = v   */
+		{  35,  21,  12, 161, 212, 207,  20,  23, 145 },/*left = h   */
+		{  56,  29,  19, 117, 109, 181,  55,  68, 112 },/*left = d45 */
+		{  47,  29,  17, 153,  64, 220,  59,  51, 114 },/*left = d135*/
+		{  46,  16,  24, 136,  76, 147,  41,  64, 172 },/*left = d117*/
+		{  34,  17,  11, 108, 152, 187,  13,  15, 209 },/*left = d153*/
+		{  51,  24,  14, 115, 133, 209,  32,  26, 104 },/*left = d207*/
+		{  55,  30,  18, 122,  79, 179,  44,  88, 116 },/*left = d63 */
+		{  37,  49,  25, 129, 168, 164,  41,  54, 148 } /*left = tm  */
+	}, {  /* above = d207 */
+		{  82,  22,  32, 127, 143, 213,  39,  41,  70 },/*left = dc  */
+		{  62,  44,  61, 123, 105, 189,  48,  57,  64 },/*left = v   */
+		{  47,  25,  17, 175, 222, 220,  24,  30,  86 },/*left = h   */
+		{  68,  36,  17, 106, 102, 206,  59,  74,  74 },/*left = d45 */
+		{  57,  39,  23, 151,  68, 216,  55,  63,  58 },/*left = d135*/
+		{  49,  30,  35, 141,  70, 168,  82,  40, 115 },/*left = d117*/
+		{  51,  25,  15, 136, 129, 202,  38,  35, 139 },/*left = d153*/
+		{  68,  26,  16, 111, 141, 215,  29,  28,  28 },/*left = d207*/
+		{  59,  39,  19, 114,  75, 180,  77, 104,  42 },/*left = d63 */
+		{  40,  61,  26, 126, 152, 206,  61,  59,  93 } /*left = tm  */
+	}, {  /* above = d63 */
+		{  78,  23,  39, 111, 117, 170,  74, 124,  94 },/*left = dc  */
+		{  48,  34,  86, 101,  92, 146,  78, 179, 134 },/*left = v   */
+		{  47,  22,  24, 138, 187, 178,  68,  69,  59 },/*left = h   */
+		{  56,  25,  33, 105, 112, 187,  95, 177, 129 },/*left = d45 */
+		{  48,  31,  27, 114,  63, 183,  82, 116,  56 },/*left = d135*/
+		{  43,  28,  37, 121,  63, 123,  61, 192, 169 },/*left = d117*/
+		{  42,  17,  24, 109,  97, 177,  56,  76, 122 },/*left = d153*/
+		{  58,  18,  28, 105, 139, 182,  70,  92,  63 },/*left = d207*/
+		{  46,  23,  32,  74,  86, 150,  67, 183,  88 },/*left = d63 */
+		{  36,  38,  48,  92, 122, 165,  88, 137,  91 } /*left = tm  */
+	}, {  /* above = tm */
+		{  65,  70,  60, 155, 159, 199,  61,  60,  81 },/*left = dc  */
+		{  44,  78, 115, 132, 119, 173,  71, 112,  93 },/*left = v   */
+		{  39,  38,  21, 184, 227, 206,  42,  32,  64 },/*left = h   */
+		{  58,  47,  36, 124, 137, 193,  80,  82,  78 },/*left = d45 */
+		{  49,  50,  35, 144,  95, 205,  63,  78,  59 },/*left = d135*/
+		{  41,  53,  52, 148,  71, 142,  65, 128,  51 },/*left = d117*/
+		{  40,  36,  28, 143, 143, 202,  40,  55, 137 },/*left = d153*/
+		{  52,  34,  29, 129, 183, 227,  42,  35,  43 },/*left = d207*/
+		{  42,  44,  44, 104, 105, 164,  64, 130,  80 },/*left = d63 */
+		{  43,  81,  53, 140, 169, 204,  68,  84,  72 } /*left = tm  */
+	}
+};
+
+static const u8 kf_partition_probs[16][3] = {
+	/* 8x8 -> 4x4 */
+	{ 158,  97,  94 },	/* a/l both not split   */
+	{  93,  24,  99 },	/* a split, l not split */
+	{  85, 119,  44 },	/* l split, a not split */
+	{  62,  59,  67 },	/* a/l both split       */
+	/* 16x16 -> 8x8 */
+	{ 149,  53,  53 },	/* a/l both not split   */
+	{  94,  20,  48 },	/* a split, l not split */
+	{  83,  53,  24 },	/* l split, a not split */
+	{  52,  18,  18 },	/* a/l both split       */
+	/* 32x32 -> 16x16 */
+	{ 150,  40,  39 },	/* a/l both not split   */
+	{  78,  12,  26 },	/* a split, l not split */
+	{  67,  33,  11 },	/* l split, a not split */
+	{  24,   7,   5 },	/* a/l both split       */
+	/* 64x64 -> 32x32 */
+	{ 174,  35,  49 },	/* a/l both not split   */
+	{  68,  11,  27 },	/* a split, l not split */
+	{  57,  15,   9 },	/* l split, a not split */
+	{  12,   3,   3 },	/* a/l both split       */
+};
+
+static const u8 kf_uv_mode_prob[10][9] = {
+	{ 144,  11,  54, 157, 195, 130,  46,  58, 108 },  /* y = dc   */
+	{ 118,  15, 123, 148, 131, 101,  44,  93, 131 },  /* y = v    */
+	{ 113,  12,  23, 188, 226, 142,  26,  32, 125 },  /* y = h    */
+	{ 120,  11,  50, 123, 163, 135,  64,  77, 103 },  /* y = d45  */
+	{ 113,   9,  36, 155, 111, 157,  32,  44, 161 },  /* y = d135 */
+	{ 116,   9,  55, 176,  76,  96,  37,  61, 149 },  /* y = d117 */
+	{ 115,   9,  28, 141, 161, 167,  21,  25, 193 },  /* y = d153 */
+	{ 120,  12,  32, 145, 195, 142,  32,  38,  86 },  /* y = d207 */
+	{ 116,  12,  64, 120, 140, 125,  49, 115, 121 },  /* y = d63  */
+	{ 102,  19,  66, 162, 182, 122,  35,  59, 128 }   /* y = tm   */
+};
+
+static const struct rkvdec_vp9_frame_context vp9_default_probs = {
+	.tx8 = {
+		{ 100 },
+		{  66 },
+	},
+	.tx16 = {
+		{ 20, 152 },
+		{ 15, 101 },
+	},
+	.tx32 = {
+		{ 3, 136, 37 },
+		{ 5,  52, 13 },
+	},
+	.coef = {
+		{ /* tx = 4x4 */
+			{ /* block Type 0 */
+				{ /* Intra */
+					{ /* Coeff Band 0 */
+						{ 195,  29, 183 },
+						{  84,  49, 136 },
+						{   8,  42,  71 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+					},
+					{ /* Coeff Band 1 */
+						{  31, 107, 169 },
+						{  35,  99, 159 },
+						{  17,  82, 140 },
+						{   8,  66, 114 },
+						{   2,  44,  76 },
+						{   1,  19,  32 },
+					},
+					{ /* Coeff Band 2 */
+						{  40, 132, 201 },
+						{  29, 114, 187 },
+						{  13,  91, 157 },
+						{   7,  75, 127 },
+						{   3,  58,  95 },
+						{   1,  28,  47 },
+					},
+					{ /* Coeff Band 3 */
+						{  69, 142, 221 },
+						{  42, 122, 201 },
+						{  15,  91, 159 },
+						{   6,  67, 121 },
+						{   1,  42,  77 },
+						{   1,  17,  31 },
+					},
+					{ /* Coeff Band 4 */
+						{ 102, 148, 228 },
+						{  67, 117, 204 },
+						{  17,  82, 154 },
+						{   6,  59, 114 },
+						{   2,  39,  75 },
+						{   1,  15,  29 },
+					},
+					{ /* Coeff Band 5 */
+						{ 156,  57, 233 },
+						{ 119,  57, 212 },
+						{  58,  48, 163 },
+						{  29,  40, 124 },
+						{  12,  30,  81 },
+						{   3,  12,  31 }
+					},
+				},
+				{ /* Inter */
+					{ /* Coeff Band 0 */
+						{ 191, 107, 226 },
+						{ 124, 117, 204 },
+						{  25,  99, 155 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+					},
+					{ /* Coeff Band 1 */
+						{  29, 148, 210 },
+						{  37, 126, 194 },
+						{   8,  93, 157 },
+						{   2,  68, 118 },
+						{   1,  39,  69 },
+						{   1,  17,  33 },
+					},
+					{ /* Coeff Band 2 */
+						{  41, 151, 213 },
+						{  27, 123, 193 },
+						{   3,  82, 144 },
+						{   1,  58, 105 },
+						{   1,  32,  60 },
+						{   1,  13,  26 },
+					},
+					{ /* Coeff Band 3 */
+						{  59, 159, 220 },
+						{  23, 126, 198 },
+						{   4,  88, 151 },
+						{   1,  66, 114 },
+						{   1,  38,  71 },
+						{   1,  18,  34 },
+					},
+					{ /* Coeff Band 4 */
+						{ 114, 136, 232 },
+						{  51, 114, 207 },
+						{  11,  83, 155 },
+						{   3,  56, 105 },
+						{   1,  33,  65 },
+						{   1,  17,  34 },
+					},
+					{ /* Coeff Band 5 */
+						{ 149,  65, 234 },
+						{ 121,  57, 215 },
+						{  61,  49, 166 },
+						{  28,  36, 114 },
+						{  12,  25,  76 },
+						{   3,  16,  42 },
+					},
+				},
+			},
+			{ /* block Type 1 */
+				{ /* Intra */
+					{ /* Coeff Band 0 */
+						{ 214,  49, 220 },
+						{ 132,  63, 188 },
+						{  42,  65, 137 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+					},
+					{ /* Coeff Band 1 */
+						{  85, 137, 221 },
+						{ 104, 131, 216 },
+						{  49, 111, 192 },
+						{  21,  87, 155 },
+						{   2,  49,  87 },
+						{   1,  16,  28 },
+					},
+					{ /* Coeff Band 2 */
+						{  89, 163, 230 },
+						{  90, 137, 220 },
+						{  29, 100, 183 },
+						{  10,  70, 135 },
+						{   2,  42,  81 },
+						{   1,  17,  33 },
+					},
+					{ /* Coeff Band 3 */
+						{ 108, 167, 237 },
+						{  55, 133, 222 },
+						{  15,  97, 179 },
+						{   4,  72, 135 },
+						{   1,  45,  85 },
+						{   1,  19,  38 },
+					},
+					{ /* Coeff Band 4 */
+						{ 124, 146, 240 },
+						{  66, 124, 224 },
+						{  17,  88, 175 },
+						{   4,  58, 122 },
+						{   1,  36,  75 },
+						{   1,  18,  37 },
+					},
+					{ /* Coeff Band 5 */
+						{ 141,  79, 241 },
+						{ 126,  70, 227 },
+						{  66,  58, 182 },
+						{  30,  44, 136 },
+						{  12,  34,  96 },
+						{   2,  20,  47 },
+					},
+				},
+				{ /* Inter */
+					{ /* Coeff Band 0 */
+						{ 229,  99, 249 },
+						{ 143, 111, 235 },
+						{  46, 109, 192 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+					},
+					{ /* Coeff Band 1 */
+						{  82, 158, 236 },
+						{  94, 146, 224 },
+						{  25, 117, 191 },
+						{   9,  87, 149 },
+						{   3,  56,  99 },
+						{   1,  33,  57 },
+					},
+					{ /* Coeff Band 2 */
+						{  83, 167, 237 },
+						{  68, 145, 222 },
+						{  10, 103, 177 },
+						{   2,  72, 131 },
+						{   1,  41,  79 },
+						{   1,  20,  39 },
+					},
+					{ /* Coeff Band 3 */
+						{  99, 167, 239 },
+						{  47, 141, 224 },
+						{  10, 104, 178 },
+						{   2,  73, 133 },
+						{   1,  44,  85 },
+						{   1,  22,  47 },
+					},
+					{ /* Coeff Band 4 */
+						{ 127, 145, 243 },
+						{  71, 129, 228 },
+						{  17,  93, 177 },
+						{   3,  61, 124 },
+						{   1,  41,  84 },
+						{   1,  21,  52 },
+					},
+					{ /* Coeff Band 5 */
+						{ 157,  78, 244 },
+						{ 140,  72, 231 },
+						{  69,  58, 184 },
+						{  31,  44, 137 },
+						{  14,  38, 105 },
+						{   8,  23,  61 },
+					},
+				},
+			},
+		},
+		{ /* tx = 8x8 */
+			{ /* block Type 0 */
+				{ /* Intra */
+					{ /* Coeff Band 0 */
+						{ 125,  34, 187 },
+						{  52,  41, 133 },
+						{   6,  31,  56 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+					},
+					{ /* Coeff Band 1 */
+						{  37, 109, 153 },
+						{  51, 102, 147 },
+						{  23,  87, 128 },
+						{   8,  67, 101 },
+						{   1,  41,  63 },
+						{   1,  19,  29 },
+					},
+					{ /* Coeff Band 2 */
+						{  31, 154, 185 },
+						{  17, 127, 175 },
+						{   6,  96, 145 },
+						{   2,  73, 114 },
+						{   1,  51,  82 },
+						{   1,  28,  45 },
+					},
+					{ /* Coeff Band 3 */
+						{  23, 163, 200 },
+						{  10, 131, 185 },
+						{   2,  93, 148 },
+						{   1,  67, 111 },
+						{   1,  41,  69 },
+						{   1,  14,  24 },
+					},
+					{ /* Coeff Band 4 */
+						{  29, 176, 217 },
+						{  12, 145, 201 },
+						{   3, 101, 156 },
+						{   1,  69, 111 },
+						{   1,  39,  63 },
+						{   1,  14,  23 },
+					},
+					{ /* Coeff Band 5 */
+						{  57, 192, 233 },
+						{  25, 154, 215 },
+						{   6, 109, 167 },
+						{   3,  78, 118 },
+						{   1,  48,  69 },
+						{   1,  21,  29 },
+					},
+				},
+				{ /* Inter */
+					{ /* Coeff Band 0 */
+						{ 202, 105, 245 },
+						{ 108, 106, 216 },
+						{  18,  90, 144 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+					},
+					{ /* Coeff Band 1 */
+						{  33, 172, 219 },
+						{  64, 149, 206 },
+						{  14, 117, 177 },
+						{   5,  90, 141 },
+						{   2,  61,  95 },
+						{   1,  37,  57 },
+					},
+					{ /* Coeff Band 2 */
+						{  33, 179, 220 },
+						{  11, 140, 198 },
+						{   1,  89, 148 },
+						{   1,  60, 104 },
+						{   1,  33,  57 },
+						{   1,  12,  21 },
+					},
+					{ /* Coeff Band 3 */
+						{  30, 181, 221 },
+						{   8, 141, 198 },
+						{   1,  87, 145 },
+						{   1,  58, 100 },
+						{   1,  31,  55 },
+						{   1,  12,  20 },
+					},
+					{ /* Coeff Band 4 */
+						{  32, 186, 224 },
+						{   7, 142, 198 },
+						{   1,  86, 143 },
+						{   1,  58, 100 },
+						{   1,  31,  55 },
+						{   1,  12,  22 },
+					},
+					{ /* Coeff Band 5 */
+						{  57, 192, 227 },
+						{  20, 143, 204 },
+						{   3,  96, 154 },
+						{   1,  68, 112 },
+						{   1,  42,  69 },
+						{   1,  19,  32 },
+					},
+				},
+			},
+			{ /* block Type 1 */
+				{ /* Intra */
+					{ /* Coeff Band 0 */
+						{ 212,  35, 215 },
+						{ 113,  47, 169 },
+						{  29,  48, 105 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+					},
+					{ /* Coeff Band 1 */
+						{  74, 129, 203 },
+						{ 106, 120, 203 },
+						{  49, 107, 178 },
+						{  19,  84, 144 },
+						{   4,  50,  84 },
+						{   1,  15,  25 },
+					},
+					{ /* Coeff Band 2 */
+						{  71, 172, 217 },
+						{  44, 141, 209 },
+						{  15, 102, 173 },
+						{   6,  76, 133 },
+						{   2,  51,  89 },
+						{   1,  24,  42 },
+					},
+					{ /* Coeff Band 3 */
+						{  64, 185, 231 },
+						{  31, 148, 216 },
+						{   8, 103, 175 },
+						{   3,  74, 131 },
+						{   1,  46,  81 },
+						{   1,  18,  30 },
+					},
+					{ /* Coeff Band 4 */
+						{  65, 196, 235 },
+						{  25, 157, 221 },
+						{   5, 105, 174 },
+						{   1,  67, 120 },
+						{   1,  38,  69 },
+						{   1,  15,  30 },
+					},
+					{ /* Coeff Band 5 */
+						{  65, 204, 238 },
+						{  30, 156, 224 },
+						{   7, 107, 177 },
+						{   2,  70, 124 },
+						{   1,  42,  73 },
+						{   1,  18,  34 },
+					},
+				},
+				{ /* Inter */
+					{ /* Coeff Band 0 */
+						{ 225,  86, 251 },
+						{ 144, 104, 235 },
+						{  42,  99, 181 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+					},
+					{ /* Coeff Band 1 */
+						{  85, 175, 239 },
+						{ 112, 165, 229 },
+						{  29, 136, 200 },
+						{  12, 103, 162 },
+						{   6,  77, 123 },
+						{   2,  53,  84 },
+					},
+					{ /* Coeff Band 2 */
+						{  75, 183, 239 },
+						{  30, 155, 221 },
+						{   3, 106, 171 },
+						{   1,  74, 128 },
+						{   1,  44,  76 },
+						{   1,  17,  28 },
+					},
+					{ /* Coeff Band 3 */
+						{  73, 185, 240 },
+						{  27, 159, 222 },
+						{   2, 107, 172 },
+						{   1,  75, 127 },
+						{   1,  42,  73 },
+						{   1,  17,  29 },
+					},
+					{ /* Coeff Band 4 */
+						{  62, 190, 238 },
+						{  21, 159, 222 },
+						{   2, 107, 172 },
+						{   1,  72, 122 },
+						{   1,  40,  71 },
+						{   1,  18,  32 },
+					},
+					{ /* Coeff Band 5 */
+						{  61, 199, 240 },
+						{  27, 161, 226 },
+						{   4, 113, 180 },
+						{   1,  76, 129 },
+						{   1,  46,  80 },
+						{   1,  23,  41 },
+					},
+				},
+			},
+		},
+		{ /* tx = 16x16 */
+			{ /* block Type 0 */
+				{ /* Intra */
+					{ /* Coeff Band 0 */
+						{   7,  27, 153 },
+						{   5,  30,  95 },
+						{   1,  16,  30 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+					},
+					{ /* Coeff Band 1 */
+						{  50,  75, 127 },
+						{  57,  75, 124 },
+						{  27,  67, 108 },
+						{  10,  54,  86 },
+						{   1,  33,  52 },
+						{   1,  12,  18 },
+					},
+					{ /* Coeff Band 2 */
+						{  43, 125, 151 },
+						{  26, 108, 148 },
+						{   7,  83, 122 },
+						{   2,  59,  89 },
+						{   1,  38,  60 },
+						{   1,  17,  27 },
+					},
+					{ /* Coeff Band 3 */
+						{  23, 144, 163 },
+						{  13, 112, 154 },
+						{   2,  75, 117 },
+						{   1,  50,  81 },
+						{   1,  31,  51 },
+						{   1,  14,  23 },
+					},
+					{ /* Coeff Band 4 */
+						{  18, 162, 185 },
+						{   6, 123, 171 },
+						{   1,  78, 125 },
+						{   1,  51,  86 },
+						{   1,  31,  54 },
+						{   1,  14,  23 },
+					},
+					{ /* Coeff Band 5 */
+						{  15, 199, 227 },
+						{   3, 150, 204 },
+						{   1,  91, 146 },
+						{   1,  55,  95 },
+						{   1,  30,  53 },
+						{   1,  11,  20 },
+					}
+				},
+				{ /* Inter */
+					{ /* Coeff Band 0 */
+						{  19,  55, 240 },
+						{  19,  59, 196 },
+						{   3,  52, 105 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+					},
+					{ /* Coeff Band 1 */
+						{  41, 166, 207 },
+						{ 104, 153, 199 },
+						{  31, 123, 181 },
+						{  14, 101, 152 },
+						{   5,  72, 106 },
+						{   1,  36,  52 },
+					},
+					{ /* Coeff Band 2 */
+						{  35, 176, 211 },
+						{  12, 131, 190 },
+						{   2,  88, 144 },
+						{   1,  60, 101 },
+						{   1,  36,  60 },
+						{   1,  16,  28 },
+					},
+					{ /* Coeff Band 3 */
+						{  28, 183, 213 },
+						{   8, 134, 191 },
+						{   1,  86, 142 },
+						{   1,  56,  96 },
+						{   1,  30,  53 },
+						{   1,  12,  20 },
+					},
+					{ /* Coeff Band 4 */
+						{  20, 190, 215 },
+						{   4, 135, 192 },
+						{   1,  84, 139 },
+						{   1,  53,  91 },
+						{   1,  28,  49 },
+						{   1,  11,  20 },
+					},
+					{ /* Coeff Band 5 */
+						{  13, 196, 216 },
+						{   2, 137, 192 },
+						{   1,  86, 143 },
+						{   1,  57,  99 },
+						{   1,  32,  56 },
+						{   1,  13,  24 },
+					},
+				},
+			},
+			{ /* block Type 1 */
+				{ /* Intra */
+					{ /* Coeff Band 0 */
+						{ 211,  29, 217 },
+						{  96,  47, 156 },
+						{  22,  43,  87 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+					},
+					{ /* Coeff Band 1 */
+						{  78, 120, 193 },
+						{ 111, 116, 186 },
+						{  46, 102, 164 },
+						{  15,  80, 128 },
+						{   2,  49,  76 },
+						{   1,  18,  28 },
+					},
+					{ /* Coeff Band 2 */
+						{  71, 161, 203 },
+						{  42, 132, 192 },
+						{  10,  98, 150 },
+						{   3,  69, 109 },
+						{   1,  44,  70 },
+						{   1,  18,  29 },
+					},
+					{ /* Coeff Band 3 */
+						{  57, 186, 211 },
+						{  30, 140, 196 },
+						{   4,  93, 146 },
+						{   1,  62, 102 },
+						{   1,  38,  65 },
+						{   1,  16,  27 },
+					},
+					{ /* Coeff Band 4 */
+						{  47, 199, 217 },
+						{  14, 145, 196 },
+						{   1,  88, 142 },
+						{   1,  57,  98 },
+						{   1,  36,  62 },
+						{   1,  15,  26 },
+					},
+					{ /* Coeff Band 5 */
+						{  26, 219, 229 },
+						{   5, 155, 207 },
+						{   1,  94, 151 },
+						{   1,  60, 104 },
+						{   1,  36,  62 },
+						{   1,  16,  28 },
+					}
+				},
+				{ /* Inter */
+					{ /* Coeff Band 0 */
+						{ 233,  29, 248 },
+						{ 146,  47, 220 },
+						{  43,  52, 140 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+					},
+					{ /* Coeff Band 1 */
+						{ 100, 163, 232 },
+						{ 179, 161, 222 },
+						{  63, 142, 204 },
+						{  37, 113, 174 },
+						{  26,  89, 137 },
+						{  18,  68,  97 },
+					},
+					{ /* Coeff Band 2 */
+						{  85, 181, 230 },
+						{  32, 146, 209 },
+						{   7, 100, 164 },
+						{   3,  71, 121 },
+						{   1,  45,  77 },
+						{   1,  18,  30 },
+					},
+					{ /* Coeff Band 3 */
+						{  65, 187, 230 },
+						{  20, 148, 207 },
+						{   2,  97, 159 },
+						{   1,  68, 116 },
+						{   1,  40,  70 },
+						{   1,  14,  29 },
+					},
+					{ /* Coeff Band 4 */
+						{  40, 194, 227 },
+						{   8, 147, 204 },
+						{   1,  94, 155 },
+						{   1,  65, 112 },
+						{   1,  39,  66 },
+						{   1,  14,  26 },
+					},
+					{ /* Coeff Band 5 */
+						{  16, 208, 228 },
+						{   3, 151, 207 },
+						{   1,  98, 160 },
+						{   1,  67, 117 },
+						{   1,  41,  74 },
+						{   1,  17,  31 },
+					},
+				},
+			},
+		},
+		{ /* tx = 32x32 */
+			{ /* block Type 0 */
+				{ /* Intra */
+					{ /* Coeff Band 0 */
+						{  17,  38, 140 },
+						{   7,  34,  80 },
+						{   1,  17,  29 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+					},
+					{ /* Coeff Band 1 */
+						{  37,  75, 128 },
+						{  41,  76, 128 },
+						{  26,  66, 116 },
+						{  12,  52,  94 },
+						{   2,  32,  55 },
+						{   1,  10,  16 },
+					},
+					{ /* Coeff Band 2 */
+						{  50, 127, 154 },
+						{  37, 109, 152 },
+						{  16,  82, 121 },
+						{   5,  59,  85 },
+						{   1,  35,  54 },
+						{   1,  13,  20 },
+					},
+					{ /* Coeff Band 3 */
+						{  40, 142, 167 },
+						{  17, 110, 157 },
+						{   2,  71, 112 },
+						{   1,  44,  72 },
+						{   1,  27,  45 },
+						{   1,  11,  17 },
+					},
+					{ /* Coeff Band 4 */
+						{  30, 175, 188 },
+						{   9, 124, 169 },
+						{   1,  74, 116 },
+						{   1,  48,  78 },
+						{   1,  30,  49 },
+						{   1,  11,  18 },
+					},
+					{ /* Coeff Band 5 */
+						{  10, 222, 223 },
+						{   2, 150, 194 },
+						{   1,  83, 128 },
+						{   1,  48,  79 },
+						{   1,  27,  45 },
+						{   1,  11,  17 },
+					},
+				},
+				{ /* Inter */
+					{ /* Coeff Band 0 */
+						{  36,  41, 235 },
+						{  29,  36, 193 },
+						{  10,  27, 111 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+					},
+					{ /* Coeff Band 1 */
+						{  85, 165, 222 },
+						{ 177, 162, 215 },
+						{ 110, 135, 195 },
+						{  57, 113, 168 },
+						{  23,  83, 120 },
+						{  10,  49,  61 },
+					},
+					{ /* Coeff Band 2 */
+						{  85, 190, 223 },
+						{  36, 139, 200 },
+						{   5,  90, 146 },
+						{   1,  60, 103 },
+						{   1,  38,  65 },
+						{   1,  18,  30 },
+					},
+					{ /* Coeff Band 3 */
+						{  72, 202, 223 },
+						{  23, 141, 199 },
+						{   2,  86, 140 },
+						{   1,  56,  97 },
+						{   1,  36,  61 },
+						{   1,  16,  27 },
+					},
+					{ /* Coeff Band 4 */
+						{  55, 218, 225 },
+						{  13, 145, 200 },
+						{   1,  86, 141 },
+						{   1,  57,  99 },
+						{   1,  35,  61 },
+						{   1,  13,  22 },
+					},
+					{ /* Coeff Band 5 */
+						{  15, 235, 212 },
+						{   1, 132, 184 },
+						{   1,  84, 139 },
+						{   1,  57,  97 },
+						{   1,  34,  56 },
+						{   1,  14,  23 },
+					},
+				},
+			},
+			{ /* block Type 1 */
+				{ /* Intra */
+					{ /* Coeff Band 0 */
+						{ 181,  21, 201 },
+						{  61,  37, 123 },
+						{  10,  38,  71 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+					},
+					{ /* Coeff Band 1 */
+						{  47, 106, 172 },
+						{  95, 104, 173 },
+						{  42,  93, 159 },
+						{  18,  77, 131 },
+						{   4,  50,  81 },
+						{   1,  17,  23 },
+					},
+					{ /* Coeff Band 2 */
+						{  62, 147, 199 },
+						{  44, 130, 189 },
+						{  28, 102, 154 },
+						{  18,  75, 115 },
+						{   2,  44,  65 },
+						{   1,  12,  19 },
+					},
+					{ /* Coeff Band 3 */
+						{  55, 153, 210 },
+						{  24, 130, 194 },
+						{   3,  93, 146 },
+						{   1,  61,  97 },
+						{   1,  31,  50 },
+						{   1,  10,  16 },
+					},
+					{ /* Coeff Band 4 */
+						{  49, 186, 223 },
+						{  17, 148, 204 },
+						{   1,  96, 142 },
+						{   1,  53,  83 },
+						{   1,  26,  44 },
+						{   1,  11,  17 },
+					},
+					{ /* Coeff Band 5 */
+						{  13, 217, 212 },
+						{   2, 136, 180 },
+						{   1,  78, 124 },
+						{   1,  50,  83 },
+						{   1,  29,  49 },
+						{   1,  14,  23 },
+					},
+				},
+				{ /* Inter */
+					{ /* Coeff Band 0 */
+						{ 197,  13, 247 },
+						{  82,  17, 222 },
+						{  25,  17, 162 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+						{   0,   0,   0 },
+					},
+					{ /* Coeff Band 1 */
+						{ 126, 186, 247 },
+						{ 234, 191, 243 },
+						{ 176, 177, 234 },
+						{ 104, 158, 220 },
+						{  66, 128, 186 },
+						{  55,  90, 137 },
+					},
+					{ /* Coeff Band 2 */
+						{ 111, 197, 242 },
+						{  46, 158, 219 },
+						{   9, 104, 171 },
+						{   2,  65, 125 },
+						{   1,  44,  80 },
+						{   1,  17,  91 },
+					},
+					{ /* Coeff Band 3 */
+						{ 104, 208, 245 },
+						{  39, 168, 224 },
+						{   3, 109, 162 },
+						{   1,  79, 124 },
+						{   1,  50, 102 },
+						{   1,  43, 102 },
+					},
+					{ /* Coeff Band 4 */
+						{  84, 220, 246 },
+						{  31, 177, 231 },
+						{   2, 115, 180 },
+						{   1,  79, 134 },
+						{   1,  55,  77 },
+						{   1,  60,  79 },
+					},
+					{ /* Coeff Band 5 */
+						{  43, 243, 240 },
+						{   8, 180, 217 },
+						{   1, 115, 166 },
+						{   1,  84, 121 },
+						{   1,  51,  67 },
+						{   1,  16,   6 },
+					},
+				},
+			},
+		},
+	},
+
+	.skip = { 192, 128, 64 },
+	.inter_mode = {
+		{  2, 173, 34 },
+		{  7, 145, 85 },
+		{  7, 166, 63 },
+		{  7,  94, 66 },
+		{  8,  64, 46 },
+		{ 17,  81, 31 },
+		{ 25,  29, 30 },
+	},
+	.interp_filter = {
+		{ 235, 162 },
+		{  36, 255 },
+		{  34,   3 },
+		{ 149, 144 },
+	},
+	.is_inter = { 9, 102, 187, 225 },
+	.comp_mode = { 239, 183, 119, 96, 41 },
+	.single_ref = {
+		{  33,  16 },
+		{  77,  74 },
+		{ 142, 142 },
+		{ 172, 170 },
+		{ 238, 247 },
+	},
+	.comp_ref = { 50, 126, 123, 221, 226 },
+	.y_mode = {
+		{  65,  32, 18, 144, 162, 194, 41, 51, 98 },
+		{ 132,  68, 18, 165, 217, 196, 45, 40, 78 },
+		{ 173,  80, 19, 176, 240, 193, 64, 35, 46 },
+		{ 221, 135, 38, 194, 248, 121, 96, 85, 29 },
+	},
+	.uv_mode = {
+		{ 120,   7,  76, 176, 208, 126,  28,  54, 103 } /* y = dc */,
+		{  48,  12, 154, 155, 139,  90,  34, 117, 119 } /* y = v */,
+		{  67,   6,  25, 204, 243, 158,  13,  21,  96 } /* y = h */,
+		{  97,   5,  44, 131, 176, 139,  48,  68,  97 } /* y = d45 */,
+		{  83,   5,  42, 156, 111, 152,  26,  49, 152 } /* y = d135 */,
+		{  80,   5,  58, 178,  74,  83,  33,  62, 145 } /* y = d117 */,
+		{  86,   5,  32, 154, 192, 168,  14,  22, 163 } /* y = d153 */,
+		{  85,   5,  32, 156, 216, 148,  19,  29,  73 } /* y = d207 */,
+		{  77,   7,  64, 116, 132, 122,  37, 126, 120 } /* y = d63 */,
+		{ 101,  21, 107, 181, 192, 103,  19,  67, 125 } /* y = tm */
+	},
+	.partition = {
+		/* 8x8 -> 4x4 */
+		{ 199, 122, 141 } /* a/l both not split */,
+		{ 147,  63, 159 } /* a split, l not split */,
+		{ 148, 133, 118 } /* l split, a not split */,
+		{ 121, 104, 114 } /* a/l both split */,
+		/* 16x16 -> 8x8 */
+		{ 174,  73,  87 } /* a/l both not split */,
+		{  92,  41,  83 } /* a split, l not split */,
+		{  82,  99,  50 } /* l split, a not split */,
+		{  53,  39,  39 } /* a/l both split */,
+		/* 32x32 -> 16x16 */
+		{ 177,  58,  59 } /* a/l both not split */,
+		{  68,  26,  63 } /* a split, l not split */,
+		{  52,  79,  25 } /* l split, a not split */,
+		{  17,  14,  12 } /* a/l both split */,
+		/* 64x64 -> 32x32 */
+		{ 222,  34,  30 } /* a/l both not split */,
+		{  72,  16,  44 } /* a split, l not split */,
+		{  58,  32,  12 } /* l split, a not split */,
+		{  10,   7,   6 } /* a/l both split */,
+	},
+
+	.mv = {
+		.joint = { 32, 64, 96 },
+		.sign = { 128, 128 },
+		.class = {
+			{ 224, 144, 192, 168, 192, 176, 192, 198, 198, 245 },
+			{ 216, 128, 176, 160, 176, 176, 192, 198, 198, 208 },
+		},
+		.class0_bit = { 216, 208 },
+		.bits = {
+			{ 136, 140, 148, 160, 176, 192, 224, 234, 234, 240},
+			{ 136, 140, 148, 160, 176, 192, 224, 234, 234, 240},
+		},
+		.class0_fr = {
+			{
+				{ 128, 128, 64 },
+				{  96, 112, 64 },
+			},
+			{
+				{ 128, 128, 64 },
+				{  96, 112, 64 },
+			},
+		},
+		.fr = {
+			{ 64, 96, 64 },
+			{ 64, 96, 64 },
+		},
+		.class0_hp = { 160, 160 },
+		.hp = { 128, 128 },
+	},
+};
+
+static void write_coeff_plane(const u8 coef[6][6][3], u8 *coeff_plane)
+{
+	unsigned int idx = 0;
+	u8 byte_count = 0, p;
+	s32 k, m, n;
+
+	for (k = 0; k < 6; k++) {
+		for (m = 0; m < 6; m++) {
+			for (n = 0; n < 3; n++) {
+				p = coef[k][m][n];
+				coeff_plane[idx++] = p;
+				byte_count++;
+				if (byte_count == 27) {
+					idx += 5;
+					byte_count = 0;
+				}
+			}
+		}
+	}
+}
+
+static void init_intra_only_probs(struct rkvdec_ctx *ctx,
+				  const struct rkvdec_vp9_run *run)
+{
+	const struct v4l2_ctrl_vp9_frame_decode_params *dec_params;
+	struct rkvdec_vp9_ctx *vp9_ctx = ctx->priv;
+	struct rkvdec_vp9_priv_tbl *tbl = vp9_ctx->priv_tbl.cpu;
+	struct rkvdec_vp9_intra_only_frame_probs *rkprobs;
+	const struct rkvdec_vp9_frame_context *probs;
+	unsigned int i, j, k, m;
+
+	rkprobs = &tbl->probs.intra_only;
+	dec_params = run->decode_params;
+	probs = &vp9_ctx->probability_tables;
+
+	/*
+	 * intra only 149 x 128 bits ,aligned to 152 x 128 bits coeff related
+	 * prob 64 x 128 bits
+	 */
+	for (i = 0; i < ARRAY_SIZE(probs->coef); i++) {
+		for (j = 0; j < ARRAY_SIZE(probs->coef[0]); j++)
+			write_coeff_plane(probs->coef[i][j][0],
+					  rkprobs->coef_intra[i][j]);
+	}
+
+	/* intra mode prob  80 x 128 bits */
+	for (i = 0; i < ARRAY_SIZE(vp9_kf_y_mode_prob); i++) {
+		u32 byte_count = 0;
+		int idx = 0;
+
+		/* vp9_kf_y_mode_prob */
+		for (j = 0; j < ARRAY_SIZE(vp9_kf_y_mode_prob[0]); j++) {
+			for (k = 0; k < ARRAY_SIZE(vp9_kf_y_mode_prob[0][0]);
+			     k++) {
+				u8 val = vp9_kf_y_mode_prob[i][j][k];
+
+				rkprobs->intra_mode[i].y_mode[idx++] = val;
+				byte_count++;
+				if (byte_count == 27) {
+					byte_count = 0;
+					idx += 5;
+				}
+			}
+		}
+
+		idx = 0;
+		if (i < 4) {
+			for (m = 0; m < (i < 3 ? 23 : 21); m++) {
+				const u8 *ptr = (const u8 *)kf_uv_mode_prob;
+
+				rkprobs->intra_mode[i].uv_mode[idx++] = ptr[i * 23 + m];
+			}
+		}
+	}
+}
+
+static void init_inter_probs(struct rkvdec_ctx *ctx,
+			     const struct rkvdec_vp9_run *run)
+{
+	const struct v4l2_ctrl_vp9_frame_decode_params *dec_params;
+	struct rkvdec_vp9_ctx *vp9_ctx = ctx->priv;
+	struct rkvdec_vp9_priv_tbl *tbl = vp9_ctx->priv_tbl.cpu;
+	struct rkvdec_vp9_inter_frame_probs *rkprobs;
+	const struct rkvdec_vp9_frame_context *probs;
+	unsigned int i, j, k;
+
+	rkprobs = &tbl->probs.inter;
+	dec_params = run->decode_params;
+	probs = &vp9_ctx->probability_tables;
+
+	/*
+	 * inter probs
+	 * 151 x 128 bits, aligned to 152 x 128 bits
+	 * inter only
+	 * intra_y_mode & inter_block info 6 x 128 bits
+	 */
+
+	memcpy(rkprobs->y_mode, probs->y_mode, sizeof(rkprobs->y_mode));
+	memcpy(rkprobs->comp_mode, probs->comp_mode,
+	       sizeof(rkprobs->comp_mode));
+	memcpy(rkprobs->comp_ref, probs->comp_ref,
+	       sizeof(rkprobs->comp_ref));
+	memcpy(rkprobs->single_ref, probs->single_ref,
+	       sizeof(rkprobs->single_ref));
+	memcpy(rkprobs->inter_mode, probs->inter_mode,
+	       sizeof(rkprobs->inter_mode));
+	memcpy(rkprobs->interp_filter, probs->interp_filter,
+	       sizeof(rkprobs->interp_filter));
+
+	/* 128 x 128 bits coeff related */
+	for (i = 0; i < ARRAY_SIZE(probs->coef); i++) {
+		for (j = 0; j < ARRAY_SIZE(probs->coef[0]); j++) {
+			for (k = 0; k < ARRAY_SIZE(probs->coef[0][0]); k++)
+				write_coeff_plane(probs->coef[i][j][k],
+						  rkprobs->coef[k][i][j]);
+		}
+	}
+
+	/* intra uv mode 6 x 128 */
+	memcpy(rkprobs->uv_mode_0_2, &probs->uv_mode[0],
+	       sizeof(rkprobs->uv_mode_0_2));
+	memcpy(rkprobs->uv_mode_3_5, &probs->uv_mode[3],
+	       sizeof(rkprobs->uv_mode_3_5));
+	memcpy(rkprobs->uv_mode_6_8, &probs->uv_mode[6],
+	       sizeof(rkprobs->uv_mode_6_8));
+	memcpy(rkprobs->uv_mode_9, &probs->uv_mode[9],
+	       sizeof(rkprobs->uv_mode_9));
+
+	/* mv related 6 x 128 */
+	memcpy(rkprobs->mv.joint, probs->mv.joint,
+	       sizeof(rkprobs->mv.joint));
+	memcpy(rkprobs->mv.sign, probs->mv.sign,
+	       sizeof(rkprobs->mv.sign));
+	memcpy(rkprobs->mv.class, probs->mv.class,
+	       sizeof(rkprobs->mv.class));
+	memcpy(rkprobs->mv.class0_bit, probs->mv.class0_bit,
+	       sizeof(rkprobs->mv.class0_bit));
+	memcpy(rkprobs->mv.bits, probs->mv.bits,
+	       sizeof(rkprobs->mv.bits));
+	memcpy(rkprobs->mv.class0_fr, probs->mv.class0_fr,
+	       sizeof(rkprobs->mv.class0_fr));
+	memcpy(rkprobs->mv.fr, probs->mv.fr,
+	       sizeof(rkprobs->mv.fr));
+	memcpy(rkprobs->mv.class0_hp, probs->mv.class0_hp,
+	       sizeof(rkprobs->mv.class0_hp));
+	memcpy(rkprobs->mv.hp, probs->mv.hp,
+	       sizeof(rkprobs->mv.hp));
+}
+
+static void init_probs(struct rkvdec_ctx *ctx,
+		       const struct rkvdec_vp9_run *run)
+{
+	const struct v4l2_ctrl_vp9_frame_decode_params *dec_params;
+	struct rkvdec_vp9_ctx *vp9_ctx = ctx->priv;
+	struct rkvdec_vp9_priv_tbl *tbl = vp9_ctx->priv_tbl.cpu;
+	struct rkvdec_vp9_probs *rkprobs = &tbl->probs;
+	const struct v4l2_vp9_segmentation *seg;
+	const struct rkvdec_vp9_frame_context *probs;
+	bool intra_only;
+
+	dec_params = run->decode_params;
+	probs = &vp9_ctx->probability_tables;
+	seg = &dec_params->seg;
+
+	memset(rkprobs, 0, sizeof(*rkprobs));
+
+	intra_only = !!(dec_params->flags &
+			(V4L2_VP9_FRAME_FLAG_KEY_FRAME |
+			 V4L2_VP9_FRAME_FLAG_INTRA_ONLY));
+
+	/* sb info  5 x 128 bit */
+	memcpy(rkprobs->partition,
+	       intra_only ? kf_partition_probs : probs->partition,
+	       sizeof(rkprobs->partition));
+
+	memcpy(rkprobs->pred, seg->pred_probs, sizeof(rkprobs->pred));
+	memcpy(rkprobs->tree, seg->tree_probs, sizeof(rkprobs->tree));
+	memcpy(rkprobs->skip, probs->skip, sizeof(rkprobs->skip));
+	memcpy(rkprobs->tx32, probs->tx32, sizeof(rkprobs->tx32));
+	memcpy(rkprobs->tx16, probs->tx16, sizeof(rkprobs->tx16));
+	memcpy(rkprobs->tx8, probs->tx8, sizeof(rkprobs->tx8));
+	memcpy(rkprobs->is_inter, probs->is_inter, sizeof(rkprobs->is_inter));
+
+	if (intra_only)
+		init_intra_only_probs(ctx, run);
+	else
+		init_inter_probs(ctx, run);
+}
+
+struct vp9d_ref_config {
+	u32 reg_frm_size;
+	u32 reg_hor_stride;
+	u32 reg_y_stride;
+	u32 reg_yuv_stride;
+	u32 reg_ref_base;
+};
+
+static struct vp9d_ref_config ref_config[3] = {
+	{
+		.reg_frm_size = RKVDEC_REG_VP9_FRAME_SIZE(0),
+		.reg_hor_stride = RKVDEC_VP9_HOR_VIRSTRIDE(0),
+		.reg_y_stride = RKVDEC_VP9_LAST_FRAME_YSTRIDE,
+		.reg_yuv_stride = RKVDEC_VP9_LAST_FRAME_YUVSTRIDE,
+		.reg_ref_base = RKVDEC_REG_VP9_LAST_FRAME_BASE,
+	},
+	{
+		.reg_frm_size = RKVDEC_REG_VP9_FRAME_SIZE(1),
+		.reg_hor_stride = RKVDEC_VP9_HOR_VIRSTRIDE(1),
+		.reg_y_stride = RKVDEC_VP9_GOLDEN_FRAME_YSTRIDE,
+		.reg_yuv_stride = 0,
+		.reg_ref_base = RKVDEC_REG_VP9_GOLDEN_FRAME_BASE,
+	},
+	{
+		.reg_frm_size = RKVDEC_REG_VP9_FRAME_SIZE(2),
+		.reg_hor_stride = RKVDEC_VP9_HOR_VIRSTRIDE(2),
+		.reg_y_stride = RKVDEC_VP9_ALTREF_FRAME_YSTRIDE,
+		.reg_yuv_stride = 0,
+		.reg_ref_base = RKVDEC_REG_VP9_ALTREF_FRAME_BASE,
+	}
+};
+
+static struct rkvdec_decoded_buffer *
+get_ref_buf(struct rkvdec_ctx *ctx, struct vb2_v4l2_buffer *dst, u64 timestamp)
+{
+	struct v4l2_m2m_ctx *m2m_ctx = ctx->fh.m2m_ctx;
+	struct vb2_queue *cap_q = &m2m_ctx->cap_q_ctx.q;
+	int buf_idx;
+
+	/*
+	 * If a ref is unused or invalid, address of current destination
+	 * buffer is returned.
+	 */
+	buf_idx = vb2_find_timestamp(cap_q, timestamp, 0);
+	if (buf_idx < 0)
+		return vb2_to_rkvdec_decoded_buf(&dst->vb2_buf);
+
+	return vb2_to_rkvdec_decoded_buf(vb2_get_buffer(cap_q, buf_idx));
+}
+
+static dma_addr_t get_mv_base_addr(struct rkvdec_decoded_buffer *buf)
+{
+	u32 aligned_pitch, aligned_height, yuv_len;
+
+	aligned_height = round_up(buf->vp9.height, 64);
+	aligned_pitch = round_up(buf->vp9.width * buf->vp9.bit_depth, 512) / 8;
+	yuv_len = (aligned_height * aligned_pitch * 3) / 2;
+
+	return vb2_dma_contig_plane_dma_addr(&buf->base.vb.vb2_buf, 0) +
+	       yuv_len;
+}
+
+static void config_ref_registers(struct rkvdec_ctx *ctx,
+				 const struct rkvdec_vp9_run *run,
+				 struct rkvdec_decoded_buffer **ref_bufs,
+				 enum v4l2_vp9_ref_id id)
+{
+	u32 aligned_pitch, aligned_height, y_len, yuv_len;
+	struct rkvdec_decoded_buffer *buf = ref_bufs[id];
+	struct rkvdec_dev *rkvdec = ctx->dev;
+
+	aligned_height = round_up(buf->vp9.height, 64);
+	writel_relaxed(RKVDEC_VP9_FRAMEWIDTH(buf->vp9.width) |
+		       RKVDEC_VP9_FRAMEHEIGHT(buf->vp9.height),
+		       rkvdec->regs + ref_config[id].reg_frm_size);
+
+	writel_relaxed(vb2_dma_contig_plane_dma_addr(&buf->base.vb.vb2_buf, 0),
+		       rkvdec->regs + ref_config[id].reg_ref_base);
+
+	if (&buf->base.vb == run->base.bufs.dst)
+		return;
+
+	aligned_pitch = round_up(buf->vp9.width * buf->vp9.bit_depth, 512) / 8;
+	y_len = aligned_height * aligned_pitch;
+	yuv_len = (y_len * 3) / 2;
+
+	writel_relaxed(RKVDEC_HOR_Y_VIRSTRIDE(aligned_pitch / 16) |
+		       RKVDEC_HOR_UV_VIRSTRIDE(aligned_pitch / 16),
+		       rkvdec->regs + ref_config[id].reg_hor_stride);
+	writel_relaxed(RKVDEC_VP9_REF_YSTRIDE(y_len / 16),
+		       rkvdec->regs + ref_config[id].reg_y_stride);
+
+	if (!ref_config[id].reg_yuv_stride)
+		return;
+
+	writel_relaxed(RKVDEC_VP9_REF_YUVSTRIDE(yuv_len / 16),
+		       rkvdec->regs + ref_config[id].reg_yuv_stride);
+}
+
+static bool seg_featured_enabled(const struct v4l2_vp9_segmentation *seg,
+				 enum v4l2_vp9_segment_feature feature,
+				 unsigned int segid)
+{
+	u8 mask = V4L2_VP9_SEGMENT_FEATURE_ENABLED(feature);
+
+	return !!(seg->feature_enabled[segid] & mask);
+}
+
+static void config_seg_registers(struct rkvdec_ctx *ctx, unsigned int segid)
+{
+	struct rkvdec_vp9_ctx *vp9_ctx = ctx->priv;
+	const struct v4l2_vp9_segmentation *seg;
+	struct rkvdec_dev *rkvdec = ctx->dev;
+	s16 feature_val;
+	u8 feature_id;
+	u32 val = 0;
+
+	seg = vp9_ctx->last.valid ? &vp9_ctx->last.seg : &vp9_ctx->cur.seg;
+	feature_id = V4L2_VP9_SEGMENT_FEATURE_QP_DELTA;
+	if (seg_featured_enabled(seg, feature_id, segid)) {
+		feature_val = seg->feature_data[segid][feature_id];
+		val |= RKVDEC_SEGID_FRAME_QP_DELTA_EN(1) |
+		       RKVDEC_SEGID_FRAME_QP_DELTA(feature_val);
+	}
+
+	feature_id = V4L2_VP9_SEGMENT_FEATURE_LF;
+	if (seg_featured_enabled(seg, feature_id, segid)) {
+		feature_val = seg->feature_data[segid][feature_id];
+		val |= RKVDEC_SEGID_FRAME_LOOPFILTER_VALUE_EN(1) |
+		       RKVDEC_SEGID_FRAME_LOOPFILTER_VALUE(feature_val);
+	}
+
+	feature_id = V4L2_VP9_SEGMENT_FEATURE_REF_FRAME;
+	if (seg_featured_enabled(seg, feature_id, segid)) {
+		feature_val = seg->feature_data[segid][feature_id];
+		val |= RKVDEC_SEGID_REFERINFO_EN(1) |
+		       RKVDEC_SEGID_REFERINFO(feature_val);
+	}
+
+	feature_id = V4L2_VP9_SEGMENT_FEATURE_SKIP;
+	if (seg_featured_enabled(seg, feature_id, segid))
+		val |= RKVDEC_SEGID_FRAME_SKIP_EN(1);
+
+	if (!segid &&
+	    (seg->flags & V4L2_VP9_SEGMENTATION_FLAG_ABS_OR_DELTA_UPDATE))
+		val |= RKVDEC_SEGID_ABS_DELTA(1);
+
+	writel_relaxed(val, rkvdec->regs + RKVDEC_VP9_SEGID_GRP(segid));
+}
+
+static void update_dec_buf_info(struct rkvdec_decoded_buffer *buf,
+				const struct v4l2_ctrl_vp9_frame_decode_params *dec_params)
+{
+	buf->vp9.width = dec_params->frame_width_minus_1 + 1;
+	buf->vp9.height = dec_params->frame_height_minus_1 + 1;
+	buf->vp9.bit_depth = dec_params->bit_depth;
+}
+
+static void update_ctx_cur_info(struct rkvdec_vp9_ctx *vp9_ctx,
+				struct rkvdec_decoded_buffer *buf,
+				const struct v4l2_ctrl_vp9_frame_decode_params *dec_params)
+{
+	vp9_ctx->cur.valid = true;
+	vp9_ctx->cur.reference_mode = dec_params->reference_mode;
+	vp9_ctx->cur.tx_mode = dec_params->tx_mode;
+	vp9_ctx->cur.interpolation_filter = dec_params->interpolation_filter;
+	vp9_ctx->cur.flags = dec_params->flags;
+	vp9_ctx->cur.timestamp = buf->base.vb.vb2_buf.timestamp;
+	vp9_ctx->cur.seg = dec_params->seg;
+	vp9_ctx->cur.lf = dec_params->lf;
+}
+
+static void update_ctx_last_info(struct rkvdec_vp9_ctx *vp9_ctx)
+{
+	vp9_ctx->last = vp9_ctx->cur;
+}
+
+static void config_registers(struct rkvdec_ctx *ctx,
+			     const struct rkvdec_vp9_run *run)
+{
+	u32 y_len, uv_len, yuv_len, bit_depth, aligned_height, aligned_pitch;
+	const struct v4l2_ctrl_vp9_frame_decode_params *dec_params;
+	struct rkvdec_decoded_buffer *ref_bufs[V4L2_REF_ID_CNT];
+	struct rkvdec_decoded_buffer *dst, *last, *mv_ref;
+	struct rkvdec_vp9_ctx *vp9_ctx = ctx->priv;
+	u32 val, stream_len, last_frame_info = 0;
+	const struct v4l2_vp9_segmentation *seg;
+	struct rkvdec_dev *rkvdec = ctx->dev;
+	dma_addr_t addr;
+	bool intra_only;
+	unsigned int i;
+
+	dec_params = run->decode_params;
+	dst = vb2_to_rkvdec_decoded_buf(&run->base.bufs.dst->vb2_buf);
+	for (i = 0; i < ARRAY_SIZE(ref_bufs); i++)
+		ref_bufs[i] = get_ref_buf(ctx, &dst->base.vb,
+					  dec_params->refs[i]);
+
+	if (vp9_ctx->last.valid)
+		last = get_ref_buf(ctx, &dst->base.vb, vp9_ctx->last.timestamp);
+	else
+		last = dst;
+
+	update_dec_buf_info(dst, dec_params);
+	update_ctx_cur_info(vp9_ctx, dst, dec_params);
+	seg = &dec_params->seg;
+
+	intra_only = !!(dec_params->flags &
+			(V4L2_VP9_FRAME_FLAG_KEY_FRAME |
+			 V4L2_VP9_FRAME_FLAG_INTRA_ONLY));
+
+	writel_relaxed(RKVDEC_MODE(RKVDEC_MODE_VP9),
+		       rkvdec->regs + RKVDEC_REG_SYSCTRL);
+
+	bit_depth = dec_params->bit_depth;
+	aligned_height = round_up(ctx->decoded_fmt.fmt.pix_mp.height, 64);
+
+	aligned_pitch = round_up(ctx->decoded_fmt.fmt.pix_mp.width *
+				 bit_depth,
+				 512) / 8;
+	y_len = aligned_height * aligned_pitch;
+	uv_len = y_len / 2;
+	yuv_len = y_len + uv_len;
+
+	writel_relaxed(RKVDEC_Y_HOR_VIRSTRIDE(aligned_pitch / 16) |
+		       RKVDEC_UV_HOR_VIRSTRIDE(aligned_pitch / 16),
+		       rkvdec->regs + RKVDEC_REG_PICPAR);
+	writel_relaxed(RKVDEC_Y_VIRSTRIDE(y_len / 16),
+		       rkvdec->regs + RKVDEC_REG_Y_VIRSTRIDE);
+	writel_relaxed(RKVDEC_YUV_VIRSTRIDE(yuv_len / 16),
+		       rkvdec->regs + RKVDEC_REG_YUV_VIRSTRIDE);
+
+	stream_len = vb2_get_plane_payload(&run->base.bufs.src->vb2_buf, 0);
+	writel_relaxed(RKVDEC_STRM_LEN(stream_len),
+		       rkvdec->regs + RKVDEC_REG_STRM_LEN);
+
+	/*
+	 * Reset count buffer, because decoder only output intra related syntax
+	 * counts when decoding intra frame, but update entropy need to update
+	 * all the probabilities.
+	 */
+	if (intra_only)
+		memset(vp9_ctx->count_tbl.cpu, 0, vp9_ctx->count_tbl.size);
+
+	vp9_ctx->cur.segmapid = vp9_ctx->last.segmapid;
+	if (!intra_only &&
+	    !(dec_params->flags & V4L2_VP9_FRAME_FLAG_ERROR_RESILIENT) &&
+	    (!(seg->flags & V4L2_VP9_SEGMENTATION_FLAG_ENABLED) ||
+	     (seg->flags & V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP)))
+		vp9_ctx->cur.segmapid++;
+
+	for (i = 0; i < ARRAY_SIZE(ref_bufs); i++)
+		config_ref_registers(ctx, run, ref_bufs, i);
+
+	for (i = 0; i < 8; i++)
+		config_seg_registers(ctx, i);
+
+	writel_relaxed(RKVDEC_VP9_TX_MODE(dec_params->tx_mode) |
+		       RKVDEC_VP9_FRAME_REF_MODE(dec_params->reference_mode),
+		       rkvdec->regs + RKVDEC_VP9_CPRHEADER_CONFIG);
+
+	if (!intra_only) {
+		const struct v4l2_vp9_loop_filter *lf;
+		s8 delta;
+
+		if (vp9_ctx->last.valid)
+			lf = &vp9_ctx->last.lf;
+		else
+			lf = &vp9_ctx->cur.lf;
+
+		val = 0;
+		for (i = 0; i < ARRAY_SIZE(lf->ref_deltas); i++) {
+			delta = lf->ref_deltas[i];
+			val |= RKVDEC_REF_DELTAS_LASTFRAME(i, delta);
+		}
+
+		writel_relaxed(val,
+			       rkvdec->regs + RKVDEC_VP9_REF_DELTAS_LASTFRAME);
+
+		for (i = 0; i < ARRAY_SIZE(lf->mode_deltas); i++) {
+			delta = lf->mode_deltas[i];
+			last_frame_info |= RKVDEC_MODE_DELTAS_LASTFRAME(i,
+									delta);
+		}
+	}
+
+	if (vp9_ctx->last.valid && !intra_only &&
+	    vp9_ctx->last.seg.flags & V4L2_VP9_SEGMENTATION_FLAG_ENABLED)
+		last_frame_info |= RKVDEC_SEG_EN_LASTFRAME;
+
+	if (vp9_ctx->last.valid &&
+	    vp9_ctx->last.flags & V4L2_VP9_FRAME_FLAG_SHOW_FRAME)
+		last_frame_info |= RKVDEC_LAST_SHOW_FRAME;
+
+	if (vp9_ctx->last.valid &&
+	    vp9_ctx->last.flags &
+	    (V4L2_VP9_FRAME_FLAG_KEY_FRAME | V4L2_VP9_FRAME_FLAG_INTRA_ONLY))
+		last_frame_info |= RKVDEC_LAST_INTRA_ONLY;
+
+	if (vp9_ctx->last.valid &&
+	    last->vp9.width == dst->vp9.width &&
+	    last->vp9.height == dst->vp9.height)
+		last_frame_info |= RKVDEC_LAST_WIDHHEIGHT_EQCUR;
+
+	writel_relaxed(last_frame_info,
+		       rkvdec->regs + RKVDEC_VP9_INFO_LASTFRAME);
+
+	writel_relaxed(stream_len - dec_params->compressed_header_size -
+		       dec_params->uncompressed_header_size,
+		       rkvdec->regs + RKVDEC_VP9_LASTTILE_SIZE);
+
+	for (i = 0; !intra_only && i < ARRAY_SIZE(ref_bufs); i++) {
+		u32 refw = ref_bufs[i]->vp9.width;
+		u32 refh = ref_bufs[i]->vp9.height;
+		u32 hscale, vscale;
+
+		hscale = (refw << 14) /	dst->vp9.width;
+		vscale = (refh << 14) / dst->vp9.height;
+		writel_relaxed(RKVDEC_VP9_REF_HOR_SCALE(hscale) |
+			       RKVDEC_VP9_REF_VER_SCALE(vscale),
+			       rkvdec->regs + RKVDEC_VP9_REF_SCALE(i));
+	}
+
+	addr = vb2_dma_contig_plane_dma_addr(&dst->base.vb.vb2_buf, 0);
+	writel_relaxed(addr, rkvdec->regs + RKVDEC_REG_DECOUT_BASE);
+	addr = vb2_dma_contig_plane_dma_addr(&run->base.bufs.src->vb2_buf, 0);
+	writel_relaxed(addr, rkvdec->regs + RKVDEC_REG_STRM_RLC_BASE);
+	writel_relaxed(vp9_ctx->priv_tbl.dma +
+		       offsetof(struct rkvdec_vp9_priv_tbl, probs),
+		       rkvdec->regs + RKVDEC_REG_CABACTBL_PROB_BASE);
+	writel_relaxed(vp9_ctx->count_tbl.dma,
+		       rkvdec->regs + RKVDEC_REG_VP9COUNT_BASE);
+
+	writel_relaxed(vp9_ctx->priv_tbl.dma +
+		       offsetof(struct rkvdec_vp9_priv_tbl, segmap) +
+		       (RKVDEC_VP9_MAX_SEGMAP_SIZE * vp9_ctx->cur.segmapid),
+		       rkvdec->regs + RKVDEC_REG_VP9_SEGIDCUR_BASE);
+	writel_relaxed(vp9_ctx->priv_tbl.dma +
+		       offsetof(struct rkvdec_vp9_priv_tbl, segmap) +
+		       (RKVDEC_VP9_MAX_SEGMAP_SIZE * (!vp9_ctx->cur.segmapid)),
+		       rkvdec->regs + RKVDEC_REG_VP9_SEGIDLAST_BASE);
+
+	if (!intra_only &&
+	    !(dec_params->flags & V4L2_VP9_FRAME_FLAG_ERROR_RESILIENT) &&
+	    vp9_ctx->last.valid)
+		mv_ref = last;
+	else
+		mv_ref = dst;
+
+	writel_relaxed(get_mv_base_addr(mv_ref),
+		       rkvdec->regs + RKVDEC_VP9_REF_COLMV_BASE);
+
+	writel_relaxed(ctx->decoded_fmt.fmt.pix_mp.width |
+		       (ctx->decoded_fmt.fmt.pix_mp.height << 16),
+		       rkvdec->regs + RKVDEC_REG_PERFORMANCE_CYCLE);
+}
+
+static int validate_dec_params(struct rkvdec_ctx *ctx,
+			       const struct v4l2_ctrl_vp9_frame_decode_params *dec_params)
+{
+	unsigned int aligned_width, aligned_height;
+
+	/* We only support profile 0. */
+	if (dec_params->profile != 0) {
+		dev_err(ctx->dev->dev, "unsupported profile %d\n",
+			dec_params->profile);
+		return -EINVAL;
+	}
+
+	aligned_width = round_up(dec_params->frame_width_minus_1 + 1, 64);
+	aligned_height = round_up(dec_params->frame_height_minus_1 + 1, 64);
+
+	/*
+	 * Userspace should update the capture/decoded format when the
+	 * resolution changes.
+	 */
+	if (aligned_width != ctx->decoded_fmt.fmt.pix_mp.width ||
+	    aligned_height != ctx->decoded_fmt.fmt.pix_mp.height) {
+		dev_err(ctx->dev->dev,
+			"unexpected bitstream resolution %dx%d\n",
+			dec_params->frame_width_minus_1 + 1,
+			dec_params->frame_height_minus_1 + 1);
+		return -EINVAL;
+	}
+
+	return 0;
+}
+
+/* 6.3.6 inv_recenter_nonneg(v, m) */
+static int inv_recenter_nonneg(int v, int m)
+{
+	if (v > 2 * m)
+		return v;
+
+	if (v & 1)
+		return m - ((v + 1) >> 1);
+
+	return m + (v >> 1);
+}
+
+/*
+ * part of 6.3.5 inv_remap_prob(deltaProb, prob)
+ * delta = inv_map_table[deltaProb] done by userspace
+ */
+static int update_prob(int delta, int prob)
+{
+	if (!delta)
+		return prob;
+
+	return prob <= 128 ?
+		1 + inv_recenter_nonneg(delta, prob - 1) :
+		255 - inv_recenter_nonneg(delta, 255 - prob);
+}
+
+/* Counterpart to 6.3.2 tx_mode_probs() */
+static void update_tx_probs(struct rkvdec_vp9_frame_context *probs,
+			    const struct v4l2_ctrl_vp9_compressed_hdr_probs *deltas)
+{
+	int i;
+
+	for (i = 0; i < ARRAY_SIZE(probs->tx8); i++) {
+		u8 *p8x8 = probs->tx8[i];
+		u8 *p16x16 = probs->tx16[i];
+		u8 *p32x32 = probs->tx32[i];
+		const u8 *d8x8 = deltas->tx8[i];
+		const u8 *d16x16 = deltas->tx16[i];
+		const u8 *d32x32 = deltas->tx32[i];
+
+		p8x8[0] = update_prob(d8x8[0], p8x8[0]);
+		p16x16[0] = update_prob(d16x16[0], p16x16[0]);
+		p16x16[1] = update_prob(d16x16[1], p16x16[1]);
+		p32x32[0] = update_prob(d32x32[0], p32x32[0]);
+		p32x32[1] = update_prob(d32x32[1], p32x32[1]);
+		p32x32[2] = update_prob(d32x32[2], p32x32[2]);
+	}
+}
+
+#define BAND_6(band) ((band) == 0 ? 3 : 6)
+
+static void update_coeff(const u8 deltas[6][6][3], u8 probs[6][6][3])
+{
+	int l, m, n;
+
+	for (l = 0; l < 6; l++)
+		for (m = 0; m < BAND_6(l); m++) {
+			u8 *p = probs[l][m];
+			const u8 *d = deltas[l][m];
+
+			for (n = 0; n < 3; n++)
+				p[n] = update_prob(d[n], p[n]);
+		}
+}
+
+/* Counterpart to 6.3.7 read_coef_probs() */
+static void update_coef_probs(struct rkvdec_vp9_frame_context *probs,
+			      const struct v4l2_ctrl_vp9_compressed_hdr_probs *deltas,
+			      const struct v4l2_ctrl_vp9_frame_decode_params *dec_params)
+{
+	int i, j, k;
+
+	for (i = 0; i < ARRAY_SIZE(probs->coef); i++) {
+		for (j = 0; j < ARRAY_SIZE(probs->coef[0]); j++)
+			for (k = 0; k < ARRAY_SIZE(probs->coef[0][0]); k++)
+				update_coeff(deltas->coef[i][j][k], probs->coef[i][j][k]);
+
+		if (dec_params->tx_mode == i)
+			break;
+	}
+}
+
+/* Counterpart to 6.3.8 read_skip_prob() */
+static void update_skip_probs(struct rkvdec_vp9_frame_context *probs,
+			      const struct v4l2_ctrl_vp9_compressed_hdr_probs *deltas)
+{
+	int i;
+
+	for (i = 0; i < ARRAY_SIZE(probs->skip); i++)
+		probs->skip[i] = update_prob(deltas->skip[i], probs->skip[i]);
+}
+
+/* Counterpart to 6.3.9 read_inter_mode_probs() */
+static void update_inter_mode_probs(struct rkvdec_vp9_frame_context *probs,
+				    const struct v4l2_ctrl_vp9_compressed_hdr_probs *deltas)
+{
+	int i;
+
+	for (i = 0; i < ARRAY_SIZE(probs->inter_mode); i++) {
+		u8 *p = probs->inter_mode[i];
+		const u8 *d = deltas->inter_mode[i];
+
+		p[0] = update_prob(d[0], p[0]);
+		p[1] = update_prob(d[1], p[1]);
+		p[2] = update_prob(d[2], p[2]);
+	}
+}
+
+/* Counterpart to 6.3.10 read_interp_filter_probs() */
+static void update_interp_filter_probs(struct rkvdec_vp9_frame_context *probs,
+				       const struct v4l2_ctrl_vp9_compressed_hdr_probs *deltas)
+{
+	int i;
+
+	for (i = 0; i < ARRAY_SIZE(probs->interp_filter); i++) {
+		u8 *p = probs->interp_filter[i];
+		const u8 *d = deltas->interp_filter[i];
+
+		p[0] = update_prob(d[0], p[0]);
+		p[1] = update_prob(d[1], p[1]);
+	}
+}
+
+/* Counterpart to 6.3.11 read_is_inter_probs() */
+static void update_is_inter_probs(struct rkvdec_vp9_frame_context *probs,
+				  const struct v4l2_ctrl_vp9_compressed_hdr_probs *deltas)
+{
+	int i;
+
+	for (i = 0; i < ARRAY_SIZE(probs->is_inter); i++)
+		probs->is_inter[i] = update_prob(deltas->is_inter[i], probs->is_inter[i]);
+}
+
+/* 6.3.12 frame_reference_mode() done entirely in userspace */
+
+/* Counterpart to 6.3.13 frame_reference_mode_probs() */
+static void
+update_frame_reference_mode_probs(enum v4l2_vp9_reference_mode reference_mode,
+				  struct rkvdec_vp9_frame_context *probs,
+				  const struct v4l2_ctrl_vp9_compressed_hdr_probs *deltas)
+{
+	int i;
+
+	if (reference_mode == V4L2_VP9_REF_MODE_SELECT)
+		for (i = 0; i < ARRAY_SIZE(probs->comp_mode); i++)
+			probs->comp_mode[i] = update_prob(deltas->comp_mode[i],
+							  probs->comp_mode[i]);
+
+	if (reference_mode != V4L2_VP9_REF_MODE_COMPOUND)
+		for (i = 0; i < ARRAY_SIZE(probs->single_ref); i++) {
+			u8 *p = probs->single_ref[i];
+			const u8 *d = deltas->single_ref[i];
+
+			p[0] = update_prob(d[0], p[0]);
+			p[1] = update_prob(d[1], p[1]);
+		}
+
+	if (reference_mode != V4L2_VP9_REF_MODE_SINGLE)
+		for (i = 0; i < ARRAY_SIZE(probs->comp_ref); i++)
+			probs->comp_ref[i] = update_prob(deltas->comp_ref[i], probs->comp_ref[i]);
+}
+
+/* Counterpart to 6.3.14 read_y_mode_probs() */
+static void update_y_mode_probs(struct rkvdec_vp9_frame_context *probs,
+				const struct v4l2_ctrl_vp9_compressed_hdr_probs *deltas)
+{
+	int i, j;
+
+	for (i = 0; i < ARRAY_SIZE(probs->y_mode); i++)
+		for (j = 0; j < ARRAY_SIZE(probs->y_mode[0]); ++j)
+			probs->y_mode[i][j] =
+				update_prob(deltas->y_mode[i][j], probs->y_mode[i][j]);
+}
+
+/* Counterpart to 6.3.15 read_partition_probs() */
+static void update_partition_probs(struct rkvdec_vp9_frame_context *probs,
+				   const struct v4l2_ctrl_vp9_compressed_hdr_probs *deltas)
+{
+	int i, j;
+
+	for (i = 0; i < 4; i++)
+		for (j = 0; j < 4; j++) {
+			u8 *p = probs->partition[i * 4 + j];
+			const u8 *d = deltas->partition[i * 4 + j];
+
+			p[0] = update_prob(d[0], p[0]);
+			p[1] = update_prob(d[1], p[1]);
+			p[2] = update_prob(d[2], p[2]);
+		}
+}
+
+static inline int update_mv_prob(int delta, int prob)
+{
+	if (!delta)
+		return prob;
+
+	return delta;
+}
+
+/* Counterpart to 6.3.16 mv_probs() */
+static void update_mv_probs(struct rkvdec_vp9_frame_context *probs,
+			    const struct v4l2_ctrl_vp9_compressed_hdr_probs *deltas,
+			    const struct v4l2_ctrl_vp9_frame_decode_params *dec_params)
+{
+	u8 *p = probs->mv.joint;
+	const u8 *d = deltas->mv.joint;
+	unsigned int i, j;
+
+	p[0] = update_mv_prob(d[0], p[0]);
+	p[1] = update_mv_prob(d[1], p[1]);
+	p[2] = update_mv_prob(d[2], p[2]);
+
+	for (i = 0; i < ARRAY_SIZE(probs->mv.sign); i++) {
+		p = probs->mv.sign;
+		d = deltas->mv.sign;
+		p[i] = update_mv_prob(d[i], p[i]);
+
+		p = probs->mv.class[i];
+		d = deltas->mv.class[i];
+		for (j = 0; j < ARRAY_SIZE(probs->mv.class[0]); j++)
+			p[j] = update_mv_prob(d[j], p[j]);
+
+		p = probs->mv.class0_bit;
+		d = deltas->mv.class0_bit;
+		p[i] = update_mv_prob(d[i], p[i]);
+
+		p = probs->mv.bits[i];
+		d = deltas->mv.bits[i];
+		for (j = 0; j < ARRAY_SIZE(probs->mv.bits[0]); j++)
+			p[j] = update_mv_prob(d[j], p[j]);
+
+		for (j = 0; j < ARRAY_SIZE(probs->mv.class0_fr[0]); j++) {
+			p = probs->mv.class0_fr[i][j];
+			d = deltas->mv.class0_fr[i][j];
+
+			p[0] = update_mv_prob(d[0], p[0]);
+			p[1] = update_mv_prob(d[1], p[1]);
+			p[2] = update_mv_prob(d[2], p[2]);
+		}
+
+		p = probs->mv.fr[i];
+		d = deltas->mv.fr[i];
+		for (j = 0; j < ARRAY_SIZE(probs->mv.fr[i]); j++)
+			p[j] = update_mv_prob(d[j], p[j]);
+
+		if (dec_params->flags & V4L2_VP9_FRAME_FLAG_ALLOW_HIGH_PREC_MV) {
+			p = probs->mv.class0_hp;
+			d = deltas->mv.class0_hp;
+			p[i] = update_mv_prob(d[i], p[i]);
+
+			p = probs->mv.hp;
+			d = deltas->mv.hp;
+			p[i] = update_mv_prob(d[i], p[i]);
+		}
+	}
+}
+
+/* Counterpart to 6.3 compressed_header(), but parsing has been done in userspace. */
+static void fw_update_probs(struct rkvdec_vp9_frame_context *probs,
+			    const struct v4l2_ctrl_vp9_compressed_hdr_probs *deltas,
+			    const struct v4l2_ctrl_vp9_frame_decode_params *dec_params)
+{
+	if (dec_params->tx_mode == V4L2_VP9_TX_MODE_SELECT)
+		update_tx_probs(probs, deltas);
+
+	update_coef_probs(probs, deltas, dec_params);
+
+	update_skip_probs(probs, deltas);
+
+	if (dec_params->flags & V4L2_VP9_FRAME_FLAG_KEY_FRAME ||
+	    dec_params->flags & V4L2_VP9_FRAME_FLAG_INTRA_ONLY)
+		return;
+
+	update_inter_mode_probs(probs, deltas);
+
+	if (dec_params->interpolation_filter == V4L2_VP9_INTERP_FILTER_SWITCHABLE)
+		update_interp_filter_probs(probs, deltas);
+
+	update_is_inter_probs(probs, deltas);
+
+	update_frame_reference_mode_probs(dec_params->reference_mode, probs, deltas);
+
+	update_y_mode_probs(probs, deltas);
+
+	update_partition_probs(probs, deltas);
+
+	update_mv_probs(probs, deltas, dec_params);
+}
+
+static int rkvdec_vp9_run_preamble(struct rkvdec_ctx *ctx,
+				   struct rkvdec_vp9_run *run)
+{
+	const struct v4l2_ctrl_vp9_frame_decode_params *dec_params;
+	const struct v4l2_ctrl_vp9_compressed_hdr_probs *prob_updates;
+	struct rkvdec_vp9_ctx *vp9_ctx = ctx->priv;
+	struct v4l2_ctrl *ctrl;
+	u8 fctx_idx;
+	int ret, i;
+
+	/* v4l2-specific stuff */
+	rkvdec_run_preamble(ctx, &run->base);
+
+	ctrl = v4l2_ctrl_find(&ctx->ctrl_hdl,
+			      V4L2_CID_STATELESS_VP9_FRAME_DECODE_PARAMS);
+	WARN_ON(!ctrl);
+
+	dec_params = ctrl ? ctrl->p_cur.p : NULL;
+	if (WARN_ON(!dec_params))
+		return -EINVAL;
+
+	ret = validate_dec_params(ctx, dec_params);
+	if (ret)
+		return ret;
+
+	run->decode_params = dec_params;
+
+	ctrl = v4l2_ctrl_find(&ctx->ctrl_hdl, V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS);
+	WARN_ON(!ctrl);
+
+	prob_updates = ctrl->p_cur.p;
+	if (WARN_ON(!prob_updates))
+		return -EINVAL;
+
+	/*
+	 * vp9 stuff
+	 *
+	 * by this point the userspace has done all parts of 6.2 uncompressed_header()
+	 * except this fragment:
+	 * if ( FrameIsIntra || error_resilient_mode ) {
+	 *	setup_past_independence ( )
+	 *	if ( frame_type == KEY_FRAME || error_resilient_mode == 1 ||
+	 *	     reset_frame_context == 3 ) {
+	 *		for ( i = 0; i < 4; i ++ ) {
+	 *			save_probs( i )
+	 *		}
+	 *	} else if ( reset_frame_context == 2 ) {
+	 *		save_probs( frame_context_idx )
+	 *	}
+	 *	frame_context_idx = 0
+	 * }
+	 */
+	fctx_idx = run->decode_params->frame_context_idx;
+	vp9_ctx->cur.frame_context_idx = run->decode_params->frame_context_idx;
+
+	if (dec_params->flags & V4L2_VP9_FRAME_FLAG_KEY_FRAME ||
+	    dec_params->flags & V4L2_VP9_FRAME_FLAG_INTRA_ONLY ||
+	    dec_params->flags & V4L2_VP9_FRAME_FLAG_ERROR_RESILIENT) {
+		/*
+		 * setup_past_independence()
+		 * We do nothing here. Instead of storing default probs in some intermediate
+		 * location and then copying from that location to appropriate contexts
+		 * in save_probs() below, we skip that step and save default probs directly
+		 * to appropriate contexts.
+		 */
+		if (dec_params->flags & V4L2_VP9_FRAME_FLAG_KEY_FRAME ||
+		    dec_params->flags & V4L2_VP9_FRAME_FLAG_ERROR_RESILIENT ||
+		    dec_params->reset_frame_context == V4L2_VP9_RESET_FRAME_CTX_ALL)
+			for (i = 0; i < ARRAY_SIZE(vp9_ctx->frame_context); ++i)
+				/* save_probs(i) */
+				memcpy(&vp9_ctx->frame_context[i],
+				       &vp9_default_probs, sizeof(vp9_default_probs));
+		else if (dec_params->reset_frame_context == V4L2_VP9_RESET_FRAME_CTX_SPEC)
+			/* save_probs(fctx_idx) */
+			memcpy(&vp9_ctx->frame_context[fctx_idx],
+			       &vp9_default_probs, sizeof(vp9_default_probs));
+		fctx_idx = 0;
+		vp9_ctx->cur.frame_context_idx = 0;
+	}
+
+	/* 6.1 frame(sz): load_probs() and load_probs2() */
+	vp9_ctx->probability_tables = vp9_ctx->frame_context[fctx_idx];
+
+	/*
+	 * The userspace has also performed 6.3 compressed_header(), but handling the
+	 * probs in a special way. All probs which need updating, except MV-related,
+	 * have been read from the bitstream and translated through inv_map_table[],
+	 * but no 6.3.6 inv_recenter_nonneg(v, m) has been performed. The values passed
+	 * by userspace are either translated values (there are no 0 values in
+	 * inv_map_table[]), or zero to indicate no update. All MV-related probs which need
+	 * updating have been read from the bitstream and (mv_prob << 1) | 1 has been
+	 * performed. The values passed by userspace are either new values
+	 * to replace old ones (the above mentioned shift and bitwise or never result in
+	 * a zero) or zero to indicate no update.
+	 * fw_update_probs() performs actual probs updates or leaves probs as-is
+	 * for values for which a zero was passed from userspace.
+	 */
+	fw_update_probs(&vp9_ctx->probability_tables, prob_updates, dec_params);
+
+	return 0;
+}
+
+static int rkvdec_vp9_run(struct rkvdec_ctx *ctx)
+{
+	struct rkvdec_dev *rkvdec = ctx->dev;
+	struct rkvdec_vp9_run run = { };
+	int ret;
+
+	ret = rkvdec_vp9_run_preamble(ctx, &run);
+	if (ret) {
+		rkvdec_run_postamble(ctx, &run.base);
+		return ret;
+	}
+
+	/* Prepare probs. */
+	init_probs(ctx, &run);
+
+	/* Configure hardware registers. */
+	config_registers(ctx, &run);
+
+	rkvdec_run_postamble(ctx, &run.base);
+
+	schedule_delayed_work(&rkvdec->watchdog_work, msecs_to_jiffies(2000));
+
+	writel(1, rkvdec->regs + RKVDEC_REG_PREF_LUMA_CACHE_COMMAND);
+	writel(1, rkvdec->regs + RKVDEC_REG_PREF_CHR_CACHE_COMMAND);
+
+	writel(0xe, rkvdec->regs + RKVDEC_REG_STRMD_ERR_EN);
+	/* Start decoding! */
+	writel(RKVDEC_INTERRUPT_DEC_E | RKVDEC_CONFIG_DEC_CLK_GATE_E |
+	       RKVDEC_TIMEOUT_E | RKVDEC_BUF_EMPTY_E,
+	       rkvdec->regs + RKVDEC_REG_INTERRUPT);
+
+	return 0;
+}
+
+/* 8.4.1 Merge prob process */
+static u8 merge_prob(u8 pre_prob, u32 ct0, u32 ct1, u16 count_sat, u32 max_update_factor)
+{
+	u32 den, prob, count, factor;
+
+	den = ct0 + ct1;
+	if (!den) {
+		/*
+		 * prob = 128, count = 0, update_factor = 0
+		 * Round2's argument: pre_prob * 256
+		 * (pre_prob * 256 + 128) >> 8 == pre_prob
+		 */
+		return pre_prob;
+	}
+
+	prob = clamp(((ct0 << 8) + (den >> 1)) / den, (u32)1, (u32)255);
+	count = min_t(u32, den, count_sat);
+	factor = rkvdec_fastdiv(max_update_factor * count, count_sat);
+
+	/*
+	 * Round2(pre_prob * (256 - factor) + prob * factor, 8)
+	 * Round2(pre_prob * 256 + (prob - pre_prob) * factor, 8)
+	 * (pre_prob * 256 >> 8) + (((prob - pre_prob) * factor + 128) >> 8)
+	 */
+	return pre_prob + (((prob - pre_prob) * factor + 128) >> 8);
+}
+
+static inline u8 noncoef_merge_prob(u8 pre_prob, u32 ct0, u32 ct1)
+{
+	return merge_prob(pre_prob, ct0, ct1, 20, 128);
+}
+
+/* 8.4.2 Merge probs process */
+/*
+ * merge_probs() is a recursive function in the spec. We avoid recursion in the kernel.
+ * That said, the "tree" parameter of merge_probs() controls how deep the recursion goes.
+ * It turns out that in all cases the recursive calls boil down to a short-ish series
+ * of merge_prob() invocations (note no "s").
+ *
+ * Variant A
+ * ---------
+ * merge_probs(small_token_tree, 2):
+ *	merge_prob(p[1], c[0], c[1] + c[2])
+ *	merge_prob(p[2], c[1], c[2])
+ *
+ * Variant B
+ * ---------
+ * merge_probs(binary_tree, 0) or
+ * merge_probs(tx_size_8_tree, 0):
+ *	merge_prob(p[0], c[0], c[1])
+ *
+ * Variant C
+ * ---------
+ * merge_probs(inter_mode_tree, 0):
+ *	merge_prob(p[0], c[2], c[1] + c[0] + c[3])
+ *	merge_prob(p[1], c[0], c[1] + c[3])
+ *	merge_prob(p[2], c[1], c[3])
+ *
+ * Variant D
+ * ---------
+ * merge_probs(intra_mode_tree, 0):
+ *	merge_prob(p[0], c[0], c[1] + ... + c[9])
+ *	merge_prob(p[1], c[9], c[1] + ... + c[8])
+ *	merge_prob(p[2], c[1], c[2] + ... + c[8])
+ *	merge_prob(p[3], c[2] + c[4] + c[5], c[3] + c[8] + c[6] + c[7])
+ *	merge_prob(p[4], c[2], c[4] + c[5])
+ *	merge_prob(p[5], c[4], c[5])
+ *	merge_prob(p[6], c[3], c[8] + c[6] + c[7])
+ *	merge_prob(p[7], c[8], c[6] + c[7])
+ *	merge_prob(p[8], c[6], c[7])
+ *
+ * Variant E
+ * ---------
+ * merge_probs(partition_tree, 0) or
+ * merge_probs(tx_size_32_tree, 0) or
+ * merge_probs(mv_joint_tree, 0) or
+ * merge_probs(mv_fr_tree, 0):
+ *	merge_prob(p[0], c[0], c[1] + c[2] + c[3])
+ *	merge_prob(p[1], c[1], c[2] + c[3])
+ *	merge_prob(p[2], c[2], c[3])
+ *
+ * Variant F
+ * ---------
+ * merge_probs(interp_filter_tree, 0) or
+ * merge_probs(tx_size_16_tree, 0):
+ *	merge_prob(p[0], c[0], c[1] + c[2])
+ *	merge_prob(p[1], c[1], c[2])
+ *
+ * Variant G
+ * ---------
+ * merge_probs(mv_class_tree, 0):
+ *	merge_prob(p[0], c[0], c[1] + ... + c[10])
+ *	merge_prob(p[1], c[1], c[2] + ... + c[10])
+ *	merge_prob(p[2], c[2] + c[3], c[4] + ... + c[10])
+ *	merge_prob(p[3], c[2], c[3])
+ *	merge_prob(p[4], c[4] + c[5], c[6] + ... + c[10])
+ *	merge_prob(p[5], c[4], c[5])
+ *	merge_prob(p[6], c[6], c[7] + ... + c[10])
+ *	merge_prob(p[7], c[7] + c[8], c[9] + c[10])
+ *	merge_prob(p[8], c[7], c[8])
+ *	merge_prob(p[9], c[9], [10])
+ */
+
+static inline void merge_probs_variant_a(u8 *p, const u32 *c, u16 count_sat, u32 update_factor)
+{
+	p[1] = merge_prob(p[1], c[0], c[1] + c[2], count_sat, update_factor);
+	p[2] = merge_prob(p[2], c[1], c[2], count_sat, update_factor);
+}
+
+static inline void merge_probs_variant_b(u8 *p, const u32 *c, u16 count_sat, u32 update_factor)
+{
+	p[0] = merge_prob(p[0], c[0], c[1], count_sat, update_factor);
+}
+
+static inline void merge_probs_variant_c(u8 *p, const u32 *c)
+{
+	p[0] = noncoef_merge_prob(p[0], c[2], c[1] + c[0] + c[3]);
+	p[1] = noncoef_merge_prob(p[1], c[0], c[1] + c[3]);
+	p[2] = noncoef_merge_prob(p[2], c[1], c[3]);
+}
+
+static void merge_probs_variant_d(u8 *p, const u32 *c)
+{
+	u32 sum = 0, s2;
+
+	sum = c[1] + c[2] + c[3] + c[4] + c[5] + c[6] + c[7] + c[8] + c[9];
+
+	p[0] = noncoef_merge_prob(p[0], c[0], sum);
+	sum -= c[9];
+	p[1] = noncoef_merge_prob(p[1], c[9], sum);
+	sum -= c[1];
+	p[2] = noncoef_merge_prob(p[2], c[1], sum);
+	s2 = c[2] + c[4] + c[5];
+	sum -= s2;
+	p[3] = noncoef_merge_prob(p[3], s2, sum);
+	s2 -= c[2];
+	p[4] = noncoef_merge_prob(p[4], c[2], s2);
+	p[5] = noncoef_merge_prob(p[5], c[4], c[5]);
+	sum -= c[3];
+	p[6] = noncoef_merge_prob(p[6], c[3], sum);
+	sum -= c[8];
+	p[7] = noncoef_merge_prob(p[7], c[8], sum);
+	p[8] = noncoef_merge_prob(p[8], c[6], c[7]);
+}
+
+static inline void merge_probs_variant_e(u8 *p, const u32 *c)
+{
+	p[0] = noncoef_merge_prob(p[0], c[0], c[1] + c[2] + c[3]);
+	p[1] = noncoef_merge_prob(p[1], c[1], c[2] + c[3]);
+	p[2] = noncoef_merge_prob(p[2], c[2], c[3]);
+}
+
+static inline void merge_probs_variant_f(u8 *p, const u32 *c)
+{
+	p[0] = noncoef_merge_prob(p[0], c[0], c[1] + c[2]);
+	p[1] = noncoef_merge_prob(p[1], c[1], c[2]);
+}
+
+static void merge_probs_variant_g(u8 *p, const u32 *c)
+{
+	u32 sum;
+
+	sum = c[1] + c[2] + c[3] + c[4] + c[5] + c[6] + c[7] + c[8] + c[9] + c[10];
+	p[0] = noncoef_merge_prob(p[0], c[0], sum);
+	sum -= c[1];
+	p[1] = noncoef_merge_prob(p[1], c[1], sum);
+	sum -= c[2] + c[3];
+	p[2] = noncoef_merge_prob(p[2], c[2] + c[3], sum);
+	p[3] = noncoef_merge_prob(p[3], c[2], c[3]);
+	sum -= c[4] + c[5];
+	p[4] = noncoef_merge_prob(p[4], c[4] + c[5], sum);
+	p[5] = noncoef_merge_prob(p[5], c[4], c[5]);
+	sum -= c[6];
+	p[6] = noncoef_merge_prob(p[6], c[6], sum);
+	p[7] = noncoef_merge_prob(p[7], c[7] + c[8], c[9] + c[10]);
+	p[8] = noncoef_merge_prob(p[8], c[7], c[8]);
+	p[9] = noncoef_merge_prob(p[9], c[9], c[10]);
+}
+
+/* 8.4.3 Coefficient probability adaptation process */
+static inline void adapt_probs_variant_a_coef(u8 *p, const u32 *c, u32 update_factor)
+{
+	merge_probs_variant_a(p, c, 24, update_factor);
+}
+
+static inline void adapt_probs_variant_b_coef(u8 *p, const u32 *c, u32 update_factor)
+{
+	merge_probs_variant_b(p, c, 24, update_factor);
+}
+
+static void _adapt_coeff(u8 coef[6][6][3],
+			 const struct rkvdec_vp9_refs_counts ref_cnt[6][6],
+			 u32 uf)
+{
+	s32 l, m;
+
+	for (l = 0; l < 6; l++) {
+		for (m = 0; m < BAND_6(l); m++) {
+			u8 *p = coef[l][m];
+			const u32 counts_more_coefs[2] = {
+				ref_cnt[l][m].eob[1],
+				ref_cnt[l][m].eob[0] - ref_cnt[l][m].eob[1],
+			};
+
+			adapt_probs_variant_a_coef(p, ref_cnt[l][m].coeff, uf);
+			adapt_probs_variant_b_coef(p, counts_more_coefs, uf);
+		}
+	}
+}
+
+static void _adapt_coef_probs(struct rkvdec_vp9_frame_context *probs,
+			      const struct rkvdec_vp9_refs_counts ref_cnt[2][4][2][6][6],
+			      unsigned int uf)
+{
+	unsigned int i, j, k;
+
+	for (i = 0; i < ARRAY_SIZE(probs->coef); i++)
+		for (j = 0; j < ARRAY_SIZE(probs->coef[0]); j++)
+			for (k = 0; k < ARRAY_SIZE(probs->coef[0][0]); k++)
+				_adapt_coeff(probs->coef[i][j][k], ref_cnt[k][i][j], uf);
+}
+
+static void adapt_coef_probs(struct rkvdec_vp9_frame_context *probs,
+			     struct rkvdec_aux_buf *count_tbl,
+			     struct rkvdec_vp9_frame_info *last,
+			     bool frame_is_intra)
+{
+	if (frame_is_intra) {
+		const struct rkvdec_vp9_intra_frame_symbol_counts *sym_cnts;
+
+		sym_cnts = count_tbl->cpu;
+		_adapt_coef_probs(probs, sym_cnts->ref_cnt, 112);
+	} else {
+		const struct rkvdec_vp9_inter_frame_symbol_counts *sym_cnts;
+
+		sym_cnts = count_tbl->cpu;
+		if (last->valid &&
+		    !(last->flags & V4L2_VP9_FRAME_FLAG_KEY_FRAME))
+			_adapt_coef_probs(probs, sym_cnts->ref_cnt, 112);
+		else
+			_adapt_coef_probs(probs, sym_cnts->ref_cnt, 128);
+	}
+}
+
+/* 8.4.4 Non coefficient probability adaptation process, adapt_probs() */
+static inline void adapt_probs_variant_b(u8 *p, const u32 *c)
+{
+	merge_probs_variant_b(p, c, 20, 128);
+}
+
+static inline void adapt_probs_variant_c(u8 *p, const u32 *c)
+{
+	merge_probs_variant_c(p, c);
+}
+
+static inline void adapt_probs_variant_d(u8 *p, const u32 *c)
+{
+	merge_probs_variant_d(p, c);
+}
+
+static inline void adapt_probs_variant_e(u8 *p, const u32 *c)
+{
+	merge_probs_variant_e(p, c);
+}
+
+static inline void adapt_probs_variant_f(u8 *p, const u32 *c)
+{
+	merge_probs_variant_f(p, c);
+}
+
+static inline void adapt_probs_variant_g(u8 *p, const u32 *c)
+{
+	merge_probs_variant_g(p, c);
+}
+
+/* 8.4.4 Non coefficient probability adaptation process, adapt_prob() */
+static inline u8 adapt_prob(u8 prob, const u32 counts[2])
+{
+	return noncoef_merge_prob(prob, counts[0], counts[1]);
+}
+
+/* 8.4.4 Non coefficient probability adaptation process */
+static void adapt_noncoef_probs(struct rkvdec_ctx *ctx)
+{
+	struct rkvdec_vp9_ctx *vp9_ctx = ctx->priv;
+	struct rkvdec_vp9_frame_context *probs = &vp9_ctx->probability_tables;
+	const struct rkvdec_vp9_inter_frame_symbol_counts *sym_cnts;
+	unsigned int i, j;
+
+	sym_cnts = vp9_ctx->count_tbl.cpu;
+
+	for (i = 0; i < ARRAY_SIZE(probs->is_inter); i++)
+		probs->is_inter[i] = adapt_prob(probs->is_inter[i], sym_cnts->inter[i]);
+
+	for (i = 0; i < ARRAY_SIZE(probs->comp_mode); i++)
+		probs->comp_mode[i] = adapt_prob(probs->comp_mode[i], sym_cnts->comp[i]);
+
+	for (i = 0; i < ARRAY_SIZE(probs->comp_ref); i++)
+		probs->comp_ref[i] = adapt_prob(probs->comp_ref[i], sym_cnts->comp_ref[i]);
+
+	if (vp9_ctx->cur.reference_mode != V4L2_VP9_REF_MODE_COMPOUND)
+		for (i = 0; i < ARRAY_SIZE(probs->single_ref); i++)
+			for (j = 0; j < ARRAY_SIZE(probs->single_ref[0]); j++)
+				probs->single_ref[i][j] = adapt_prob(probs->single_ref[i][j],
+								     sym_cnts->single_ref[i][j]);
+
+	for (i = 0; i < ARRAY_SIZE(probs->inter_mode); i++)
+		adapt_probs_variant_c(probs->inter_mode[i], sym_cnts->mv_mode[i]);
+
+	for (i = 0; i < ARRAY_SIZE(probs->y_mode); i++)
+		adapt_probs_variant_d(probs->y_mode[i], sym_cnts->y_mode[i]);
+
+	for (i = 0; i < ARRAY_SIZE(probs->uv_mode); i++)
+		adapt_probs_variant_d(probs->uv_mode[i], sym_cnts->uv_mode[i]);
+
+	for (i = 0; i < ARRAY_SIZE(probs->partition); i++)
+		adapt_probs_variant_e(probs->partition[i], sym_cnts->partition[i]);
+
+	for (i = 0; i < ARRAY_SIZE(probs->skip); i++)
+		probs->skip[i] = adapt_prob(probs->skip[i], sym_cnts->skip[i]);
+
+	if (vp9_ctx->cur.interpolation_filter == V4L2_VP9_INTERP_FILTER_SWITCHABLE)
+		for (i = 0; i < ARRAY_SIZE(probs->interp_filter); i++)
+			adapt_probs_variant_f(probs->interp_filter[i], sym_cnts->filter[i]);
+
+	if (vp9_ctx->cur.tx_mode == V4L2_VP9_TX_MODE_SELECT)
+		for (i = 0; i < ARRAY_SIZE(probs->tx8); i++) {
+			adapt_probs_variant_b(probs->tx8[i], sym_cnts->tx8p[i]);
+			adapt_probs_variant_f(probs->tx16[i], sym_cnts->tx16p[i]);
+			adapt_probs_variant_e(probs->tx32[i], sym_cnts->tx32p[i]);
+		}
+
+	adapt_probs_variant_e(probs->mv.joint, sym_cnts->mv_joint);
+
+	for (i = 0; i < ARRAY_SIZE(probs->mv.sign); i++) {
+		probs->mv.sign[i] = adapt_prob(probs->mv.sign[i], sym_cnts->sign[i]);
+
+		adapt_probs_variant_g(probs->mv.class[i], sym_cnts->classes[i]);
+
+		probs->mv.class0_bit[i] = adapt_prob(probs->mv.class0_bit[i], sym_cnts->class0[i]);
+
+		for (j = 0; j < ARRAY_SIZE(probs->mv.bits[0]); j++)
+			probs->mv.bits[i][j] = adapt_prob(probs->mv.bits[i][j],
+							  sym_cnts->bits[i][j]);
+
+		for (j = 0; j < ARRAY_SIZE(probs->mv.class0_fr[0]); j++)
+			adapt_probs_variant_e(probs->mv.class0_fr[i][j],
+					      sym_cnts->class0_fp[i][j]);
+
+		adapt_probs_variant_e(probs->mv.fr[i], sym_cnts->fp[i]);
+
+		if (!(vp9_ctx->cur.flags & V4L2_VP9_FRAME_FLAG_ALLOW_HIGH_PREC_MV))
+			continue;
+
+		probs->mv.class0_hp[i] = adapt_prob(probs->mv.class0_hp[i],
+						    sym_cnts->class0_hp[i]);
+
+		probs->mv.hp[i] = adapt_prob(probs->mv.hp[i], sym_cnts->hp[i]);
+	}
+}
+
+#define copy_tx_and_skip(p1, p2)				\
+do {								\
+	memcpy((p1)->tx8, (p2)->tx8, sizeof((p1)->tx8));	\
+	memcpy((p1)->tx16, (p2)->tx16, sizeof((p1)->tx16));	\
+	memcpy((p1)->tx32, (p2)->tx32, sizeof((p1)->tx32));	\
+	memcpy((p1)->skip, (p2)->skip, sizeof((p1)->skip));	\
+} while (0)
+
+static void rkvdec_vp9_done(struct rkvdec_ctx *ctx,
+			    struct vb2_v4l2_buffer *src_buf,
+			    struct vb2_v4l2_buffer *dst_buf,
+			    enum vb2_buffer_state result)
+{
+	struct rkvdec_vp9_ctx *vp9_ctx = ctx->priv;
+	unsigned int fctx_idx;
+
+	/* v4l2-specific stuff */
+	if (result == VB2_BUF_STATE_ERROR)
+		goto out_update_last;
+
+	/*
+	 * vp9 stuff
+	 *
+	 * 6.1.2 refresh_probs()
+	 *
+	 * In the spec a complementary condition goes last in 6.1.2 refresh_probs(),
+	 * but it makes no sense to perform all the activities from the first "if"
+	 * there if we actually are not refreshing the frame context. On top of that,
+	 * because of 6.2 uncompressed_header() whenever error_resilient_mode == 1,
+	 * refresh_frame_context == 0. Consequently, if we don't jump to out_update_last
+	 * it means error_resilient_mode must be 0.
+	 */
+	if (!(vp9_ctx->cur.flags & V4L2_VP9_FRAME_FLAG_REFRESH_FRAME_CTX))
+		goto out_update_last;
+
+	fctx_idx = vp9_ctx->cur.frame_context_idx;
+
+	if (!(vp9_ctx->cur.flags & V4L2_VP9_FRAME_FLAG_PARALLEL_DEC_MODE)) {
+		/* error_resilient_mode == 0 && frame_parallel_decoding_mode == 0 */
+		struct rkvdec_vp9_frame_context *probs = &vp9_ctx->probability_tables;
+		bool frame_is_intra = vp9_ctx->cur.flags &
+		    (V4L2_VP9_FRAME_FLAG_KEY_FRAME | V4L2_VP9_FRAME_FLAG_INTRA_ONLY);
+		struct tx_and_skip {
+			u8 tx8[2][1];
+			u8 tx16[2][2];
+			u8 tx32[2][3];
+			u8 skip[3];
+		} _tx_skip, *tx_skip = &_tx_skip;
+
+		/* buffer the forward-updated TX and skip probs */
+		if (frame_is_intra)
+			copy_tx_and_skip(tx_skip, probs);
+
+		/* 6.1.2 refresh_probs(): load_probs() and load_probs2() */
+		*probs = vp9_ctx->frame_context[fctx_idx];
+
+		/* if FrameIsIntra then undo the effect of load_probs2() */
+		if (frame_is_intra)
+			copy_tx_and_skip(probs, tx_skip);
+
+		adapt_coef_probs(probs, &vp9_ctx->count_tbl, &vp9_ctx->last, frame_is_intra);
+		if (!frame_is_intra) {
+			/* load_probs2() already done */
+			adapt_noncoef_probs(ctx);
+		}
+	}
+
+	/* 6.1.2 refresh_probs(): save_probs(fctx_idx) */
+	vp9_ctx->frame_context[fctx_idx] = vp9_ctx->probability_tables;
+
+out_update_last:
+	update_ctx_last_info(vp9_ctx);
+}
+
+static int rkvdec_vp9_start(struct rkvdec_ctx *ctx)
+{
+	struct rkvdec_dev *rkvdec = ctx->dev;
+	struct rkvdec_vp9_priv_tbl *priv_tbl;
+	struct rkvdec_vp9_ctx *vp9_ctx;
+	u8 *count_tbl;
+	int ret;
+
+	vp9_ctx = kzalloc(sizeof(*vp9_ctx), GFP_KERNEL);
+	if (!vp9_ctx)
+		return -ENOMEM;
+
+	ctx->priv = vp9_ctx;
+
+	priv_tbl = dma_alloc_coherent(rkvdec->dev, sizeof(*priv_tbl),
+				      &vp9_ctx->priv_tbl.dma, GFP_KERNEL);
+	if (!priv_tbl) {
+		ret = -ENOMEM;
+		goto err_free_ctx;
+	}
+
+	vp9_ctx->priv_tbl.size = sizeof(*priv_tbl);
+	vp9_ctx->priv_tbl.cpu = priv_tbl;
+	memset(priv_tbl, 0, sizeof(*priv_tbl));
+
+	count_tbl = dma_alloc_coherent(rkvdec->dev, RKVDEC_VP9_COUNT_SIZE,
+				       &vp9_ctx->count_tbl.dma, GFP_KERNEL);
+	if (!count_tbl) {
+		ret = -ENOMEM;
+		goto err_free_priv_tbl;
+	}
+
+	vp9_ctx->count_tbl.size = RKVDEC_VP9_COUNT_SIZE;
+	vp9_ctx->count_tbl.cpu = count_tbl;
+	memset(count_tbl, 0, sizeof(*count_tbl));
+
+	return 0;
+
+err_free_priv_tbl:
+	dma_free_coherent(rkvdec->dev, vp9_ctx->priv_tbl.size,
+			  vp9_ctx->priv_tbl.cpu, vp9_ctx->priv_tbl.dma);
+
+err_free_ctx:
+	kfree(vp9_ctx);
+	return ret;
+}
+
+static void rkvdec_vp9_stop(struct rkvdec_ctx *ctx)
+{
+	struct rkvdec_vp9_ctx *vp9_ctx = ctx->priv;
+	struct rkvdec_dev *rkvdec = ctx->dev;
+
+	dma_free_coherent(rkvdec->dev, vp9_ctx->count_tbl.size,
+			  vp9_ctx->count_tbl.cpu, vp9_ctx->count_tbl.dma);
+	dma_free_coherent(rkvdec->dev, vp9_ctx->priv_tbl.size,
+			  vp9_ctx->priv_tbl.cpu, vp9_ctx->priv_tbl.dma);
+	kfree(vp9_ctx);
+}
+
+static int rkvdec_vp9_adjust_fmt(struct rkvdec_ctx *ctx,
+				 struct v4l2_format *f)
+{
+	struct v4l2_pix_format_mplane *fmt = &f->fmt.pix_mp;
+
+	fmt->num_planes = 1;
+	if (!fmt->plane_fmt[0].sizeimage)
+		fmt->plane_fmt[0].sizeimage = fmt->width * fmt->height * 2;
+	return 0;
+}
+
+const struct rkvdec_coded_fmt_ops rkvdec_vp9_fmt_ops = {
+	.adjust_fmt = rkvdec_vp9_adjust_fmt,
+	.start = rkvdec_vp9_start,
+	.stop = rkvdec_vp9_stop,
+	.run = rkvdec_vp9_run,
+	.done = rkvdec_vp9_done,
+};
diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c
index ef2166043127..7a931affa8fd 100644
--- a/drivers/staging/media/rkvdec/rkvdec.c
+++ b/drivers/staging/media/rkvdec/rkvdec.c
@@ -99,10 +99,30 @@ static const struct rkvdec_ctrls rkvdec_h264_ctrls = {
 	.num_ctrls = ARRAY_SIZE(rkvdec_h264_ctrl_descs),
 };
 
-static const u32 rkvdec_h264_decoded_fmts[] = {
+static const u32 rkvdec_h264_vp9_decoded_fmts[] = {
 	V4L2_PIX_FMT_NV12,
 };
 
+static const struct rkvdec_ctrl_desc rkvdec_vp9_ctrl_descs[] = {
+	{
+		.cfg.id = V4L2_CID_STATELESS_VP9_FRAME_DECODE_PARAMS,
+	},
+	{
+		.cfg.id = V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS,
+	},
+	{
+		.cfg.id = V4L2_CID_MPEG_VIDEO_VP9_PROFILE,
+		.cfg.min = V4L2_MPEG_VIDEO_VP9_PROFILE_0,
+		.cfg.max = V4L2_MPEG_VIDEO_VP9_PROFILE_0,
+		.cfg.def = V4L2_MPEG_VIDEO_VP9_PROFILE_0,
+	},
+};
+
+static const struct rkvdec_ctrls rkvdec_vp9_ctrls = {
+	.ctrls = rkvdec_vp9_ctrl_descs,
+	.num_ctrls = ARRAY_SIZE(rkvdec_vp9_ctrl_descs),
+};
+
 static const struct rkvdec_coded_fmt_desc rkvdec_coded_fmts[] = {
 	{
 		.fourcc = V4L2_PIX_FMT_H264_SLICE,
@@ -116,8 +136,23 @@ static const struct rkvdec_coded_fmt_desc rkvdec_coded_fmts[] = {
 		},
 		.ctrls = &rkvdec_h264_ctrls,
 		.ops = &rkvdec_h264_fmt_ops,
-		.num_decoded_fmts = ARRAY_SIZE(rkvdec_h264_decoded_fmts),
-		.decoded_fmts = rkvdec_h264_decoded_fmts,
+		.num_decoded_fmts = ARRAY_SIZE(rkvdec_h264_vp9_decoded_fmts),
+		.decoded_fmts = rkvdec_h264_vp9_decoded_fmts,
+	},
+	{
+		.fourcc = V4L2_PIX_FMT_VP9_FRAME,
+		.frmsize = {
+			.min_width = 64,
+			.max_width = 4096,
+			.step_width = 64,
+			.min_height = 64,
+			.max_height = 2304,
+			.step_height = 64,
+		},
+		.ctrls = &rkvdec_vp9_ctrls,
+		.ops = &rkvdec_vp9_fmt_ops,
+		.num_decoded_fmts = ARRAY_SIZE(rkvdec_h264_vp9_decoded_fmts),
+		.decoded_fmts = rkvdec_h264_vp9_decoded_fmts,
 	}
 };
 
@@ -319,7 +354,7 @@ static int rkvdec_s_output_fmt(struct file *file, void *priv,
 	struct v4l2_m2m_ctx *m2m_ctx = ctx->fh.m2m_ctx;
 	const struct rkvdec_coded_fmt_desc *desc;
 	struct v4l2_format *cap_fmt;
-	struct vb2_queue *peer_vq;
+	struct vb2_queue *peer_vq, *vq;
 	int ret;
 
 	/*
@@ -331,6 +366,15 @@ static int rkvdec_s_output_fmt(struct file *file, void *priv,
 	if (vb2_is_busy(peer_vq))
 		return -EBUSY;
 
+	/*
+	 * Some codecs like VP9 can contain dynamic resolution changes which
+	 * are currently not supported by the V4L2 API or driver, so return
+	 * an error if userspace tries to reconfigure the output format.
+	 */
+	vq = v4l2_m2m_get_vq(m2m_ctx, V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE);
+	if (vb2_is_busy(vq))
+		return -EINVAL;
+
 	ret = rkvdec_s_fmt(file, priv, f, rkvdec_try_output_fmt);
 	if (ret)
 		return ret;
diff --git a/drivers/staging/media/rkvdec/rkvdec.h b/drivers/staging/media/rkvdec/rkvdec.h
index 52ac3874c5e5..8f534743eaf1 100644
--- a/drivers/staging/media/rkvdec/rkvdec.h
+++ b/drivers/staging/media/rkvdec/rkvdec.h
@@ -50,6 +50,10 @@ struct rkvdec_vp9_decoded_buffer_info {
 struct rkvdec_decoded_buffer {
 	/* Must be the first field in this struct. */
 	struct v4l2_m2m_buffer base;
+
+	union {
+		struct rkvdec_vp9_decoded_buffer_info vp9;
+	};
 };
 
 static inline struct rkvdec_decoded_buffer *
@@ -116,4 +120,6 @@ void rkvdec_run_preamble(struct rkvdec_ctx *ctx, struct rkvdec_run *run);
 void rkvdec_run_postamble(struct rkvdec_ctx *ctx, struct rkvdec_run *run);
 
 extern const struct rkvdec_coded_fmt_ops rkvdec_h264_fmt_ops;
+extern const struct rkvdec_coded_fmt_ops rkvdec_vp9_fmt_ops;
+
 #endif /* RKVDEC_H_ */
-- 
2.17.1

Re: [RFC RESEND 3/3] media: rkvdec: Add the VP9 backend

[Hans Verkuil]

On 21/04/2021 12:00, Andrzej Pietrasiewicz wrote:
> From: Boris Brezillon <boris.brezillon@collabora.com>
> 
> The Rockchip VDEC supports VP9 profile 0 up to 4096x2304@30fps. Add
> a backend for this new format.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
> ---
>  drivers/staging/media/rkvdec/Makefile     |    2 +-
>  drivers/staging/media/rkvdec/rkvdec-vp9.c | 2846 +++++++++++++++++++++
>  drivers/staging/media/rkvdec/rkvdec.c     |   52 +-
>  drivers/staging/media/rkvdec/rkvdec.h     |    6 +
>  4 files changed, 2901 insertions(+), 5 deletions(-)
>  create mode 100644 drivers/staging/media/rkvdec/rkvdec-vp9.c
> 
> diff --git a/drivers/staging/media/rkvdec/Makefile b/drivers/staging/media/rkvdec/Makefile
> index c08fed0a39f9..cb86b429cfaa 100644
> --- a/drivers/staging/media/rkvdec/Makefile
> +++ b/drivers/staging/media/rkvdec/Makefile
> @@ -1,3 +1,3 @@
>  obj-$(CONFIG_VIDEO_ROCKCHIP_VDEC) += rockchip-vdec.o
>  
> -rockchip-vdec-y += rkvdec.o rkvdec-h264.o
> +rockchip-vdec-y += rkvdec.o rkvdec-h264.o rkvdec-vp9.o
> diff --git a/drivers/staging/media/rkvdec/rkvdec-vp9.c b/drivers/staging/media/rkvdec/rkvdec-vp9.c
> new file mode 100644
> index 000000000000..82e5dcfe5ef0
> --- /dev/null
> +++ b/drivers/staging/media/rkvdec/rkvdec-vp9.c
> @@ -0,0 +1,2846 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Rockchip Video Decoder VP9 backend
> + *
> + * Copyright (C) 2019 Collabora, Ltd.
> + *	Boris Brezillon <boris.brezillon@collabora.com>
> + * Copyright (C) 2021 Collabora, Ltd.
> + *	Andrzej Pietrasiewicz <andrzej.p@collabora.com>
> + *
> + * Copyright (C) 2016 Rockchip Electronics Co., Ltd.
> + *	Alpha Lin <Alpha.Lin@rock-chips.com>
> + */
> +
> +/*
> + * For following the vp9 spec please start reading this driver
> + * code from rkvdec_vp9_run() followed by rkvdec_vp9_done().
> + */
> +
> +#include <linux/kernel.h>
> +#include <linux/vmalloc.h>
> +#include <media/v4l2-mem2mem.h>
> +
> +#include "rkvdec.h"
> +#include "rkvdec-regs.h"
> +
> +#define RKVDEC_VP9_PROBE_SIZE		4864
> +#define RKVDEC_VP9_COUNT_SIZE		13232
> +#define RKVDEC_VP9_MAX_SEGMAP_SIZE	73728
> +
> +struct rkvdec_vp9_intra_mode_probs {
> +	u8 y_mode[105];
> +	u8 uv_mode[23];
> +};
> +
> +struct rkvdec_vp9_intra_only_frame_probs {
> +	u8 coef_intra[4][2][128];
> +	struct rkvdec_vp9_intra_mode_probs intra_mode[10];
> +};
> +
> +struct rkvdec_vp9_inter_frame_probs {
> +	u8 y_mode[4][9];
> +	u8 comp_mode[5];
> +	u8 comp_ref[5];
> +	u8 single_ref[5][2];
> +	u8 inter_mode[7][3];
> +	u8 interp_filter[4][2];
> +	u8 padding0[11];
> +	u8 coef[2][4][2][128];
> +	u8 uv_mode_0_2[3][9];
> +	u8 padding1[5];
> +	u8 uv_mode_3_5[3][9];
> +	u8 padding2[5];
> +	u8 uv_mode_6_8[3][9];
> +	u8 padding3[5];
> +	u8 uv_mode_9[9];
> +	u8 padding4[7];
> +	u8 padding5[16];
> +	struct {
> +		u8 joint[3];
> +		u8 sign[2];
> +		u8 class[2][10];
> +		u8 class0_bit[2];
> +		u8 bits[2][10];
> +		u8 class0_fr[2][2][3];
> +		u8 fr[2][3];
> +		u8 class0_hp[2];
> +		u8 hp[2];
> +	} mv;
> +};
> +
> +struct rkvdec_vp9_probs {
> +	u8 partition[16][3];
> +	u8 pred[3];
> +	u8 tree[7];
> +	u8 skip[3];
> +	u8 tx32[2][3];
> +	u8 tx16[2][2];
> +	u8 tx8[2][1];
> +	u8 is_inter[4];
> +	/* 128 bit alignment */
> +	u8 padding0[3];
> +	union {
> +		struct rkvdec_vp9_inter_frame_probs inter;
> +		struct rkvdec_vp9_intra_only_frame_probs intra_only;
> +	};
> +};
> +
> +/* Data structure describing auxiliary buffer format. */
> +struct rkvdec_vp9_priv_tbl {
> +	struct rkvdec_vp9_probs probs;
> +	u8 segmap[2][RKVDEC_VP9_MAX_SEGMAP_SIZE];
> +};
> +
> +struct rkvdec_vp9_refs_counts {
> +	u32 eob[2];
> +	u32 coeff[3];
> +};
> +
> +struct rkvdec_vp9_inter_frame_symbol_counts {
> +	u32 partition[16][4];
> +	u32 skip[3][2];
> +	u32 inter[4][2];
> +	u32 tx32p[2][4];
> +	u32 tx16p[2][4];
> +	u32 tx8p[2][2];
> +	u32 y_mode[4][10];
> +	u32 uv_mode[10][10];
> +	u32 comp[5][2];
> +	u32 comp_ref[5][2];
> +	u32 single_ref[5][2][2];
> +	u32 mv_mode[7][4];
> +	u32 filter[4][3];
> +	u32 mv_joint[4];
> +	u32 sign[2][2];
> +	/* add 1 element for align */
> +	u32 classes[2][11 + 1];
> +	u32 class0[2][2];
> +	u32 bits[2][10][2];
> +	u32 class0_fp[2][2][4];
> +	u32 fp[2][4];
> +	u32 class0_hp[2][2];
> +	u32 hp[2][2];
> +	struct rkvdec_vp9_refs_counts ref_cnt[2][4][2][6][6];
> +};
> +
> +struct rkvdec_vp9_intra_frame_symbol_counts {
> +	u32 partition[4][4][4];
> +	u32 skip[3][2];
> +	u32 intra[4][2];
> +	u32 tx32p[2][4];
> +	u32 tx16p[2][4];
> +	u32 tx8p[2][2];
> +	struct rkvdec_vp9_refs_counts ref_cnt[2][4][2][6][6];
> +};
> +
> +struct rkvdec_vp9_run {
> +	struct rkvdec_run base;
> +	const struct v4l2_ctrl_vp9_frame_decode_params *decode_params;
> +};
> +
> +struct rkvdec_vp9_frame_info {
> +	u32 valid : 1;
> +	u32 segmapid : 1;
> +	u32 frame_context_idx : 2;
> +	u32 reference_mode : 2;
> +	u32 tx_mode : 3;
> +	u32 interpolation_filter : 3;
> +	u32 flags;
> +	u64 timestamp;
> +	struct v4l2_vp9_segmentation seg;
> +	struct v4l2_vp9_loop_filter lf;
> +};
> +
> +struct rkvdec_vp9_frame_mv_context {
> +	u8 joint[3];
> +	u8 sign[2];
> +	u8 class[2][10];
> +	u8 class0_bit[2];
> +	u8 bits[2][10];
> +	u8 class0_fr[2][2][3];
> +	u8 fr[2][3];
> +	u8 class0_hp[2];
> +	u8 hp[2];
> +};
> +
> +struct rkvdec_vp9_frame_context {
> +	u8 tx8[2][1];
> +	u8 tx16[2][2];
> +	u8 tx32[2][3];
> +	u8 coef[4][2][2][6][6][3];
> +	u8 skip[3];
> +	u8 inter_mode[7][3];
> +	u8 interp_filter[4][2];
> +	u8 is_inter[4];
> +	u8 comp_mode[5];
> +	u8 single_ref[5][2];
> +	u8 comp_ref[5];
> +	u8 y_mode[4][9];
> +	u8 uv_mode[10][9];
> +	u8 partition[16][3];
> +
> +	struct rkvdec_vp9_frame_mv_context mv;
> +};
> +
> +struct rkvdec_vp9_ctx {
> +	struct rkvdec_aux_buf priv_tbl;
> +	struct rkvdec_aux_buf count_tbl;
> +	struct rkvdec_vp9_frame_context probability_tables;
> +	struct rkvdec_vp9_frame_context frame_context[4];
> +	struct rkvdec_vp9_frame_info cur;
> +	struct rkvdec_vp9_frame_info last;
> +};
> +
> +static u32 rkvdec_fastdiv(u32 dividend, u16 divisor)
> +{
> +#define DIV_INV(d)	((u32)(((1ULL << 32) + ((d) - 1)) / (d)))
> +#define DIVS_INV(d0, d1, d2, d3, d4, d5, d6, d7, d8, d9)	\
> +	DIV_INV(d0), DIV_INV(d1), DIV_INV(d2), DIV_INV(d3),	\
> +	DIV_INV(d4), DIV_INV(d5), DIV_INV(d6), DIV_INV(d7),	\
> +	DIV_INV(d8), DIV_INV(d9)
> +
> +	static const u32 inv[] = {
> +		DIV_INV(2), DIV_INV(3), DIV_INV(4), DIV_INV(5),
> +		DIV_INV(6), DIV_INV(7), DIV_INV(8), DIV_INV(9),
> +		DIVS_INV(10, 11, 12, 13, 14, 15, 16, 17, 18, 19),
> +		DIVS_INV(20, 21, 22, 23, 24, 25, 26, 27, 28, 29),
> +		DIVS_INV(30, 31, 32, 33, 34, 35, 36, 37, 38, 39),
> +		DIVS_INV(40, 41, 42, 43, 44, 45, 46, 47, 48, 49),
> +		DIVS_INV(50, 51, 52, 53, 54, 55, 56, 57, 58, 59),
> +		DIVS_INV(60, 61, 62, 63, 64, 65, 66, 67, 68, 69),
> +		DIVS_INV(70, 71, 72, 73, 74, 75, 76, 77, 78, 79),
> +		DIVS_INV(80, 81, 82, 83, 84, 85, 86, 87, 88, 89),
> +		DIVS_INV(90, 91, 92, 93, 94, 95, 96, 97, 98, 99),
> +		DIVS_INV(100, 101, 102, 103, 104, 105, 106, 107, 108, 109),
> +		DIVS_INV(110, 111, 112, 113, 114, 115, 116, 117, 118, 119),
> +		DIVS_INV(120, 121, 122, 123, 124, 125, 126, 127, 128, 129),
> +		DIVS_INV(130, 131, 132, 133, 134, 135, 136, 137, 138, 139),
> +		DIVS_INV(140, 141, 142, 143, 144, 145, 146, 147, 148, 149),
> +		DIVS_INV(150, 151, 152, 153, 154, 155, 156, 157, 158, 159),
> +		DIVS_INV(160, 161, 162, 163, 164, 165, 166, 167, 168, 169),
> +		DIVS_INV(170, 171, 172, 173, 174, 175, 176, 177, 178, 179),
> +		DIVS_INV(180, 181, 182, 183, 184, 185, 186, 187, 188, 189),
> +		DIVS_INV(190, 191, 192, 193, 194, 195, 196, 197, 198, 199),
> +		DIVS_INV(200, 201, 202, 203, 204, 205, 206, 207, 208, 209),
> +		DIVS_INV(210, 211, 212, 213, 214, 215, 216, 217, 218, 219),
> +		DIVS_INV(220, 221, 222, 223, 224, 225, 226, 227, 228, 229),
> +		DIVS_INV(230, 231, 232, 233, 234, 235, 236, 237, 238, 239),
> +		DIVS_INV(240, 241, 242, 243, 244, 245, 246, 247, 248, 249),
> +		DIV_INV(250), DIV_INV(251), DIV_INV(252), DIV_INV(253),
> +		DIV_INV(254), DIV_INV(255), DIV_INV(256),
> +	};

Is this and the other static const arrays below specific to this driver,
or generic for VP9? If the latter, then it is something for a v4l2-vp9.c.

> +
> +	if (divisor == 0)
> +		return 0;
> +	else if (divisor == 1)
> +		return dividend;
> +
> +	if (WARN_ON(divisor - 2 >= ARRAY_SIZE(inv)))
> +		return dividend;
> +
> +	return ((u64)dividend * inv[divisor - 2]) >> 32;
> +}
> +
> +static const u8 vp9_kf_y_mode_prob[10][10][9] = {
> +	{
> +		/* above = dc */
> +		{ 137,  30,  42, 148, 151, 207,  70,  52,  91 },/*left = dc  */

Add a space after , and before /*

That should make it a bit easier to read (it feels a bit cramped right now).

> +		{  92,  45, 102, 136, 116, 180,  74,  90, 100 },/*left = v   */
> +		{  73,  32,  19, 187, 222, 215,  46,  34, 100 },/*left = h   */
> +		{  91,  30,  32, 116, 121, 186,  93,  86,  94 },/*left = d45 */
> +		{  72,  35,  36, 149,  68, 206,  68,  63, 105 },/*left = d135*/
> +		{  73,  31,  28, 138,  57, 124,  55, 122, 151 },/*left = d117*/
> +		{  67,  23,  21, 140, 126, 197,  40,  37, 171 },/*left = d153*/
> +		{  86,  27,  28, 128, 154, 212,  45,  43,  53 },/*left = d207*/
> +		{  74,  32,  27, 107,  86, 160,  63, 134, 102 },/*left = d63 */
> +		{  59,  67,  44, 140, 161, 202,  78,  67, 119 } /*left = tm  */
> +	}, {  /* above = v */
> +		{  63,  36, 126, 146, 123, 158,  60,  90,  96 },/*left = dc  */
> +		{  43,  46, 168, 134, 107, 128,  69, 142,  92 },/*left = v   */
> +		{  44,  29,  68, 159, 201, 177,  50,  57,  77 },/*left = h   */
> +		{  58,  38,  76, 114,  97, 172,  78, 133,  92 },/*left = d45 */
> +		{  46,  41,  76, 140,  63, 184,  69, 112,  57 },/*left = d135*/
> +		{  38,  32,  85, 140,  46, 112,  54, 151, 133 },/*left = d117*/
> +		{  39,  27,  61, 131, 110, 175,  44,  75, 136 },/*left = d153*/
> +		{  52,  30,  74, 113, 130, 175,  51,  64,  58 },/*left = d207*/
> +		{  47,  35,  80, 100,  74, 143,  64, 163,  74 },/*left = d63 */
> +		{  36,  61, 116, 114, 128, 162,  80, 125,  82 } /*left = tm  */
> +	}, {  /* above = h */
> +		{  82,  26,  26, 171, 208, 204,  44,  32, 105 },/*left = dc  */
> +		{  55,  44,  68, 166, 179, 192,  57,  57, 108 },/*left = v   */
> +		{  42,  26,  11, 199, 241, 228,  23,  15,  85 },/*left = h   */
> +		{  68,  42,  19, 131, 160, 199,  55,  52,  83 },/*left = d45 */
> +		{  58,  50,  25, 139, 115, 232,  39,  52, 118 },/*left = d135*/
> +		{  50,  35,  33, 153, 104, 162,  64,  59, 131 },/*left = d117*/
> +		{  44,  24,  16, 150, 177, 202,  33,  19, 156 },/*left = d153*/
> +		{  55,  27,  12, 153, 203, 218,  26,  27,  49 },/*left = d207*/
> +		{  53,  49,  21, 110, 116, 168,  59,  80,  76 },/*left = d63 */
> +		{  38,  72,  19, 168, 203, 212,  50,  50, 107 } /*left = tm  */
> +	}, {  /* above = d45 */
> +		{ 103,  26,  36, 129, 132, 201,  83,  80,  93 },/*left = dc  */
> +		{  59,  38,  83, 112, 103, 162,  98, 136,  90 },/*left = v   */
> +		{  62,  30,  23, 158, 200, 207,  59,  57,  50 },/*left = h   */
> +		{  67,  30,  29,  84,  86, 191, 102,  91,  59 },/*left = d45 */
> +		{  60,  32,  33, 112,  71, 220,  64,  89, 104 },/*left = d135*/
> +		{  53,  26,  34, 130,  56, 149,  84, 120, 103 },/*left = d117*/
> +		{  53,  21,  23, 133, 109, 210,  56,  77, 172 },/*left = d153*/
> +		{  77,  19,  29, 112, 142, 228,  55,  66,  36 },/*left = d207*/
> +		{  61,  29,  29,  93,  97, 165,  83, 175, 162 },/*left = d63 */
> +		{  47,  47,  43, 114, 137, 181, 100,  99,  95 } /*left = tm  */
> +	}, {  /* above = d135 */
> +		{  69,  23,  29, 128,  83, 199,  46,  44, 101 },/*left = dc  */
> +		{  53,  40,  55, 139,  69, 183,  61,  80, 110 },/*left = v   */
> +		{  40,  29,  19, 161, 180, 207,  43,  24,  91 },/*left = h   */
> +		{  60,  34,  19, 105,  61, 198,  53,  64,  89 },/*left = d45 */
> +		{  52,  31,  22, 158,  40, 209,  58,  62,  89 },/*left = d135*/
> +		{  44,  31,  29, 147,  46, 158,  56, 102, 198 },/*left = d117*/
> +		{  35,  19,  12, 135,  87, 209,  41,  45, 167 },/*left = d153*/
> +		{  55,  25,  21, 118,  95, 215,  38,  39,  66 },/*left = d207*/
> +		{  51,  38,  25, 113,  58, 164,  70,  93,  97 },/*left = d63 */
> +		{  47,  54,  34, 146, 108, 203,  72, 103, 151 } /*left = tm  */
> +	}, {  /* above = d117 */
> +		{  64,  19,  37, 156,  66, 138,  49,  95, 133 },/*left = dc  */
> +		{  46,  27,  80, 150,  55, 124,  55, 121, 135 },/*left = v   */
> +		{  36,  23,  27, 165, 149, 166,  54,  64, 118 },/*left = h   */
> +		{  53,  21,  36, 131,  63, 163,  60, 109,  81 },/*left = d45 */
> +		{  40,  26,  35, 154,  40, 185,  51,  97, 123 },/*left = d135*/
> +		{  35,  19,  34, 179,  19,  97,  48, 129, 124 },/*left = d117*/
> +		{  36,  20,  26, 136,  62, 164,  33,  77, 154 },/*left = d153*/
> +		{  45,  18,  32, 130,  90, 157,  40,  79,  91 },/*left = d207*/
> +		{  45,  26,  28, 129,  45, 129,  49, 147, 123 },/*left = d63 */
> +		{  38,  44,  51, 136,  74, 162,  57,  97, 121 } /*left = tm  */
> +	}, {  /* above = d153 */
> +		{  75,  17,  22, 136, 138, 185,  32,  34, 166 },/*left = dc  */
> +		{  56,  39,  58, 133, 117, 173,  48,  53, 187 },/*left = v   */
> +		{  35,  21,  12, 161, 212, 207,  20,  23, 145 },/*left = h   */
> +		{  56,  29,  19, 117, 109, 181,  55,  68, 112 },/*left = d45 */
> +		{  47,  29,  17, 153,  64, 220,  59,  51, 114 },/*left = d135*/
> +		{  46,  16,  24, 136,  76, 147,  41,  64, 172 },/*left = d117*/
> +		{  34,  17,  11, 108, 152, 187,  13,  15, 209 },/*left = d153*/
> +		{  51,  24,  14, 115, 133, 209,  32,  26, 104 },/*left = d207*/
> +		{  55,  30,  18, 122,  79, 179,  44,  88, 116 },/*left = d63 */
> +		{  37,  49,  25, 129, 168, 164,  41,  54, 148 } /*left = tm  */
> +	}, {  /* above = d207 */
> +		{  82,  22,  32, 127, 143, 213,  39,  41,  70 },/*left = dc  */
> +		{  62,  44,  61, 123, 105, 189,  48,  57,  64 },/*left = v   */
> +		{  47,  25,  17, 175, 222, 220,  24,  30,  86 },/*left = h   */
> +		{  68,  36,  17, 106, 102, 206,  59,  74,  74 },/*left = d45 */
> +		{  57,  39,  23, 151,  68, 216,  55,  63,  58 },/*left = d135*/
> +		{  49,  30,  35, 141,  70, 168,  82,  40, 115 },/*left = d117*/
> +		{  51,  25,  15, 136, 129, 202,  38,  35, 139 },/*left = d153*/
> +		{  68,  26,  16, 111, 141, 215,  29,  28,  28 },/*left = d207*/
> +		{  59,  39,  19, 114,  75, 180,  77, 104,  42 },/*left = d63 */
> +		{  40,  61,  26, 126, 152, 206,  61,  59,  93 } /*left = tm  */
> +	}, {  /* above = d63 */
> +		{  78,  23,  39, 111, 117, 170,  74, 124,  94 },/*left = dc  */
> +		{  48,  34,  86, 101,  92, 146,  78, 179, 134 },/*left = v   */
> +		{  47,  22,  24, 138, 187, 178,  68,  69,  59 },/*left = h   */
> +		{  56,  25,  33, 105, 112, 187,  95, 177, 129 },/*left = d45 */
> +		{  48,  31,  27, 114,  63, 183,  82, 116,  56 },/*left = d135*/
> +		{  43,  28,  37, 121,  63, 123,  61, 192, 169 },/*left = d117*/
> +		{  42,  17,  24, 109,  97, 177,  56,  76, 122 },/*left = d153*/
> +		{  58,  18,  28, 105, 139, 182,  70,  92,  63 },/*left = d207*/
> +		{  46,  23,  32,  74,  86, 150,  67, 183,  88 },/*left = d63 */
> +		{  36,  38,  48,  92, 122, 165,  88, 137,  91 } /*left = tm  */
> +	}, {  /* above = tm */
> +		{  65,  70,  60, 155, 159, 199,  61,  60,  81 },/*left = dc  */
> +		{  44,  78, 115, 132, 119, 173,  71, 112,  93 },/*left = v   */
> +		{  39,  38,  21, 184, 227, 206,  42,  32,  64 },/*left = h   */
> +		{  58,  47,  36, 124, 137, 193,  80,  82,  78 },/*left = d45 */
> +		{  49,  50,  35, 144,  95, 205,  63,  78,  59 },/*left = d135*/
> +		{  41,  53,  52, 148,  71, 142,  65, 128,  51 },/*left = d117*/
> +		{  40,  36,  28, 143, 143, 202,  40,  55, 137 },/*left = d153*/
> +		{  52,  34,  29, 129, 183, 227,  42,  35,  43 },/*left = d207*/
> +		{  42,  44,  44, 104, 105, 164,  64, 130,  80 },/*left = d63 */
> +		{  43,  81,  53, 140, 169, 204,  68,  84,  72 } /*left = tm  */
> +	}
> +};
> +
> +static const u8 kf_partition_probs[16][3] = {
> +	/* 8x8 -> 4x4 */
> +	{ 158,  97,  94 },	/* a/l both not split   */
> +	{  93,  24,  99 },	/* a split, l not split */
> +	{  85, 119,  44 },	/* l split, a not split */
> +	{  62,  59,  67 },	/* a/l both split       */
> +	/* 16x16 -> 8x8 */
> +	{ 149,  53,  53 },	/* a/l both not split   */
> +	{  94,  20,  48 },	/* a split, l not split */
> +	{  83,  53,  24 },	/* l split, a not split */
> +	{  52,  18,  18 },	/* a/l both split       */
> +	/* 32x32 -> 16x16 */
> +	{ 150,  40,  39 },	/* a/l both not split   */
> +	{  78,  12,  26 },	/* a split, l not split */
> +	{  67,  33,  11 },	/* l split, a not split */
> +	{  24,   7,   5 },	/* a/l both split       */
> +	/* 64x64 -> 32x32 */
> +	{ 174,  35,  49 },	/* a/l both not split   */
> +	{  68,  11,  27 },	/* a split, l not split */
> +	{  57,  15,   9 },	/* l split, a not split */
> +	{  12,   3,   3 },	/* a/l both split       */
> +};
> +
> +static const u8 kf_uv_mode_prob[10][9] = {
> +	{ 144,  11,  54, 157, 195, 130,  46,  58, 108 },  /* y = dc   */
> +	{ 118,  15, 123, 148, 131, 101,  44,  93, 131 },  /* y = v    */
> +	{ 113,  12,  23, 188, 226, 142,  26,  32, 125 },  /* y = h    */
> +	{ 120,  11,  50, 123, 163, 135,  64,  77, 103 },  /* y = d45  */
> +	{ 113,   9,  36, 155, 111, 157,  32,  44, 161 },  /* y = d135 */
> +	{ 116,   9,  55, 176,  76,  96,  37,  61, 149 },  /* y = d117 */
> +	{ 115,   9,  28, 141, 161, 167,  21,  25, 193 },  /* y = d153 */
> +	{ 120,  12,  32, 145, 195, 142,  32,  38,  86 },  /* y = d207 */
> +	{ 116,  12,  64, 120, 140, 125,  49, 115, 121 },  /* y = d63  */
> +	{ 102,  19,  66, 162, 182, 122,  35,  59, 128 }   /* y = tm   */
> +};
> +
> +static const struct rkvdec_vp9_frame_context vp9_default_probs = {
> +	.tx8 = {
> +		{ 100 },
> +		{  66 },
> +	},
> +	.tx16 = {
> +		{ 20, 152 },
> +		{ 15, 101 },
> +	},
> +	.tx32 = {
> +		{ 3, 136, 37 },
> +		{ 5,  52, 13 },
> +	},
> +	.coef = {
> +		{ /* tx = 4x4 */
> +			{ /* block Type 0 */
> +				{ /* Intra */
> +					{ /* Coeff Band 0 */
> +						{ 195,  29, 183 },
> +						{  84,  49, 136 },
> +						{   8,  42,  71 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +					},
> +					{ /* Coeff Band 1 */
> +						{  31, 107, 169 },
> +						{  35,  99, 159 },
> +						{  17,  82, 140 },
> +						{   8,  66, 114 },
> +						{   2,  44,  76 },
> +						{   1,  19,  32 },
> +					},
> +					{ /* Coeff Band 2 */
> +						{  40, 132, 201 },
> +						{  29, 114, 187 },
> +						{  13,  91, 157 },
> +						{   7,  75, 127 },
> +						{   3,  58,  95 },
> +						{   1,  28,  47 },
> +					},
> +					{ /* Coeff Band 3 */
> +						{  69, 142, 221 },
> +						{  42, 122, 201 },
> +						{  15,  91, 159 },
> +						{   6,  67, 121 },
> +						{   1,  42,  77 },
> +						{   1,  17,  31 },
> +					},
> +					{ /* Coeff Band 4 */
> +						{ 102, 148, 228 },
> +						{  67, 117, 204 },
> +						{  17,  82, 154 },
> +						{   6,  59, 114 },
> +						{   2,  39,  75 },
> +						{   1,  15,  29 },
> +					},
> +					{ /* Coeff Band 5 */
> +						{ 156,  57, 233 },
> +						{ 119,  57, 212 },
> +						{  58,  48, 163 },
> +						{  29,  40, 124 },
> +						{  12,  30,  81 },
> +						{   3,  12,  31 }
> +					},
> +				},
> +				{ /* Inter */
> +					{ /* Coeff Band 0 */
> +						{ 191, 107, 226 },
> +						{ 124, 117, 204 },
> +						{  25,  99, 155 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +					},
> +					{ /* Coeff Band 1 */
> +						{  29, 148, 210 },
> +						{  37, 126, 194 },
> +						{   8,  93, 157 },
> +						{   2,  68, 118 },
> +						{   1,  39,  69 },
> +						{   1,  17,  33 },
> +					},
> +					{ /* Coeff Band 2 */
> +						{  41, 151, 213 },
> +						{  27, 123, 193 },
> +						{   3,  82, 144 },
> +						{   1,  58, 105 },
> +						{   1,  32,  60 },
> +						{   1,  13,  26 },
> +					},
> +					{ /* Coeff Band 3 */
> +						{  59, 159, 220 },
> +						{  23, 126, 198 },
> +						{   4,  88, 151 },
> +						{   1,  66, 114 },
> +						{   1,  38,  71 },
> +						{   1,  18,  34 },
> +					},
> +					{ /* Coeff Band 4 */
> +						{ 114, 136, 232 },
> +						{  51, 114, 207 },
> +						{  11,  83, 155 },
> +						{   3,  56, 105 },
> +						{   1,  33,  65 },
> +						{   1,  17,  34 },
> +					},
> +					{ /* Coeff Band 5 */
> +						{ 149,  65, 234 },
> +						{ 121,  57, 215 },
> +						{  61,  49, 166 },
> +						{  28,  36, 114 },
> +						{  12,  25,  76 },
> +						{   3,  16,  42 },
> +					},
> +				},
> +			},
> +			{ /* block Type 1 */
> +				{ /* Intra */
> +					{ /* Coeff Band 0 */
> +						{ 214,  49, 220 },
> +						{ 132,  63, 188 },
> +						{  42,  65, 137 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +					},
> +					{ /* Coeff Band 1 */
> +						{  85, 137, 221 },
> +						{ 104, 131, 216 },
> +						{  49, 111, 192 },
> +						{  21,  87, 155 },
> +						{   2,  49,  87 },
> +						{   1,  16,  28 },
> +					},
> +					{ /* Coeff Band 2 */
> +						{  89, 163, 230 },
> +						{  90, 137, 220 },
> +						{  29, 100, 183 },
> +						{  10,  70, 135 },
> +						{   2,  42,  81 },
> +						{   1,  17,  33 },
> +					},
> +					{ /* Coeff Band 3 */
> +						{ 108, 167, 237 },
> +						{  55, 133, 222 },
> +						{  15,  97, 179 },
> +						{   4,  72, 135 },
> +						{   1,  45,  85 },
> +						{   1,  19,  38 },
> +					},
> +					{ /* Coeff Band 4 */
> +						{ 124, 146, 240 },
> +						{  66, 124, 224 },
> +						{  17,  88, 175 },
> +						{   4,  58, 122 },
> +						{   1,  36,  75 },
> +						{   1,  18,  37 },
> +					},
> +					{ /* Coeff Band 5 */
> +						{ 141,  79, 241 },
> +						{ 126,  70, 227 },
> +						{  66,  58, 182 },
> +						{  30,  44, 136 },
> +						{  12,  34,  96 },
> +						{   2,  20,  47 },
> +					},
> +				},
> +				{ /* Inter */
> +					{ /* Coeff Band 0 */
> +						{ 229,  99, 249 },
> +						{ 143, 111, 235 },
> +						{  46, 109, 192 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +					},
> +					{ /* Coeff Band 1 */
> +						{  82, 158, 236 },
> +						{  94, 146, 224 },
> +						{  25, 117, 191 },
> +						{   9,  87, 149 },
> +						{   3,  56,  99 },
> +						{   1,  33,  57 },
> +					},
> +					{ /* Coeff Band 2 */
> +						{  83, 167, 237 },
> +						{  68, 145, 222 },
> +						{  10, 103, 177 },
> +						{   2,  72, 131 },
> +						{   1,  41,  79 },
> +						{   1,  20,  39 },
> +					},
> +					{ /* Coeff Band 3 */
> +						{  99, 167, 239 },
> +						{  47, 141, 224 },
> +						{  10, 104, 178 },
> +						{   2,  73, 133 },
> +						{   1,  44,  85 },
> +						{   1,  22,  47 },
> +					},
> +					{ /* Coeff Band 4 */
> +						{ 127, 145, 243 },
> +						{  71, 129, 228 },
> +						{  17,  93, 177 },
> +						{   3,  61, 124 },
> +						{   1,  41,  84 },
> +						{   1,  21,  52 },
> +					},
> +					{ /* Coeff Band 5 */
> +						{ 157,  78, 244 },
> +						{ 140,  72, 231 },
> +						{  69,  58, 184 },
> +						{  31,  44, 137 },
> +						{  14,  38, 105 },
> +						{   8,  23,  61 },
> +					},
> +				},
> +			},
> +		},
> +		{ /* tx = 8x8 */
> +			{ /* block Type 0 */
> +				{ /* Intra */
> +					{ /* Coeff Band 0 */
> +						{ 125,  34, 187 },
> +						{  52,  41, 133 },
> +						{   6,  31,  56 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +					},
> +					{ /* Coeff Band 1 */
> +						{  37, 109, 153 },
> +						{  51, 102, 147 },
> +						{  23,  87, 128 },
> +						{   8,  67, 101 },
> +						{   1,  41,  63 },
> +						{   1,  19,  29 },
> +					},
> +					{ /* Coeff Band 2 */
> +						{  31, 154, 185 },
> +						{  17, 127, 175 },
> +						{   6,  96, 145 },
> +						{   2,  73, 114 },
> +						{   1,  51,  82 },
> +						{   1,  28,  45 },
> +					},
> +					{ /* Coeff Band 3 */
> +						{  23, 163, 200 },
> +						{  10, 131, 185 },
> +						{   2,  93, 148 },
> +						{   1,  67, 111 },
> +						{   1,  41,  69 },
> +						{   1,  14,  24 },
> +					},
> +					{ /* Coeff Band 4 */
> +						{  29, 176, 217 },
> +						{  12, 145, 201 },
> +						{   3, 101, 156 },
> +						{   1,  69, 111 },
> +						{   1,  39,  63 },
> +						{   1,  14,  23 },
> +					},
> +					{ /* Coeff Band 5 */
> +						{  57, 192, 233 },
> +						{  25, 154, 215 },
> +						{   6, 109, 167 },
> +						{   3,  78, 118 },
> +						{   1,  48,  69 },
> +						{   1,  21,  29 },
> +					},
> +				},
> +				{ /* Inter */
> +					{ /* Coeff Band 0 */
> +						{ 202, 105, 245 },
> +						{ 108, 106, 216 },
> +						{  18,  90, 144 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +					},
> +					{ /* Coeff Band 1 */
> +						{  33, 172, 219 },
> +						{  64, 149, 206 },
> +						{  14, 117, 177 },
> +						{   5,  90, 141 },
> +						{   2,  61,  95 },
> +						{   1,  37,  57 },
> +					},
> +					{ /* Coeff Band 2 */
> +						{  33, 179, 220 },
> +						{  11, 140, 198 },
> +						{   1,  89, 148 },
> +						{   1,  60, 104 },
> +						{   1,  33,  57 },
> +						{   1,  12,  21 },
> +					},
> +					{ /* Coeff Band 3 */
> +						{  30, 181, 221 },
> +						{   8, 141, 198 },
> +						{   1,  87, 145 },
> +						{   1,  58, 100 },
> +						{   1,  31,  55 },
> +						{   1,  12,  20 },
> +					},
> +					{ /* Coeff Band 4 */
> +						{  32, 186, 224 },
> +						{   7, 142, 198 },
> +						{   1,  86, 143 },
> +						{   1,  58, 100 },
> +						{   1,  31,  55 },
> +						{   1,  12,  22 },
> +					},
> +					{ /* Coeff Band 5 */
> +						{  57, 192, 227 },
> +						{  20, 143, 204 },
> +						{   3,  96, 154 },
> +						{   1,  68, 112 },
> +						{   1,  42,  69 },
> +						{   1,  19,  32 },
> +					},
> +				},
> +			},
> +			{ /* block Type 1 */
> +				{ /* Intra */
> +					{ /* Coeff Band 0 */
> +						{ 212,  35, 215 },
> +						{ 113,  47, 169 },
> +						{  29,  48, 105 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +					},
> +					{ /* Coeff Band 1 */
> +						{  74, 129, 203 },
> +						{ 106, 120, 203 },
> +						{  49, 107, 178 },
> +						{  19,  84, 144 },
> +						{   4,  50,  84 },
> +						{   1,  15,  25 },
> +					},
> +					{ /* Coeff Band 2 */
> +						{  71, 172, 217 },
> +						{  44, 141, 209 },
> +						{  15, 102, 173 },
> +						{   6,  76, 133 },
> +						{   2,  51,  89 },
> +						{   1,  24,  42 },
> +					},
> +					{ /* Coeff Band 3 */
> +						{  64, 185, 231 },
> +						{  31, 148, 216 },
> +						{   8, 103, 175 },
> +						{   3,  74, 131 },
> +						{   1,  46,  81 },
> +						{   1,  18,  30 },
> +					},
> +					{ /* Coeff Band 4 */
> +						{  65, 196, 235 },
> +						{  25, 157, 221 },
> +						{   5, 105, 174 },
> +						{   1,  67, 120 },
> +						{   1,  38,  69 },
> +						{   1,  15,  30 },
> +					},
> +					{ /* Coeff Band 5 */
> +						{  65, 204, 238 },
> +						{  30, 156, 224 },
> +						{   7, 107, 177 },
> +						{   2,  70, 124 },
> +						{   1,  42,  73 },
> +						{   1,  18,  34 },
> +					},
> +				},
> +				{ /* Inter */
> +					{ /* Coeff Band 0 */
> +						{ 225,  86, 251 },
> +						{ 144, 104, 235 },
> +						{  42,  99, 181 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +					},
> +					{ /* Coeff Band 1 */
> +						{  85, 175, 239 },
> +						{ 112, 165, 229 },
> +						{  29, 136, 200 },
> +						{  12, 103, 162 },
> +						{   6,  77, 123 },
> +						{   2,  53,  84 },
> +					},
> +					{ /* Coeff Band 2 */
> +						{  75, 183, 239 },
> +						{  30, 155, 221 },
> +						{   3, 106, 171 },
> +						{   1,  74, 128 },
> +						{   1,  44,  76 },
> +						{   1,  17,  28 },
> +					},
> +					{ /* Coeff Band 3 */
> +						{  73, 185, 240 },
> +						{  27, 159, 222 },
> +						{   2, 107, 172 },
> +						{   1,  75, 127 },
> +						{   1,  42,  73 },
> +						{   1,  17,  29 },
> +					},
> +					{ /* Coeff Band 4 */
> +						{  62, 190, 238 },
> +						{  21, 159, 222 },
> +						{   2, 107, 172 },
> +						{   1,  72, 122 },
> +						{   1,  40,  71 },
> +						{   1,  18,  32 },
> +					},
> +					{ /* Coeff Band 5 */
> +						{  61, 199, 240 },
> +						{  27, 161, 226 },
> +						{   4, 113, 180 },
> +						{   1,  76, 129 },
> +						{   1,  46,  80 },
> +						{   1,  23,  41 },
> +					},
> +				},
> +			},
> +		},
> +		{ /* tx = 16x16 */
> +			{ /* block Type 0 */
> +				{ /* Intra */
> +					{ /* Coeff Band 0 */
> +						{   7,  27, 153 },
> +						{   5,  30,  95 },
> +						{   1,  16,  30 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +					},
> +					{ /* Coeff Band 1 */
> +						{  50,  75, 127 },
> +						{  57,  75, 124 },
> +						{  27,  67, 108 },
> +						{  10,  54,  86 },
> +						{   1,  33,  52 },
> +						{   1,  12,  18 },
> +					},
> +					{ /* Coeff Band 2 */
> +						{  43, 125, 151 },
> +						{  26, 108, 148 },
> +						{   7,  83, 122 },
> +						{   2,  59,  89 },
> +						{   1,  38,  60 },
> +						{   1,  17,  27 },
> +					},
> +					{ /* Coeff Band 3 */
> +						{  23, 144, 163 },
> +						{  13, 112, 154 },
> +						{   2,  75, 117 },
> +						{   1,  50,  81 },
> +						{   1,  31,  51 },
> +						{   1,  14,  23 },
> +					},
> +					{ /* Coeff Band 4 */
> +						{  18, 162, 185 },
> +						{   6, 123, 171 },
> +						{   1,  78, 125 },
> +						{   1,  51,  86 },
> +						{   1,  31,  54 },
> +						{   1,  14,  23 },
> +					},
> +					{ /* Coeff Band 5 */
> +						{  15, 199, 227 },
> +						{   3, 150, 204 },
> +						{   1,  91, 146 },
> +						{   1,  55,  95 },
> +						{   1,  30,  53 },
> +						{   1,  11,  20 },
> +					}
> +				},
> +				{ /* Inter */
> +					{ /* Coeff Band 0 */
> +						{  19,  55, 240 },
> +						{  19,  59, 196 },
> +						{   3,  52, 105 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +					},
> +					{ /* Coeff Band 1 */
> +						{  41, 166, 207 },
> +						{ 104, 153, 199 },
> +						{  31, 123, 181 },
> +						{  14, 101, 152 },
> +						{   5,  72, 106 },
> +						{   1,  36,  52 },
> +					},
> +					{ /* Coeff Band 2 */
> +						{  35, 176, 211 },
> +						{  12, 131, 190 },
> +						{   2,  88, 144 },
> +						{   1,  60, 101 },
> +						{   1,  36,  60 },
> +						{   1,  16,  28 },
> +					},
> +					{ /* Coeff Band 3 */
> +						{  28, 183, 213 },
> +						{   8, 134, 191 },
> +						{   1,  86, 142 },
> +						{   1,  56,  96 },
> +						{   1,  30,  53 },
> +						{   1,  12,  20 },
> +					},
> +					{ /* Coeff Band 4 */
> +						{  20, 190, 215 },
> +						{   4, 135, 192 },
> +						{   1,  84, 139 },
> +						{   1,  53,  91 },
> +						{   1,  28,  49 },
> +						{   1,  11,  20 },
> +					},
> +					{ /* Coeff Band 5 */
> +						{  13, 196, 216 },
> +						{   2, 137, 192 },
> +						{   1,  86, 143 },
> +						{   1,  57,  99 },
> +						{   1,  32,  56 },
> +						{   1,  13,  24 },
> +					},
> +				},
> +			},
> +			{ /* block Type 1 */
> +				{ /* Intra */
> +					{ /* Coeff Band 0 */
> +						{ 211,  29, 217 },
> +						{  96,  47, 156 },
> +						{  22,  43,  87 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +					},
> +					{ /* Coeff Band 1 */
> +						{  78, 120, 193 },
> +						{ 111, 116, 186 },
> +						{  46, 102, 164 },
> +						{  15,  80, 128 },
> +						{   2,  49,  76 },
> +						{   1,  18,  28 },
> +					},
> +					{ /* Coeff Band 2 */
> +						{  71, 161, 203 },
> +						{  42, 132, 192 },
> +						{  10,  98, 150 },
> +						{   3,  69, 109 },
> +						{   1,  44,  70 },
> +						{   1,  18,  29 },
> +					},
> +					{ /* Coeff Band 3 */
> +						{  57, 186, 211 },
> +						{  30, 140, 196 },
> +						{   4,  93, 146 },
> +						{   1,  62, 102 },
> +						{   1,  38,  65 },
> +						{   1,  16,  27 },
> +					},
> +					{ /* Coeff Band 4 */
> +						{  47, 199, 217 },
> +						{  14, 145, 196 },
> +						{   1,  88, 142 },
> +						{   1,  57,  98 },
> +						{   1,  36,  62 },
> +						{   1,  15,  26 },
> +					},
> +					{ /* Coeff Band 5 */
> +						{  26, 219, 229 },
> +						{   5, 155, 207 },
> +						{   1,  94, 151 },
> +						{   1,  60, 104 },
> +						{   1,  36,  62 },
> +						{   1,  16,  28 },
> +					}
> +				},
> +				{ /* Inter */
> +					{ /* Coeff Band 0 */
> +						{ 233,  29, 248 },
> +						{ 146,  47, 220 },
> +						{  43,  52, 140 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +					},
> +					{ /* Coeff Band 1 */
> +						{ 100, 163, 232 },
> +						{ 179, 161, 222 },
> +						{  63, 142, 204 },
> +						{  37, 113, 174 },
> +						{  26,  89, 137 },
> +						{  18,  68,  97 },
> +					},
> +					{ /* Coeff Band 2 */
> +						{  85, 181, 230 },
> +						{  32, 146, 209 },
> +						{   7, 100, 164 },
> +						{   3,  71, 121 },
> +						{   1,  45,  77 },
> +						{   1,  18,  30 },
> +					},
> +					{ /* Coeff Band 3 */
> +						{  65, 187, 230 },
> +						{  20, 148, 207 },
> +						{   2,  97, 159 },
> +						{   1,  68, 116 },
> +						{   1,  40,  70 },
> +						{   1,  14,  29 },
> +					},
> +					{ /* Coeff Band 4 */
> +						{  40, 194, 227 },
> +						{   8, 147, 204 },
> +						{   1,  94, 155 },
> +						{   1,  65, 112 },
> +						{   1,  39,  66 },
> +						{   1,  14,  26 },
> +					},
> +					{ /* Coeff Band 5 */
> +						{  16, 208, 228 },
> +						{   3, 151, 207 },
> +						{   1,  98, 160 },
> +						{   1,  67, 117 },
> +						{   1,  41,  74 },
> +						{   1,  17,  31 },
> +					},
> +				},
> +			},
> +		},
> +		{ /* tx = 32x32 */
> +			{ /* block Type 0 */
> +				{ /* Intra */
> +					{ /* Coeff Band 0 */
> +						{  17,  38, 140 },
> +						{   7,  34,  80 },
> +						{   1,  17,  29 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +					},
> +					{ /* Coeff Band 1 */
> +						{  37,  75, 128 },
> +						{  41,  76, 128 },
> +						{  26,  66, 116 },
> +						{  12,  52,  94 },
> +						{   2,  32,  55 },
> +						{   1,  10,  16 },
> +					},
> +					{ /* Coeff Band 2 */
> +						{  50, 127, 154 },
> +						{  37, 109, 152 },
> +						{  16,  82, 121 },
> +						{   5,  59,  85 },
> +						{   1,  35,  54 },
> +						{   1,  13,  20 },
> +					},
> +					{ /* Coeff Band 3 */
> +						{  40, 142, 167 },
> +						{  17, 110, 157 },
> +						{   2,  71, 112 },
> +						{   1,  44,  72 },
> +						{   1,  27,  45 },
> +						{   1,  11,  17 },
> +					},
> +					{ /* Coeff Band 4 */
> +						{  30, 175, 188 },
> +						{   9, 124, 169 },
> +						{   1,  74, 116 },
> +						{   1,  48,  78 },
> +						{   1,  30,  49 },
> +						{   1,  11,  18 },
> +					},
> +					{ /* Coeff Band 5 */
> +						{  10, 222, 223 },
> +						{   2, 150, 194 },
> +						{   1,  83, 128 },
> +						{   1,  48,  79 },
> +						{   1,  27,  45 },
> +						{   1,  11,  17 },
> +					},
> +				},
> +				{ /* Inter */
> +					{ /* Coeff Band 0 */
> +						{  36,  41, 235 },
> +						{  29,  36, 193 },
> +						{  10,  27, 111 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +					},
> +					{ /* Coeff Band 1 */
> +						{  85, 165, 222 },
> +						{ 177, 162, 215 },
> +						{ 110, 135, 195 },
> +						{  57, 113, 168 },
> +						{  23,  83, 120 },
> +						{  10,  49,  61 },
> +					},
> +					{ /* Coeff Band 2 */
> +						{  85, 190, 223 },
> +						{  36, 139, 200 },
> +						{   5,  90, 146 },
> +						{   1,  60, 103 },
> +						{   1,  38,  65 },
> +						{   1,  18,  30 },
> +					},
> +					{ /* Coeff Band 3 */
> +						{  72, 202, 223 },
> +						{  23, 141, 199 },
> +						{   2,  86, 140 },
> +						{   1,  56,  97 },
> +						{   1,  36,  61 },
> +						{   1,  16,  27 },
> +					},
> +					{ /* Coeff Band 4 */
> +						{  55, 218, 225 },
> +						{  13, 145, 200 },
> +						{   1,  86, 141 },
> +						{   1,  57,  99 },
> +						{   1,  35,  61 },
> +						{   1,  13,  22 },
> +					},
> +					{ /* Coeff Band 5 */
> +						{  15, 235, 212 },
> +						{   1, 132, 184 },
> +						{   1,  84, 139 },
> +						{   1,  57,  97 },
> +						{   1,  34,  56 },
> +						{   1,  14,  23 },
> +					},
> +				},
> +			},
> +			{ /* block Type 1 */
> +				{ /* Intra */
> +					{ /* Coeff Band 0 */
> +						{ 181,  21, 201 },
> +						{  61,  37, 123 },
> +						{  10,  38,  71 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +					},
> +					{ /* Coeff Band 1 */
> +						{  47, 106, 172 },
> +						{  95, 104, 173 },
> +						{  42,  93, 159 },
> +						{  18,  77, 131 },
> +						{   4,  50,  81 },
> +						{   1,  17,  23 },
> +					},
> +					{ /* Coeff Band 2 */
> +						{  62, 147, 199 },
> +						{  44, 130, 189 },
> +						{  28, 102, 154 },
> +						{  18,  75, 115 },
> +						{   2,  44,  65 },
> +						{   1,  12,  19 },
> +					},
> +					{ /* Coeff Band 3 */
> +						{  55, 153, 210 },
> +						{  24, 130, 194 },
> +						{   3,  93, 146 },
> +						{   1,  61,  97 },
> +						{   1,  31,  50 },
> +						{   1,  10,  16 },
> +					},
> +					{ /* Coeff Band 4 */
> +						{  49, 186, 223 },
> +						{  17, 148, 204 },
> +						{   1,  96, 142 },
> +						{   1,  53,  83 },
> +						{   1,  26,  44 },
> +						{   1,  11,  17 },
> +					},
> +					{ /* Coeff Band 5 */
> +						{  13, 217, 212 },
> +						{   2, 136, 180 },
> +						{   1,  78, 124 },
> +						{   1,  50,  83 },
> +						{   1,  29,  49 },
> +						{   1,  14,  23 },
> +					},
> +				},
> +				{ /* Inter */
> +					{ /* Coeff Band 0 */
> +						{ 197,  13, 247 },
> +						{  82,  17, 222 },
> +						{  25,  17, 162 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +						{   0,   0,   0 },
> +					},
> +					{ /* Coeff Band 1 */
> +						{ 126, 186, 247 },
> +						{ 234, 191, 243 },
> +						{ 176, 177, 234 },
> +						{ 104, 158, 220 },
> +						{  66, 128, 186 },
> +						{  55,  90, 137 },
> +					},
> +					{ /* Coeff Band 2 */
> +						{ 111, 197, 242 },
> +						{  46, 158, 219 },
> +						{   9, 104, 171 },
> +						{   2,  65, 125 },
> +						{   1,  44,  80 },
> +						{   1,  17,  91 },
> +					},
> +					{ /* Coeff Band 3 */
> +						{ 104, 208, 245 },
> +						{  39, 168, 224 },
> +						{   3, 109, 162 },
> +						{   1,  79, 124 },
> +						{   1,  50, 102 },
> +						{   1,  43, 102 },
> +					},
> +					{ /* Coeff Band 4 */
> +						{  84, 220, 246 },
> +						{  31, 177, 231 },
> +						{   2, 115, 180 },
> +						{   1,  79, 134 },
> +						{   1,  55,  77 },
> +						{   1,  60,  79 },
> +					},
> +					{ /* Coeff Band 5 */
> +						{  43, 243, 240 },
> +						{   8, 180, 217 },
> +						{   1, 115, 166 },
> +						{   1,  84, 121 },
> +						{   1,  51,  67 },
> +						{   1,  16,   6 },
> +					},
> +				},
> +			},
> +		},
> +	},
> +
> +	.skip = { 192, 128, 64 },
> +	.inter_mode = {
> +		{  2, 173, 34 },
> +		{  7, 145, 85 },
> +		{  7, 166, 63 },
> +		{  7,  94, 66 },
> +		{  8,  64, 46 },
> +		{ 17,  81, 31 },
> +		{ 25,  29, 30 },
> +	},
> +	.interp_filter = {
> +		{ 235, 162 },
> +		{  36, 255 },
> +		{  34,   3 },
> +		{ 149, 144 },
> +	},
> +	.is_inter = { 9, 102, 187, 225 },
> +	.comp_mode = { 239, 183, 119, 96, 41 },
> +	.single_ref = {
> +		{  33,  16 },
> +		{  77,  74 },
> +		{ 142, 142 },
> +		{ 172, 170 },
> +		{ 238, 247 },
> +	},
> +	.comp_ref = { 50, 126, 123, 221, 226 },
> +	.y_mode = {
> +		{  65,  32, 18, 144, 162, 194, 41, 51, 98 },
> +		{ 132,  68, 18, 165, 217, 196, 45, 40, 78 },
> +		{ 173,  80, 19, 176, 240, 193, 64, 35, 46 },
> +		{ 221, 135, 38, 194, 248, 121, 96, 85, 29 },
> +	},
> +	.uv_mode = {
> +		{ 120,   7,  76, 176, 208, 126,  28,  54, 103 } /* y = dc */,
> +		{  48,  12, 154, 155, 139,  90,  34, 117, 119 } /* y = v */,
> +		{  67,   6,  25, 204, 243, 158,  13,  21,  96 } /* y = h */,
> +		{  97,   5,  44, 131, 176, 139,  48,  68,  97 } /* y = d45 */,
> +		{  83,   5,  42, 156, 111, 152,  26,  49, 152 } /* y = d135 */,
> +		{  80,   5,  58, 178,  74,  83,  33,  62, 145 } /* y = d117 */,
> +		{  86,   5,  32, 154, 192, 168,  14,  22, 163 } /* y = d153 */,
> +		{  85,   5,  32, 156, 216, 148,  19,  29,  73 } /* y = d207 */,
> +		{  77,   7,  64, 116, 132, 122,  37, 126, 120 } /* y = d63 */,
> +		{ 101,  21, 107, 181, 192, 103,  19,  67, 125 } /* y = tm */
> +	},
> +	.partition = {
> +		/* 8x8 -> 4x4 */
> +		{ 199, 122, 141 } /* a/l both not split */,
> +		{ 147,  63, 159 } /* a split, l not split */,
> +		{ 148, 133, 118 } /* l split, a not split */,
> +		{ 121, 104, 114 } /* a/l both split */,
> +		/* 16x16 -> 8x8 */
> +		{ 174,  73,  87 } /* a/l both not split */,
> +		{  92,  41,  83 } /* a split, l not split */,
> +		{  82,  99,  50 } /* l split, a not split */,
> +		{  53,  39,  39 } /* a/l both split */,
> +		/* 32x32 -> 16x16 */
> +		{ 177,  58,  59 } /* a/l both not split */,
> +		{  68,  26,  63 } /* a split, l not split */,
> +		{  52,  79,  25 } /* l split, a not split */,
> +		{  17,  14,  12 } /* a/l both split */,
> +		/* 64x64 -> 32x32 */
> +		{ 222,  34,  30 } /* a/l both not split */,
> +		{  72,  16,  44 } /* a split, l not split */,
> +		{  58,  32,  12 } /* l split, a not split */,
> +		{  10,   7,   6 } /* a/l both split */,
> +	},
> +
> +	.mv = {
> +		.joint = { 32, 64, 96 },
> +		.sign = { 128, 128 },
> +		.class = {
> +			{ 224, 144, 192, 168, 192, 176, 192, 198, 198, 245 },
> +			{ 216, 128, 176, 160, 176, 176, 192, 198, 198, 208 },
> +		},
> +		.class0_bit = { 216, 208 },
> +		.bits = {
> +			{ 136, 140, 148, 160, 176, 192, 224, 234, 234, 240},
> +			{ 136, 140, 148, 160, 176, 192, 224, 234, 234, 240},
> +		},
> +		.class0_fr = {
> +			{
> +				{ 128, 128, 64 },
> +				{  96, 112, 64 },
> +			},
> +			{
> +				{ 128, 128, 64 },
> +				{  96, 112, 64 },
> +			},
> +		},
> +		.fr = {
> +			{ 64, 96, 64 },
> +			{ 64, 96, 64 },
> +		},
> +		.class0_hp = { 160, 160 },
> +		.hp = { 128, 128 },
> +	},
> +};
> +
> +static void write_coeff_plane(const u8 coef[6][6][3], u8 *coeff_plane)
> +{
> +	unsigned int idx = 0;
> +	u8 byte_count = 0, p;
> +	s32 k, m, n;
> +
> +	for (k = 0; k < 6; k++) {
> +		for (m = 0; m < 6; m++) {
> +			for (n = 0; n < 3; n++) {
> +				p = coef[k][m][n];
> +				coeff_plane[idx++] = p;
> +				byte_count++;
> +				if (byte_count == 27) {
> +					idx += 5;
> +					byte_count = 0;
> +				}
> +			}
> +		}
> +	}
> +}
> +
> +static void init_intra_only_probs(struct rkvdec_ctx *ctx,
> +				  const struct rkvdec_vp9_run *run)
> +{
> +	const struct v4l2_ctrl_vp9_frame_decode_params *dec_params;
> +	struct rkvdec_vp9_ctx *vp9_ctx = ctx->priv;
> +	struct rkvdec_vp9_priv_tbl *tbl = vp9_ctx->priv_tbl.cpu;
> +	struct rkvdec_vp9_intra_only_frame_probs *rkprobs;
> +	const struct rkvdec_vp9_frame_context *probs;
> +	unsigned int i, j, k, m;
> +
> +	rkprobs = &tbl->probs.intra_only;
> +	dec_params = run->decode_params;
> +	probs = &vp9_ctx->probability_tables;
> +
> +	/*
> +	 * intra only 149 x 128 bits ,aligned to 152 x 128 bits coeff related
> +	 * prob 64 x 128 bits
> +	 */
> +	for (i = 0; i < ARRAY_SIZE(probs->coef); i++) {
> +		for (j = 0; j < ARRAY_SIZE(probs->coef[0]); j++)
> +			write_coeff_plane(probs->coef[i][j][0],
> +					  rkprobs->coef_intra[i][j]);
> +	}
> +
> +	/* intra mode prob  80 x 128 bits */
> +	for (i = 0; i < ARRAY_SIZE(vp9_kf_y_mode_prob); i++) {
> +		u32 byte_count = 0;
> +		int idx = 0;
> +
> +		/* vp9_kf_y_mode_prob */
> +		for (j = 0; j < ARRAY_SIZE(vp9_kf_y_mode_prob[0]); j++) {
> +			for (k = 0; k < ARRAY_SIZE(vp9_kf_y_mode_prob[0][0]);
> +			     k++) {
> +				u8 val = vp9_kf_y_mode_prob[i][j][k];
> +
> +				rkprobs->intra_mode[i].y_mode[idx++] = val;
> +				byte_count++;
> +				if (byte_count == 27) {
> +					byte_count = 0;
> +					idx += 5;
> +				}
> +			}
> +		}
> +
> +		idx = 0;
> +		if (i < 4) {
> +			for (m = 0; m < (i < 3 ? 23 : 21); m++) {
> +				const u8 *ptr = (const u8 *)kf_uv_mode_prob;
> +
> +				rkprobs->intra_mode[i].uv_mode[idx++] = ptr[i * 23 + m];
> +			}
> +		}
> +	}
> +}
> +
> +static void init_inter_probs(struct rkvdec_ctx *ctx,
> +			     const struct rkvdec_vp9_run *run)
> +{
> +	const struct v4l2_ctrl_vp9_frame_decode_params *dec_params;
> +	struct rkvdec_vp9_ctx *vp9_ctx = ctx->priv;
> +	struct rkvdec_vp9_priv_tbl *tbl = vp9_ctx->priv_tbl.cpu;
> +	struct rkvdec_vp9_inter_frame_probs *rkprobs;
> +	const struct rkvdec_vp9_frame_context *probs;
> +	unsigned int i, j, k;
> +
> +	rkprobs = &tbl->probs.inter;
> +	dec_params = run->decode_params;
> +	probs = &vp9_ctx->probability_tables;
> +
> +	/*
> +	 * inter probs
> +	 * 151 x 128 bits, aligned to 152 x 128 bits
> +	 * inter only
> +	 * intra_y_mode & inter_block info 6 x 128 bits
> +	 */
> +
> +	memcpy(rkprobs->y_mode, probs->y_mode, sizeof(rkprobs->y_mode));
> +	memcpy(rkprobs->comp_mode, probs->comp_mode,
> +	       sizeof(rkprobs->comp_mode));
> +	memcpy(rkprobs->comp_ref, probs->comp_ref,
> +	       sizeof(rkprobs->comp_ref));
> +	memcpy(rkprobs->single_ref, probs->single_ref,
> +	       sizeof(rkprobs->single_ref));
> +	memcpy(rkprobs->inter_mode, probs->inter_mode,
> +	       sizeof(rkprobs->inter_mode));
> +	memcpy(rkprobs->interp_filter, probs->interp_filter,
> +	       sizeof(rkprobs->interp_filter));
> +
> +	/* 128 x 128 bits coeff related */
> +	for (i = 0; i < ARRAY_SIZE(probs->coef); i++) {
> +		for (j = 0; j < ARRAY_SIZE(probs->coef[0]); j++) {
> +			for (k = 0; k < ARRAY_SIZE(probs->coef[0][0]); k++)
> +				write_coeff_plane(probs->coef[i][j][k],
> +						  rkprobs->coef[k][i][j]);
> +		}
> +	}
> +
> +	/* intra uv mode 6 x 128 */
> +	memcpy(rkprobs->uv_mode_0_2, &probs->uv_mode[0],
> +	       sizeof(rkprobs->uv_mode_0_2));
> +	memcpy(rkprobs->uv_mode_3_5, &probs->uv_mode[3],
> +	       sizeof(rkprobs->uv_mode_3_5));
> +	memcpy(rkprobs->uv_mode_6_8, &probs->uv_mode[6],
> +	       sizeof(rkprobs->uv_mode_6_8));
> +	memcpy(rkprobs->uv_mode_9, &probs->uv_mode[9],
> +	       sizeof(rkprobs->uv_mode_9));
> +
> +	/* mv related 6 x 128 */
> +	memcpy(rkprobs->mv.joint, probs->mv.joint,
> +	       sizeof(rkprobs->mv.joint));
> +	memcpy(rkprobs->mv.sign, probs->mv.sign,
> +	       sizeof(rkprobs->mv.sign));
> +	memcpy(rkprobs->mv.class, probs->mv.class,
> +	       sizeof(rkprobs->mv.class));
> +	memcpy(rkprobs->mv.class0_bit, probs->mv.class0_bit,
> +	       sizeof(rkprobs->mv.class0_bit));
> +	memcpy(rkprobs->mv.bits, probs->mv.bits,
> +	       sizeof(rkprobs->mv.bits));
> +	memcpy(rkprobs->mv.class0_fr, probs->mv.class0_fr,
> +	       sizeof(rkprobs->mv.class0_fr));
> +	memcpy(rkprobs->mv.fr, probs->mv.fr,
> +	       sizeof(rkprobs->mv.fr));
> +	memcpy(rkprobs->mv.class0_hp, probs->mv.class0_hp,
> +	       sizeof(rkprobs->mv.class0_hp));
> +	memcpy(rkprobs->mv.hp, probs->mv.hp,
> +	       sizeof(rkprobs->mv.hp));
> +}
> +
> +static void init_probs(struct rkvdec_ctx *ctx,
> +		       const struct rkvdec_vp9_run *run)
> +{
> +	const struct v4l2_ctrl_vp9_frame_decode_params *dec_params;
> +	struct rkvdec_vp9_ctx *vp9_ctx = ctx->priv;
> +	struct rkvdec_vp9_priv_tbl *tbl = vp9_ctx->priv_tbl.cpu;
> +	struct rkvdec_vp9_probs *rkprobs = &tbl->probs;
> +	const struct v4l2_vp9_segmentation *seg;
> +	const struct rkvdec_vp9_frame_context *probs;
> +	bool intra_only;
> +
> +	dec_params = run->decode_params;
> +	probs = &vp9_ctx->probability_tables;
> +	seg = &dec_params->seg;
> +
> +	memset(rkprobs, 0, sizeof(*rkprobs));
> +
> +	intra_only = !!(dec_params->flags &
> +			(V4L2_VP9_FRAME_FLAG_KEY_FRAME |
> +			 V4L2_VP9_FRAME_FLAG_INTRA_ONLY));
> +
> +	/* sb info  5 x 128 bit */
> +	memcpy(rkprobs->partition,
> +	       intra_only ? kf_partition_probs : probs->partition,
> +	       sizeof(rkprobs->partition));
> +
> +	memcpy(rkprobs->pred, seg->pred_probs, sizeof(rkprobs->pred));
> +	memcpy(rkprobs->tree, seg->tree_probs, sizeof(rkprobs->tree));
> +	memcpy(rkprobs->skip, probs->skip, sizeof(rkprobs->skip));
> +	memcpy(rkprobs->tx32, probs->tx32, sizeof(rkprobs->tx32));
> +	memcpy(rkprobs->tx16, probs->tx16, sizeof(rkprobs->tx16));
> +	memcpy(rkprobs->tx8, probs->tx8, sizeof(rkprobs->tx8));
> +	memcpy(rkprobs->is_inter, probs->is_inter, sizeof(rkprobs->is_inter));
> +
> +	if (intra_only)
> +		init_intra_only_probs(ctx, run);
> +	else
> +		init_inter_probs(ctx, run);
> +}
> +
> +struct vp9d_ref_config {
> +	u32 reg_frm_size;
> +	u32 reg_hor_stride;
> +	u32 reg_y_stride;
> +	u32 reg_yuv_stride;
> +	u32 reg_ref_base;
> +};
> +
> +static struct vp9d_ref_config ref_config[3] = {
> +	{
> +		.reg_frm_size = RKVDEC_REG_VP9_FRAME_SIZE(0),
> +		.reg_hor_stride = RKVDEC_VP9_HOR_VIRSTRIDE(0),
> +		.reg_y_stride = RKVDEC_VP9_LAST_FRAME_YSTRIDE,
> +		.reg_yuv_stride = RKVDEC_VP9_LAST_FRAME_YUVSTRIDE,
> +		.reg_ref_base = RKVDEC_REG_VP9_LAST_FRAME_BASE,
> +	},
> +	{
> +		.reg_frm_size = RKVDEC_REG_VP9_FRAME_SIZE(1),
> +		.reg_hor_stride = RKVDEC_VP9_HOR_VIRSTRIDE(1),
> +		.reg_y_stride = RKVDEC_VP9_GOLDEN_FRAME_YSTRIDE,
> +		.reg_yuv_stride = 0,
> +		.reg_ref_base = RKVDEC_REG_VP9_GOLDEN_FRAME_BASE,
> +	},
> +	{
> +		.reg_frm_size = RKVDEC_REG_VP9_FRAME_SIZE(2),
> +		.reg_hor_stride = RKVDEC_VP9_HOR_VIRSTRIDE(2),
> +		.reg_y_stride = RKVDEC_VP9_ALTREF_FRAME_YSTRIDE,
> +		.reg_yuv_stride = 0,
> +		.reg_ref_base = RKVDEC_REG_VP9_ALTREF_FRAME_BASE,
> +	}
> +};
> +
> +static struct rkvdec_decoded_buffer *
> +get_ref_buf(struct rkvdec_ctx *ctx, struct vb2_v4l2_buffer *dst, u64 timestamp)
> +{
> +	struct v4l2_m2m_ctx *m2m_ctx = ctx->fh.m2m_ctx;
> +	struct vb2_queue *cap_q = &m2m_ctx->cap_q_ctx.q;
> +	int buf_idx;
> +
> +	/*
> +	 * If a ref is unused or invalid, address of current destination
> +	 * buffer is returned.
> +	 */
> +	buf_idx = vb2_find_timestamp(cap_q, timestamp, 0);
> +	if (buf_idx < 0)
> +		return vb2_to_rkvdec_decoded_buf(&dst->vb2_buf);
> +
> +	return vb2_to_rkvdec_decoded_buf(vb2_get_buffer(cap_q, buf_idx));
> +}
> +
> +static dma_addr_t get_mv_base_addr(struct rkvdec_decoded_buffer *buf)
> +{
> +	u32 aligned_pitch, aligned_height, yuv_len;
> +
> +	aligned_height = round_up(buf->vp9.height, 64);
> +	aligned_pitch = round_up(buf->vp9.width * buf->vp9.bit_depth, 512) / 8;
> +	yuv_len = (aligned_height * aligned_pitch * 3) / 2;
> +
> +	return vb2_dma_contig_plane_dma_addr(&buf->base.vb.vb2_buf, 0) +
> +	       yuv_len;
> +}
> +
> +static void config_ref_registers(struct rkvdec_ctx *ctx,
> +				 const struct rkvdec_vp9_run *run,
> +				 struct rkvdec_decoded_buffer **ref_bufs,
> +				 enum v4l2_vp9_ref_id id)
> +{
> +	u32 aligned_pitch, aligned_height, y_len, yuv_len;
> +	struct rkvdec_decoded_buffer *buf = ref_bufs[id];
> +	struct rkvdec_dev *rkvdec = ctx->dev;
> +
> +	aligned_height = round_up(buf->vp9.height, 64);
> +	writel_relaxed(RKVDEC_VP9_FRAMEWIDTH(buf->vp9.width) |
> +		       RKVDEC_VP9_FRAMEHEIGHT(buf->vp9.height),
> +		       rkvdec->regs + ref_config[id].reg_frm_size);
> +
> +	writel_relaxed(vb2_dma_contig_plane_dma_addr(&buf->base.vb.vb2_buf, 0),
> +		       rkvdec->regs + ref_config[id].reg_ref_base);
> +
> +	if (&buf->base.vb == run->base.bufs.dst)
> +		return;
> +
> +	aligned_pitch = round_up(buf->vp9.width * buf->vp9.bit_depth, 512) / 8;
> +	y_len = aligned_height * aligned_pitch;
> +	yuv_len = (y_len * 3) / 2;
> +
> +	writel_relaxed(RKVDEC_HOR_Y_VIRSTRIDE(aligned_pitch / 16) |
> +		       RKVDEC_HOR_UV_VIRSTRIDE(aligned_pitch / 16),
> +		       rkvdec->regs + ref_config[id].reg_hor_stride);
> +	writel_relaxed(RKVDEC_VP9_REF_YSTRIDE(y_len / 16),
> +		       rkvdec->regs + ref_config[id].reg_y_stride);
> +
> +	if (!ref_config[id].reg_yuv_stride)
> +		return;
> +
> +	writel_relaxed(RKVDEC_VP9_REF_YUVSTRIDE(yuv_len / 16),
> +		       rkvdec->regs + ref_config[id].reg_yuv_stride);
> +}
> +
> +static bool seg_featured_enabled(const struct v4l2_vp9_segmentation *seg,
> +				 enum v4l2_vp9_segment_feature feature,
> +				 unsigned int segid)
> +{
> +	u8 mask = V4L2_VP9_SEGMENT_FEATURE_ENABLED(feature);
> +
> +	return !!(seg->feature_enabled[segid] & mask);
> +}
> +
> +static void config_seg_registers(struct rkvdec_ctx *ctx, unsigned int segid)
> +{
> +	struct rkvdec_vp9_ctx *vp9_ctx = ctx->priv;
> +	const struct v4l2_vp9_segmentation *seg;
> +	struct rkvdec_dev *rkvdec = ctx->dev;
> +	s16 feature_val;
> +	u8 feature_id;
> +	u32 val = 0;
> +
> +	seg = vp9_ctx->last.valid ? &vp9_ctx->last.seg : &vp9_ctx->cur.seg;
> +	feature_id = V4L2_VP9_SEGMENT_FEATURE_QP_DELTA;
> +	if (seg_featured_enabled(seg, feature_id, segid)) {
> +		feature_val = seg->feature_data[segid][feature_id];
> +		val |= RKVDEC_SEGID_FRAME_QP_DELTA_EN(1) |
> +		       RKVDEC_SEGID_FRAME_QP_DELTA(feature_val);
> +	}
> +
> +	feature_id = V4L2_VP9_SEGMENT_FEATURE_LF;
> +	if (seg_featured_enabled(seg, feature_id, segid)) {
> +		feature_val = seg->feature_data[segid][feature_id];
> +		val |= RKVDEC_SEGID_FRAME_LOOPFILTER_VALUE_EN(1) |
> +		       RKVDEC_SEGID_FRAME_LOOPFILTER_VALUE(feature_val);
> +	}
> +
> +	feature_id = V4L2_VP9_SEGMENT_FEATURE_REF_FRAME;
> +	if (seg_featured_enabled(seg, feature_id, segid)) {
> +		feature_val = seg->feature_data[segid][feature_id];
> +		val |= RKVDEC_SEGID_REFERINFO_EN(1) |
> +		       RKVDEC_SEGID_REFERINFO(feature_val);
> +	}
> +
> +	feature_id = V4L2_VP9_SEGMENT_FEATURE_SKIP;
> +	if (seg_featured_enabled(seg, feature_id, segid))
> +		val |= RKVDEC_SEGID_FRAME_SKIP_EN(1);
> +
> +	if (!segid &&
> +	    (seg->flags & V4L2_VP9_SEGMENTATION_FLAG_ABS_OR_DELTA_UPDATE))
> +		val |= RKVDEC_SEGID_ABS_DELTA(1);
> +
> +	writel_relaxed(val, rkvdec->regs + RKVDEC_VP9_SEGID_GRP(segid));
> +}
> +
> +static void update_dec_buf_info(struct rkvdec_decoded_buffer *buf,
> +				const struct v4l2_ctrl_vp9_frame_decode_params *dec_params)
> +{
> +	buf->vp9.width = dec_params->frame_width_minus_1 + 1;
> +	buf->vp9.height = dec_params->frame_height_minus_1 + 1;
> +	buf->vp9.bit_depth = dec_params->bit_depth;
> +}
> +
> +static void update_ctx_cur_info(struct rkvdec_vp9_ctx *vp9_ctx,
> +				struct rkvdec_decoded_buffer *buf,
> +				const struct v4l2_ctrl_vp9_frame_decode_params *dec_params)
> +{
> +	vp9_ctx->cur.valid = true;
> +	vp9_ctx->cur.reference_mode = dec_params->reference_mode;
> +	vp9_ctx->cur.tx_mode = dec_params->tx_mode;
> +	vp9_ctx->cur.interpolation_filter = dec_params->interpolation_filter;
> +	vp9_ctx->cur.flags = dec_params->flags;
> +	vp9_ctx->cur.timestamp = buf->base.vb.vb2_buf.timestamp;
> +	vp9_ctx->cur.seg = dec_params->seg;
> +	vp9_ctx->cur.lf = dec_params->lf;
> +}
> +
> +static void update_ctx_last_info(struct rkvdec_vp9_ctx *vp9_ctx)
> +{
> +	vp9_ctx->last = vp9_ctx->cur;
> +}
> +
> +static void config_registers(struct rkvdec_ctx *ctx,
> +			     const struct rkvdec_vp9_run *run)
> +{
> +	u32 y_len, uv_len, yuv_len, bit_depth, aligned_height, aligned_pitch;
> +	const struct v4l2_ctrl_vp9_frame_decode_params *dec_params;
> +	struct rkvdec_decoded_buffer *ref_bufs[V4L2_REF_ID_CNT];
> +	struct rkvdec_decoded_buffer *dst, *last, *mv_ref;
> +	struct rkvdec_vp9_ctx *vp9_ctx = ctx->priv;
> +	u32 val, stream_len, last_frame_info = 0;
> +	const struct v4l2_vp9_segmentation *seg;
> +	struct rkvdec_dev *rkvdec = ctx->dev;
> +	dma_addr_t addr;
> +	bool intra_only;
> +	unsigned int i;
> +
> +	dec_params = run->decode_params;
> +	dst = vb2_to_rkvdec_decoded_buf(&run->base.bufs.dst->vb2_buf);
> +	for (i = 0; i < ARRAY_SIZE(ref_bufs); i++)
> +		ref_bufs[i] = get_ref_buf(ctx, &dst->base.vb,
> +					  dec_params->refs[i]);
> +
> +	if (vp9_ctx->last.valid)
> +		last = get_ref_buf(ctx, &dst->base.vb, vp9_ctx->last.timestamp);
> +	else
> +		last = dst;
> +
> +	update_dec_buf_info(dst, dec_params);
> +	update_ctx_cur_info(vp9_ctx, dst, dec_params);
> +	seg = &dec_params->seg;
> +
> +	intra_only = !!(dec_params->flags &
> +			(V4L2_VP9_FRAME_FLAG_KEY_FRAME |
> +			 V4L2_VP9_FRAME_FLAG_INTRA_ONLY));
> +
> +	writel_relaxed(RKVDEC_MODE(RKVDEC_MODE_VP9),
> +		       rkvdec->regs + RKVDEC_REG_SYSCTRL);
> +
> +	bit_depth = dec_params->bit_depth;
> +	aligned_height = round_up(ctx->decoded_fmt.fmt.pix_mp.height, 64);
> +
> +	aligned_pitch = round_up(ctx->decoded_fmt.fmt.pix_mp.width *
> +				 bit_depth,
> +				 512) / 8;
> +	y_len = aligned_height * aligned_pitch;
> +	uv_len = y_len / 2;
> +	yuv_len = y_len + uv_len;
> +
> +	writel_relaxed(RKVDEC_Y_HOR_VIRSTRIDE(aligned_pitch / 16) |
> +		       RKVDEC_UV_HOR_VIRSTRIDE(aligned_pitch / 16),
> +		       rkvdec->regs + RKVDEC_REG_PICPAR);
> +	writel_relaxed(RKVDEC_Y_VIRSTRIDE(y_len / 16),
> +		       rkvdec->regs + RKVDEC_REG_Y_VIRSTRIDE);
> +	writel_relaxed(RKVDEC_YUV_VIRSTRIDE(yuv_len / 16),
> +		       rkvdec->regs + RKVDEC_REG_YUV_VIRSTRIDE);
> +
> +	stream_len = vb2_get_plane_payload(&run->base.bufs.src->vb2_buf, 0);
> +	writel_relaxed(RKVDEC_STRM_LEN(stream_len),
> +		       rkvdec->regs + RKVDEC_REG_STRM_LEN);
> +
> +	/*
> +	 * Reset count buffer, because decoder only output intra related syntax
> +	 * counts when decoding intra frame, but update entropy need to update
> +	 * all the probabilities.
> +	 */
> +	if (intra_only)
> +		memset(vp9_ctx->count_tbl.cpu, 0, vp9_ctx->count_tbl.size);
> +
> +	vp9_ctx->cur.segmapid = vp9_ctx->last.segmapid;
> +	if (!intra_only &&
> +	    !(dec_params->flags & V4L2_VP9_FRAME_FLAG_ERROR_RESILIENT) &&
> +	    (!(seg->flags & V4L2_VP9_SEGMENTATION_FLAG_ENABLED) ||
> +	     (seg->flags & V4L2_VP9_SEGMENTATION_FLAG_UPDATE_MAP)))
> +		vp9_ctx->cur.segmapid++;
> +
> +	for (i = 0; i < ARRAY_SIZE(ref_bufs); i++)
> +		config_ref_registers(ctx, run, ref_bufs, i);
> +
> +	for (i = 0; i < 8; i++)
> +		config_seg_registers(ctx, i);
> +
> +	writel_relaxed(RKVDEC_VP9_TX_MODE(dec_params->tx_mode) |
> +		       RKVDEC_VP9_FRAME_REF_MODE(dec_params->reference_mode),
> +		       rkvdec->regs + RKVDEC_VP9_CPRHEADER_CONFIG);
> +
> +	if (!intra_only) {
> +		const struct v4l2_vp9_loop_filter *lf;
> +		s8 delta;
> +
> +		if (vp9_ctx->last.valid)
> +			lf = &vp9_ctx->last.lf;
> +		else
> +			lf = &vp9_ctx->cur.lf;
> +
> +		val = 0;
> +		for (i = 0; i < ARRAY_SIZE(lf->ref_deltas); i++) {
> +			delta = lf->ref_deltas[i];
> +			val |= RKVDEC_REF_DELTAS_LASTFRAME(i, delta);
> +		}
> +
> +		writel_relaxed(val,
> +			       rkvdec->regs + RKVDEC_VP9_REF_DELTAS_LASTFRAME);
> +
> +		for (i = 0; i < ARRAY_SIZE(lf->mode_deltas); i++) {
> +			delta = lf->mode_deltas[i];
> +			last_frame_info |= RKVDEC_MODE_DELTAS_LASTFRAME(i,
> +									delta);
> +		}
> +	}
> +
> +	if (vp9_ctx->last.valid && !intra_only &&
> +	    vp9_ctx->last.seg.flags & V4L2_VP9_SEGMENTATION_FLAG_ENABLED)
> +		last_frame_info |= RKVDEC_SEG_EN_LASTFRAME;
> +
> +	if (vp9_ctx->last.valid &&
> +	    vp9_ctx->last.flags & V4L2_VP9_FRAME_FLAG_SHOW_FRAME)
> +		last_frame_info |= RKVDEC_LAST_SHOW_FRAME;
> +
> +	if (vp9_ctx->last.valid &&
> +	    vp9_ctx->last.flags &
> +	    (V4L2_VP9_FRAME_FLAG_KEY_FRAME | V4L2_VP9_FRAME_FLAG_INTRA_ONLY))
> +		last_frame_info |= RKVDEC_LAST_INTRA_ONLY;
> +
> +	if (vp9_ctx->last.valid &&
> +	    last->vp9.width == dst->vp9.width &&
> +	    last->vp9.height == dst->vp9.height)
> +		last_frame_info |= RKVDEC_LAST_WIDHHEIGHT_EQCUR;
> +
> +	writel_relaxed(last_frame_info,
> +		       rkvdec->regs + RKVDEC_VP9_INFO_LASTFRAME);
> +
> +	writel_relaxed(stream_len - dec_params->compressed_header_size -
> +		       dec_params->uncompressed_header_size,
> +		       rkvdec->regs + RKVDEC_VP9_LASTTILE_SIZE);
> +
> +	for (i = 0; !intra_only && i < ARRAY_SIZE(ref_bufs); i++) {
> +		u32 refw = ref_bufs[i]->vp9.width;
> +		u32 refh = ref_bufs[i]->vp9.height;
> +		u32 hscale, vscale;
> +
> +		hscale = (refw << 14) /	dst->vp9.width;
> +		vscale = (refh << 14) / dst->vp9.height;
> +		writel_relaxed(RKVDEC_VP9_REF_HOR_SCALE(hscale) |
> +			       RKVDEC_VP9_REF_VER_SCALE(vscale),
> +			       rkvdec->regs + RKVDEC_VP9_REF_SCALE(i));
> +	}
> +
> +	addr = vb2_dma_contig_plane_dma_addr(&dst->base.vb.vb2_buf, 0);
> +	writel_relaxed(addr, rkvdec->regs + RKVDEC_REG_DECOUT_BASE);
> +	addr = vb2_dma_contig_plane_dma_addr(&run->base.bufs.src->vb2_buf, 0);
> +	writel_relaxed(addr, rkvdec->regs + RKVDEC_REG_STRM_RLC_BASE);
> +	writel_relaxed(vp9_ctx->priv_tbl.dma +
> +		       offsetof(struct rkvdec_vp9_priv_tbl, probs),
> +		       rkvdec->regs + RKVDEC_REG_CABACTBL_PROB_BASE);
> +	writel_relaxed(vp9_ctx->count_tbl.dma,
> +		       rkvdec->regs + RKVDEC_REG_VP9COUNT_BASE);
> +
> +	writel_relaxed(vp9_ctx->priv_tbl.dma +
> +		       offsetof(struct rkvdec_vp9_priv_tbl, segmap) +
> +		       (RKVDEC_VP9_MAX_SEGMAP_SIZE * vp9_ctx->cur.segmapid),
> +		       rkvdec->regs + RKVDEC_REG_VP9_SEGIDCUR_BASE);
> +	writel_relaxed(vp9_ctx->priv_tbl.dma +
> +		       offsetof(struct rkvdec_vp9_priv_tbl, segmap) +
> +		       (RKVDEC_VP9_MAX_SEGMAP_SIZE * (!vp9_ctx->cur.segmapid)),
> +		       rkvdec->regs + RKVDEC_REG_VP9_SEGIDLAST_BASE);
> +
> +	if (!intra_only &&
> +	    !(dec_params->flags & V4L2_VP9_FRAME_FLAG_ERROR_RESILIENT) &&
> +	    vp9_ctx->last.valid)
> +		mv_ref = last;
> +	else
> +		mv_ref = dst;
> +
> +	writel_relaxed(get_mv_base_addr(mv_ref),
> +		       rkvdec->regs + RKVDEC_VP9_REF_COLMV_BASE);
> +
> +	writel_relaxed(ctx->decoded_fmt.fmt.pix_mp.width |
> +		       (ctx->decoded_fmt.fmt.pix_mp.height << 16),
> +		       rkvdec->regs + RKVDEC_REG_PERFORMANCE_CYCLE);
> +}
> +
> +static int validate_dec_params(struct rkvdec_ctx *ctx,
> +			       const struct v4l2_ctrl_vp9_frame_decode_params *dec_params)
> +{
> +	unsigned int aligned_width, aligned_height;
> +
> +	/* We only support profile 0. */
> +	if (dec_params->profile != 0) {
> +		dev_err(ctx->dev->dev, "unsupported profile %d\n",
> +			dec_params->profile);
> +		return -EINVAL;
> +	}
> +
> +	aligned_width = round_up(dec_params->frame_width_minus_1 + 1, 64);
> +	aligned_height = round_up(dec_params->frame_height_minus_1 + 1, 64);
> +
> +	/*
> +	 * Userspace should update the capture/decoded format when the
> +	 * resolution changes.
> +	 */
> +	if (aligned_width != ctx->decoded_fmt.fmt.pix_mp.width ||
> +	    aligned_height != ctx->decoded_fmt.fmt.pix_mp.height) {
> +		dev_err(ctx->dev->dev,
> +			"unexpected bitstream resolution %dx%d\n",
> +			dec_params->frame_width_minus_1 + 1,
> +			dec_params->frame_height_minus_1 + 1);
> +		return -EINVAL;
> +	}
> +
> +	return 0;
> +}
> +
> +/* 6.3.6 inv_recenter_nonneg(v, m) */
> +static int inv_recenter_nonneg(int v, int m)
> +{
> +	if (v > 2 * m)
> +		return v;
> +
> +	if (v & 1)
> +		return m - ((v + 1) >> 1);
> +
> +	return m + (v >> 1);
> +}
> +
> +/*
> + * part of 6.3.5 inv_remap_prob(deltaProb, prob)
> + * delta = inv_map_table[deltaProb] done by userspace
> + */
> +static int update_prob(int delta, int prob)
> +{
> +	if (!delta)
> +		return prob;
> +
> +	return prob <= 128 ?
> +		1 + inv_recenter_nonneg(delta, prob - 1) :
> +		255 - inv_recenter_nonneg(delta, 255 - prob);
> +}
> +
> +/* Counterpart to 6.3.2 tx_mode_probs() */
> +static void update_tx_probs(struct rkvdec_vp9_frame_context *probs,
> +			    const struct v4l2_ctrl_vp9_compressed_hdr_probs *deltas)
> +{
> +	int i;
> +
> +	for (i = 0; i < ARRAY_SIZE(probs->tx8); i++) {
> +		u8 *p8x8 = probs->tx8[i];
> +		u8 *p16x16 = probs->tx16[i];
> +		u8 *p32x32 = probs->tx32[i];
> +		const u8 *d8x8 = deltas->tx8[i];
> +		const u8 *d16x16 = deltas->tx16[i];
> +		const u8 *d32x32 = deltas->tx32[i];
> +
> +		p8x8[0] = update_prob(d8x8[0], p8x8[0]);
> +		p16x16[0] = update_prob(d16x16[0], p16x16[0]);
> +		p16x16[1] = update_prob(d16x16[1], p16x16[1]);
> +		p32x32[0] = update_prob(d32x32[0], p32x32[0]);
> +		p32x32[1] = update_prob(d32x32[1], p32x32[1]);
> +		p32x32[2] = update_prob(d32x32[2], p32x32[2]);
> +	}
> +}
> +
> +#define BAND_6(band) ((band) == 0 ? 3 : 6)
> +
> +static void update_coeff(const u8 deltas[6][6][3], u8 probs[6][6][3])
> +{
> +	int l, m, n;
> +
> +	for (l = 0; l < 6; l++)
> +		for (m = 0; m < BAND_6(l); m++) {
> +			u8 *p = probs[l][m];
> +			const u8 *d = deltas[l][m];
> +
> +			for (n = 0; n < 3; n++)
> +				p[n] = update_prob(d[n], p[n]);
> +		}
> +}
> +
> +/* Counterpart to 6.3.7 read_coef_probs() */
> +static void update_coef_probs(struct rkvdec_vp9_frame_context *probs,
> +			      const struct v4l2_ctrl_vp9_compressed_hdr_probs *deltas,
> +			      const struct v4l2_ctrl_vp9_frame_decode_params *dec_params)
> +{
> +	int i, j, k;
> +
> +	for (i = 0; i < ARRAY_SIZE(probs->coef); i++) {
> +		for (j = 0; j < ARRAY_SIZE(probs->coef[0]); j++)
> +			for (k = 0; k < ARRAY_SIZE(probs->coef[0][0]); k++)
> +				update_coeff(deltas->coef[i][j][k], probs->coef[i][j][k]);
> +
> +		if (dec_params->tx_mode == i)
> +			break;
> +	}
> +}
> +
> +/* Counterpart to 6.3.8 read_skip_prob() */
> +static void update_skip_probs(struct rkvdec_vp9_frame_context *probs,
> +			      const struct v4l2_ctrl_vp9_compressed_hdr_probs *deltas)
> +{
> +	int i;
> +
> +	for (i = 0; i < ARRAY_SIZE(probs->skip); i++)
> +		probs->skip[i] = update_prob(deltas->skip[i], probs->skip[i]);
> +}
> +
> +/* Counterpart to 6.3.9 read_inter_mode_probs() */
> +static void update_inter_mode_probs(struct rkvdec_vp9_frame_context *probs,
> +				    const struct v4l2_ctrl_vp9_compressed_hdr_probs *deltas)
> +{
> +	int i;
> +
> +	for (i = 0; i < ARRAY_SIZE(probs->inter_mode); i++) {
> +		u8 *p = probs->inter_mode[i];
> +		const u8 *d = deltas->inter_mode[i];
> +
> +		p[0] = update_prob(d[0], p[0]);
> +		p[1] = update_prob(d[1], p[1]);
> +		p[2] = update_prob(d[2], p[2]);
> +	}
> +}
> +
> +/* Counterpart to 6.3.10 read_interp_filter_probs() */
> +static void update_interp_filter_probs(struct rkvdec_vp9_frame_context *probs,
> +				       const struct v4l2_ctrl_vp9_compressed_hdr_probs *deltas)
> +{
> +	int i;
> +
> +	for (i = 0; i < ARRAY_SIZE(probs->interp_filter); i++) {
> +		u8 *p = probs->interp_filter[i];
> +		const u8 *d = deltas->interp_filter[i];
> +
> +		p[0] = update_prob(d[0], p[0]);
> +		p[1] = update_prob(d[1], p[1]);
> +	}
> +}
> +
> +/* Counterpart to 6.3.11 read_is_inter_probs() */
> +static void update_is_inter_probs(struct rkvdec_vp9_frame_context *probs,
> +				  const struct v4l2_ctrl_vp9_compressed_hdr_probs *deltas)
> +{
> +	int i;
> +
> +	for (i = 0; i < ARRAY_SIZE(probs->is_inter); i++)
> +		probs->is_inter[i] = update_prob(deltas->is_inter[i], probs->is_inter[i]);
> +}
> +
> +/* 6.3.12 frame_reference_mode() done entirely in userspace */
> +
> +/* Counterpart to 6.3.13 frame_reference_mode_probs() */
> +static void
> +update_frame_reference_mode_probs(enum v4l2_vp9_reference_mode reference_mode,
> +				  struct rkvdec_vp9_frame_context *probs,
> +				  const struct v4l2_ctrl_vp9_compressed_hdr_probs *deltas)
> +{
> +	int i;
> +
> +	if (reference_mode == V4L2_VP9_REF_MODE_SELECT)
> +		for (i = 0; i < ARRAY_SIZE(probs->comp_mode); i++)
> +			probs->comp_mode[i] = update_prob(deltas->comp_mode[i],
> +							  probs->comp_mode[i]);
> +
> +	if (reference_mode != V4L2_VP9_REF_MODE_COMPOUND)
> +		for (i = 0; i < ARRAY_SIZE(probs->single_ref); i++) {
> +			u8 *p = probs->single_ref[i];
> +			const u8 *d = deltas->single_ref[i];
> +
> +			p[0] = update_prob(d[0], p[0]);
> +			p[1] = update_prob(d[1], p[1]);
> +		}
> +
> +	if (reference_mode != V4L2_VP9_REF_MODE_SINGLE)
> +		for (i = 0; i < ARRAY_SIZE(probs->comp_ref); i++)
> +			probs->comp_ref[i] = update_prob(deltas->comp_ref[i], probs->comp_ref[i]);
> +}
> +
> +/* Counterpart to 6.3.14 read_y_mode_probs() */
> +static void update_y_mode_probs(struct rkvdec_vp9_frame_context *probs,
> +				const struct v4l2_ctrl_vp9_compressed_hdr_probs *deltas)
> +{
> +	int i, j;
> +
> +	for (i = 0; i < ARRAY_SIZE(probs->y_mode); i++)
> +		for (j = 0; j < ARRAY_SIZE(probs->y_mode[0]); ++j)
> +			probs->y_mode[i][j] =
> +				update_prob(deltas->y_mode[i][j], probs->y_mode[i][j]);
> +}
> +
> +/* Counterpart to 6.3.15 read_partition_probs() */
> +static void update_partition_probs(struct rkvdec_vp9_frame_context *probs,
> +				   const struct v4l2_ctrl_vp9_compressed_hdr_probs *deltas)
> +{
> +	int i, j;
> +
> +	for (i = 0; i < 4; i++)
> +		for (j = 0; j < 4; j++) {
> +			u8 *p = probs->partition[i * 4 + j];
> +			const u8 *d = deltas->partition[i * 4 + j];
> +
> +			p[0] = update_prob(d[0], p[0]);
> +			p[1] = update_prob(d[1], p[1]);
> +			p[2] = update_prob(d[2], p[2]);
> +		}
> +}
> +
> +static inline int update_mv_prob(int delta, int prob)
> +{
> +	if (!delta)
> +		return prob;
> +
> +	return delta;
> +}
> +
> +/* Counterpart to 6.3.16 mv_probs() */
> +static void update_mv_probs(struct rkvdec_vp9_frame_context *probs,
> +			    const struct v4l2_ctrl_vp9_compressed_hdr_probs *deltas,
> +			    const struct v4l2_ctrl_vp9_frame_decode_params *dec_params)
> +{
> +	u8 *p = probs->mv.joint;
> +	const u8 *d = deltas->mv.joint;
> +	unsigned int i, j;
> +
> +	p[0] = update_mv_prob(d[0], p[0]);
> +	p[1] = update_mv_prob(d[1], p[1]);
> +	p[2] = update_mv_prob(d[2], p[2]);
> +
> +	for (i = 0; i < ARRAY_SIZE(probs->mv.sign); i++) {
> +		p = probs->mv.sign;
> +		d = deltas->mv.sign;
> +		p[i] = update_mv_prob(d[i], p[i]);
> +
> +		p = probs->mv.class[i];
> +		d = deltas->mv.class[i];
> +		for (j = 0; j < ARRAY_SIZE(probs->mv.class[0]); j++)
> +			p[j] = update_mv_prob(d[j], p[j]);
> +
> +		p = probs->mv.class0_bit;
> +		d = deltas->mv.class0_bit;
> +		p[i] = update_mv_prob(d[i], p[i]);
> +
> +		p = probs->mv.bits[i];
> +		d = deltas->mv.bits[i];
> +		for (j = 0; j < ARRAY_SIZE(probs->mv.bits[0]); j++)
> +			p[j] = update_mv_prob(d[j], p[j]);
> +
> +		for (j = 0; j < ARRAY_SIZE(probs->mv.class0_fr[0]); j++) {
> +			p = probs->mv.class0_fr[i][j];
> +			d = deltas->mv.class0_fr[i][j];
> +
> +			p[0] = update_mv_prob(d[0], p[0]);
> +			p[1] = update_mv_prob(d[1], p[1]);
> +			p[2] = update_mv_prob(d[2], p[2]);
> +		}
> +
> +		p = probs->mv.fr[i];
> +		d = deltas->mv.fr[i];
> +		for (j = 0; j < ARRAY_SIZE(probs->mv.fr[i]); j++)
> +			p[j] = update_mv_prob(d[j], p[j]);
> +
> +		if (dec_params->flags & V4L2_VP9_FRAME_FLAG_ALLOW_HIGH_PREC_MV) {
> +			p = probs->mv.class0_hp;
> +			d = deltas->mv.class0_hp;
> +			p[i] = update_mv_prob(d[i], p[i]);
> +
> +			p = probs->mv.hp;
> +			d = deltas->mv.hp;
> +			p[i] = update_mv_prob(d[i], p[i]);
> +		}
> +	}
> +}
> +
> +/* Counterpart to 6.3 compressed_header(), but parsing has been done in userspace. */
> +static void fw_update_probs(struct rkvdec_vp9_frame_context *probs,
> +			    const struct v4l2_ctrl_vp9_compressed_hdr_probs *deltas,
> +			    const struct v4l2_ctrl_vp9_frame_decode_params *dec_params)
> +{
> +	if (dec_params->tx_mode == V4L2_VP9_TX_MODE_SELECT)
> +		update_tx_probs(probs, deltas);
> +
> +	update_coef_probs(probs, deltas, dec_params);
> +
> +	update_skip_probs(probs, deltas);
> +
> +	if (dec_params->flags & V4L2_VP9_FRAME_FLAG_KEY_FRAME ||
> +	    dec_params->flags & V4L2_VP9_FRAME_FLAG_INTRA_ONLY)
> +		return;
> +
> +	update_inter_mode_probs(probs, deltas);
> +
> +	if (dec_params->interpolation_filter == V4L2_VP9_INTERP_FILTER_SWITCHABLE)
> +		update_interp_filter_probs(probs, deltas);
> +
> +	update_is_inter_probs(probs, deltas);
> +
> +	update_frame_reference_mode_probs(dec_params->reference_mode, probs, deltas);
> +
> +	update_y_mode_probs(probs, deltas);
> +
> +	update_partition_probs(probs, deltas);
> +
> +	update_mv_probs(probs, deltas, dec_params);
> +}
> +
> +static int rkvdec_vp9_run_preamble(struct rkvdec_ctx *ctx,
> +				   struct rkvdec_vp9_run *run)
> +{
> +	const struct v4l2_ctrl_vp9_frame_decode_params *dec_params;
> +	const struct v4l2_ctrl_vp9_compressed_hdr_probs *prob_updates;
> +	struct rkvdec_vp9_ctx *vp9_ctx = ctx->priv;
> +	struct v4l2_ctrl *ctrl;
> +	u8 fctx_idx;
> +	int ret, i;
> +
> +	/* v4l2-specific stuff */
> +	rkvdec_run_preamble(ctx, &run->base);
> +
> +	ctrl = v4l2_ctrl_find(&ctx->ctrl_hdl,
> +			      V4L2_CID_STATELESS_VP9_FRAME_DECODE_PARAMS);
> +	WARN_ON(!ctrl);

How about:

	if (WARN_ON(!ctrl))
		return -EINVAL;

> +
> +	dec_params = ctrl ? ctrl->p_cur.p : NULL;
> +	if (WARN_ON(!dec_params))
> +		return -EINVAL;

and then these three lines can be replaced by:

	dec_params = ctrl->p_cur.p;

> +
> +	ret = validate_dec_params(ctx, dec_params);
> +	if (ret)
> +		return ret;
> +
> +	run->decode_params = dec_params;
> +
> +	ctrl = v4l2_ctrl_find(&ctx->ctrl_hdl, V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS);
> +	WARN_ON(!ctrl);
> +
> +	prob_updates = ctrl->p_cur.p;
> +	if (WARN_ON(!prob_updates))
> +		return -EINVAL;

Ditto.

> +
> +	/*
> +	 * vp9 stuff
> +	 *
> +	 * by this point the userspace has done all parts of 6.2 uncompressed_header()
> +	 * except this fragment:
> +	 * if ( FrameIsIntra || error_resilient_mode ) {
> +	 *	setup_past_independence ( )
> +	 *	if ( frame_type == KEY_FRAME || error_resilient_mode == 1 ||
> +	 *	     reset_frame_context == 3 ) {
> +	 *		for ( i = 0; i < 4; i ++ ) {
> +	 *			save_probs( i )
> +	 *		}
> +	 *	} else if ( reset_frame_context == 2 ) {
> +	 *		save_probs( frame_context_idx )
> +	 *	}
> +	 *	frame_context_idx = 0
> +	 * }
> +	 */
> +	fctx_idx = run->decode_params->frame_context_idx;
> +	vp9_ctx->cur.frame_context_idx = run->decode_params->frame_context_idx;
> +
> +	if (dec_params->flags & V4L2_VP9_FRAME_FLAG_KEY_FRAME ||
> +	    dec_params->flags & V4L2_VP9_FRAME_FLAG_INTRA_ONLY ||
> +	    dec_params->flags & V4L2_VP9_FRAME_FLAG_ERROR_RESILIENT) {
> +		/*
> +		 * setup_past_independence()
> +		 * We do nothing here. Instead of storing default probs in some intermediate
> +		 * location and then copying from that location to appropriate contexts
> +		 * in save_probs() below, we skip that step and save default probs directly
> +		 * to appropriate contexts.
> +		 */
> +		if (dec_params->flags & V4L2_VP9_FRAME_FLAG_KEY_FRAME ||
> +		    dec_params->flags & V4L2_VP9_FRAME_FLAG_ERROR_RESILIENT ||
> +		    dec_params->reset_frame_context == V4L2_VP9_RESET_FRAME_CTX_ALL)
> +			for (i = 0; i < ARRAY_SIZE(vp9_ctx->frame_context); ++i)
> +				/* save_probs(i) */
> +				memcpy(&vp9_ctx->frame_context[i],
> +				       &vp9_default_probs, sizeof(vp9_default_probs));
> +		else if (dec_params->reset_frame_context == V4L2_VP9_RESET_FRAME_CTX_SPEC)
> +			/* save_probs(fctx_idx) */
> +			memcpy(&vp9_ctx->frame_context[fctx_idx],
> +			       &vp9_default_probs, sizeof(vp9_default_probs));
> +		fctx_idx = 0;
> +		vp9_ctx->cur.frame_context_idx = 0;
> +	}
> +
> +	/* 6.1 frame(sz): load_probs() and load_probs2() */
> +	vp9_ctx->probability_tables = vp9_ctx->frame_context[fctx_idx];
> +
> +	/*
> +	 * The userspace has also performed 6.3 compressed_header(), but handling the
> +	 * probs in a special way. All probs which need updating, except MV-related,
> +	 * have been read from the bitstream and translated through inv_map_table[],
> +	 * but no 6.3.6 inv_recenter_nonneg(v, m) has been performed. The values passed
> +	 * by userspace are either translated values (there are no 0 values in
> +	 * inv_map_table[]), or zero to indicate no update. All MV-related probs which need
> +	 * updating have been read from the bitstream and (mv_prob << 1) | 1 has been
> +	 * performed. The values passed by userspace are either new values
> +	 * to replace old ones (the above mentioned shift and bitwise or never result in
> +	 * a zero) or zero to indicate no update.
> +	 * fw_update_probs() performs actual probs updates or leaves probs as-is
> +	 * for values for which a zero was passed from userspace.
> +	 */
> +	fw_update_probs(&vp9_ctx->probability_tables, prob_updates, dec_params);
> +
> +	return 0;
> +}
> +
> +static int rkvdec_vp9_run(struct rkvdec_ctx *ctx)
> +{
> +	struct rkvdec_dev *rkvdec = ctx->dev;
> +	struct rkvdec_vp9_run run = { };
> +	int ret;
> +
> +	ret = rkvdec_vp9_run_preamble(ctx, &run);
> +	if (ret) {
> +		rkvdec_run_postamble(ctx, &run.base);
> +		return ret;
> +	}
> +
> +	/* Prepare probs. */
> +	init_probs(ctx, &run);
> +
> +	/* Configure hardware registers. */
> +	config_registers(ctx, &run);
> +
> +	rkvdec_run_postamble(ctx, &run.base);
> +
> +	schedule_delayed_work(&rkvdec->watchdog_work, msecs_to_jiffies(2000));
> +
> +	writel(1, rkvdec->regs + RKVDEC_REG_PREF_LUMA_CACHE_COMMAND);
> +	writel(1, rkvdec->regs + RKVDEC_REG_PREF_CHR_CACHE_COMMAND);
> +
> +	writel(0xe, rkvdec->regs + RKVDEC_REG_STRMD_ERR_EN);
> +	/* Start decoding! */
> +	writel(RKVDEC_INTERRUPT_DEC_E | RKVDEC_CONFIG_DEC_CLK_GATE_E |
> +	       RKVDEC_TIMEOUT_E | RKVDEC_BUF_EMPTY_E,
> +	       rkvdec->regs + RKVDEC_REG_INTERRUPT);
> +
> +	return 0;
> +}
> +
> +/* 8.4.1 Merge prob process */
> +static u8 merge_prob(u8 pre_prob, u32 ct0, u32 ct1, u16 count_sat, u32 max_update_factor)
> +{
> +	u32 den, prob, count, factor;
> +
> +	den = ct0 + ct1;
> +	if (!den) {
> +		/*
> +		 * prob = 128, count = 0, update_factor = 0
> +		 * Round2's argument: pre_prob * 256
> +		 * (pre_prob * 256 + 128) >> 8 == pre_prob
> +		 */
> +		return pre_prob;
> +	}
> +
> +	prob = clamp(((ct0 << 8) + (den >> 1)) / den, (u32)1, (u32)255);
> +	count = min_t(u32, den, count_sat);
> +	factor = rkvdec_fastdiv(max_update_factor * count, count_sat);
> +
> +	/*
> +	 * Round2(pre_prob * (256 - factor) + prob * factor, 8)
> +	 * Round2(pre_prob * 256 + (prob - pre_prob) * factor, 8)
> +	 * (pre_prob * 256 >> 8) + (((prob - pre_prob) * factor + 128) >> 8)
> +	 */
> +	return pre_prob + (((prob - pre_prob) * factor + 128) >> 8);
> +}
> +
> +static inline u8 noncoef_merge_prob(u8 pre_prob, u32 ct0, u32 ct1)
> +{
> +	return merge_prob(pre_prob, ct0, ct1, 20, 128);
> +}
> +
> +/* 8.4.2 Merge probs process */
> +/*
> + * merge_probs() is a recursive function in the spec. We avoid recursion in the kernel.
> + * That said, the "tree" parameter of merge_probs() controls how deep the recursion goes.
> + * It turns out that in all cases the recursive calls boil down to a short-ish series
> + * of merge_prob() invocations (note no "s").
> + *
> + * Variant A
> + * ---------
> + * merge_probs(small_token_tree, 2):
> + *	merge_prob(p[1], c[0], c[1] + c[2])
> + *	merge_prob(p[2], c[1], c[2])
> + *
> + * Variant B
> + * ---------
> + * merge_probs(binary_tree, 0) or
> + * merge_probs(tx_size_8_tree, 0):
> + *	merge_prob(p[0], c[0], c[1])
> + *
> + * Variant C
> + * ---------
> + * merge_probs(inter_mode_tree, 0):
> + *	merge_prob(p[0], c[2], c[1] + c[0] + c[3])
> + *	merge_prob(p[1], c[0], c[1] + c[3])
> + *	merge_prob(p[2], c[1], c[3])
> + *
> + * Variant D
> + * ---------
> + * merge_probs(intra_mode_tree, 0):
> + *	merge_prob(p[0], c[0], c[1] + ... + c[9])
> + *	merge_prob(p[1], c[9], c[1] + ... + c[8])
> + *	merge_prob(p[2], c[1], c[2] + ... + c[8])
> + *	merge_prob(p[3], c[2] + c[4] + c[5], c[3] + c[8] + c[6] + c[7])
> + *	merge_prob(p[4], c[2], c[4] + c[5])
> + *	merge_prob(p[5], c[4], c[5])
> + *	merge_prob(p[6], c[3], c[8] + c[6] + c[7])
> + *	merge_prob(p[7], c[8], c[6] + c[7])
> + *	merge_prob(p[8], c[6], c[7])
> + *
> + * Variant E
> + * ---------
> + * merge_probs(partition_tree, 0) or
> + * merge_probs(tx_size_32_tree, 0) or
> + * merge_probs(mv_joint_tree, 0) or
> + * merge_probs(mv_fr_tree, 0):
> + *	merge_prob(p[0], c[0], c[1] + c[2] + c[3])
> + *	merge_prob(p[1], c[1], c[2] + c[3])
> + *	merge_prob(p[2], c[2], c[3])
> + *
> + * Variant F
> + * ---------
> + * merge_probs(interp_filter_tree, 0) or
> + * merge_probs(tx_size_16_tree, 0):
> + *	merge_prob(p[0], c[0], c[1] + c[2])
> + *	merge_prob(p[1], c[1], c[2])
> + *
> + * Variant G
> + * ---------
> + * merge_probs(mv_class_tree, 0):
> + *	merge_prob(p[0], c[0], c[1] + ... + c[10])
> + *	merge_prob(p[1], c[1], c[2] + ... + c[10])
> + *	merge_prob(p[2], c[2] + c[3], c[4] + ... + c[10])
> + *	merge_prob(p[3], c[2], c[3])
> + *	merge_prob(p[4], c[4] + c[5], c[6] + ... + c[10])
> + *	merge_prob(p[5], c[4], c[5])
> + *	merge_prob(p[6], c[6], c[7] + ... + c[10])
> + *	merge_prob(p[7], c[7] + c[8], c[9] + c[10])
> + *	merge_prob(p[8], c[7], c[8])
> + *	merge_prob(p[9], c[9], [10])
> + */
> +
> +static inline void merge_probs_variant_a(u8 *p, const u32 *c, u16 count_sat, u32 update_factor)
> +{
> +	p[1] = merge_prob(p[1], c[0], c[1] + c[2], count_sat, update_factor);
> +	p[2] = merge_prob(p[2], c[1], c[2], count_sat, update_factor);
> +}

All these functions here appear to also be vp9 generic. Something for v4l2-vp9.c?

> +
> +static inline void merge_probs_variant_b(u8 *p, const u32 *c, u16 count_sat, u32 update_factor)
> +{
> +	p[0] = merge_prob(p[0], c[0], c[1], count_sat, update_factor);
> +}
> +
> +static inline void merge_probs_variant_c(u8 *p, const u32 *c)
> +{
> +	p[0] = noncoef_merge_prob(p[0], c[2], c[1] + c[0] + c[3]);
> +	p[1] = noncoef_merge_prob(p[1], c[0], c[1] + c[3]);
> +	p[2] = noncoef_merge_prob(p[2], c[1], c[3]);
> +}
> +
> +static void merge_probs_variant_d(u8 *p, const u32 *c)
> +{
> +	u32 sum = 0, s2;
> +
> +	sum = c[1] + c[2] + c[3] + c[4] + c[5] + c[6] + c[7] + c[8] + c[9];
> +
> +	p[0] = noncoef_merge_prob(p[0], c[0], sum);
> +	sum -= c[9];
> +	p[1] = noncoef_merge_prob(p[1], c[9], sum);
> +	sum -= c[1];
> +	p[2] = noncoef_merge_prob(p[2], c[1], sum);
> +	s2 = c[2] + c[4] + c[5];
> +	sum -= s2;
> +	p[3] = noncoef_merge_prob(p[3], s2, sum);
> +	s2 -= c[2];
> +	p[4] = noncoef_merge_prob(p[4], c[2], s2);
> +	p[5] = noncoef_merge_prob(p[5], c[4], c[5]);
> +	sum -= c[3];
> +	p[6] = noncoef_merge_prob(p[6], c[3], sum);
> +	sum -= c[8];
> +	p[7] = noncoef_merge_prob(p[7], c[8], sum);
> +	p[8] = noncoef_merge_prob(p[8], c[6], c[7]);
> +}
> +
> +static inline void merge_probs_variant_e(u8 *p, const u32 *c)
> +{
> +	p[0] = noncoef_merge_prob(p[0], c[0], c[1] + c[2] + c[3]);
> +	p[1] = noncoef_merge_prob(p[1], c[1], c[2] + c[3]);
> +	p[2] = noncoef_merge_prob(p[2], c[2], c[3]);
> +}
> +
> +static inline void merge_probs_variant_f(u8 *p, const u32 *c)
> +{
> +	p[0] = noncoef_merge_prob(p[0], c[0], c[1] + c[2]);
> +	p[1] = noncoef_merge_prob(p[1], c[1], c[2]);
> +}
> +
> +static void merge_probs_variant_g(u8 *p, const u32 *c)
> +{
> +	u32 sum;
> +
> +	sum = c[1] + c[2] + c[3] + c[4] + c[5] + c[6] + c[7] + c[8] + c[9] + c[10];
> +	p[0] = noncoef_merge_prob(p[0], c[0], sum);
> +	sum -= c[1];
> +	p[1] = noncoef_merge_prob(p[1], c[1], sum);
> +	sum -= c[2] + c[3];
> +	p[2] = noncoef_merge_prob(p[2], c[2] + c[3], sum);
> +	p[3] = noncoef_merge_prob(p[3], c[2], c[3]);
> +	sum -= c[4] + c[5];
> +	p[4] = noncoef_merge_prob(p[4], c[4] + c[5], sum);
> +	p[5] = noncoef_merge_prob(p[5], c[4], c[5]);
> +	sum -= c[6];
> +	p[6] = noncoef_merge_prob(p[6], c[6], sum);
> +	p[7] = noncoef_merge_prob(p[7], c[7] + c[8], c[9] + c[10]);
> +	p[8] = noncoef_merge_prob(p[8], c[7], c[8]);
> +	p[9] = noncoef_merge_prob(p[9], c[9], c[10]);
> +}
> +
> +/* 8.4.3 Coefficient probability adaptation process */
> +static inline void adapt_probs_variant_a_coef(u8 *p, const u32 *c, u32 update_factor)
> +{
> +	merge_probs_variant_a(p, c, 24, update_factor);
> +}
> +
> +static inline void adapt_probs_variant_b_coef(u8 *p, const u32 *c, u32 update_factor)
> +{
> +	merge_probs_variant_b(p, c, 24, update_factor);
> +}
> +
> +static void _adapt_coeff(u8 coef[6][6][3],
> +			 const struct rkvdec_vp9_refs_counts ref_cnt[6][6],
> +			 u32 uf)
> +{
> +	s32 l, m;
> +
> +	for (l = 0; l < 6; l++) {
> +		for (m = 0; m < BAND_6(l); m++) {
> +			u8 *p = coef[l][m];
> +			const u32 counts_more_coefs[2] = {
> +				ref_cnt[l][m].eob[1],
> +				ref_cnt[l][m].eob[0] - ref_cnt[l][m].eob[1],
> +			};
> +
> +			adapt_probs_variant_a_coef(p, ref_cnt[l][m].coeff, uf);
> +			adapt_probs_variant_b_coef(p, counts_more_coefs, uf);
> +		}
> +	}
> +}
> +
> +static void _adapt_coef_probs(struct rkvdec_vp9_frame_context *probs,
> +			      const struct rkvdec_vp9_refs_counts ref_cnt[2][4][2][6][6],
> +			      unsigned int uf)
> +{
> +	unsigned int i, j, k;
> +
> +	for (i = 0; i < ARRAY_SIZE(probs->coef); i++)
> +		for (j = 0; j < ARRAY_SIZE(probs->coef[0]); j++)
> +			for (k = 0; k < ARRAY_SIZE(probs->coef[0][0]); k++)
> +				_adapt_coeff(probs->coef[i][j][k], ref_cnt[k][i][j], uf);
> +}
> +
> +static void adapt_coef_probs(struct rkvdec_vp9_frame_context *probs,
> +			     struct rkvdec_aux_buf *count_tbl,
> +			     struct rkvdec_vp9_frame_info *last,
> +			     bool frame_is_intra)
> +{
> +	if (frame_is_intra) {
> +		const struct rkvdec_vp9_intra_frame_symbol_counts *sym_cnts;
> +
> +		sym_cnts = count_tbl->cpu;
> +		_adapt_coef_probs(probs, sym_cnts->ref_cnt, 112);
> +	} else {
> +		const struct rkvdec_vp9_inter_frame_symbol_counts *sym_cnts;
> +
> +		sym_cnts = count_tbl->cpu;
> +		if (last->valid &&
> +		    !(last->flags & V4L2_VP9_FRAME_FLAG_KEY_FRAME))
> +			_adapt_coef_probs(probs, sym_cnts->ref_cnt, 112);
> +		else
> +			_adapt_coef_probs(probs, sym_cnts->ref_cnt, 128);
> +	}
> +}
> +
> +/* 8.4.4 Non coefficient probability adaptation process, adapt_probs() */
> +static inline void adapt_probs_variant_b(u8 *p, const u32 *c)
> +{
> +	merge_probs_variant_b(p, c, 20, 128);
> +}
> +
> +static inline void adapt_probs_variant_c(u8 *p, const u32 *c)
> +{
> +	merge_probs_variant_c(p, c);
> +}
> +
> +static inline void adapt_probs_variant_d(u8 *p, const u32 *c)
> +{
> +	merge_probs_variant_d(p, c);
> +}
> +
> +static inline void adapt_probs_variant_e(u8 *p, const u32 *c)
> +{
> +	merge_probs_variant_e(p, c);
> +}
> +
> +static inline void adapt_probs_variant_f(u8 *p, const u32 *c)
> +{
> +	merge_probs_variant_f(p, c);
> +}
> +
> +static inline void adapt_probs_variant_g(u8 *p, const u32 *c)
> +{
> +	merge_probs_variant_g(p, c);
> +}
> +
> +/* 8.4.4 Non coefficient probability adaptation process, adapt_prob() */
> +static inline u8 adapt_prob(u8 prob, const u32 counts[2])
> +{
> +	return noncoef_merge_prob(prob, counts[0], counts[1]);
> +}
> +
> +/* 8.4.4 Non coefficient probability adaptation process */
> +static void adapt_noncoef_probs(struct rkvdec_ctx *ctx)
> +{
> +	struct rkvdec_vp9_ctx *vp9_ctx = ctx->priv;
> +	struct rkvdec_vp9_frame_context *probs = &vp9_ctx->probability_tables;
> +	const struct rkvdec_vp9_inter_frame_symbol_counts *sym_cnts;
> +	unsigned int i, j;
> +
> +	sym_cnts = vp9_ctx->count_tbl.cpu;
> +
> +	for (i = 0; i < ARRAY_SIZE(probs->is_inter); i++)
> +		probs->is_inter[i] = adapt_prob(probs->is_inter[i], sym_cnts->inter[i]);
> +
> +	for (i = 0; i < ARRAY_SIZE(probs->comp_mode); i++)
> +		probs->comp_mode[i] = adapt_prob(probs->comp_mode[i], sym_cnts->comp[i]);
> +
> +	for (i = 0; i < ARRAY_SIZE(probs->comp_ref); i++)
> +		probs->comp_ref[i] = adapt_prob(probs->comp_ref[i], sym_cnts->comp_ref[i]);
> +
> +	if (vp9_ctx->cur.reference_mode != V4L2_VP9_REF_MODE_COMPOUND)
> +		for (i = 0; i < ARRAY_SIZE(probs->single_ref); i++)
> +			for (j = 0; j < ARRAY_SIZE(probs->single_ref[0]); j++)
> +				probs->single_ref[i][j] = adapt_prob(probs->single_ref[i][j],
> +								     sym_cnts->single_ref[i][j]);
> +
> +	for (i = 0; i < ARRAY_SIZE(probs->inter_mode); i++)
> +		adapt_probs_variant_c(probs->inter_mode[i], sym_cnts->mv_mode[i]);
> +
> +	for (i = 0; i < ARRAY_SIZE(probs->y_mode); i++)
> +		adapt_probs_variant_d(probs->y_mode[i], sym_cnts->y_mode[i]);
> +
> +	for (i = 0; i < ARRAY_SIZE(probs->uv_mode); i++)
> +		adapt_probs_variant_d(probs->uv_mode[i], sym_cnts->uv_mode[i]);
> +
> +	for (i = 0; i < ARRAY_SIZE(probs->partition); i++)
> +		adapt_probs_variant_e(probs->partition[i], sym_cnts->partition[i]);
> +
> +	for (i = 0; i < ARRAY_SIZE(probs->skip); i++)
> +		probs->skip[i] = adapt_prob(probs->skip[i], sym_cnts->skip[i]);
> +
> +	if (vp9_ctx->cur.interpolation_filter == V4L2_VP9_INTERP_FILTER_SWITCHABLE)
> +		for (i = 0; i < ARRAY_SIZE(probs->interp_filter); i++)
> +			adapt_probs_variant_f(probs->interp_filter[i], sym_cnts->filter[i]);
> +
> +	if (vp9_ctx->cur.tx_mode == V4L2_VP9_TX_MODE_SELECT)
> +		for (i = 0; i < ARRAY_SIZE(probs->tx8); i++) {
> +			adapt_probs_variant_b(probs->tx8[i], sym_cnts->tx8p[i]);
> +			adapt_probs_variant_f(probs->tx16[i], sym_cnts->tx16p[i]);
> +			adapt_probs_variant_e(probs->tx32[i], sym_cnts->tx32p[i]);
> +		}
> +
> +	adapt_probs_variant_e(probs->mv.joint, sym_cnts->mv_joint);
> +
> +	for (i = 0; i < ARRAY_SIZE(probs->mv.sign); i++) {
> +		probs->mv.sign[i] = adapt_prob(probs->mv.sign[i], sym_cnts->sign[i]);
> +
> +		adapt_probs_variant_g(probs->mv.class[i], sym_cnts->classes[i]);
> +
> +		probs->mv.class0_bit[i] = adapt_prob(probs->mv.class0_bit[i], sym_cnts->class0[i]);
> +
> +		for (j = 0; j < ARRAY_SIZE(probs->mv.bits[0]); j++)
> +			probs->mv.bits[i][j] = adapt_prob(probs->mv.bits[i][j],
> +							  sym_cnts->bits[i][j]);
> +
> +		for (j = 0; j < ARRAY_SIZE(probs->mv.class0_fr[0]); j++)
> +			adapt_probs_variant_e(probs->mv.class0_fr[i][j],
> +					      sym_cnts->class0_fp[i][j]);
> +
> +		adapt_probs_variant_e(probs->mv.fr[i], sym_cnts->fp[i]);
> +
> +		if (!(vp9_ctx->cur.flags & V4L2_VP9_FRAME_FLAG_ALLOW_HIGH_PREC_MV))
> +			continue;
> +
> +		probs->mv.class0_hp[i] = adapt_prob(probs->mv.class0_hp[i],
> +						    sym_cnts->class0_hp[i]);
> +
> +		probs->mv.hp[i] = adapt_prob(probs->mv.hp[i], sym_cnts->hp[i]);
> +	}
> +}
> +
> +#define copy_tx_and_skip(p1, p2)				\
> +do {								\
> +	memcpy((p1)->tx8, (p2)->tx8, sizeof((p1)->tx8));	\
> +	memcpy((p1)->tx16, (p2)->tx16, sizeof((p1)->tx16));	\
> +	memcpy((p1)->tx32, (p2)->tx32, sizeof((p1)->tx32));	\
> +	memcpy((p1)->skip, (p2)->skip, sizeof((p1)->skip));	\
> +} while (0)
> +
> +static void rkvdec_vp9_done(struct rkvdec_ctx *ctx,
> +			    struct vb2_v4l2_buffer *src_buf,
> +			    struct vb2_v4l2_buffer *dst_buf,
> +			    enum vb2_buffer_state result)
> +{
> +	struct rkvdec_vp9_ctx *vp9_ctx = ctx->priv;
> +	unsigned int fctx_idx;
> +
> +	/* v4l2-specific stuff */
> +	if (result == VB2_BUF_STATE_ERROR)
> +		goto out_update_last;
> +
> +	/*
> +	 * vp9 stuff
> +	 *
> +	 * 6.1.2 refresh_probs()
> +	 *
> +	 * In the spec a complementary condition goes last in 6.1.2 refresh_probs(),
> +	 * but it makes no sense to perform all the activities from the first "if"
> +	 * there if we actually are not refreshing the frame context. On top of that,
> +	 * because of 6.2 uncompressed_header() whenever error_resilient_mode == 1,
> +	 * refresh_frame_context == 0. Consequently, if we don't jump to out_update_last
> +	 * it means error_resilient_mode must be 0.
> +	 */
> +	if (!(vp9_ctx->cur.flags & V4L2_VP9_FRAME_FLAG_REFRESH_FRAME_CTX))
> +		goto out_update_last;
> +
> +	fctx_idx = vp9_ctx->cur.frame_context_idx;
> +
> +	if (!(vp9_ctx->cur.flags & V4L2_VP9_FRAME_FLAG_PARALLEL_DEC_MODE)) {
> +		/* error_resilient_mode == 0 && frame_parallel_decoding_mode == 0 */
> +		struct rkvdec_vp9_frame_context *probs = &vp9_ctx->probability_tables;
> +		bool frame_is_intra = vp9_ctx->cur.flags &
> +		    (V4L2_VP9_FRAME_FLAG_KEY_FRAME | V4L2_VP9_FRAME_FLAG_INTRA_ONLY);
> +		struct tx_and_skip {
> +			u8 tx8[2][1];
> +			u8 tx16[2][2];
> +			u8 tx32[2][3];
> +			u8 skip[3];
> +		} _tx_skip, *tx_skip = &_tx_skip;
> +
> +		/* buffer the forward-updated TX and skip probs */
> +		if (frame_is_intra)
> +			copy_tx_and_skip(tx_skip, probs);
> +
> +		/* 6.1.2 refresh_probs(): load_probs() and load_probs2() */
> +		*probs = vp9_ctx->frame_context[fctx_idx];
> +
> +		/* if FrameIsIntra then undo the effect of load_probs2() */
> +		if (frame_is_intra)
> +			copy_tx_and_skip(probs, tx_skip);
> +
> +		adapt_coef_probs(probs, &vp9_ctx->count_tbl, &vp9_ctx->last, frame_is_intra);
> +		if (!frame_is_intra) {
> +			/* load_probs2() already done */
> +			adapt_noncoef_probs(ctx);
> +		}
> +	}
> +
> +	/* 6.1.2 refresh_probs(): save_probs(fctx_idx) */
> +	vp9_ctx->frame_context[fctx_idx] = vp9_ctx->probability_tables;
> +
> +out_update_last:
> +	update_ctx_last_info(vp9_ctx);
> +}
> +
> +static int rkvdec_vp9_start(struct rkvdec_ctx *ctx)
> +{
> +	struct rkvdec_dev *rkvdec = ctx->dev;
> +	struct rkvdec_vp9_priv_tbl *priv_tbl;
> +	struct rkvdec_vp9_ctx *vp9_ctx;
> +	u8 *count_tbl;
> +	int ret;
> +
> +	vp9_ctx = kzalloc(sizeof(*vp9_ctx), GFP_KERNEL);
> +	if (!vp9_ctx)
> +		return -ENOMEM;
> +
> +	ctx->priv = vp9_ctx;
> +
> +	priv_tbl = dma_alloc_coherent(rkvdec->dev, sizeof(*priv_tbl),
> +				      &vp9_ctx->priv_tbl.dma, GFP_KERNEL);
> +	if (!priv_tbl) {
> +		ret = -ENOMEM;
> +		goto err_free_ctx;
> +	}
> +
> +	vp9_ctx->priv_tbl.size = sizeof(*priv_tbl);
> +	vp9_ctx->priv_tbl.cpu = priv_tbl;
> +	memset(priv_tbl, 0, sizeof(*priv_tbl));
> +
> +	count_tbl = dma_alloc_coherent(rkvdec->dev, RKVDEC_VP9_COUNT_SIZE,
> +				       &vp9_ctx->count_tbl.dma, GFP_KERNEL);
> +	if (!count_tbl) {
> +		ret = -ENOMEM;
> +		goto err_free_priv_tbl;
> +	}
> +
> +	vp9_ctx->count_tbl.size = RKVDEC_VP9_COUNT_SIZE;
> +	vp9_ctx->count_tbl.cpu = count_tbl;
> +	memset(count_tbl, 0, sizeof(*count_tbl));
> +
> +	return 0;
> +
> +err_free_priv_tbl:
> +	dma_free_coherent(rkvdec->dev, vp9_ctx->priv_tbl.size,
> +			  vp9_ctx->priv_tbl.cpu, vp9_ctx->priv_tbl.dma);
> +
> +err_free_ctx:
> +	kfree(vp9_ctx);
> +	return ret;
> +}
> +
> +static void rkvdec_vp9_stop(struct rkvdec_ctx *ctx)
> +{
> +	struct rkvdec_vp9_ctx *vp9_ctx = ctx->priv;
> +	struct rkvdec_dev *rkvdec = ctx->dev;
> +
> +	dma_free_coherent(rkvdec->dev, vp9_ctx->count_tbl.size,
> +			  vp9_ctx->count_tbl.cpu, vp9_ctx->count_tbl.dma);
> +	dma_free_coherent(rkvdec->dev, vp9_ctx->priv_tbl.size,
> +			  vp9_ctx->priv_tbl.cpu, vp9_ctx->priv_tbl.dma);
> +	kfree(vp9_ctx);
> +}
> +
> +static int rkvdec_vp9_adjust_fmt(struct rkvdec_ctx *ctx,
> +				 struct v4l2_format *f)
> +{
> +	struct v4l2_pix_format_mplane *fmt = &f->fmt.pix_mp;
> +
> +	fmt->num_planes = 1;
> +	if (!fmt->plane_fmt[0].sizeimage)
> +		fmt->plane_fmt[0].sizeimage = fmt->width * fmt->height * 2;
> +	return 0;
> +}
> +
> +const struct rkvdec_coded_fmt_ops rkvdec_vp9_fmt_ops = {
> +	.adjust_fmt = rkvdec_vp9_adjust_fmt,
> +	.start = rkvdec_vp9_start,
> +	.stop = rkvdec_vp9_stop,
> +	.run = rkvdec_vp9_run,
> +	.done = rkvdec_vp9_done,
> +};
> diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c
> index ef2166043127..7a931affa8fd 100644
> --- a/drivers/staging/media/rkvdec/rkvdec.c
> +++ b/drivers/staging/media/rkvdec/rkvdec.c
> @@ -99,10 +99,30 @@ static const struct rkvdec_ctrls rkvdec_h264_ctrls = {
>  	.num_ctrls = ARRAY_SIZE(rkvdec_h264_ctrl_descs),
>  };
>  
> -static const u32 rkvdec_h264_decoded_fmts[] = {
> +static const u32 rkvdec_h264_vp9_decoded_fmts[] = {
>  	V4L2_PIX_FMT_NV12,
>  };
>  
> +static const struct rkvdec_ctrl_desc rkvdec_vp9_ctrl_descs[] = {
> +	{
> +		.cfg.id = V4L2_CID_STATELESS_VP9_FRAME_DECODE_PARAMS,
> +	},
> +	{
> +		.cfg.id = V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS,
> +	},
> +	{
> +		.cfg.id = V4L2_CID_MPEG_VIDEO_VP9_PROFILE,
> +		.cfg.min = V4L2_MPEG_VIDEO_VP9_PROFILE_0,
> +		.cfg.max = V4L2_MPEG_VIDEO_VP9_PROFILE_0,
> +		.cfg.def = V4L2_MPEG_VIDEO_VP9_PROFILE_0,
> +	},
> +};
> +
> +static const struct rkvdec_ctrls rkvdec_vp9_ctrls = {
> +	.ctrls = rkvdec_vp9_ctrl_descs,
> +	.num_ctrls = ARRAY_SIZE(rkvdec_vp9_ctrl_descs),
> +};
> +
>  static const struct rkvdec_coded_fmt_desc rkvdec_coded_fmts[] = {
>  	{
>  		.fourcc = V4L2_PIX_FMT_H264_SLICE,
> @@ -116,8 +136,23 @@ static const struct rkvdec_coded_fmt_desc rkvdec_coded_fmts[] = {
>  		},
>  		.ctrls = &rkvdec_h264_ctrls,
>  		.ops = &rkvdec_h264_fmt_ops,
> -		.num_decoded_fmts = ARRAY_SIZE(rkvdec_h264_decoded_fmts),
> -		.decoded_fmts = rkvdec_h264_decoded_fmts,
> +		.num_decoded_fmts = ARRAY_SIZE(rkvdec_h264_vp9_decoded_fmts),
> +		.decoded_fmts = rkvdec_h264_vp9_decoded_fmts,
> +	},
> +	{
> +		.fourcc = V4L2_PIX_FMT_VP9_FRAME,
> +		.frmsize = {
> +			.min_width = 64,
> +			.max_width = 4096,
> +			.step_width = 64,
> +			.min_height = 64,
> +			.max_height = 2304,
> +			.step_height = 64,
> +		},
> +		.ctrls = &rkvdec_vp9_ctrls,
> +		.ops = &rkvdec_vp9_fmt_ops,
> +		.num_decoded_fmts = ARRAY_SIZE(rkvdec_h264_vp9_decoded_fmts),
> +		.decoded_fmts = rkvdec_h264_vp9_decoded_fmts,
>  	}
>  };
>  
> @@ -319,7 +354,7 @@ static int rkvdec_s_output_fmt(struct file *file, void *priv,
>  	struct v4l2_m2m_ctx *m2m_ctx = ctx->fh.m2m_ctx;
>  	const struct rkvdec_coded_fmt_desc *desc;
>  	struct v4l2_format *cap_fmt;
> -	struct vb2_queue *peer_vq;
> +	struct vb2_queue *peer_vq, *vq;
>  	int ret;
>  
>  	/*
> @@ -331,6 +366,15 @@ static int rkvdec_s_output_fmt(struct file *file, void *priv,
>  	if (vb2_is_busy(peer_vq))
>  		return -EBUSY;
>  
> +	/*
> +	 * Some codecs like VP9 can contain dynamic resolution changes which
> +	 * are currently not supported by the V4L2 API or driver, so return
> +	 * an error if userspace tries to reconfigure the output format.
> +	 */
> +	vq = v4l2_m2m_get_vq(m2m_ctx, V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE);
> +	if (vb2_is_busy(vq))
> +		return -EINVAL;
> +
>  	ret = rkvdec_s_fmt(file, priv, f, rkvdec_try_output_fmt);
>  	if (ret)
>  		return ret;
> diff --git a/drivers/staging/media/rkvdec/rkvdec.h b/drivers/staging/media/rkvdec/rkvdec.h
> index 52ac3874c5e5..8f534743eaf1 100644
> --- a/drivers/staging/media/rkvdec/rkvdec.h
> +++ b/drivers/staging/media/rkvdec/rkvdec.h
> @@ -50,6 +50,10 @@ struct rkvdec_vp9_decoded_buffer_info {
>  struct rkvdec_decoded_buffer {
>  	/* Must be the first field in this struct. */
>  	struct v4l2_m2m_buffer base;
> +
> +	union {
> +		struct rkvdec_vp9_decoded_buffer_info vp9;
> +	};
>  };
>  
>  static inline struct rkvdec_decoded_buffer *
> @@ -116,4 +120,6 @@ void rkvdec_run_preamble(struct rkvdec_ctx *ctx, struct rkvdec_run *run);
>  void rkvdec_run_postamble(struct rkvdec_ctx *ctx, struct rkvdec_run *run);
>  
>  extern const struct rkvdec_coded_fmt_ops rkvdec_h264_fmt_ops;
> +extern const struct rkvdec_coded_fmt_ops rkvdec_vp9_fmt_ops;
> +
>  #endif /* RKVDEC_H_ */
> 

Regards,

	Hans

Re: [RFC RESEND 0/3] vp9 v4l2 stateless uapi

[Hans Verkuil]

Hi Andrzej,

Thank you for working on this!

On 21/04/2021 12:00, Andrzej Pietrasiewicz wrote:
> Dear All,
> 
> This is an RFC on stateless uapi for vp9 decoding with v4l2. This work is based on https://lkml.org/lkml/2020/11/2/1043, but has been substantially reworked. The important change is that the v4l2 control used to pass boolean decoder probabilities has been made unidirectional, and is now called V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS.
> 
> In the previous proposal, to queue a frame the userspace must fully dequeue the previous one, which effectively results in a forced lockstep behavior and defeats vb2's capability to enqueue multiple buffers. Such a design was a consequence of backward probability updates being performed by the kernel driver (which has direct access to appropriate counter values) but forward probability updates being coupled with compressed header parsing performed by the userspace.
> 
> In vp9 the boolean decoder used to decode the bitstream needs certain parameters to work. Those are probabilities, which change with each frame. After each frame is decoded it is known how many times a given symbol occured in the frame, so the probabilities can be adapted. This process is known as backward probabilities update. A next frame header can also contain information which modifies probabilities resulting from backward update. The said modification is called forward probabilities update. The data for backward update is generated by the decoder hardware, while the data for forward update is prepared by reading the compressed frame header. The natural place to parse something is userspace, while the natural place to access hardware-provided counters is the kernel. Such responsibilties assignment was used in the original work.
> 
> To overcome the lockstep, we moved forward probability updates to the kernel, while leaving parsing them in userspace. This way the v4l2 control which is used to pass the probs becomes unidirectional (user->kernel) and the userspace can keep parsing and enqueueing succeeding frames.
> 
> If a particular driver parses the compressed header and does backward probability updates on its own then V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS does not need to be used.
> 
> This series adds vp9 uapi in proper locations, which means it is a proper, "official" uapi, as opposed to staging uapi which was proposed in the above mentioned lkml thread.

Why? I rather liked the way that the other codec APIs started life in a private header
(like include/media/vp8-ctrls.h) and were given time to mature before moving them to
the uAPI. Is there a reason why you think that VP9 doesn't need that?

> 
> The series adds vp9 support to rkvdec driver.
> 
> Rebased onto media_tree.
> 
> I kindly ask for your comments.
> 
> TODO:
> 
> - potentially fine-tune the uAPI (add/remove fields, move between structs)
> - write another driver (intended g2 @ iMX8)
> - verify the added documentation
> 
> Regards,
> 
> Andrzej
> 
> Andrzej Pietrasiewicz (1):
>   media: uapi: Add VP9 stateless decoder controls
> 
> Boris Brezillon (1):
>   media: rkvdec: Add the VP9 backend
> 
> Ezequiel Garcia (1):
>   media: rkvdec: Fix .buf_prepare

Isn't this just a bug fix? Should it be part of this series at all?

If it is just a bug fix, then please post it separately and let me know if it is
a fix that should go to 5.13 (i.e. the current mainline) or if 5.14 is fine.

Regards,

	Hans

> 
>  .../userspace-api/media/v4l/biblio.rst        |   10 +
>  .../media/v4l/ext-ctrls-codec-stateless.rst   |  523 +++
>  .../media/v4l/pixfmt-compressed.rst           |   15 +
>  .../media/v4l/vidioc-g-ext-ctrls.rst          |    8 +
>  .../media/v4l/vidioc-queryctrl.rst            |   12 +
>  .../media/videodev2.h.rst.exceptions          |    2 +
>  drivers/media/v4l2-core/v4l2-ctrls.c          |  244 ++
>  drivers/media/v4l2-core/v4l2-ioctl.c          |    1 +
>  drivers/staging/media/rkvdec/Makefile         |    2 +-
>  drivers/staging/media/rkvdec/rkvdec-vp9.c     | 2846 +++++++++++++++++
>  drivers/staging/media/rkvdec/rkvdec.c         |   62 +-
>  drivers/staging/media/rkvdec/rkvdec.h         |    6 +
>  include/media/v4l2-ctrls.h                    |    4 +
>  include/uapi/linux/v4l2-controls.h            |  455 +++
>  include/uapi/linux/videodev2.h                |    6 +
>  15 files changed, 4190 insertions(+), 6 deletions(-)
>  create mode 100644 drivers/staging/media/rkvdec/rkvdec-vp9.c
> 

Re: [RFC RESEND 0/3] vp9 v4l2 stateless uapi

[Nicolas Dufresne]

Le lundi 26 avril 2021 à 09:38 +0200, Hans Verkuil a écrit :
> Hi Andrzej,
> 
> Thank you for working on this!
> 
> On 21/04/2021 12:00, Andrzej Pietrasiewicz wrote:
> > Dear All,
> > 
> > This is an RFC on stateless uapi for vp9 decoding with v4l2. This work is based on https://lkml.org/lkml/2020/11/2/1043, but has been substantially reworked. The important change is that the v4l2 control used to pass boolean decoder probabilities has been made unidirectional, and is now called V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS.
> > 
> > In the previous proposal, to queue a frame the userspace must fully dequeue the previous one, which effectively results in a forced lockstep behavior and defeats vb2's capability to enqueue multiple buffers. Such a design was a consequence of backward probability updates being performed by the kernel driver (which has direct access to appropriate counter values) but forward probability updates being coupled with compressed header parsing performed by the userspace.
> > 
> > In vp9 the boolean decoder used to decode the bitstream needs certain parameters to work. Those are probabilities, which change with each frame. After each frame is decoded it is known how many times a given symbol occured in the frame, so the probabilities can be adapted. This process is known as backward probabilities update. A next frame header can also contain information which modifies probabilities resulting from backward update. The said modification is called forward probabilities update. The data for backward update is generated by the decoder hardware, while the data for forward update is prepared by reading the compressed frame header. The natural place to parse something is userspace, while the natural place to access hardware-provided counters is the kernel. Such responsibilties assignment was used in the original work.
> > 
> > To overcome the lockstep, we moved forward probability updates to the kernel, while leaving parsing them in userspace. This way the v4l2 control which is used to pass the probs becomes unidirectional (user->kernel) and the userspace can keep parsing and enqueueing succeeding frames.
> > 
> > If a particular driver parses the compressed header and does backward probability updates on its own then V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS does not need to be used.
> > 
> > This series adds vp9 uapi in proper locations, which means it is a proper, "official" uapi, as opposed to staging uapi which was proposed in the above mentioned lkml thread.
> 
> Why? I rather liked the way that the other codec APIs started life in a private header
> (like include/media/vp8-ctrls.h) and were given time to mature before moving them to
> the uAPI. Is there a reason why you think that VP9 doesn't need that?

I'll be honest, I accepted early code into GStreamer for H264, and it ended up
in a nightmare for the users. We now have a released GStreamer that supports
kernel API up to 5.9, a blackwhole at 5.10 and finally master catched up and can
support 5.11+. It is so complicated for packagers to understand what is going
on, that they endup wasting a lot of their time for a single feature in their
OS. Same breakage is happening for VP8 in 5.13, even though VP8 has been working
great all this time. I will for sure for now on ignore any contribution that
depends on staged uAPI.

As for FFMPEG, even though now H264 API is table, the maintainers just simply
ignore the patches as they have been bitten by the reviewing stuff based on
unstable APIs and downstream work.

I believe the staged uAPI has been used wrongly in the past. Stuff has been
staged quicky right before associated project budget for it was exhausted, so it
was in the end a way to look good, and someone else had to pick it up and finish
it. Going straight for final API put more pressure on making good research from
the start, doing more in-depth reviews and avoiding delaying for multiple years
the support. I believe the staging API are confusing even for the Linux
projects. Going straight to stable here is a commitment to finish this work and
doing it correctly.

This specially make sense for VP9, which is a very Open CODEC and were all HW
implementation are Google/Hantro derivatives. Also, unlike when this work all
started, we do have multiple HW we can look at to validate the API, with more
then enough in-depth information to make the right decisions.

> 
> > 
> > The series adds vp9 support to rkvdec driver.
> > 
> > Rebased onto media_tree.
> > 
> > I kindly ask for your comments.
> > 
> > TODO:
> > 
> > - potentially fine-tune the uAPI (add/remove fields, move between structs)
> > - write another driver (intended g2 @ iMX8)

The commitment is subtly describe here, the commitment is to implement a second
driver, Hantro G2 which has a different design), and that even if we have no use
for it in the short term.

> > - verify the added documentation
> > 
> > Regards,
> > 
> > Andrzej
> > 
> > Andrzej Pietrasiewicz (1):
> >   media: uapi: Add VP9 stateless decoder controls
> > 
> > Boris Brezillon (1):
> >   media: rkvdec: Add the VP9 backend
> > 
> > Ezequiel Garcia (1):
> >   media: rkvdec: Fix .buf_prepare
> 
> Isn't this just a bug fix? Should it be part of this series at all?
> 
> If it is just a bug fix, then please post it separately and let me know if it is
> a fix that should go to 5.13 (i.e. the current mainline) or if 5.14 is fine.
> 
> Regards,
> 
> 	Hans
> 
> > 
> >  .../userspace-api/media/v4l/biblio.rst        |   10 +
> >  .../media/v4l/ext-ctrls-codec-stateless.rst   |  523 +++
> >  .../media/v4l/pixfmt-compressed.rst           |   15 +
> >  .../media/v4l/vidioc-g-ext-ctrls.rst          |    8 +
> >  .../media/v4l/vidioc-queryctrl.rst            |   12 +
> >  .../media/videodev2.h.rst.exceptions          |    2 +
> >  drivers/media/v4l2-core/v4l2-ctrls.c          |  244 ++
> >  drivers/media/v4l2-core/v4l2-ioctl.c          |    1 +
> >  drivers/staging/media/rkvdec/Makefile         |    2 +-
> >  drivers/staging/media/rkvdec/rkvdec-vp9.c     | 2846 +++++++++++++++++
> >  drivers/staging/media/rkvdec/rkvdec.c         |   62 +-
> >  drivers/staging/media/rkvdec/rkvdec.h         |    6 +
> >  include/media/v4l2-ctrls.h                    |    4 +
> >  include/uapi/linux/v4l2-controls.h            |  455 +++
> >  include/uapi/linux/videodev2.h                |    6 +
> >  15 files changed, 4190 insertions(+), 6 deletions(-)
> >  create mode 100644 drivers/staging/media/rkvdec/rkvdec-vp9.c
> > 
> 

Re: [RFC RESEND 0/3] vp9 v4l2 stateless uapi

[Ezequiel Garcia]

On Mon, 26 Apr 2021 at 14:38, Nicolas Dufresne <nicolas@ndufresne.ca> wrote:
>
> Le lundi 26 avril 2021 à 09:38 +0200, Hans Verkuil a écrit :
> > Hi Andrzej,
> >
> > Thank you for working on this!
> >
> > On 21/04/2021 12:00, Andrzej Pietrasiewicz wrote:
> > > Dear All,
> > >
> > > This is an RFC on stateless uapi for vp9 decoding with v4l2. This work is based on https://lkml.org/lkml/2020/11/2/1043, but has been substantially reworked. The important change is that the v4l2 control used to pass boolean decoder probabilities has been made unidirectional, and is now called V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS.
> > >
> > > In the previous proposal, to queue a frame the userspace must fully dequeue the previous one, which effectively results in a forced lockstep behavior and defeats vb2's capability to enqueue multiple buffers. Such a design was a consequence of backward probability updates being performed by the kernel driver (which has direct access to appropriate counter values) but forward probability updates being coupled with compressed header parsing performed by the userspace.
> > >
> > > In vp9 the boolean decoder used to decode the bitstream needs certain parameters to work. Those are probabilities, which change with each frame. After each frame is decoded it is known how many times a given symbol occured in the frame, so the probabilities can be adapted. This process is known as backward probabilities update. A next frame header can also contain information which modifies probabilities resulting from backward update. The said modification is called forward probabilities update. The data for backward update is generated by the decoder hardware, while the data for forward update is prepared by reading the compressed frame header. The natural place to parse something is userspace, while the natural place to access hardware-provided counters is the kernel. Such responsibilties assignment was used in the original work.
> > >
> > > To overcome the lockstep, we moved forward probability updates to the kernel, while leaving parsing them in userspace. This way the v4l2 control which is used to pass the probs becomes unidirectional (user->kernel) and the userspace can keep parsing and enqueueing succeeding frames.
> > >
> > > If a particular driver parses the compressed header and does backward probability updates on its own then V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS does not need to be used.
> > >
> > > This series adds vp9 uapi in proper locations, which means it is a proper, "official" uapi, as opposed to staging uapi which was proposed in the above mentioned lkml thread.
> >
> > Why? I rather liked the way that the other codec APIs started life in a private header
> > (like include/media/vp8-ctrls.h) and were given time to mature before moving them to
> > the uAPI. Is there a reason why you think that VP9 doesn't need that?
>
> I'll be honest, I accepted early code into GStreamer for H264, and it ended up
> in a nightmare for the users. We now have a released GStreamer that supports
> kernel API up to 5.9, a blackwhole at 5.10 and finally master catched up and can
> support 5.11+. It is so complicated for packagers to understand what is going
> on, that they endup wasting a lot of their time for a single feature in their
> OS. Same breakage is happening for VP8 in 5.13, even though VP8 has been working
> great all this time. I will for sure for now on ignore any contribution that
> depends on staged uAPI.
>
> As for FFMPEG, even though now H264 API is table, the maintainers just simply
> ignore the patches as they have been bitten by the reviewing stuff based on
> unstable APIs and downstream work.
>
> I believe the staged uAPI has been used wrongly in the past. Stuff has been
> staged quicky right before associated project budget for it was exhausted, so it
> was in the end a way to look good, and someone else had to pick it up and finish
> it. Going straight for final API put more pressure on making good research from
> the start, doing more in-depth reviews and avoiding delaying for multiple years
> the support. I believe the staging API are confusing even for the Linux
> projects. Going straight to stable here is a commitment to finish this work and
> doing it correctly.
>
> This specially make sense for VP9, which is a very Open CODEC and were all HW
> implementation are Google/Hantro derivatives. Also, unlike when this work all
> started, we do have multiple HW we can look at to validate the API, with more
> then enough in-depth information to make the right decisions.
>

+1

Although I can understand how, from the kernel point of view, it's
tempting to merge
the uAPI as staging first and then de-stage it, I have to say that I
agree fully with
Nicolas, the experience wasn't really good for the userspace.

I really hope we can do better than this for at least VP9. So, let's make sure
the hardware decoders that are currently available (Rockchip,
Verisilicon, Mediatek)
are covered, as well as any future features (dynamic frame resize).

A well-thought, honest effort for a sane uAPI is IMO the right way,
and if we find out
something is missing (which may happen, as we are all humans), we can still
introduce another API control (V4L2_CID_STATELESS_VP9_V2) and use it
to supersede the current API. If I understand correctly, this should work,
and allow backward compatibility without issues.

Thanks,
Ezequiel

Re: [RFC RESEND 0/3] vp9 v4l2 stateless uapi

[Hans Verkuil]

On 27/04/2021 01:34, Ezequiel Garcia wrote:
> On Mon, 26 Apr 2021 at 14:38, Nicolas Dufresne <nicolas@ndufresne.ca> wrote:
>>
>> Le lundi 26 avril 2021 à 09:38 +0200, Hans Verkuil a écrit :
>>> Hi Andrzej,
>>>
>>> Thank you for working on this!
>>>
>>> On 21/04/2021 12:00, Andrzej Pietrasiewicz wrote:
>>>> Dear All,
>>>>
>>>> This is an RFC on stateless uapi for vp9 decoding with v4l2. This work is based on https://lkml.org/lkml/2020/11/2/1043, but has been substantially reworked. The important change is that the v4l2 control used to pass boolean decoder probabilities has been made unidirectional, and is now called V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS.
>>>>
>>>> In the previous proposal, to queue a frame the userspace must fully dequeue the previous one, which effectively results in a forced lockstep behavior and defeats vb2's capability to enqueue multiple buffers. Such a design was a consequence of backward probability updates being performed by the kernel driver (which has direct access to appropriate counter values) but forward probability updates being coupled with compressed header parsing performed by the userspace.
>>>>
>>>> In vp9 the boolean decoder used to decode the bitstream needs certain parameters to work. Those are probabilities, which change with each frame. After each frame is decoded it is known how many times a given symbol occured in the frame, so the probabilities can be adapted. This process is known as backward probabilities update. A next frame header can also contain information which modifies probabilities resulting from backward update. The said modification is called forward probabilities update. The data for backward update is generated by the decoder hardware, while the data for forward update is prepared by reading the compressed frame header. The natural place to parse something is userspace, while the natural place to access hardware-provided counters is the kernel. Such responsibilties assignment was used in the original work.
>>>>
>>>> To overcome the lockstep, we moved forward probability updates to the kernel, while leaving parsing them in userspace. This way the v4l2 control which is used to pass the probs becomes unidirectional (user->kernel) and the userspace can keep parsing and enqueueing succeeding frames.
>>>>
>>>> If a particular driver parses the compressed header and does backward probability updates on its own then V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS does not need to be used.
>>>>
>>>> This series adds vp9 uapi in proper locations, which means it is a proper, "official" uapi, as opposed to staging uapi which was proposed in the above mentioned lkml thread.
>>>
>>> Why? I rather liked the way that the other codec APIs started life in a private header
>>> (like include/media/vp8-ctrls.h) and were given time to mature before moving them to
>>> the uAPI. Is there a reason why you think that VP9 doesn't need that?
>>
>> I'll be honest, I accepted early code into GStreamer for H264, and it ended up
>> in a nightmare for the users. We now have a released GStreamer that supports
>> kernel API up to 5.9, a blackwhole at 5.10 and finally master catched up and can
>> support 5.11+. It is so complicated for packagers to understand what is going
>> on, that they endup wasting a lot of their time for a single feature in their
>> OS. Same breakage is happening for VP8 in 5.13, even though VP8 has been working
>> great all this time. I will for sure for now on ignore any contribution that
>> depends on staged uAPI.
>>
>> As for FFMPEG, even though now H264 API is table, the maintainers just simply
>> ignore the patches as they have been bitten by the reviewing stuff based on
>> unstable APIs and downstream work.
>>
>> I believe the staged uAPI has been used wrongly in the past. Stuff has been
>> staged quicky right before associated project budget for it was exhausted, so it
>> was in the end a way to look good, and someone else had to pick it up and finish
>> it. Going straight for final API put more pressure on making good research from
>> the start, doing more in-depth reviews and avoiding delaying for multiple years
>> the support. I believe the staging API are confusing even for the Linux
>> projects. Going straight to stable here is a commitment to finish this work and
>> doing it correctly.
>>
>> This specially make sense for VP9, which is a very Open CODEC and were all HW
>> implementation are Google/Hantro derivatives. Also, unlike when this work all
>> started, we do have multiple HW we can look at to validate the API, with more
>> then enough in-depth information to make the right decisions.
>>
> 
> +1
> 
> Although I can understand how, from the kernel point of view, it's
> tempting to merge
> the uAPI as staging first and then de-stage it, I have to say that I
> agree fully with
> Nicolas, the experience wasn't really good for the userspace.

It was a completely new API and it took quite a long time to really understand
what was needed and how to get it right. Not to mention implement it for
different platforms. Both H264 and MPEG-2 saw major changes. VP8 was the exception,
so it might well be that VP9 is equally good at the first attempt.

> 
> I really hope we can do better than this for at least VP9. So, let's make sure
> the hardware decoders that are currently available (Rockchip,
> Verisilicon, Mediatek)
> are covered, as well as any future features (dynamic frame resize).

Sure, if we can have this supported on several platforms and it is well reviewed,
then I am not opposed to merging it as a public API without going through
staging. We have build up a lot of experience by now.

> 
> A well-thought, honest effort for a sane uAPI is IMO the right way,
> and if we find out
> something is missing (which may happen, as we are all humans), we can still
> introduce another API control (V4L2_CID_STATELESS_VP9_V2) and use it
> to supersede the current API. If I understand correctly, this should work,
> and allow backward compatibility without issues.

Yes, but it is something we'd like to avoid. You need to have sufficient
confidence that the uAPI has been well tested and is in good shape. If you
have that, then great, we can merge it without going through staging.

In particular, if 1) we support at least two HW platforms, and 2) testing
with test suites (I assume those are available for VP9) passed on those
platforms, then I'd be happy to merge.

Regarding the 'userspace mess': why did support for staging APIs end up
in released gstreamer/ffmpeg implementations at all? What did you expect
would happen? Released versions of those applications should only support
public APIs, not staging APIs. Unless perhaps if you explicitly enable it
with some test config option that is by default off. And once a codec API
becomes public, rip out the old code.

I don't use gstreamer/ffmpeg myself, so I hadn't noticed. I thought people
were testing using test branches of those apps. It's staging for a reason,
you are completely on your own if you use it.

I wonder if I should make a patch that issues some really serious messages
in the kernel log if someone attempts to use these staging APIs.

Of course, ideally you would have a perfect API from the beginning, but that
wasn't an option here, and keeping everything out of the kernel entirely until
we're happy with the uAPI would be almost impossible to maintain.

Regards,

	Hans

Re: [RFC RESEND 0/3] vp9 v4l2 stateless uapi

[Nicolas Dufresne]

Le jeudi 29 avril 2021 à 11:23 +0200, Hans Verkuil a écrit :
> On 27/04/2021 01:34, Ezequiel Garcia wrote:
> > On Mon, 26 Apr 2021 at 14:38, Nicolas Dufresne <nicolas@ndufresne.ca> wrote:
> > > 
> > > Le lundi 26 avril 2021 à 09:38 +0200, Hans Verkuil a écrit :
> > > > Hi Andrzej,
> > > > 
> > > > Thank you for working on this!
> > > > 
> > > > On 21/04/2021 12:00, Andrzej Pietrasiewicz wrote:
> > > > > Dear All,
> > > > > 
> > > > > This is an RFC on stateless uapi for vp9 decoding with v4l2. This work is based on https://lkml.org/lkml/2020/11/2/1043, but has been substantially reworked. The important change is that the v4l2 control used to pass boolean decoder probabilities has been made unidirectional, and is now called V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS.
> > > > > 
> > > > > In the previous proposal, to queue a frame the userspace must fully dequeue the previous one, which effectively results in a forced lockstep behavior and defeats vb2's capability to enqueue multiple buffers. Such a design was a consequence of backward probability updates being performed by the kernel driver (which has direct access to appropriate counter values) but forward probability updates being coupled with compressed header parsing performed by the userspace.
> > > > > 
> > > > > In vp9 the boolean decoder used to decode the bitstream needs certain parameters to work. Those are probabilities, which change with each frame. After each frame is decoded it is known how many times a given symbol occured in the frame, so the probabilities can be adapted. This process is known as backward probabilities update. A next frame header can also contain information which modifies probabilities resulting from backward update. The said modification is called forward probabilities update. The data for backward update is generated by the decoder hardware, while the data for forward update is prepared by reading the compressed frame header. The natural place to parse something is userspace, while the natural place to access hardware-provided counters is the kernel. Such responsibilties assignment was used in the original work.
> > > > > 
> > > > > To overcome the lockstep, we moved forward probability updates to the kernel, while leaving parsing them in userspace. This way the v4l2 control which is used to pass the probs becomes unidirectional (user->kernel) and the userspace can keep parsing and enqueueing succeeding frames.
> > > > > 
> > > > > If a particular driver parses the compressed header and does backward probability updates on its own then V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS does not need to be used.
> > > > > 
> > > > > This series adds vp9 uapi in proper locations, which means it is a proper, "official" uapi, as opposed to staging uapi which was proposed in the above mentioned lkml thread.
> > > > 
> > > > Why? I rather liked the way that the other codec APIs started life in a private header
> > > > (like include/media/vp8-ctrls.h) and were given time to mature before moving them to
> > > > the uAPI. Is there a reason why you think that VP9 doesn't need that?
> > > 
> > > I'll be honest, I accepted early code into GStreamer for H264, and it ended up
> > > in a nightmare for the users. We now have a released GStreamer that supports
> > > kernel API up to 5.9, a blackwhole at 5.10 and finally master catched up and can
> > > support 5.11+. It is so complicated for packagers to understand what is going
> > > on, that they endup wasting a lot of their time for a single feature in their
> > > OS. Same breakage is happening for VP8 in 5.13, even though VP8 has been working
> > > great all this time. I will for sure for now on ignore any contribution that
> > > depends on staged uAPI.
> > > 
> > > As for FFMPEG, even though now H264 API is table, the maintainers just simply
> > > ignore the patches as they have been bitten by the reviewing stuff based on
> > > unstable APIs and downstream work.
> > > 
> > > I believe the staged uAPI has been used wrongly in the past. Stuff has been
> > > staged quicky right before associated project budget for it was exhausted, so it
> > > was in the end a way to look good, and someone else had to pick it up and finish
> > > it. Going straight for final API put more pressure on making good research from
> > > the start, doing more in-depth reviews and avoiding delaying for multiple years
> > > the support. I believe the staging API are confusing even for the Linux
> > > projects. Going straight to stable here is a commitment to finish this work and
> > > doing it correctly.
> > > 
> > > This specially make sense for VP9, which is a very Open CODEC and were all HW
> > > implementation are Google/Hantro derivatives. Also, unlike when this work all
> > > started, we do have multiple HW we can look at to validate the API, with more
> > > then enough in-depth information to make the right decisions.
> > > 
> > 
> > +1
> > 
> > Although I can understand how, from the kernel point of view, it's
> > tempting to merge
> > the uAPI as staging first and then de-stage it, I have to say that I
> > agree fully with
> > Nicolas, the experience wasn't really good for the userspace.
> 
> It was a completely new API and it took quite a long time to really understand
> what was needed and how to get it right. Not to mention implement it for
> different platforms. Both H264 and MPEG-2 saw major changes. VP8 was the exception,
> so it might well be that VP9 is equally good at the first attempt.
> 
> > 
> > I really hope we can do better than this for at least VP9. So, let's make sure
> > the hardware decoders that are currently available (Rockchip,
> > Verisilicon, Mediatek)
> > are covered, as well as any future features (dynamic frame resize).
> 
> Sure, if we can have this supported on several platforms and it is well reviewed,
> then I am not opposed to merging it as a public API without going through
> staging. We have build up a lot of experience by now.
> 
> > 
> > A well-thought, honest effort for a sane uAPI is IMO the right way,
> > and if we find out
> > something is missing (which may happen, as we are all humans), we can still
> > introduce another API control (V4L2_CID_STATELESS_VP9_V2) and use it
> > to supersede the current API. If I understand correctly, this should work,
> > and allow backward compatibility without issues.
> 
> Yes, but it is something we'd like to avoid. You need to have sufficient
> confidence that the uAPI has been well tested and is in good shape. If you
> have that, then great, we can merge it without going through staging.
> 
> In particular, if 1) we support at least two HW platforms, and 2) testing
> with test suites (I assume those are available for VP9) passed on those
> platforms, then I'd be happy to merge.
> 
> Regarding the 'userspace mess': why did support for staging APIs end up
> in released gstreamer/ffmpeg implementations at all? What did you expect
> would happen? Released versions of those applications should only support
> public APIs, not staging APIs. Unless perhaps if you explicitly enable it
> with some test config option that is by default off. And once a codec API
> becomes public, rip out the old code.
> 
> I don't use gstreamer/ffmpeg myself, so I hadn't noticed. I thought people
> were testing using test branches of those apps. It's staging for a reason,
> you are completely on your own if you use it.

It's the exact same reason Kernel folks stage stuff and releases kernel with
staged driver (and now APIs). There is no more to add, if you do it in the
kernel, and can't handle having side kernel branches due to complexity when
comes to exchange, collaborate and test, it's identical for GStreamer.

The support was landed in GStreamer own staging area, called gst-plugins-bad
(from the movie the bad the good and the ugly). But GStreamer release cycle is
way slower then kernel release cycle, and that's what created a lot of headache
to the integrators, which in fact have no other choice then using this staging
stuff.

p.s. nothing of that is merged in ffmpeg, upstream ffmpeg in fact seems to be
ignoring the patches (even the latest one based on stable API).

> 
> I wonder if I should make a patch that issues some really serious messages
> in the kernel log if someone attempts to use these staging APIs.

We could of course, I think users (the developers/integrator) are well aware,
but they have no other choices but to deal with it. What I think I would rather
prefer would be to version the specific staging API, so we can explicitly assert
that we have a matching kernel in staging enabled builds of userspace
application. (In our meaculpa, we added kernel version check now, that was our
mistake, but as kernel stuff get backported all the time, this check can be
quite in the way).

Consider that H264 breakage in 3 consecutive Linux kernel was the most agressive
usage of stating uAPI we have come across so far. 3 Linux kernel is a relatively
short delay, so one may wonder if we should not have just skipped some middle
breakage and aimed at public API sooner.

I think the other thing that bugs me, is that when the staging is final, even if
you made no changes, moving from staging to public cause an API break. If that
break could be removed, it would also be easier. In GStreamer as an example, we
have some staging libs in -bad, but the day we move the libs to -base (our
stable), there will be nothing else needed but to rebuild to fix the linking
(and there is not linking with the linux kernel). Or perhaps that how the
transition should have gone and we just didn't do that properly ?

> 
> Of course, ideally you would have a perfect API from the beginning, but that
> wasn't an option here, and keeping everything out of the kernel entirely until
> we're happy with the uAPI would be almost impossible to maintain.

I understand, arguably I'm simply looking for avoiding what may or may not be an
abuse of the staging area. Which is to use it as a shortcut into being
"mainline" and bragging in the social media with hope someone will pay to finish
the work. While the staging should be used when multiple unrelated individual
and companies need to collaborate into a specific component, with a engagement
to do so (can be weak engagement, but there must be something).

Let's at least start VP9 as final, we have more experience, more HW to look at,
and to help even further, most of the HW is derived from Hantro (Google) design,
as that design was given for free to interested HW vendors.

> 
> Regards,
> 
> 	Hans

Re: [RFC RESEND 0/3] vp9 v4l2 stateless uapi

[Hans Verkuil]

Hi Nicolas,

On 29/04/2021 21:38, Nicolas Dufresne wrote:
> Le jeudi 29 avril 2021 à 11:23 +0200, Hans Verkuil a écrit :
>> On 27/04/2021 01:34, Ezequiel Garcia wrote:
>>> On Mon, 26 Apr 2021 at 14:38, Nicolas Dufresne <nicolas@ndufresne.ca> wrote:
>>>>
>>>> Le lundi 26 avril 2021 à 09:38 +0200, Hans Verkuil a écrit :
>>>>> Hi Andrzej,
>>>>>
>>>>> Thank you for working on this!
>>>>>
>>>>> On 21/04/2021 12:00, Andrzej Pietrasiewicz wrote:
>>>>>> Dear All,
>>>>>>
>>>>>> This is an RFC on stateless uapi for vp9 decoding with v4l2. This work is based on https://lkml.org/lkml/2020/11/2/1043, but has been substantially reworked. The important change is that the v4l2 control used to pass boolean decoder probabilities has been made unidirectional, and is now called V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS.
>>>>>>
>>>>>> In the previous proposal, to queue a frame the userspace must fully dequeue the previous one, which effectively results in a forced lockstep behavior and defeats vb2's capability to enqueue multiple buffers. Such a design was a consequence of backward probability updates being performed by the kernel driver (which has direct access to appropriate counter values) but forward probability updates being coupled with compressed header parsing performed by the userspace.
>>>>>>
>>>>>> In vp9 the boolean decoder used to decode the bitstream needs certain parameters to work. Those are probabilities, which change with each frame. After each frame is decoded it is known how many times a given symbol occured in the frame, so the probabilities can be adapted. This process is known as backward probabilities update. A next frame header can also contain information which modifies probabilities resulting from backward update. The said modification is called forward probabilities update. The data for backward update is generated by the decoder hardware, while the data for forward update is prepared by reading the compressed frame header. The natural place to parse something is userspace, while the natural place to access hardware-provided counters is the kernel. Such responsibilties assignment was used in the original work.
>>>>>>
>>>>>> To overcome the lockstep, we moved forward probability updates to the kernel, while leaving parsing them in userspace. This way the v4l2 control which is used to pass the probs becomes unidirectional (user->kernel) and the userspace can keep parsing and enqueueing succeeding frames.
>>>>>>
>>>>>> If a particular driver parses the compressed header and does backward probability updates on its own then V4L2_CID_STATELESS_VP9_COMPRESSED_HDR_PROBS does not need to be used.
>>>>>>
>>>>>> This series adds vp9 uapi in proper locations, which means it is a proper, "official" uapi, as opposed to staging uapi which was proposed in the above mentioned lkml thread.
>>>>>
>>>>> Why? I rather liked the way that the other codec APIs started life in a private header
>>>>> (like include/media/vp8-ctrls.h) and were given time to mature before moving them to
>>>>> the uAPI. Is there a reason why you think that VP9 doesn't need that?
>>>>
>>>> I'll be honest, I accepted early code into GStreamer for H264, and it ended up
>>>> in a nightmare for the users. We now have a released GStreamer that supports
>>>> kernel API up to 5.9, a blackwhole at 5.10 and finally master catched up and can
>>>> support 5.11+. It is so complicated for packagers to understand what is going
>>>> on, that they endup wasting a lot of their time for a single feature in their
>>>> OS. Same breakage is happening for VP8 in 5.13, even though VP8 has been working
>>>> great all this time. I will for sure for now on ignore any contribution that
>>>> depends on staged uAPI.
>>>>
>>>> As for FFMPEG, even though now H264 API is table, the maintainers just simply
>>>> ignore the patches as they have been bitten by the reviewing stuff based on
>>>> unstable APIs and downstream work.
>>>>
>>>> I believe the staged uAPI has been used wrongly in the past. Stuff has been
>>>> staged quicky right before associated project budget for it was exhausted, so it
>>>> was in the end a way to look good, and someone else had to pick it up and finish
>>>> it. Going straight for final API put more pressure on making good research from
>>>> the start, doing more in-depth reviews and avoiding delaying for multiple years
>>>> the support. I believe the staging API are confusing even for the Linux
>>>> projects. Going straight to stable here is a commitment to finish this work and
>>>> doing it correctly.
>>>>
>>>> This specially make sense for VP9, which is a very Open CODEC and were all HW
>>>> implementation are Google/Hantro derivatives. Also, unlike when this work all
>>>> started, we do have multiple HW we can look at to validate the API, with more
>>>> then enough in-depth information to make the right decisions.
>>>>
>>>
>>> +1
>>>
>>> Although I can understand how, from the kernel point of view, it's
>>> tempting to merge
>>> the uAPI as staging first and then de-stage it, I have to say that I
>>> agree fully with
>>> Nicolas, the experience wasn't really good for the userspace.
>>
>> It was a completely new API and it took quite a long time to really understand
>> what was needed and how to get it right. Not to mention implement it for
>> different platforms. Both H264 and MPEG-2 saw major changes. VP8 was the exception,
>> so it might well be that VP9 is equally good at the first attempt.
>>
>>>
>>> I really hope we can do better than this for at least VP9. So, let's make sure
>>> the hardware decoders that are currently available (Rockchip,
>>> Verisilicon, Mediatek)
>>> are covered, as well as any future features (dynamic frame resize).
>>
>> Sure, if we can have this supported on several platforms and it is well reviewed,
>> then I am not opposed to merging it as a public API without going through
>> staging. We have build up a lot of experience by now.
>>
>>>
>>> A well-thought, honest effort for a sane uAPI is IMO the right way,
>>> and if we find out
>>> something is missing (which may happen, as we are all humans), we can still
>>> introduce another API control (V4L2_CID_STATELESS_VP9_V2) and use it
>>> to supersede the current API. If I understand correctly, this should work,
>>> and allow backward compatibility without issues.
>>
>> Yes, but it is something we'd like to avoid. You need to have sufficient
>> confidence that the uAPI has been well tested and is in good shape. If you
>> have that, then great, we can merge it without going through staging.
>>
>> In particular, if 1) we support at least two HW platforms, and 2) testing
>> with test suites (I assume those are available for VP9) passed on those
>> platforms, then I'd be happy to merge.
>>
>> Regarding the 'userspace mess': why did support for staging APIs end up
>> in released gstreamer/ffmpeg implementations at all? What did you expect
>> would happen? Released versions of those applications should only support
>> public APIs, not staging APIs. Unless perhaps if you explicitly enable it
>> with some test config option that is by default off. And once a codec API
>> becomes public, rip out the old code.
>>
>> I don't use gstreamer/ffmpeg myself, so I hadn't noticed. I thought people
>> were testing using test branches of those apps. It's staging for a reason,
>> you are completely on your own if you use it.
> 
> It's the exact same reason Kernel folks stage stuff and releases kernel with
> staged driver (and now APIs). There is no more to add, if you do it in the
> kernel, and can't handle having side kernel branches due to complexity when
> comes to exchange, collaborate and test, it's identical for GStreamer.
> 
> The support was landed in GStreamer own staging area, called gst-plugins-bad
> (from the movie the bad the good and the ugly). But GStreamer release cycle is
> way slower then kernel release cycle, and that's what created a lot of headache
> to the integrators, which in fact have no other choice then using this staging
> stuff.7

Ah, OK, I wasn't aware of that. If as an integrator you choose to take gstreamer
'bad' code AND bad kernel staging code, then you also accept the additional work.

I would strongly recommend dropping the gstreamer code for the old staging codec
APIs as soon as possible.

> 
> p.s. nothing of that is merged in ffmpeg, upstream ffmpeg in fact seems to be
> ignoring the patches (even the latest one based on stable API).

I would refrain from attempting to merge ffmpeg patches based on staging APIs.
You are in control of gstreamer, so you know what it happening. With ffmpeg that's
not the case, so let's not confuse them with staging APIs.

> 
>>
>> I wonder if I should make a patch that issues some really serious messages
>> in the kernel log if someone attempts to use these staging APIs.
> 
> We could of course, I think users (the developers/integrator) are well aware,
> but they have no other choices but to deal with it. What I think I would rather
> prefer would be to version the specific staging API, so we can explicitly assert
> that we have a matching kernel in staging enabled builds of userspace
> application. (In our meaculpa, we added kernel version check now, that was our
> mistake, but as kernel stuff get backported all the time, this check can be
> quite in the way).
> 
> Consider that H264 breakage in 3 consecutive Linux kernel was the most agressive
> usage of stating uAPI we have come across so far. 3 Linux kernel is a relatively
> short delay, so one may wonder if we should not have just skipped some middle
> breakage and aimed at public API sooner.

This API was very atypical. Most staging APIs (such as the Request API) see very
little or any changes in my experience. But the stateless codec APIs required
a steep learning curve from all involved in this and our understanding of the
requirements kept changing as we learned more. It's the first time in the 18
years or so that I've been involved in the media subsystem that this happened.

> I think the other thing that bugs me, is that when the staging is final, even if
> you made no changes, moving from staging to public cause an API break. If that
> break could be removed, it would also be easier. In GStreamer as an example, we
> have some staging libs in -bad, but the day we move the libs to -base (our
> stable), there will be nothing else needed but to rebuild to fix the linking
> (and there is not linking with the linux kernel). Or perhaps that how the
> transition should have gone and we just didn't do that properly ?

Both H264 and the upcoming MPEG2 move to mainline saw substantial API changes.
Only VP8 (and FWHT for what little that's worth) had no actual changes. And
we know HEVC will have substantial changes as well before it is ready to be
merged (e.g. dynamic array control support).

This API break (renumbering the control IDs etc) was done intentionally: the
staging API was really just that IMHO: alpha quality, unsuitable for production
code, and still evolving. Forcing these changes ensured a clean break with the
staging API and any code that uses the new uAPI doesn't have to care about older
versions floating around, there is no confusion possible.

Again, very atypical, not something that you would normally want to do.

> 
>>
>> Of course, ideally you would have a perfect API from the beginning, but that
>> wasn't an option here, and keeping everything out of the kernel entirely until
>> we're happy with the uAPI would be almost impossible to maintain.
> 
> I understand, arguably I'm simply looking for avoiding what may or may not be an
> abuse of the staging area. Which is to use it as a shortcut into being
> "mainline" and bragging in the social media with hope someone will pay to finish
> the work. While the staging should be used when multiple unrelated individual
> and companies need to collaborate into a specific component, with a engagement
> to do so (can be weak engagement, but there must be something).

It's kind of out of my scope as maintainer since my responsibility is to ensure
good (or at least as good as we can manage) APIs and this seemed the best (or
least bad) way to go: it's at least in the kernel tree so maintenance and
collaboration was easier, but not part of the public API so changes (which we
knew from the start would be substantial) remained possible.

If we kept this out of the kernel entirely, I'm convinced that this would have
fizzled out since it would have been much harder to maintain and collaborate.

Not to mention that you would get huge patch series since it would have to
include everything that was out-of-tree.

So I still think this was the best approach, warts and all.

Regarding the 'bragging' on social media: well, it worked, didn't it? It kickstarted
all this work. Perhaps less through actual funding (I can't tell, I'm not involved
in that of course) and more through people spending their spare time on this, the
end result is that we now have solid APIs for these HW codecs.

One other thing that I wanted to mention: the collaboration between so many
different developers and companies has been amazing. These are complex pieces
of hardware, so to see it all come together has been one of the highlights in
my career as kernel developer/maintainer.

Thank you all for contributing!

> Let's at least start VP9 as final, we have more experience, more HW to look at,
> and to help even further, most of the HW is derived from Hantro (Google) design,
> as that design was given for free to interested HW vendors.

I agree with this. I'm happy to merge this directly as a uAPI provided it is
implemented in at least two drivers. We have sufficient experience now to avoid
the staging step.

Regards,

	Hans