linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] edid-decode: Avoid division by zero
@ 2019-09-30 17:13 Breno Leitao
  2019-09-30 17:26 ` Hans Verkuil
  0 siblings, 1 reply; 10+ messages in thread
From: Breno Leitao @ 2019-09-30 17:13 UTC (permalink / raw)
  To: linux-media, hverkuil-cisco

There are some weird monitors that returns invalid data, as zeroed
Horizontal/Vertical Active/Blanking.

This causes edid-decode to crash with a divsion by error exception. This
simple patch avoids so, checking for the divisor before proceeding.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 edid-decode.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/edid-decode.c b/edid-decode.c
index 7442f8a..4b2cef8 100644
--- a/edid-decode.c
+++ b/edid-decode.c
@@ -1022,6 +1022,17 @@ static int detailed_block(const unsigned char *x,
int in_extension)
 		break;
 	}

+	if ((ha + hbl) == 0 ||
+	    (va + vbl) == 0) {
+		printf("Invalid data. Refusing to continue.\n"
+		       "Horizontal Active %4d\n"
+		       "Horizontal Blanking %4d\n"
+		       "Vertical Active %4d\n"
+		       "Vertical Blanking %4d\n",
+		       ha, hbl, va, vbl);
+		return 0;
+	}
+
 	pixclk_khz = (x[0] + (x[1] << 8)) * 10;
 	refresh = (pixclk_khz * 1000) / ((ha + hbl) * (va + vbl));
 	printf("Detailed mode: Clock %.3f MHz, %d mm x %d mm\n"
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH] edid-decode: Avoid division by zero
  2019-09-30 17:13 [PATCH] edid-decode: Avoid division by zero Breno Leitao
@ 2019-09-30 17:26 ` Hans Verkuil
  2019-10-01  8:10   ` [PATCH v2] " Breno Leitao
  0 siblings, 1 reply; 10+ messages in thread
From: Hans Verkuil @ 2019-09-30 17:26 UTC (permalink / raw)
  To: Breno Leitao, linux-media

On 9/30/19 7:13 PM, Breno Leitao wrote:
> There are some weird monitors that returns invalid data, as zeroed
> Horizontal/Vertical Active/Blanking.
> 
> This causes edid-decode to crash with a divsion by error exception. This
> simple patch avoids so, checking for the divisor before proceeding.
> 
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
>  edid-decode.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/edid-decode.c b/edid-decode.c
> index 7442f8a..4b2cef8 100644
> --- a/edid-decode.c
> +++ b/edid-decode.c
> @@ -1022,6 +1022,17 @@ static int detailed_block(const unsigned char *x,
> int in_extension)

This should have been on one line, it looks like your mailer is wrapping lines.

>  		break;
>  	}
> 
> +	if ((ha + hbl) == 0 ||
> +	    (va + vbl) == 0) {

I'd use '!ha || !hbl || !va || !vbl' here.



> +		printf("Invalid data. Refusing to continue.\n"

I'd say: "Invalid Detailing Timings:" here.

> +		       "Horizontal Active %4d\n"
> +		       "Horizontal Blanking %4d\n"
> +		       "Vertical Active %4d\n"
> +		       "Vertical Blanking %4d\n",
> +		       ha, hbl, va, vbl);
> +		return 0;
> +	}
> +
>  	pixclk_khz = (x[0] + (x[1] << 8)) * 10;
>  	refresh = (pixclk_khz * 1000) / ((ha + hbl) * (va + vbl));
>  	printf("Detailed mode: Clock %.3f MHz, %d mm x %d mm\n"
> 

I'm happy to take this if you post a v2 with these changes!

Regards,

	Hans

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH v2] edid-decode: Avoid division by zero
  2019-09-30 17:26 ` Hans Verkuil
@ 2019-10-01  8:10   ` Breno Leitao
  2019-10-01  8:39     ` Hans Verkuil
  0 siblings, 1 reply; 10+ messages in thread
From: Breno Leitao @ 2019-10-01  8:10 UTC (permalink / raw)
  To: Hans Verkuil; +Cc: linux-media

There are some weird monitors that returns invalid data, as zeroed
Horizontal/Vertical Active/Blanking.

This causes edid-decode to crash with a division by zero exception. This simple
patch avoids so, checking for the divisor before proceeding.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 edid-decode.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/edid-decode.c b/edid-decode.c
index 7442f8a..b932179 100644
--- a/edid-decode.c
+++ b/edid-decode.c
@@ -1022,6 +1022,16 @@ static int detailed_block(const unsigned char *x, int in_extension)
 		break;
 	}
 
+	if (!ha || !hbl || !va || !vbl) {
+		printf("Invalid Detailing Timings:\n"
+		       "Horizontal Active %4d\n"
+		       "Horizontal Blanking %4d\n"
+		       "Vertical Active %4d\n"
+		       "Vertical Blanking %4d\n",
+		       ha, hbl, va, vbl);
+		return 0;
+	}
+
 	pixclk_khz = (x[0] + (x[1] << 8)) * 10;
 	refresh = (pixclk_khz * 1000) / ((ha + hbl) * (va + vbl));
 	printf("Detailed mode: Clock %.3f MHz, %d mm x %d mm\n"
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH v2] edid-decode: Avoid division by zero
  2019-10-01  8:10   ` [PATCH v2] " Breno Leitao
@ 2019-10-01  8:39     ` Hans Verkuil
  2019-10-01  9:15       ` Breno Leitao
  2019-10-01  9:52       ` [PATCH v3] " Breno Leitao
  0 siblings, 2 replies; 10+ messages in thread
From: Hans Verkuil @ 2019-10-01  8:39 UTC (permalink / raw)
  To: Breno Leitao; +Cc: linux-media

On 10/1/19 10:10 AM, Breno Leitao wrote:
> There are some weird monitors that returns invalid data, as zeroed
> Horizontal/Vertical Active/Blanking.

Do you have an EDID that does this? I'd like to add it to the collection
of EDIDs in edid-decode.

Some more nitpicks below:

> 
> This causes edid-decode to crash with a division by zero exception. This simple
> patch avoids so, checking for the divisor before proceeding.
> 
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
>  edid-decode.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/edid-decode.c b/edid-decode.c
> index 7442f8a..b932179 100644
> --- a/edid-decode.c
> +++ b/edid-decode.c
> @@ -1022,6 +1022,16 @@ static int detailed_block(const unsigned char *x, int in_extension)
>  		break;
>  	}
>  
> +	if (!ha || !hbl || !va || !vbl) {
> +		printf("Invalid Detailing Timings:\n"

Detailing -> Detailed

> +		       "Horizontal Active %4d\n"
> +		       "Horizontal Blanking %4d\n"

This can be a bit more concise:

			"Horizontal Active/Blanking: %d/%d\n"

> +		       "Vertical Active %4d\n"
> +		       "Vertical Blanking %4d\n",

Ditto.

> +		       ha, hbl, va, vbl);
> +		return 0;
> +	}
> +
>  	pixclk_khz = (x[0] + (x[1] << 8)) * 10;
>  	refresh = (pixclk_khz * 1000) / ((ha + hbl) * (va + vbl));
>  	printf("Detailed mode: Clock %.3f MHz, %d mm x %d mm\n"
> 

Regards,

	Hans

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH v2] edid-decode: Avoid division by zero
  2019-10-01  8:39     ` Hans Verkuil
@ 2019-10-01  9:15       ` Breno Leitao
  2019-10-01  9:16         ` Hans Verkuil
  2019-10-01  9:26         ` Hans Verkuil
  2019-10-01  9:52       ` [PATCH v3] " Breno Leitao
  1 sibling, 2 replies; 10+ messages in thread
From: Breno Leitao @ 2019-10-01  9:15 UTC (permalink / raw)
  To: Hans Verkuil; +Cc: linux-media

Hi Hans,

On 01/10/2019 09:39, Hans Verkuil wrote:
> On 10/1/19 10:10 AM, Breno Leitao wrote:
>> There are some weird monitors that returns invalid data, as zeroed
>> Horizontal/Vertical Active/Blanking.
> 
> Do you have an EDID that does this? I'd like to add it to the collection
> of EDIDs in edid-decode.

Yes, This is an example. Is this what you want?

# cat /sys/devices/pci0000:00/0000:00:02.0/drm/card0/card0-HDMI-A-1/edid | hexdump
0000000 ff00 ffff ffff 00ff 8f15 4600 72f0 0000
0000010 171e 0301 6680 7839 602a a19d 4954 269b
0000020 470f 234a 0008 c081 4081 8081 0095 00b3
0000030 c0d1 c08b 0101 3a02 1880 3871 402d 2c58
0000040 0045 3dfa 0032 1e00 2166 aa56 0051 301e
0000050 8f46 0033 3dfa 0032 1e00 0000 fd00 3000
0000060 1f3e 0f50 0a00 2020 2020 2020 0000 fe00
0000070 3100 3242 3343 3050 3430 3035 200a a101
0000080 0302 401b 1647 0431 0119 1803 0923 0707
0000090 0183 0000 0366 000c 0020 0180 001d 2e7c
00000a0 a090 1a60 401e 2030 0036 0ba2 0032 1a00
00000b0 0000 f700 0a00 ca00 60e0 0000 0000 0000
00000c0 0000 0000 fc00 4500 4f4c 4520 3454 3036
00000d0 4c30 2020 0000 0000 0000 0000 0000 0000
00000e0 0000 0000 0000 0000 0000 0000 0000 0000
00000f0 0000 0000 0000 0000 0000 0000 0000 c100
0000100

> 
> Some more nitpicks below:
> 
>>
>> This causes edid-decode to crash with a division by zero exception. This simple
>> patch avoids so, checking for the divisor before proceeding.
>>
>> Signed-off-by: Breno Leitao <leitao@debian.org>
>> ---
>>  edid-decode.c | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/edid-decode.c b/edid-decode.c
>> index 7442f8a..b932179 100644
>> --- a/edid-decode.c
>> +++ b/edid-decode.c
>> @@ -1022,6 +1022,16 @@ static int detailed_block(const unsigned char *x, int in_extension)
>>  		break;
>>  	}
>>  
>> +	if (!ha || !hbl || !va || !vbl) {
>> +		printf("Invalid Detailing Timings:\n"
> 
> Detailing -> Detailed
> 
>> +		       "Horizontal Active %4d\n"
>> +		       "Horizontal Blanking %4d\n"
> 
> This can be a bit more concise:
> 
> 			"Horizontal Active/Blanking: %d/%d\n"
> 
>> +		       "Vertical Active %4d\n"
>> +		       "Vertical Blanking %4d\n",
> 
> Ditto.

Ok, let me change it and send a v3.

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH v2] edid-decode: Avoid division by zero
  2019-10-01  9:15       ` Breno Leitao
@ 2019-10-01  9:16         ` Hans Verkuil
  2019-10-01  9:19           ` Breno Leitao
  2019-10-01  9:26         ` Hans Verkuil
  1 sibling, 1 reply; 10+ messages in thread
From: Hans Verkuil @ 2019-10-01  9:16 UTC (permalink / raw)
  To: Breno Leitao; +Cc: linux-media

On 10/1/19 11:15 AM, Breno Leitao wrote:
> Hi Hans,
> 
> On 01/10/2019 09:39, Hans Verkuil wrote:
>> On 10/1/19 10:10 AM, Breno Leitao wrote:
>>> There are some weird monitors that returns invalid data, as zeroed
>>> Horizontal/Vertical Active/Blanking.
>>
>> Do you have an EDID that does this? I'd like to add it to the collection
>> of EDIDs in edid-decode.
> 
> Yes, This is an example. Is this what you want?
> 
> # cat /sys/devices/pci0000:00/0000:00:02.0/drm/card0/card0-HDMI-A-1/edid | hexdump
> 0000000 ff00 ffff ffff 00ff 8f15 4600 72f0 0000
> 0000010 171e 0301 6680 7839 602a a19d 4954 269b
> 0000020 470f 234a 0008 c081 4081 8081 0095 00b3
> 0000030 c0d1 c08b 0101 3a02 1880 3871 402d 2c58
> 0000040 0045 3dfa 0032 1e00 2166 aa56 0051 301e
> 0000050 8f46 0033 3dfa 0032 1e00 0000 fd00 3000
> 0000060 1f3e 0f50 0a00 2020 2020 2020 0000 fe00
> 0000070 3100 3242 3343 3050 3430 3035 200a a101
> 0000080 0302 401b 1647 0431 0119 1803 0923 0707
> 0000090 0183 0000 0366 000c 0020 0180 001d 2e7c
> 00000a0 a090 1a60 401e 2030 0036 0ba2 0032 1a00
> 00000b0 0000 f700 0a00 ca00 60e0 0000 0000 0000
> 00000c0 0000 0000 fc00 4500 4f4c 4520 3454 3036
> 00000d0 4c30 2020 0000 0000 0000 0000 0000 0000
> 00000e0 0000 0000 0000 0000 0000 0000 0000 0000
> 00000f0 0000 0000 0000 0000 0000 0000 0000 c100
> 0000100

Yes, that's fine. What is the brand/model of the display?

Regards,

	Hans

> 
>>
>> Some more nitpicks below:
>>
>>>
>>> This causes edid-decode to crash with a division by zero exception. This simple
>>> patch avoids so, checking for the divisor before proceeding.
>>>
>>> Signed-off-by: Breno Leitao <leitao@debian.org>
>>> ---
>>>  edid-decode.c | 10 ++++++++++
>>>  1 file changed, 10 insertions(+)
>>>
>>> diff --git a/edid-decode.c b/edid-decode.c
>>> index 7442f8a..b932179 100644
>>> --- a/edid-decode.c
>>> +++ b/edid-decode.c
>>> @@ -1022,6 +1022,16 @@ static int detailed_block(const unsigned char *x, int in_extension)
>>>  		break;
>>>  	}
>>>  
>>> +	if (!ha || !hbl || !va || !vbl) {
>>> +		printf("Invalid Detailing Timings:\n"
>>
>> Detailing -> Detailed
>>
>>> +		       "Horizontal Active %4d\n"
>>> +		       "Horizontal Blanking %4d\n"
>>
>> This can be a bit more concise:
>>
>> 			"Horizontal Active/Blanking: %d/%d\n"
>>
>>> +		       "Vertical Active %4d\n"
>>> +		       "Vertical Blanking %4d\n",
>>
>> Ditto.
> 
> Ok, let me change it and send a v3.
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH v2] edid-decode: Avoid division by zero
  2019-10-01  9:16         ` Hans Verkuil
@ 2019-10-01  9:19           ` Breno Leitao
  0 siblings, 0 replies; 10+ messages in thread
From: Breno Leitao @ 2019-10-01  9:19 UTC (permalink / raw)
  To: Hans Verkuil; +Cc: linux-media

On 01/10/2019 10:16, Hans Verkuil wrote:
> On 10/1/19 11:15 AM, Breno Leitao wrote:
>> Hi Hans,
>>
>> On 01/10/2019 09:39, Hans Verkuil wrote:
>>> On 10/1/19 10:10 AM, Breno Leitao wrote:
>>>> There are some weird monitors that returns invalid data, as zeroed
>>>> Horizontal/Vertical Active/Blanking.
>>>
>>> Do you have an EDID that does this? I'd like to add it to the collection
>>> of EDIDs in edid-decode.
>>
>> Yes, This is an example. Is this what you want?
>>
>> # cat /sys/devices/pci0000:00/0000:00:02.0/drm/card0/card0-HDMI-A-1/edid | hexdump
>> 0000000 ff00 ffff ffff 00ff 8f15 4600 72f0 0000
>> 0000010 171e 0301 6680 7839 602a a19d 4954 269b
>> 0000020 470f 234a 0008 c081 4081 8081 0095 00b3
>> 0000030 c0d1 c08b 0101 3a02 1880 3871 402d 2c58
>> 0000040 0045 3dfa 0032 1e00 2166 aa56 0051 301e
>> 0000050 8f46 0033 3dfa 0032 1e00 0000 fd00 3000
>> 0000060 1f3e 0f50 0a00 2020 2020 2020 0000 fe00
>> 0000070 3100 3242 3343 3050 3430 3035 200a a101
>> 0000080 0302 401b 1647 0431 0119 1803 0923 0707
>> 0000090 0183 0000 0366 000c 0020 0180 001d 2e7c
>> 00000a0 a090 1a60 401e 2030 0036 0ba2 0032 1a00
>> 00000b0 0000 f700 0a00 ca00 60e0 0000 0000 0000
>> 00000c0 0000 0000 fc00 4500 4f4c 4520 3454 3036
>> 00000d0 4c30 2020 0000 0000 0000 0000 0000 0000
>> 00000e0 0000 0000 0000 0000 0000 0000 0000 0000
>> 00000f0 0000 0000 0000 0000 0000 0000 0000 c100
>> 0000100
> 
> Yes, that's fine. What is the brand/model of the display?

This is a touch panel manufactured by Elo, model 4600.

https://www.elotouch.com/4600l-discontinued-aug-2013.html

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH v2] edid-decode: Avoid division by zero
  2019-10-01  9:15       ` Breno Leitao
  2019-10-01  9:16         ` Hans Verkuil
@ 2019-10-01  9:26         ` Hans Verkuil
  2019-10-01  9:51           ` Breno Leitao
  1 sibling, 1 reply; 10+ messages in thread
From: Hans Verkuil @ 2019-10-01  9:26 UTC (permalink / raw)
  To: Breno Leitao; +Cc: linux-media

On 10/1/19 11:15 AM, Breno Leitao wrote:
> Hi Hans,
> 
> On 01/10/2019 09:39, Hans Verkuil wrote:
>> On 10/1/19 10:10 AM, Breno Leitao wrote:
>>> There are some weird monitors that returns invalid data, as zeroed
>>> Horizontal/Vertical Active/Blanking.
>>
>> Do you have an EDID that does this? I'd like to add it to the collection
>> of EDIDs in edid-decode.
> 
> Yes, This is an example. Is this what you want?
> 
> # cat /sys/devices/pci0000:00/0000:00:02.0/drm/card0/card0-HDMI-A-1/edid | hexdump
> 0000000 ff00 ffff ffff 00ff 8f15 4600 72f0 0000
> 0000010 171e 0301 6680 7839 602a a19d 4954 269b
> 0000020 470f 234a 0008 c081 4081 8081 0095 00b3
> 0000030 c0d1 c08b 0101 3a02 1880 3871 402d 2c58
> 0000040 0045 3dfa 0032 1e00 2166 aa56 0051 301e
> 0000050 8f46 0033 3dfa 0032 1e00 0000 fd00 3000
> 0000060 1f3e 0f50 0a00 2020 2020 2020 0000 fe00
> 0000070 3100 3242 3343 3050 3430 3035 200a a101
> 0000080 0302 401b 1647 0431 0119 1803 0923 0707
> 0000090 0183 0000 0366 000c 0020 0180 001d 2e7c
> 00000a0 a090 1a60 401e 2030 0036 0ba2 0032 1a00
> 00000b0 0000 f700 0a00 ca00 60e0 0000 0000 0000
> 00000c0 0000 0000 fc00 4500 4f4c 4520 3454 3036
> 00000d0 4c30 2020 0000 0000 0000 0000 0000 0000
> 00000e0 0000 0000 0000 0000 0000 0000 0000 0000
> 00000f0 0000 0000 0000 0000 0000 0000 0000 c100

Can you just mail me the raw output?

cat /sys/devices/pci0000:00/0000:00:02.0/drm/card0/card0-HDMI-A-1/edid >edid.bin

hexdump messes things up, swapping lsb and msb :-)

Regards,

	Hans


> 0000100
> 
>>
>> Some more nitpicks below:
>>
>>>
>>> This causes edid-decode to crash with a division by zero exception. This simple
>>> patch avoids so, checking for the divisor before proceeding.
>>>
>>> Signed-off-by: Breno Leitao <leitao@debian.org>
>>> ---
>>>  edid-decode.c | 10 ++++++++++
>>>  1 file changed, 10 insertions(+)
>>>
>>> diff --git a/edid-decode.c b/edid-decode.c
>>> index 7442f8a..b932179 100644
>>> --- a/edid-decode.c
>>> +++ b/edid-decode.c
>>> @@ -1022,6 +1022,16 @@ static int detailed_block(const unsigned char *x, int in_extension)
>>>  		break;
>>>  	}
>>>  
>>> +	if (!ha || !hbl || !va || !vbl) {
>>> +		printf("Invalid Detailing Timings:\n"
>>
>> Detailing -> Detailed
>>
>>> +		       "Horizontal Active %4d\n"
>>> +		       "Horizontal Blanking %4d\n"
>>
>> This can be a bit more concise:
>>
>> 			"Horizontal Active/Blanking: %d/%d\n"
>>
>>> +		       "Vertical Active %4d\n"
>>> +		       "Vertical Blanking %4d\n",
>>
>> Ditto.
> 
> Ok, let me change it and send a v3.
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH v2] edid-decode: Avoid division by zero
  2019-10-01  9:26         ` Hans Verkuil
@ 2019-10-01  9:51           ` Breno Leitao
  0 siblings, 0 replies; 10+ messages in thread
From: Breno Leitao @ 2019-10-01  9:51 UTC (permalink / raw)
  To: Hans Verkuil; +Cc: linux-media

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

On 01/10/2019 10:26, Hans Verkuil wrote:
> Can you just mail me the raw output?
> 
> cat /sys/devices/pci0000:00/0000:00:02.0/drm/card0/card0-HDMI-A-1/edid >edid.bin

Sure, here it is.

[-- Attachment #2: edid.bin --]
[-- Type: application/macbinary, Size: 256 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH v3] edid-decode: Avoid division by zero
  2019-10-01  8:39     ` Hans Verkuil
  2019-10-01  9:15       ` Breno Leitao
@ 2019-10-01  9:52       ` Breno Leitao
  1 sibling, 0 replies; 10+ messages in thread
From: Breno Leitao @ 2019-10-01  9:52 UTC (permalink / raw)
  To: Hans Verkuil; +Cc: linux-media

There are some weird monitors that returns invalid data, as zeroed
Horizontal/Vertical Active/Blanking.

This causes edid-decode to crash with a divsion by error exception. This simple
patch avoids so, checking for the divisor before proceeding. On invalid data,
it prints something as:

  ...
  Invalid Detailed Timings:
  Horizontal Active/Blanking 32/0
  Vertical Active/Blanking 0/0
  ...

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 edid-decode.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/edid-decode.c b/edid-decode.c
index 7442f8a..2612e70 100644
--- a/edid-decode.c
+++ b/edid-decode.c
@@ -1022,6 +1022,14 @@ static int detailed_block(const unsigned char *x, int in_extension)
 		break;
 	}
 
+	if (!ha || !hbl || !va || !vbl) {
+		printf("Invalid Detailed Timings:\n"
+		       "Horizontal Active/Blanking %d/%d\n"
+		       "Vertical Active/Blanking %d/%d\n",
+		       ha, hbl, va, vbl);
+		return 0;
+	}
+
 	pixclk_khz = (x[0] + (x[1] << 8)) * 10;
 	refresh = (pixclk_khz * 1000) / ((ha + hbl) * (va + vbl));
 	printf("Detailed mode: Clock %.3f MHz, %d mm x %d mm\n"
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-10-01  9:52 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-30 17:13 [PATCH] edid-decode: Avoid division by zero Breno Leitao
2019-09-30 17:26 ` Hans Verkuil
2019-10-01  8:10   ` [PATCH v2] " Breno Leitao
2019-10-01  8:39     ` Hans Verkuil
2019-10-01  9:15       ` Breno Leitao
2019-10-01  9:16         ` Hans Verkuil
2019-10-01  9:19           ` Breno Leitao
2019-10-01  9:26         ` Hans Verkuil
2019-10-01  9:51           ` Breno Leitao
2019-10-01  9:52       ` [PATCH v3] " Breno Leitao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).