* [PATCH] media: dvb-frontends: DUMMY_FE should depends on DVB_CORE
@ 2020-04-17 7:22 Mauro Carvalho Chehab
0 siblings, 0 replies; only message in thread
From: Mauro Carvalho Chehab @ 2020-04-17 7:22 UTC (permalink / raw)
To: Linux Media Mailing List
Cc: Mauro Carvalho Chehab, Hans Verkuil, Stefan Agner,
Ezequiel Garcia, Bartlomiej Zolnierkiewicz, Randy Dunlap
Using select for DVB_CORE doesn't work, as reported by
Randy:
CONFIG_I2C=m
CONFIG_DVB_CORE=y
ld: drivers/media/dvb-core/dvbdev.o: in function `dvb_module_probe':
dvbdev.c:(.text+0xf92): undefined reference to `i2c_new_client_device'
ld: dvbdev.c:(.text+0xffb): undefined reference to `i2c_unregister_device'
ld: drivers/media/dvb-core/dvbdev.o: in function `dvb_module_release':
dvbdev.c:(.text+0x107d): undefined reference to `i2c_unregister_device'
The problem is actually caused by the dummy frontend driver,
which uses select, and it is missing an I2C dependency:
WARNING: unmet direct dependencies detected for DVB_CORE
Depends on [m]: MEDIA_SUPPORT [=y] && MEDIA_DIGITAL_TV_SUPPORT [=y] && (I2C [=m] || I2C [=m]=n)
Selected by [y]:
- DVB_DUMMY_FE [=y] && MEDIA_SUPPORT [=y] && MEDIA_TEST_SUPPORT [=y]
As this is the only frontend driver using "select DVB_CORE",
change it do depends on DVB_CORE.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
drivers/media/dvb-frontends/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/dvb-frontends/Kconfig b/drivers/media/dvb-frontends/Kconfig
index fbadba9b328e..643b851a6b60 100644
--- a/drivers/media/dvb-frontends/Kconfig
+++ b/drivers/media/dvb-frontends/Kconfig
@@ -956,7 +956,6 @@ comment "Tools to develop new frontends"
config DVB_DUMMY_FE
tristate "Dummy frontend driver"
- depends on MEDIA_TEST_SUPPORT
- select DVB_CORE
+ depends on MEDIA_TEST_SUPPORT && DVB_CORE
help
Dummy skeleton frontend driver.
--
2.25.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-04-17 7:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-17 7:22 [PATCH] media: dvb-frontends: DUMMY_FE should depends on DVB_CORE Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).