From: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
To: David Laight <David.Laight@ACULAB.COM>,
'Colin King' <colin.king@canonical.com>,
Helen Koike <helen.koike@collabora.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>
Cc: "kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: staging: rkisp1: rsz: make const array static, makes object smaller
Date: Tue, 20 Oct 2020 19:10:07 +0200 [thread overview]
Message-ID: <cec23fd3-15c1-8e52-3f4d-300d6149d89c@collabora.com> (raw)
In-Reply-To: <d5663dec063440129bf6c373aa252d51@AcuMS.aculab.com>
Am 20.10.20 um 17:29 schrieb David Laight:
> From: Colin King
>> Sent: 20 October 2020 15:47
>>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Don't populate the const array dev_names on the stack but instead it
>> static. Makes the object code smaller by 15 bytes.
>>
>> Before:
>> text data bss dec hex filename
>> 17091 2648 64 19803 4d5b media/rkisp1/rkisp1-resizer.o
>>
>> After:
>> text data bss dec hex filename
>> 17012 2712 64 19788 4d4c media/rkisp1/rkisp1-resizer.o
>>
>> (gcc version 10.2.0)
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/staging/media/rkisp1/rkisp1-resizer.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/media/rkisp1/rkisp1-resizer.c b/drivers/staging/media/rkisp1/rkisp1-
>> resizer.c
>> index 1687d82e6c68..7ca5b47c5bf5 100644
>> --- a/drivers/staging/media/rkisp1/rkisp1-resizer.c
>> +++ b/drivers/staging/media/rkisp1/rkisp1-resizer.c
>> @@ -763,8 +763,10 @@ static void rkisp1_rsz_unregister(struct rkisp1_resizer *rsz)
>>
>> static int rkisp1_rsz_register(struct rkisp1_resizer *rsz)
>> {
>> - const char * const dev_names[] = {RKISP1_RSZ_MP_DEV_NAME,
>> - RKISP1_RSZ_SP_DEV_NAME};
>> + static const char * const dev_names[] = {
>> + RKISP1_RSZ_MP_DEV_NAME,
>> + RKISP1_RSZ_SP_DEV_NAME
>> + };
>> struct media_pad *pads = rsz->pads;
>> struct v4l2_subdev *sd = &rsz->sd;
>> int ret;
>
> Don't look at what that code is actually doing....
> It is rather horrid.
> rkisp1_rsz_register() is called for each entry in an array (twice).
> The array index is written into rsz->id.
> The value is then used to select one of the two strings.
> But rsz->id is actually an enum type.
Hi,
Is it that bad to use enum as an array index?
we use it in many places in the driver.
Thanks,
Dafna
>
> rkisp1_rsz_register() should probably just be called twice with some
> extra parameters.
>
> David
>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
>
next prev parent reply other threads:[~2020-10-20 17:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 14:46 [PATCH] media: staging: rkisp1: rsz: make const array static, makes object smaller Colin King
2020-10-20 15:29 ` David Laight
2020-10-20 17:10 ` Dafna Hirschfeld [this message]
2020-10-20 21:53 ` David Laight
2020-10-20 16:23 ` Dafna Hirschfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cec23fd3-15c1-8e52-3f4d-300d6149d89c@collabora.com \
--to=dafna.hirschfeld@collabora.com \
--cc=David.Laight@ACULAB.COM \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=helen.koike@collabora.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).