From: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
To: Colin King <colin.king@canonical.com>,
Helen Koike <helen.koike@collabora.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: staging: rkisp1: rsz: make const array static, makes object smaller
Date: Tue, 20 Oct 2020 18:23:52 +0200 [thread overview]
Message-ID: <07b92ab9-bade-623e-395d-89320d9f88f6@collabora.com> (raw)
In-Reply-To: <20201020144655.53251-1-colin.king@canonical.com>
Hi, thanks,
Am 20.10.20 um 16:46 schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the const array dev_names on the stack but instead it
> static. Makes the object code smaller by 15 bytes.
>
> Before:
> text data bss dec hex filename
> 17091 2648 64 19803 4d5b media/rkisp1/rkisp1-resizer.o
>
> After:
> text data bss dec hex filename
> 17012 2712 64 19788 4d4c media/rkisp1/rkisp1-resizer.o
On the other hand the data segment is 64 bytes bigger.
I don't know what is more important to save.
Anyway, the rkisp1-capture.c does the same with the names
so it is better to be consistent.
Thanks,
Dafna
>
> (gcc version 10.2.0)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/staging/media/rkisp1/rkisp1-resizer.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/rkisp1/rkisp1-resizer.c b/drivers/staging/media/rkisp1/rkisp1-resizer.c
> index 1687d82e6c68..7ca5b47c5bf5 100644
> --- a/drivers/staging/media/rkisp1/rkisp1-resizer.c
> +++ b/drivers/staging/media/rkisp1/rkisp1-resizer.c
> @@ -763,8 +763,10 @@ static void rkisp1_rsz_unregister(struct rkisp1_resizer *rsz)
>
> static int rkisp1_rsz_register(struct rkisp1_resizer *rsz)
> {
> - const char * const dev_names[] = {RKISP1_RSZ_MP_DEV_NAME,
> - RKISP1_RSZ_SP_DEV_NAME};
> + static const char * const dev_names[] = {
> + RKISP1_RSZ_MP_DEV_NAME,
> + RKISP1_RSZ_SP_DEV_NAME
> + };
> struct media_pad *pads = rsz->pads;
> struct v4l2_subdev *sd = &rsz->sd;
> int ret;
>
prev parent reply other threads:[~2020-10-20 16:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 14:46 [PATCH] media: staging: rkisp1: rsz: make const array static, makes object smaller Colin King
2020-10-20 15:29 ` David Laight
2020-10-20 17:10 ` Dafna Hirschfeld
2020-10-20 21:53 ` David Laight
2020-10-20 16:23 ` Dafna Hirschfeld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07b92ab9-bade-623e-395d-89320d9f88f6@collabora.com \
--to=dafna.hirschfeld@collabora.com \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=helen.koike@collabora.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).