* [PATCH] dma-buf: fix kernel-doc warning in dma-fence.c
@ 2020-08-31 4:17 Randy Dunlap
2020-08-31 10:02 ` Christian König
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2020-08-31 4:17 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Sumit Semwal, Gustavo Padovan,
Christian König, linux-media, dri-devel
Add @cookie to dma_fence_end_signalling() to prevent kernel-doc
warning in drivers/dma-buf/dma-fence.c:
../drivers/dma-buf/dma-fence.c:291: warning: Function parameter or member 'cookie' not described in 'dma_fence_end_signalling'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Gustavo Padovan <gustavo@padovan.org>
Cc: Christian König <christian.koenig@amd.com>
Cc: linux-media@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
---
drivers/dma-buf/dma-fence.c | 1 +
1 file changed, 1 insertion(+)
--- lnx-59-rc3.orig/drivers/dma-buf/dma-fence.c
+++ lnx-59-rc3/drivers/dma-buf/dma-fence.c
@@ -283,6 +283,7 @@ EXPORT_SYMBOL(dma_fence_begin_signalling
/**
* dma_fence_end_signalling - end a critical DMA fence signalling section
+ * @cookie: opaque cookie from dma_fence_begin_signalling()
*
* Closes a critical section annotation opened by dma_fence_begin_signalling().
*/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dma-buf: fix kernel-doc warning in dma-fence.c
2020-08-31 4:17 [PATCH] dma-buf: fix kernel-doc warning in dma-fence.c Randy Dunlap
@ 2020-08-31 10:02 ` Christian König
2020-09-01 13:32 ` Daniel Vetter
0 siblings, 1 reply; 5+ messages in thread
From: Christian König @ 2020-08-31 10:02 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Sumit Semwal, Gustavo Padovan, linux-media, dri-devel
Am 31.08.20 um 06:17 schrieb Randy Dunlap:
> Add @cookie to dma_fence_end_signalling() to prevent kernel-doc
> warning in drivers/dma-buf/dma-fence.c:
>
> ../drivers/dma-buf/dma-fence.c:291: warning: Function parameter or member 'cookie' not described in 'dma_fence_end_signalling'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Gustavo Padovan <gustavo@padovan.org>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: linux-media@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
Acked-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/dma-buf/dma-fence.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- lnx-59-rc3.orig/drivers/dma-buf/dma-fence.c
> +++ lnx-59-rc3/drivers/dma-buf/dma-fence.c
> @@ -283,6 +283,7 @@ EXPORT_SYMBOL(dma_fence_begin_signalling
>
> /**
> * dma_fence_end_signalling - end a critical DMA fence signalling section
> + * @cookie: opaque cookie from dma_fence_begin_signalling()
> *
> * Closes a critical section annotation opened by dma_fence_begin_signalling().
> */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dma-buf: fix kernel-doc warning in dma-fence.c
2020-08-31 10:02 ` Christian König
@ 2020-09-01 13:32 ` Daniel Vetter
2020-09-01 13:37 ` Christian König
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2020-09-01 13:32 UTC (permalink / raw)
To: Christian König
Cc: Randy Dunlap, linux-kernel, Gustavo Padovan, dri-devel, linux-media
On Mon, Aug 31, 2020 at 12:02:03PM +0200, Christian König wrote:
> Am 31.08.20 um 06:17 schrieb Randy Dunlap:
> > Add @cookie to dma_fence_end_signalling() to prevent kernel-doc
> > warning in drivers/dma-buf/dma-fence.c:
> >
> > ../drivers/dma-buf/dma-fence.c:291: warning: Function parameter or member 'cookie' not described in 'dma_fence_end_signalling'
> >
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Sumit Semwal <sumit.semwal@linaro.org>
> > Cc: Gustavo Padovan <gustavo@padovan.org>
> > Cc: Christian König <christian.koenig@amd.com>
> > Cc: linux-media@vger.kernel.org
> > Cc: dri-devel@lists.freedesktop.org
>
> Acked-by: Christian König <christian.koenig@amd.com>
Will you merge these two to drm-misc-fixes or should someone else?
Always a bit confusing when maintainers reply with acks/r-b but not what
they'll do with the patch :-)
Cheers, Daniel
>
> > ---
> > drivers/dma-buf/dma-fence.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > --- lnx-59-rc3.orig/drivers/dma-buf/dma-fence.c
> > +++ lnx-59-rc3/drivers/dma-buf/dma-fence.c
> > @@ -283,6 +283,7 @@ EXPORT_SYMBOL(dma_fence_begin_signalling
> > /**
> > * dma_fence_end_signalling - end a critical DMA fence signalling section
> > + * @cookie: opaque cookie from dma_fence_begin_signalling()
> > *
> > * Closes a critical section annotation opened by dma_fence_begin_signalling().
> > */
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dma-buf: fix kernel-doc warning in dma-fence.c
2020-09-01 13:32 ` Daniel Vetter
@ 2020-09-01 13:37 ` Christian König
2020-09-01 15:06 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: Christian König @ 2020-09-01 13:37 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel, Gustavo Padovan, dri-devel, linux-media
Am 01.09.20 um 15:32 schrieb Daniel Vetter:
> On Mon, Aug 31, 2020 at 12:02:03PM +0200, Christian König wrote:
>> Am 31.08.20 um 06:17 schrieb Randy Dunlap:
>>> Add @cookie to dma_fence_end_signalling() to prevent kernel-doc
>>> warning in drivers/dma-buf/dma-fence.c:
>>>
>>> ../drivers/dma-buf/dma-fence.c:291: warning: Function parameter or member 'cookie' not described in 'dma_fence_end_signalling'
>>>
>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>> Cc: Sumit Semwal <sumit.semwal@linaro.org>
>>> Cc: Gustavo Padovan <gustavo@padovan.org>
>>> Cc: Christian König <christian.koenig@amd.com>
>>> Cc: linux-media@vger.kernel.org
>>> Cc: dri-devel@lists.freedesktop.org
>> Acked-by: Christian König <christian.koenig@amd.com>
> Will you merge these two to drm-misc-fixes or should someone else?
I was wondering the same thing and just waiting for Randy to reply with
please pick them up or I'm going to push them because I have commit access.
Regards,
Christian.
>
> Always a bit confusing when maintainers reply with acks/r-b but not what
> they'll do with the patch :-)
>
> Cheers, Daniel
>
>>> ---
>>> drivers/dma-buf/dma-fence.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> --- lnx-59-rc3.orig/drivers/dma-buf/dma-fence.c
>>> +++ lnx-59-rc3/drivers/dma-buf/dma-fence.c
>>> @@ -283,6 +283,7 @@ EXPORT_SYMBOL(dma_fence_begin_signalling
>>> /**
>>> * dma_fence_end_signalling - end a critical DMA fence signalling section
>>> + * @cookie: opaque cookie from dma_fence_begin_signalling()
>>> *
>>> * Closes a critical section annotation opened by dma_fence_begin_signalling().
>>> */
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=02%7C01%7Cchristian.koenig%40amd.com%7C4d8d43fbbb06475f964308d84e7b6a05%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637345639254630346&sdata=hxraBxca4oxH%2BsvRJaDT44kFp%2BAXlun2GaLYY6L6LdA%3D&reserved=0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dma-buf: fix kernel-doc warning in dma-fence.c
2020-09-01 13:37 ` Christian König
@ 2020-09-01 15:06 ` Randy Dunlap
0 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2020-09-01 15:06 UTC (permalink / raw)
To: Christian König, linux-kernel, Gustavo Padovan, dri-devel,
linux-media
On 9/1/20 6:37 AM, Christian König wrote:
> Am 01.09.20 um 15:32 schrieb Daniel Vetter:
>> On Mon, Aug 31, 2020 at 12:02:03PM +0200, Christian König wrote:
>>> Am 31.08.20 um 06:17 schrieb Randy Dunlap:
>>>> Add @cookie to dma_fence_end_signalling() to prevent kernel-doc
>>>> warning in drivers/dma-buf/dma-fence.c:
>>>>
>>>> ../drivers/dma-buf/dma-fence.c:291: warning: Function parameter or member 'cookie' not described in 'dma_fence_end_signalling'
>>>>
>>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>>> Cc: Sumit Semwal <sumit.semwal@linaro.org>
>>>> Cc: Gustavo Padovan <gustavo@padovan.org>
>>>> Cc: Christian König <christian.koenig@amd.com>
>>>> Cc: linux-media@vger.kernel.org
>>>> Cc: dri-devel@lists.freedesktop.org
>>> Acked-by: Christian König <christian.koenig@amd.com>
>> Will you merge these two to drm-misc-fixes or should someone else?
>
> I was wondering the same thing and just waiting for Randy to reply with please pick them up or I'm going to push them because I have commit access.
I didn't realize that was needed, but anyway, Christian, please apply these 2
dma-buf kernel-doc patches.
thanks.
> Regards,
> Christian.
>
>>
>> Always a bit confusing when maintainers reply with acks/r-b but not what
>> they'll do with the patch :-)
Agreed.
>> Cheers, Daniel
>>
>>>> ---
>>>> drivers/dma-buf/dma-fence.c | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> --- lnx-59-rc3.orig/drivers/dma-buf/dma-fence.c
>>>> +++ lnx-59-rc3/drivers/dma-buf/dma-fence.c
>>>> @@ -283,6 +283,7 @@ EXPORT_SYMBOL(dma_fence_begin_signalling
>>>> /**
>>>> * dma_fence_end_signalling - end a critical DMA fence signalling section
>>>> + * @cookie: opaque cookie from dma_fence_begin_signalling()
>>>> *
>>>> * Closes a critical section annotation opened by dma_fence_begin_signalling().
>>>> */
>>> _______________________________________________
>>> dri-devel mailing list
>>> dri-devel@lists.freedesktop.org
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-09-01 15:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-31 4:17 [PATCH] dma-buf: fix kernel-doc warning in dma-fence.c Randy Dunlap
2020-08-31 10:02 ` Christian König
2020-09-01 13:32 ` Daniel Vetter
2020-09-01 13:37 ` Christian König
2020-09-01 15:06 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).