* [PATCH 0/2] Renesas Lager/Koelsch HDMI input
@ 2016-09-16 13:09 Ulrich Hecht
2016-09-16 13:09 ` [PATCH 1/2] ARM: dts: lager: Add entries for VIN HDMI input support Ulrich Hecht
2016-09-16 13:09 ` [PATCH 2/2] ARM: dts: koelsch: add HDMI input Ulrich Hecht
0 siblings, 2 replies; 6+ messages in thread
From: Ulrich Hecht @ 2016-09-16 13:09 UTC (permalink / raw)
To: horms
Cc: geert, hans.verkuil, niklas.soderlund, linux-media,
linux-renesas-soc, magnus.damm, ulrich.hecht+renesas,
laurent.pinchart, william.towle
Hi!
This series enables HDMI input on the Lager and Koelsch boards.
It sits on renesas-devel-20160913-v4.8-rc6 and also applies to the media
tree.
Testing this on a Lager board with v4l2-compliance on top of Hans's R-Car
branch (https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=rcar) with
"media: adv7604: automatic "default-input" selection" applied, it gets a
perfect score (172/172 pass).
CU
Uli
Hans Verkuil (1):
ARM: dts: koelsch: add HDMI input
William Towle (1):
ARM: dts: lager: Add entries for VIN HDMI input support
arch/arm/boot/dts/r8a7790-lager.dts | 39 +++++++++++++++++++++++++++++++++
arch/arm/boot/dts/r8a7791-koelsch.dts | 41 +++++++++++++++++++++++++++++++++++
2 files changed, 80 insertions(+)
--
2.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] ARM: dts: lager: Add entries for VIN HDMI input support
2016-09-16 13:09 [PATCH 0/2] Renesas Lager/Koelsch HDMI input Ulrich Hecht
@ 2016-09-16 13:09 ` Ulrich Hecht
2016-09-17 10:25 ` Sergei Shtylyov
2016-09-16 13:09 ` [PATCH 2/2] ARM: dts: koelsch: add HDMI input Ulrich Hecht
1 sibling, 1 reply; 6+ messages in thread
From: Ulrich Hecht @ 2016-09-16 13:09 UTC (permalink / raw)
To: horms
Cc: geert, hans.verkuil, niklas.soderlund, linux-media,
linux-renesas-soc, magnus.damm, ulrich.hecht+renesas,
laurent.pinchart, william.towle, Rob Taylor
From: William Towle <william.towle@codethink.co.uk>
Add DT entries for vin0, vin0_pins, and adv7612.
Sets the 'default-input' property for ADV7612, enabling image and video
capture without the need to have userspace specifying routing.
Signed-off-by: William Towle <william.towle@codethink.co.uk>
Signed-off-by: Rob Taylor <rob.taylor@codethink.co.uk>
[uli: added interrupt, renamed endpoint, merged default-input]
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
arch/arm/boot/dts/r8a7790-lager.dts | 39 +++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
index 52b56fc..fc9d129 100644
--- a/arch/arm/boot/dts/r8a7790-lager.dts
+++ b/arch/arm/boot/dts/r8a7790-lager.dts
@@ -427,6 +427,11 @@
function = "usb2";
};
+ vin0_pins: vin0 {
+ groups = "vin0_data24", "vin0_sync", "vin0_clkenb", "vin0_clk";
+ function = "vin0";
+ };
+
vin1_pins: vin1 {
groups = "vin1_data8", "vin1_clk";
function = "vin1";
@@ -651,6 +656,21 @@
};
};
};
+
+ hdmi-in@4c {
+ compatible = "adi,adv7612";
+ reg = <0x4c>;
+ interrupt-parent = <&gpio1>;
+ interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
+ remote = <&vin0>;
+ default-input = <0>;
+
+ port {
+ adv7612: endpoint {
+ remote-endpoint = <&vin0ep0>;
+ };
+ };
+ };
};
&iic3 {
@@ -722,6 +742,25 @@
status = "okay";
};
+/* HDMI video input */
+&vin0 {
+ pinctrl-0 = <&vin0_pins>;
+ pinctrl-names = "default";
+
+ status = "ok";
+
+ port {
+ vin0ep0: endpoint {
+ remote-endpoint = <&adv7612>;
+ bus-width = <24>;
+ hsync-active = <0>;
+ vsync-active = <0>;
+ pclk-sample = <1>;
+ data-active = <1>;
+ };
+ };
+};
+
/* composite video input */
&vin1 {
pinctrl-0 = <&vin1_pins>;
--
2.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] ARM: dts: koelsch: add HDMI input
2016-09-16 13:09 [PATCH 0/2] Renesas Lager/Koelsch HDMI input Ulrich Hecht
2016-09-16 13:09 ` [PATCH 1/2] ARM: dts: lager: Add entries for VIN HDMI input support Ulrich Hecht
@ 2016-09-16 13:09 ` Ulrich Hecht
2016-10-03 10:15 ` Laurent Pinchart
1 sibling, 1 reply; 6+ messages in thread
From: Ulrich Hecht @ 2016-09-16 13:09 UTC (permalink / raw)
To: horms
Cc: geert, hans.verkuil, niklas.soderlund, linux-media,
linux-renesas-soc, magnus.damm, ulrich.hecht+renesas,
laurent.pinchart, william.towle, Hans Verkuil
From: Hans Verkuil <hverkuil@xs4all.nl>
Add support in the dts for the HDMI input. Based on the Lager dts
patch from Ulrich Hecht.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
[uli: removed "renesas," prefixes from pfc nodes]
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
arch/arm/boot/dts/r8a7791-koelsch.dts | 41 +++++++++++++++++++++++++++++++++++
1 file changed, 41 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
index f8a7d09..45b8b5f 100644
--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
@@ -393,6 +393,11 @@
function = "usb1";
};
+ vin0_pins: vin0 {
+ groups = "vin0_data24", "vin0_sync", "vin0_clkenb", "vin0_clk";
+ function = "vin0";
+ };
+
vin1_pins: vin1 {
groups = "vin1_data8", "vin1_clk";
function = "vin1";
@@ -596,6 +601,21 @@
};
};
+ hdmi-in@4c {
+ compatible = "adi,adv7612";
+ reg = <0x4c>;
+ interrupt-parent = <&gpio1>;
+ interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
+ remote = <&vin0>;
+ default-input = <0>;
+
+ port {
+ adv7612: endpoint {
+ remote-endpoint = <&vin0ep>;
+ };
+ };
+ };
+
eeprom@50 {
compatible = "renesas,24c02";
reg = <0x50>;
@@ -672,6 +692,27 @@
cpu0-supply = <&vdd_dvfs>;
};
+/* HDMI video input */
+&vin0 {
+ status = "okay";
+ pinctrl-0 = <&vin0_pins>;
+ pinctrl-names = "default";
+
+ port {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ vin0ep: endpoint {
+ remote-endpoint = <&adv7612>;
+ bus-width = <24>;
+ hsync-active = <0>;
+ vsync-active = <0>;
+ pclk-sample = <1>;
+ data-active = <1>;
+ };
+ };
+};
+
/* composite video input */
&vin1 {
status = "okay";
--
2.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ARM: dts: lager: Add entries for VIN HDMI input support
2016-09-16 13:09 ` [PATCH 1/2] ARM: dts: lager: Add entries for VIN HDMI input support Ulrich Hecht
@ 2016-09-17 10:25 ` Sergei Shtylyov
2016-09-20 9:25 ` Simon Horman
0 siblings, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2016-09-17 10:25 UTC (permalink / raw)
To: Ulrich Hecht, horms
Cc: geert, hans.verkuil, niklas.soderlund, linux-media,
linux-renesas-soc, magnus.damm, laurent.pinchart, william.towle,
Rob Taylor
Hello.
On 9/16/2016 4:09 PM, Ulrich Hecht wrote:
> From: William Towle <william.towle@codethink.co.uk>
>
> Add DT entries for vin0, vin0_pins, and adv7612.
>
> Sets the 'default-input' property for ADV7612, enabling image and video
> capture without the need to have userspace specifying routing.
>
> Signed-off-by: William Towle <william.towle@codethink.co.uk>
> Signed-off-by: Rob Taylor <rob.taylor@codethink.co.uk>
> [uli: added interrupt, renamed endpoint, merged default-input]
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
> arch/arm/boot/dts/r8a7790-lager.dts | 39 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> index 52b56fc..fc9d129 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
[...]
> @@ -722,6 +742,25 @@
> status = "okay";
> };
>
> +/* HDMI video input */
> +&vin0 {
> + pinctrl-0 = <&vin0_pins>;
> + pinctrl-names = "default";
> +
> + status = "ok";
Should be "okay", although "ok" is also valid.
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ARM: dts: lager: Add entries for VIN HDMI input support
2016-09-17 10:25 ` Sergei Shtylyov
@ 2016-09-20 9:25 ` Simon Horman
0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2016-09-20 9:25 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Ulrich Hecht, geert, hans.verkuil, niklas.soderlund, linux-media,
linux-renesas-soc, magnus.damm, laurent.pinchart, william.towle,
Rob Taylor
On Sat, Sep 17, 2016 at 01:25:47PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 9/16/2016 4:09 PM, Ulrich Hecht wrote:
>
> >From: William Towle <william.towle@codethink.co.uk>
> >
> >Add DT entries for vin0, vin0_pins, and adv7612.
> >
> >Sets the 'default-input' property for ADV7612, enabling image and video
> >capture without the need to have userspace specifying routing.
> >
> >Signed-off-by: William Towle <william.towle@codethink.co.uk>
> >Signed-off-by: Rob Taylor <rob.taylor@codethink.co.uk>
> >[uli: added interrupt, renamed endpoint, merged default-input]
> >Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> >---
> > arch/arm/boot/dts/r8a7790-lager.dts | 39 +++++++++++++++++++++++++++++++++++++
> > 1 file changed, 39 insertions(+)
> >
> >diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> >index 52b56fc..fc9d129 100644
> >--- a/arch/arm/boot/dts/r8a7790-lager.dts
> >+++ b/arch/arm/boot/dts/r8a7790-lager.dts
> [...]
> >@@ -722,6 +742,25 @@
> > status = "okay";
> > };
> >
> >+/* HDMI video input */
> >+&vin0 {
> >+ pinctrl-0 = <&vin0_pins>;
> >+ pinctrl-names = "default";
> >+
> >+ status = "ok";
>
> Should be "okay", although "ok" is also valid.
Ulrich, could you fix this and repost?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] ARM: dts: koelsch: add HDMI input
2016-09-16 13:09 ` [PATCH 2/2] ARM: dts: koelsch: add HDMI input Ulrich Hecht
@ 2016-10-03 10:15 ` Laurent Pinchart
0 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2016-10-03 10:15 UTC (permalink / raw)
To: Ulrich Hecht
Cc: horms, geert, hans.verkuil, niklas.soderlund, linux-media,
linux-renesas-soc, magnus.damm, william.towle, Hans Verkuil
Hi Ulrich,
Thank you for the patch.
On Friday 16 Sep 2016 15:09:09 Ulrich Hecht wrote:
> From: Hans Verkuil <hverkuil@xs4all.nl>
>
> Add support in the dts for the HDMI input. Based on the Lager dts
> patch from Ulrich Hecht.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> [uli: removed "renesas," prefixes from pfc nodes]
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
> arch/arm/boot/dts/r8a7791-koelsch.dts | 41 ++++++++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts
> b/arch/arm/boot/dts/r8a7791-koelsch.dts index f8a7d09..45b8b5f 100644
> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> @@ -393,6 +393,11 @@
> function = "usb1";
> };
>
> + vin0_pins: vin0 {
> + groups = "vin0_data24", "vin0_sync", "vin0_clkenb",
"vin0_clk";
> + function = "vin0";
> + };
> +
> vin1_pins: vin1 {
> groups = "vin1_data8", "vin1_clk";
> function = "vin1";
> @@ -596,6 +601,21 @@
> };
> };
>
> + hdmi-in@4c {
> + compatible = "adi,adv7612";
> + reg = <0x4c>;
> + interrupt-parent = <&gpio1>;
> + interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
This should be GP4_2.
> + remote = <&vin0>;
Is this needed ?
> + default-input = <0>;
> +
> + port {
> + adv7612: endpoint {
> + remote-endpoint = <&vin0ep>;
> + };
> + };
The ADV7612 has three ports. Ports 0 and 1 correspond to the HDMI inputs, and
port 2 to the digital output. You can leave port 1 out as it's not used on the
board, but you should specify both ports 0 and 2, and add an HDMI connector DT
node connected to port 0 of the ADV7612.
> + };
> +
> eeprom@50 {
> compatible = "renesas,24c02";
> reg = <0x50>;
> @@ -672,6 +692,27 @@
> cpu0-supply = <&vdd_dvfs>;
> };
>
> +/* HDMI video input */
> +&vin0 {
> + status = "okay";
> + pinctrl-0 = <&vin0_pins>;
> + pinctrl-names = "default";
> +
> + port {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + vin0ep: endpoint {
> + remote-endpoint = <&adv7612>;
> + bus-width = <24>;
> + hsync-active = <0>;
> + vsync-active = <0>;
> + pclk-sample = <1>;
> + data-active = <1>;
> + };
> + };
> +};
> +
> /* composite video input */
> &vin1 {
> status = "okay";
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-03 10:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-16 13:09 [PATCH 0/2] Renesas Lager/Koelsch HDMI input Ulrich Hecht
2016-09-16 13:09 ` [PATCH 1/2] ARM: dts: lager: Add entries for VIN HDMI input support Ulrich Hecht
2016-09-17 10:25 ` Sergei Shtylyov
2016-09-20 9:25 ` Simon Horman
2016-09-16 13:09 ` [PATCH 2/2] ARM: dts: koelsch: add HDMI input Ulrich Hecht
2016-10-03 10:15 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).