* [PATCH -next] media: atmel-isc: Make local symbol fmt_configs_list static
@ 2017-12-23 1:57 Wei Yongjun
2017-12-26 1:39 ` Yang, Wenyou
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2017-12-23 1:57 UTC (permalink / raw)
To: Songjun Wu, Mauro Carvalho Chehab, Nicolas Ferre,
Alexandre Belloni, Wenyou Yang, Hans Verkuil
Cc: Wei Yongjun, linux-media, linux-arm-kernel
Fixes the following sparse warning:
drivers/media/platform/atmel/atmel-isc.c:338:19: warning:
symbol 'fmt_configs_list' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/media/platform/atmel/atmel-isc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel-isc.c
index 0c26356..2dd72fc 100644
--- a/drivers/media/platform/atmel/atmel-isc.c
+++ b/drivers/media/platform/atmel/atmel-isc.c
@@ -335,7 +335,7 @@ struct isc_device {
},
};
-struct fmt_config fmt_configs_list[] = {
+static struct fmt_config fmt_configs_list[] = {
{
.fourcc = V4L2_PIX_FMT_SBGGR8,
.pfe_cfg0_bps = ISC_PFE_CFG0_BPS_EIGHT,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] media: atmel-isc: Make local symbol fmt_configs_list static
2017-12-23 1:57 [PATCH -next] media: atmel-isc: Make local symbol fmt_configs_list static Wei Yongjun
@ 2017-12-26 1:39 ` Yang, Wenyou
0 siblings, 0 replies; 2+ messages in thread
From: Yang, Wenyou @ 2017-12-26 1:39 UTC (permalink / raw)
To: Wei Yongjun, Songjun Wu, Mauro Carvalho Chehab, Nicolas Ferre,
Alexandre Belloni, Hans Verkuil
Cc: linux-media, linux-arm-kernel
On 2017/12/23 9:57, Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> drivers/media/platform/atmel/atmel-isc.c:338:19: warning:
> symbol 'fmt_configs_list' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
Acked-by: Wenyou Yang <wenyou.yang@microchip.com>
> drivers/media/platform/atmel/atmel-isc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel-isc.c
> index 0c26356..2dd72fc 100644
> --- a/drivers/media/platform/atmel/atmel-isc.c
> +++ b/drivers/media/platform/atmel/atmel-isc.c
> @@ -335,7 +335,7 @@ struct isc_device {
> },
> };
>
> -struct fmt_config fmt_configs_list[] = {
> +static struct fmt_config fmt_configs_list[] = {
> {
> .fourcc = V4L2_PIX_FMT_SBGGR8,
> .pfe_cfg0_bps = ISC_PFE_CFG0_BPS_EIGHT,
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-26 1:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-23 1:57 [PATCH -next] media: atmel-isc: Make local symbol fmt_configs_list static Wei Yongjun
2017-12-26 1:39 ` Yang, Wenyou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).