* [PATCH] rtc: Delete an error message in three functions
@ 2020-04-05 15:36 Markus Elfring
2020-04-05 16:31 ` Vladimir Zapolskiy
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2020-04-05 15:36 UTC (permalink / raw)
To: linux-rtc, linux-arm-kernel, linux-mediatek, Alessandro Zummo,
Alexandre Belloni, Eddie Huang, Sean Wang, Vladimir Zapolskiy
Cc: kernel-janitors, LKML, Tang Bin
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 5 Apr 2020 17:30:15 +0200
The function “platform_get_irq” can log an error already.
Thus omit redundant messages for the exception handling in the
calling functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/rtc/rtc-fsl-ftm-alarm.c | 4 +---
drivers/rtc/rtc-lpc24xx.c | 4 +---
drivers/rtc/rtc-mt2712.c | 4 +---
3 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c b/drivers/rtc/rtc-fsl-ftm-alarm.c
index 756af62b0486..23c811da4801 100644
--- a/drivers/rtc/rtc-fsl-ftm-alarm.c
+++ b/drivers/rtc/rtc-fsl-ftm-alarm.c
@@ -268,10 +268,8 @@ static int ftm_rtc_probe(struct platform_device *pdev)
}
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(&pdev->dev, "can't get irq number\n");
+ if (irq < 0)
return irq;
- }
ret = devm_request_irq(&pdev->dev, irq, ftm_rtc_alarm_interrupt,
IRQF_NO_SUSPEND, dev_name(&pdev->dev), rtc);
diff --git a/drivers/rtc/rtc-lpc24xx.c b/drivers/rtc/rtc-lpc24xx.c
index 00ef16ba9480..eec881a81067 100644
--- a/drivers/rtc/rtc-lpc24xx.c
+++ b/drivers/rtc/rtc-lpc24xx.c
@@ -205,10 +205,8 @@ static int lpc24xx_rtc_probe(struct platform_device *pdev)
return PTR_ERR(rtc->rtc_base);
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_warn(&pdev->dev, "can't get interrupt resource\n");
+ if (irq < 0)
return irq;
- }
rtc->clk_rtc = devm_clk_get(&pdev->dev, "rtc");
if (IS_ERR(rtc->clk_rtc)) {
diff --git a/drivers/rtc/rtc-mt2712.c b/drivers/rtc/rtc-mt2712.c
index 581b8731fb8a..f6bdbabd7202 100644
--- a/drivers/rtc/rtc-mt2712.c
+++ b/drivers/rtc/rtc-mt2712.c
@@ -328,10 +328,8 @@ static int mt2712_rtc_probe(struct platform_device *pdev)
mt2712_rtc_hw_init(mt2712_rtc);
mt2712_rtc->irq = platform_get_irq(pdev, 0);
- if (mt2712_rtc->irq < 0) {
- dev_err(&pdev->dev, "No IRQ resource\n");
+ if (mt2712_rtc->irq < 0)
return mt2712_rtc->irq;
- }
platform_set_drvdata(pdev, mt2712_rtc);
--
2.26.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: Delete an error message in three functions
2020-04-05 15:36 [PATCH] rtc: Delete an error message in three functions Markus Elfring
@ 2020-04-05 16:31 ` Vladimir Zapolskiy
0 siblings, 0 replies; 2+ messages in thread
From: Vladimir Zapolskiy @ 2020-04-05 16:31 UTC (permalink / raw)
To: Markus Elfring, linux-rtc, linux-arm-kernel, linux-mediatek,
Alessandro Zummo, Alexandre Belloni, Eddie Huang, Sean Wang
Cc: kernel-janitors, LKML, Tang Bin
On 4/5/20 6:36 PM, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 5 Apr 2020 17:30:15 +0200
>
> The function “platform_get_irq” can log an error already.
> Thus omit redundant messages for the exception handling in the
> calling functions.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/rtc/rtc-fsl-ftm-alarm.c | 4 +---
> drivers/rtc/rtc-lpc24xx.c | 4 +---
For LPC24xx/18xx/43xx change
Acked-by: Vladimir Zapolskiy <vz@mleia.com>
> drivers/rtc/rtc-mt2712.c | 4 +---
> 3 files changed, 3 insertions(+), 9 deletions(-)
>
--
Best wishes,
Vladimir
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-05 16:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-05 15:36 [PATCH] rtc: Delete an error message in three functions Markus Elfring
2020-04-05 16:31 ` Vladimir Zapolskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).