* Re: [PATCH 1/2] clk: Export clk_register_composite
[not found] ` <1593588382-19049-2-git-send-email-wendell.lin@mediatek.com>
@ 2020-07-11 0:26 ` Stephen Boyd
2020-07-23 8:08 ` Wendell Lin
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Boyd @ 2020-07-11 0:26 UTC (permalink / raw)
To: Matthias Brugger, Michael Turquette, Weiyi Lu, mtk01761
Cc: wsd_upstream, linux-mediatek, linux-clk, linux-arm-kernel, linux-kernel
Quoting Wendell Lin (2020-07-01 00:26:21)
> clk_register_composite() will be used in mediatek's
> clock kernel module, so export it to GPL modules.
>
> Signed-off-by: Wendell Lin <wendell.lin@mediatek.com>
> ---
> drivers/clk/clk-composite.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/clk-composite.c b/drivers/clk/clk-composite.c
> index 7376f57..fb5cb4a 100644
> --- a/drivers/clk/clk-composite.c
> +++ b/drivers/clk/clk-composite.c
> @@ -360,6 +360,7 @@ struct clk *clk_register_composite(struct device *dev, const char *name,
> return ERR_CAST(hw);
> return hw->clk;
> }
> +EXPORT_SYMBOL(clk_register_composite);
Should be EXPORT_SYMBOL_GPL()
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] clk: mediatek: Add EXPORT_SYMBOL for kernel module support
[not found] ` <1593588382-19049-3-git-send-email-wendell.lin@mediatek.com>
@ 2020-07-11 16:26 ` Stephen Boyd
2020-07-23 8:09 ` Wendell Lin
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Boyd @ 2020-07-11 16:26 UTC (permalink / raw)
To: Matthias Brugger, Michael Turquette, Weiyi Lu, mtk01761
Cc: wsd_upstream, linux-mediatek, linux-clk, linux-arm-kernel, linux-kernel
Quoting Wendell Lin (2020-07-01 00:26:22)
> Export common APIs from Mediatek clock driver.
>
> Signed-off-by: Wendell Lin <wendell.lin@mediatek.com>
Is this needed for something? I'd prefer to see some sort of mediatek
modular patches that included this patch in it before this is applied.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] clk: Export clk_register_composite
2020-07-11 0:26 ` [PATCH 1/2] clk: Export clk_register_composite Stephen Boyd
@ 2020-07-23 8:08 ` Wendell Lin
0 siblings, 0 replies; 4+ messages in thread
From: Wendell Lin @ 2020-07-23 8:08 UTC (permalink / raw)
To: Stephen Boyd
Cc: wsd_upstream, Weiyi Lu, Michael Turquette, linux-kernel,
linux-mediatek, Matthias Brugger, linux-clk, linux-arm-kernel
On Fri, 2020-07-10 at 17:26 -0700, Stephen Boyd wrote:
> Quoting Wendell Lin (2020-07-01 00:26:21)
> > clk_register_composite() will be used in mediatek's
> > clock kernel module, so export it to GPL modules.
> >
> > Signed-off-by: Wendell Lin <wendell.lin@mediatek.com>
> > ---
> > drivers/clk/clk-composite.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/clk/clk-composite.c b/drivers/clk/clk-composite.c
> > index 7376f57..fb5cb4a 100644
> > --- a/drivers/clk/clk-composite.c
> > +++ b/drivers/clk/clk-composite.c
> > @@ -360,6 +360,7 @@ struct clk *clk_register_composite(struct device *dev, const char *name,
> > return ERR_CAST(hw);
> > return hw->clk;
> > }
> > +EXPORT_SYMBOL(clk_register_composite);
>
> Should be EXPORT_SYMBOL_GPL()
Got it, I'll fix it.
Regards,
Wendell
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] clk: mediatek: Add EXPORT_SYMBOL for kernel module support
2020-07-11 16:26 ` [PATCH 2/2] clk: mediatek: Add EXPORT_SYMBOL for kernel module support Stephen Boyd
@ 2020-07-23 8:09 ` Wendell Lin
0 siblings, 0 replies; 4+ messages in thread
From: Wendell Lin @ 2020-07-23 8:09 UTC (permalink / raw)
To: Stephen Boyd
Cc: wsd_upstream, Weiyi Lu, Michael Turquette, linux-kernel,
linux-mediatek, Matthias Brugger, linux-clk, linux-arm-kernel
On Sat, 2020-07-11 at 09:26 -0700, Stephen Boyd wrote:
> Quoting Wendell Lin (2020-07-01 00:26:22)
> > Export common APIs from Mediatek clock driver.
> >
> > Signed-off-by: Wendell Lin <wendell.lin@mediatek.com>
>
> Is this needed for something? I'd prefer to see some sort of mediatek
> modular patches that included this patch in it before this is applied.
Got it.
I'll prepare a new series of mediatek modular patches that included this
patch in it later.
Regards,
Wendell
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-23 8:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1593588382-19049-1-git-send-email-wendell.lin@mediatek.com>
[not found] ` <1593588382-19049-2-git-send-email-wendell.lin@mediatek.com>
2020-07-11 0:26 ` [PATCH 1/2] clk: Export clk_register_composite Stephen Boyd
2020-07-23 8:08 ` Wendell Lin
[not found] ` <1593588382-19049-3-git-send-email-wendell.lin@mediatek.com>
2020-07-11 16:26 ` [PATCH 2/2] clk: mediatek: Add EXPORT_SYMBOL for kernel module support Stephen Boyd
2020-07-23 8:09 ` Wendell Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).