From: Yong Wu <yong.wu@mediatek.com>
To: Krzysztof Kozlowski <krzk@kernel.org>, Rob Herring <robh+dt@kernel.org>
Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org,
kernel-team@android.com, Nicolas Boichat <drinkcat@chromium.org>,
srv_heupstream@mediatek.com, chao.hao@mediatek.com,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>,
Greg Kroah-Hartman <gregkh@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Evan Green <evgreen@chromium.org>, Tomasz Figa <tfiga@google.com>,
iommu@lists.linux-foundation.org,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
ming-fan.chen@mediatek.com, anan.sun@mediatek.com,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 02/24] dt-bindings: memory: mediatek: Convert SMI to DT schema
Date: Mon, 12 Oct 2020 20:01:59 +0800 [thread overview]
Message-ID: <1602504119.26323.54.camel@mhfsdcap03> (raw)
In-Reply-To: <20201012071843.GA1889@pi3>
On Mon, 2020-10-12 at 09:18 +0200, Krzysztof Kozlowski wrote:
> On Sat, Oct 10, 2020 at 02:18:11PM +0800, Yong Wu wrote:
> > On Tue, 2020-10-06 at 09:15 +0200, Krzysztof Kozlowski wrote:
> > > On Tue, 6 Oct 2020 at 06:27, Yong Wu <yong.wu@mediatek.com> wrote:
> > > >
> > > > On Fri, 2020-10-02 at 13:08 +0200, Krzysztof Kozlowski wrote:
> > > > > On Wed, Sep 30, 2020 at 03:06:25PM +0800, Yong Wu wrote:
> > > > > > Convert MediaTek SMI to DT schema.
> > > > > >
> > > > > > Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> > > > > > ---
> > > > > > .../mediatek,smi-common.txt | 49 ---------
> > > > > > .../mediatek,smi-common.yaml | 100 ++++++++++++++++++
> > > > > > .../memory-controllers/mediatek,smi-larb.txt | 49 ---------
> > > > > > .../memory-controllers/mediatek,smi-larb.yaml | 91 ++++++++++++++++
> > > > > > 4 files changed, 191 insertions(+), 98 deletions(-)
> > > > > > delete mode 100644 Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.txt
> > > > > > create mode 100644 Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
> > > > > > delete mode 100644 Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.txt
> > > > > > create mode 100644 Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
> > > > ...
> > > > > > +properties:
> > > > > > + compatible:
> > > > > > + oneOf:
> > > > > > + - enum:
> > > > > > + - mediatek,mt2701-smi-common
> > > > > > + - mediatek,mt2712-smi-common
> > > > > > + - mediatek,mt6779-smi-common
> > > > > > + - mediatek,mt8173-smi-common
> > > > > > + - mediatek,mt8183-smi-common
> > > > > > +
> > > > > > + - description: for mt7623
> > > > > > + items:
> > > > > > + - const: mediatek,mt7623-smi-common
> > > > > > + - const: mediatek,mt2701-smi-common
> > > > > > +
> > > > > > + reg:
> > > > > > + maxItems: 1
> > > > > > +
> > > > > > + clocks:
> > > > > > + description: |
> > > > > > + apb and smi are mandatory. the async is only for generation 1 smi HW.
> > > > > > + gals(global async local sync) also is optional, here is the list which
> > > > > > + require gals: mt6779 and mt8183.
> > > > > > + minItems: 2
> > > > > > + maxItems: 4
> > > > > > + items:
> > > > > > + - description: apb is Advanced Peripheral Bus clock, It's the clock for
> > > > > > + setting the register.
> > > > > > + - description: smi is the clock for transfer data and command.
> > > > > > + - description: async is asynchronous clock, it help transform the smi clock
> > > > > > + into the emi clock domain.
> > > > > > + - description: gals0 is the path0 clock of gals.
> > > > > > + - description: gals1 is the path1 clock of gals.
> > > > > > +
> > > > > > + clock-names:
> > > > > > + oneOf:
> > > > > > + - items:
> > > > > > + - const: apb
> > > > > > + - const: smi
> > > > > > + - items:
> > > > > > + - const: apb
> > > > > > + - const: smi
> > > > > > + - const: async
> > > > > > + - items:
> > > > > > + - const: apb
> > > > > > + - const: smi
> > > > > > + - const: gals0
> > > > > > + - const: gals1
> > > > >
> > > > > Similarly to my comment to other properties, this requirement per
> > > > > compatible should be part of the schema within 'if-then'.
> > > >
> > > > I'm not so familiar with this format. Do this has "if-then-'else
> > > > if'-then-else"?
> > >
> > > These are mutually exclusive conditions, so you can skip else:
> > > - if-then
> > > - if-then
> > > - if-then
> > > It will be more readable then stacking 'if' under 'else'
> >
> > Thanks. I will use something like this:
> >
> > anyOf:
>
> Then it should be oneOf as only one condition can be valid.
I did do this at the beginning. But I get a warning log when
dt_binding_check.
Below is my schema and the detailed warning log:
//=======================================
clocks:
description: |
xxxxx
minItems: 2
maxItems: 4
items:
- description: apb is the clock for setting the register.
- description: smi is the clock for transfer data and command.
- description: async is asynchronous clock.
- description: gals0 is the path0 clock of gals.
- description: gals1 is the path1 clock of gals.
clock-names:
minItems: 2
maxItems: 4
required:
- compatible
- reg
- power-domains
- clocks
- clock-names
oneOf:
- if: #only for gen1 HW
properties:
compatible:
contains:
enum:
- mediatek,mt2701-smi-common
then:
properties:
clock:
items:
minItems: 3
maxItems: 3
clock-names:
items:
- const: apb
- const: smi
- const: async
- if: #for gen2 HW that have gals
properties:
compatible:
enum:
- mediatek,mt6779-smi-common
- mediatek,mt8183-smi-common
- mediatek,mt8192-smi-common
then:
properties:
clock:
items:
minItems: 4
maxItems: 4
clock-names:
items:
- const: apb
- const: smi
- const: gals0
- const: gals1
else: #for gen2 HW that don't have gals
properties:
clock:
items:
minItems: 2
maxItems: 2
clock-names:
items:
- const: apb
- const: smi
additionalProperties: false
//===========warning log=====================
Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.example.dt.yaml
.../Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.example.dt.yaml: smi@14022000: {'compatible': ['mediatek,mt8173-smi-common'], 'reg': [[335683584, 4096]], 'power-domains': [[4294967295, 3]], 'clocks': [[4294967295, 1], [4294967295, 1]], 'clock-names': ['apb', 'smi'], '$nodename': ['smi@14022000']} is valid under each of {'else': {'properties': {'clock': {'items': {'maxItems': 2, 'minItems': 2}, 'type': 'array'}, 'clock-names': {'additionalItems': False, 'items': [{'const': 'apb'}, {'const': 'smi'}], 'maxItems': 2, 'minItems': 2, 'type': 'array'}}}, 'if': {'properties': {'compatible': {'additionalItems': False, 'items': [{'enum': ['mediatek,mt6779-smi-common', 'mediatek,mt8183-smi-common', 'mediatek,mt8192-smi-common']}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}}}, 'then': {'properties': {'clock': {'items': {'maxItems': 4, 'minItems': 4}, 'type': 'array'}, 'clock-names': {'additionalItems': False, 'items': [{'const': 'apb'}, {'const': 'smi'}, {'const'
: 'gals0'}, {'const': 'gals1'}], 'maxItems': 4, 'minItems': 4, 'type': 'array'}}}}, {'if': {'properties': {'compatible': {'contains': {'enum': ['mediatek,mt2701-smi-common']}}}}, 'then': {'properties': {'clock': {'items': {'maxItems': 3, 'minItems': 3}, 'type': 'array'}, 'clock-names': {'additionalItems': False, 'items': [{'const': 'apb'}, {'const': 'smi'}, {'const': 'async'}], 'maxItems': 3, 'minItems': 3, 'type': 'array'}}}}
{'$filename':
'.../Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml',
'$id':
'http://devicetree.org/schemas/memory-controllers/mediatek,smi-common.yaml#',
'$schema': 'http://devicetree.org/meta-schemas/core.yaml#',
'$select_validator': <jsonschema.validators.create.<locals>.Validator
object at 0x7fb3df378908>,
'additionalProperties': False,
'oneOf': [{'if': {'properties': {'compatible': {'contains': {'enum':
['mediatek,mt2701-smi-common']}}}},
'then': {'properties': {'clock': {'items': {'maxItems': 3,
'minItems': 3},
'type': 'array'},
'clock-names': {'additionalItems':
False,
'items': [{'const':
'apb'},
{'const':
'smi'},
{'const':
'async'}],
'maxItems': 3,
'minItems': 3,
'type': 'array'}}}},
{'else': {'properties': {'clock': {'items': {'maxItems': 2,
'minItems': 2},
'type': 'array'},
'clock-names': {'additionalItems':
False,
'items': [{'const':
'apb'},
{'const':
'smi'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'}}},
'if': {'properties': {'compatible': {'additionalItems':
False,
'items': [{'enum':
['mediatek,mt6779-smi-common',
'mediatek,mt8183-smi-common',
'mediatek,mt8192-smi-common']}],
'maxItems': 1,
'minItems': 1,
'type': 'array'}}},
'then': {'properties': {'clock': {'items': {'maxItems': 4,
'minItems': 4},
'type': 'array'},
'clock-names': {'additionalItems':
False,
'items': [{'const':
'apb'},
{'const':
'smi'},
{'const':
'gals0'},
{'const':
'gals1'}],
'maxItems': 4,
'minItems': 4,
'type':
'array'}}}}],
'patternProperties': {'pinctrl-[0-9]+': True},
'properties': {'$nodename': True,
'clock-names': {'maxItems': 4, 'minItems': 2},
'clocks': {'additionalItems': False,
'items': [{}, {}, {}, {}, {}],
'maxItems': 4,
'minItems': 2,
'type': 'array'},
'compatible': {'oneOf': [{'additionalItems': False,
'items': [{'enum':
['mediatek,mt2701-smi-common',
'mediatek,mt2712-smi-common',
'mediatek,mt6779-smi-common',
'mediatek,mt8173-smi-common',
'mediatek,mt8183-smi-common',
'mediatek,mt8192-smi-common']}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{'additionalItems': False,
'items': [{'const':
'mediatek,mt7623-smi-common'},
{'const':
'mediatek,mt2701-smi-common'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'}]},
'phandle': True,
'pinctrl-names': True,
'power-domains': {'maxItems': 1, 'minItems': 1},
'reg': {'maxItems': 1, 'minItems': 1},
'status': True},
'required': ['compatible',
'reg',
'power-domains',
'clocks',
'clock-names'],
'select': {'properties': {'compatible': {'contains': {'enum':
['mediatek,mt2701-smi-common',
'mediatek,mt2712-smi-common',
'mediatek,mt6779-smi-common',
'mediatek,mt7623-smi-common',
'mediatek,mt8173-smi-common',
'mediatek,mt8183-smi-common',
'mediatek,mt8192-smi-common']}}},
'required': ['compatible']},
'title': 'SMI (Smart Multimedia Interface) Common'}
From
schema: .../Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
=================================
Sorry, I didn't find a example of multi "if-then" in oneOf and don't
know how to fix this.
From [1], "allOf" looks also is allowed... In this case, both allOf and
anyOf have no warning when dt_binding_check. only oneOf has the warning
log above.
Any suggestion is appreciated.
[1]
https://elixir.bootlin.com/linux/v5.9-rc1/source/Documentation/devicetree/bindings/example-schema.yaml#L195
>
> Best regards,
> Krzysztof
>
> > - if: #gen1 hw
> > then:
> > use apb/smi/async clocks
> >
> > - if: #gen2 hw that has gals.
> > then:
> > use apb/smi/gals0/gals1 clocks
> > else: # gen2 hw that doesn't have gals.
> > use apb/smi clocks.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-10-12 12:12 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 7:06 [PATCH v3 00/24] MT8192 IOMMU support Yong Wu
2020-09-30 7:06 ` [PATCH v3 01/24] dt-bindings: iommu: mediatek: Convert IOMMU to DT schema Yong Wu
2020-10-02 10:58 ` Krzysztof Kozlowski
2020-10-02 11:07 ` Krzysztof Kozlowski
2020-10-06 4:26 ` Yong Wu
2020-10-12 17:08 ` Krzysztof Kozlowski
2020-09-30 7:06 ` [PATCH v3 02/24] dt-bindings: memory: mediatek: Convert SMI " Yong Wu
2020-10-02 11:04 ` Krzysztof Kozlowski
2020-10-02 11:08 ` Krzysztof Kozlowski
2020-10-06 4:27 ` Yong Wu
2020-10-06 7:15 ` Krzysztof Kozlowski
2020-10-10 6:18 ` Yong Wu
2020-10-12 7:18 ` Krzysztof Kozlowski
2020-10-12 12:01 ` Yong Wu [this message]
2020-10-12 13:26 ` Krzysztof Kozlowski
2020-09-30 7:06 ` [PATCH v3 03/24] dt-bindings: memory: mediatek: Add a common larb-port header file Yong Wu
2020-09-30 7:06 ` [PATCH v3 04/24] dt-bindings: memory: mediatek: Extend LARB_NR_MAX to 32 Yong Wu
2020-09-30 7:06 ` [PATCH v3 05/24] dt-bindings: memory: mediatek: Add domain definition Yong Wu
2020-09-30 7:06 ` [PATCH v3 06/24] dt-bindings: mediatek: Add binding for mt8192 IOMMU Yong Wu
2020-10-02 11:10 ` Krzysztof Kozlowski
2020-10-06 4:26 ` Yong Wu
2020-10-06 7:19 ` Krzysztof Kozlowski
2020-09-30 7:06 ` [PATCH v3 07/24] iommu/mediatek: Use the common mtk-smi-larb-port.h Yong Wu
2020-09-30 7:06 ` [PATCH v3 08/24] iommu/io-pgtable-arm-v7s: Use ias to check the valid iova in unmap Yong Wu
2020-10-23 11:17 ` Will Deacon
2020-10-26 7:49 ` Yong Wu
2020-09-30 7:06 ` [PATCH v3 09/24] iommu/io-pgtable-arm-v7s: Extend PA34 for MediaTek Yong Wu
2020-10-23 11:22 ` Will Deacon
2020-09-30 7:06 ` [PATCH v3 10/24] iommu/io-pgtable-arm-v7s: Add cfg as a param in some macros Yong Wu
2020-10-23 11:23 ` Will Deacon
2020-09-30 7:06 ` [PATCH v3 11/24] iommu/io-pgtable-arm-v7s: Quad lvl1 pgtable for MediaTek Yong Wu
2020-10-23 11:21 ` Will Deacon
2020-10-26 7:45 ` Yong Wu
2020-10-23 14:10 ` Robin Murphy
2020-10-26 7:41 ` Yong Wu
2020-10-26 11:35 ` Robin Murphy
2020-09-30 7:06 ` [PATCH v3 12/24] iommu/mediatek: Move hw_init into attach_device Yong Wu
2020-09-30 7:06 ` [PATCH v3 13/24] iommu/mediatek: Add device link for smi-common and m4u Yong Wu
2020-09-30 7:06 ` [PATCH v3 14/24] iommu/mediatek: Add pm runtime callback Yong Wu
2020-09-30 7:06 ` [PATCH v3 15/24] iommu/mediatek: Add power-domain operation Yong Wu
2020-09-30 7:06 ` [PATCH v3 16/24] iommu/mediatek: Add iova reserved function Yong Wu
2020-09-30 7:06 ` [PATCH v3 17/24] iommu/mediatek: Add single domain Yong Wu
2020-09-30 7:06 ` [PATCH v3 18/24] iommu/mediatek: Support master use iova over 32bit Yong Wu
2020-10-06 7:18 ` Krzysztof Kozlowski
2020-09-30 7:06 ` [PATCH v3 19/24] iommu/mediatek: Support up to 34bit iova in tlb flush Yong Wu
2020-09-30 7:06 ` [PATCH v3 20/24] iommu/mediatek: Support report iova 34bit translation fault in ISR Yong Wu
2020-09-30 7:06 ` [PATCH v3 21/24] iommu/mediatek: Add support for multi domain Yong Wu
2020-09-30 7:06 ` [PATCH v3 22/24] iommu/mediatek: Adjust the structure Yong Wu
2020-09-30 7:06 ` [PATCH v3 23/24] iommu/mediatek: Add mt8192 support Yong Wu
2020-09-30 7:06 ` [PATCH v3 24/24] memory: mtk-smi: " Yong Wu
2020-10-02 11:15 ` Krzysztof Kozlowski
2020-10-26 20:08 ` [PATCH v3 00/24] MT8192 IOMMU support Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1602504119.26323.54.camel@mhfsdcap03 \
--to=yong.wu@mediatek.com \
--cc=anan.sun@mediatek.com \
--cc=chao.hao@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=evgreen@chromium.org \
--cc=gregkh@google.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kernel-team@android.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=ming-fan.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@google.com \
--cc=will@kernel.org \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).