* [PATCH net-next] net: mtk_eth_soc: delete an unneeded variable
@ 2021-12-17 7:07 Dan Carpenter
2021-12-18 3:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-12-17 7:07 UTC (permalink / raw)
To: Felix Fietkau, René van Dorst
Cc: John Crispin, Sean Wang, Mark Lee, David S. Miller,
Jakub Kicinski, Matthias Brugger, netdev, linux-mediatek,
kernel-janitors
There is already an "int err" declared at the start of the function so
re-use that instead of declaring a shadow err variable.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index a068cf5c970f..bcb91b01e69f 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -2211,7 +2211,6 @@ static int mtk_open(struct net_device *dev)
/* we run 2 netdevs on the same dma ring so we only bring it up once */
if (!refcount_read(ð->dma_refcnt)) {
u32 gdm_config = MTK_GDMA_TO_PDMA;
- int err;
err = mtk_start_dma(eth);
if (err)
--
2.20.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: mtk_eth_soc: delete an unneeded variable
2021-12-17 7:07 [PATCH net-next] net: mtk_eth_soc: delete an unneeded variable Dan Carpenter
@ 2021-12-18 3:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-12-18 3:30 UTC (permalink / raw)
To: Dan Carpenter
Cc: nbd, opensource, john, sean.wang, Mark-MC.Lee, davem, kuba,
matthias.bgg, netdev, linux-mediatek, kernel-janitors
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 17 Dec 2021 10:07:35 +0300 you wrote:
> There is already an "int err" declared at the start of the function so
> re-use that instead of declaring a shadow err variable.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 -
> 1 file changed, 1 deletion(-)
Here is the summary with links:
- [net-next] net: mtk_eth_soc: delete an unneeded variable
https://git.kernel.org/netdev/net-next/c/ddfbe18da55c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-18 3:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-17 7:07 [PATCH net-next] net: mtk_eth_soc: delete an unneeded variable Dan Carpenter
2021-12-18 3:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).