* [PATCH] MIPS: ralink: mt7621: Fix soc_device introduction
@ 2020-03-28 10:27 Thomas Bogendoerfer
2020-03-28 12:06 ` René van Dorst
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Bogendoerfer @ 2020-03-28 10:27 UTC (permalink / raw)
To: John Crispin, Matthias Brugger, Sergio Paracuellos, linux-mips,
linux-kernel, linux-arm-kernel, linux-mediatek
Depending on selected SMP config options soc_device didn't get
initialised at all. With UP config vmlinux didn't link because
of missing soc bus.
Fixes: 71b9b5e0130d ("MIPS: ralink: mt7621: introduce 'soc_device' initialization")
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
---
arch/mips/ralink/Kconfig | 1 +
arch/mips/ralink/mt7621.c | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/mips/ralink/Kconfig b/arch/mips/ralink/Kconfig
index 94e9ce994494..35c2ebd8f094 100644
--- a/arch/mips/ralink/Kconfig
+++ b/arch/mips/ralink/Kconfig
@@ -52,6 +52,7 @@ choice
select COMMON_CLK
select CLKSRC_MIPS_GIC
select HAVE_PCI if PCI_MT7621
+ select SOC_BUS
endchoice
choice
diff --git a/arch/mips/ralink/mt7621.c b/arch/mips/ralink/mt7621.c
index 905460aeeb1f..0accb80db709 100644
--- a/arch/mips/ralink/mt7621.c
+++ b/arch/mips/ralink/mt7621.c
@@ -243,12 +243,12 @@ void prom_soc_init(struct ralink_soc_info *soc_info)
rt2880_pinmux_data = mt7621_pinmux_data;
+ soc_dev_init(soc_info, rev);
+
if (!register_cps_smp_ops())
return;
if (!register_cmp_smp_ops())
return;
if (!register_vsmp_smp_ops())
return;
-
- soc_dev_init(soc_info, rev);
}
--
2.16.4
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MIPS: ralink: mt7621: Fix soc_device introduction
2020-03-28 10:27 [PATCH] MIPS: ralink: mt7621: Fix soc_device introduction Thomas Bogendoerfer
@ 2020-03-28 12:06 ` René van Dorst
0 siblings, 0 replies; 2+ messages in thread
From: René van Dorst @ 2020-03-28 12:06 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: linux-mips, linux-kernel, Sergio Paracuellos, linux-mediatek,
John Crispin, Matthias Brugger, linux-arm-kernel
Hi Thomas,
Thanks for fixing the compile issue for me.
Now I can make a kernel again.
Tested-by: René van Dorst <opensource@vdorst.com>
Greats,
René
Quoting Thomas Bogendoerfer <tsbogend@alpha.franken.de>:
> Depending on selected SMP config options soc_device didn't get
> initialised at all. With UP config vmlinux didn't link because
> of missing soc bus.
>
> Fixes: 71b9b5e0130d ("MIPS: ralink: mt7621: introduce 'soc_device'
> initialization")
> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> ---
> arch/mips/ralink/Kconfig | 1 +
> arch/mips/ralink/mt7621.c | 4 ++--
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/ralink/Kconfig b/arch/mips/ralink/Kconfig
> index 94e9ce994494..35c2ebd8f094 100644
> --- a/arch/mips/ralink/Kconfig
> +++ b/arch/mips/ralink/Kconfig
> @@ -52,6 +52,7 @@ choice
> select COMMON_CLK
> select CLKSRC_MIPS_GIC
> select HAVE_PCI if PCI_MT7621
> + select SOC_BUS
> endchoice
>
> choice
> diff --git a/arch/mips/ralink/mt7621.c b/arch/mips/ralink/mt7621.c
> index 905460aeeb1f..0accb80db709 100644
> --- a/arch/mips/ralink/mt7621.c
> +++ b/arch/mips/ralink/mt7621.c
> @@ -243,12 +243,12 @@ void prom_soc_init(struct ralink_soc_info *soc_info)
>
> rt2880_pinmux_data = mt7621_pinmux_data;
>
> + soc_dev_init(soc_info, rev);
> +
> if (!register_cps_smp_ops())
> return;
> if (!register_cmp_smp_ops())
> return;
> if (!register_vsmp_smp_ops())
> return;
> -
> - soc_dev_init(soc_info, rev);
> }
> --
> 2.16.4
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-28 12:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-28 10:27 [PATCH] MIPS: ralink: mt7621: Fix soc_device introduction Thomas Bogendoerfer
2020-03-28 12:06 ` René van Dorst
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).