From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Fengping yu <fengping.yu@mediatek.com>
Cc: Yingjoe Chen <yingjoe.chen@mediatek.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
wsd_upstream@mediatek.com
Subject: Re: [PATCH v3] Add support for MediaTek keypad
Date: Mon, 6 Apr 2020 16:04:01 +0300 [thread overview]
Message-ID: <20200406130401.GV3676135@smile.fi.intel.com> (raw)
In-Reply-To: <20200405020114.14787-1-fengping.yu@mediatek.com>
On Sun, Apr 05, 2020 at 10:01:13AM +0800, Fengping yu wrote:
>
> This patchset add support to MediaTek matrix keypad.
Seems it has not addressed comments I gave.
>
> Change since V2:
> - remove extra space and redundant lines
> - update keypad devicetree document debounce time unit
> - change to use devm_platform_ioremap_resource() to simplify resource management
> - use bitmap to store and check keypad state
>
> fengping.yu (2):
> add dt-binding document for MediaTek Keypad
> add MediaTek keypad driver
>
> .../devicetree/bindings/input/mtk-kpd.txt | 61 +++++
> arch/arm64/configs/defconfig | 1 +
> drivers/input/keyboard/Kconfig | 7 +
> drivers/input/keyboard/Makefile | 1 +
> drivers/input/keyboard/mtk-kpd.c | 258 ++++++++++++++++++
> 5 files changed, 328 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.txt
> create mode 100644 drivers/input/keyboard/mtk-kpd.c
>
> --
> 2.18.0
>
--
With Best Regards,
Andy Shevchenko
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
prev parent reply other threads:[~2020-04-06 13:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-05 2:01 [PATCH v3] Add support for MediaTek keypad Fengping yu
2020-04-05 2:01 ` [PATCH v3 1/2] add dt-binding document for MediaTek Keypad Fengping yu
2020-04-06 15:21 ` Yingjoe Chen
2020-04-05 2:01 ` [PATCH v3 2/2] add MediaTek keypad driver Fengping yu
2020-04-06 13:04 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200406130401.GV3676135@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=fengping.yu@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=wsd_upstream@mediatek.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).